Re: [VOTE] Release Apache Cassandra 5.0-alpha1

2023-08-30 Thread J. D. Jordan
These are not compiled code. They are serialized dumps of bloom filter data.

> On Aug 28, 2023, at 9:58 PM, Justin Mclean  wrote:
> 
> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin


Re: [VOTE] Release Apache Cassandra 5.0-alpha1

2023-08-30 Thread Mick Semb Wever
https://www.apache.org/legal/src-headers.html#faq-exceptions




On Thu, 31 Aug 2023 at 00:01, Justin Mclean  wrote:

> Hi,
>
> > >> - It looks like there might be compiled code in the release? [1][2]
> > Non issue. Test resources.
>
> Test resources are not exempt - see [1]
>
> > >> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party
> files?
> >
> > Non issue. Doc files, or third-party files.
> > Dockerfiles fixed in CASSANDRA-18807
>
> If they are 3rd party files, then the license needs to be included in
> LICENSE. [2] (point 2) Document files still need a header. [3]
>
> Kind Regards,
> Justin
>
> 1. https://www.apache.org/legal/release-policy.html#source-packages
> 2. https://www.apache.org/legal/src-headers.html#3party
> 3. https://www.apache.org/legal/src-headers.html#faq-docs
>


Re: [VOTE] Release Apache Cassandra 5.0-alpha1

2023-08-30 Thread Justin Mclean
Hi,

> >> - It looks like there might be compiled code in the release? [1][2]
> Non issue. Test resources.

Test resources are not exempt - see [1]

> >> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files?
> 
> Non issue. Doc files, or third-party files.
> Dockerfiles fixed in CASSANDRA-18807

If they are 3rd party files, then the license needs to be included in LICENSE. 
[2] (point 2) Document files still need a header. [3]

Kind Regards,
Justin

1. https://www.apache.org/legal/release-policy.html#source-packages
2. https://www.apache.org/legal/src-headers.html#3party
3. https://www.apache.org/legal/src-headers.html#faq-docs


Re: [DISCUSSION] Dependency management in our first alpha release

2023-08-30 Thread Ekaterina Dimitrova
Thank you for your work and the prompt update, Maxim!

We seem to have a lazy consensus here so I suggest we continue all
operational discussions on the tickets themselves (not only the mentioned
ones but also any other dependency management tickets that might be open).
My understanding is that people are happy with some careful housekeeping in
the cassandra-5.0 branch while we are still not feature-complete.

Best regards,
Ekaterina

On Tue, 29 Aug 2023 at 16:23, Maxim Muzafarov  wrote:

> A few updates.
>
> We've posted a message to the user-list asking the question about the
> use of the metrics-reporter-config library to make sure we are on the
> safe side with the removal:
> https://lists.apache.org/thread/c4m3tc08zhd4d41zs05jcdkr3gjwlhno
>
> The issue for the `org.caffinitas.ohc:ohc-core-j8` is here, we'll try
> to handle it:
> https://issues.apache.org/jira/browse/CASSANDRA-18799
>
> On Fri, 25 Aug 2023 at 18:39, Ekaterina Dimitrova 
> wrote:
> >
> > Thank you all. We are going to continue with those tickets and related
> problems then.
> >
> > On Maxim's question:
> > "Do we need a separate issue for 'org.caffinitas.ohc:ohc-core-j8' or we
> should handle everything under [2]?"
> >
> > It depends on whether someone has the time to sit and deal with the
> complete list as soon as possible or we should do divide and conquer. It
> will also require some archeology and potential discussions with users in
> some cases, etc.
> >
> > Best regards,
> > Ekaterina
> >
> >
> >
> > On Wed, 23 Aug 2023 at 17:29, Abe Ratnofsky  wrote:
> >>
> >> > I also want to hear if Abe still has concerns about not following
> deprecation process here.
> >>
> >> I support removing the library on an expedited schedule, rather than
> waiting for a full major of deprecation. We still have a large surface for
> metrics integrations, and users who depended on metrics-reporter-config
> will have a path forward if they need similar functionality.
> >>
> >> On Aug 23, 2023, at 07:28, Ekaterina Dimitrova 
> wrote:
> >>
> >> I also want to hear if Abe still has concerns about not following
> deprecation process here.
>


Re: [VOTE] Release Apache Cassandra 5.0-alpha1

2023-08-30 Thread Benedict
Yes, my understanding is that the number is not itself copyrightable. We simply 
attribute in the source code as a courtesy and for future readers.

If you are concerned we can loop in legal.

> On 30 Aug 2023, at 12:29, Mick Semb Wever  wrote:
> 
> 
>> 
>>> - It looks like there might be compiled code in the release? [1][2]
> 
> 
> Non issue. Test resources.
> 
> 
>>> - LICENSE is missing some 3rd party code license information [5] This 
>>> contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under 
>>> MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from 
>>> MagnetoDB under ALv2.
> 
> 
> CASSANDRA-18807
> 
> 
>>> - LICENSE has no mention of 3rd party CRC code in [10]
>>> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]
> 
> 
> This comes down to using an int number from Philip Koopman's CRC work.
> `private static final int CRC24_POLY = 0x1974F0B;`
> 
> It was questioned whether a number can be copyrighted, in which case
> we would not be including third-party work here. The code comment
> explains this too.
> 
> Benedict?
> 
> 
>>> - LICENSE also doesn't mention this file [9]
> 
> 
> CASSANDRA-18807
> 
> 
>>> - In LICENSE LongTimSort.java incorrectly mentions two different copyright 
>>> owners
>>> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as 
>>> AbstractIterator.java
> 
> 
> CASSANDRA-18807
> 
> 
>>> - NOTICE seems OK but may also be missing some things due to missing 3rd 
>>> party code in LICENSE under ALv2
> 
> 
> No additions required.
> 
> 
>>> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files?
> 
> 
> Non issue. Doc files, or third-party files.
> Dockerfiles fixed in CASSANDRA-18807
> 
> 
> 
>> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
>> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
>> 3. ./doc/modules/cassandra/examples/BASH/*.sh
>> 4. ./pylib/Dockerfile.ubuntu.*
>> 5. ./lib/cassandra-driver-internal-only-3.25.0.zip
>> 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py
>> 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py
>> 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c
>> 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java
>> 10. ./src/java/org/apache/cassandra/net/Crc.java
>> 11. https://www.apache.org/legal/resolved.html#cc-by


Re: [VOTE] Release Apache Cassandra 5.0-alpha1

2023-08-30 Thread Mick Semb Wever
>> - It looks like there might be compiled code in the release? [1][2]


Non issue. Test resources.


>> - LICENSE is missing some 3rd party code license information [5] This 
>> contains code "Copyright DataStax, Inc." under ALv2, python-smhasher under 
>> MIT, OrderedDict under MIT (copyright Raymond Hettinger) and code from 
>> MagnetoDB under ALv2.


CASSANDRA-18807


>> - LICENSE has no mention of 3rd party CRC code in [10]
>> - Note that any code under CC 4.0 is incompatible with the ALv2. [11]


This comes down to using an int number from Philip Koopman's CRC work.
`private static final int CRC24_POLY = 0x1974F0B;`

It was questioned whether a number can be copyrighted, in which case
we would not be including third-party work here. The code comment
explains this too.

Benedict?


>> - LICENSE also doesn't mention this file [9]


CASSANDRA-18807


>> - In LICENSE LongTimSort.java incorrectly mentions two different copyright 
>> owners
>> - In LICENSE, AbstractGuavaIterator.java is incorrectly mentioned as 
>> AbstractIterator.java


CASSANDRA-18807


>> - NOTICE seems OK but may also be missing some things due to missing 3rd 
>> party code in LICENSE under ALv2


No additions required.


>> - Files are missing ASF headers [3][4][6][7][8] are these 3rd party files?


Non issue. Doc files, or third-party files.
Dockerfiles fixed in CASSANDRA-18807



> 1../test/data/serialization/3.0/utils.BloomFilter1000.bin
> 2. ./test/data/serialization/4.0/utils.BloomFilter1000.bin
> 3. ./doc/modules/cassandra/examples/BASH/*.sh
> 4. ./pylib/Dockerfile.ubuntu.*
> 5. ./lib/cassandra-driver-internal-only-3.25.0.zip
> 6. ./lib/cassandra-driver-3.25.0/cassandra/murmur3.py
> 7. ./lib/cassandra-driver-3.25.0/cassandra/io/asyncioreactor.py
> 8 ./lib/cassandra-driver-3.25.0/cassandra/io/libevwrapper.c
> 9. ./tools/fqltool/src/org/apache/cassandra/fqltool/commands/Dump.java
> 10. ./src/java/org/apache/cassandra/net/Crc.java
> 11. https://www.apache.org/legal/resolved.html#cc-by