Re: [VOTE] Accept java-driver

2023-10-05 Thread Jeremiah Jordan
 I think this is covered by the grant agreement?

https://www.apache.org/licenses/software-grant-template.pdf

2. Licensor represents that, to Licensor's knowledge, Licensor is
legally entitled to grant the above license. Licensor agrees to notify
the Foundation of any facts or circumstances of which Licensor becomes
aware and which makes or would make Licensor's representations in this
License Agreement inaccurate in any respect.



On Oct 5, 2023 at 4:35:08 AM, Benedict  wrote:

> Surely it needs to be shared with the foundation and the PMC so we can
> verify? Or at least have ASF legal confirm they have received and are
> satisfied with the tarball? It certainly can’t be kept private to DS,
> AFAICT.
>
> Of course it shouldn’t be shared publicly but not sure how PMC can fulfil
> its verification function here without it.
>
> On 5 Oct 2023, at 10:23, Mick Semb Wever  wrote:
>
> 
>
>.
>
> On Tue, 3 Oct 2023 at 13:25, Josh McKenzie  wrote:
>
>> I see now this will likely be instead apache/cassandra-java-driver
>>
>> I was wondering about that. apache/java-driver seemed pretty broad. :)
>>
>> From the linked page:
>> Check that all active committers have a signed CLA on record. TODO –
>> attach list
>> I've been part of these discussions and work so am familiar with the
>> status of it (as well as guidance and clearance from the foundation re:
>> folks we couldn't reach) - but might be worthwhile to link to the sheet or
>> perhaps instead provide a summary of the 49 java contributors, their CLA
>> signing status, attempts to reach out, etc for other PMC members that
>> weren't actively involved back when we were working through it.
>>
>
>
> We have a spreadsheet with this information, and the tarball of all the
> signed CLAs.
> The tarball we should keep private to DS, but know that we have it for
> governance's sake.
>
> I've attached the spreadsheet to the CEP confluence page.
>
>


Re: [VOTE] Accept java-driver

2023-10-05 Thread Benjamin Lerer
+1

Le jeu. 5 oct. 2023 à 13:46, Aleksey Yeshchenko  a
écrit :

> +1
>
> On 5 Oct 2023, at 10:35, Benedict  wrote:
>
> Surely it needs to be shared with the foundation and the PMC so we can
> verify? Or at least have ASF legal confirm they have received and are
> satisfied with the tarball? It certainly can’t be kept private to DS,
> AFAICT.
>
> Of course it shouldn’t be shared publicly but not sure how PMC can fulfil
> its verification function here without it.
>
> On 5 Oct 2023, at 10:23, Mick Semb Wever  wrote:
>
> 
>
>.
>
> On Tue, 3 Oct 2023 at 13:25, Josh McKenzie  wrote:
>
>> I see now this will likely be instead apache/cassandra-java-driver
>>
>> I was wondering about that. apache/java-driver seemed pretty broad. :)
>>
>> From the linked page:
>> Check that all active committers have a signed CLA on record. TODO –
>> attach list
>> I've been part of these discussions and work so am familiar with the
>> status of it (as well as guidance and clearance from the foundation re:
>> folks we couldn't reach) - but might be worthwhile to link to the sheet or
>> perhaps instead provide a summary of the 49 java contributors, their CLA
>> signing status, attempts to reach out, etc for other PMC members that
>> weren't actively involved back when we were working through it.
>>
>
>
> We have a spreadsheet with this information, and the tarball of all the
> signed CLAs.
> The tarball we should keep private to DS, but know that we have it for
> governance's sake.
>
> I've attached the spreadsheet to the CEP confluence page.
>
>
>


[REVIEW REQUEST] Replace CRC32 with more efficient CRC32C for internode messaging

2023-10-05 Thread Maxim Muzafarov
Hello everyone,


This message is both a review request and my attempt to share with you
some of the benchmark results related to replacing the CRC32 algorithm
for the internode messaging protocol.

When a new connection is initiated between nodes, the corresponding
connection channel is configured with one of the frame encoder/decoder
pairs based on how a user has set a cluster YAML configuration. The
frame encoder is configured on the sender side, and the frame decoder
is configured on the receiver side. They use the CRC24 for frame
header protection and the CRC32 for frame payload protection.

Since we've dropped support for the jdk8 [1] in the upcoming release,
it's now possible to use the more efficient CRC32C algorithm, which
ships with jdk11 by default, without any additional overhead for us. I
have prepared a patch [4] to replace the CRC32 algorithm with the more
efficient CRC32C for frames payload. I've prototyped a new solution
and done some research into the reasons for dropping both the CRC24
and the CRC32, but replacing only the CRC32 for payload and keeping
the CRC24 as it is seems to be more efficient for us, and simplifies
the whole solution (see [2] for details).

Benchmarks seem to point us in the right direction (see [3]).

Decode

CRC  avgt4   382.764 ±  75.327  ns/op
CRC32C  avgt4   272.388 ±  63.618  ns/op

Encode

CRC  avgt4   382.130 ±  12.318  ns/op
CRC32C  avgt4   311.646 ±  17.114  ns/op


So, if anyone is interested in these changes and can verify them, I
would be happy to help and answer any questions.


[1] https://issues.apache.org/jira/browse/CASSANDRA-18255
[2] 
https://issues.apache.org/jira/browse/CASSANDRA-16360?focusedCommentId=17771183=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17771183
[3] https://gist.github.com/Mmuzaf/a7ac6f5759c16ee24683856704e7c941
[4] https://github.com/apache/cassandra/pull/2647


Re: [VOTE] Accept java-driver

2023-10-05 Thread Aleksey Yeshchenko
+1

> On 5 Oct 2023, at 10:35, Benedict  wrote:
> 
> Surely it needs to be shared with the foundation and the PMC so we can 
> verify? Or at least have ASF legal confirm they have received and are 
> satisfied with the tarball? It certainly can’t be kept private to DS, AFAICT.
> 
> Of course it shouldn’t be shared publicly but not sure how PMC can fulfil its 
> verification function here without it.
> 
>> On 5 Oct 2023, at 10:23, Mick Semb Wever  wrote:
>> 
>> 
>> 
>>.
>> 
>> On Tue, 3 Oct 2023 at 13:25, Josh McKenzie > > wrote:
 I see now this will likely be instead apache/cassandra-java-driver
>>> I was wondering about that. apache/java-driver seemed pretty broad. :)
>>> 
>>> From the linked page:
>>> Check that all active committers have a signed CLA on record. TODO – attach 
>>> list
>>> I've been part of these discussions and work so am familiar with the status 
>>> of it (as well as guidance and clearance from the foundation re: folks we 
>>> couldn't reach) - but might be worthwhile to link to the sheet or perhaps 
>>> instead provide a summary of the 49 java contributors, their CLA signing 
>>> status, attempts to reach out, etc for other PMC members that weren't 
>>> actively involved back when we were working through it.
>> 
>> 
>> 
>> We have a spreadsheet with this information, and the tarball of all the 
>> signed CLAs.
>> The tarball we should keep private to DS, but know that we have it for 
>> governance's sake.
>> 
>> I've attached the spreadsheet to the CEP confluence page.



Re: [VOTE] Accept java-driver

2023-10-05 Thread Benedict
Surely it needs to be shared with the foundation and the PMC so we can verify? Or at least have ASF legal confirm they have received and are satisfied with the tarball? It certainly can’t be kept private to DS, AFAICT.Of course it shouldn’t be shared publicly but not sure how PMC can fulfil its verification function here without it.On 5 Oct 2023, at 10:23, Mick Semb Wever  wrote:   .On Tue, 3 Oct 2023 at 13:25, Josh McKenzie  wrote:I see now this will likely be instead apache/cassandra-java-driverI was wondering about that. apache/java-driver seemed pretty broad. :)From the linked page:Check that all active committers have a signed CLA on record. TODO – attach listI've been part of these discussions and work so am familiar with the status of it (as well as guidance and clearance from the foundation re: folks we couldn't reach) - but might be worthwhile to link to the sheet or perhaps instead provide a summary of the 49 java contributors, their CLA signing status, attempts to reach out, etc for other PMC members that weren't actively involved back when we were working through it.We have a spreadsheet with this information, and the tarball of all the signed CLAs.The tarball we should keep private to DS, but know that we have it for governance's sake.I've attached the spreadsheet to the CEP confluence page.


Re: [VOTE] Accept java-driver

2023-10-05 Thread Mick Semb Wever
   .

On Tue, 3 Oct 2023 at 13:25, Josh McKenzie  wrote:

> I see now this will likely be instead apache/cassandra-java-driver
>
> I was wondering about that. apache/java-driver seemed pretty broad. :)
>
> From the linked page:
> Check that all active committers have a signed CLA on record. TODO –
> attach list
> I've been part of these discussions and work so am familiar with the
> status of it (as well as guidance and clearance from the foundation re:
> folks we couldn't reach) - but might be worthwhile to link to the sheet or
> perhaps instead provide a summary of the 49 java contributors, their CLA
> signing status, attempts to reach out, etc for other PMC members that
> weren't actively involved back when we were working through it.
>


We have a spreadsheet with this information, and the tarball of all the
signed CLAs.
The tarball we should keep private to DS, but know that we have it for
governance's sake.

I've attached the spreadsheet to the CEP confluence page.