Re: findbugs

2012-07-30 Thread Zoltan Farkas
Findbugs can be customized with a exclude filter to exclude from checking 
issues that produce a high number of false positives.

For the rest of false positives @suppresswarnings annotation can be used.

I suggest Understanding the issue Findbugs highlights before suppressing it, I 
did see devs being lazy and causing production outages...

There is no good reason for not running Findbugs as part of the build.

cheers.

--z

On Jul 30, 2012, at 10:53 AM, Brandon Williams dri...@gmail.com wrote:

 On Mon, Jul 30, 2012 at 9:52 AM, Jonathan Ellis jbel...@gmail.com wrote:
 Is Jenkins smart enough to be able to say, I know we had X findbugs
 warnings previously, which are known to be false positives, but now
 there are X+1 ?
 
 In my experience, jenkins hasn't even been smart enough to build
 cassandra in a couple of years.
 
 -Brandon


Re: findbugs

2012-07-23 Thread Zoltan Farkas
In general, I prefer integrating findbugs into the build process and fail the 
build if issues are found. I am a strong believer in this approach, increases 
the quality of the project significantly.

Enforcing coding style and complexity rules is one step further...

Cheers

--z

On Jul 23, 2012, at 3:39 AM, Radim Kolar h...@filez.com wrote:

 The line numbers here don't appear to match with trunk.
 
 you are right, it was from old trunk 415 commits old. It was just demo of 
 findbugs, for serious use developers should install findbugs maven plugin or 
 eclipse plugin (preferred).