Re: [DISCUSSION] CASSANDRA-18772 - removal of commons-codec on trunk

[Maxim Muzafarov]

There are a few other dependencies that are probably no longer used
and can be removed. I'm not talking about the netty-related
dependencies, because they seem to be used transitively and required
to be in the classpath, but the others are good candidates, I think.

For example, org.caffinitas.ohc:ohc-core-j8 seems to be related only
to jdk8 only which we have moved away from. I've removed it locally
and the sources still compile without it.

I've created an issue for that:
https://issues.apache.org/jira/browse/CASSANDRA-18777

On Thu, 17 Aug 2023 at 19:43, Mick Semb Wever  wrote:
>
> >
> > I propose we remove commons-codec on trunk.
> > The only usage I found was from CASSANDRA-12790 - Support InfluxDb metrics 
> > reporter configuration, which relied on commons-codec and 
> > metrics-reporter-config, which will be removed as part of CASSANDRA-18743.
> > The only question is whether we can remove those two dependencies on trunk, 
> > considering it is 5.1, or do we need to wait until 6.0.
>
>
>
> Dependencies are not an API (where they're not exposed/leaked), +1 on 
> removing it in 5.0 (when 18743 lands).  If users/operators need it back on 
> the classpath it is for reasons outside of our API concerns.

Re: [DISCUSSION] CASSANDRA-18772 - removal of commons-codec on trunk

[Mick Semb Wever]

>
> I propose we remove commons-codec on trunk.
> The only usage I found was from CASSANDRA-12790 - Support InfluxDb
metrics reporter configuration, which relied on commons-codec and
metrics-reporter-config, which will be removed as part of CASSANDRA-18743.
> The only question is whether we can remove those two dependencies on
trunk, considering it is 5.1, or do we need to wait until 6.0.



Dependencies are not an API (where they're not exposed/leaked), +1 on
removing it in 5.0 (when 18743 lands).  If users/operators need it back on
the classpath it is for reasons outside of our API concerns.

Re: [DISCUSSION] CASSANDRA-18772 - removal of commons-codec on trunk

[Miklosovic, Stefan]

I would remove it all in 5.0 but that's just me. I do not think that the 
deprecation is a must and it is just unnecessary exercise and we are just red 
taping here.

Major releases are good for dropping the "baggage" like this. Do we really want 
to wait until 6.0 is out to cut off the dead weight?


From: Ekaterina Dimitrova 
Sent: Thursday, August 17, 2023 19:10
To: dev
Subject: [DISCUSSION] CASSANDRA-18772 - removal of commons-codec on trunk

NetApp Security WARNING: This is an external email. Do not click links or open 
attachments unless you recognize the sender and know the content is safe.



Hi everyone,

I propose we remove commons-codec on trunk.
The only usage I found was from 
CASSANDRA-12790<https://issues.apache.org/jira/browse/CASSANDRA-12790> - 
Support InfluxDb metrics reporter configuration, which relied on commons-codec 
and metrics-reporter-config, which will be removed as part of CASSANDRA-18743.
The only question is whether we can remove those two dependencies on trunk, 
considering it is 5.1, or do we need to wait until 6.0.

Best regards,
Ekaterina

Re: [DISCUSSION] CASSANDRA-18772 - removal of commons-codec on trunk

[Abe Ratnofsky]

If we're going to do bulk dependency pruning, we should minimize the number of 
deprecation plans that users need to prepare for. There will likely be a few 
more dependencies we clean up around 5.0, so sticking with 5.0 deprecation and 
6.0 removal for all of them would likely make our users' lives easier.

If there's new information about a security issue in a dependency and no clear 
alternative, I'd be open to an expedited removal plan as an exception, but that 
would be on a case-by-case basis.

> On Aug 17, 2023, at 10:10 AM, Ekaterina Dimitrova  
> wrote:
> 
> Hi everyone,
> 
> I propose we remove commons-codec on trunk.
> The only usage I found was from CASSANDRA-12790 
>  - Support InfluxDb 
> metrics reporter configuration, which relied on commons-codec and 
> metrics-reporter-config, which will be removed as part of CASSANDRA-18743. 
> The only question is whether we can remove those two dependencies on trunk, 
> considering it is 5.1, or do we need to wait until 6.0. 
> 
> Best regards,
> Ekaterina

[DISCUSSION] CASSANDRA-18772 - removal of commons-codec on trunk

[Ekaterina Dimitrova]

Hi everyone,

I propose we remove commons-codec on trunk.
The only usage I found was from CASSANDRA-12790
* - *Support
InfluxDb metrics reporter configuration, which relied on commons-codec and
metrics-reporter-config, which will be removed as part of CASSANDRA-18743.
The only question is whether we can remove those two dependencies on trunk,
considering it is 5.1, or do we need to wait until 6.0.

Best regards,
Ekaterina