Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

As there were no objections from the community I closed CASSANDRA-18701

On Thu, 27 Jul 2023 at 16:22, Mick Semb Wever  wrote:

>
>
>
>> FYI,  devbranch (pre-commit) on ci-cassandra.a.o is hardcoded to build on
>> jdk8 and jdk11
>> so it's not going to work with trunk based patches…
>>
>> I'll review any patches to fix this, but otherwise focus is
>> on CASSANDRA-18594 where a standalone jenkinsfile avoids this problem
>> altogether.
>>
>
>
> To clarify this, devbranch was hardcoded to a matrix with jdk8 and jdk11,
> with a hack in place to skip jdk11 for <4 branches (at run time).
> Dropping jdk8 was not the cause of devbranch no longer working, it's just
> not built for it.  These limitations of devbranch (and cassandra-builds)
> are being addressed as part of the repeatable ci work.  Note, this does not
> affect post-commit ci-cassandra.a.o pipelines (which already is testing
> jdk11+17 on trunk).
>
> So… I would like to suggest we abandon CASSANDRA-18701 and we collectively
> focus on the intended replacement for this, which is the in-tree scripts
> and 18594.  (It might possibly come as part of CASSANDRA-18665 which is an
> intermediate ticket).
>
> Stefan and Maxim, I think this impacts the two of you most over the next
> few weeks.  In the meantime I suggest using the in-tree scripts as much as
> possible, using individual stage jobs under the patches tab in
> ci-cassandra.a.o (just ignoring the jdk8 axis failures), and asking others
> for final pre-commit ci runs on circleci.  We're close.
>
>
>

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Mick Semb Wever]

> FYI,  devbranch (pre-commit) on ci-cassandra.a.o is hardcoded to build on
> jdk8 and jdk11
> so it's not going to work with trunk based patches…
>
> I'll review any patches to fix this, but otherwise focus is
> on CASSANDRA-18594 where a standalone jenkinsfile avoids this problem
> altogether.
>


To clarify this, devbranch was hardcoded to a matrix with jdk8 and jdk11,
with a hack in place to skip jdk11 for <4 branches (at run time).
Dropping jdk8 was not the cause of devbranch no longer working, it's just
not built for it.  These limitations of devbranch (and cassandra-builds)
are being addressed as part of the repeatable ci work.  Note, this does not
affect post-commit ci-cassandra.a.o pipelines (which already is testing
jdk11+17 on trunk).

So… I would like to suggest we abandon CASSANDRA-18701 and we collectively
focus on the intended replacement for this, which is the in-tree scripts
and 18594.  (It might possibly come as part of CASSANDRA-18665 which is an
intermediate ticket).

Stefan and Maxim, I think this impacts the two of you most over the next
few weeks.  In the meantime I suggest using the in-tree scripts as much as
possible, using individual stage jobs under the patches tab in
ci-cassandra.a.o (just ignoring the jdk8 axis failures), and asking others
for final pre-commit ci runs on circleci.  We're close.

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

CASSANDRA-18701

On Thu, 27 Jul 2023 at 13:10, Ekaterina Dimitrova 
wrote:

> It seems there was some misunderstanding as dev-branch was on the list of
> tasks to be fixed here.
>
> Anyway, I will work on a patch as I do not want to block people who are
> using it, thanks. My understanding from a private conversation is that
> CASSANDRA-18594 might land in August-September so I don’t think we should
> wait for it.
> Apologize for any inconvenience caused, it was definitely not my intention
>
> On Thu, 27 Jul 2023 at 12:49, Mick Semb Wever  wrote:
>
>>
>>
>>
>> > I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
>> systems today.
>> > This requires numerous patches in a few repos so you will be seeing
>> more failures in CI throughout the day today, but it shouldn’t be anything
>> more 爛 than what we have listed in the table of failures in
>> CASSANDRA-16895’s description. I will be applying the fixes one by one
>> today.
>> > I will keep you posted with updates. Also, please, do let me know if
>> you have any questions or concerns.
>>
>>
>>
>> FYI,  devbranch (pre-commit) on ci-cassandra.a.o is hardcoded to build on
>> jdk8 and jdk11
>> so it's not going to work with trunk based patches…
>>
>> I'll review any patches to fix this, but otherwise focus is
>> on CASSANDRA-18594 where a standalone jenkinsfile avoids this problem
>> altogether.
>>
>>

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

It seems there was some misunderstanding as dev-branch was on the list of
tasks to be fixed here.

Anyway, I will work on a patch as I do not want to block people who are
using it, thanks. My understanding from a private conversation is that
CASSANDRA-18594 might land in August-September so I don’t think we should
wait for it.
Apologize for any inconvenience caused, it was definitely not my intention

On Thu, 27 Jul 2023 at 12:49, Mick Semb Wever  wrote:

>
>
>
> > I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
> systems today.
> > This requires numerous patches in a few repos so you will be seeing more
> failures in CI throughout the day today, but it shouldn’t be anything more
> 爛 than what we have listed in the table of failures in CASSANDRA-16895’s
> description. I will be applying the fixes one by one today.
> > I will keep you posted with updates. Also, please, do let me know if you
> have any questions or concerns.
>
>
>
> FYI,  devbranch (pre-commit) on ci-cassandra.a.o is hardcoded to build on
> jdk8 and jdk11
> so it's not going to work with trunk based patches…
>
> I'll review any patches to fix this, but otherwise focus is
> on CASSANDRA-18594 where a standalone jenkinsfile avoids this problem
> altogether.
>
>

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Mick Semb Wever]

> I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
systems today.
> This requires numerous patches in a few repos so you will be seeing more
failures in CI throughout the day today, but it shouldn’t be anything more
爛 than what we have listed in the table of failures in CASSANDRA-16895’s
description. I will be applying the fixes one by one today.
> I will keep you posted with updates. Also, please, do let me know if you
have any questions or concerns.



FYI,  devbranch (pre-commit) on ci-cassandra.a.o is hardcoded to build on
jdk8 and jdk11
so it's not going to work with trunk based patches…

I'll review any patches to fix this, but otherwise focus is
on CASSANDRA-18594 where a standalone jenkinsfile avoids this problem
altogether.

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Jeremiah Jordan]

 Yes.  Great to get this work merged.  Thanks to everyone who worked on it
and to Ekaterina for leading the charge!

-Jeremiah

On Jul 24, 2023 at 9:27:10 PM, C. Scott Andreas 
wrote:

> Ekaterina, thank you for spearheading JDK17 support for Apache Cassandra!
> Exciting to get to this point.
>
> - Scott
>
> On Jul 24, 2023, at 7:11 PM, Ekaterina Dimitrova 
> wrote:
>
> 
> Good news!
> After run #1638-39 you should not see anything else failing than
> SSLFactory test class. This known issue will be fixed by potentially adding
>  bounty castle. More info in CASSANDRA-17992 and this netty PR:
> https://github.com/netty/netty/issues/10317
> We can probably mark the test class with @Ignore, but knowing how easily
> those are forgotten and 17992 being already in review, I prefer not to do
> it.
>
> The only new failure I found in #1636 is a rare flaky test we never saw in
> CircleCI before. (unit tests were running only there; they were not enabled
> in Jenkins until we cleaned them ). Ticket already opened -
> CASSANDRA-18685 
>
> Last but not least, eclipse-warnings is already removed (it doesn't work
> with post JDK8 versions), but the new static analysis from Checker
> Framework is already in review and soon to land in trunk - CASSANDRA-18239
>
> As usual - if you have any questions or concerns, please do let me know.
> Last but not least - thank you to everyone who helped in one way or
> another with this effort!!
>
> On Mon, 24 Jul 2023 at 16:37, Ekaterina Dimitrova 
> wrote:
>
>> Ninja fix was required for Jenkins, new build started #1636
>>
>> On Mon, 24 Jul 2023 at 15:42, Ekaterina Dimitrova 
>> wrote:
>>
>>> Done!
>>>
>>> All commits from 18255 are in.
>>> The first run to monitor will be in Jenkins #1635
>>>
>>> There will be still fixes to be applied for some unit and in-jvm tests
>>> that were pending on the drop but I will do it when I see Jenkins kicking
>>> in this run properly.  (Which are those can be seen in CASSANDRA-16895,
>>> there is a table in its description)
>>>
>>> I will keep you posted on any new developments.
>>>
>>>
>>> On Mon, 24 Jul 2023 at 14:52, Ekaterina Dimitrova 
>>> wrote:
>>>
 Starting commits for 18255. Please put on hold any trunk commits. I
 will let you know when it is done. Thank you

 On Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova <
 e.dimitr...@gmail.com> wrote:

> Hi everyone,
>
> Happy Monday!
>
> I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
> systems today.
> This requires numerous patches in a few repos so you will be seeing
> more failures in CI throughout the day today, but it shouldn’t be anything
> more 爛 than what we have listed in the table of failures in
> CASSANDRA-16895’s description. I will be applying the fixes one by one
> today.
> I will keep you posted with updates. Also, please, do let me know if
> you have any questions or concerns.
>
> Best regards,
> Ekaterina
>
>
>

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[C. Scott Andreas]

Ekaterina, thank you for spearheading JDK17 support for Apache Cassandra! Exciting to get to this point.- ScottOn Jul 24, 2023, at 7:11 PM, Ekaterina Dimitrova  wrote:Good news! After run #1638-39 you should not see anything else failing than SSLFactory test class. This known issue will be fixed by potentially adding  bounty castle. More info in CASSANDRA-17992 and this netty PR:https://github.com/netty/netty/issues/10317We can probably mark the test class with @Ignore, but knowing how easily those are forgotten and 17992 being already in review, I prefer not to do it. The only new failure I found in #1636 is a rare flaky test we never saw in CircleCI before. (unit tests were running only there; they were not enabled in Jenkins until we cleaned them ). Ticket already opened -  CASSANDRA-18685Last but not least, eclipse-warnings is already removed (it doesn't work with post JDK8 versions), but the new static analysis from Checker Framework is already in review and soon to land in trunk - CASSANDRA-18239As usual - if you have any questions or concerns, please do let me know.Last but not least - thank you to everyone who helped in one way or another with this effort!!On Mon, 24 Jul 2023 at 16:37, Ekaterina Dimitrova  wrote:Ninja fix was required for Jenkins, new build started #1636On Mon, 24 Jul 2023 at 15:42, Ekaterina Dimitrova  wrote:Done!All commits from 18255 are in.The first run to monitor will be in Jenkins #1635There will be still fixes to be applied for some unit and in-jvm tests that were pending on the drop but I will do it when I see Jenkins kicking in this run properly.  (Which are those can be seen in CASSANDRA-16895, there is a table in its description)I will keep you posted on any new developments.On Mon, 24 Jul 2023 at 14:52, Ekaterina Dimitrova  wrote:Starting commits for 18255. Please put on hold any trunk commits. I will let you know when it is done. Thank youOn Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova  wrote:Hi everyone,Happy Monday! I am working on dropping JDK 8 and adding JDK17 on trunk in both CI systems today.This requires numerous patches in a few repos so you will be seeing more failures in CI throughout the day today, but it shouldn’t be anything more 爛 than what we have listed in the table of failures in CASSANDRA-16895’s description. I will be applying the fixes one by one today.I will keep you posted with updates. Also, please, do let me know if you have any questions or concerns.Best regards,Ekaterina

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

Good news!
After run #1638-39 you should not see anything else failing than SSLFactory
test class. This known issue will be fixed by potentially adding  bounty
castle. More info in CASSANDRA-17992 and this netty PR:
https://github.com/netty/netty/issues/10317
We can probably mark the test class with @Ignore, but knowing how easily
those are forgotten and 17992 being already in review, I prefer not to do
it.

The only new failure I found in #1636 is a rare flaky test we never saw in
CircleCI before. (unit tests were running only there; they were not enabled
in Jenkins until we cleaned them ). Ticket already opened -  CASSANDRA-18685


Last but not least, eclipse-warnings is already removed (it doesn't work
with post JDK8 versions), but the new static analysis from Checker
Framework is already in review and soon to land in trunk - CASSANDRA-18239

As usual - if you have any questions or concerns, please do let me know.
Last but not least - thank you to everyone who helped in one way or another
with this effort!!

On Mon, 24 Jul 2023 at 16:37, Ekaterina Dimitrova 
wrote:

> Ninja fix was required for Jenkins, new build started #1636
>
> On Mon, 24 Jul 2023 at 15:42, Ekaterina Dimitrova 
> wrote:
>
>> Done!
>>
>> All commits from 18255 are in.
>> The first run to monitor will be in Jenkins #1635
>>
>> There will be still fixes to be applied for some unit and in-jvm tests
>> that were pending on the drop but I will do it when I see Jenkins kicking
>> in this run properly.  (Which are those can be seen in CASSANDRA-16895,
>> there is a table in its description)
>>
>> I will keep you posted on any new developments.
>>
>>
>> On Mon, 24 Jul 2023 at 14:52, Ekaterina Dimitrova 
>> wrote:
>>
>>> Starting commits for 18255. Please put on hold any trunk commits. I will
>>> let you know when it is done. Thank you
>>>
>>> On Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova 
>>> wrote:
>>>
 Hi everyone,

 Happy Monday!

 I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
 systems today.
 This requires numerous patches in a few repos so you will be seeing
 more failures in CI throughout the day today, but it shouldn’t be anything
 more 爛 than what we have listed in the table of failures in
 CASSANDRA-16895’s description. I will be applying the fixes one by one
 today.
 I will keep you posted with updates. Also, please, do let me know if
 you have any questions or concerns.

 Best regards,
 Ekaterina

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

Ninja fix was required for Jenkins, new build started #1636

On Mon, 24 Jul 2023 at 15:42, Ekaterina Dimitrova 
wrote:

> Done!
>
> All commits from 18255 are in.
> The first run to monitor will be in Jenkins #1635
>
> There will be still fixes to be applied for some unit and in-jvm tests
> that were pending on the drop but I will do it when I see Jenkins kicking
> in this run properly.  (Which are those can be seen in CASSANDRA-16895,
> there is a table in its description)
>
> I will keep you posted on any new developments.
>
>
> On Mon, 24 Jul 2023 at 14:52, Ekaterina Dimitrova 
> wrote:
>
>> Starting commits for 18255. Please put on hold any trunk commits. I will
>> let you know when it is done. Thank you
>>
>> On Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova 
>> wrote:
>>
>>> Hi everyone,
>>>
>>> Happy Monday!
>>>
>>> I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
>>> systems today.
>>> This requires numerous patches in a few repos so you will be seeing more
>>> failures in CI throughout the day today, but it shouldn’t be anything more
>>> 爛 than what we have listed in the table of failures in CASSANDRA-16895’s
>>> description. I will be applying the fixes one by one today.
>>> I will keep you posted with updates. Also, please, do let me know if you
>>> have any questions or concerns.
>>>
>>> Best regards,
>>> Ekaterina
>>>
>>>
>>>

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

Done!

All commits from 18255 are in.
The first run to monitor will be in Jenkins #1635

There will be still fixes to be applied for some unit and in-jvm tests that
were pending on the drop but I will do it when I see Jenkins kicking in
this run properly.  (Which are those can be seen in CASSANDRA-16895, there
is a table in its description)

I will keep you posted on any new developments.


On Mon, 24 Jul 2023 at 14:52, Ekaterina Dimitrova 
wrote:

> Starting commits for 18255. Please put on hold any trunk commits. I will
> let you know when it is done. Thank you
>
> On Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova 
> wrote:
>
>> Hi everyone,
>>
>> Happy Monday!
>>
>> I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
>> systems today.
>> This requires numerous patches in a few repos so you will be seeing more
>> failures in CI throughout the day today, but it shouldn’t be anything more
>> 爛 than what we have listed in the table of failures in CASSANDRA-16895’s
>> description. I will be applying the fixes one by one today.
>> I will keep you posted with updates. Also, please, do let me know if you
>> have any questions or concerns.
>>
>> Best regards,
>> Ekaterina
>>
>>
>>

Re: [ANNOUNCEMENT] Expect failures today. Dropping JDK 8 and adding JDK 11

[Ekaterina Dimitrova]

Starting commits for 18255. Please put on hold any trunk commits. I will
let you know when it is done. Thank you

On Mon, 24 Jul 2023 at 11:29, Ekaterina Dimitrova 
wrote:

> Hi everyone,
>
> Happy Monday!
>
> I am working on dropping JDK 8 and adding JDK17 on trunk in both CI
> systems today.
> This requires numerous patches in a few repos so you will be seeing more
> failures in CI throughout the day today, but it shouldn’t be anything more
> 爛 than what we have listed in the table of failures in CASSANDRA-16895’s
> description. I will be applying the fixes one by one today.
> I will keep you posted with updates. Also, please, do let me know if you
> have any questions or concerns.
>
> Best regards,
> Ekaterina
>
>
>