[PR] Fix decompressed file name [celeborn-website]
cxzl25 opened a new pull request, #43: URL: https://github.com/apache/celeborn-website/pull/43 https://github.com/cxzl25/celeborn-website/actions/runs/8430466551/job/23086356974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celeborn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix decompressed file name [celeborn-website]
pan3793 commented on code in PR #43: URL: https://github.com/apache/celeborn-website/pull/43#discussion_r1538560685 ## .github/bin/build_docs.sh: ## @@ -36,12 +36,16 @@ TAR_NAME=${REF_VERSION_NAME##*/} if [[ "$REF_VERSION_NAME" == *"-tm"* ]] ;then DIR_VERSION_NAME=$(echo "$TAR_NAME" | sed -r "s/v*(.*)\.tar\.gz/\1/g") -TAR_DIR_NAME=incubator-celeborn-$DOC_LINK_PATH -wget "https://github.com/apache/incubator-celeborn/releases/download/${REF_VERSION_NAME}"; +if [[ "$REF_VERSION_NAME" == *"-incubating"* ]] ;then + TAR_DIR_NAME=incubator-celeborn-$DOC_LINK_PATH Review Comment: why should we handle `incubator-*` case now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celeborn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix decompressed file name [celeborn-website]
cxzl25 commented on code in PR #43: URL: https://github.com/apache/celeborn-website/pull/43#discussion_r1538562124 ## .github/bin/build_docs.sh: ## @@ -36,12 +36,16 @@ TAR_NAME=${REF_VERSION_NAME##*/} if [[ "$REF_VERSION_NAME" == *"-tm"* ]] ;then DIR_VERSION_NAME=$(echo "$TAR_NAME" | sed -r "s/v*(.*)\.tar\.gz/\1/g") -TAR_DIR_NAME=incubator-celeborn-$DOC_LINK_PATH -wget "https://github.com/apache/incubator-celeborn/releases/download/${REF_VERSION_NAME}"; +if [[ "$REF_VERSION_NAME" == *"-incubating"* ]] ;then + TAR_DIR_NAME=incubator-celeborn-$DOC_LINK_PATH Review Comment: Because the tar we released earlier had an incubator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celeborn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix decompressed file name [celeborn-website]
pan3793 merged PR #43: URL: https://github.com/apache/celeborn-website/pull/43 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celeborn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org