Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-23 Thread Yu Li
-1 (binding)

- Checked the diff between 0.3.2 and 0.4.0-rc4: FAILED (
https://github.com/apache/incubator-celeborn/compare/v0.3.2-incubating...v0.4.0-incubating-rc4).
Problems observed include:
   * The client-flink/flink-1.15-shaded module bundles
*com.google.guava:failureaccess* but has no entry in the embedded LICENSE
file. Actually, most (if not all) shaded jars
(flink-1.14/1.15/1.17/1.18-shaded, spark-3-shaded, mr-shaded, etc.) have
this problem.
   * The client-mr/mr-shaded module bundles *com.github.luben:zstd-jni* but
has no entry in the embedded LICENSE file. What's more, since this bundled
dependency is with BSD license [1], the relative license file needs to be
embedded.

AFAICS, this release has multiple dependency-related (dep version change,
new dep introduced, etc.) commits, so I suggest paying more attention to
the legal check for the next RC.

And maybe a shorter release cycle for major versions would help to reduce
the efforts required for (incremental) legal checking.

Best Regards,
Yu

[1] https://github.com/luben/zstd-jni?tab=License-1-ov-file#readme

On Tue, 23 Jan 2024 at 15:20, Suyan  wrote:

> I was just kidding. Don't worry about it.
> It's certainly not a problem.
>
> Sincerely,
> Suyan
>
> > 2024年1月23日 01:49,Fu Chen  写道:
> >
> > Hi Suyan,
> >
> > Thank you for your vote. The GPG key was generated when I first released
> > the Kyuubi project. Regarding the GPG key name, it's merely an
> identifier,
> > and I believe it should not be a blocking issue.
> >
> > Thanks,
> > Fu Chen
> >
> > Suyan  于2024年1月22日周一 22:01写道:
> >
> >> +1 non-binding
> >>
> >> [x] Download links are valid
> >> [x] Checksums and signatures
> >> gpg: assuming signed data in
> >> './apache-celeborn-0.4.0-incubating-source.tgz'
> >> gpg: Signature made 四  1/18 21:06:45 2024 CST
> >> gpg:using RSA key
> 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
> >> gpg: checking the trustdb
> >> gpg: marginals needed: 3  completes needed: 1  trust model: pgp
> >> gpg: depth: 0  valid:  12  signed:   0  trust: 0-, 0q, 0n, 0m, 0f, 12u
> >> gpg: next trustdb check due at 2024-05-25
> >> gpg: Good signature from "Fu Chen (For Kyuubi release)
> >> " [ultimate]
> >>
> >> [x] LICENSE/NOTICE files exist
> >> [x] NO unexpected binary files
> >> [x] Source files have ASF headers
> >> [x] Can compile from source
> >>
> >> Build successed on Apple Silicon M1(arm64).
> >>
> >>
> >> I noticed the release manager's key name  'Fu Chen (for Kyuubi
> >> release)', maybe a different name would be better? lol
> >>
> >> Sincerely,
> >> Suyan
> >>
> >> Fu Chen  于2024年1月22日周一 00:25写道:
> >>>
> >>> Hi IPMC,
> >>>
> >>> This is a call for a vote to release Apache Celeborn (Incubating)
> >>> 0.4.0-incubating-rc4
> >>>
> >>> The Apache Celeborn community has voted on and approved a proposal to
> >>> release Apache Celeborn (Incubating) version 0.4.0-incubating-rc4.
> >>> We now kindly request the Incubator PMC members review and vote on this
> >>> incubator release.
> >>>
> >>> celeborn@dev vote thread:
> >>>
> >>> https://lists.apache.org/thread/w91n2vgwts06gskoc5y19gl49myjm1jq
> >>>
> >>> celeborn@dev vote result thread:
> >>>
> >>> https://lists.apache.org/thread/7ylzdq6htzvlnnjzb5lhdd1nsfv4cjmn
> >>>
> >>> The git tag to be voted upon:
> >>>
> >>>
> >>
> https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
> >>>
> >>> The git commit hash:
> >>> 8bc07466dd85a90216820617015e329fb806c7dd
> >>>
> >>> The source and binary artifacts can be found at:
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
> >>>
> >>> The staging repo:
> >>>
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapacheceleborn-1051
> >>>
> >>> Fingerprint of the PGP key release artifacts are signed with:
> >>> 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
> >>>
> >>> My public key to verify signatures can be found in:
> >>>
> >>> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >>>
> >>> The vote will be open for at least 72 hours or until the necessary
> >>>
> >>> number of votes are reached.
> >>>
> >>> Please vote accordingly:
> >>>
> >>> [ ] +1 approve
> >>> [ ] +0 no opinion
> >>> [ ] -1 disapprove (and the reason)
> >>>
> >>> Checklist for release:
> >>>
> >>>
> >>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >>>
> >>> Steps to validate the release:
> >>>
> >>> https://www.apache.org/info/verification.html
> >>>
> >>> Please be aware that there has been a transition in the Celeborn
> >> project's
> >>> build tool, shifting from Maven to SBT. The SBT build documentation is
> >>> available at https://celeborn.apache.org/docs/latest/developers/sbt/.
> >>>
> >>> For illustrative purposes:
> >>>
> >>> Packaging the project
> >>> ```
> >>> ./build/sbt clean package
> >>> ```
> >>>
> >>> Creating the distribution
> >>> ```
> >>> ./build/make-distribution.sh --sbt-enabled --release
> >>> ```
> >>>
> >>> Regards,
> >>> Fu Chen

Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-19 Thread Shaoyun Chen
+1 (non-binding)

I checked the following things:

- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
```
- checksums are good.
```
sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512
sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512
```
- build success from source code.
```
./build/make-distribution.sh --release
./build/make-distribution.sh --sbt-enabled --release
```

Nicholas  于2024年1月19日周五 17:58写道:
>
> +1 (non-binding)
>
> I have verified:
> - Git commit hash is correct.
> - Checksums and signatures are valid.
> - Download links are valid.
> - No binary files in the source release.
> - Built the binary from the source with command successfully: 
> ./build/make-distribution.sh -Pspark-3.1,flink-1.17. Regards,
>
> Nicholas Jiang
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> At 2024-01-18 21:40:22, "Fu Chen"  wrote:
> >Hi Celeborn community,
> >
> >This is a call for a vote to release Apache Celeborn (Incubating)
> >0.4.0-incubating-rc4
> >
> >
> >The git tag to be voted upon:
> >https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
> >
> >
> >The git commit hash:
> >8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can be
> >found at:
> >https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
> >
> >
> >The staging repo:
> >https://repository.apache.org/content/repositories/orgapacheceleborn-1051
> >
> >
> >Fingerprint of the PGP key release artifacts are signed with:
> >92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
> >
> >
> >My public key to verify signatures can be found in:
> >https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >
> >
> >The vote will be open for at least 72 hours or until the necessary
> >number of votes are reached.
> >
> >
> >Please vote accordingly:
> >
> >
> >[ ] +1 approve
> >[ ] +0 no opinion
> >[ ] -1 disapprove (and the reason)
> >
> >
> >Checklist for release:
> >https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >Steps to validate the release:
> >https://www.apache.org/info/verification.html
> >
> >
> >* Download links, checksums and PGP signatures are valid.
> >* Source code distributions have correct names matching the current release.
> >* Release files have the word incubating in their name.
> >* DISCLAIMER, LICENSE and NOTICE files are correct.
> >* All files have license headers if necessary.
> >* No unlicensed compiled archives bundled in source archive.
> >* The source tarball matches the git tag.
> >* Build from source is successful.
> >
> >Please be aware that there has been a transition in the Celeborn project's
> >build tool, shifting from Maven to SBT. The SBT build documentation is
> >available
> >at https://celeborn.apache.org/docs/latest/developers/sbt/.
> >
> >For illustrative purposes:
> >
> >Packaging the project
> >```
> >./build/sbt clean package
> >```
> >
> >Creating the distribution
> >```
> >./build/make-distribution.sh --sbt-enabled --release
> >```
> >
> >Thanks,
> >Fu Chen


Re:[VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-19 Thread Nicholas
+1 (non-binding)

I have verified:
- Git commit hash is correct.
- Checksums and signatures are valid.
- Download links are valid.
- No binary files in the source release.
- Built the binary from the source with command successfully: 
./build/make-distribution.sh -Pspark-3.1,flink-1.17. Regards,

Nicholas Jiang














At 2024-01-18 21:40:22, "Fu Chen"  wrote:
>Hi Celeborn community,
>
>This is a call for a vote to release Apache Celeborn (Incubating)
>0.4.0-incubating-rc4
>
>
>The git tag to be voted upon:
>https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
>
>
>The git commit hash:
>8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can be
>found at:
>https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
>
>
>The staging repo:
>https://repository.apache.org/content/repositories/orgapacheceleborn-1051
>
>
>Fingerprint of the PGP key release artifacts are signed with:
>92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
>
>
>My public key to verify signatures can be found in:
>https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
>
>The vote will be open for at least 72 hours or until the necessary
>number of votes are reached.
>
>
>Please vote accordingly:
>
>
>[ ] +1 approve
>[ ] +0 no opinion
>[ ] -1 disapprove (and the reason)
>
>
>Checklist for release:
>https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>Steps to validate the release:
>https://www.apache.org/info/verification.html
>
>
>* Download links, checksums and PGP signatures are valid.
>* Source code distributions have correct names matching the current release.
>* Release files have the word incubating in their name.
>* DISCLAIMER, LICENSE and NOTICE files are correct.
>* All files have license headers if necessary.
>* No unlicensed compiled archives bundled in source archive.
>* The source tarball matches the git tag.
>* Build from source is successful.
>
>Please be aware that there has been a transition in the Celeborn project's
>build tool, shifting from Maven to SBT. The SBT build documentation is
>available
>at https://celeborn.apache.org/docs/latest/developers/sbt/.
>
>For illustrative purposes:
>
>Packaging the project
>```
>./build/sbt clean package
>```
>
>Creating the distribution
>```
>./build/make-distribution.sh --sbt-enabled --release
>```
>
>Thanks,
>Fu Chen


Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-19 Thread Wei Wu
+1 (binding)

I checked
- Download links are valid
- git commit hash is correct
- Checksums and signatures are valid
- Release files have the word 'incubating' in their names
- DISCLAIMER, LICENSE and NOTICE files in tarballs are correct
- Successfully built the binary from the source on Linux using jdk8 with
command:
  ./build/make-distribution.sh -Pspark-3.3

Thanks,
Wei Wu

On Thu, Jan 18, 2024 at 9:41 PM Fu Chen  wrote:

> Hi Celeborn community,
>
> This is a call for a vote to release Apache Celeborn (Incubating)
> 0.4.0-incubating-rc4
>
>
> The git tag to be voted upon:
>
> https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
>
>
> The git commit hash:
> 8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
>
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapacheceleborn-1051
>
>
> Fingerprint of the PGP key release artifacts are signed with:
> 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
>
>
> My public key to verify signatures can be found in:
> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
>
> The vote will be open for at least 72 hours or until the necessary
> number of votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and the reason)
>
>
> Checklist for release:
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> Steps to validate the release:
> https://www.apache.org/info/verification.html
>
>
> * Download links, checksums and PGP signatures are valid.
> * Source code distributions have correct names matching the current
> release.
> * Release files have the word incubating in their name.
> * DISCLAIMER, LICENSE and NOTICE files are correct.
> * All files have license headers if necessary.
> * No unlicensed compiled archives bundled in source archive.
> * The source tarball matches the git tag.
> * Build from source is successful.
>
> Please be aware that there has been a transition in the Celeborn project's
> build tool, shifting from Maven to SBT. The SBT build documentation is
> available
> at https://celeborn.apache.org/docs/latest/developers/sbt/.
>
> For illustrative purposes:
>
> Packaging the project
> ```
> ./build/sbt clean package
> ```
>
> Creating the distribution
> ```
> ./build/make-distribution.sh --sbt-enabled --release
> ```
>
> Thanks,
> Fu Chen
>


Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-18 Thread rexxiong
+1 (binding)
I checked
- Download links are valid.
- git commit hash is correct
- Checksums and signatures are valid.
- No binary files in the source release
- Files have the word incubating in their name.
- DISCLAIMER,LICENSE and NOTICE files exist.
- Successfully built the binary from the source on MacOs with Command:
./build/make-distribution.sh -Pspark-3.3

Thanks,
Jiashu Xiong

Cheng Pan  于2024年1月19日周五 15:43写道:

> +1 binding
>
> I checked
>
> - links are valid
> - build success from source (CentOS 7, x86, OpenJDK 8)
> - LICENSE and NOTICE look good
> - DISCLAIMER exist
> - incubating present in artifacts name
>
> Thanks,
> Cheng Pan
>
>
> > On Jan 19, 2024, at 15:29, Ethan Feng  wrote:
> >
> > +1(binding)
> >
> > I checked:
> > √ release files in the correct location
> > √ release files have the word incubating
> > √ digital signature and hashes correct
> > √ DISCLAIMER file exist
> > √ LICENSE and NOTICE files exist and are correct
> > √ the contents of the release match the tag in VCS
> > √ can build the release from the source
> > √ maven artifacts look correct
> >
> > Thanks,
> > Ethan Feng
> >
> > Yihe Li  于2024年1月19日周五 14:28写道:
> >>
> >> +1 (non-binding)
> >> I checked the following things:
> >> - git commit hash is correct.
> >> - download links are valid.
> >> - release files are in correct location.
> >> - release files have the word incubating in their name.
> >> - signatures and checksums are good.
> >> - DISCLAIMER, LICENSE and NOTICE files exist.
> >> - build success from source code(ubuntu 16.04).
> >> ```
> >> ./build/make-distribution.sh --release
> >> real30m46.326s
> >> user154m25.760s
> >> sys 29m14.300s
> >> ./build/make-distribution.sh --sbt-enabled --release
> >> real12m57.246s
> >> user68m48.212s
> >> sys 10m8.060s
> >> ```
> >>
> >> Thanks,
> >> Yihe Li
> >>
> >> On 2024/01/19 02:24:53 Keyong Zhou wrote:
> >>> +1 (binding)
> >>>
> >>> I checked
> >>> - git commit hash is correct.
> >>> - links are valid.
> >>> - "incubating" is in the name.
> >>> - signatures are good.
> >>> ```
> >>> gpg --import KEYS
> >>> gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
> >>> gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
> >>> ```
> >>> - checksums are good.
> >>> ```
> >>> sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512
> >>> sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512
> >>> ```
> >>> - LICENSE looks good.
> >>> - NOTICE looks good.
> >>> - DISCLAIMER exists.
> >>> - build success from source code (macOS).
> >>> ```
> >>> ./build/make-distribution.sh --sbt-enabled --release
> >>> ```
> >>>
> >>> Thanks,
> >>> Keyong Zhou
> >>>
> >>> Fu Chen  于2024年1月18日周四 21:40写道:
> >>>
>  Hi Celeborn community,
> 
>  This is a call for a vote to release Apache Celeborn (Incubating)
>  0.4.0-incubating-rc4
> 
> 
>  The git tag to be voted upon:
> 
> 
> https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
> 
> 
>  The git commit hash:
>  8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts
> can be
>  found at:
> 
> 
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
> 
> 
>  The staging repo:
> 
> https://repository.apache.org/content/repositories/orgapacheceleborn-1051
> 
> 
>  Fingerprint of the PGP key release artifacts are signed with:
>  92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
> 
> 
>  My public key to verify signatures can be found in:
>  https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> 
> 
>  The vote will be open for at least 72 hours or until the necessary
>  number of votes are reached.
> 
> 
>  Please vote accordingly:
> 
> 
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove (and the reason)
> 
> 
>  Checklist for release:
> 
> 
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>  Steps to validate the release:
>  https://www.apache.org/info/verification.html
> 
> 
>  * Download links, checksums and PGP signatures are valid.
>  * Source code distributions have correct names matching the current
>  release.
>  * Release files have the word incubating in their name.
>  * DISCLAIMER, LICENSE and NOTICE files are correct.
>  * All files have license headers if necessary.
>  * No unlicensed compiled archives bundled in source archive.
>  * The source tarball matches the git tag.
>  * Build from source is successful.
> 
>  Please be aware that there has been a transition in the Celeborn
> project's
>  build tool, shifting from Maven to SBT. The SBT build documentation is
>  available
>  at https://celeborn.apache.org/docs/latest/developers/sbt/.
> 
>  For illustrative purposes:
> 
>  Packaging the project
>  

Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-18 Thread Cheng Pan
+1 binding

I checked

- links are valid
- build success from source (CentOS 7, x86, OpenJDK 8)
- LICENSE and NOTICE look good
- DISCLAIMER exist
- incubating present in artifacts name

Thanks,
Cheng Pan


> On Jan 19, 2024, at 15:29, Ethan Feng  wrote:
> 
> +1(binding)
> 
> I checked:
> √ release files in the correct location
> √ release files have the word incubating
> √ digital signature and hashes correct
> √ DISCLAIMER file exist
> √ LICENSE and NOTICE files exist and are correct
> √ the contents of the release match the tag in VCS
> √ can build the release from the source
> √ maven artifacts look correct
> 
> Thanks,
> Ethan Feng
> 
> Yihe Li  于2024年1月19日周五 14:28写道:
>> 
>> +1 (non-binding)
>> I checked the following things:
>> - git commit hash is correct.
>> - download links are valid.
>> - release files are in correct location.
>> - release files have the word incubating in their name.
>> - signatures and checksums are good.
>> - DISCLAIMER, LICENSE and NOTICE files exist.
>> - build success from source code(ubuntu 16.04).
>> ```
>> ./build/make-distribution.sh --release
>> real30m46.326s
>> user154m25.760s
>> sys 29m14.300s
>> ./build/make-distribution.sh --sbt-enabled --release
>> real12m57.246s
>> user68m48.212s
>> sys 10m8.060s
>> ```
>> 
>> Thanks,
>> Yihe Li
>> 
>> On 2024/01/19 02:24:53 Keyong Zhou wrote:
>>> +1 (binding)
>>> 
>>> I checked
>>> - git commit hash is correct.
>>> - links are valid.
>>> - "incubating" is in the name.
>>> - signatures are good.
>>> ```
>>> gpg --import KEYS
>>> gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
>>> gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
>>> ```
>>> - checksums are good.
>>> ```
>>> sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512
>>> sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512
>>> ```
>>> - LICENSE looks good.
>>> - NOTICE looks good.
>>> - DISCLAIMER exists.
>>> - build success from source code (macOS).
>>> ```
>>> ./build/make-distribution.sh --sbt-enabled --release
>>> ```
>>> 
>>> Thanks,
>>> Keyong Zhou
>>> 
>>> Fu Chen  于2024年1月18日周四 21:40写道:
>>> 
 Hi Celeborn community,
 
 This is a call for a vote to release Apache Celeborn (Incubating)
 0.4.0-incubating-rc4
 
 
 The git tag to be voted upon:
 
 https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
 
 
 The git commit hash:
 8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can be
 found at:
 
 https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
 
 
 The staging repo:
 https://repository.apache.org/content/repositories/orgapacheceleborn-1051
 
 
 Fingerprint of the PGP key release artifacts are signed with:
 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
 
 
 My public key to verify signatures can be found in:
 https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
 
 
 The vote will be open for at least 72 hours or until the necessary
 number of votes are reached.
 
 
 Please vote accordingly:
 
 
 [ ] +1 approve
 [ ] +0 no opinion
 [ ] -1 disapprove (and the reason)
 
 
 Checklist for release:
 
 https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
 Steps to validate the release:
 https://www.apache.org/info/verification.html
 
 
 * Download links, checksums and PGP signatures are valid.
 * Source code distributions have correct names matching the current
 release.
 * Release files have the word incubating in their name.
 * DISCLAIMER, LICENSE and NOTICE files are correct.
 * All files have license headers if necessary.
 * No unlicensed compiled archives bundled in source archive.
 * The source tarball matches the git tag.
 * Build from source is successful.
 
 Please be aware that there has been a transition in the Celeborn project's
 build tool, shifting from Maven to SBT. The SBT build documentation is
 available
 at https://celeborn.apache.org/docs/latest/developers/sbt/.
 
 For illustrative purposes:
 
 Packaging the project
 ```
 ./build/sbt clean package
 ```
 
 Creating the distribution
 ```
 ./build/make-distribution.sh --sbt-enabled --release
 ```
 
 Thanks,
 Fu Chen
 
>>> 



Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-18 Thread Ethan Feng
+1(binding)

I checked:
√ release files in the correct location
√ release files have the word incubating
√ digital signature and hashes correct
√ DISCLAIMER file exist
√ LICENSE and NOTICE files exist and are correct
√ the contents of the release match the tag in VCS
√ can build the release from the source
√ maven artifacts look correct

Thanks,
Ethan Feng

Yihe Li  于2024年1月19日周五 14:28写道:
>
> +1 (non-binding)
> I checked the following things:
> - git commit hash is correct.
> - download links are valid.
> - release files are in correct location.
> - release files have the word incubating in their name.
> - signatures and checksums are good.
> - DISCLAIMER, LICENSE and NOTICE files exist.
> - build success from source code(ubuntu 16.04).
> ```
> ./build/make-distribution.sh --release
> real30m46.326s
> user154m25.760s
> sys 29m14.300s
> ./build/make-distribution.sh --sbt-enabled --release
> real12m57.246s
> user68m48.212s
> sys 10m8.060s
> ```
>
> Thanks,
> Yihe Li
>
> On 2024/01/19 02:24:53 Keyong Zhou wrote:
> > +1 (binding)
> >
> > I checked
> > - git commit hash is correct.
> > - links are valid.
> > - "incubating" is in the name.
> > - signatures are good.
> > ```
> > gpg --import KEYS
> > gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
> > gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
> > ```
> > - checksums are good.
> > ```
> > sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512
> > sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512
> > ```
> > - LICENSE looks good.
> > - NOTICE looks good.
> > - DISCLAIMER exists.
> > - build success from source code (macOS).
> > ```
> > ./build/make-distribution.sh --sbt-enabled --release
> > ```
> >
> > Thanks,
> > Keyong Zhou
> >
> > Fu Chen  于2024年1月18日周四 21:40写道:
> >
> > > Hi Celeborn community,
> > >
> > > This is a call for a vote to release Apache Celeborn (Incubating)
> > > 0.4.0-incubating-rc4
> > >
> > >
> > > The git tag to be voted upon:
> > >
> > > https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
> > >
> > >
> > > The git commit hash:
> > > 8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can 
> > > be
> > > found at:
> > >
> > > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
> > >
> > >
> > > The staging repo:
> > > https://repository.apache.org/content/repositories/orgapacheceleborn-1051
> > >
> > >
> > > Fingerprint of the PGP key release artifacts are signed with:
> > > 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
> > >
> > >
> > > My public key to verify signatures can be found in:
> > > https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> > >
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> > > number of votes are reached.
> > >
> > >
> > > Please vote accordingly:
> > >
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove (and the reason)
> > >
> > >
> > > Checklist for release:
> > >
> > > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > Steps to validate the release:
> > > https://www.apache.org/info/verification.html
> > >
> > >
> > > * Download links, checksums and PGP signatures are valid.
> > > * Source code distributions have correct names matching the current
> > > release.
> > > * Release files have the word incubating in their name.
> > > * DISCLAIMER, LICENSE and NOTICE files are correct.
> > > * All files have license headers if necessary.
> > > * No unlicensed compiled archives bundled in source archive.
> > > * The source tarball matches the git tag.
> > > * Build from source is successful.
> > >
> > > Please be aware that there has been a transition in the Celeborn project's
> > > build tool, shifting from Maven to SBT. The SBT build documentation is
> > > available
> > > at https://celeborn.apache.org/docs/latest/developers/sbt/.
> > >
> > > For illustrative purposes:
> > >
> > > Packaging the project
> > > ```
> > > ./build/sbt clean package
> > > ```
> > >
> > > Creating the distribution
> > > ```
> > > ./build/make-distribution.sh --sbt-enabled --release
> > > ```
> > >
> > > Thanks,
> > > Fu Chen
> > >
> >


Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-18 Thread Yihe Li
+1 (non-binding)
I checked the following things:
- git commit hash is correct.
- download links are valid.
- release files are in correct location.
- release files have the word incubating in their name.
- signatures and checksums are good.
- DISCLAIMER, LICENSE and NOTICE files exist.
- build success from source code(ubuntu 16.04).
```
./build/make-distribution.sh --release
real30m46.326s
user154m25.760s
sys 29m14.300s
./build/make-distribution.sh --sbt-enabled --release
real12m57.246s
user68m48.212s
sys 10m8.060s
```

Thanks,
Yihe Li

On 2024/01/19 02:24:53 Keyong Zhou wrote:
> +1 (binding)
> 
> I checked
> - git commit hash is correct.
> - links are valid.
> - "incubating" is in the name.
> - signatures are good.
> ```
> gpg --import KEYS
> gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
> gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
> ```
> - checksums are good.
> ```
> sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512
> sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512
> ```
> - LICENSE looks good.
> - NOTICE looks good.
> - DISCLAIMER exists.
> - build success from source code (macOS).
> ```
> ./build/make-distribution.sh --sbt-enabled --release
> ```
> 
> Thanks,
> Keyong Zhou
> 
> Fu Chen  于2024年1月18日周四 21:40写道:
> 
> > Hi Celeborn community,
> >
> > This is a call for a vote to release Apache Celeborn (Incubating)
> > 0.4.0-incubating-rc4
> >
> >
> > The git tag to be voted upon:
> >
> > https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
> >
> >
> > The git commit hash:
> > 8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can be
> > found at:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
> >
> >
> > The staging repo:
> > https://repository.apache.org/content/repositories/orgapacheceleborn-1051
> >
> >
> > Fingerprint of the PGP key release artifacts are signed with:
> > 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
> >
> >
> > My public key to verify signatures can be found in:
> > https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >
> >
> > The vote will be open for at least 72 hours or until the necessary
> > number of votes are reached.
> >
> >
> > Please vote accordingly:
> >
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and the reason)
> >
> >
> > Checklist for release:
> >
> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > Steps to validate the release:
> > https://www.apache.org/info/verification.html
> >
> >
> > * Download links, checksums and PGP signatures are valid.
> > * Source code distributions have correct names matching the current
> > release.
> > * Release files have the word incubating in their name.
> > * DISCLAIMER, LICENSE and NOTICE files are correct.
> > * All files have license headers if necessary.
> > * No unlicensed compiled archives bundled in source archive.
> > * The source tarball matches the git tag.
> > * Build from source is successful.
> >
> > Please be aware that there has been a transition in the Celeborn project's
> > build tool, shifting from Maven to SBT. The SBT build documentation is
> > available
> > at https://celeborn.apache.org/docs/latest/developers/sbt/.
> >
> > For illustrative purposes:
> >
> > Packaging the project
> > ```
> > ./build/sbt clean package
> > ```
> >
> > Creating the distribution
> > ```
> > ./build/make-distribution.sh --sbt-enabled --release
> > ```
> >
> > Thanks,
> > Fu Chen
> >
> 


Re: [VOTE] Release Apache Celeborn(Incubating) 0.4.0-incubating-rc4

2024-01-18 Thread Keyong Zhou
+1 (binding)

I checked
- git commit hash is correct.
- links are valid.
- "incubating" is in the name.
- signatures are good.
```
gpg --import KEYS
gpg --verify apache-celeborn-0.4.0-incubating-source.tgz.asc
gpg --verify apache-celeborn-0.4.0-incubating-bin.tgz.asc
```
- checksums are good.
```
sha512sum --check apache-celeborn-0.4.0-incubating-source.tgz.sha512
sha512sum --check apache-celeborn-0.4.0-incubating-bin.tgz.sha512
```
- LICENSE looks good.
- NOTICE looks good.
- DISCLAIMER exists.
- build success from source code (macOS).
```
./build/make-distribution.sh --sbt-enabled --release
```

Thanks,
Keyong Zhou

Fu Chen  于2024年1月18日周四 21:40写道:

> Hi Celeborn community,
>
> This is a call for a vote to release Apache Celeborn (Incubating)
> 0.4.0-incubating-rc4
>
>
> The git tag to be voted upon:
>
> https://github.com/apache/incubator-celeborn/releases/tag/v0.4.0-incubating-rc4
>
>
> The git commit hash:
> 8bc07466dd85a90216820617015e329fb806c7dd source and binary artifacts can be
> found at:
>
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.4.0-incubating-rc4
>
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapacheceleborn-1051
>
>
> Fingerprint of the PGP key release artifacts are signed with:
> 92AF4750DAFCB5E25B5B83EA76F54B977EB5C09B
>
>
> My public key to verify signatures can be found in:
> https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
>
> The vote will be open for at least 72 hours or until the necessary
> number of votes are reached.
>
>
> Please vote accordingly:
>
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove (and the reason)
>
>
> Checklist for release:
>
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> Steps to validate the release:
> https://www.apache.org/info/verification.html
>
>
> * Download links, checksums and PGP signatures are valid.
> * Source code distributions have correct names matching the current
> release.
> * Release files have the word incubating in their name.
> * DISCLAIMER, LICENSE and NOTICE files are correct.
> * All files have license headers if necessary.
> * No unlicensed compiled archives bundled in source archive.
> * The source tarball matches the git tag.
> * Build from source is successful.
>
> Please be aware that there has been a transition in the Celeborn project's
> build tool, shifting from Maven to SBT. The SBT build documentation is
> available
> at https://celeborn.apache.org/docs/latest/developers/sbt/.
>
> For illustrative purposes:
>
> Packaging the project
> ```
> ./build/sbt clean package
> ```
>
> Creating the distribution
> ```
> ./build/make-distribution.sh --sbt-enabled --release
> ```
>
> Thanks,
> Fu Chen
>