[GitHub] climate pull request #444: optimizing code
GitHub user Kejia opened a pull request: https://github.com/apache/climate/pull/444 optimizing code You can merge this pull request into a Git repository by running: $ git pull https://github.com/Kejia/climate patch-1 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/444.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #444 commit 60ec96ad92a9b9284d03370a715644f03e1a337c Author: 象é Date: 2017-05-30T14:13:01Z optimizing code --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request #445: optimizing traversing
GitHub user Kejia opened a pull request: https://github.com/apache/climate/pull/445 optimizing traversing use a set to track visiting state. also some minor updates. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Kejia/climate patch-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #445 commit c800e48cd2750f8fe2bbeb77750efe55c62fd05a Author: 象é Date: 2017-05-30T14:55:31Z optimizing traversing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (CLIMATE-912) Upgrade mccSearch code from Python2 > 3
[ https://issues.apache.org/jira/browse/CLIMATE-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030163#comment-16030163 ] ASF GitHub Bot commented on CLIMATE-912: Github user kwhitehall commented on the issue: https://github.com/apache/climate/pull/439 Hey @lewismc Tested and found the following: 1. need to convert this spaces to tabs in this folder 2. updated code to reduce the number of datasets needed to test. Code for test can be obtained at the this [Google Drive loc](https://drive.google.com/drive/folders/0B0kFBnuqk_GTczFiU3kwWDBXaFk?usp=sharing) Note that I did a hacky update cause another error flagged in [dataset_processor.py](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L1004-1005) by changing them to: spatial_indices_true = np.where(spatial_values.mask.all) spatial_indices_false = np.where(not spatial_values.mask.all) I haven't included these as something to include in this PR as more investigation needs to be done to ensure that this doesn't break the code otherwise. The PR has been pushed to my local [here](https://github.com/kwhitehall/climate/pull/7). I'll work on pushing it to your PR. Do you have direction on this? > Upgrade mccSearch code from Python2 > 3 > --- > > Key: CLIMATE-912 > URL: https://issues.apache.org/jira/browse/CLIMATE-912 > Project: Apache Open Climate Workbench > Issue Type: Improvement > Components: mcc search >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Minor > Fix For: 1.3.0 > > > I recently attempted to run the MCC Search code without any luck. Thsi issue > will simply upgrade the code such that it runs with Python 3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] climate issue #439: CLIMATE-912 Upgrade mccSearch code from Python2 > 3
Github user kwhitehall commented on the issue: https://github.com/apache/climate/pull/439 Hey @lewismc Tested and found the following: 1. need to convert this spaces to tabs in this folder 2. updated code to reduce the number of datasets needed to test. Code for test can be obtained at the this [Google Drive loc](https://drive.google.com/drive/folders/0B0kFBnuqk_GTczFiU3kwWDBXaFk?usp=sharing) Note that I did a hacky update cause another error flagged in [dataset_processor.py](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L1004-1005) by changing them to: spatial_indices_true = np.where(spatial_values.mask.all) spatial_indices_false = np.where(not spatial_values.mask.all) I haven't included these as something to include in this PR as more investigation needs to be done to ensure that this doesn't break the code otherwise. The PR has been pushed to my local [here](https://github.com/kwhitehall/climate/pull/7). I'll work on pushing it to your PR. Do you have direction on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
