[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
Github user huikyole commented on the pull request: https://github.com/apache/climate/pull/213#issuecomment-127110465 The issue (https://issues.apache.org/jira/browse/CLIMATE-643?jql=project%20%3D%20CLIMATE) has been updated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
Github user asfgit closed the pull request at: https://github.com/apache/climate/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
Github user MJJoyce commented on the pull request: https://github.com/apache/climate/pull/213#issuecomment-126737886 Good stuff @huikyole. Can I ask why we're copying the code from [water_flux_unit_conversion](https://github.com/apache/climate/blob/master/ocw/dataset_processor.py#L397) nearly verbatim into this new function instead of just calling the existing code? That's just a maintenance mistake waiting to happen and it seems like it would be much more useful to separate out the functionality right? Then we don't have to maintain the exact same functionality in multiple places. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/213#issuecomment-126522551 Merged build finished. Test Passed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
GitHub user huikyole opened a pull request: https://github.com/apache/climate/pull/213 CLIMATE-643 - Updating unit conversion function In many cases, observational and model datasets have different units for the same variable. We need to update variable_unit_conversion module is needed in dataset_processor. This new module is based on water_flux_unit_conversion. You can merge this pull request into a Git repository by running: $ git pull https://github.com/huikyole/climate CLIMATE-643 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/climate/pull/213.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #213 commit 3b297dbf29e789f4aec46e5f2f3ea151d9e14372 Author: huikyole huiky...@argo.jpl.nasa.gov Date: 2015-07-30T23:37:34Z Added: ocw.dataset_processor.variable_unit_conversion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/213#issuecomment-126522358 Merged build triggered. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] climate pull request: CLIMATE-643 - Updating unit conversion funct...
Github user OCWJenkins commented on the pull request: https://github.com/apache/climate/pull/213#issuecomment-126522367 Merged build started. Test Failed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
