Re: Review Request 11670: CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary storage is in maintenance state.

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11670/#review22579
---


Applying: CLOUDSTACK-2288: NPE while creating volume from snapshot when the 
primary storage is in maintenance state.
error: patch failed: server/src/com/cloud/storage/VolumeManagerImpl.java:523
error: server/src/com/cloud/storage/VolumeManagerImpl.java: patch does not apply
Patch failed at 0001 CLOUDSTACK-2288: NPE while creating volume from snapshot 
when the primary storage is in maintenance state.
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".

Fails to apply because of storage related changes. Can you retest if this is 
still an issue and submit the patch?

Thanks

- Prasanna Santhanam


On June 6, 2013, 11:24 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11670/
> ---
> 
> (Updated June 6, 2013, 11:24 a.m.)
> 
> 
> Review request for cloudstack and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-2288
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary 
> storage is in maintenance state.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/VolumeManagerImpl.java 43f3681 
> 
> Diff: https://reviews.apache.org/r/11670/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 1. In CS setup, put all primary storage in maintenance mode.
> 2. Create a volume from snapshot.
> 
> Verified the fix locally.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

RE: Master build problem

[Paul Angus]

Is this fix in the new 4.2 branch?  I'm getting the following error when trying 
to log in to the management UI. (UI reports 'Invalid Username or Password')

2013-06-30 07:12:33,779 DEBUG [cloud.user.AccountManagerImpl] 
(catalina-exec-5:null) Attempting to log in user: admin in domain 1
2013-06-30 07:12:33,779 DEBUG [server.auth.SHA256SaltedUserAuthenticator] 
(catalina-exec-5:null) Retrieving user: admin
2013-06-30 07:12:33,782 WARN  [server.auth.SHA256SaltedUserAuthenticator] 
(catalina-exec-5:null) The stored password for admin isn't in the right format 
for this authenticator



Regards,

Paul Angus
S: +44 20 3603 0540 | M: +447711418784
paul.an...@shapeblue.com



-Original Message-
From: Soheil Eizadi [mailto:seiz...@infoblox.com]
Sent: 27 June 2013 20:17
To: dev@cloudstack.apache.org
Subject: RE: Master build problem

Hi Prasanna,
I am glad the problem is fixed on master. I will pull it next time I merge with 
master.
Thanks,
-Soheil

From: Prasanna Santhanam [t...@apache.org]
Sent: Wednesday, June 26, 2013 9:47 PM
To: dev@cloudstack.apache.org
Subject: Re: Master build problem

Hiroaki fixed this with 39ef9240e87234afc2d4ddb37beaa63fe3240e4a. Do you have 
that commit SHA in your branch?

On Wed, Jun 26, 2013 at 06:45:20PM +, Soheil Eizadi wrote:
> I don't see a fix checked in for that, my merged branch is ahead of master. 
> It looks like it is due to the SSP Plugin checkin yesterday. If I had to 
> guess the component is not included in the client/pom.xml. I commented out 
> the plugin  in my branch (removed it from componentContext.xml.in) and I can 
> run the image now.
> -Soheil
>
> Administrators-MacBook-Pro-7:client seizadi$ pwd
> /Users/seizadi/cloudstack/infoblox_branch/cloudstack/client
>
> Administrators-MacBook-Pro-7:client seizadi$ fgrep "cloud-plugin-network" 
> pom.xml
>   cloud-plugin-network-nvp
>   cloud-plugin-network-ovs
>   cloud-plugin-network-elb
>   cloud-plugin-network-vns
>   cloud-plugin-network-midonet
>   cloud-plugin-network-internallb
>   cloud-plugin-network-infoblox
>   cloud-plugin-network-f5
>   cloud-plugin-network-netscaler
>   cloud-plugin-network-srx
>   cloud-plugin-network-cisco-vnmc
>
> 
> From: Min Chen [min.c...@citrix.com]
> Sent: Wednesday, June 26, 2013 11:07 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Master build problem
>
> I got latest master and able to start MS. I think that Prasanna has
> fixed that with a later checkin.
>
> Thanks
> -min
>
> On 6/26/13 11:02 AM, "Soheil Eizadi"  wrote:
>
> >I merged the latest master into my branch and could not run it. I
> >switched to master branch and built it but can not run it either, has
> >anyone else seen this problem with sspCredentialDaoImpl?
> >
> >ERROR [web.context.ContextLoader] (main:) Context initialization
> >failed
> >org.springframework.beans.factory.BeanCreationException: Error
> >creating bean with name 'actionEventUtils': Injection of autowired
> >dependencies failed; nested exception is
> >org.springframework.beans.factory.BeanCreationException: Could not
> >autowire field: com.cloud.event.dao.EventDao
> >com.cloud.event.ActionEventUtils.eventDao; nested exception is
> >org.springframework.beans.factory.CannotLoadBeanClassException:
> >Cannot find class [com.cloud.network.dao.SspCredentialDaoImpl] for
> >bean with name 'sspCredentialDaoImpl' defined in class path resource
> >[componentContext.xml]; nested exception is
> >java.lang.ClassNotFoundException:
> >com.cloud.network.dao.SspCredentialDaoImpl
>

--
Prasanna.,


Powered by BigRock.com


This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is operated under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Review Request 9818: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9818/#review22578
---


Roxanne, thanks for working on the patch and resubmitting!
Since the storage subsystem has been revamped the secondary storage does not 
show in Alert state anymore, I will mark this patch as discarded for now.

- Prasanna Santhanam


On June 19, 2013, 6:50 a.m., roxanne chang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9818/
> ---
> 
> (Updated June 19, 2013, 6:50 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, edison su, and Nitin Mehta.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-1594
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
> [https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
> 
> In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if 
> the host type is Secondary storage VM, the logic is to set secondarystorage 
> host, at this time, secondarystorage host stauts should become Up.
> 
> The secondary storage host always remains Alert status, because before the 
> secondary storage vm is deployed, the secondary storage host is created. The 
> tricky way (in the end of file AgentManagerImpl.java, function 
> NotifiMonitorsOfConnection) will try to disconnect secondary storage, 
> therefore the secondary storage host becomes Alert status. The code should 
> take SSVM into consider, not only Answer reponse.
> 
> File ResourceManagerImpl.java, function discoverHostsFull, in the end will 
> call discoverer.postDiscovery, in file 
> SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not 
> needed since its use to make secondary storage host wait for SSVM is already 
> done in SecondaryStorageManagerImpl. This makes why secondary storage host 
> always remains Alert status.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/agent/manager/AgentManagerImpl.java 6baeecf 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> c343286 
>   
> services/secondary-storage/src/org/apache/cloudstack/storage/resource/SecondaryStorageDiscoverer.java
>  d3af792 
> 
> Diff: https://reviews.apache.org/r/9818/diff/
> 
> 
> Testing
> ---
> 
> Test 4.0.0, 4.2.0 in basic mode, works well.
> 
> 
> Thanks,
> 
> roxanne chang
> 
>

Re: Review Request 11977: Re-enabling baremetal for 4.2/master

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11977/#review22577
---


This was submitted. Closing the review
http://cloudstack.markmail.org/thread/xfx4sjwyurnyn2xo

- Prasanna Santhanam


On June 19, 2013, 5:59 p.m., Sheng Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11977/
> ---
> 
> (Updated June 19, 2013, 5:59 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3077
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This patch would re-enable baremetal support for master, which we've disabled 
> on 4.1 release due to release blocker bugs.
> 
> After review passed, I would apply the patch to master in small patches.
> 
> 
> Diffs
> -
> 
>   client/pom.xml ab758eb 
>   client/tomcatconf/applicationContext.xml.in 049e483 
>   client/tomcatconf/componentContext.xml.in 93ef21f 
>   client/tomcatconf/nonossComponentContext.xml.in 143aa22 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalDiscoverer.java
>  edb5dea 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BareMetalTemplateAdapter.java
>  928183b 
>   
> plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalDhcpElement.java
>  fdf8b63 
>   plugins/network-elements/dns-notifier/resources/components-example.xml 
> 2e9c5be 
>   server/src/com/cloud/configuration/Config.java f6fa974 
>   server/src/com/cloud/network/NetworkServiceImpl.java aace68d 
>   setup/db/db/schema-410to420.sql bcdf2d9 
> 
> Diff: https://reviews.apache.org/r/11977/diff/
> 
> 
> Testing
> ---
> 
> All the following bugs(which are the original blocker for 4.1 releases) are 
> tested against the patch.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-1610
> https://issues.apache.org/jira/browse/CLOUDSTACK-1618
> https://issues.apache.org/jira/browse/CLOUDSTACK-1614
> https://issues.apache.org/jira/browse/CLOUDSTACK-1440
> 
> 
> Thanks,
> 
> Sheng Yang
> 
>

Re: Review Request 10846: Selenium Headless configuration using PhantomJS

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review22576
---


48540dcf5621d0cd7a925e8da299a3ef2d7d0c31

- Prasanna Santhanam


On May 2, 2013, 12:08 a.m., Parth Jagirdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> ---
> 
> (Updated May 2, 2013, 12:08 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, edison su, and David Nalley.
> 
> 
> Bugs: Cloudstack-2282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> Diffs
> -
> 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
>   test/selenium/smoke/main.py 86bb930 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> ---
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Re: Review Request 11858: CLOUDSTACK-2340 [AWS Style Health Checks] Response of the API listLoadBalancerRuleInstances should show the service state of a VM if health check is configured for it

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/
---

(Updated June 30, 2013, 6:08 a.m.)


Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, and 
Vijay Venkatachalam.


Changes
---

ping (reviewers). this one's marked for 4.2


Bugs: CLOUDSTACK-2340


Repository: cloudstack-git


Description
---

Issue: when healthcheck is created for LB rule then 
listLoadBalancerRuleInstance api should have the service state populated by 
LBHealthCheckManager. 
Fixed: Fixed the response of listLoadBalancerRuleInstance  to include a 
"servicestate":"UP" which tell the service state of the instance.
   if the healthcheck is not created on LB then api response then 
"servicestate" field won't be in the response.


Diffs
-

  api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3 
  api/src/org/apache/cloudstack/api/ApiConstants.java ab1402c 
  
api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
 49ab42c 
  api/src/org/apache/cloudstack/api/response/UserVmResponse.java 1f9eb1a 
  server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 67d31ab 

Diff: https://reviews.apache.org/r/11858/diff/


Testing
---

1. Created LB rule with healthcheck policy verified the 
listLoadBalancerRuleInstance  api response, it has the field servicestate for 
all the VM's assigned to the LB rule
2. Created LB rule without healthcheck policy, verified the 
listLoadBalancerRuleInstance api response wont have the servicestate field for 
all the VM's assigned to the LB rule


Thanks,

Rajesh Battala

Re: Review Request 7018: when a template is deleted and then copied over again , it is still marked as "Removed" in template_zone_ref table.

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7018/#review22575
---


Don't think this is applicable anymore with the storage subsystem changes. 

- Prasanna Santhanam


On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/
> ---
> 
> (Updated Jan. 13, 2013, 5:14 p.m.)
> 
> 
> Review request for cloudstack and Nitin Mehta.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This bug fix (CLOUDSTACK-970) deals with the database aspects of template 
> creation, this changes the way in which the entries are added and removed 
> from template_zone_ref and template_host_ref.
> 
>  
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8 
>   server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6 
>   server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2 
> 
> Diff: https://reviews.apache.org/r/7018/diff/
> 
> 
> Testing
> ---
> 
> I have tested this on the asf branch.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: [GSOC] cloudstack-agent service and "unable to add host"

[Prasanna Santhanam]

On Sat, Jun 29, 2013 at 01:51:32PM -0400, Han,Meng wrote:
> I encountered a few problems while following 4.0 quick install guide.
> 
> 1. cloudstack-management service can be started, but dies quickly.
> It is the same problem listed
> here:https://issues.apache.org/jira/browse/CLOUDSTACK-2758
> I know the master branch is properly patched to fix this problem.
> Are the packages in the following link updated as well?
> http://cloudstack.apt-get.eu/rhel/4.1/

Not that I know of. 4.1 was released with this known issue. The plan
is to fix this and other issues in the point release 4.1.1. For now
the workaround mentioned in the bug report is unfortunately the only
solution.

> 
> 2. Invalid username or password at initial login to CloudStack UI
> using the default admin/password.
> 
> I tried the installation several times. This error showed
> frequently. But the reason for this error varied. In my case, the
> following reasons are included, hardware does not support
> virtulization extension(I tried install everything inside a VM
> once), cloudstack-agent is not running...
> 
> I feel that this error is a little bit misleading. Because I checked
> the data in mysql, the user name and password are properly set to
> admin/password.
> 

Usually, this happens when the ApiServer does not come up
successfully. Sometimes the error will be found in catalina.out, so do
check over there. How much memory have you given for your managment
server VM? It might be running out of memory.

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 11953: Remove code that does nothing but allocate a bunch of objects

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/
---

(Updated June 30, 2013, 5:52 a.m.)


Review request for cloudstack, Alena Prokharchyk and Prachi Damle.


Changes
---

including couple reviewers


Repository: cloudstack-git


Description
---

remove code that may have been used for something in the past, but now does 
nothing but allocate memory temporarily.


Diffs
-

  
engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
 38ed7e6 

Diff: https://reviews.apache.org/r/11953/diff/


Testing
---


Thanks,

Dave Brosius

Re: Review Request 12197: Updated VPC test case's service offering

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12197/#review22574
---

Ship it!


b59bb25..1116968  master-6-17-stable -> master-6-17-stable
e8ea6b1..e14f355  master -> master
eb0552d..7791454  4.2 -> 4.2



- Prasanna Santhanam


On June 30, 2013, 5:15 a.m., Rayees Namathponnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12197/
> ---
> 
> (Updated June 30, 2013, 5:15 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> VPC test cases using high percentage of resources, it effects other test 
> cases 
> 
>   64 "service_offering": {
>   65 "name": "Tiny Instance",
>   66 "displaytext": "Tiny Instance",
>   67 "cpunumber": 1,
>   68 "cpuspeed": 1000,
>   69 "memory": 512,
>   70 },
> 
> Reduced to 
> 
>   64 "service_offering": {
>   65 "name": "Tiny Instance",
>   66 "displaytext": "Tiny Instance",
>   67 "cpunumber": 1,
>   68 "cpuspeed": 100,
>   69 "memory": 128,
>   70 },
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_network_lbrules.py b0357fa 
>   test/integration/component/test_vpc_network_pfrules.py b478b6a 
>   test/integration/component/test_vpc_network_staticnatrule.py c5d9e57 
>   test/integration/component/test_vpc_routers.py a8559e5 
> 
> Diff: https://reviews.apache.org/r/12197/diff/
> 
> 
> Testing
> ---
> 
> Tested
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Re: Review Request 12129: CLOUDSTACK-3217: Fixed indentation issues in test_routers.py

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12129/#review22573
---


was fixed as part of 8dc99d92b6f82e435610dfcc01d3458a99503119

- Prasanna Santhanam


On June 27, 2013, 7:28 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12129/
> ---
> 
> (Updated June 27, 2013, 7:28 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Resolved indentation issues as reported in 
> https://issues.apache.org/jira/browse/CLOUDSTACK-3217
> 
> File changed: test_routers.py
> 
> 
> Diffs
> -
> 
>   test/integration/smoke/test_routers.py 2e4553b 
> 
> Diff: https://reviews.apache.org/r/12129/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 12130: Tag missing for test integratin.component test_ldap.py

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12130/#review22572
---

Ship it!


56a001d1c49221397621759d784bd6000b38f5e4

- Prasanna Santhanam


On June 27, 2013, 7:30 a.m., suresh sadhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12130/
> ---
> 
> (Updated June 27, 2013, 7:30 a.m.)
> 
> 
> Review request for cloudstack, Rayees Namathponnan, SrikanteswaraRao Talluri, 
> and Prasanna Santhanam.
> 
> 
> Bugs: cloudstack-3023
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Added missing tags for test_ldap test cases.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_ldap.py 1b933db 
> 
> Diff: https://reviews.apache.org/r/12130/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> suresh sadhu
> 
>

Review Request 12197: Updated VPC test case's service offering

[Rayees Namathponnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12197/
---

Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam.


Repository: cloudstack-git


Description
---

VPC test cases using high percentage of resources, it effects other test cases 

  64 "service_offering": {
  65 "name": "Tiny Instance",
  66 "displaytext": "Tiny Instance",
  67 "cpunumber": 1,
  68 "cpuspeed": 1000,
  69 "memory": 512,
  70 },

Reduced to 

  64 "service_offering": {
  65 "name": "Tiny Instance",
  66 "displaytext": "Tiny Instance",
  67 "cpunumber": 1,
  68 "cpuspeed": 100,
  69 "memory": 128,
  70 },


Diffs
-

  test/integration/component/test_vpc_network_lbrules.py b0357fa 
  test/integration/component/test_vpc_network_pfrules.py b478b6a 
  test/integration/component/test_vpc_network_staticnatrule.py c5d9e57 
  test/integration/component/test_vpc_routers.py a8559e5 

Diff: https://reviews.apache.org/r/12197/diff/


Testing
---

Tested


Thanks,

Rayees Namathponnan

RE: [ACS42] Branch created

[Sateesh Chodapuneedi]

Hi Animesh,
Can you please let me know if commits into this branch are controlled?

Regards,
Sateesh

> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: 29 June 2013 22:01
> To: dev@cloudstack.apache.org
> Subject: [ACS42] Branch created
> 
> I have created 4.2 branch
> 
> Animesh

Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

[Dave Brosius]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12192/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

code checks the parameter 'state' and if null, set it to Allocated, even though 
that parameter is never accessed. Meant to set the field 'state'.


Diffs
-

  engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 

Diff: https://reviews.apache.org/r/12192/diff/


Testing
---


Thanks,

Dave Brosius

Re: Review Request 12162: Add documents on plugin development

[Noel King]

Good work Ian, enjoy the weekend


On 29 June 2013 20:54, Sebastien Goasguen  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12162/#review22568
> ---
>
> Ship it!
>
>
> applied to master with 15a6844784142141af4489a57d7d748c6687
> also applied on 4.1 and 4.2
>
> please mark review as submitted
>
> you need to check that it gets added to the devguide...
>
> thanks
>
> - Sebastien Goasguen
>
>
> On June 28, 2013, 12:37 p.m., Ian Duffy wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/12162/
> > ---
> >
> > (Updated June 28, 2013, 12:37 p.m.)
> >
> >
> > Review request for cloudstack and Sebastien Goasguen.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > ---
> >
> > Add documentation on creating a simple "helloWorld" API command plugin.
> >
> >
> > Diffs
> > -
> >
> >   docs/en-US/creating-a-plugin.xml PRE-CREATION
> >   docs/en-US/creating-my-first-plugin.xml PRE-CREATION
> >   docs/en-US/plugin-development.xml PRE-CREATION
> >
> > Diff: https://reviews.apache.org/r/12162/diff/
> >
> >
> > Testing
> > ---
> >
> > Built with publican, reviewed the build pdf in adobe reader.
> > There was funky text indentation between pages... this seems to be a
> global problem though.
> >
> >
> > Thanks,
> >
> > Ian Duffy
> >
> >
>
>

Re: Review Request 12162: Add documents on plugin development

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12162/#review22568
---

Ship it!


applied to master with 15a6844784142141af4489a57d7d748c6687
also applied on 4.1 and 4.2

please mark review as submitted

you need to check that it gets added to the devguide...

thanks

- Sebastien Goasguen


On June 28, 2013, 12:37 p.m., Ian Duffy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12162/
> ---
> 
> (Updated June 28, 2013, 12:37 p.m.)
> 
> 
> Review request for cloudstack and Sebastien Goasguen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Add documentation on creating a simple "helloWorld" API command plugin. 
> 
> 
> Diffs
> -
> 
>   docs/en-US/creating-a-plugin.xml PRE-CREATION 
>   docs/en-US/creating-my-first-plugin.xml PRE-CREATION 
>   docs/en-US/plugin-development.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12162/diff/
> 
> 
> Testing
> ---
> 
> Built with publican, reviewed the build pdf in adobe reader.
> There was funky text indentation between pages... this seems to be a global 
> problem though.  
> 
> 
> Thanks,
> 
> Ian Duffy
> 
>

Re: Review Request 12189: Apach CloudStack 4.1 Quick Install Guide (en-US)

[Sebastien Goasguen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12189/#review22567
---

Ship it!


committed to master with 676d8744ef6801cf3fcf6425d37ba27a149e5615
also committed to 4.1 and 4.2 branch

make sure to add your name and email to your .gitconfig

also make sure to squash trailing whitespaces

thanks for this, it's great

please mark the review as submitted

- Sebastien Goasguen


On June 29, 2013, 3:54 p.m., meng han wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12189/
> ---
> 
> (Updated June 29, 2013, 3:54 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the ACS quick install guide for the branch 4.1
> 
> 
> Diffs
> -
> 
>   docs/qig/en-US/Author_Group.xml PRE-CREATION 
>   docs/qig/en-US/Book_Info.xml PRE-CREATION 
>   docs/qig/en-US/Chapter.xml PRE-CREATION 
>   docs/qig/en-US/Environment.xml PRE-CREATION 
>   docs/qig/en-US/Management.xml PRE-CREATION 
>   docs/qig/en-US/Overview.xml PRE-CREATION 
>   docs/qig/en-US/Preface.xml PRE-CREATION 
>   docs/qig/en-US/Revision_History.xml PRE-CREATION 
>   docs/qig/en-US/config.xml PRE-CREATION 
>   docs/qig/en-US/kvm.xml PRE-CREATION 
>   docs/qig/en-US/qig.ent PRE-CREATION 
>   docs/qig/en-US/qig.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12189/diff/
> 
> 
> Testing
> ---
> 
> I tested the quick install guide of 4.0 and created this 4.1 guide 
> accordingly.
> Test it successfully on my desktop (centos6.4).
> 
> 
> Thanks,
> 
> meng han
> 
>

RE: [ACS42] Branch created

[Sudha Ponnaganti]

Just want to confirm if upgrades are all enabled for 4.2?? 

-Original Message-
From: Trippie [mailto:trip...@gmail.com] On Behalf Of Hugo Trippaers
Sent: Saturday, June 29, 2013 10:31 AM
To: dev@cloudstack.apache.org
Subject: Re: [ACS42] Branch created

Great!

I've setup the basic build jobs for 4.2 on jenkins.cloudstack.org.  I would 
like to send all build failures from those jobs directly to the dev list. Can a 
moderator add jenk...@cloudstack.org to the whitelist of the dev mailing list?

Cheers,

Hugo

On Jun 29, 2013, at 9:30 AM, Animesh Chaturvedi  
wrote:

> I have created 4.2 branch
> 
> Animesh

Re: [GSOC] cloudstack-agent service and "unable to add host"

[Han,Meng]

Hi Sebastien,

Thanks for your reply.


On Fri, 28 Jun 2013 14:54:46 -0400, Sebastien Goasguen wrote:

Meng,

I am not sure where you stand on this, but you should not use VLANs.

Just setup a basic zone (no vlans needed) , use the packages from the
repository and don't even try to compile from source.


It turned out that I didn't configure the repository correctly. Now I 
can install cloud-client and cloud-agent.




All information should be in the installation guide (not the quick
install guide, which is not valid for 4.1).

This script might help you:

http://simonljb123.wordpress.com/2013/05/22/installation-of-cloudstack-4-0-kvm-hypervisor-host-with-onekey/

but this is only for 4.0. In 4.1 the package names have changed from
cloud- to cloudstack-


Just figured this out yesterday :)



I will do an install on monday and get back with you (have not done
an install in a while).


I tested the quick install guide 4.0 and created a quick install guide 
for 4.1. Tested the 4.1 guide successfully on my desktop.

I encountered a few problems while following 4.0 quick install guide.

1. cloudstack-management service can be started, but dies quickly. It 
is the same problem listed 
here:https://issues.apache.org/jira/browse/CLOUDSTACK-2758
I know the master branch is properly patched to fix this problem. Are 
the packages in the following link updated as well?

http://cloudstack.apt-get.eu/rhel/4.1/

2. Invalid username or password at initial login to CloudStack UI using 
the default admin/password.


I tried the installation several times. This error showed frequently. 
But the reason for this error varied. In my case, the following reasons 
are included, hardware does not support virtulization extension(I tried 
install everything inside a VM once), cloudstack-agent is not running...


I feel that this error is a little bit misleading. Because I checked 
the data in mysql, the user name and password are properly set to 
admin/password.



Best Regards,

Meng




-sebastien

On Jun 24, 2013, at 10:53 PM, "Han,Meng"  wrote:


Hi all,

In the CloudStack installation guides(both 4.0 and 4.1), it says 
that we need to install cloud-agent.


(http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html#hypervisor-host-install-agent)

However I could not find this package. Instead I found a directory 
named "agent" in the CloudStack master branch.


Is it the same agent? How should I run this agent?
Also it is mentioned here that we should configure a couple of 
things after we installed cloud agent 
:http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Quick_Install_Guide/sect-qig-KVM-Installation.html
What configuration do I need to make to the cloud agent? It seems to 
me at least  we should told the agent which bridges the VMs are 
connected to. There is a script called "cloud-setup-agent" under the 
agent directory. Should we use this to configure the agent?


I have stuck on these question for a couple of days. I seems to grab 
pieces from every installation guide I can find to make things through 
:(


Also in the network configuration part: 
http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.1.0/html/Installation_Guide/hypervisor-kvm-install-flow.html#hypervisor-host-install-network


We assume that the hypervisor has one NIC (eth0) with three tagged 
VLAN's:


   VLAN 100 for management of the hypervisor
   VLAN 200 for public network of the instances (cloudbr0)
   VLAN 300 for private network of the instances (cloudbr1)

I am not allowed to use tagged VLANs on campus, which means my VMs 
will not be able to connect to internet. Is there anyway to work 
around this? Can we use a "flat" network structure?


If we setup these two bridges: cloudbr0 and cloudbr1, how does the 
cloud agent know these two bridges?


Thanks for your help.

Best Regards,
Meng

Re: [ACS42] Branch created

[Hugo Trippaers]

Great!

I've setup the basic build jobs for 4.2 on jenkins.cloudstack.org.  I would 
like to send all build failures from those jobs directly to the dev list. Can a 
moderator add jenk...@cloudstack.org to the whitelist of the dev mailing list?

Cheers,

Hugo

On Jun 29, 2013, at 9:30 AM, Animesh Chaturvedi  
wrote:

> I have created 4.2 branch
> 
> Animesh

Review Request 12191: removed EnumerationImpl

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12191/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

EnumerationImpl was not used and duplicates functionality
with org.apache.commons.collections.iterators.EnumerationIterator


Diffs
-

  utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3 

Diff: https://reviews.apache.org/r/12191/diff/


Testing
---


Thanks,

Laszlo Hornyak

Review Request 12190: removed CleanupDelegate

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12190/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

It did not have an implementation


Diffs
-

  utils/src/com/cloud/utils/CleanupDelegate.java 6c368c3 

Diff: https://reviews.apache.org/r/12190/diff/


Testing
---


Thanks,

Laszlo Hornyak

Re: Suggestion needed for CLOUDSTACK-212

[David Nalley]

On Fri, Jun 28, 2013 at 4:05 AM, Sebastien Goasguen  wrote:
>
> On Jun 27, 2013, at 1:23 PM, Dharmesh Kakadia  wrote:
>
>> Hi,
>>
>> I misunderstood the feature freeze. This has been assigned to fix in
>> Version 4.2 on jira. As per this discussion, should I change it to 4.3 ?
>
> Dharmesh, can you give us the pointer to github where you put the latest 
> changes on this ?
>
> Did you rebase against the latest master lately ?
>
> -sebastien
>

Dharmesh:
4.2 has branched, and I'd like to get this up for review - can you get
us a patch and push it to ReviewBoard?

--David

Re: [DISCUSS] If BVT breaks, revert the commits...

[David Nalley]

On Sat, Jun 29, 2013 at 12:45 AM, Prasanna Santhanam  wrote:
> On Sat, Jun 29, 2013 at 12:18:17AM +, Alex Huang wrote:
>> After Dave's complain in the vmsync [MERGE] thread about BVT in
>> horrible shape on master, I went around to figure out what exactly
>> happened.  The best I can figure is that after a certain merge (I
>> will leave out which merge as that's not important), BVT no longer
>> runs automatically.  It was promised to be fixed and there are
>> people who are actively fixing it but it's been in this way for
>> about two weeks.  People running BVTs are working around the problem
>> but it's not automated anymore and so it's no longer running on
>> master.  I understand people are nice and tried to be accommodating
>> to other people by working around the problem but sometimes we just
>> have to be an arse.  So let me be that arse...
>>
>> New Rule
>> If BVT or automated regression tests break on master or any release
>> branch, we revert all commits that broke it.  It doesn't matter if
>> they promise to fix it within the next hour.  If it's broken, the
>> release manager will revert the commits and developers must
>> resubmit.  It sounds mean but it's the only way this problem can be
>> fixed.
>>
>> To avoid having a bunch of reverts and resubmits, the developers
>> should be able to request that BVT run on their branch and don't
>> merge until BVT on their branch is at 100%.  We will work on
>> figuring out how to do that.
>>
>> Comments?
>>
> Quick questions:
>
> 1. How do we test contributor code (from github/reviewboard) because
> we have no staging area/branch?
>

Take a look at the pre-commit testing that hadoop does, that might be
usable for us. Olamy did a blog post about it recently.


> 2. Squashing into a big patch is not a good idea. I prefer that we
> keep the clean commit history rebased atop master in the topic branch
> and run the bvt on it. This can be requested and there is ability in
> the test jobs to switch branches already.
>
> Hit Build (test-matrix job) -> choose  on the form.
>
> 3. BVTs have long runtime (3 HVs - 4hrs). For large merges it makes
> sense since we're going to be waiting 72h for the review/merge
> request. But rest of the time I propose we run it against master only.
> Is this the same as you're proposing?
>
> 4. Who will fix the tests which are broken?
>

Well if we treat master as frozen until the tests are fixed, then I'd
suppose that folks wanting to get code in will be incentivized to at
least help fix them so that master can start getting code again :)

--David

[ACS42] Branch created

[Animesh Chaturvedi]

I have created 4.2 branch

Animesh

Re: [DISCUSS][VOTE] Moving cloudmonkey to its own repository, have its own release process

[David Nalley]

Rohit:

Do you plan on generating a cloudmonkey release? (and acting as the
RM?, should be comparatively simple, but we might need to document
it.)
Setup.py will need to be fixed, but I have no other concerns than
that. I plan to make this writable momentarily.

--David

On Sat, Jun 29, 2013 at 9:27 AM, Rohit Yadav  wrote:
> More than 72 hours now. Let's make it writable and publish latest
> cloudmonkey on pypi.
>
> Cheers.
>
> On Wed, Jun 26, 2013 at 3:02 AM, David Nalley  wrote:
>
>> >
>> > Not sure about setup.py related failures.
>> >
>>
>> Me either - setup.py is pretty dramatically different between the two
>> repos.
>>
>> --David
>>

Review Request 12189: Apach CloudStack 4.1 Quick Install Guide (en-US)

[meng han]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12189/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

This is the ACS quick install guide for the branch 4.1


Diffs
-

  docs/qig/en-US/Author_Group.xml PRE-CREATION 
  docs/qig/en-US/Book_Info.xml PRE-CREATION 
  docs/qig/en-US/Chapter.xml PRE-CREATION 
  docs/qig/en-US/Environment.xml PRE-CREATION 
  docs/qig/en-US/Management.xml PRE-CREATION 
  docs/qig/en-US/Overview.xml PRE-CREATION 
  docs/qig/en-US/Preface.xml PRE-CREATION 
  docs/qig/en-US/Revision_History.xml PRE-CREATION 
  docs/qig/en-US/config.xml PRE-CREATION 
  docs/qig/en-US/kvm.xml PRE-CREATION 
  docs/qig/en-US/qig.ent PRE-CREATION 
  docs/qig/en-US/qig.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/12189/diff/


Testing
---

I tested the quick install guide of 4.0 and created this 4.1 guide accordingly.
Test it successfully on my desktop (centos6.4).


Thanks,

meng han

Re: Review Request 11942: ProcessUtil cleanup

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11942/
---

(Updated June 29, 2013, 3:51 p.m.)


Review request for cloudstack.


Changes
---

basically just rebased


Repository: cloudstack-git


Description
---

- possible resource leak closed
- file content read uses now commons-lang FileUtils
- Added unit tests


Diffs (updated)
-

  utils/src/com/cloud/utils/ProcessUtil.java c9fdf35 
  utils/test/com/cloud/utils/ProcessUtilTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/11942/diff/


Testing
---

test included


Thanks,

Laszlo Hornyak

Review Request 12188: removed interface "On"

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12188/
---

Review request for cloudstack.


Repository: cloudstack-git


Description
---

Interface "On" had no implementation and its references were not used
- removed methods returning "On"
- removed "On" interface


Diffs
-

  utils/src/com/cloud/utils/db/JoinQueryBuilder.java 090a1d1 
  utils/src/com/cloud/utils/db/On.java 6965f4d 
  utils/src/com/cloud/utils/db/QueryBuilder.java 3303fbd 

Diff: https://reviews.apache.org/r/12188/diff/


Testing
---

recompiled


Thanks,

Laszlo Hornyak

Re: Review Request 11953: Remove code that does nothing but allocate a bunch of objects

[Laszlo Hornyak]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11953/#review22566
---


Looks like the whole point is to calculate the poolId and the 
DataCenterDeployment constructor does take a poolId argument, but instead a 
null is passed. Just wondering if the original intention here was to pass the 
poolId over rather than having null there.

But anyway, the temporary object reservation would not be necessary even then, 
the code could iterate over the keySet() rather than on its copy.

- Laszlo Hornyak


On June 29, 2013, 2:35 a.m., Dave Brosius wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11953/
> ---
> 
> (Updated June 29, 2013, 2:35 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> remove code that may have been used for something in the past, but now does 
> nothing but allocate memory temporarily.
> 
> 
> Diffs
> -
> 
>   
> engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java
>  38ed7e6 
> 
> Diff: https://reviews.apache.org/r/11953/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dave Brosius
> 
>

Testcase Failure

[Dharmesh Kakadia]

Hi,

I am trying to switch com.cloud.network package to org.apache.network.
While doing so, I am encountering following failure in test case. I tried
looking around for few hours, but no success. I don't understand
spring-junit testing much. I looked at
https://cwiki.apache.org/CLOUDSTACK/unit-testing-101.html but still not
clear how dependencies are resolved in testing.

Please tell me where to look for.

Tests in error:
  testSchedule(org.apache.network.security.SecurityGroupManagerImpl2Test):
Error creating bean with name 'dataCenterDaoImpl': Injection of autowired
dependencies failed; nested exception is
org.springframework.beans.factory.BeanCreationException: Could not autowire
field: protected org.apache.network.dao.AccountGuestVlanMapDao
com.cloud.dc.dao.DataCenterDaoImpl._accountGuestVlanMapDao; nested
exception is
org.springframework.beans.factory.NoSuchBeanDefinitionException: No
matching bean of type [org.apache.network.dao.AccountGuestVlanMapDao] found
for dependency: expected at least 1 bean which qualifies as autowire
candidate for this dependency. Dependency annotations:
{@javax.inject.Inject()}

Thanks,
Dharmesh

Re: Jenkins and IRC

[Rohit Yadav]

On Fri, Jun 28, 2013 at 10:39 PM, Hugo Trippaers  wrote:

> Heya,
>
> I've added a parameterised job to jenkins that will run a complete build
> on any branch. You can kick it off on jenkins.cloudstack.org and enter
> any branch as the parameter. It will do the regular maven build with the
> clean and test actions. It will also generate a cobertura coverage report
> so you can easily see how much code your unit tests cover.
>
> Also its possible to kick this build right from our IRC channel. For
> example the following command will build the vmsync branch:
>
> !jenkins build cloudstack-build-parameterized now branch=vmsync
>
> List the current builds using the '!jenkins cb' command.
>
> So whenever you push a branch to apache, feel free to ask cato to build it
> for you.
>

w00t! awesome.


>
> Cheers,
>
> Hugo
>
>
> @David, remember that nginx proxy timeout setting we discussed ages ago?
> Would be nice to get that sorted so we can use some extra cloud power on
> jenkins.cloudstack.org. Any ideas on how we can get that done?

Re: [DISCUSS][VOTE] Moving cloudmonkey to its own repository, have its own release process

[Rohit Yadav]

More than 72 hours now. Let's make it writable and publish latest
cloudmonkey on pypi.

Cheers.

On Wed, Jun 26, 2013 at 3:02 AM, David Nalley  wrote:

> >
> > Not sure about setup.py related failures.
> >
>
> Me either - setup.py is pretty dramatically different between the two
> repos.
>
> --David
>

Re: [ACS42] Feature Freeze reminder

[Prasanna Santhanam]

And the RAT check failed. Fixed now in SolidFireUtil.java

On Sat, Jun 29, 2013 at 04:51:59PM +0530, Prasanna Santhanam wrote:
> I've merged the plugin changes for simulator into master. Also ran the
> checkin tests without issue. The only change was to move Mike's plugin
> over to componentContext.xml instead of applicationContext.xml.
> 
> Thanks,
> 
> -- 
> Prasanna.,
> 
-- 
Prasanna.,


Powered by BigRock.com

Re: [ACS42] Feature Freeze reminder

[Prasanna Santhanam]

I've merged the plugin changes for simulator into master. Also ran the
checkin tests without issue. The only change was to move Mike's plugin
over to componentContext.xml instead of applicationContext.xml.

Thanks,

-- 
Prasanna.,

On Fri, Jun 28, 2013 at 11:57:16PM +, Edison Su wrote:
> Nice! Thanks for your great work, now we will have first primary storage 
> plugin in 4.2. 
> 
> > -Original Message-
> > From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> > Sent: Friday, June 28, 2013 4:07 PM
> > To: dev@cloudstack.apache.org
> > Subject: Re: [ACS42] Feature Freeze reminder
> > 
> > Hi Animesh,
> > 
> > Just to make sure I'm dealing with the correct repo, I pushed my code to
> > master here:
> > 
> > https://git-wip-us.apache.org/repos/asf/cloudstack.git
> > 
> > This is where I fetch from, but I had not done a push there until today, so 
> > I
> > just wanted to make sure it was the correct location (i.e. not a mirror)
> > (although, I suppose if it were a mirror, I wouldn't have had permission to
> > push to it).
> > 
> > Thanks
> > 
> > 
> > On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi <
> > animesh.chaturv...@citrix.com> wrote:
> > 
> > > Folks
> > >
> > > Today is the feature freeze date, if you plan to get your features
> > > into
> > > 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow
> > > morning PST.
> > >
> > >
> > >
> > > Thanks
> > > Animesh
> > >
> > 
> > 
> > 
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*



Powered by BigRock.com

RE: [ACS42] Feature Freeze reminder

[Sudha Ponnaganti]

Mike,

I have targeted the Ticket to 4.2 [1]
Added subtasks for QA/Doc and automation 

Wanted to check if there is someone with SolidFire background that can add test 
plan and do some validation for this plug-in

[1]  https://issues.apache.org/jira/browse/CLOUDSTACK-2778

Thanks
/sudha


-Original Message-
From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] 
Sent: Saturday, June 29, 2013 4:00 AM
To: dev@cloudstack.apache.org
Subject: RE: [ACS42] Feature Freeze reminder

Hi All,

Calling on community to see if someone is interested to pick up this plugin for 
validation

Require the following to close validation aspect for this plug-in:

- Functional test plan/ Automated tests to test this plug-in
- see cwiki for test plan template[1] and test results templates[2]
- FS and feature description are posted on the ticket [3]

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+Plans
[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/QA+-+4.2+Test+Execution+Results
[3] https://issues.apache.org/jira/browse/CLOUDSTACK-2778

Thanks
/sudha

-Original Message-
From: Edison Su [mailto:edison...@citrix.com]
Sent: Friday, June 28, 2013 4:57 PM
To: dev@cloudstack.apache.org
Subject: RE: [ACS42] Feature Freeze reminder

Nice! Thanks for your great work, now we will have first primary storage plugin 
in 4.2. 

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Friday, June 28, 2013 4:07 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Feature Freeze reminder
> 
> Hi Animesh,
> 
> Just to make sure I'm dealing with the correct repo, I pushed my code 
> to master here:
> 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> 
> This is where I fetch from, but I had not done a push there until 
> today, so I just wanted to make sure it was the correct location (i.e.
> not a mirror) (although, I suppose if it were a mirror, I wouldn't 
> have had permission to push to it).
> 
> Thanks
> 
> 
> On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi < 
> animesh.chaturv...@citrix.com> wrote:
> 
> > Folks
> >
> > Today is the feature freeze date, if you plan to get your features 
> > into
> > 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow 
> > morning PST.
> >
> >
> >
> > Thanks
> > Animesh
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

RE: [ACS42] Feature Freeze reminder

[Sudha Ponnaganti]

Hi All,

Calling on community to see if someone is interested to pick up this plugin for 
validation

Require the following to close validation aspect for this plug-in:

- Functional test plan/ Automated tests to test this plug-in
- see cwiki for test plan template[1] and test results templates[2]
- FS and feature description are posted on the ticket [3]

[1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+Plans
[2] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/QA+-+4.2+Test+Execution+Results
[3] https://issues.apache.org/jira/browse/CLOUDSTACK-2778

Thanks
/sudha

-Original Message-
From: Edison Su [mailto:edison...@citrix.com] 
Sent: Friday, June 28, 2013 4:57 PM
To: dev@cloudstack.apache.org
Subject: RE: [ACS42] Feature Freeze reminder

Nice! Thanks for your great work, now we will have first primary storage plugin 
in 4.2. 

> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Friday, June 28, 2013 4:07 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [ACS42] Feature Freeze reminder
> 
> Hi Animesh,
> 
> Just to make sure I'm dealing with the correct repo, I pushed my code 
> to master here:
> 
> https://git-wip-us.apache.org/repos/asf/cloudstack.git
> 
> This is where I fetch from, but I had not done a push there until 
> today, so I just wanted to make sure it was the correct location (i.e. 
> not a mirror) (although, I suppose if it were a mirror, I wouldn't 
> have had permission to push to it).
> 
> Thanks
> 
> 
> On Fri, Jun 28, 2013 at 4:44 PM, Animesh Chaturvedi < 
> animesh.chaturv...@citrix.com> wrote:
> 
> > Folks
> >
> > Today is the feature freeze date, if you plan to get your features 
> > into
> > 4.2 it needs to be in master today. I will cut 4.2 branch tomorrow 
> > morning PST.
> >
> >
> >
> > Thanks
> > Animesh
> >
> 
> 
> 
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*

Is there any patch file CS 4.1 to xen-6.2.0

[Keerthiraja SJ]

Hi All,



Is there any patch file for cloudstack-4.1 to added xenserver-6.2.0 .



I knew that
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
this file plays vital role to added xenserver-6.2.0 but it support only
upto 6.1 do u guys have any patch Just but adding into my cloudstack
location will help me.



I have installed Cloudstack as RPM it would be better to patch like script
to work in my installed CS.



Thanks,

Keerthi

Re: Unable to register templates and ISOs

[Nguyen Anh Tu]

I checked SSVM. Everything fine. DNS checking's ok and SSVM can connect to
MS port 8250. But it still can't register template. Log on MS said:

2013-06-29 15:38:35,133 DEBUG [storage.download.DownloadListener]
(Timer-5:null) Scheduling timeout at 3 ms, TEMPLATE: 201 at host 0
2013-06-29 15:38:35,134 DEBUG [storage.download.DownloadListener]
(Timer-5:null) NOT_DOWNLOADED first timeout: checking again , TEMPLATE: 201
at host 0

2013-06-29 15:39:05,134 DEBUG [storage.download.DownloadListener]
(Timer-5:null) timeout: transitioning to download error state,
currstate=NOT_DOWNLOADED, TEMPLATE: 201 at host 0
2013-06-29 15:39:05,290 WARN  [storage.download.DownloadListener]
(Timer-5:null) Entering download error state: timeout waiting for response
from storage host, TEMPLATE: 201 at host 0



2013/6/29 Harikrishna Patnala 

> Can you try troubleshooting the SSVM by following this link
>
> https://cwiki.apache.org/CLOUDSTACK/ssvm-templates-secondary-storage-troubleshooting.html
> Probably agent is not running in the SSVM due to which no entry is created
> in the host table.
> please try building systemvm and recreate ssvm
>
> -Harikrishna
>
> On 29-Jun-2013, at 9:37 AM, Nguyen Anh Tu  ng.t...@gmail.com>>
>  wrote:
>
> Hi,
>
> I got the same issue. Log say "there is no secondary storage..." and I see
> no record for ssvm in host table in DB.
>
> I cc your question to dev maillist. Anyone can help?
>
> Sent from my GT-N7000
> On 29 Jun 2013 03:30, "Tim Schultheiss"  >
> wrote:
>
> Hi all,
>
> I have a CS 4.1 zone with XenServer 6.1 hosts. They were configured
> locally,
> disconnected and sent to a remote site, and then reconnected. After
> reconnecting, I cannot register anything to the secondary storage in this
> zone. I checked the logs and saw that it said that my two secondary storage
> shares have no storage hosts. I have restarted the SSVM, deleted both it
> and
> the Console Proxy, and verified that they were remade.
> I can create instances from any templates already imported. The status of
> any template or ISO created is blank, and if I attempt to copy one over
> from
> another zone, it fails as well.
>
> Can anyone offer any insight?
>
> Here's what the log says:
> 2013-06-28 14:21:45,987 DEBUG [cloud.api.ApiServlet]
> (catalina-exec-23:null)
> ===START===  74.122.165.4 -- GET
>
>
> command=registerIso&response=json&sessionkey=H4EadP%2Bc8GKR0Ym224FWLav13Tw%3
>
>
> D&name=CentOS+6.4+Minimal&displayText=CentOS+6.4+Minimal&url=http%3A%2F%2Fmi
> rrors.vpsnoc.com
> %2FCentOS%2F6%2Fisos%2Fx86_642FCentOS-6.4-x86_64-minimal.iso
>
>
> &zoneid=5f86ad9d-d8bc-4832-8fcb-838586f2ba5c&isextractable=false&bootable=tr
>
>
> ue&osTypeId=63d22a42-d9a9-11e2-a93bb6bd483074cc&ispublic=false&isfeatured=fa
> lse&_=1372443705867
> 2013-06-28 14:21:46,225 WARN  [storage.download.DownloadMonitorImpl]
> (catalina-exec-23:null) There is no secondary storage VM for secondary
> storage host nfs://10.147.36.75/export/secondary
> 2013-06-28 14:21:46,325 DEBUG [cloud.api.ApiServlet]
> (catalina-exec-23:null)
> ===END===  74.122.165.4 -- GET
>
>
> command=registerIso&response=json&sessionkey=H4EadP%2Bc8GKR0Ym224FWLav13Tw%3
>
>
> D&name=CentOS+6.4+Minimal&displayText=CentOS+6.4+Minimal&url=http%3A%2F%2Fmi
> rrors.vpsnoc.com
> %2FCentOS%2F6%2Fisos%2Fx86_642FCentOS-6.4-x86_64-minimal.iso
>
>
> &zoneid=5f86ad9d-d8bc-4832-8fcb-838586f2ba5c&isextractable=false&bootable=tr
>
>
> ue&osTypeId=63d22a42-d9a9-11e2-a93bb6bd483074cc&ispublic=false&isfeatured=fa
> lse&_=1372443705867
> 2013-06-28 14:22:00,453 DEBUG
> [storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:null) Zone 10
> is ready to launch secondary storage VM
> 2013-06-28 14:22:01,218 DEBUG [cloud.consoleproxy.ConsoleProxyManagerImpl]
> (consoleproxy-1:null) Zone 10 is ready to launch console proxy
> 2013-06-28 14:22:03,252 DEBUG [cloud.server.StatsCollector]
> (StatsCollector-2:null) VmStatsCollector is running...
> 2013-06-28 14:22:03,295 DEBUG [agent.manager.ClusteredAgentAttache]
> (StatsCollector-2:null) Seq 26-927141969: Forwarding null to
> 147455086999471
> 2013-06-28 14:22:04,256 DEBUG [agent.transport.Request]
> (StatsCollector-2:null) Seq 26-927141969: Received:  { Ans: , MgmtId:
> 227165843378938, via: 26, Ver: v1, Flags: 10, {GetVmStatsAnswer } }
> 2013-06-28 14:22:04,282 DEBUG [agent.manager.ClusteredAgentAttache]
> (StatsCollector-2:null) Seq 27-1832978880: Forwarding null to
> 147455086999471
> 2013-06-28 14:22:05,365 DEBUG [agent.transport.Request]
> (StatsCollector-2:null) Seq 27-1832978880: Received:  { Ans: , MgmtId:
> 227165843378938, via: 27, Ver: v1, Flags: 10, {GetVmStatsAnswer } }
> 2013-06-28 14:22:18,465 DEBUG [cloud.server.StatsCollector]
> (StatsCollector-2:null) StorageCollector is running...
> 2013-06-28 14:22:18,476 DEBUG [cloud.server.StatsCollector]
> (StatsCollector-2:null) There is no secondary storage VM for secondary
> storage host nfs://10.147.36.75/export/secondary
> 2013-06-

Re: Unable to register templates and ISOs

[Harikrishna Patnala]

Can you try troubleshooting the SSVM by following this link
https://cwiki.apache.org/CLOUDSTACK/ssvm-templates-secondary-storage-troubleshooting.html
Probably agent is not running in the SSVM due to which no entry is created in 
the host table.
please try building systemvm and recreate ssvm

-Harikrishna

On 29-Jun-2013, at 9:37 AM, Nguyen Anh Tu 
mailto:ng.t...@gmail.com>>
 wrote:

Hi,

I got the same issue. Log say "there is no secondary storage..." and I see
no record for ssvm in host table in DB.

I cc your question to dev maillist. Anyone can help?

Sent from my GT-N7000
On 29 Jun 2013 03:30, "Tim Schultheiss" 
mailto:tschulthe...@dynamicquest.com>>
wrote:

Hi all,

I have a CS 4.1 zone with XenServer 6.1 hosts. They were configured
locally,
disconnected and sent to a remote site, and then reconnected. After
reconnecting, I cannot register anything to the secondary storage in this
zone. I checked the logs and saw that it said that my two secondary storage
shares have no storage hosts. I have restarted the SSVM, deleted both it
and
the Console Proxy, and verified that they were remade.
I can create instances from any templates already imported. The status of
any template or ISO created is blank, and if I attempt to copy one over
from
another zone, it fails as well.

Can anyone offer any insight?

Here's what the log says:
2013-06-28 14:21:45,987 DEBUG [cloud.api.ApiServlet]
(catalina-exec-23:null)
===START===  74.122.165.4 -- GET

command=registerIso&response=json&sessionkey=H4EadP%2Bc8GKR0Ym224FWLav13Tw%3

D&name=CentOS+6.4+Minimal&displayText=CentOS+6.4+Minimal&url=http%3A%2F%2Fmi
rrors.vpsnoc.com
%2FCentOS%2F6%2Fisos%2Fx86_642FCentOS-6.4-x86_64-minimal.iso

&zoneid=5f86ad9d-d8bc-4832-8fcb-838586f2ba5c&isextractable=false&bootable=tr

ue&osTypeId=63d22a42-d9a9-11e2-a93bb6bd483074cc&ispublic=false&isfeatured=fa
lse&_=1372443705867
2013-06-28 14:21:46,225 WARN  [storage.download.DownloadMonitorImpl]
(catalina-exec-23:null) There is no secondary storage VM for secondary
storage host nfs://10.147.36.75/export/secondary
2013-06-28 14:21:46,325 DEBUG [cloud.api.ApiServlet]
(catalina-exec-23:null)
===END===  74.122.165.4 -- GET

command=registerIso&response=json&sessionkey=H4EadP%2Bc8GKR0Ym224FWLav13Tw%3

D&name=CentOS+6.4+Minimal&displayText=CentOS+6.4+Minimal&url=http%3A%2F%2Fmi
rrors.vpsnoc.com
%2FCentOS%2F6%2Fisos%2Fx86_642FCentOS-6.4-x86_64-minimal.iso

&zoneid=5f86ad9d-d8bc-4832-8fcb-838586f2ba5c&isextractable=false&bootable=tr

ue&osTypeId=63d22a42-d9a9-11e2-a93bb6bd483074cc&ispublic=false&isfeatured=fa
lse&_=1372443705867
2013-06-28 14:22:00,453 DEBUG
[storage.secondary.SecondaryStorageManagerImpl] (secstorage-1:null) Zone 10
is ready to launch secondary storage VM
2013-06-28 14:22:01,218 DEBUG [cloud.consoleproxy.ConsoleProxyManagerImpl]
(consoleproxy-1:null) Zone 10 is ready to launch console proxy
2013-06-28 14:22:03,252 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) VmStatsCollector is running...
2013-06-28 14:22:03,295 DEBUG [agent.manager.ClusteredAgentAttache]
(StatsCollector-2:null) Seq 26-927141969: Forwarding null to
147455086999471
2013-06-28 14:22:04,256 DEBUG [agent.transport.Request]
(StatsCollector-2:null) Seq 26-927141969: Received:  { Ans: , MgmtId:
227165843378938, via: 26, Ver: v1, Flags: 10, {GetVmStatsAnswer } }
2013-06-28 14:22:04,282 DEBUG [agent.manager.ClusteredAgentAttache]
(StatsCollector-2:null) Seq 27-1832978880: Forwarding null to
147455086999471
2013-06-28 14:22:05,365 DEBUG [agent.transport.Request]
(StatsCollector-2:null) Seq 27-1832978880: Received:  { Ans: , MgmtId:
227165843378938, via: 27, Ver: v1, Flags: 10, {GetVmStatsAnswer } }
2013-06-28 14:22:18,465 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) StorageCollector is running...
2013-06-28 14:22:18,476 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) There is no secondary storage VM for secondary
storage host nfs://10.147.36.75/export/secondary
2013-06-28 14:22:18,480 DEBUG [cloud.server.StatsCollector]
(StatsCollector-2:null) There is no secondary storage VM for secondary
storage host nfs://10.147.36.76/export/secondary
2013-06-28 14:22:18,501 DEBUG [agent.manager.ClusteredAgentAttache]
(StatsCollector-2:null) Seq 26-927141970: Forwarding null to
147455086999471

Test Result for test-smoke-matrix #559

[Prasanna Santhanam]

Test Run: #559

Total:94
Fail :7
Skip :2


name   passfailskip
test_vm_life_cycle/   9   1   0
test_global_settings/ 1   0   0
test_affinity_groups/ 0   1   0
test_deploy_vm/   1   0   0
test_network_acl/ 1   0   0
test_regions/ 1   0   0
test_resource_detail/ 1   0   0
test_pvlan/   1   0   0
test_iso/ 5   0   1
test_deploy_vm_with_userdata/ 2   0   0
test_routers/10   0   0
test_disk_offerings/  3   0   0
test_scale_vm/0   1   0
test_deploy_vms_with_varied_deploymentplanners/   2   1   0
test_templates/   6   1   1
test_internal_lb/ 1   0   0
test_nic/ 1   0   0
test_portable_publicip/   2   0   0
test_non_contigiousvlan/  1   0   0
test_ssvm/   10   0   0
test_network/ 8   2   0
test_public_ip_range/ 1   0   0
test_vm_snapshots/3   0   0
test_volumes/ 9   0   0
test_guest_vlan_range/1   0   0
test_privategw_acl/   1   0   0
test_service_offerings/   4   0   0



Regressions



Failures

name
durationage
integration.smoke.test_vm_life_cycle.TestVMLifeCycle.test_10_attachAndDetach_iso
  60.309  6
integration.smoke.test_affinity_groups.TestDeployVmWithAffinityGroup.test_DeployVmAntiAffinityGroup
0.113 26
integration.smoke.test_scale_vm.TestScaleVm.test_01_scale_vm
   5.175 34
integration.smoke.test_deploy_vms_with_varied_deploymentplanners.TestDeployVmWithVariedPlanners.test_deployvm_userdispersing
 181.766145
integration.smoke.test_templates.TestTemplates.test_04_extract_template 
   5.092  3
integration.smoke.test_network.TestAssignRemoveLB.test_assign_and_removal_lb
 348.935  2
integration.smoke.test_network.TestLoadBalancingRule.test_02_create_lb_rule_non_nat
   15.443 34

Fixed

name
   durationage
integration.smoke.test_templates.TestTemplates.test_03_delete_template  
  5.107  0
integration.smoke.test_network.TestDeleteAccount.test_delete_account
393.394  0
integration.smoke.test_network.TestLoadBalancingRule.test_01_create_lb_rule_src_nat
 157.437  0
integration.smoke.test_network.TestPortForwarding.test_01_port_fwd_on_src_nat   
111.589  0
integration.smoke.test_network.TestPortForwarding.test_02_port_fwd_on_non_src_nat
30.585  0

Latest report @
http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/lastCompletedBuild/testReport/

Thanks,

-- 
Prasanna.,


Powered by BigRock.com

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

[Sateesh Chodapuneedi]

> On June 29, 2013, 7:33 a.m., Prasanna Santhanam wrote:
> > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java,
> >  line 59
> > 
> >
> > This block should simply be:
> > 
> > if (dataStoreVO == null) {
> > throw new CloudRuntimeException("Unable to locate primary 
> > datastore with id " + dataStoreVO.getId());   
> > }   
> > String providerName = dataStoreVO.getStorageProviderName();

Use dataStoreId instead of dataStoreVO.getId() in exception message 


- Sateesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/#review22563
---


On June 29, 2013, 12:48 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12180/
> ---
> 
> (Updated June 29, 2013, 12:48 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3110
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing an NPE when an attempt is made to add a primary datastore by providing 
> an unreachable/nonexistent datastore/host.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
>  06b54e0 
> 
> Diff: https://reviews.apache.org/r/12180/diff/
> 
> 
> Testing
> ---
> 
> With fix in place, an attempt to add an invalid primary datastore will fail 
> with a GUI error dialog instead of failing silently with an NPE in the mgmt 
> server log.
> 
> 
> File Attachments
> 
> 
> Refactored patch for master-6-17-stable branch
>   
> https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

[Prasanna Santhanam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/#review22563
---



engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java


This block should simply be:

if (dataStoreVO == null) {
throw new CloudRuntimeException("Unable to locate primary 
datastore with id " + dataStoreVO.getId());   
}   
String providerName = dataStoreVO.getStorageProviderName();


- Prasanna Santhanam


On June 29, 2013, 12:48 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12180/
> ---
> 
> (Updated June 29, 2013, 12:48 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3110
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing an NPE when an attempt is made to add a primary datastore by providing 
> an unreachable/nonexistent datastore/host.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
>  06b54e0 
> 
> Diff: https://reviews.apache.org/r/12180/diff/
> 
> 
> Testing
> ---
> 
> With fix in place, an attempt to add an invalid primary datastore will fail 
> with a GUI error dialog instead of failing silently with an NPE in the mgmt 
> server log.
> 
> 
> File Attachments
> 
> 
> Refactored patch for master-6-17-stable branch
>   
> https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request 12180: Fix NPE when adding invalid primary datastore

[Sateesh Chodapuneedi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12180/#review22562
---



engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java


LGTM.
Can you also add datastore id in the log message. It's useful to know the 
datastore that is not found.


- Sateesh Chodapuneedi


On June 29, 2013, 12:48 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12180/
> ---
> 
> (Updated June 29, 2013, 12:48 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and 
> Sateesh Chodapuneedi.
> 
> 
> Bugs: CLOUDSTACK-3110
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Fixing an NPE when an attempt is made to add a primary datastore by providing 
> an unreachable/nonexistent datastore/host.
> 
> 
> Diffs
> -
> 
>   
> engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java
>  b92f92f 
>   
> engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java
>  06b54e0 
> 
> Diff: https://reviews.apache.org/r/12180/diff/
> 
> 
> Testing
> ---
> 
> With fix in place, an attempt to add an invalid primary datastore will fail 
> with a GUI error dialog instead of failing silently with an NPE in the mgmt 
> server log.
> 
> 
> File Attachments
> 
> 
> Refactored patch for master-6-17-stable branch
>   
> https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>