Re: Review Request 15175: Added a verifyElementInList utility function
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/#review28513 --- 4.2: b18e730108e6a24e00c372e3c56c655ff51106ba - Girish Shilamkar On Nov. 1, 2013, 7:44 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15175/ --- (Updated Nov. 1, 2013, 7:44 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- The purpose is to verify a given element in list at a given position with few error checks like list type,empty list and position Returns appropriate codes based upon the inputs. Can be used under tests instead of multiple asserts Earlier, there was a list validity function, this is on top of that. Need to go to both master and 4.2 Diffs - tools/marvin/marvin/codes.py bd01ad3 tools/marvin/marvin/integration/lib/utils.py b6e38ec Diff: https://reviews.apache.org/r/15175/diff/ Testing --- Tested. from utils import verifyElementInList a=[1,2,3] verifyElementInList(a,2) [0, 'ELEMENT NOT FOUND IN THE INPUT'] verifyElementInList(a,1) [1, None] verifyElementInList(a,3) [0, 'ELEMENT NOT FOUND IN THE INPUT'] Thanks, Santhosh Edukulla
Re: 4.2.1 BVT automation results
On Nov 7, 2013, at 9:54 AM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi Sebastian, I don't think so we are running automation 4.2.1 branch in jenkins.buildacloud.org, below result is from master branch; So how did you come up with the results for the 4.2.1 branch ? http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/ Also I reported master failures in ASF jira https://issues.apache.org/jira/browse/CLOUDSTACK-5050 https://issues.apache.org/jira/browse/CLOUDSTACK-5049 https://issues.apache.org/jira/browse/CLOUDSTACK-5047 https://issues.apache.org/jira/browse/CLOUDSTACK-5046 https://issues.apache.org/jira/browse/CLOUDSTACK-5045 https://issues.apache.org/jira/browse/CLOUDSTACK-4835 NOTE : I ran automation with RHEL 6.3 Regards, Rayees -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, November 07, 2013 12:29 AM To: dev@cloudstack.apache.org Subject: Re: 4.2.1 BVT automation results On Nov 6, 2013, at 6:07 PM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi All, 4.2.1 BVT automation results published to cwiki; you can see the results below https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2.1+Automation+Result Regards, Rayees Where are those results coming from ? The qa and simulator jobs on http://jenkins.buildacloud.org/view/simulator/ seem to have been failing for a while Also it would be great if the results table could have the OS version. Technically we need to have each set run on ubuntu 12.04 and Centos6.4. -sebastien
Re: [Cloudmonkey] assignVirtualMachine API causes index out of range error
Finally got a new environment to build from source code (4.2 branch).
Unfortunately, it still crashes Cloudmonkey. The error messages are exactly
the same. Here's the new Cloudmonkey log:
2013-11-08 16:15:34,242 - requester.py:45 - [DEBUG] START Request
2013-11-08 16:15:34,242 - requester.py:45 - [DEBUG] Requesting
command=assignVirtualMachine, args={'account': 'user', 'domainid':
'e55f7756-4842-11e3-a696-f6180bef7a51', 'virtualmachineid':
'd4da5cd7-9f68-4fd0-beda-c285e432911d'}
2013-11-08 16:15:34,243 - requester.py:45 - [DEBUG] Request sent:
http://localhost:8080/client/api?account=userapiKey=Jxqh9fiJhBVaXHoBKSvNvqhYl3j-qNW_04kDoyW27RgZMiJe0pduFfUuRP8cPnOEAFZnyIrrGoZaVUubWk9JQQcommand=assignVirtualMachinedomainid=e55f7756-4842-11e3-a696-f6180bef7a51response=jsonvirtualmachineid=d4da5cd7-9f68-4fd0-beda-c285e432911dsignature=opZc9bQmW34AN1OcVps%2Fxb%2BKtVU%3D
2013-11-08 16:15:34,488 - requester.py:45 - [DEBUG] Response received: {
virtualmachine : { virtualmachine :
{id:d4da5cd7-9f68-4fd0-beda-c285e432911d,name:assignVM-API,displayname:assignVM-API,account:user,domainid:e55f7756-4842-11e3-a696-f6180bef7a51,domain:ROOT,created:2013-11-08T16:08:58+0800,state:Stopping,haenable:false,zoneid:0c1268f1-efda-42a8-80a7-5e7d2a6aaf0a,zonename:Zone,hostid:24f982b3-3a9a-4fb5-ba78-9e44c04a2e39,hostname:xenserver-205-15,templateid:91050f5c-3212-4412-85d1-0035a0f754ef,templatename:CentOS-6.4-x86_64-XS62,templatedisplaytext:CentOS-6.4-x86_64-XS62,passwordenabled:false,serviceofferingid:1c081f6f-fa14-4db3-b5ec-34c203f6b9b5,serviceofferingname:Medium
Instance,cpunumber:1,cpuspeed:1000,memory:1024,cpuused:0.01%,networkkbsread:0,networkkbswrite:1,diskkbsread:0,diskkbswrite:0,diskioread:0,diskiowrite:0,guestosid:e4f94c9c-4842-11e3-a696-f6180bef7a51,rootdeviceid:0,rootdevicetype:ROOT,securitygroup:[],nic:[{id:c18c7ef0-061f-404c-baab-4ffd585cbfec,networkid:26642bfa-a037-40a0-bcaf-81aded2a4cf4,networkname:user-1,netmask:255.255.255.0,gateway:10.1.1.1,ipaddress:10.1.1.228,isolationuri:vlan://850,broadcasturi:vlan://850,traffictype:Guest,type:Isolated,isdefault:true,macaddress:02:00:47:3e:00:03}],hypervisor:XenServer,instancename:i-2-8-VM,tags:[],affinitygroup:[],displayvm:true,isdynamicallyscalable:true,details:{hypervisortoolsversion:xenserver56},jobid:d9368add-bc64-45f7-83a7-de498cef730b,jobstatus:0}
} }
2013-11-08 16:15:34,488 - requester.py:45 - [DEBUG] END Request
Hence, I'm reopening the ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-4998
---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw or ryanlei750...@gmail.com
On Wed, Oct 30, 2013 at 4:11 PM, Sebastien Goasguen run...@gmail.comwrote:
On Oct 30, 2013, at 2:40 AM, Ryan Lei ryan...@cht.com.tw wrote:
Ticket created:
https://issues.apache.org/jira/browse/CLOUDSTACK-4998
Ryan, I fixed it in master and 4.2. Any chance you can compile from source
and check again ?
thanks
---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw
https://email.cht.com.tw/owa/redir.aspx?C=-wE1FEC3G0SWYpVkiWo8SsDdf3ZqO9AIuAPTzRnFYCUi-z4YljtI_hyVKkNHfn9F1Bn-vUWJnQ4.URL=mailto%3aryanlei%40cht.com.tw
or
ryanlei750...@gmail.com
On Wed, Oct 30, 2013 at 2:04 PM, Rohit Yadav bhais...@apache.org
wrote:
On Mon, Oct 28, 2013 at 1:52 PM, Sebastien Goasguen run...@gmail.com
wrote:
I think the error is in the java code of AssignVirtualMachine:
api/src/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java:
@APICommand(name = assignVirtualMachine, description=Change
ownership
of a VM from one account to another. This API is available for Basic
zones
with security groups and Advanced zones with guest networks. A root
administrator can reassign a VM from any account to any other account
in
any domain. A domain administrator can reassign a VM to any account in
the
same domain., responseObject=UserVmResponse.class, since=3.0.0)
public class AssignVMCmd extends BaseCmd {
public static final Logger s_logger =
Logger.getLogger(AssignVMCmd.class.getName());
private static final String s_name = moveuservmresponse;
Shouldn't the string be assignvirtualmachineresponse ?
Thanks Ryan for the output, Sebastien is right the response string of
AssignVMCmd
should be fixed. Please open a bug ticket, patch contributions are most
welcome :)
Regards.
On Oct 27, 2013, at 11:02 PM, Ryan Lei ryan...@cht.com.tw wrote:
Here's the assignVirtualMachine response json from log:
2013-10-25 17:02:54,107 - cloudmonkey.py:83 - [DEBUG] Loaded config
fields:
['cache_file=/root/.cloudmonkey/cache',
'log_file=/root/.cloudmonkey/log', 'asyncblock=true',
Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15344/ --- Review request for cloudstack, Abhinandan Prateek and Darren Shepherd. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916 Repository: cloudstack-git Description --- To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING.. Diffs - client/tomcatconf/db.properties.in b0cb22b framework/db/src/com/cloud/utils/db/ConnectionConcierge.java acb9cc6 framework/db/src/com/cloud/utils/db/Merovingian2.java 8544aab framework/db/src/com/cloud/utils/db/TransactionLegacy.java a874ce1 Diff: https://reviews.apache.org/r/15344/diff/ Testing --- Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail Thanks, Damodar Reddy Talakanti
Re: Review Request 14784: [CLOUDSTACK-4805] Installation instructions drops support for Ubuntu
On Nov. 7, 2013, 7:38 p.m., Sebastien Goasguen wrote: this does not seem to apply. Can you please pull the latest and see what's going on thanks Travis Graham wrote: Do you want this based against master or 4.2? The patch was originally created against 4.2. I tried both master and 4.2 branch in the new docs repo and there is an error. We most likely needs the patch in both branches. If you look it up and I am happy to apply it asap. thanks - Sebastien --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14784/#review28433 --- On Nov. 7, 2013, 6:53 p.m., Travis Graham wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14784/ --- (Updated Nov. 7, 2013, 6:53 p.m.) Review request for cloudstack and Joe Brockmeier. Repository: cloudstack-docs Description --- (section 4.5.7.2) reflect steps for RHEL/CentOS and Ubuntu. Diffs - en-US/nfs-shares-on-management-server.xml 881ca8d Diff: https://reviews.apache.org/r/14784/diff/ Testing --- Thanks, Travis Graham
Re: Review Request 13922: Minimal Hyper-V Plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13922/#review28518 --- Ship it! The feature was merged and changes committed to master in commit id f9f196a46ad820198894ef1ebba3d61413d5da59. - Devdeep Singh On Sept. 5, 2013, 8:29 a.m., Donal Lafferty wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13922/ --- (Updated Sept. 5, 2013, 8:29 a.m.) Review request for cloudstack, Alex Huang, Chiradeep Vittal, and Devdeep Singh. Repository: cloudstack-git Description --- A plugin for Hyper-V control is available for CloudStack. The plugin implements basic VM control; however, its architecture allows additional functionality to be easily added. Incorporating the plugin in CloudStack will allow the community to participate in improving the features available with Hyper-V. The plugin uses a Director Connect Agent architecture described here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress This links provides details of third party libraries used by the plugin including their licenses. No source for these libraries is used, and the binaries are downloaded from their distributors at build time. No proprietary tools are required for the build. For instance, C# compiled with Mono has been tested. Therefore, the plugin has been added to the default build and the default deployment. The plugin includes unit and functional tests that can be triggered at build time. See the link above for details. The Apache header is applied to source and where feasible to build config files. The source is the https://github.com/lafferty/cloudstack/tree/hyperv_plugin Diffs - client/pom.xml 1afe5b898d328b06b5da7c132eaed14fefc78718 client/tomcatconf/applicationContext.xml.in 956c77c5fa6c3d909be1fbee8ba26e8d8ba1dce7 client/tomcatconf/componentContext.xml.in f36d0ee02a2eb91733f6f2a76be60a1477529d4d client/tomcatconf/simulatorComponentContext.xml.in c46d1de086a5633b64c90884dbc02a03c3b2e8ad plugins/hypervisors/hyperv/DotNet/ServerResource/.gitignore PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.targets PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.Designer.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.Designer.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShellException.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/App.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/Program.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/Properties/AssemblyInfo.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/packages.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/App.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Properties/AssemblyInfo.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCalls.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/packages.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/App.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/HypervResourceControllerTest.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/Properties/AssemblyInfo.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/ServerResource.Tests.csproj PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/packages.config PRE-CREATION
Re: Review Request 13745: CLOUDSTACK-4329: [DOC] Added Linux template creation documentation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13745/#review28517 --- Marty, it looks like this was lost somehow when we moved to the docs only repo. Can you check out that repo and send a new patch. Let me know if this applies to master and 4.2 - Sebastien Goasguen On Aug. 22, 2013, 6:32 p.m., Marty Sweet wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13745/ --- (Updated Aug. 22, 2013, 6:32 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-4329 https://issues.apache.org/jira/browse/CLOUDSTACK-4329 Repository: cloudstack-git Description --- Added 2 documents (prepare-linux-template and create-linux-template) which covers details explained in CLOUDSTACK-4329 on how to create a working Linux Template. Adjusted working-with-templates.xml to add menu item - it appears the patch has chosen to delete the file, then recreate it at the bottom of the patch. Diffs - docs/en-US/create-linux-template.xml PRE-CREATION docs/en-US/prepare-linux-template.xml PRE-CREATION docs/en-US/working-with-templates.xml 9f4e750 docs/en-US/working-with-templates.xml PRE-CREATION Diff: https://reviews.apache.org/r/13745/diff/ Testing --- Documents build with Publican Thanks, Marty Sweet
Re: Review Request 13922: Minimal Hyper-V Plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13922/#review28519 --- Ship it! The feature was merged and changes committed to master in commit id f9f196a46ad820198894ef1ebba3d61413d5da59. - Devdeep Singh On Sept. 5, 2013, 8:29 a.m., Donal Lafferty wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13922/ --- (Updated Sept. 5, 2013, 8:29 a.m.) Review request for cloudstack, Alex Huang, Chiradeep Vittal, and Devdeep Singh. Repository: cloudstack-git Description --- A plugin for Hyper-V control is available for CloudStack. The plugin implements basic VM control; however, its architecture allows additional functionality to be easily added. Incorporating the plugin in CloudStack will allow the community to participate in improving the features available with Hyper-V. The plugin uses a Director Connect Agent architecture described here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Progress This links provides details of third party libraries used by the plugin including their licenses. No source for these libraries is used, and the binaries are downloaded from their distributors at build time. No proprietary tools are required for the build. For instance, C# compiled with Mono has been tested. Therefore, the plugin has been added to the default build and the default deployment. The plugin includes unit and functional tests that can be triggered at build time. See the link above for details. The Apache header is applied to source and where feasible to build config files. The source is the https://github.com/lafferty/cloudstack/tree/hyperv_plugin Diffs - client/pom.xml 1afe5b898d328b06b5da7c132eaed14fefc78718 client/tomcatconf/applicationContext.xml.in 956c77c5fa6c3d909be1fbee8ba26e8d8ba1dce7 client/tomcatconf/componentContext.xml.in f36d0ee02a2eb91733f6f2a76be60a1477529d4d client/tomcatconf/simulatorComponentContext.xml.in c46d1de086a5633b64c90884dbc02a03c3b2e8ad plugins/hypervisors/hyperv/DotNet/ServerResource/.gitignore PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.Config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/.nuget/NuGet.targets PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.Designer.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentService.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.Designer.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentSettings.settings PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShell.csproj PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/AgentShellException.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/App.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/Program.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/Properties/AssemblyInfo.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/AgentShell/packages.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/App.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResource.csproj PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Properties/AssemblyInfo.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCalls.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/packages.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/App.config PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/HypervResourceControllerTest.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/Properties/AssemblyInfo.cs PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/ServerResource.Tests.csproj PRE-CREATION plugins/hypervisors/hyperv/DotNet/ServerResource/ServerResource.Tests/packages.config PRE-CREATION
Re: [DOC] 4.2.0 Templates
On Oct 27, 2013, at 7:02 AM, Marty Sweet msweet@gmail.com wrote: Hi, Is there any update on this? My commit https://github.com/apache/cloudstack/commit/f5e7f46dadda741f10e5b674d0578ade9ba719d7 made it into the 4.2.0 docs but https://github.com/apache/cloudstack/commit/922ef76224d4a8534f67f47b97cf664e5c65ecba hasn't, I have gone to use this several times just to remember it's not there :) Marty, I commented on your patch: https://reviews.apache.org/r/13745/ Seems to me your patch was lost somehow in the move to the new repo. Can you also make sure that you have your author info in there, otherwise we loose the authorship info. Just use git config to set your name and email in your patch. thanks, -sebastien Thanks, Marty On Thu, Oct 10, 2013 at 10:05 AM, Daan Hoogland daan.hoogl...@gmail.comwrote: Marty, As I understand the master branch for docs will be filled as work on it starts. the ones in the 4.2 branch are the current ones. btw commits get hidden, rarely lost :p regards, On Thu, Oct 10, 2013 at 8:29 AM, Marty Sweet msweet@gmail.com wrote: Where will the docs commited to the master become available? This probably isn't the only case where commits have been lost? https://reviews.apache.org/r/13745/ On Thu, Oct 10, 2013 at 1:17 AM, Radhika Puthiyetath radhika.puthiyet...@citrix.com wrote: 4.2 docs are from 4.2 branch. -Original Message- From: Marty Sweet [mailto:msweet@gmail.com] Sent: Thursday, October 10, 2013 3:27 AM To: dev@cloudstack.apache.org Subject: Re: [DOC] 4.2.0 Templates Hi Daan, Yeah the doc directory in the repo commited to master, where is the current http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Admin_Guide/working-with-templates.html being built from? Marty On Wed, Oct 9, 2013 at 8:55 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Marty, I am not sure what you mean. Do you mean the doc dir in the repo? I think you need to look in https://git-wip-us.apache.org/repos/asf/cloudstack-docs.git for the 4.2 docs. regards, Daan On Sun, Oct 6, 2013 at 10:51 PM, Marty Sweet msweet@gmail.com wrote: Hi guys, I created a document for creating Linux documentation for the 4.2.0 release. Checking the documentation it seems that it is not there? Is there any reason for this? http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/A dmin_Guide/working-with-templates.html https://github.com/apache/cloudstack/commit/922ef76224d4a8534f67f47b97 cf664e5c65ecba https://issues.apache.org/jira/browse/CLOUDSTACK-4329 Thanks, Marty
Re: Review Request 14648: Added few changes related to 4870
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/#review28520 --- 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de - Girish Shilamkar On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/ --- (Updated Oct. 15, 2013, 12:10 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Added few naming convention changes--minor. Diffs - tools/marvin/marvin/deployDataCenter.py beed8c8 Diff: https://reviews.apache.org/r/14648/diff/ Testing --- Thanks, Santhosh Edukulla
Re: Review Request 14595: Adding https support to marvin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14595/#review28521 --- 4.2: 6e1821f585df5c643873ab0ce1e7d91d1d94f00d - Girish Shilamkar On Oct. 11, 2013, 12:51 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14595/ --- (Updated Oct. 11, 2013, 12:51 p.m.) Review request for cloudstack, daan Hoogland and Prasanna Santhanam. Bugs: 4832 https://issues.apache.org/jira/browse/4832 Repository: cloudstack-git Description --- adding support to marvin for https. We will allow user to specify whether to usehttps or not using three params useHttps, certCAPath, certPath - the params are self explanatory Diffs - setup/dev/advanced.cfg 4a48399 tools/marvin/marvin/cloudstackConnection.py 686c533 tools/marvin/marvin/cloudstackTestClient.py 36f7f8d tools/marvin/marvin/configGenerator.py a966ae0 tools/marvin/marvin/deployDataCenter.py beed8c8 Diff: https://reviews.apache.org/r/14595/diff/ Testing --- Tested against http. Setting up https environment for testing. Will appreciate a test if anyone has https enabled on their setup Thanks, Santhosh Edukulla
Re: [Cloudmonkey] assignVirtualMachine API causes index out of range error
On Nov 8, 2013, at 10:29 AM, Ryan Lei ryan...@cht.com.tw wrote:
Super. The Cloudmonkey crash is fixed now. Thanks a a lot, Sebastien!!
You are right about this line:
- response.setResponseName(DeployVMCmd.getResultObjectName());
+ response.setResponseName(getCommandName());
Please also commit this change to master.
great thanks for testing it, I applied it to master.
Can you close the bug please.
---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw or ryanlei750...@gmail.com
On Fri, Nov 8, 2013 at 4:50 PM, Sebastien Goasguen run...@gmail.com wrote:
Ryan,
I found another bug in that class, can you try again with a fresh pull of
4.2 branch ?
thanks
On Nov 8, 2013, at 3:40 AM, Sebastien Goasguen run...@gmail.com wrote:
Can you get on IRC ?
On Nov 8, 2013, at 3:27 AM, Ryan Lei ryan...@cht.com.tw wrote:
Finally got a new environment to build from source code (4.2 branch).
Unfortunately, it still crashes Cloudmonkey. The error messages are
exactly
the same. Here's the new Cloudmonkey log:
2013-11-08 16:15:34,242 - requester.py:45 - [DEBUG] START
Request
2013-11-08 16:15:34,242 - requester.py:45 - [DEBUG] Requesting
command=assignVirtualMachine, args={'account': 'user', 'domainid':
'e55f7756-4842-11e3-a696-f6180bef7a51', 'virtualmachineid':
'd4da5cd7-9f68-4fd0-beda-c285e432911d'}
2013-11-08 16:15:34,243 - requester.py:45 - [DEBUG] Request sent:
http://localhost:8080/client/api?account=userapiKey=Jxqh9fiJhBVaXHoBKSvNvqhYl3j-qNW_04kDoyW27RgZMiJe0pduFfUuRP8cPnOEAFZnyIrrGoZaVUubWk9JQQcommand=assignVirtualMachinedomainid=e55f7756-4842-11e3-a696-f6180bef7a51response=jsonvirtualmachineid=d4da5cd7-9f68-4fd0-beda-c285e432911dsignature=opZc9bQmW34AN1OcVps%2Fxb%2BKtVU%3D
2013-11-08 16:15:34,488 - requester.py:45 - [DEBUG] Response received: {
virtualmachine : { virtualmachine :
{id:d4da5cd7-9f68-4fd0-beda-c285e432911d,name:assignVM-API,displayname:assignVM-API,account:user,domainid:e55f7756-4842-11e3-a696-f6180bef7a51,domain:ROOT,created:2013-11-08T16:08:58+0800,state:Stopping,haenable:false,zoneid:0c1268f1-efda-42a8-80a7-5e7d2a6aaf0a,zonename:Zone,hostid:24f982b3-3a9a-4fb5-ba78-9e44c04a2e39,hostname:xenserver-205-15,templateid:91050f5c-3212-4412-85d1-0035a0f754ef,templatename:CentOS-6.4-x86_64-XS62,templatedisplaytext:CentOS-6.4-x86_64-XS62,passwordenabled:false,serviceofferingid:1c081f6f-fa14-4db3-b5ec-34c203f6b9b5,serviceofferingname:Medium
Instance,cpunumber:1,cpuspeed:1000,memory:1024,cpuused:0.01%,networkkbsread:0,networkkbswrite:1,diskkbsread:0,diskkbswrite:0,diskioread:0,diskiowrite:0,guestosid:e4f94c9c-4842-11e3-a696-f6180bef7a51,rootdeviceid:0,rootdevicetype:ROOT,securitygroup:[],nic:[{id:c18c7ef0-061f-404c-baab-4ffd585cbfec,networkid:26642bfa-a037-40a0-bcaf-81aded2a4cf4,networkname:user-1,netmask:255.255.255.0,gateway:10.1.1.1,ipaddress:10.1.1.228,isolationuri:vlan://850,broadcasturi:vlan://850,traffictype:Guest,type:Isolated,isdefault:true,macaddress:02:00:47:3e:00:03}],hypervisor:XenServer,instancename:i-2-8-VM,tags:[],affinitygroup:[],displayvm:true,isdynamicallyscalable:true,details:{hypervisortoolsversion:xenserver56},jobid:d9368add-bc64-45f7-83a7-de498cef730b,jobstatus:0}
} }
2013-11-08 16:15:34,488 - requester.py:45 - [DEBUG] END Request
Hence, I'm reopening the ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-4998
---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw or ryanlei750...@gmail.com
On Wed, Oct 30, 2013 at 4:11 PM, Sebastien Goasguen run...@gmail.com
wrote:
On Oct 30, 2013, at 2:40 AM, Ryan Lei ryan...@cht.com.tw wrote:
Ticket created:
https://issues.apache.org/jira/browse/CLOUDSTACK-4998
Ryan, I fixed it in master and 4.2. Any chance you can compile from
source
and check again ?
thanks
---
Yu-Heng (Ryan) Lei, Associate Researcher
Chunghwa Telecom Laboratories / Cloud Computing Laboratory
ryan...@cht.com.tw
https://email.cht.com.tw/owa/redir.aspx?C=-wE1FEC3G0SWYpVkiWo8SsDdf3ZqO9AIuAPTzRnFYCUi-z4YljtI_hyVKkNHfn9F1Bn-vUWJnQ4.URL=mailto%3aryanlei%40cht.com.tw
or
ryanlei750...@gmail.com
On Wed, Oct 30, 2013 at 2:04 PM, Rohit Yadav bhais...@apache.org
wrote:
On Mon, Oct 28, 2013 at 1:52 PM, Sebastien Goasguen
run...@gmail.com
wrote:
I think the error is in the java code of AssignVirtualMachine:
api/src/org/apache/cloudstack/api/command/admin/vm/AssignVMCmd.java:
@APICommand(name = assignVirtualMachine, description=Change
ownership
of a VM from one account to another. This API is available for Basic
Re: Review Request 14869: Added changes related to bug 4920 and few code clean up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14869/#review28524 --- 4.2: 87983e09e21c51dbef6b2a8a0252b039e32915ad - Girish Shilamkar On Oct. 23, 2013, 8:19 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14869/ --- (Updated Oct. 23, 2013, 8:19 a.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- 1. Currently, there was one issue found in requests library. 2. Added change to strip the command string passed to marvin request command 3. Removed few unwanted code. 4. Made the testclient uniform to pass both mgt and dbsrv details. 5. Fixed one issue in request call Diffs - tools/marvin/marvin/cloudstackConnection.py df88fa2 tools/marvin/marvin/cloudstackTestClient.py 5dcd8bf tools/marvin/marvin/codegenerator.py 96729f6 tools/marvin/marvin/configGenerator.py 45c3d69 tools/marvin/marvin/deployDataCenter.py 6b5f64b Diff: https://reviews.apache.org/r/14869/diff/ Testing --- Tested changes on simulator, it created entities post the run so it seems tests were working fine. Thanks, Santhosh Edukulla
Re: Review Request 15208: Added fix for bug 5032. Provides custom assert facility to test features. Added the new assert to cloudstackTestCase
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/#review28527 --- 4.2: c76da53123f4130ac59bdf112171bc2e39af91d4 - Girish Shilamkar On Nov. 4, 2013, 5:22 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15208/ --- (Updated Nov. 4, 2013, 5:22 p.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-5032 https://issues.apache.org/jira/browse/CLOUDSTACK-5032 Repository: cloudstack-git Description --- Added custom assert by name assertElementInList to cloudstackTestCase, this will help users to simplify their asserts. Allows users to dump custom message for these asserts. Changed the Interface for verifyElementInList to take additional argument. Diffs - tools/marvin/marvin/cloudstackTestCase.py 85ef542 tools/marvin/marvin/integration/lib/utils.py d53c1ae Diff: https://reviews.apache.org/r/15208/diff/ Testing --- Thanks, Santhosh Edukulla
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/#review28528 --- Santhosh, Please update the diff instead of uploading them as different file. - Girish Shilamkar On Nov. 8, 2013, 7:16 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/ --- (Updated Nov. 8, 2013, 7:16 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5099 https://issues.apache.org/jira/browse/CLOUDSTACK-5099 Repository: cloudstack-git Description --- 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it. 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote Diffs - Diff: https://reviews.apache.org/r/15341/diff/ Testing --- File Attachments patch file https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch patchfile https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch Thanks, Santhosh Edukulla
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
H Sheng, All sdn implementations use the field in one way or another as uri. So if this is wrong reverting my patch won't do the trick, I am afraid. I actually think the field should be renamed to broadcastUri, as this is how it is used at the moment by a lot of elements. Going back to only allowing vlans as isolation method is not going to solve anything as the feature is still desired. The alternative is adding a field/parameter all over the code and have all methods check both fields for valid values to decide what to do. The patch runs in production at the moment on a 4.1.1 fork on a xen based cloud and on a mixed xen/vmware cloud as well. It has been heavily tested in master. I don't value my implementation of the requirement and am happy to discuss better implementations and the scope of validity of vlan-ids and broadcast uris but the feature it fulfills is very needed (and works). kind regards, Daan On Fri, Nov 8, 2013 at 1:35 AM, Sheng Yang sh...@yasker.org wrote: Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId and secondaryVlanId are both numbers, not URI. Please revert it. --Sheng On Thu, Nov 7, 2013 at 4:07 PM, Min Chen min.c...@citrix.com wrote: Then we need to clearly define the semantic of parameter vlanId of HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not other format. The invoker method should pass the correct one to this utility to make it work. Thanks -min On 11/7/13 3:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Doesn't sound like a guarantee, If the stack is build otherwise there might come in a different (non-integer-representing) string. On Thu, Nov 7, 2013 at 6:08 PM, Min Chen min.c...@citrix.com wrote: Yes. From callstack, BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is already called before going to that routine. Thanks -min On 11/7/13 1:51 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan://some_number , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromSt ri ng(vlanId))); regards, Daan On Wed, Nov 6, 2013 at 3:25 AM, Min Chen min.c...@citrix.com wrote: Hi Daan, Your commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=25c 8c ee01a450ee924fe108cafe54b046485ab2b broke Vmware advanced zone setup on Master, where system vm starts failed with NumberFormatException, see details in https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this blocker bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part of your change on HypervisorHostHelper method, but not sure if there is any side effect on your another functionality fixed in your commit. Can you please review to make sure that it is ok? Thanks -min
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/ --- (Updated Nov. 8, 2013, 10:43 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5099 https://issues.apache.org/jira/browse/CLOUDSTACK-5099 Repository: cloudstack-git Description --- 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it. 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote Diffs (updated) - tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15341/diff/ Testing --- File Attachments patch file https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch patchfile https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch Thanks, Santhosh Edukulla
Re: Review Request 14648: Added few changes related to 4870
On Nov. 8, 2013, 9:15 a.m., Girish Shilamkar wrote: 4.2: fba874120bb40ddeceacbc7ef51217f34d3749de Sebastien Goasguen wrote: if these patches apply to master, can you make sure to also apply to master at the same time. thanks They were already applied to master but missing in 4.2 - Girish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/#review28520 --- On Oct. 15, 2013, 12:10 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14648/ --- (Updated Oct. 15, 2013, 12:10 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Added few naming convention changes--minor. Diffs - tools/marvin/marvin/deployDataCenter.py beed8c8 Diff: https://reviews.apache.org/r/14648/diff/ Testing --- Thanks, Santhosh Edukulla
Re: [ACS 421] Upgrade testing
Sudha, give us till the end of next week please. I'll report back on friday, ok? On Fri, Nov 8, 2013 at 3:12 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi, Looks like Schuberg Philis is covering 4. 1.1 - 4.2.1 upgrade We ( Citrix systems) would cover 4.2 - 4.2.1 I think these two paths might be enough for this minor release. I think RC is going to cut soon so these need to be covered before that. Thanks /sudha -Original Message- From: Sudha Ponnaganti To: dev Subject: RE: [ACS 421] Upgrade testing Thanks Daan -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, October 31, 2013 2:33 PM To: dev Subject: Re: [ACS 421] Upgrade testing H Sudha, We will at Schuberg Philis but probably not before next friday. We will be upgrading from 4.1.1. I hope we can free up some people to test that scenario soon. Daan On Thu, Oct 31, 2013 at 3:51 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi All, Want to check if anyone is testing upgrades from prior versions to 4.2.1. As Release date is getting close, If there are gaps, would like to cover some scenarios in our lab. Thanks /sudha
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/#review28531 --- Ship it! Ship It! - Santhosh Edukulla On Nov. 8, 2013, 10:43 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/ --- (Updated Nov. 8, 2013, 10:43 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5099 https://issues.apache.org/jira/browse/CLOUDSTACK-5099 Repository: cloudstack-git Description --- 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it. 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote Diffs - tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15341/diff/ Testing --- File Attachments patch file https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch patchfile https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch Thanks, Santhosh Edukulla
Re: Review Request 15341: Fix-for-5099: Utils.py-has-wrong-reference, cleaned it. As well added Uniform naming convention
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/#review28532 --- Ship it! Ship It! - SrikanteswaraRao Talluri On Nov. 8, 2013, 10:43 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15341/ --- (Updated Nov. 8, 2013, 10:43 a.m.) Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5099 https://issues.apache.org/jira/browse/CLOUDSTACK-5099 Repository: cloudstack-git Description --- 1. Utils.py has wrong reference for keyword argument, keyPairFilesLocation 2. We followed uniform naming convention of Camel casing for classes but here its not. Changed it. 3. Renaming remotesshClient.py to sshClient.py, it is more apt name ssh can be to local as well remote Diffs - tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15341/diff/ Testing --- File Attachments patch file https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke.patch patchfile https://reviews.apache.org/media/uploaded/files/2013/11/08/0001-Bug-fix-for-5099-Utils.py-has-wrong-reference-for-ke_1.patch Thanks, Santhosh Edukulla
Re: Review Request 14976: [SSL Termination support] Part2 : Assign certificates to LBs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28533 --- Ship it! commit 0076307863e9155273d9e4c14282de429388c9e9 Author: Syed sah...@cloudops.com Date: Wed Nov 6 15:08:42 2013 -0500 - Murali Reddy On Nov. 6, 2013, 8:15 p.m., Syed Ahmed wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/ --- (Updated Nov. 6, 2013, 8:15 p.m.) Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang. Bugs: CLOUDSTACK-4821 https://issues.apache.org/jira/browse/CLOUDSTACK-4821 Repository: cloudstack-git Description --- This is the second patch for SSL termination support. This patch impletements the assginement of certificate to loadbalancers. Support for netscaler is also added. Due to the version of netscaler API in CS, I could not add support for certificate chain. This should not be a big change however. We can discuss this. NOTE: Because I cannot diff with my local branch, this patch also includes the first patch which includes certificate management logic ... sorry Diffs - CHANGES 054e7b0 api/src/com/cloud/agent/api/to/LoadBalancerTO.java df2f8a8 api/src/com/cloud/event/EventTypes.java d9f80eb api/src/com/cloud/network/Network.java 318ac19 api/src/com/cloud/network/lb/CertService.java PRE-CREATION api/src/com/cloud/network/lb/LoadBalancingRule.java 4b37782 api/src/com/cloud/network/lb/LoadBalancingRulesService.java 59d5c8d api/src/com/cloud/network/lb/SslCert.java PRE-CREATION api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67 api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java a368436 api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION client/tomcatconf/commands.properties.in 087d8b9 core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 3a51e8a engine/components-api/src/com/cloud/network/lb/LoadBalancingRulesManager.java 3e32585 engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/dao/LoadBalancerVO.java fee88cf engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java 5c6f2e7 plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java b6269eb plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java 82f90fb plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java 8101864 plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java fe072e1 server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml 5e37908 server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java 6ca40c0 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 0d43478 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b server/src/com/cloud/server/ManagementServerImpl.java 79b20d0 server/src/org/apache/cloudstack/network/lb/ApplicationLoadBalancerManagerImpl.java b7cd231 server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68 server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java PRE-CREATION server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
Re: Review Request 15263: Added fix for bug 5056.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15263/#review28534 --- commit cf7532e8480385bcc9c5dfd63fb82cd836282028 - SrikanteswaraRao Talluri On Nov. 6, 2013, 1:44 p.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15263/ --- (Updated Nov. 6, 2013, 1:44 p.m.) Review request for cloudstack and Girish Shilamkar. Bugs: CLOUDSTACK-5056 https://issues.apache.org/jira/browse/CLOUDSTACK-5056 Repository: cloudstack-git Description --- 1. The library( remoteSSHClient ) in its current form has some issues. Fixed few of them. As part of that, did clean up of the code. 2. Added tcp timeout flag as an additional parameter to help establish the tcp connections and retry if failed. It retries even otherwise failed. 3. Renamed few variables and maintained uniform usage and convention. 4. Added few new member functions runCommand,createConnection 5. Current, way of creating connection and raising exception from constructor along with return was removed and added a new way of handling it. 6. Currently, result list was returned for execute command, but we dont know the status of command execution, whether the output contains error or output etc. Now, provided more information in the return with new implementation. 7. Added few codes for proper return status. TODO: 1. Remove establishing connection from constructor altogether. This will effect the current modules using it. 2. Need to change is_server_ssh_ready function for proper and adequate checks, currently the name and functionality is little different. It can add more adequate checks before returning ssh object. Diffs - tools/marvin/marvin/codes.py b6580d0 tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15263/diff/ Testing --- File Attachments Added New File https://reviews.apache.org/media/uploaded/files/2013/11/06/0001-Added-fix-for-bug-5056.patch Thanks, Santhosh Edukulla
Re: Review Request 15307: Increasing the timeout values to 600 seconds from 300 seconds
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15307/#review28535 --- 9495fbc87317cbcf8b77630d06e52d52dfc19060 - SrikanteswaraRao Talluri On Nov. 7, 2013, 10:23 a.m., Santhosh Edukulla wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15307/ --- (Updated Nov. 7, 2013, 10:23 a.m.) Review request for cloudstack and Girish Shilamkar. Repository: cloudstack-git Description --- Timeout for ssh related test cases is increased based upon few test run observations where ssh is taking more time during restart scenarios as an example. We have done few changes to streamline ssh library. This is in addition to those to keep less ssh script issues Diffs - tools/marvin/marvin/integration/lib/utils.py 4d048f0 tools/marvin/marvin/remoteSSHClient.py fea9b12 Diff: https://reviews.apache.org/r/15307/diff/ Testing --- Thanks, Santhosh Edukulla
Strange info on secondary storage after upgrade to CloudStack 4.2.0
Dear all, On CloudStack GUI, under Infrastructure Secondary Storage, I remember we used to have a proper name for each secondary storage. However, after the upgrade to CloudStack 4.2.0, the name disappears and it now becomes the ID like this: NameURLProviderQuickviewc02da448-b9f4-401b-b8d5-83e8ead5cfde nfs://xxx/mnt/vol1/sec-storageNFS 5937edb6-2e95-4ae2-907b-80fe4599ed87 nfs://xxx/mnt/vol1/sec-storage2 Is it normal during the upgrade? Looking forward to your reply, thank you. Cheers.
Re: Review Request 15348: CLOUDSTACK-5105 Template/ISO download fails cause the object to disappear from UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15348/ --- (Updated Nov. 8, 2013, 12:02 p.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-5105 https://issues.apache.org/jira/browse/CLOUDSTACK-5105 Repository: cloudstack-git Description --- CLOUDSTACK-5105: Template/ISO download fails cause the object to disappear from UI Diffs - engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java 652df43 server/src/com/cloud/template/HypervisorTemplateAdapter.java 00e6222 Diff: https://reviews.apache.org/r/15348/diff/ Testing --- Thanks, Harikrishna Patnala
Re: [ACS 421] Upgrade testing
I am working on upgrade from 2.2.14 to 4.2.1 some issues have been fixed , except CLOUDSTACK-5076 will fix it today 2013/11/8 Sudha Ponnaganti sudha.ponnaga...@citrix.com Hi, Looks like Schuberg Philis is covering 4. 1.1 - 4.2.1 upgrade We ( Citrix systems) would cover 4.2 - 4.2.1 I think these two paths might be enough for this minor release. I think RC is going to cut soon so these need to be covered before that. Thanks /sudha -Original Message- From: Sudha Ponnaganti To: dev Subject: RE: [ACS 421] Upgrade testing Thanks Daan -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, October 31, 2013 2:33 PM To: dev Subject: Re: [ACS 421] Upgrade testing H Sudha, We will at Schuberg Philis but probably not before next friday. We will be upgrading from 4.1.1. I hope we can free up some people to test that scenario soon. Daan On Thu, Oct 31, 2013 at 3:51 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi All, Want to check if anyone is testing upgrades from prior versions to 4.2.1. As Release date is getting close, If there are gaps, would like to cover some scenarios in our lab. Thanks /sudha
RE: [ACS 421] Upgrade testing
Abhinandan (RM for 4.2.1), You cannot cut RC at least till end of next week i.e Nov 15th. Thanks /sudha -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, November 08, 2013 3:08 AM To: dev Cc: int-tool...@schubergphilis.com; cloud-team Subject: Re: [ACS 421] Upgrade testing Sudha, give us till the end of next week please. I'll report back on friday, ok? On Fri, Nov 8, 2013 at 3:12 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi, Looks like Schuberg Philis is covering 4. 1.1 - 4.2.1 upgrade We ( Citrix systems) would cover 4.2 - 4.2.1 I think these two paths might be enough for this minor release. I think RC is going to cut soon so these need to be covered before that. Thanks /sudha -Original Message- From: Sudha Ponnaganti To: dev Subject: RE: [ACS 421] Upgrade testing Thanks Daan -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, October 31, 2013 2:33 PM To: dev Subject: Re: [ACS 421] Upgrade testing H Sudha, We will at Schuberg Philis but probably not before next friday. We will be upgrading from 4.1.1. I hope we can free up some people to test that scenario soon. Daan On Thu, Oct 31, 2013 at 3:51 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi All, Want to check if anyone is testing upgrades from prior versions to 4.2.1. As Release date is getting close, If there are gaps, would like to cover some scenarios in our lab. Thanks /sudha
RE: [ACS 421] Upgrade testing
Thanks Wei for covering this path -Original Message- From: Wei ZHOU [mailto:ustcweiz...@gmail.com] Sent: Friday, November 08, 2013 4:04 AM To: dev@cloudstack.apache.org Subject: Re: [ACS 421] Upgrade testing I am working on upgrade from 2.2.14 to 4.2.1 some issues have been fixed , except CLOUDSTACK-5076 will fix it today 2013/11/8 Sudha Ponnaganti sudha.ponnaga...@citrix.com Hi, Looks like Schuberg Philis is covering 4. 1.1 - 4.2.1 upgrade We ( Citrix systems) would cover 4.2 - 4.2.1 I think these two paths might be enough for this minor release. I think RC is going to cut soon so these need to be covered before that. Thanks /sudha -Original Message- From: Sudha Ponnaganti To: dev Subject: RE: [ACS 421] Upgrade testing Thanks Daan -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, October 31, 2013 2:33 PM To: dev Subject: Re: [ACS 421] Upgrade testing H Sudha, We will at Schuberg Philis but probably not before next friday. We will be upgrading from 4.1.1. I hope we can free up some people to test that scenario soon. Daan On Thu, Oct 31, 2013 at 3:51 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi All, Want to check if anyone is testing upgrades from prior versions to 4.2.1. As Release date is getting close, If there are gaps, would like to cover some scenarios in our lab. Thanks /sudha
Re: Review Request 15348: CLOUDSTACK-5105 Template/ISO download fails cause the object to disappear from UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15348/#review28538 --- Ship it! Ship It! - Koushik Das On Nov. 8, 2013, 12:02 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15348/ --- (Updated Nov. 8, 2013, 12:02 p.m.) Review request for cloudstack, Kishan Kavala and Koushik Das. Bugs: CLOUDSTACK-5105 https://issues.apache.org/jira/browse/CLOUDSTACK-5105 Repository: cloudstack-git Description --- CLOUDSTACK-5105: Template/ISO download fails cause the object to disappear from UI Diffs - engine/storage/src/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java 652df43 server/src/com/cloud/template/HypervisorTemplateAdapter.java 00e6222 Diff: https://reviews.apache.org/r/15348/diff/ Testing --- Thanks, Harikrishna Patnala
Review Request 15350: CLOUDSTACK-5107: Decreased memory in service offering so as not to run out of resources
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/ --- Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5107 https://issues.apache.org/jira/browse/CLOUDSTACK-5107 Repository: cloudstack-git Description --- This change will prevent test cases from failing in daily runs due to running out of resources. Decreased the memory from 5 GB to 2 GB in service offering and made according changes in test cases. Diffs - test/integration/component/test_memory_limits.py 18eab4c test/integration/component/test_mm_domain_limits.py d87db84 test/integration/component/test_mm_project_limits.py 1c0ed92 Diff: https://reviews.apache.org/r/15350/diff/ Testing --- Tested locally on KVM. Thanks, Gaurav Aradhye
Re: Reviewboard needs your attention
This is what I see when logged in: http://i.imgur.com/RZvXuy1.png Am I missing something? Thanks! On Thu, Nov 7, 2013 at 10:01 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: I can see it fine, were you logged in at that time -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Thursday, November 07, 2013 6:03 PM To: dev@cloudstack.apache.org Subject: Re: Reviewboard needs your attention Hi Animesh, For whatever reason, I can no longer edit https://reviews.apache.org/r/13865/. Any thoughts on this? Thanks! On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: 2013/11/8 Animesh Chaturvedi animesh.chaturv...@citrix.com Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please reach out to your reviewers Dear Sebastien Hugo, I have two pending patches on review board need to review: Rebase OVS (sdnextensions branch) to master branch: https://reviews.apache.org/r/15205/ AutoScaling without NetScaler: https://reviews.apache.org/r/14628/ Thanks, -- N.g.U.y.e.N.A.n.H.t.U -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Re: [ACS 421] Upgrade testing
Sudha, We can still cut RC but will wait for GA till Daan and others have done their testing. On 08/11/13 5:36 pm, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Abhinandan (RM for 4.2.1), You cannot cut RC at least till end of next week i.e Nov 15th. Thanks /sudha -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Friday, November 08, 2013 3:08 AM To: dev Cc: int-tool...@schubergphilis.com; cloud-team Subject: Re: [ACS 421] Upgrade testing Sudha, give us till the end of next week please. I'll report back on friday, ok? On Fri, Nov 8, 2013 at 3:12 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi, Looks like Schuberg Philis is covering 4. 1.1 - 4.2.1 upgrade We ( Citrix systems) would cover 4.2 - 4.2.1 I think these two paths might be enough for this minor release. I think RC is going to cut soon so these need to be covered before that. Thanks /sudha -Original Message- From: Sudha Ponnaganti To: dev Subject: RE: [ACS 421] Upgrade testing Thanks Daan -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Thursday, October 31, 2013 2:33 PM To: dev Subject: Re: [ACS 421] Upgrade testing H Sudha, We will at Schuberg Philis but probably not before next friday. We will be upgrading from 4.1.1. I hope we can free up some people to test that scenario soon. Daan On Thu, Oct 31, 2013 at 3:51 AM, Sudha Ponnaganti sudha.ponnaga...@citrix.com wrote: Hi All, Want to check if anyone is testing upgrades from prior versions to 4.2.1. As Release date is getting close, If there are gaps, would like to cover some scenarios in our lab. Thanks /sudha
Re: Review Request 15350: CLOUDSTACK-5107: Decreased memory in service offering so as not to run out of resources
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/#review28539 --- Commit 9e6a1eaffe3df0981703dc26ab4cc7043d4ca23f in branch refs/heads/4.2 from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9e6a1ea ] CLOUDSTACK-5107: Decreasing memory in service offering so as not to run out of resources Signed-off-by: Girish Shilamkar gir...@clogeny.com - ASF Subversion and Git Services On Nov. 8, 2013, 12:44 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/ --- (Updated Nov. 8, 2013, 12:44 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5107 https://issues.apache.org/jira/browse/CLOUDSTACK-5107 Repository: cloudstack-git Description --- This change will prevent test cases from failing in daily runs due to running out of resources. Decreased the memory from 5 GB to 2 GB in service offering and made according changes in test cases. Diffs - test/integration/component/test_memory_limits.py 18eab4c test/integration/component/test_mm_domain_limits.py d87db84 test/integration/component/test_mm_project_limits.py 1c0ed92 Diff: https://reviews.apache.org/r/15350/diff/ Testing --- Tested locally on KVM. Thanks, Gaurav Aradhye
Re: Review Request 15350: CLOUDSTACK-5107: Decreased memory in service offering so as not to run out of resources
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/#review28540 --- Commit a2117d46f90ae6a96e3d046e306e524756609f5d in branch refs/heads/master from Gaurav Aradhye [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a2117d4 ] CLOUDSTACK-5107: Decreasing memory in service offering so as not to run out of resources Signed-off-by: Girish Shilamkar gir...@clogeny.com - ASF Subversion and Git Services On Nov. 8, 2013, 12:44 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15350/ --- (Updated Nov. 8, 2013, 12:44 p.m.) Review request for cloudstack, Girish Shilamkar and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-5107 https://issues.apache.org/jira/browse/CLOUDSTACK-5107 Repository: cloudstack-git Description --- This change will prevent test cases from failing in daily runs due to running out of resources. Decreased the memory from 5 GB to 2 GB in service offering and made according changes in test cases. Diffs - test/integration/component/test_memory_limits.py 18eab4c test/integration/component/test_mm_domain_limits.py d87db84 test/integration/component/test_mm_project_limits.py 1c0ed92 Diff: https://reviews.apache.org/r/15350/diff/ Testing --- Tested locally on KVM. Thanks, Gaurav Aradhye
Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/ --- (Updated Nov. 8, 2013, 1:48 p.m.) Review request for cloudstack, Girish Shilamkar, venkata swamy babu budumuru, and Sheng Yang. Changes --- Marged patch with latest changes so that it applies to 4.2 Repository: cloudstack-git Description --- Added 10 tests for VPC VM liftcycle on tagged hosts New class added : TestVMLifeCycleDiffHosts def test_01_deploy_instance_in_network(self): def test_02_stop_instance_in_network(self): def test_03_start_instance_in_network(self): def test_04_reboot_instance_in_network(self): def test_05_destroy_instance_in_network(self): def test_06_recover_instance_in_network(self): def test_07_migrate_instance_in_network(self): def test_08_user_data(self): def test_09_meta_data(self): def test_10_expunge_instance_in_network(self): This set of tests requires a multi host tagged setup (3 hosts - 2 hosts with tag 'host1' and 1 host with tag 'host2') Diffs (updated) - test/integration/component/test_vpc_vm_life_cycle.py cc65eed tools/marvin/marvin/integration/lib/base.py 10c636c Diff: https://reviews.apache.org/r/14058/diff/ Testing --- Tested locally on KVM advanced setup. Log: test_01_deploy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test deploy an instance in VPC networks ... ok test_02_stop_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test stop an instance in VPC networks ... ok test_03_start_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test start an instance in VPC networks ... ok test_04_reboot_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test reboot an instance in VPC networks ... ok test_05_destroy_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test destroy an instance in VPC networks ... ok test_06_migrate_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test migrate an instance in VPC networks ... ok test_07_user_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test user data in virtual machines ... ok test_08_meta_data (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test meta data in virtual machines ... ok test_09_expunge_instance_in_network (test_vpc_vm_life_cycle.TestVMLifeCycleDiffHosts) Test expunge an instance in VPC networks ... ok Thanks, Ashutosh Kelkar
SRX inline with VR
All, Is it possible to use a Juniper SRX Firewall for firewall features, and a VR for Load Balancing, or do you need to use an F5 to get 'in line' mode If you can use a SRX, what IP gets load balanced, public or private etc Regards Geoff Higginbottom CTO / Cloud Architect [Description: Mail Logo Bottom Align] D: +44 20 3603 0542tel:+442036030542 | S: +44 20 3603 0540tel:+442036030540 | M: +447968161581tel:+447968161581 geoff.higginbot...@shapeblue.commailto:geoff.higginbot...@shapeblue.com | www.shapeblue.com | Twitter:@shapebluehttps://twitter.com/#!/shapeblue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS ShapeBlue are proud to be sponsoring CloudStack Collab EU 2013 [cid:image004.jpg@01CED4C8.C686BDF0]http://www.cloudstackcollab.org/ Apache CloudStack Bootcamp training courses **NEW!** CloudStack 4.2 traininghttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 13/14 November, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 09-13 December, GLOBAL. Instructor led, On-linehttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 27/28 November, Bangalorehttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 08/09 January 2014, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Review Request 15351: Fixing bugs from Coverity related to Dereferenced Null after check and as return value.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15351/ --- Review request for cloudstack and Hugo Trippaers. Repository: cloudstack-git Description --- Fixing Coverity bugs with IDs: cv_1125361, cv_1125357, cv_1125356, cv_1125355, cv_1117769, cv_1125354, cv_1125353, cv_1125346, cv_1125352, cv_1125360 Diffs - agent/src/com/cloud/agent/AgentShell.java 900a13f plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 47fc99e plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java ec20a94 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java 063db0e server/src/com/cloud/server/ConfigurationServerImpl.java 0676db8 utils/src/com/cloud/utils/nio/Link.java 4b041f5 Diff: https://reviews.apache.org/r/15351/diff/ Testing --- All tests passed during build. [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 10:19.357s [INFO] Finished at: Fri Nov 08 15:06:34 CET 2013 [INFO] Final Memory: 68M/163M Thanks, Wilder Rodrigues
Re: Review Request 15303: Reserved SCSI device number prevents CloudStack to attach more than 6 data volumes to CLOUDSTACK-4790
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15303/#review28542 --- Ship it! commit 97348217c47ad1cb4e242a04ddfcc3696c2a280f - Kishan Kavala On Nov. 7, 2013, 3:13 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15303/ --- (Updated Nov. 7, 2013, 3:13 p.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-4790 https://issues.apache.org/jira/browse/CLOUDSTACK-4790 Repository: cloudstack-git Description --- Adding the sql changes to increase the max attach volume limit to 13 in case of VMware. https://issues.apache.org/jira/browse/CLOUDSTACK-4790 Diffs - setup/db/create-schema.sql 79550ae Diff: https://reviews.apache.org/r/15303/diff/ Testing --- tested on 4.2 Thanks, bharat kumar
RE: 4.2.1 BVT automation results
4.2.1 automation not executed from jenkins.buildacloud.org, Automation executed in side my company including vmware, Regards, Rayees -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Friday, November 08, 2013 12:20 AM To: dev@cloudstack.apache.org Subject: Re: 4.2.1 BVT automation results On Nov 7, 2013, at 9:54 AM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi Sebastian, I don't think so we are running automation 4.2.1 branch in jenkins.buildacloud.org, below result is from master branch; So how did you come up with the results for the 4.2.1 branch ? http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/ Also I reported master failures in ASF jira https://issues.apache.org/jira/browse/CLOUDSTACK-5050 https://issues.apache.org/jira/browse/CLOUDSTACK-5049 https://issues.apache.org/jira/browse/CLOUDSTACK-5047 https://issues.apache.org/jira/browse/CLOUDSTACK-5046 https://issues.apache.org/jira/browse/CLOUDSTACK-5045 https://issues.apache.org/jira/browse/CLOUDSTACK-4835 NOTE : I ran automation with RHEL 6.3 Regards, Rayees -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, November 07, 2013 12:29 AM To: dev@cloudstack.apache.org Subject: Re: 4.2.1 BVT automation results On Nov 6, 2013, at 6:07 PM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi All, 4.2.1 BVT automation results published to cwiki; you can see the results below https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2.1+Automation+Result Regards, Rayees Where are those results coming from ? The qa and simulator jobs on http://jenkins.buildacloud.org/view/simulator/ seem to have been failing for a while Also it would be great if the results table could have the OS version. Technically we need to have each set run on ubuntu 12.04 and Centos6.4. -sebastien
Re: Review Request 15344: Enabling DB HA for cloud stack data bases using mysql active-active solution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15344/#review28545 --- I don't agree with this approach. Following this logic for every possible option one would want to add to the jdbc url we would need to write code to manage it. I would prefer that we just provide a way for the operator to fully override the URL. So they just add db.cloud.url=jdbc:.. to the db.properties and that will override the code generated url - Darren Shepherd On Nov. 8, 2013, 8:48 a.m., Damodar Reddy Talakanti wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15344/ --- (Updated Nov. 8, 2013, 8:48 a.m.) Review request for cloudstack, Abhinandan Prateek and Darren Shepherd. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-4916 https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-4916 Repository: cloudstack-git Description --- To enable Data base High Availability for cloud stack management server database. We have used Mysql's connector parameters to switch between master and slaves along with mysql's 2-way replication and chain way of replication for more than 2 nodes https://wikis.oracle.com/display/CommSuite/MySQL+High+Availability+and+Replication+Information+For+Calendar+Server#MySQLHighAvailabilityandReplicationInformationForCalendarServer-MySQLServerTwoWayReplicationExample Due ot this defect http://bugs.mysql.com/bug.php?id=68141 changed 2 files to have synchronized for on block of statements which were cauing Thread BLOCKING.. Diffs - client/tomcatconf/db.properties.in b0cb22b framework/db/src/com/cloud/utils/db/ConnectionConcierge.java acb9cc6 framework/db/src/com/cloud/utils/db/Merovingian2.java 8544aab framework/db/src/com/cloud/utils/db/TransactionLegacy.java a874ce1 Diff: https://reviews.apache.org/r/15344/diff/ Testing --- Basic sanity testing is done using 2 nodes. If any transaction(api request) is in between and if server goes down then that api request will fail Thanks, Damodar Reddy Talakanti
Re: Review Request 14605: Fill the creationMonitors based on priority
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14605/#review28546 --- Ship it! Laszlo can you commit this? - Darren Shepherd On Oct. 11, 2013, 7:14 p.m., Laszlo Hornyak wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14605/ --- (Updated Oct. 11, 2013, 7:14 p.m.) Review request for cloudstack and Darren Shepherd. Repository: cloudstack-git Description --- If not priotity, append to the end of the list. Diffs - engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java 4202015 Diff: https://reviews.apache.org/r/14605/diff/ Testing --- not really, just guessing this is how it was meant (please review) Thanks, Laszlo Hornyak
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
Sheng, Min, The use of the word semantics has triggered a line of though I want to share on this. The word vlanid is being used as a homonym in cloudstack, meaning both vlan-number and broadcast-uri-pertaining-to-a-vlan. This has been so since 4.0 and maybe even longer. As I see it; Assuming a vlanid is a number and then passing it as a string is wrong. Assuming a number is a vlanid is a wrong assumption as well. I looked at the hypervisorhelper prepareNetwork member methods again and it seems that these expect 1-based 12-bit unsigned integers. They accept anything encoded as a string, however. We could do one of the following things: 1. changing the footprint of those methods or 2. checking and explicitly throwing an exception if this is not the case. 3. is the one I proposed earlier in this thread. This is the most forgiving one. Reverting will lead to runtime exceptions as well. These are why this is in in the first place. regards, Daan On Fri, Nov 8, 2013 at 11:43 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Sheng, All sdn implementations use the field in one way or another as uri. So if this is wrong reverting my patch won't do the trick, I am afraid. I actually think the field should be renamed to broadcastUri, as this is how it is used at the moment by a lot of elements. Going back to only allowing vlans as isolation method is not going to solve anything as the feature is still desired. The alternative is adding a field/parameter all over the code and have all methods check both fields for valid values to decide what to do. The patch runs in production at the moment on a 4.1.1 fork on a xen based cloud and on a mixed xen/vmware cloud as well. It has been heavily tested in master. I don't value my implementation of the requirement and am happy to discuss better implementations and the scope of validity of vlan-ids and broadcast uris but the feature it fulfills is very needed (and works). kind regards, Daan On Fri, Nov 8, 2013 at 1:35 AM, Sheng Yang sh...@yasker.org wrote: Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId and secondaryVlanId are both numbers, not URI. Please revert it. --Sheng On Thu, Nov 7, 2013 at 4:07 PM, Min Chen min.c...@citrix.com wrote: Then we need to clearly define the semantic of parameter vlanId of HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not other format. The invoker method should pass the correct one to this utility to make it work. Thanks -min On 11/7/13 3:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Doesn't sound like a guarantee, If the stack is build otherwise there might come in a different (non-integer-representing) string. On Thu, Nov 7, 2013 at 6:08 PM, Min Chen min.c...@citrix.com wrote: Yes. From callstack, BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is already called before going to that routine. Thanks -min On 11/7/13 1:51 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan://some_number , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fromSt ri ng(vlanId))); regards, Daan On Wed, Nov 6, 2013 at 3:25 AM, Min Chen min.c...@citrix.com wrote: Hi Daan, Your commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=25c 8c ee01a450ee924fe108cafe54b046485ab2b broke Vmware advanced zone setup on Master, where system vm starts failed with NumberFormatException, see details in https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this blocker bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part of your change on HypervisorHostHelper method, but not sure if there is any side effect on your another functionality fixed in your commit. Can you please review to make sure that it is ok? Thanks -min
Re: [PROPOSAL] Liaison with ETSI NFV ISG
On Fri, Nov 08, 2013 at 08:58:17AM +0700, Nguyen Anh Tu wrote: 2013/11/7 Chiradeep Vittal chiradeep.vit...@citrix.com While I appreciate the confidence, there are weekly calls to attend. The particularly interesting one (MANO WG) happens on Wednesdays at 6am PST. I've tried but there's very little chance that I can attend these meetings. Anybody in a more agreeable timezone? Not sure if I have permitted to join, I'm in agreeable timezone (9pm at local time). It's great and I'm willing to join to liaison team. I'd say you are... you're a committer on the project. Perhaps you and Chiradeep can discuss how to get involved?
Re: api incompatibility between 4.1 and 4.2 in ACLs
So I take the silence to simply be a collective oops. I guess this just should serve as a reminder to not break API compatibility without a discussion. Perhaps our tests will surface this better in the future (although I need to look, I wonder if any ACL tests were also simply changed to accomodate the new behavior). On Thu, Nov 7, 2013 at 2:23 PM, Marcus Sorensen shadow...@gmail.com wrote: Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This means that applications that are coded to the cloudstack API and utilize createNetworkACL will break, because the flow has changed. Am I correct on this? And if so, shouldn't we have deployed 4.2 as 5.0, since the stated versioning is based on API compatibility?
Re: [ACS 421] Upgrade testing
On Fri, Nov 08, 2013 at 12:52:13PM +, Abhinandan Prateek wrote: Sudha, We can still cut RC but will wait for GA till Daan and others have done their testing. Abhi, An RC here is really a release artifact that's being voted on, so no... please don't do that until you are satisfied that we are ready to start voting. Unlike past releases, it looks like we *as a community* are actually testing a bug-fix release before voting starts. Let's continue to engender this approach!
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
Daan, I am curious about this: you mentioned that your patch has been running fine on a mixed xen/vmware cloud environment. How come you didn't encounter the blocker bug filed by Rayees on our automation environment on master branch: https://issues.apache.org/jira/browse/CLOUDSTACK-5046. Are you not using advanced zone? Your change I fixed in commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 will definitely lead to this NumberFormatException in a vmware advanced zone setup in starting system vm. Anyway, my fix 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 is for resolving that vmware blocker defect 5046. If you feel that it may break other SDN implementation, please submit a better fix that can work for both SDN and Vmware. That is also the original intention I raised in this thread, since I am not fully aware of the context of your patch change. Thanks -min On 11/8/13 2:43 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Sheng, All sdn implementations use the field in one way or another as uri. So if this is wrong reverting my patch won't do the trick, I am afraid. I actually think the field should be renamed to broadcastUri, as this is how it is used at the moment by a lot of elements. Going back to only allowing vlans as isolation method is not going to solve anything as the feature is still desired. The alternative is adding a field/parameter all over the code and have all methods check both fields for valid values to decide what to do. The patch runs in production at the moment on a 4.1.1 fork on a xen based cloud and on a mixed xen/vmware cloud as well. It has been heavily tested in master. I don't value my implementation of the requirement and am happy to discuss better implementations and the scope of validity of vlan-ids and broadcast uris but the feature it fulfills is very needed (and works). kind regards, Daan On Fri, Nov 8, 2013 at 1:35 AM, Sheng Yang sh...@yasker.org wrote: Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId and secondaryVlanId are both numbers, not URI. Please revert it. --Sheng On Thu, Nov 7, 2013 at 4:07 PM, Min Chen min.c...@citrix.com wrote: Then we need to clearly define the semantic of parameter vlanId of HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not other format. The invoker method should pass the correct one to this utility to make it work. Thanks -min On 11/7/13 3:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Doesn't sound like a guarantee, If the stack is build otherwise there might come in a different (non-integer-representing) string. On Thu, Nov 7, 2013 at 6:08 PM, Min Chen min.c...@citrix.com wrote: Yes. From callstack, BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is already called before going to that routine. Thanks -min On 11/7/13 1:51 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan://some_number , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fro mSt ri ng(vlanId))); regards, Daan On Wed, Nov 6, 2013 at 3:25 AM, Min Chen min.c...@citrix.com wrote: Hi Daan, Your commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h= 25c 8c ee01a450ee924fe108cafe54b046485ab2b broke Vmware advanced zone setup on Master, where system vm starts failed with NumberFormatException, see details in https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this blocker bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part of your change on HypervisorHostHelper method, but not sure if there is any side effect on your another functionality fixed in your commit. Can you please review to make sure that it is ok? Thanks -min
Re: SRX inline with VR
Hi Geoff, Currently we don't support VR as load balancing alone, there are some VR limitations need to be solved. I think the current plan is to fix it in Felton. --Sheng On Fri, Nov 8, 2013 at 6:19 AM, Geoff Higginbottom geoff.higginbot...@shapeblue.com wrote: All, Is it possible to use a Juniper SRX Firewall for firewall features, and a VR for Load Balancing, or do you need to use an F5 to get ‘in line’ mode If you can use a SRX, what IP gets load balanced, public or private etc Regards Geoff Higginbottom *CTO / Cloud Architect* [image: Description: Mail Logo Bottom Align] D: +44 20 3603 0542 +442036030542 | S: +44 20 3603 0540 +442036030540| M: +447968161581 geoff.higginbot...@shapeblue.com | www.shapeblue.com | Twitter:@shapebluehttps://twitter.com/#!/shapeblue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS *ShapeBlue are proud to be sponsoring CloudStack Collab EU 2013* [image: cid:image004.jpg@01CED4C8.C686BDF0]http://www.cloudstackcollab.org/ Apache CloudStack Bootcamp training courses **NEW!** CloudStack 4.2 traininghttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 13/14 November, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ *09-13 December, GLOBAL. Instructor led, On-line http://www.shapeblue.com/cloudstack-bootcamp-training-course/ * 27/28 November, Bangalorehttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 08/09 January 2014, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
Min, I realize that you fixed something and didn't just change code because of no reason. The point is that a vlan might be identified both as number and as vlan://number. the patch is part of a series that addresses these situations. I will look at this case and make sure either only one is possible or both are accepted. regards, Daan On Fri, Nov 8, 2013 at 6:37 PM, Min Chen min.c...@citrix.com wrote: Daan, I am curious about this: you mentioned that your patch has been running fine on a mixed xen/vmware cloud environment. How come you didn't encounter the blocker bug filed by Rayees on our automation environment on master branch: https://issues.apache.org/jira/browse/CLOUDSTACK-5046. Are you not using advanced zone? Your change I fixed in commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 will definitely lead to this NumberFormatException in a vmware advanced zone setup in starting system vm. Anyway, my fix 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 is for resolving that vmware blocker defect 5046. If you feel that it may break other SDN implementation, please submit a better fix that can work for both SDN and Vmware. That is also the original intention I raised in this thread, since I am not fully aware of the context of your patch change. Thanks -min On 11/8/13 2:43 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Sheng, All sdn implementations use the field in one way or another as uri. So if this is wrong reverting my patch won't do the trick, I am afraid. I actually think the field should be renamed to broadcastUri, as this is how it is used at the moment by a lot of elements. Going back to only allowing vlans as isolation method is not going to solve anything as the feature is still desired. The alternative is adding a field/parameter all over the code and have all methods check both fields for valid values to decide what to do. The patch runs in production at the moment on a 4.1.1 fork on a xen based cloud and on a mixed xen/vmware cloud as well. It has been heavily tested in master. I don't value my implementation of the requirement and am happy to discuss better implementations and the scope of validity of vlan-ids and broadcast uris but the feature it fulfills is very needed (and works). kind regards, Daan On Fri, Nov 8, 2013 at 1:35 AM, Sheng Yang sh...@yasker.org wrote: Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId and secondaryVlanId are both numbers, not URI. Please revert it. --Sheng On Thu, Nov 7, 2013 at 4:07 PM, Min Chen min.c...@citrix.com wrote: Then we need to clearly define the semantic of parameter vlanId of HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not other format. The invoker method should pass the correct one to this utility to make it work. Thanks -min On 11/7/13 3:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Doesn't sound like a guarantee, If the stack is build otherwise there might come in a different (non-integer-representing) string. On Thu, Nov 7, 2013 at 6:08 PM, Min Chen min.c...@citrix.com wrote: Yes. From callstack, BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is already called before going to that routine. Thanks -min On 11/7/13 1:51 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan://some_number , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fro mSt ri ng(vlanId))); regards, Daan On Wed, Nov 6, 2013 at 3:25 AM, Min Chen min.c...@citrix.com wrote: Hi Daan, Your commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h= 25c 8c ee01a450ee924fe108cafe54b046485ab2b broke Vmware advanced zone setup on Master, where system vm starts failed with NumberFormatException, see details in https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this blocker bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part of your change on HypervisorHostHelper method, but not sure if there is any side effect on your another functionality fixed in your commit. Can you please review to make sure that it is ok? Thanks -min
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
Hi Daan, Your commit has broken BOTH VMware and JuniperSRX, and these are only two functional codes in your commit. The other two modification are comments. So I don't know how your testing can possibly work. Alena has already fixed the Juniper part at: commit 3ab8d8d8f20c453fdc684f177a612922eae5f415 Author: Alena Prokharchyk alena.prokharc...@citrix.com Date: Wed Sep 18 16:37:00 2013 -0700 Fixed non-oss build broken in Juniper SRX with commit 2614b00c513734ce6b1c29e572fbd7a37d4059fc BTW, I think we can talk about how to improve the format of URI/vlanid definition and how to fix it in the future, but it's another story and shouldn't be mixed with the broken commit issue. --Sheng On Fri, Nov 8, 2013 at 9:37 AM, Min Chen min.c...@citrix.com wrote: Daan, I am curious about this: you mentioned that your patch has been running fine on a mixed xen/vmware cloud environment. How come you didn't encounter the blocker bug filed by Rayees on our automation environment on master branch: https://issues.apache.org/jira/browse/CLOUDSTACK-5046. Are you not using advanced zone? Your change I fixed in commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 will definitely lead to this NumberFormatException in a vmware advanced zone setup in starting system vm. Anyway, my fix 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 is for resolving that vmware blocker defect 5046. If you feel that it may break other SDN implementation, please submit a better fix that can work for both SDN and Vmware. That is also the original intention I raised in this thread, since I am not fully aware of the context of your patch change. Thanks -min On 11/8/13 2:43 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Sheng, All sdn implementations use the field in one way or another as uri. So if this is wrong reverting my patch won't do the trick, I am afraid. I actually think the field should be renamed to broadcastUri, as this is how it is used at the moment by a lot of elements. Going back to only allowing vlans as isolation method is not going to solve anything as the feature is still desired. The alternative is adding a field/parameter all over the code and have all methods check both fields for valid values to decide what to do. The patch runs in production at the moment on a 4.1.1 fork on a xen based cloud and on a mixed xen/vmware cloud as well. It has been heavily tested in master. I don't value my implementation of the requirement and am happy to discuss better implementations and the scope of validity of vlan-ids and broadcast uris but the feature it fulfills is very needed (and works). kind regards, Daan On Fri, Nov 8, 2013 at 1:35 AM, Sheng Yang sh...@yasker.org wrote: Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId and secondaryVlanId are both numbers, not URI. Please revert it. --Sheng On Thu, Nov 7, 2013 at 4:07 PM, Min Chen min.c...@citrix.com wrote: Then we need to clearly define the semantic of parameter vlanId of HypervisorHostHelper.prepareNetwork is indeed the vlan Id string, not other format. The invoker method should pass the correct one to this utility to make it work. Thanks -min On 11/7/13 3:43 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Doesn't sound like a guarantee, If the stack is build otherwise there might come in a different (non-integer-representing) string. On Thu, Nov 7, 2013 at 6:08 PM, Min Chen min.c...@citrix.com wrote: Yes. From callstack, BroadcastDomainType.getValue(BroadcastDomainType.fromString(vlanId) is already called before going to that routine. Thanks -min On 11/7/13 1:51 AM, Daan Hoogland daan.hoogl...@gmail.com wrote: H Min, Your fix will work if you can guarantee that the String passed is a integer. if it has the chance of being in the form of for instance vlan://some_number , you should use: vid = Integer.parseInt(BroadcastDomainType.getValue(BroadcastDomainType.fro mSt ri ng(vlanId))); regards, Daan On Wed, Nov 6, 2013 at 3:25 AM, Min Chen min.c...@citrix.com wrote: Hi Daan, Your commit https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h= 25c 8c ee01a450ee924fe108cafe54b046485ab2b broke Vmware advanced zone setup on Master, where system vm starts failed with NumberFormatException, see details in https://issues.apache.org/jira/browse/CLOUDSTACK-5046. I fixed this blocker bug (commit 94f9b31c9a4c7ae67feabbe16d2ea753e3183289) by reverting part of your change on HypervisorHostHelper method, but not sure if there is any side effect on your another functionality fixed in
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
Here is the part in your commit about SRX:
diff --git
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
index 3bcbf2d..46ef332 100644
---
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
+++
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
@@ -65,6 +65,7 @@ import com.cloud.agent.api.to.IpAddressTO;
import com.cloud.agent.api.to.PortForwardingRuleTO;
import com.cloud.agent.api.to.StaticNatRuleTO;
import com.cloud.host.Host;
+import com.cloud.network.Networks.BroadcastDomainType;
import com.cloud.network.rules.FirewallRule;
import com.cloud.network.rules.FirewallRule.Purpose;
import com.cloud.resource.ServerResource;
@@ -698,8 +699,7 @@ public class JuniperSrxResource implements
ServerResource {
Long publicVlanTag = null;
if (ip.getVlanId() != null
!ip.getVlanId().equals(untagged)) {
try {
-// TODO BroadcastDomain.getValue(ip.getVlanId) ???
- publicVlanTag = Long.parseLong(ip.getVlanId());
+publicVlanTag =
Long.parseLong(BroadcastDomainType.getValue(ip.getVlanId()));
} catch (Exception e) {
throw new ExecutionException(Could not parse
public VLAN tag: + ip.getVlanId());
}
@@ -3581,7 +3581,8 @@ public class JuniperSrxResource implements
ServerResource {
Long publicVlanTag = null;
if (!vlan.equals(untagged)) {
try {
- publicVlanTag = Long.parseLong(vlan);
+// make sure this vlan is numeric
+publicVlanTag =
Long.parseLong(BroadcastDomainType.getValue(vlan));
} catch (Exception e) {
throw new ExecutionException(Unable to parse VLAN
tag: + vlan);
}
In the code, seems you want to make sure vlan is numeric and let
BroadcastDomainType.getValue() accept it(which would only accept URI)? I
don't think that would work.
--Sheng
On Fri, Nov 8, 2013 at 10:15 AM, Sheng Yang sh...@yasker.org wrote:
Hi Daan,
Your commit has broken BOTH VMware and JuniperSRX, and these are only two
functional codes in your commit. The other two modification are comments.
So I don't know how your testing can possibly work.
Alena has already fixed the Juniper part at:
commit 3ab8d8d8f20c453fdc684f177a612922eae5f415
Author: Alena Prokharchyk alena.prokharc...@citrix.com
Date: Wed Sep 18 16:37:00 2013 -0700
Fixed non-oss build broken in Juniper SRX with commit
2614b00c513734ce6b1c29e572fbd7a37d4059fc
BTW, I think we can talk about how to improve the format of URI/vlanid
definition and how to fix it in the future, but it's another story and
shouldn't be mixed with the broken commit issue.
--Sheng
On Fri, Nov 8, 2013 at 9:37 AM, Min Chen min.c...@citrix.com wrote:
Daan,
I am curious about this: you mentioned that your patch has been
running
fine on a mixed xen/vmware cloud environment. How come you didn't
encounter the blocker bug filed by Rayees on our automation environment on
master branch: https://issues.apache.org/jira/browse/CLOUDSTACK-5046. Are
you not using advanced zone? Your change I fixed in commit
94f9b31c9a4c7ae67feabbe16d2ea753e3183289 will definitely lead to this
NumberFormatException in a vmware advanced zone setup in starting system
vm.
Anyway, my fix 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 is for
resolving
that vmware blocker defect 5046. If you feel that it may break other SDN
implementation, please submit a better fix that can work for both SDN and
Vmware. That is also the original intention I raised in this thread, since
I am not fully aware of the context of your patch change.
Thanks
-min
On 11/8/13 2:43 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
H Sheng,
All sdn implementations use the field in one way or another as uri. So
if this is wrong reverting my patch won't do the trick, I am afraid. I
actually think the field should be renamed to broadcastUri, as this is
how it is used at the moment by a lot of elements.
Going back to only allowing vlans as isolation method is not going to
solve anything as the feature is still desired. The alternative is
adding a field/parameter all over the code and have all methods check
both fields for valid values to decide what to do.
The patch runs in production at the moment on a 4.1.1 fork on a xen
based cloud and on a mixed xen/vmware cloud as well. It has been
heavily tested in master. I don't value my implementation of the
requirement and am happy to discuss better implementations and the
scope of validity of vlan-ids and broadcast uris but the feature it
fulfills is very needed (and works).
kind regards,
Daan
On Fri, Nov 8, 2013 at
RE: Reviewboard needs your attention
Mike is this the only review that you cannot see, or it's a general problem you are seeing with reviewboard. May be try another browser -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Friday, November 08, 2013 4:47 AM To: dev@cloudstack.apache.org Subject: Re: Reviewboard needs your attention This is what I see when logged in: http://i.imgur.com/RZvXuy1.png Am I missing something? Thanks! On Thu, Nov 7, 2013 at 10:01 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: I can see it fine, were you logged in at that time -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Thursday, November 07, 2013 6:03 PM To: dev@cloudstack.apache.org Subject: Re: Reviewboard needs your attention Hi Animesh, For whatever reason, I can no longer edit https://reviews.apache.org/r/13865/. Any thoughts on this? Thanks! On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: 2013/11/8 Animesh Chaturvedi animesh.chaturv...@citrix.com Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please reach out to your reviewers Dear Sebastien Hugo, I have two pending patches on review board need to review: Rebase OVS (sdnextensions branch) to master branch: https://reviews.apache.org/r/15205/ AutoScaling without NetScaler: https://reviews.apache.org/r/14628/ Thanks, -- N.g.U.y.e.N.A.n.H.t.U -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)*
Re: SRX inline with VR
Sorry, I meant the CloudStack major release after 4.3... Got mixed up a little bit... --Sheng On Fri, Nov 8, 2013 at 9:57 AM, Sheng Yang sh...@yasker.org wrote: Hi Geoff, Currently we don't support VR as load balancing alone, there are some VR limitations need to be solved. I think the current plan is to fix it in Felton. --Sheng On Fri, Nov 8, 2013 at 6:19 AM, Geoff Higginbottom geoff.higginbot...@shapeblue.com wrote: All, Is it possible to use a Juniper SRX Firewall for firewall features, and a VR for Load Balancing, or do you need to use an F5 to get ‘in line’ mode If you can use a SRX, what IP gets load balanced, public or private etc Regards Geoff Higginbottom *CTO / Cloud Architect* [image: Description: Mail Logo Bottom Align] D: +44 20 3603 0542 +442036030542 | S: +44 20 3603 0540 +442036030540| M: +447968161581 geoff.higginbot...@shapeblue.com | www.shapeblue.com | Twitter:@shapebluehttps://twitter.com/#!/shapeblue ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS *ShapeBlue are proud to be sponsoring CloudStack Collab EU 2013* [image: cid:image004.jpg@01CED4C8.C686BDF0]http://www.cloudstackcollab.org/ Apache CloudStack Bootcamp training courses **NEW!** CloudStack 4.2 traininghttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 13/14 November, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ *09-13 December, GLOBAL. Instructor led, On-line http://www.shapeblue.com/cloudstack-bootcamp-training-course/ * 27/28 November, Bangalorehttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ 08/09 January 2014, Londonhttp://www.shapeblue.com/cloudstack-bootcamp-training-course/ This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master
my code doesn't work when the vlan comes in as numeric. I don't claim
that. it only works when it comes in as vlan://number. It is then
and only then properly parsed into a numeric value.
On Fri, Nov 8, 2013 at 7:23 PM, Sheng Yang sh...@yasker.org wrote:
Here is the part in your commit about SRX:
diff --git
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
index 3bcbf2d..46ef332 100644
---
a/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
+++
b/plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java
@@ -65,6 +65,7 @@ import com.cloud.agent.api.to.IpAddressTO;
import com.cloud.agent.api.to.PortForwardingRuleTO;
import com.cloud.agent.api.to.StaticNatRuleTO;
import com.cloud.host.Host;
+import com.cloud.network.Networks.BroadcastDomainType;
import com.cloud.network.rules.FirewallRule;
import com.cloud.network.rules.FirewallRule.Purpose;
import com.cloud.resource.ServerResource;
@@ -698,8 +699,7 @@ public class JuniperSrxResource implements
ServerResource {
Long publicVlanTag = null;
if (ip.getVlanId() != null
!ip.getVlanId().equals(untagged)) {
try {
-// TODO BroadcastDomain.getValue(ip.getVlanId) ???
- publicVlanTag = Long.parseLong(ip.getVlanId());
+publicVlanTag =
Long.parseLong(BroadcastDomainType.getValue(ip.getVlanId()));
} catch (Exception e) {
throw new ExecutionException(Could not parse
public VLAN tag: + ip.getVlanId());
}
@@ -3581,7 +3581,8 @@ public class JuniperSrxResource implements
ServerResource {
Long publicVlanTag = null;
if (!vlan.equals(untagged)) {
try {
- publicVlanTag = Long.parseLong(vlan);
+// make sure this vlan is numeric
+publicVlanTag =
Long.parseLong(BroadcastDomainType.getValue(vlan));
} catch (Exception e) {
throw new ExecutionException(Unable to parse VLAN
tag: + vlan);
}
In the code, seems you want to make sure vlan is numeric and let
BroadcastDomainType.getValue() accept it(which would only accept URI)? I
don't think that would work.
--Sheng
On Fri, Nov 8, 2013 at 10:15 AM, Sheng Yang sh...@yasker.org wrote:
Hi Daan,
Your commit has broken BOTH VMware and JuniperSRX, and these are only two
functional codes in your commit. The other two modification are comments.
So I don't know how your testing can possibly work.
Alena has already fixed the Juniper part at:
commit 3ab8d8d8f20c453fdc684f177a612922eae5f415
Author: Alena Prokharchyk alena.prokharc...@citrix.com
Date: Wed Sep 18 16:37:00 2013 -0700
Fixed non-oss build broken in Juniper SRX with commit
2614b00c513734ce6b1c29e572fbd7a37d4059fc
BTW, I think we can talk about how to improve the format of URI/vlanid
definition and how to fix it in the future, but it's another story and
shouldn't be mixed with the broken commit issue.
--Sheng
On Fri, Nov 8, 2013 at 9:37 AM, Min Chen min.c...@citrix.com wrote:
Daan,
I am curious about this: you mentioned that your patch has been
running
fine on a mixed xen/vmware cloud environment. How come you didn't
encounter the blocker bug filed by Rayees on our automation environment on
master branch: https://issues.apache.org/jira/browse/CLOUDSTACK-5046. Are
you not using advanced zone? Your change I fixed in commit
94f9b31c9a4c7ae67feabbe16d2ea753e3183289 will definitely lead to this
NumberFormatException in a vmware advanced zone setup in starting system
vm.
Anyway, my fix 94f9b31c9a4c7ae67feabbe16d2ea753e3183289 is for
resolving
that vmware blocker defect 5046. If you feel that it may break other SDN
implementation, please submit a better fix that can work for both SDN and
Vmware. That is also the original intention I raised in this thread, since
I am not fully aware of the context of your patch change.
Thanks
-min
On 11/8/13 2:43 AM, Daan Hoogland daan.hoogl...@gmail.com wrote:
H Sheng,
All sdn implementations use the field in one way or another as uri. So
if this is wrong reverting my patch won't do the trick, I am afraid. I
actually think the field should be renamed to broadcastUri, as this is
how it is used at the moment by a lot of elements.
Going back to only allowing vlans as isolation method is not going to
solve anything as the feature is still desired. The alternative is
adding a field/parameter all over the code and have all methods check
both fields for valid values to decide what to do.
The patch runs in production at the moment on a 4.1.1 fork on a xen
based cloud and on a mixed xen/vmware cloud as
RE: api incompatibility between 4.1 and 4.2 in ACLs
I will let Kishan comment but found this thread http://markmail.org/thread/fxzki6ftqacyrylk -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Friday, November 08, 2013 9:13 AM To: dev@cloudstack.apache.org Subject: Re: api incompatibility between 4.1 and 4.2 in ACLs So I take the silence to simply be a collective oops. I guess this just should serve as a reminder to not break API compatibility without a discussion. Perhaps our tests will surface this better in the future (although I need to look, I wonder if any ACL tests were also simply changed to accomodate the new behavior). On Thu, Nov 7, 2013 at 2:23 PM, Marcus Sorensen shadow...@gmail.com wrote: Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This means that applications that are coded to the cloudstack API and utilize createNetworkACL will break, because the flow has changed. Am I correct on this? And if so, shouldn't we have deployed 4.2 as 5.0, since the stated versioning is based on API compatibility?
Re: api incompatibility between 4.1 and 4.2 in ACLs
Kishan, weren't we supposed to create a default ACL container (list) and assign the rule to it, if no ACL list is passed to the call? Shouldn't be hard to fix From: Animesh Chaturvedi animesh.chaturv...@citrix.commailto:animesh.chaturv...@citrix.com Reply-To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Date: Friday, November 8, 2013 11:23 AM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Cc: Kishan Kavala kishan.kav...@citrix.commailto:kishan.kav...@citrix.com Subject: RE: api incompatibility between 4.1 and 4.2 in ACLs I will let Kishan comment but found this thread http://markmail.org/thread/fxzki6ftqacyrylk -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Friday, November 08, 2013 9:13 AM To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: api incompatibility between 4.1 and 4.2 in ACLs So I take the silence to simply be a collective oops. I guess this just should serve as a reminder to not break API compatibility without a discussion. Perhaps our tests will surface this better in the future (although I need to look, I wonder if any ACL tests were also simply changed to accomodate the new behavior). On Thu, Nov 7, 2013 at 2:23 PM, Marcus Sorensen shadow...@gmail.commailto:shadow...@gmail.com wrote: Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This means that applications that are coded to the cloudstack API and utilize createNetworkACL will break, because the flow has changed. Am I correct on this? And if so, shouldn't we have deployed 4.2 as 5.0, since the stated versioning is based on API compatibility?
Re: 4.2.1 BVT automation results
Thats less than ideal, but better than no testing. Did bugs get filed for the failing tests in 4.2.1? --David On Fri, Nov 8, 2013 at 10:43 AM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: 4.2.1 automation not executed from jenkins.buildacloud.org, Automation executed in side my company including vmware, Regards, Rayees -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Friday, November 08, 2013 12:20 AM To: dev@cloudstack.apache.org Subject: Re: 4.2.1 BVT automation results On Nov 7, 2013, at 9:54 AM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi Sebastian, I don't think so we are running automation 4.2.1 branch in jenkins.buildacloud.org, below result is from master branch; So how did you come up with the results for the 4.2.1 branch ? http://jenkins.buildacloud.org/view/cloudstack-qa/job/test-smoke-matrix/ Also I reported master failures in ASF jira https://issues.apache.org/jira/browse/CLOUDSTACK-5050 https://issues.apache.org/jira/browse/CLOUDSTACK-5049 https://issues.apache.org/jira/browse/CLOUDSTACK-5047 https://issues.apache.org/jira/browse/CLOUDSTACK-5046 https://issues.apache.org/jira/browse/CLOUDSTACK-5045 https://issues.apache.org/jira/browse/CLOUDSTACK-4835 NOTE : I ran automation with RHEL 6.3 Regards, Rayees -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, November 07, 2013 12:29 AM To: dev@cloudstack.apache.org Subject: Re: 4.2.1 BVT automation results On Nov 6, 2013, at 6:07 PM, Rayees Namathponnan rayees.namathpon...@citrix.com wrote: Hi All, 4.2.1 BVT automation results published to cwiki; you can see the results below https://cwiki.apache.org/confluence/display/CLOUDSTACK/4.2.1+Automation+Result Regards, Rayees Where are those results coming from ? The qa and simulator jobs on http://jenkins.buildacloud.org/view/simulator/ seem to have been failing for a while Also it would be great if the results table could have the OS version. Technically we need to have each set run on ubuntu 12.04 and Centos6.4. -sebastien
RE: api incompatibility between 4.1 and 4.2 in ACLs
Actually use this link to the message in that thread http://s.apache.org/QKI -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Friday, November 08, 2013 11:24 AM To: dev@cloudstack.apache.org Cc: Kishan Kavala Subject: RE: api incompatibility between 4.1 and 4.2 in ACLs I will let Kishan comment but found this thread http://markmail.org/thread/fxzki6ftqacyrylk -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Friday, November 08, 2013 9:13 AM To: dev@cloudstack.apache.org Subject: Re: api incompatibility between 4.1 and 4.2 in ACLs So I take the silence to simply be a collective oops. I guess this just should serve as a reminder to not break API compatibility without a discussion. Perhaps our tests will surface this better in the future (although I need to look, I wonder if any ACL tests were also simply changed to accomodate the new behavior). On Thu, Nov 7, 2013 at 2:23 PM, Marcus Sorensen shadow...@gmail.com wrote: Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This means that applications that are coded to the cloudstack API and utilize createNetworkACL will break, because the flow has changed. Am I correct on this? And if so, shouldn't we have deployed 4.2 as 5.0, since the stated versioning is based on API compatibility?
Re: api incompatibility between 4.1 and 4.2 in ACLs
Yes, that would certainly maintain api compatibility if one creates an ACL without specifying aclid, it creates a new list and applies it to the given network. On Fri, Nov 8, 2013 at 12:28 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Actually use this link to the message in that thread http://s.apache.org/QKI -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Friday, November 08, 2013 11:24 AM To: dev@cloudstack.apache.org Cc: Kishan Kavala Subject: RE: api incompatibility between 4.1 and 4.2 in ACLs I will let Kishan comment but found this thread http://markmail.org/thread/fxzki6ftqacyrylk -Original Message- From: Marcus Sorensen [mailto:shadow...@gmail.com] Sent: Friday, November 08, 2013 9:13 AM To: dev@cloudstack.apache.org Subject: Re: api incompatibility between 4.1 and 4.2 in ACLs So I take the silence to simply be a collective oops. I guess this just should serve as a reminder to not break API compatibility without a discussion. Perhaps our tests will surface this better in the future (although I need to look, I wonder if any ACL tests were also simply changed to accomodate the new behavior). On Thu, Nov 7, 2013 at 2:23 PM, Marcus Sorensen shadow...@gmail.com wrote: Maybe this has been discussed already, but we seem to have run into an api incompatibility. In 4.1, you could create ad-hoc ACL rules that applied to a network. In 4.2, you have to first create an 'ACL list', then add those rules to the list, then apply the list to a network. Or so it seems. This means that applications that are coded to the cloudstack API and utilize createNetworkACL will break, because the flow has changed. Am I correct on this? And if so, shouldn't we have deployed 4.2 as 5.0, since the stated versioning is based on API compatibility?
Review Request 15362: Fixed issue with detail view fields marked as 'isPassword' not being obfuscated
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15362/ --- Review request for cloudstack, Brian Federle and Jessica Wang. Repository: cloudstack-git Description --- Form fields marked with 'isPassword' are created as input fields with type 'password' so that the value is obfuscated. However, detail view fields (when editing) are not obfuscated. Additionally, if a value is entered and the edit form is submitted, the password is still visible in plain text. This patch fixes the issue by respecting the 'isPassword' attribute on detail view fields. Diffs - ui/scripts/ui/widgets/detailView.js 65f71b3 Diff: https://reviews.apache.org/r/15362/diff/ Testing --- Thanks, Chris Suich
Re: [ACS 421] Upgrade testing
On Thu, Oct 31, 2013 at 6:31 PM, Nux! n...@li.nux.ro wrote: On 31.10.2013 02:51, Sudha Ponnaganti wrote: Hi All, Want to check if anyone is testing upgrades from prior versions to 4.2.1. As Release date is getting close, If there are gaps, would like to cover some scenarios in our lab. Thanks /sudha I'd love to test it, anyone got an RPM repo with it? Lucian -- Nux, et al; Here is the latest RPMs from the 4.2 branch in a yum repo. http://people.apache.org/~ke4qqq/4.2.1/ Disclaimer: Not a release, much less an Apache release; ymmv; this will eat babies, etc, etc. --David
Re: Review Request 13901: fix long cast to double
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13901/ --- (Updated Nov. 8, 2013, 10:17 p.m.) Review request for cloudstack, Alena Prokharchyk and Wei Zhou. Changes --- no changes, only rebased and resolved merge conflicts Repository: cloudstack-git Description --- - the result of dividing long with long resulted in loss of precision both for network and IO - unit tests included Diffs (updated) - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 63bd5dc plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java d6e8dc2 Diff: https://reviews.apache.org/r/13901/diff/ Testing --- unit test included Thanks, Laszlo Hornyak
Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions
I'd also like to highlight that it isn't a trivial problem. Let's say there's 3 regions: this means there are 3 copies of the user database that are geographically separated by network links that fail quite often (orders of magnitude more than intra-DC networks). Here we run into the consequences of the CAP theorem [1]. We can either have a CP or AP system: either approach makes some tradeoffs: 1. If we run a AP system, then the challenge is to resolve conflicting updates 2. If we run a CP system, then the challenge is to detect partitions reliably and disallow updates during partitions. [1] http://en.wikipedia.org/wiki/CAP_theorem On 11/7/13 11:58 AM, Chip Childers chipchild...@apache.org wrote: On Thu, Nov 7, 2013 at 2:37 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: It may be an admin burden, but it has to be optional. There are other ways to achieve global sync (e.g., LDAP/AD/Oauth). A lot of service providers who run cloudstack have their own user database / portal. In their implementations the CloudStack database is not the master source of user records, but a slave. +1 to it being optional.
Review Request 15349: Overprivisoning changes needed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15349/ --- Review request for cloudstack and Nitin Mehta. Bugs: Cloudstack-5077. https://issues.apache.org/jira/browse/Cloudstack-5077. Repository: cloudstack-git Description --- 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit. 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925 server/src/com/cloud/configuration/Config.java f3cb919 Diff: https://reviews.apache.org/r/15349/diff/ Testing --- Thanks, bharat kumar
RE: [ACS43] Schedule reminder : feature freeze today 11/08
Folks one final reminder I will cut the 4.3 branch tomorrow morning. -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Monday, November 04, 2013 9:58 PM To: dev@cloudstack.apache.org Subject: [ACS43] Schedule reminder : feature freeze this Friday 11/08 Folks Friday 11/8 is the feature freeze date for ACS 4.3. If your contribution is unlikely to make it to 4.3 feature freeze on 11/8 please move them out of 4.3 release to 'Future'. Do remember that we have a 72 hour notice period to solicit feedback for MERGE requests. So the absolute last day for merge requests for 4.3 features/ improvements is tomorrow 11/05. Contributors if you have patches in reviewboard that you had planned for 4.3 make sure to follow up with reviewers. The contribution has to be in master after satisfying any merge concerns / review comments by 11/08 to be included in 4.3.0 release. For detailed branch merge requirement check [1] [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/Branch+Merge+Expe ctations Thanks Animesh
Re: Reviewboard needs your attention
Hi Animesh, I get the same results using Firefox. I assume there are supposed to be buttons to the left of the Review button? If I make a new Review Request, I see more buttons. Thanks On Fri, Nov 8, 2013 at 11:28 AM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Mike is this the only review that you cannot see, or it's a general problem you are seeing with reviewboard. May be try another browser -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Friday, November 08, 2013 4:47 AM To: dev@cloudstack.apache.org Subject: Re: Reviewboard needs your attention This is what I see when logged in: http://i.imgur.com/RZvXuy1.png Am I missing something? Thanks! On Thu, Nov 7, 2013 at 10:01 PM, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: I can see it fine, were you logged in at that time -Original Message- From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Thursday, November 07, 2013 6:03 PM To: dev@cloudstack.apache.org Subject: Re: Reviewboard needs your attention Hi Animesh, For whatever reason, I can no longer edit https://reviews.apache.org/r/13865/. Any thoughts on this? Thanks! On Thu, Nov 7, 2013 at 6:41 PM, Nguyen Anh Tu ng.t...@gmail.com wrote: 2013/11/8 Animesh Chaturvedi animesh.chaturv...@citrix.com Given that we are approaching the 4.3 feature freeze tomorrow if you have submitted patches and are still pending reviews please reach out to your reviewers Dear Sebastien Hugo, I have two pending patches on review board need to review: Rebase OVS (sdnextensions branch) to master branch: https://reviews.apache.org/r/15205/ AutoScaling without NetScaler: https://reviews.apache.org/r/14628/ Thanks, -- N.g.U.y.e.N.A.n.H.t.U -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *(tm)* -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloudhttp://solidfire.com/solution/overview/?video=play *™*
Regarding the ssl key store change
Hi Wei, I found this change in the MASTER. commit 57ba367f3c985e80ea1b34267e298b481a353298 Author: Wei Zhou w.z...@leaseweb.com Date: Thu Nov 7 11:09:06 2013 +0100 CLOUDSTACK-5042: change cloud.keystore to cloudmanagementserver.keystore and install it (cherry picked from commit de448ec4792eda5b47d79b26e9cb8ce96a2b22f4) IIUC, this would means there is no SSL keystore generation for the new management servers? That doesn't sound right... --Sheng
Re: Review Request 15349: Overprivisoning changes needed
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15349/#review28602 --- engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java https://reviews.apache.org/r/15349/#comment55463 Do we have a way to correct it for folks already on 4.2 ? server/src/com/cloud/configuration/Config.java https://reviews.apache.org/r/15349/#comment55462 This needs to have corresponding upgrade fix as well. - Nitin Mehta On Nov. 9, 2013, 12:11 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15349/ --- (Updated Nov. 9, 2013, 12:11 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: Cloudstack-5077. https://issues.apache.org/jira/browse/Cloudstack-5077. Repository: cloudstack-git Description --- 1.) This includes the change to reserve cpu and memory only when vmware.reserve.cpu/mem is true, regardless of overcommit. 2.) populate the default value of the cpu overcommit at cluster level form the global setting when up grading. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 646b406 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 4921925 server/src/com/cloud/configuration/Config.java f3cb919 Diff: https://reviews.apache.org/r/15349/diff/ Testing --- Thanks, bharat kumar
Re: [DISCUSS] Domain/Account/User Sync Up Among Multiple Regions
We are already (generally) AP for most infra changes really. I'd use that model. Eventual consistency is better in this scenario. On Nov 8, 2013, at 6:49 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: I'd also like to highlight that it isn't a trivial problem. Let's say there's 3 regions: this means there are 3 copies of the user database that are geographically separated by network links that fail quite often (orders of magnitude more than intra-DC networks). Here we run into the consequences of the CAP theorem [1]. We can either have a CP or AP system: either approach makes some tradeoffs: 1. If we run a AP system, then the challenge is to resolve conflicting updates 2. If we run a CP system, then the challenge is to detect partitions reliably and disallow updates during partitions. [1] http://en.wikipedia.org/wiki/CAP_theorem On 11/7/13 11:58 AM, Chip Childers chipchild...@apache.org wrote: On Thu, Nov 7, 2013 at 2:37 PM, Chiradeep Vittal chiradeep.vit...@citrix.com wrote: It may be an admin burden, but it has to be optional. There are other ways to achieve global sync (e.g., LDAP/AD/Oauth). A lot of service providers who run cloudstack have their own user database / portal. In their implementations the CloudStack database is not the master source of user records, but a slave. +1 to it being optional.
