Review Request 16481: CLOUDSTACK-5640: Corrected imports in test cases

2013-12-27 Thread Gaurav Aradhye 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16481/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5640
https://issues.apache.org/jira/browse/CLOUDSTACK-5640


Repository: cloudstack-git


Description
---

Some test suites are failing due to error in imports. These failures are 
represented by a generic message "sequence item 0: expected string, NoneType 
found".
Corrected the imports in 5 test suites which failed in recent build.


Diffs
-

  test/integration/component/test_egress_fw_rules.py 919725f 
  test/integration/component/test_haproxy.py 1c8dc63 
  test/integration/smoke/test_deploy_vm_with_userdata.py 8910b2e 
  test/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py 
a08537e 
  test/integration/smoke/test_service_offerings.py 22273d7 

Diff: https://reviews.apache.org/r/16481/diff/


Testing
---

Tested using command "python test_suite_name.py"


Thanks,

Gaurav Aradhye

Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30908
---


Commit 029f4e36a0188520f46d7997df3e53ab1661fb63 in branch refs/heads/4.3 from 
Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=029f4e3 ]

CLOUDSTACK-2237: Automation - Adding new test cases for security group in 
advanced zone feature


- ASF Subversion and Git Services


On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> ---
> 
> (Updated Dec. 16, 2013, 10:01 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding Automation tests for feature "Security Group Isolation in advanced 
> zone".
> 
> @Santhosh: Please check the change in configGenerator file. Made changes to 
> take relative path.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_advancedsg_networks.py 4834351 
>   tools/marvin/marvin/config/config.cfg PRE-CREATION 
>   tools/marvin/marvin/configGenerator.py 6d5b70d 
>   tools/marvin/marvin/integration/lib/base.py b43af33 
>   tools/marvin/marvin/integration/lib/common.py 096b073 
> 
> Diff: https://reviews.apache.org/r/16178/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on Advanced zone setup with security group enabled.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30909
---


Commit 4d9b95e13d9c59009cf359ab3c869e2bb48ba62f in branch refs/heads/master 
from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d9b95e ]

CLOUDSTACK-2237: Automation - Adding new test cases for security group in 
advanced zone feature


- ASF Subversion and Git Services


On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> ---
> 
> (Updated Dec. 16, 2013, 10:01 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding Automation tests for feature "Security Group Isolation in advanced 
> zone".
> 
> @Santhosh: Please check the change in configGenerator file. Made changes to 
> take relative path.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_advancedsg_networks.py 4834351 
>   tools/marvin/marvin/config/config.cfg PRE-CREATION 
>   tools/marvin/marvin/configGenerator.py 6d5b70d 
>   tools/marvin/marvin/integration/lib/base.py b43af33 
>   tools/marvin/marvin/integration/lib/common.py 096b073 
> 
> Diff: https://reviews.apache.org/r/16178/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on Advanced zone setup with security group enabled.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature

2013-12-27 Thread Girish Shilamkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30910
---

Ship it!


Committed the first patch to 4.3 and master.

- Girish Shilamkar


On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> ---
> 
> (Updated Dec. 16, 2013, 10:01 a.m.)
> 
> 
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding Automation tests for feature "Security Group Isolation in advanced 
> zone".
> 
> @Santhosh: Please check the change in configGenerator file. Made changes to 
> take relative path.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_advancedsg_networks.py 4834351 
>   tools/marvin/marvin/config/config.cfg PRE-CREATION 
>   tools/marvin/marvin/configGenerator.py 6d5b70d 
>   tools/marvin/marvin/integration/lib/base.py b43af33 
>   tools/marvin/marvin/integration/lib/common.py 096b073 
> 
> Diff: https://reviews.apache.org/r/16178/diff/
> 
> 
> Testing
> ---
> 
> Tested locally on Advanced zone setup with security group enabled.
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>

Re: Review Request 16128: CLOUDSTACK-4973: Specified locale keyboard language is not showing as default in consoleView passed during deployVM.

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16128/#review30911
---


Commit 526043b715dc279ad58cb37c28d81b177eb2aa44 in branch refs/heads/4.3 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=526043b ]

CLOUDSTACK-4973: Specified keyboard language is not showing as default in 
consoleView passed during deployVM.


- ASF Subversion and Git Services


On Dec. 20, 2013, 10:42 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16128/
> ---
> 
> (Updated Dec. 20, 2013, 10:42 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUUDSTACK-4973
> https://issues.apache.org/jira/browse/CLOUUDSTACK-4973
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4973: Specified locale keyboard language is not showing as default 
> in consoleView passed during deployVM.
> 
> While deploying a VM, user passes the "keyboard" parameter to specify the
> default language for that VM but in the consoleView, the default language
> selected is en-us irrespective of the default language of the VM.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/servlet/ConsoleProxyClientParam.java e420110 
>   server/src/com/cloud/servlet/ConsoleProxyServlet.java b3415db 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
>  6cadeca 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
>  07a1b6f 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
>  8de4955 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java
>  297e711 
>   systemvm/js/ajaxviewer.js 9643204 
> 
> Diff: https://reviews.apache.org/r/16128/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally by deploying a VM with keyboard=uk and keyboard=jp.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 16381: CLOUDSTACK-4402: [deleteStoragePool] There is no way to delete Primary storage if the last host with which it was associated is already removed.

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16381/#review30912
---


Commit 1ee3612adad8e10a6dd089fda1f07256b813c211 in branch refs/heads/4.3 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1ee3612 ]

CLOUDSTACK-4402: [deleteStoragePool] There is no way to delete Primary storage 
if the last host with which it was associated is already removed.


- ASF Subversion and Git Services


On Dec. 19, 2013, 12:20 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16381/
> ---
> 
> (Updated Dec. 19, 2013, 12:20 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-4402
> https://issues.apache.org/jira/browse/CLOUDSTACK-4402
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4402: [deleteStoragePool] There is no way to delete Primary 
> storage if the last host with which it was associated is already removed.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
>  b304a00 
> 
> Diff: https://reviews.apache.org/r/16381/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1) Deploy a CS environment.
> 2) Put cluster under maintenance.
> 3) Remove host.
> 4) Delete storage pool.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature

2013-12-27 Thread Ashutosh Kelkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/
---

(Updated Dec. 27, 2013, 11:49 a.m.)


Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Changes
---

Adding next set of test cases.


Bugs: CLOUDSTACK-2237
https://issues.apache.org/jira/browse/CLOUDSTACK-2237


Repository: cloudstack-git


Description
---

Adding Automation tests for feature "Security Group Isolation in advanced zone".

@Santhosh: Please check the change in configGenerator file. Made changes to 
take relative path.


Diffs (updated)
-

  test/integration/component/test_advancedsg_networks.py 7f3a390 
  tools/marvin/marvin/config/config.cfg 5849fe8 

Diff: https://reviews.apache.org/r/16178/diff/


Testing
---

Tested locally on Advanced zone setup with security group enabled.


Thanks,

Ashutosh Kelkar

Re: Review Request 13735: CLOUDSTACK-4450: Possibility of /tmp/xapilog filling up the Root disk on Xenserver.

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13735/#review30913
---


Commit 5eda091530c0ce5dbf0ac469e6c7c7b58aa48744 in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5eda091 ]

CLOUDSTACK-4450: Possibility of /tmp/xapilog filling up the Root disk on 
Xenserver.


- ASF Subversion and Git Services


On Aug. 22, 2013, 3:45 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13735/
> ---
> 
> (Updated Aug. 22, 2013, 3:45 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4450
> https://issues.apache.org/jira/browse/CLOUDSTACK-4450
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4450: Possibility of /tmp/xapilog filling up the Root disk on 
> Xenserver.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4450
> 
> 
> Diffs
> -
> 
>   scripts/vm/hypervisor/xenserver/hostvmstats.py 38609b1 
> 
> Diff: https://reviews.apache.org/r/13735/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally on cloudstack setup with 4.2-forward branch code and 
> Xenserver 6.2.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 16381: CLOUDSTACK-4402: [deleteStoragePool] There is no way to delete Primary storage if the last host with which it was associated is already removed.

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16381/#review30914
---


Commit 46c6b9183269a411818dfdf286c20b7ac2b852bd in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=46c6b91 ]

CLOUDSTACK-4402: [deleteStoragePool] There is no way to delete Primary storage 
if the last host with which it was associated is already removed.


- ASF Subversion and Git Services


On Dec. 19, 2013, 12:20 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16381/
> ---
> 
> (Updated Dec. 19, 2013, 12:20 p.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Rajesh Battala.
> 
> 
> Bugs: CLOUDSTACK-4402
> https://issues.apache.org/jira/browse/CLOUDSTACK-4402
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4402: [deleteStoragePool] There is no way to delete Primary 
> storage if the last host with which it was associated is already removed.
> 
> 
> Diffs
> -
> 
>   
> plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
>  b304a00 
> 
> Diff: https://reviews.apache.org/r/16381/diff/
> 
> 
> Testing
> ---
> 
> Tests:
> 
> 1) Deploy a CS environment.
> 2) Put cluster under maintenance.
> 3) Remove host.
> 4) Delete storage pool.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 16128: CLOUDSTACK-4973: Specified locale keyboard language is not showing as default in consoleView passed during deployVM.

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16128/#review30915
---


Commit f6b063de7994c65d307d39fe51229c671ad91f16 in branch refs/heads/master 
from Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f6b063d ]

CLOUDSTACK-4973: Specified keyboard language is not showing as default in 
consoleView passed during deployVM.


- ASF Subversion and Git Services


On Dec. 20, 2013, 10:42 a.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16128/
> ---
> 
> (Updated Dec. 20, 2013, 10:42 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh, Rajesh Battala, and Sateesh 
> Chodapuneedi.
> 
> 
> Bugs: CLOUUDSTACK-4973
> https://issues.apache.org/jira/browse/CLOUUDSTACK-4973
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4973: Specified locale keyboard language is not showing as default 
> in consoleView passed during deployVM.
> 
> While deploying a VM, user passes the "keyboard" parameter to specify the
> default language for that VM but in the consoleView, the default language
> selected is en-us irrespective of the default language of the VM.
> 
> 
> Diffs
> -
> 
>   server/src/com/cloud/servlet/ConsoleProxyClientParam.java e420110 
>   server/src/com/cloud/servlet/ConsoleProxyServlet.java b3415db 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyAjaxHandler.java
>  6cadeca 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java
>  07a1b6f 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java
>  8de4955 
>   
> services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyHttpHandlerHelper.java
>  297e711 
>   systemvm/js/ajaxviewer.js 9643204 
> 
> Diff: https://reviews.apache.org/r/16128/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally by deploying a VM with keyboard=uk and keyboard=jp.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

Re: Review Request 13735: CLOUDSTACK-4450: Possibility of /tmp/xapilog filling up the Root disk on Xenserver.

2013-12-27 Thread ASF Subversion and Git Services 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13735/#review30916
---


Commit 17bdbebf93923da7228d31396395dd3227d0d053 in branch refs/heads/4.3 from 
Sanjay Tripathi
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=17bdbeb ]

CLOUDSTACK-4450: Possibility of /tmp/xapilog filling up the Root disk on 
Xenserver.


- ASF Subversion and Git Services


On Aug. 22, 2013, 3:45 p.m., Sanjay Tripathi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13735/
> ---
> 
> (Updated Aug. 22, 2013, 3:45 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-4450
> https://issues.apache.org/jira/browse/CLOUDSTACK-4450
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-4450: Possibility of /tmp/xapilog filling up the Root disk on 
> Xenserver.
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4450
> 
> 
> Diffs
> -
> 
>   scripts/vm/hypervisor/xenserver/hostvmstats.py 38609b1 
> 
> Diff: https://reviews.apache.org/r/13735/diff/
> 
> 
> Testing
> ---
> 
> Verified the fix locally on cloudstack setup with 4.2-forward branch code and 
> Xenserver 6.2.
> 
> 
> Thanks,
> 
> Sanjay Tripathi
> 
>

RE: Regarding contribution to CloudStack project

2013-12-27 Thread Chandan Purushothama 
Hello Abhinav,

There is a wiki page on CloudStack. I refer to it for information on 
CloudStack. Kindly refer to the wiki at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Home,

Thank you,
Chandan.

-Original Message-
From: jitendra shelar [mailto:jitendra.shelar...@gmail.com] 
Sent: Thursday, December 26, 2013 10:06 AM
To: dev@cloudstack.apache.org; CloudStack-Users; 
users-subscr...@cloudstack.apache.org; issues-subscr...@cloudstack.apache.org
Subject: Re: Regarding contribution to CloudStack project

Hi Abhinav,

Nice that you have taken interest in cloudstack.
It is really excellent.

Free ebook is available at below link.
http://it-ebooks.info/book/2930/

Thanks,
Jitendra


On Thu, Dec 26, 2013 at 5:33 PM, Mike Tutkowski < mike.tutkow...@solidfire.com> 
wrote:

> There is this book on Amazon (I read it when I started working on 
> CloudStack, but - as Wido says - CloudStack development moves fast, so 
> not all details in this book are still accurate, but the high-level 
> areas generally still apply):
>
>
> http://www.amazon.com/Apache-CloudStack-Cloud-Computing-Sabharwal/dp/1
> 782160108
>
>
> On Thu, Dec 26, 2013 at 7:09 AM, Wido den Hollander 
> wrote:
>
> > Hi Abhinav!
> >
> > On 12/23/2013 05:27 PM, Abhinav Koppula wrote:
> >
> >> Hi all,
> >>
> >> I am Abhinav Koppula, a senior undergraduate student pursuing my
> Bachelors
> >> in India. I am interested in contributing towards the Apache 
> >> CloudStack project. I would be really glad if anyone could guide me 
> >> on how I can
> get
> >> started.
> >> Also, I wanted to know if there are any pre-requisites(in terms of 
> >> computer science concepts) which I need to cover before starting 
> >> off.
> >>
> >>
> > Well, we don't require anything. You can start contributing right 
> > away if you want to.
> >
> >  I am skilled in Java but however I do not have prior experience of
> working
> >> on cloud computing platforms. What books/resources should I refer 
> >> which would help me in understanding the code-base easily?
> >>
> >>
> > There are no real books on CloudStack and how to code for it. This 
> > is impossible to write at this moment since a lot changes in CloudStack.
> >
> > I recommend you start with cloning the source and you start to 
> > understand the code.
> >
> > Are there any particular things you want to work on? If so, we can 
> > point you in to the right direction to where to look.
> >
> > Wido
> >
> >  Thanks,
> >> Abhinav Koppula
> >>
> >>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>

Re: VMware Question

2013-12-27 Thread Mike Tutkowski 
Investigating this a bit more today, I came to the conclusion that the NFS
datastore was not being added to CloudStack as primary storage.

It appears I must have had one more dynamically created iSCSI-based
datastore that was being added to CloudStack as primary storage.

I went ahead and checked in a fix to stop VMware logic from adding these
kinds (dynamically created) of datastores to CloudStack as primary storage.


On Thu, Dec 26, 2013 at 11:42 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> I can see the problem is in HostMO.getLocalDatastoreOnHost.
>
> My datastore (as well as the NFS datastore that was automatically created
> to download an ISO) shows up as DatastoreSummary.isMultipleHostAccess ==
> false (along with a couple other fields) and this qualifies it as "local"
> storage.
>
> I believe I've never seen this before because vCenter Server probably
> changes DatastoreSummary.isMultipleHostAccess to true when you have more
> than one host in the cluster that can access the datastore (I usually have
> more than one host in a VMware cluster, but don't right now).
>
> It seems DatastoreSummary.isMultipleHostAccess is not sufficient to use to
> declare if something is local storage.
>
>
> On Thu, Dec 26, 2013 at 11:18 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi,
>>
>> I have a question about the initializeLocalStorage method in
>> VmwareResource.
>>
>> When an ISO is downloaded from secondary storage to an ESX host, we
>> create an NFS datastore on the host.
>>
>> When the host connects to a management server, initializeLocalStorage is
>> run and this method sees the new NFS datastore as new local storage and
>> this ends up being added as a new primary storage in CloudStack.
>>
>> I doubt this behavior is intended.
>>
>> I actually have a similar problem with how initializeLocalStorage treats
>> iSCSI-based datastores that I dynamically create.
>>
>> In my case, a user executes a Disk Offering based on my plug-in. An
>> iSCSI-based datastore (with a single VMDK file in it) is dynamically
>> created and made accessible to all hosts in the cluster (although of course
>> only a single host is running the VM that has the VMDK file attached as a
>> data disk).
>>
>> Later on, if the host reconnects to a management server,
>> initializeLocalStorage sees the new datastore as new local storage and
>> tells the management server to add it to CloudStack as a new primary
>> storage, which is not ideal.
>>
>> Any thoughts from people on a good way to stop this behavior? When I
>> create a datastore, can I tag it a certain way and then look for that tag
>> in initializeLocalStorage?
>>
>> Thanks!
>>
>> --
>> *Mike Tutkowski*
>> *Senior CloudStack Developer, SolidFire Inc.*
>> e: mike.tutkow...@solidfire.com
>> o: 303.746.7302
>> Advancing the way the world uses the 
>> cloud
>> *™*
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *™*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*™*