Re: CLOUDSTACK-5641

2014-03-06 Thread Namita Chaudhari
Hi Nitin,

Regarding *CLOUDSTACK-5641, *can you please verify the screenshot and let
me know that is it the same local storage you are looking for in UI?
Please let me know your comments.


Thanks and Regards,
Namita


On Tue, Feb 25, 2014 at 7:11 PM, Namita Chaudhari <
namita.chaudh...@sungard.com> wrote:

> Hi All,
>
> I started looking at https://issues.apache.org/jira/browse/CLOUDSTACK-5641
> If anybody is working on it please let me know.
>
>
> Nitin,
> I tried this issue on master and I see the local storage is displayed in
> the admin's webui. In the storage pool view, though the capacity_type = 3,
> it does not affect the local storage that is displayed in the UI as shown
> in the screenshot attached to the jira.
> I was trying to figure out that is there any other view from which we get
> this data.
>
> Can you please verify the screenshot and let me know is it the same local
> storage you are looking for in UI?
> Please let me know your comments.
>
> Thanks and Regards,
> --
>
> *Namita Chaudhari* ● Associate Engineer- Product Development ● SunGard
> Availability Services, India ● Mobile: +91 9762922138 ● Email:
> namita.chaudh...@sungard.com
>
> *[image: AS_yt]* *[image:
> AS_twitter]* *[image: 
> AS_in]**[image:
> AS_gplus]* *[image:
> AS_fb]* *[image: 
> AS_ss]*
>



-- 

*Namita Chaudhari* ● Associate Engineer- Product Development ● SunGard
Availability Services, India ● Mobile: +91 9762922138 ● Email:
namita.chaudh...@sungard.com

*[image: AS_yt]* *[image:
AS_twitter]* *[image:
AS_in]**[image:
AS_gplus]* *[image:
AS_fb]**[image:
AS_ss]* 


RE: apidocs build failure

2014-03-06 Thread Alex Hitchins
Hi Wei,

I seem to have a build working now, I'm getting the UI up in Jetty which is 
much better state of affairs on yesterday!

I didn't need to do anything with that OvsProvider.java file in the end, I 
cleared out my .m2 folder, did an mvn clean install then redeployed the 
databases. I will try a non-oss built to see how I get on with that.

Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Wei ZHOU [mailto:ustcweiz...@gmail.com]
Sent: 07 March 2014 06:54
To: dev@cloudstack.apache.org
Subject: Re: apidocs build failure

"git status"
then you can see some files which are untracked. for example

#   api/src/com/cloud/network/OvsProvider.java
#
api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java
#
api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java
#   api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java

you should remove these files.

-Wei

2014-03-07 3:15 GMT+01:00 Alex Hitchins :

> I've just checked out 4.3 and am still getting the same error.
>
> Could this be an incorrect build?
>
> What is the best way for me to start from scratch? Remove any existing
> dependencies and re-downloading them? If so, do I need to clear
> everything from deps folder AND the m2 directory?
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>
> alex.hitch...@shapeblue.com
>
> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: 06 March 2014 23:42
> To: dev@cloudstack.apache.org
> Subject: RE: apidocs build failure
>
> I do not run into this issue in 4.3 branch.
>
> Animesh
>
> > -Original Message-
> > From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> > Sent: Thursday, March 06, 2014 2:12 PM
> > To: dev
> > Subject: apidocs build failure
> >
> > Just trying a build against 4.3 (not 4.3-forward) and I get the
> following error:
> >
> > [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-
> > plugin:1.2.1:exec (compile) on project cloud-apidoc: Command
> > execution failed. Process exited with an error: 2 (Exit value: 2) ->
> > [Help 1]
> >
> > Anyone else seen this issue? I don't know what I'm doing wrong,
> > nothing is building for me!
> >
> >
> > Regards,
> >
> > Alex Hitchins
> >
> > D: +44 1892 523 587 | S: +44 20 3603 0540 | M:
> > +44 7788 423 969
> >
> > ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
> >
> > Need Enterprise Grade Support for Apache CloudStack?
> > Our CloudStack Infrastructure
> > Support > infrastructure-support/> offers the best 24/7 SLA for CloudStack
> > Environments.
> >
> > Apache CloudStack Bootcamp training courses
> >
> > **NEW!** CloudStack 4.2.1 training > training/>
> > 18th-19th February 2014, Brazil.
> > Classroom
> > 17th-23rd March 2014, Region A. Instructor led, On-
> > line
> > 24th-28th March 2014, Region B. Instructor led, On-
> > line
> > 16th-20th June 2014, Region A. Instructor led, On-
> > line
> > 23rd-27th June 2014, Region B. Instructor led, On-
> > line
> >
> > This email and any attachments to it may be confidential and are
> > intended solely for the use of the individual to whom it is addressed.
> > Any views or opinions expressed are solely those of the author and
> > do not necessarily represent those of Shape Blue Ltd or related
> > companies. If you are not the intended recipient of this email, you
> > must neither take any action based upon its contents, nor copy or
> > show it to anyone. Please contact the sender if you believe you have
> > received this email in error. Shape Blue Ltd is a company
> > incorporated in England & Wales. ShapeBlue Services India LLP is a
> > company incorporated in India and is operated under license from
> > Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company
> > incorporated in Brasil and is operated under license from Shape Blue
> > Ltd. ShapeBlue is a
> registered trademark.
> This email and any attachments to it may be confidential and are
> intended solely for the use of the individual to whom it is addressed.
> Any views or opinions expressed are solely those of the author and do
> not necessarily represent those of Shape Blue Ltd or related
> companies. If you are not the intended recipient of this email, you
> must neither take any action based upon its contents, nor copy or show
> it to anyone. Please contact the sender if you believe you have
> received this email in error. Shape Blue Ltd is a company incorporated
> in England & Wales. ShapeBlue Services India LLP is a company
> incorporated in India and is operate

RE: 4.3 vote

2014-03-06 Thread Animesh Chaturvedi
Ok so how do we get past this? This should have been pre-existing as dependency 
has been broken for a long time and I am not sure if this should block our next 
RC.

> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: Thursday, March 06, 2014 4:14 PM
> To: dev@cloudstack.apache.org
> Subject: Re: 4.3 vote
> 
> David was seeing this as well. This is is a documented problem at
> https://issues.apache.org/jira/browse/RAMPART-393.
> 
> I just spun up a VM at AWS using a 64 bit amazon linux api. Ran the
> commands below, got same errors:
> 
> 1  sudo yum update
> 2  yum install git java-1.7.0-openjdk-devel
> 3  git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
> 4  wget http://www.dsgnwrld.com/am/maven/maven-
> 3/3.2.1/binaries/apache-maven-3.2.1-bin.tar.gz
> 5  tar xvf apache-maven-3.2.1-bin.tar.gz
> 6  export PATH=$PATH:~/apache-maven-3.2.1/bin/
> 7  cd cloudstack/
> 8  mvn -P deps
> 9  mvn clean install -Pawsapi
> 
> I suspect the Citrix devs are sitting behind Nexus or other maven mirror?
> 
> John
> 
> On Mar 6, 2014, at 3:13 PM, Animesh Chaturvedi
> mailto:animesh.chaturv...@citrix.com>>
> wrote:
> 
> Folks anyone else seeing this? I want to build RC soon and wanted to
> confirm if this is an issue or not and if so if we can get a fix right away
> 
> -Original Message-
> From: Prachi Damle [mailto:prachi.da...@citrix.com]
> Sent: Thursday, March 06, 2014 1:20 PM
> To: dev@cloudstack.apache.org
> Subject: RE: 4.3 vote
> 
> John,
> 
> I could not reproduce this broken build on 4.3 after wiping out my entire
> repository.
> 1.  rm -rf ~/.m2/repository
> 2. mvn clean install -Pawsapi
> 
> My build is successful.
> 
> Can someone who is able to reproduce this check this further?
> 
> Prachi
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache CloudStack . SUCCESS 
> [1:53.957s] [INFO]
> Apache CloudStack Maven Conventions Parent  SUCCESS [0.089s] [INFO]
> Apache CloudStack Framework - Managed Context . SUCCESS [28.189s]
> [INFO] Apache CloudStack Utils ... SUCCESS 
> [1:06.368s] [INFO]
> Apache CloudStack Framework ... SUCCESS [0.303s] [INFO]
> Apache CloudStack Framework - Event Notification .. SUCCESS [27.125s]
> [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [5.878s]
> [INFO] Apache CloudStack API . SUCCESS [55.346s] 
> [INFO]
> Apache CloudStack Framework - REST  SUCCESS [16.891s] [INFO]
> Apache CloudStack Framework - IPC . SUCCESS [11.845s] [INFO]
> Apache CloudStack Cloud Engine  SUCCESS [0.072s] [INFO]
> Apache CloudStack Cloud Engine API  SUCCESS [10.641s] [INFO]
> Apache CloudStack Core  SUCCESS [30.300s] [INFO] 
> Apache
> CloudStack Agents .. SUCCESS [22.533s] [INFO] Apache
> CloudStack Framework - Clustering .. SUCCESS [8.801s] [INFO] Apache
> CloudStack Framework - Jobs  SUCCESS [9.251s] [INFO] Apache
> CloudStack Cloud Engine Schema Component ... SUCCESS [39.764s] [INFO]
> Apache CloudStack Framework - Event Notification .. SUCCESS [2.761s] [INFO]
> Apache CloudStack Cloud Engine Internal Components API  SUCCESS [6.014s]
> [INFO] Apache CloudStack Server .. SUCCESS 
> [1:23.722s] [INFO]
> Apache CloudStack Usage Server  SUCCESS [9.872s] [INFO]
> Apache XenSource XAPI . SUCCESS [17.003s] [INFO] 
> Apache
> CloudStack Cloud Engine Orchestration Component  SUCCESS [16.774s]
> 
> [INFO] Apache CloudStack Cloud Services .. SUCCESS [0.100s] 
> ...
> [INFO] Apache CloudStack Client UI ... SUCCESS [35.094s] 
> [INFO]
> Apache CloudStack Console Proxy - RDP Client .. SUCCESS [24.447s] [INFO]
> Apache CloudStack Console Proxy ... SUCCESS [0.120s] [INFO]
> Apache CloudStack Console Proxy - Server .. SUCCESS [6.431s] [INFO]
> Apache CloudStack Framework - QuickCloud .. SUCCESS [0.577s] [INFO]
> Apache CloudStack AWS API Bridge .. SUCCESS [4:57.758s] 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> 
> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: Wednesday, March 05, 2014 11:51 AM
> To: dev@cloudstack.apache.org
> Subject: Re: 4.3 vote
> 
> The dependency's actually been broken for a very long time, apparently. On
> a clean box with no maven repository cache (rm -rf ~/.m2/repository),
> awsapi (and therefore RPMs) will not build.
> 
> It loo

Re: apidocs build failure

2014-03-06 Thread Wei ZHOU
"git status"
then you can see some files which are untracked. for example

#   api/src/com/cloud/network/OvsProvider.java
#
api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java
#
api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java
#   api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java

you should remove these files.

-Wei

2014-03-07 3:15 GMT+01:00 Alex Hitchins :

> I've just checked out 4.3 and am still getting the same error.
>
> Could this be an incorrect build?
>
> What is the best way for me to start from scratch? Remove any existing
> dependencies and re-downloading them? If so, do I need to clear everything
> from deps folder AND the m2 directory?
>
> Regards
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>
> alex.hitch...@shapeblue.com
>
> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: 06 March 2014 23:42
> To: dev@cloudstack.apache.org
> Subject: RE: apidocs build failure
>
> I do not run into this issue in 4.3 branch.
>
> Animesh
>
> > -Original Message-
> > From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> > Sent: Thursday, March 06, 2014 2:12 PM
> > To: dev
> > Subject: apidocs build failure
> >
> > Just trying a build against 4.3 (not 4.3-forward) and I get the
> following error:
> >
> > [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-
> > plugin:1.2.1:exec (compile) on project cloud-apidoc: Command execution
> > failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
> >
> > Anyone else seen this issue? I don't know what I'm doing wrong,
> > nothing is building for me!
> >
> >
> > Regards,
> >
> > Alex Hitchins
> >
> > D: +44 1892 523 587 | S: +44 20 3603 0540 | M:
> > +44 7788 423 969
> >
> > ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
> >
> > Need Enterprise Grade Support for Apache CloudStack?
> > Our CloudStack Infrastructure Support > infrastructure-support/> offers the best 24/7 SLA for CloudStack
> > Environments.
> >
> > Apache CloudStack Bootcamp training courses
> >
> > **NEW!** CloudStack 4.2.1 training > training/>
> > 18th-19th February 2014, Brazil.
> > Classroom
> > 17th-23rd March 2014, Region A. Instructor led, On-
> > line
> > 24th-28th March 2014, Region B. Instructor led, On-
> > line
> > 16th-20th June 2014, Region A. Instructor led, On-
> > line
> > 23rd-27th June 2014, Region B. Instructor led, On-
> > line
> >
> > This email and any attachments to it may be confidential and are
> > intended solely for the use of the individual to whom it is addressed.
> > Any views or opinions expressed are solely those of the author and do
> > not necessarily represent those of Shape Blue Ltd or related
> > companies. If you are not the intended recipient of this email, you
> > must neither take any action based upon its contents, nor copy or show
> > it to anyone. Please contact the sender if you believe you have
> > received this email in error. Shape Blue Ltd is a company incorporated
> > in England & Wales. ShapeBlue Services India LLP is a company
> > incorporated in India and is operated under license from Shape Blue
> > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
> > Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
>


Jenkins build is back to normal : build-master-slowbuild #374

2014-03-06 Thread jenkins
See 



Re: Review Request 18735: CLOUDSTACK-4840: Final set of test cases for Multiple IPs per NIC feature

2014-03-06 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18735/#review36497
---

Ship it!


Ship It!

- Santhosh Edukulla


On March 4, 2014, 5:12 p.m., Ashutosh Kelkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18735/
> ---
> 
> (Updated March 4, 2014, 5:12 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-4840
> https://issues.apache.org/jira/browse/CLOUDSTACK-4840
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> This is the final set of test cases for "Multiple IPs per NIC" feature.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_multiple_ips_per_nic.py dcbb453 
>   tools/marvin/marvin/config/config.cfg 356a291 
>   tools/marvin/marvin/integration/lib/base.py 0a7ad94 
> 
> Diff: https://reviews.apache.org/r/18735/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> Please ignore the docstrings, I have updated them according to test case, 
> they were redundant before.
> 
> 
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> Add secondary IP to NIC of a VM ... ok
> 
> --
> Ran 43 tests in 11415.388s
> 
> OK (SKIP=28)
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>



Re: Review Request 18894: CLOUDSTACK-6210 LDAP:listLdapUsers api throws exception when we click on "Add LDAP Account"

2014-03-06 Thread Rajani Karuturi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18894/
---

(Updated March 7, 2014, 6:10 a.m.)


Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-6210
https://issues.apache.org/jira/browse/CLOUDSTACK-6210


Repository: cloudstack-git


Description
---

This occurs when ldap basedn is not configured.
Throwing an IAE and a proper message is returned from the api call

The api call response earlier was
{ "ldapuserresponse" : {"uuidList":[],"errorcode":530,"cserrorcode":} }
now it is as follows
{ "ldapuserresponse" : 
{"uuidList":[],"errorcode":431,"cserrorcode":,"errortext":"ldap basedn is 
not configured"} }


Diffs
-

  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
 2dacafe 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy
 fa735d3 

Diff: https://reviews.apache.org/r/18894/diff/


Testing
---

unittested by adding a new test case "test searchUsers when ldap basedn in not 
set" in LdapUserManagerSpec.groovy which reproduces this case 

manually tested the api call as well


Thanks,

Rajani Karuturi



Re: Review Request 18623: CLOUDSTACK-6147: Adding first set of test cases for Dynamic Compute Offering feature

2014-03-06 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18623/#review36496
---

Ship it!


Ship It!

- Santhosh Edukulla


On Feb. 28, 2014, 1:47 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18623/
> ---
> 
> (Updated Feb. 28, 2014, 1:47 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6147
> https://issues.apache.org/jira/browse/CLOUDSTACK-6147
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Adding first set of automation test cases for Dynamic Compute Offering 
> Feature.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_dynamic_compute_offering.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py 0a7ad94 
>   tools/marvin/marvin/integration/lib/common.py b2da3ff 
> 
> Diff: https://reviews.apache.org/r/18623/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Deploy VM with dynamic service offering and check VM stats ... ok
> Deploy VM with dynamic service offering and check VM stats ... ok
> Create dynamic compute offering with cpunumber, cpuspeed and memory ... ok
> Create dynamic compute offering with only cpunumber unspecified ... ok
> Create dynamic compute offering with only cpuspeed unspecified ... ok
> Create dynamic compute offering with only memory unspecified ... ok
> Create normal compute offering with non zero values for cpu, ... ok
> Test deploy VM with dynamic compute offering ... ok
> Test deploy VM with dynamic compute offering ... ok
> Test deploy VM with static offering ... ok
> Test deploy VM with static offering ... ok
> --
> Ran 11 tests in 794.431s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>



Review Request 18896: Fixed a local variable issue reported

2014-03-06 Thread Santhosh Edukulla

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18896/
---

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-5674
https://issues.apache.org/jira/browse/CLOUDSTACK-5674


Repository: cloudstack-git


Description
---

Fixed a local variable issue.


Diffs
-

  tools/marvin/marvin/marvinPlugin.py 3a364b1 

Diff: https://reviews.apache.org/r/18896/diff/


Testing
---


Thanks,

Santhosh Edukulla



Review Request 18894: CLOUDSTACK-6210 LDAP:listLdapUsers api throws exception when we click on "Add LDAP Account"

2014-03-06 Thread Rajani Karuturi

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18894/
---

Review request for cloudstack, Abhinandan Prateek and Ian Duffy.


Bugs: CLOUDSTACK-6210
https://issues.apache.org/jira/browse/CLOUDSTACK-6210


Repository: cloudstack-git


Description
---

This occurs when ldap basedn is not configured.
Throwing an IAE and a proper message is returned from the api call

The api call response earlier was
{ "ldapuserresponse" : {"uuidList":[],"errorcode":530,"cserrorcode":} }
now it is as follows
{ "ldapuserresponse" : 
{"uuidList":[],"errorcode":431,"cserrorcode":,"errortext":"ldap basedn is 
not configured"} }


Diffs
-

  
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java
 2dacafe 
  
plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserManagerSpec.groovy
 fa735d3 

Diff: https://reviews.apache.org/r/18894/diff/


Testing
---

unittested by adding a new test case "test searchUsers when ldap basedn in not 
set" in LdapUserManagerSpec.groovy which reproduces this case 

manually tested the api call as well


Thanks,

Rajani Karuturi



Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Mike Tutkowski
Sounds good - let's plan on that for 4.5. :)


On Thu, Mar 6, 2014 at 10:15 PM, Punith S  wrote:

> yea sure , will target this for 4.5.
>
> thanks
>
>
> On Thu, Mar 6, 2014 at 8:37 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com
> > wrote:
>
> > Just to clarify, Punith: You are correct that changing storage QoS
> > dynamically will be a more time-consuming task than adding that kind of
> > support on the hypervisor side. That's why I say with the Feature Freeze
> > date as it is for 4.4 that we should look to address this in 4.5.
> >
> > Thanks
> >
> >
> > On Thu, Mar 6, 2014 at 3:42 AM, Wido den Hollander 
> wrote:
> >
> > >
> > >
> > > On 03/05/2014 07:18 PM, Marcus wrote:
> > >
> > >> For the hypervisor version of throttling, we just need
> > >> ResizeVolumeCommand to pass the VolumeObjectTO rather than just the
> > >> volume uuid/path, so that when we change offerings on the agent side
> > >> we have the info we need to update libvirt with the new iops/bytes
> > >> settings. We also need the libvirt java bindings to do so, per
> > >> previous discussion.
> > >>
> > >>
> > > I'm already working on the patch: https://github.com/wido/
> > > libvirt-java/tree/change-iops
> > >
> > > It's not so hard to implement it seems. Hopefully I'll have it ready
> > after
> > > the weekend.
> > >
> > >
> > >  On Wed, Mar 5, 2014 at 11:12 AM, Marcus  wrote:
> > >>
> > >>> Wouldn't this be implemented as just changing disk offerings? The
> > >>> resizeVolume API call already allows you to switch disk offerings, we
> > >>> just need to add a hook in there to optionally call the storage
> driver
> > >>> (If volume is deployed to a primary storage) to make an update to the
> > >>> iops properties on the backend storage. Come to think of it,
> depending
> > >>> on how storage drivers are implementing the iops/limits feature,
> > >>> resizeVolume might be breaking this, or simply requiring a reboot to
> > >>> apply. That is, if the storage driver is setting the iops just once
> > >>> upon volume creation, it's probably breaking when a user moves a disk
> > >>> between offerings that may have alternate iops limits (this is
> > >>> probably not the case for hypervisor throttling, as that's applied
> > >>> from whatever is current when the VM starts up).
> > >>>
> > >>> On Wed, Mar 5, 2014 at 9:58 AM, Mike Tutkowski
> > >>>  wrote:
> > >>>
> >  Hi,
> > 
> >  Perhaps I'm not following this correctly, but I'm a bit lost on why
> we
> >  are
> >  talking about changing settings on running VMs.
> > 
> >   From what I understand, you are a representative of a storage
> vendor
> >  that
> >  has a rate-limiting feature. You want to be able to not only set the
> > Max
> >  IOPS, but also adjust them. Is this true?
> > 
> >  If so, I totally agree. SolidFire has control over Min and Max IOPS
> > and
> >  it
> >  is on my to-do list to add support into CloudStack to be able to
> >  dynamically change these values (right now customers do this from
> the
> >  SolidFire API or its GUI).
> > 
> >  If you would like to work on this feature, that would be great. I'd
> be
> >  happy to review your design and code.
> > 
> >  One complication is that we are looking at adding support for
> generic
> >  key/value pairs for storage plug-ins in 4.5 and this would
> effectively
> >  remove the need to have Min and Max IOPS as "special" fields in the
> >  CloudStack API and GUI.
> > 
> >  I'm going to CC Chris Suichll (from NetApp) as he and I have already
> >  discussed this generic-properties concept. It would be good to get
> his
> >  feedback on how we might go about dynamically updating
> storage-plug-in
> >  key/value pairs.
> > 
> >  Thanks!
> >  Mike
> > 
> > 
> >  On Wed, Mar 5, 2014 at 3:12 AM, Wido den Hollander 
> >  wrote:
> > 
> > 
> > >
> > > On 03/05/2014 10:12 AM, Wei ZHOU wrote:
> > >
> > >  I was thinking about it last week.
> > >> AFAIK, libvirt-java 0.5.1 does not support change setting on
> running
> > >> vms,
> > >> but virsh command line and libvirt API supports it.
> > >> so the sulution are
> > >> (1) change libvirt-java to support it, and make it released in the
> > >> next
> > >> version. Maybe Wido can help us.
> > >>
> > >>
> > > Sure! That seems the best way forward. What is currently lacking in
> > the
> > > libvirt-java bindings?
> > >
> > >
> > >   (2) call virsh command line.
> > >
> > >>
> > >>
> > >>  Please, please, do not do that. That's very hacky. We should
> really
> > > keep
> > > using the libvirt-java bindings and stay away from invoking
> binaries.
> > >
> > > Wido
> > >
> > >
> > >   -Wei
> > >
> > >>
> > >> 2014-03-05 9:01 GMT+01:00 Punith S :
> > >>
> > >>   hi guys,
> > >>
> > >>>
> > >>> we are having 

Re: spring modification in order to register new storage plugin ?

2014-03-06 Thread Mike Tutkowski
No problem!


On Thu, Mar 6, 2014 at 10:14 PM, Punith S  wrote:

> thanks mike , it worked :)
>
>
> On Thu, Mar 6, 2014 at 8:48 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com
> > wrote:
>
> > Hi Punith,
> >
> > Did you add something like this to client/pom.xml?
> >
> > 
> >
> >   org.apache.cloudstack
> >
> >   cloud-plugin-storage-volume-solidfire
> >
> >   ${project.version}
> >
> > 
> >
> >
> > On Thu, Mar 6, 2014 at 7:29 AM, Punith S  wrote:
> >
> > > hi guys,
> > >
> > > i have built a new storage plugin for 4.4, and i have added new
> > > module.properties as well as
> > > new spring-storage-volume-cloudbyte-context.xml with the new provider
> > bean
> > > along with the
> > > new addition in pom.xml of plugins directory.
> > >
> > > after running, mvn -P developer,systemvm clean install,
> > >
> > > the build is showing successful, but my plugin jar can't be found in
> the
> > > client/target/cloud.war file
> > >
> > > but i copied it for my local .m2 repo to the lib folder and ran  mvn
> -pl
> > > :cloud-client-ui jetty:run on localhost, 4.4 is coming alive but my
> > plugin
> > > module without my plugin being loaded even though the jar being
> > implanted.
> > >
> > > so am i missing any spring configuration ?
> > >
> > >
> > >
> > > regards,
> > >
> > > punith s
> > > cloudbyte.com
> > >
> >
> >
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Punith S
yea sure , will target this for 4.5.

thanks


On Thu, Mar 6, 2014 at 8:37 PM, Mike Tutkowski  wrote:

> Just to clarify, Punith: You are correct that changing storage QoS
> dynamically will be a more time-consuming task than adding that kind of
> support on the hypervisor side. That's why I say with the Feature Freeze
> date as it is for 4.4 that we should look to address this in 4.5.
>
> Thanks
>
>
> On Thu, Mar 6, 2014 at 3:42 AM, Wido den Hollander  wrote:
>
> >
> >
> > On 03/05/2014 07:18 PM, Marcus wrote:
> >
> >> For the hypervisor version of throttling, we just need
> >> ResizeVolumeCommand to pass the VolumeObjectTO rather than just the
> >> volume uuid/path, so that when we change offerings on the agent side
> >> we have the info we need to update libvirt with the new iops/bytes
> >> settings. We also need the libvirt java bindings to do so, per
> >> previous discussion.
> >>
> >>
> > I'm already working on the patch: https://github.com/wido/
> > libvirt-java/tree/change-iops
> >
> > It's not so hard to implement it seems. Hopefully I'll have it ready
> after
> > the weekend.
> >
> >
> >  On Wed, Mar 5, 2014 at 11:12 AM, Marcus  wrote:
> >>
> >>> Wouldn't this be implemented as just changing disk offerings? The
> >>> resizeVolume API call already allows you to switch disk offerings, we
> >>> just need to add a hook in there to optionally call the storage driver
> >>> (If volume is deployed to a primary storage) to make an update to the
> >>> iops properties on the backend storage. Come to think of it, depending
> >>> on how storage drivers are implementing the iops/limits feature,
> >>> resizeVolume might be breaking this, or simply requiring a reboot to
> >>> apply. That is, if the storage driver is setting the iops just once
> >>> upon volume creation, it's probably breaking when a user moves a disk
> >>> between offerings that may have alternate iops limits (this is
> >>> probably not the case for hypervisor throttling, as that's applied
> >>> from whatever is current when the VM starts up).
> >>>
> >>> On Wed, Mar 5, 2014 at 9:58 AM, Mike Tutkowski
> >>>  wrote:
> >>>
>  Hi,
> 
>  Perhaps I'm not following this correctly, but I'm a bit lost on why we
>  are
>  talking about changing settings on running VMs.
> 
>   From what I understand, you are a representative of a storage vendor
>  that
>  has a rate-limiting feature. You want to be able to not only set the
> Max
>  IOPS, but also adjust them. Is this true?
> 
>  If so, I totally agree. SolidFire has control over Min and Max IOPS
> and
>  it
>  is on my to-do list to add support into CloudStack to be able to
>  dynamically change these values (right now customers do this from the
>  SolidFire API or its GUI).
> 
>  If you would like to work on this feature, that would be great. I'd be
>  happy to review your design and code.
> 
>  One complication is that we are looking at adding support for generic
>  key/value pairs for storage plug-ins in 4.5 and this would effectively
>  remove the need to have Min and Max IOPS as "special" fields in the
>  CloudStack API and GUI.
> 
>  I'm going to CC Chris Suichll (from NetApp) as he and I have already
>  discussed this generic-properties concept. It would be good to get his
>  feedback on how we might go about dynamically updating storage-plug-in
>  key/value pairs.
> 
>  Thanks!
>  Mike
> 
> 
>  On Wed, Mar 5, 2014 at 3:12 AM, Wido den Hollander 
>  wrote:
> 
> 
> >
> > On 03/05/2014 10:12 AM, Wei ZHOU wrote:
> >
> >  I was thinking about it last week.
> >> AFAIK, libvirt-java 0.5.1 does not support change setting on running
> >> vms,
> >> but virsh command line and libvirt API supports it.
> >> so the sulution are
> >> (1) change libvirt-java to support it, and make it released in the
> >> next
> >> version. Maybe Wido can help us.
> >>
> >>
> > Sure! That seems the best way forward. What is currently lacking in
> the
> > libvirt-java bindings?
> >
> >
> >   (2) call virsh command line.
> >
> >>
> >>
> >>  Please, please, do not do that. That's very hacky. We should really
> > keep
> > using the libvirt-java bindings and stay away from invoking binaries.
> >
> > Wido
> >
> >
> >   -Wei
> >
> >>
> >> 2014-03-05 9:01 GMT+01:00 Punith S :
> >>
> >>   hi guys,
> >>
> >>>
> >>> we are having a fixed max iops for each volume being attached to
> the
> >>> instance in managed storage,
> >>> so this a problem where we are making users to pre allocate the
> iops
> >>> of
> >>> the
> >>> disk without having an option to change or resize it, similar to
> the
> >>> size
> >>> metric.
> >>>
> >>> so i would like to introduce a new feature which enables to change
> or
> >>> resi

Re: spring modification in order to register new storage plugin ?

2014-03-06 Thread Punith S
thanks mike , it worked :)


On Thu, Mar 6, 2014 at 8:48 PM, Mike Tutkowski  wrote:

> Hi Punith,
>
> Did you add something like this to client/pom.xml?
>
> 
>
>   org.apache.cloudstack
>
>   cloud-plugin-storage-volume-solidfire
>
>   ${project.version}
>
> 
>
>
> On Thu, Mar 6, 2014 at 7:29 AM, Punith S  wrote:
>
> > hi guys,
> >
> > i have built a new storage plugin for 4.4, and i have added new
> > module.properties as well as
> > new spring-storage-volume-cloudbyte-context.xml with the new provider
> bean
> > along with the
> > new addition in pom.xml of plugins directory.
> >
> > after running, mvn -P developer,systemvm clean install,
> >
> > the build is showing successful, but my plugin jar can't be found in the
> > client/target/cloud.war file
> >
> > but i copied it for my local .m2 repo to the lib folder and ran  mvn -pl
> > :cloud-client-ui jetty:run on localhost, 4.4 is coming alive but my
> plugin
> > module without my plugin being loaded even though the jar being
> implanted.
> >
> > so am i missing any spring configuration ?
> >
> >
> >
> > regards,
> >
> > punith s
> > cloudbyte.com
> >
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the
> cloud
> *(tm)*
>



-- 
regards,

punith s
cloudbyte.com


Build failed in Jenkins: build-master-slowbuild #373

2014-03-06 Thread jenkins
See 

Changes:

[Alena Prokharchyk] Removed unused parameter from @Parameter

[sheng.yang] CLOUDSTACK-6047: Introduce Aggregated commands queue to VR

[sheng.yang] CLOUDSTACK-6047: Add testing for VR aggregation commands

[sheng.yang] CLOUDSTACK-6047: Fix checkstyle build issue

--
[...truncated 18074 lines...]

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ cloud-awsapi ---
[INFO] Cobertura 2.0.3 - GNU GPL License (NO WARRANTY) - See COPYRIGHT file
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/ec2/AmazonEC2SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/amazon/s3/AmazonS3SkeletonInterface.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SAcl.java.  Ensure this class was instrumented, and this 
data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SBucket.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/model/SHost.java.  Ensure this class was instrumented, and 
this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/BucketPolicyDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackAccountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackConfigurationDao.java.  Ensure this 
class was instrumented, and this data file contains the instrumentation 
information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackSvcOfferingDao.java.  Ensure this class 
was instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/CloudStackUserDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MHostMountDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartPartsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrumentation information for the file 
com/cloud/bridge/persist/dao/MultiPartUploadsDao.java.  Ensure this class was 
instrumented, and this data file contains the instrumentation information.
[cobertura] INFO  [main] net.sourceforge.cobertura.reporting.html.HTMLReport - 
Data file does not contain instrum

RE: apidocs build failure

2014-03-06 Thread Alex Hitchins
I've just checked out 4.3 and am still getting the same error.

Could this be an incorrect build?

What is the best way for me to start from scratch? Remove any existing 
dependencies and re-downloading them? If so, do I need to clear everything from 
deps folder AND the m2 directory?

Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
Sent: 06 March 2014 23:42
To: dev@cloudstack.apache.org
Subject: RE: apidocs build failure

I do not run into this issue in 4.3 branch.

Animesh

> -Original Message-
> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> Sent: Thursday, March 06, 2014 2:12 PM
> To: dev
> Subject: apidocs build failure
>
> Just trying a build against 4.3 (not 4.3-forward) and I get the following 
> error:
>
> [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-
> plugin:1.2.1:exec (compile) on project cloud-apidoc: Command execution
> failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
>
> Anyone else seen this issue? I don't know what I'm doing wrong,
> nothing is building for me!
>
>
> Regards,
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M:
> +44 7788 423 969
>
> ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
>
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure Support infrastructure-support/> offers the best 24/7 SLA for CloudStack
> Environments.
>
> Apache CloudStack Bootcamp training courses
>
> **NEW!** CloudStack 4.2.1 training training/>
> 18th-19th February 2014, Brazil.
> Classroom
> 17th-23rd March 2014, Region A. Instructor led, On-
> line
> 24th-28th March 2014, Region B. Instructor led, On-
> line
> 16th-20th June 2014, Region A. Instructor led, On-
> line
> 23rd-27th June 2014, Region B. Instructor led, On-
> line
>
> This email and any attachments to it may be confidential and are
> intended solely for the use of the individual to whom it is addressed.
> Any views or opinions expressed are solely those of the author and do
> not necessarily represent those of Shape Blue Ltd or related
> companies. If you are not the intended recipient of this email, you
> must neither take any action based upon its contents, nor copy or show
> it to anyone. Please contact the sender if you believe you have
> received this email in error. Shape Blue Ltd is a company incorporated
> in England & Wales. ShapeBlue Services India LLP is a company
> incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
> Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a 
> registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: [DISCUSS] realhostip.com going away

2014-03-06 Thread John Kinsella
So - I’ve browsed around a little after pondering the idea of doing crypto at 
the JS level, but I can’t seem to make the argument and keep a straight face. I 
did find a JS library [1] that would probably work, but still you’re left with 
2 issues: 1) gotta get the library securely to the browser (proper running SSL 
on the management server), and 2) You’d still need a CA to sign the certs that 
run on the console proxy/SSVM [2]. 

So, nix that. It seems like the best way to do this is have security off by 
default, make sure that’s very obvious to new users, and have a guide on how to 
get things production-ready.

Anyways - we almost have the patch ready, Amogh and I have gone back/forth on 
the review once or twice, once we get I think just one more issue straightened 
out we’re good.

John
1: https://github.com/digitalbazaar/forge
2: Ya know…we could run a CA on the management server….

On Mar 6, 2014, at 4:53 PM, Kelven Yang  wrote:

> 
> 
> On 3/2/14, 8:15 AM, "Paul Angus"  wrote:
> 
>> There are a few issues with the current console proxy setup, not least of
>> which is the need to have internet access to resolve realhostip.com in
>> the first place - so console proxy can't work if you don't have internet
>> access on your client.  I have configured alternative realhostip.com
>> setups for clients - and quite a lot of work goes into creating the
>> infrastructure (and certs) to support changing to a user managed
>> certificate.
>> 
>> Sooo, is it at all possible to secure communications with the console
>> proxy, without having to rely on ANY outside entity?
> 
> 
> console proxy client is based on AJAX channel provided by browser via
> Javascript engine, which leaves the security option to be pretty much on
> HTTPS, and it requires a server certificate to start with. So we don¹t
> have many choices here.
> 
> -Kelven
> 
> 
>> 
>> Testing alone is going to be a pain, if a full ssl cert setup is required
>> to use console proxy..
>> 
>> Regards
>> 
>> Paul Angus
>> Cloud Architect
>> S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
>> paul.an...@shapeblue.com
>> 
>> -Original Message-
>> From: Amogh Vasekar [mailto:amogh.vase...@citrix.com]
>> Sent: 28 February 2014 23:05
>> To: dev@cloudstack.apache.org
>> Subject: Re: [DISCUSS] realhostip.com going away
>> 
>> 
>> 
>> On 2/28/14 2:03 PM, "Nux!"  wrote:
>> 
>>> There's also the problem of the certificate. It comes bundled in ACS as
>>> far as I can tell.. When does it expire?
>> 
>> notBefore=Feb  3 03:30:40 2012 GMT
>> notAfter=Feb  7 05:11:23 2017 GMT
>> 
>> Need Enterprise Grade Support for Apache CloudStack?
>> Our CloudStack Infrastructure
>> Support offers
>> the best 24/7 SLA for CloudStack Environments.
>> 
>> Apache CloudStack Bootcamp training courses
>> 
>> **NEW!** CloudStack 4.2.1
>> training
>> 18th-19th February 2014, Brazil.
>> Classroom
>> 17th-23rd March 2014, Region A. Instructor led,
>> On-line
>> 24th-28th March 2014, Region B. Instructor led,
>> On-line
>> 16th-20th June 2014, Region A. Instructor led,
>> On-line
>> 23rd-27th June 2014, Region B. Instructor led,
>> On-line
>> 
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views
>> or opinions expressed are solely those of the author and do not
>> necessarily represent those of Shape Blue Ltd or related companies. If
>> you are not the intended recipient of this email, you must neither take
>> any action based upon its contents, nor copy or show it to anyone. Please
>> contact the sender if you believe you have received this email in error.
>> Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>> Services India LLP is a company incorporated in India and is operated
>> under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
>> a company incorporated in Brasil and is operated under license from Shape
>> Blue Ltd. ShapeBlue is a registered trademark.
> 

Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella



Jenkins build is back to normal : build-master #422

2014-03-06 Thread jenkins
See 



Re: [DISCUSS] realhostip.com going away

2014-03-06 Thread Kelven Yang


On 3/2/14, 8:15 AM, "Paul Angus"  wrote:

>There are a few issues with the current console proxy setup, not least of
>which is the need to have internet access to resolve realhostip.com in
>the first place - so console proxy can't work if you don't have internet
>access on your client.  I have configured alternative realhostip.com
>setups for clients - and quite a lot of work goes into creating the
>infrastructure (and certs) to support changing to a user managed
>certificate.
>
>Sooo, is it at all possible to secure communications with the console
>proxy, without having to rely on ANY outside entity?


console proxy client is based on AJAX channel provided by browser via
Javascript engine, which leaves the security option to be pretty much on
HTTPS, and it requires a server certificate to start with. So we don¹t
have many choices here.

-Kelven


>
>Testing alone is going to be a pain, if a full ssl cert setup is required
>to use console proxy..
>
>Regards
>
>Paul Angus
>Cloud Architect
>S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
>paul.an...@shapeblue.com
>
>-Original Message-
>From: Amogh Vasekar [mailto:amogh.vase...@citrix.com]
>Sent: 28 February 2014 23:05
>To: dev@cloudstack.apache.org
>Subject: Re: [DISCUSS] realhostip.com going away
>
>
>
>On 2/28/14 2:03 PM, "Nux!"  wrote:
>
>>There's also the problem of the certificate. It comes bundled in ACS as
>>far as I can tell.. When does it expire?
>
>notBefore=Feb  3 03:30:40 2012 GMT
>notAfter=Feb  7 05:11:23 2017 GMT
>
>Need Enterprise Grade Support for Apache CloudStack?
>Our CloudStack Infrastructure
>Support offers
>the best 24/7 SLA for CloudStack Environments.
>
>Apache CloudStack Bootcamp training courses
>
>**NEW!** CloudStack 4.2.1
>training
>18th-19th February 2014, Brazil.
>Classroom
>17th-23rd March 2014, Region A. Instructor led,
>On-line
>24th-28th March 2014, Region B. Instructor led,
>On-line
>16th-20th June 2014, Region A. Instructor led,
>On-line
>23rd-27th June 2014, Region B. Instructor led,
>On-line
>
>This email and any attachments to it may be confidential and are intended
>solely for the use of the individual to whom it is addressed. Any views
>or opinions expressed are solely those of the author and do not
>necessarily represent those of Shape Blue Ltd or related companies. If
>you are not the intended recipient of this email, you must neither take
>any action based upon its contents, nor copy or show it to anyone. Please
>contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is a company incorporated in India and is operated
>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
>a company incorporated in Brasil and is operated under license from Shape
>Blue Ltd. ShapeBlue is a registered trademark.



Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-06 Thread Amogh Vasekar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18759/
---

(Updated March 7, 2014, 12:32 a.m.)


Review request for cloudstack, Demetrius Tsitrelis and John Kinsella.


Changes
---

Reverting the formatting clean up


Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6204

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6204


Repository: cloudstack-git


Description
---

Changes to support HTTP mode in Console Proxy, per 
http://www.mail-archive.com/dev@cloudstack.apache.org/msg24151.html , as 
realhostip may go away

More details here : 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+changes


Diffs (updated)
-

  core/src/com/cloud/info/ConsoleProxyInfo.java 
3439f3d3bfa2e262c48f1d7b1ea4f58522f3fcbe 
  
engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 a649bb7212308de70c41e2d74de1d865949f1cb7 
  
plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java
 52cad3bc7af291e59eabc68e23e09248877e0a81 
  server/src/com/cloud/configuration/Config.java 
473db96059a4367858f9487d901b7cb3a054654a 
  server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 
c8769d43349dbc5a3103a00c905f29b7edef0468 
  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
611550e90832911fb182ad18d93a8a18333f3a35 
  setup/db/db/schema-421to430.sql 39f58d43822ebbe469d9af433582846a80ce91a0 
  systemvm/conf/consoleproxy.properties 
bb452f5823cb2da2e12aa61d762de90e4349e9ee 

Diff: https://reviews.apache.org/r/18759/diff/


Testing
---

Tested on local environment by 
1. Using HTTP based console proxy
2. HTTPS with realhostip domain
3. HTTPS with custom domain and self-signed cert
4. Secondary storage template download with custom domain and self-signed cert


Thanks,

Amogh Vasekar



Build failed in Jenkins: build-master #421

2014-03-06 Thread jenkins
See 

Changes:

[sheng.yang] CLOUDSTACK-6047: Introduce Aggregated commands queue to VR

[sheng.yang] CLOUDSTACK-6047: Add testing for VR aggregation commands

--
[...truncated 808 lines...]
---
Running org.apache.cloudstack.messagebus.TestMessageBus
log4j:WARN No appenders could be found for logger 
(org.springframework.test.context.junit4.SpringJUnit4ClassRunner).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.423 sec

Results :

Tests run: 3, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-engine ---
[INFO] Deleting 
 (includes = 
[**/*], excludes = [])
[INFO] Deleting  
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-engine 
---
[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Cloud Engine API 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-engine-api ---
[INFO] Deleting 
 
(includes = [**/*], excludes = [])
[INFO] Deleting  
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-engine-api ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-engine-api ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-engine-api ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-api ---
[INFO] Compiling 107 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-api ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-api ---
[INFO] Compiling 2 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-engine-api ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running org.apache.cloudstack.engine.subsystem.api.storage.ScopeTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.098 sec
Running 
org.apache.cloudstack.engine.subsystem.api.storage.type.VolumeTypeHelperTest
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec

Results :

Tests run: 11, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Framework - Security 4.4.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-framework-security ---
[INFO] Deleting 
 
(includes = [**/*], excludes = [])
[INFO] Deleting 
 
(includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-framework-security ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process 

Re: 4.3 vote

2014-03-06 Thread John Kinsella
David was seeing this as well. This is is a documented problem at 
https://issues.apache.org/jira/browse/RAMPART-393.

I just spun up a VM at AWS using a 64 bit amazon linux api. Ran the commands 
below, got same errors:

1  sudo yum update
2  yum install git java-1.7.0-openjdk-devel
3  git clone https://git-wip-us.apache.org/repos/asf/cloudstack.git
4  wget 
http://www.dsgnwrld.com/am/maven/maven-3/3.2.1/binaries/apache-maven-3.2.1-bin.tar.gz
5  tar xvf apache-maven-3.2.1-bin.tar.gz
6  export PATH=$PATH:~/apache-maven-3.2.1/bin/
7  cd cloudstack/
8  mvn -P deps
9  mvn clean install -Pawsapi

I suspect the Citrix devs are sitting behind Nexus or other maven mirror?

John

On Mar 6, 2014, at 3:13 PM, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>> wrote:

Folks anyone else seeing this? I want to build RC soon and wanted to confirm if 
this is an issue or not and if so if we can get a fix right away

-Original Message-
From: Prachi Damle [mailto:prachi.da...@citrix.com]
Sent: Thursday, March 06, 2014 1:20 PM
To: dev@cloudstack.apache.org
Subject: RE: 4.3 vote

John,

I could not reproduce this broken build on 4.3 after wiping out my entire
repository.
1.  rm -rf ~/.m2/repository
2. mvn clean install -Pawsapi

My build is successful.

Can someone who is able to reproduce this check this further?

Prachi


[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Apache CloudStack . SUCCESS [1:53.957s] 
[INFO]
Apache CloudStack Maven Conventions Parent  SUCCESS [0.089s] [INFO]
Apache CloudStack Framework - Managed Context . SUCCESS [28.189s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:06.368s] 
[INFO]
Apache CloudStack Framework ... SUCCESS [0.303s] [INFO]
Apache CloudStack Framework - Event Notification .. SUCCESS [27.125s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [5.878s]
[INFO] Apache CloudStack API . SUCCESS [55.346s] 
[INFO]
Apache CloudStack Framework - REST  SUCCESS [16.891s] [INFO]
Apache CloudStack Framework - IPC . SUCCESS [11.845s] [INFO]
Apache CloudStack Cloud Engine  SUCCESS [0.072s] [INFO]
Apache CloudStack Cloud Engine API  SUCCESS [10.641s] [INFO]
Apache CloudStack Core  SUCCESS [30.300s] [INFO] 
Apache
CloudStack Agents .. SUCCESS [22.533s] [INFO] Apache
CloudStack Framework - Clustering .. SUCCESS [8.801s] [INFO] Apache
CloudStack Framework - Jobs  SUCCESS [9.251s] [INFO] Apache
CloudStack Cloud Engine Schema Component ... SUCCESS [39.764s] [INFO]
Apache CloudStack Framework - Event Notification .. SUCCESS [2.761s] [INFO]
Apache CloudStack Cloud Engine Internal Components API  SUCCESS [6.014s]
[INFO] Apache CloudStack Server .. SUCCESS [1:23.722s] 
[INFO]
Apache CloudStack Usage Server  SUCCESS [9.872s] [INFO]
Apache XenSource XAPI . SUCCESS [17.003s] [INFO] 
Apache
CloudStack Cloud Engine Orchestration Component  SUCCESS [16.774s]

[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.100s] 
...
[INFO] Apache CloudStack Client UI ... SUCCESS [35.094s] 
[INFO]
Apache CloudStack Console Proxy - RDP Client .. SUCCESS [24.447s] [INFO]
Apache CloudStack Console Proxy ... SUCCESS [0.120s] [INFO]
Apache CloudStack Console Proxy - Server .. SUCCESS [6.431s] [INFO]
Apache CloudStack Framework - QuickCloud .. SUCCESS [0.577s] [INFO]
Apache CloudStack AWS API Bridge .. SUCCESS [4:57.758s] [INFO] 


[INFO] BUILD SUCCESS
[INFO] 

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: Wednesday, March 05, 2014 11:51 AM
To: dev@cloudstack.apache.org
Subject: Re: 4.3 vote

The dependency's actually been broken for a very long time, apparently. On
a clean box with no maven repository cache (rm -rf ~/.m2/repository),
awsapi (and therefore RPMs) will not build.

It looks like Noa saw similar issue in
42f3804fbdde7bfe4f3676ef0c18a54dfe95354c, but I'm still seeing issues.

John

On Mar 5, 2014, at 11:10 AM, Animesh Chaturvedi
mailto:animesh.chaturv...@citrix.com>>
wrote:

John when was the dependency broken? Are you not able to build AWSAPI?

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: Wednesday, March 05, 2014 11:00 AM
To: 
dev@cloudstack.apache.org
Subject: Re: 4.3 vote

FYI I'

RE: apidocs build failure

2014-03-06 Thread Animesh Chaturvedi
I do not run into this issue in 4.3 branch.

Animesh

> -Original Message-
> From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
> Sent: Thursday, March 06, 2014 2:12 PM
> To: dev
> Subject: apidocs build failure
> 
> Just trying a build against 4.3 (not 4.3-forward) and I get the following 
> error:
> 
> [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-
> plugin:1.2.1:exec (compile) on project cloud-apidoc: Command execution
> failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
> 
> Anyone else seen this issue? I don't know what I'm doing wrong, nothing is
> building for me!
> 
> 
> Regards,
> 
> Alex Hitchins
> 
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M:
> +44 7788 423 969
> 
> ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
> 
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure Support infrastructure-support/> offers the best 24/7 SLA for CloudStack
> Environments.
> 
> Apache CloudStack Bootcamp training courses
> 
> **NEW!** CloudStack 4.2.1 training training/>
> 18th-19th February 2014, Brazil.
> Classroom
> 17th-23rd March 2014, Region A. Instructor led, On-
> line
> 24th-28th March 2014, Region B. Instructor led, On-
> line
> 16th-20th June 2014, Region A. Instructor led, On-
> line
> 23rd-27th June 2014, Region B. Instructor led, On-
> line
> 
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape
> Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in
> Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.


Re: apidocs build failure

2014-03-06 Thread Wei ZHOU
This is because of the command  listOvsElements.
Actually it is introduced in 4.4, so it should not exist in 4.3
However, if you cherry-pick the Ovs-related commits from master/4.4 to 4.3,
you need to add a category in gen_toc.py

diff --git a/tools/apidoc/gen_toc.py b/tools/apidoc/gen_toc.py index
9e4cd31..29ff3bf 100644 --- a/tools/apidoc/gen_toc.py +++
b/tools/apidoc/gen_toc.py @@ -160,6 +160,7 @@ known_categories = { 'Ucs' :
'UCS', 'CacheStores' : 'Cache Stores', 'CacheStore' : 'Cache Store', +
'OvsElement' : 'Ovs Element', 'StratosphereSsp' : ' Stratosphere SSP' }



2014-03-06 23:23 GMT+01:00 John Kinsella :

> Can't quite tell if that's the same as what I was seeing - haven't tried
> for a few days http://markmail.org/thread/6drub4m2xgrgtfxt
>
> On Mar 6, 2014, at 2:12 PM, Alex Hitchins  > wrote:
>
> Just trying a build against 4.3 (not 4.3-forward) and I get the following
> error:
>
> [ERROR] Failed to execute goal
> org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (compile) on project
> cloud-apidoc: Command execution failed. Process exited with an error: 2
> (Exit value: 2) -> [Help 1]
>
> Anyone else seen this issue? I don't know what I'm doing wrong, nothing is
> building for me!
>
>
> Regards,
>
> Alex Hitchins
>
> D: +44 1892 523 587 | S: +44 20 3603 0540 | M:
> +44 7788 423 969
>
> ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS
>
> Need Enterprise Grade Support for Apache CloudStack?
> Our CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/> offers the best
> 24/7 SLA for CloudStack Environments.
>
> Apache CloudStack Bootcamp training courses
>
> **NEW!** CloudStack 4.2.1 training<
> http://shapeblue.com/cloudstack-training/>
> 18th-19th February 2014, Brazil. Classroom<
> http://shapeblue.com/cloudstack-training/>
> 17th-23rd March 2014, Region A. Instructor led, On-line<
> http://shapeblue.com/cloudstack-training/>
> 24th-28th March 2014, Region B. Instructor led, On-line<
> http://shapeblue.com/cloudstack-training/>
> 16th-20th June 2014, Region A. Instructor led, On-line<
> http://shapeblue.com/cloudstack-training/>
> 23rd-27th June 2014, Region B. Instructor led, On-line<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue is a
> registered trademark.
>
> Stratosec - Compliance as a Service
> o: 415.315.9385
> @johnlkinsella
>
>


RE: 4.3 vote

2014-03-06 Thread Animesh Chaturvedi
Folks anyone else seeing this? I want to build RC soon and wanted to confirm if 
this is an issue or not and if so if we can get a fix right away

> -Original Message-
> From: Prachi Damle [mailto:prachi.da...@citrix.com]
> Sent: Thursday, March 06, 2014 1:20 PM
> To: dev@cloudstack.apache.org
> Subject: RE: 4.3 vote
> 
> John,
> 
> I could not reproduce this broken build on 4.3 after wiping out my entire
> repository.
> 1.  rm -rf ~/.m2/repository
> 2. mvn clean install -Pawsapi
> 
> My build is successful.
> 
> Can someone who is able to reproduce this check this further?
> 
> Prachi
> 
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache CloudStack . SUCCESS 
> [1:53.957s] [INFO]
> Apache CloudStack Maven Conventions Parent  SUCCESS [0.089s] [INFO]
> Apache CloudStack Framework - Managed Context . SUCCESS [28.189s]
> [INFO] Apache CloudStack Utils ... SUCCESS 
> [1:06.368s] [INFO]
> Apache CloudStack Framework ... SUCCESS [0.303s] [INFO]
> Apache CloudStack Framework - Event Notification .. SUCCESS [27.125s]
> [INFO] Apache CloudStack Framework - Configuration ... SUCCESS [5.878s]
> [INFO] Apache CloudStack API . SUCCESS [55.346s] 
> [INFO]
> Apache CloudStack Framework - REST  SUCCESS [16.891s] [INFO]
> Apache CloudStack Framework - IPC . SUCCESS [11.845s] [INFO]
> Apache CloudStack Cloud Engine  SUCCESS [0.072s] [INFO]
> Apache CloudStack Cloud Engine API  SUCCESS [10.641s] [INFO]
> Apache CloudStack Core  SUCCESS [30.300s] [INFO] 
> Apache
> CloudStack Agents .. SUCCESS [22.533s] [INFO] Apache
> CloudStack Framework - Clustering .. SUCCESS [8.801s] [INFO] Apache
> CloudStack Framework - Jobs  SUCCESS [9.251s] [INFO] Apache
> CloudStack Cloud Engine Schema Component ... SUCCESS [39.764s] [INFO]
> Apache CloudStack Framework - Event Notification .. SUCCESS [2.761s] [INFO]
> Apache CloudStack Cloud Engine Internal Components API  SUCCESS [6.014s]
> [INFO] Apache CloudStack Server .. SUCCESS 
> [1:23.722s] [INFO]
> Apache CloudStack Usage Server  SUCCESS [9.872s] [INFO]
> Apache XenSource XAPI . SUCCESS [17.003s] [INFO] 
> Apache
> CloudStack Cloud Engine Orchestration Component  SUCCESS [16.774s]
> 
> [INFO] Apache CloudStack Cloud Services .. SUCCESS [0.100s] 
> ...
>  [INFO] Apache CloudStack Client UI ... SUCCESS [35.094s] 
> [INFO]
> Apache CloudStack Console Proxy - RDP Client .. SUCCESS [24.447s] [INFO]
> Apache CloudStack Console Proxy ... SUCCESS [0.120s] [INFO]
> Apache CloudStack Console Proxy - Server .. SUCCESS [6.431s] [INFO]
> Apache CloudStack Framework - QuickCloud .. SUCCESS [0.577s] [INFO]
> Apache CloudStack AWS API Bridge .. SUCCESS [4:57.758s] 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> 
> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: Wednesday, March 05, 2014 11:51 AM
> To: dev@cloudstack.apache.org
> Subject: Re: 4.3 vote
> 
> The dependency's actually been broken for a very long time, apparently. On
> a clean box with no maven repository cache (rm -rf ~/.m2/repository),
> awsapi (and therefore RPMs) will not build.
> 
> It looks like Noa saw similar issue in
> 42f3804fbdde7bfe4f3676ef0c18a54dfe95354c, but I'm still seeing issues.
> 
> John
> 
> On Mar 5, 2014, at 11:10 AM, Animesh Chaturvedi
> mailto:animesh.chaturv...@citrix.com>>
> wrote:
> 
> John when was the dependency broken? Are you not able to build AWSAPI?
> 
> -Original Message-
> From: John Kinsella [mailto:j...@stratosec.co]
> Sent: Wednesday, March 05, 2014 11:00 AM
> To: dev@cloudstack.apache.org
> Subject: Re: 4.3 vote
> 
> FYI I'm still -1 until CLOUDSTACK-6156 and
> https://reviews.apache.org/r/18392/ is addressed.
> 
> On Mar 5, 2014, at 10:10 AM, Animesh Chaturvedi
> mailto:animesh.chaturv...@citrix.com>>
> wrote:
> 
> 
> 
> -Original Message-
> From: sebgoa [mailto:run...@gmail.com]
> Sent: Wednesday, March 05, 2014 7:58 AM
> To: dev@cloudstack.apache.org
> Subject: Re: 4.3 vote
> 
> 
> On Mar 5, 2014, at 4:54 PM, Nux! mailto:n...@li.nux.ro>>
> wrote:
> 
> On 05.03.2014 15:52, Animesh Chaturvedi wrote:
> Working on it now, waiting on 1 last thing for realhostip changes
> 
> So, does the realhostip "feature" disappear starting with 4.3?
> 
> if that's the case we need to put this on the release notes. Happy to do so if
> someo

RE: apidocs build failure

2014-03-06 Thread Alex Hitchins
It looks similar but exactly the same. I'll try against 4.3-forward.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: 06 March 2014 22:24
To: dev@cloudstack.apache.org
Subject: Re: apidocs build failure

Can't quite tell if that's the same as what I was seeing - haven't tried for a 
few days http://markmail.org/thread/6drub4m2xgrgtfxt

On Mar 6, 2014, at 2:12 PM, Alex Hitchins 
mailto:alex.hitch...@shapeblue.com>> wrote:

Just trying a build against 4.3 (not 4.3-forward) and I get the following error:

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec 
(compile) on project cloud-apidoc: Command execution failed. Process exited 
with an error: 2 (Exit value: 2) -> [Help 1]

Anyone else seen this issue? I don't know what I'm doing wrong, nothing is 
building for me!


Regards,

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: apidocs build failure

2014-03-06 Thread John Kinsella
Can’t quite tell if that’s the same as what I was seeing - haven’t tried for a 
few days http://markmail.org/thread/6drub4m2xgrgtfxt

On Mar 6, 2014, at 2:12 PM, Alex Hitchins 
mailto:alex.hitch...@shapeblue.com>> wrote:

Just trying a build against 4.3 (not 4.3-forward) and I get the following error:

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec 
(compile) on project cloud-apidoc: Command execution failed. Process exited 
with an error: 2 (Exit value: 2) -> [Help 1]

Anyone else seen this issue? I don't know what I'm doing wrong, nothing is 
building for me!


Regards,

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.

Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella



apidocs build failure

2014-03-06 Thread Alex Hitchins
Just trying a build against 4.3 (not 4.3-forward) and I get the following error:

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec 
(compile) on project cloud-apidoc: Command execution failed. Process exited 
with an error: 2 (Exit value: 2) -> [Help 1]

Anyone else seen this issue? I don't know what I'm doing wrong, nothing is 
building for me!


Regards,

Alex Hitchins

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)

2014-03-06 Thread Alex Hitchins
Ah, sorry - I'll delete this one and add to the original.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: 06 March 2014 17:39
To: dev; Alex Hitchins
Cc: Devdeep Singh
Subject: Re: Review Request 18844: Amended review request (origin: 
https://reviews.apache.org/r/17531/)

Alex, you don't have to create a new review request for this. If you upload a 
new version of the patch we can see the diff online and decide more easily that 
concerns were met and no new concerns where introduced.

On Thu, Mar 6, 2014 at 3:59 PM, Alexander Hitchins 
 wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18844/
> ---
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Bugs: cloudstack-5440
> https://issues.apache.org/jira/browse/cloudstack-5440
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Please see amended script to add new os types. 32 & 64 bit separated and hard 
> coded to specific Id numbers.
>
>
> Diffs
> -
>
>   setup/db/db/schema-430to440.sql acc7e21
>
> Diff: https://reviews.apache.org/r/18844/diff/
>
>
> Testing
> ---
>
> Ran SQL, changes applied with no errors.
>
>
> Thanks,
>
> Alexander Hitchins
>



--
Daan
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: com.vmware.vim25 Dependency Issue?

2014-03-06 Thread Alex Hitchins
Min,

I've just registered vim25 and still get similar errors as below. I can only 
see this jar in my m2 directory.

java: cannot find symbol
  symbol:   class InvalidCollectorVersionFaultMsg
  location: package com.vmware.vim25

I'll continue the battle tomorrow.

Alex Hitchins
D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com]
Sent: 06 March 2014 17:58
To: dev@cloudstack.apache.org
Subject: Re: com.vmware.vim25 Dependency Issue?

apputils.jar and vim.jar are not needed in new Vmware SDK jar for 5.1. You only 
need to download that vmware-vim25.jar, and install, things should work. Be 
sure to clean your old .m2 repository for the old vmware jars.


Thanks
-min

On 3/6/14 9:54 AM, "Alex Hitchins"  wrote:

>Ah, OK.
>
>So when I download the SDK the jars are part of the install?
>
>
>Regards
>
>Alex Hitchins
>
>D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>
>alex.hitch...@shapeblue.com
>
>-Original Message-
>From: Min Chen [mailto:min.c...@citrix.com]
>Sent: 06 March 2014 17:37
>To: dev@cloudstack.apache.org
>Subject: Re: com.vmware.vim25 Dependency Issue?
>
>No. Those two jars are out-of-dated, we have upgraded to vmware SDK
>5.1, those are for older version of SDK.
>
>Thanks
>-min
>
>On 3/6/14 4:44 AM, "Alex Hitchins"  wrote:
>
>>I've just downloaded and run the install-non-oss.sh script however I'm
>>getting lots of errors like the below.
>>
>>java: cannot find symbol
>>  symbol:   class InvalidCollectorVersionFaultMsg
>>  location: package com.vmware.vim25
>>
>>import com.vmware.vim25.InvalidCollectorVersionFaultMsg;
>>^-Unused Import Statement
>>
>>I did notice in the install-non-oss.sh file it handles the follwing
>>.jars
>>
>>   cloud-iControl.jar
>>   cloud-netscaler-sdx.jar
>>   manageontap.jar (renamed from cloud-manageontap.jar)
>>   vim25_51.jar (renamed from vmware-vim25.jar)
>>
>>Are the .jars below included in the above somehow? I can't see where
>>these are called in the install-non-oss.sh script however they sit in
>>the deps folder.
>>
>>   apputils.jar (renamed from vmware-apputils.jar)
>>   vim.jar (renamed from vmware-vim.jar)
>>
>>Are these missing ones causing the errors above?
>>
>>
>>Regards,
>>
>>Alex Hitchins
>>
>>Need Enterprise Grade Support for Apache CloudStack?
>>Our CloudStack Infrastructure
>>Support
>>offers the best 24/7 SLA for CloudStack Environments.
>>
>>Apache CloudStack Bootcamp training courses
>>
>>**NEW!** CloudStack 4.2.1
>>training
>>18th-19th February 2014, Brazil.
>>Classroom
>>17th-23rd March 2014, Region A. Instructor led,
>>On-line
>>24th-28th March 2014, Region B. Instructor led,
>>On-line
>>16th-20th June 2014, Region A. Instructor led,
>>On-line
>>23rd-27th June 2014, Region B. Instructor led,
>>On-line
>>
>>This email and any attachments to it may be confidential and are
>>intended solely for the use of the individual to whom it is addressed.
>>Any views or opinions expressed are solely those of the author and do
>>not necessarily represent those of Shape Blue Ltd or related companies.
>>If you are not the intended recipient of this email, you must neither
>>take any action based upon its contents, nor copy or show it to anyone.
>>Please contact the sender if you believe you have received this email
>>in error.
>>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>>Services India LLP is a company incorporated in India and is operated
>>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda
>>is a company incorporated in Brasil and is operated under license from
>>Shape Blue Ltd. ShapeBlue is a registered trademark.
>
>This email and any attachments to it may be confidential and are
>intended solely for the use of the individual to whom it is addressed.
>Any views or opinions expressed are solely those of the author and do
>not necessarily represent those of Shape Blue Ltd or related companies.
>If you are not the intended recipient of this email, you must neither
>take any action based upon its contents, nor copy or show it to anyone.
>Please contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is a company incorporated in India and is operated
>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda
>is a company incorporated in Brasil and is operated under license from
>Shape Blue Ltd. ShapeBlue is a registered trademark.

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is ad

Re: Review Request 16385: Fix for CloudStack JIRA 4406

2014-03-06 Thread Alena Prokharchyk
Mandar, I¹ve ran into this checkin submitted by you:

b0c6d4734724358df97b6fa4d8c5beb0f447745e

- Updated APICommand annotation to add new flags that indicate if API
request or response carry sensitive info

And have a couple of comments on that.

1) I don¹t see the parameter being checked anywhere in the code. You just
define the annotation in each command class, but there is no processing
after all. To me, the checkin seems to be partial, unless I¹m missing
anything? 

2) Defaulting the parameter to true doesn¹t seem right to me. If I¹m a new
developer adding the API, and I don¹t care about the security, I would
expect my command to be seen in the log rather than being hidden by
default. And if I¹m a developer who is really concerned about displaying
it, I would research all existing CS API @ capabilities to see if this can
be controlled, and set it to true in my command.
Otherwise you are just spamming the code with overriding this annotation
in 99% of the API CS commands.

3) Why you define this parameter on the command level? Even the parameter
name states that the certain parameters in the request/response are
sensitive. To me it seems that it should be defined on the parameter level
- whether you want this parameter to be exposed/hidden. As an example,
look at (RoleType[] authorized() default {}) param in @Param. This
parameter determines who can pass this particular parameter to the API
call. And its ³everyone² by default, and can be overridden in the specific
command.


Mandar/Daan, can you please comment on the above.

Thanks,
Alena.


On 12/24/13, 11:39 AM, "Nitin Mehta"  wrote:

>
>
>> On Dec. 23, 2013, 5:58 p.m., Nitin Mehta wrote:
>> > api/src/org/apache/cloudstack/api/BaseCmd.java, line 415
>> > 
>>>>
>> >
>> > Can you please create names which are more intuitive such as
>>cmdRequestContainsSensitiveInfo and also better names for getters and
>>setters ?
>> 
>> Mandar Barve wrote:
>> Nitin,
>>  I wanted to keep names short at the same time convey adequate
>>meaning hence I chose those names. But I see your point, I could create
>>following names. Here the thought is to have intuitive names plus try to
>>follow getter/setter existing naming convention.
>> 
>> Let me know if you have concerns.
>> 
>> Member variables can be named as:
>> responseHasSensitiveInfo
>> requestHasSensitiveInfo
>> 
>> The getter/setters can be named as:
>> getRequestHasSensitiveInfo
>> setRequestHasSensitiveInfo
>> getResponseHasSensitiveInfo
>> setResponseHasSensitiveInfo
>> 
>> Thanks,
>> Mandar
>
>Good enough..
>
>
>> On Dec. 23, 2013, 5:58 p.m., Nitin Mehta wrote:
>> > 
>>api/src/org/apache/cloudstack/api/BaseListTemplateOrIsoPermissionsCmd.jav
>>a, line 53
>> > 
>>
>> >
>> > You shouldn't have to override for every cmd. By default its
>>false and the cmds having sensitive information can have methods
>>returning true. Also they do not need to be set in execute. This is
>>static information, doesn't change per command so why this needs to be
>>set ?
>> 
>> Mandar Barve wrote:
>> Nitin,
>> You are right. This was discussed in the earlier discussion
>>thread. You should really have to modify only commands that carry
>>sensitive information. The problem with that approach as stated earlier
>>is API developer can forget to declare command/response sensitivity by
>>implementing a method that sets the flags, returns true etc. The wrapper
>>abstract method was introduced essentially to ensure new APIs as they
>>get introduced will give compiler error if this wrapper is not
>>implemented enforcing the developer to declare such sensitivity upfront.
>> Hope that addresses your concern.
>> 
>> Thanks,
>> Mandar
>
>Thanks Mandar. I see your point and was thinking on the same lines as
>well. I appreciate your thinking for future API devs. But I have the
>following concerns
>1. I probably think that this information should be static for the Cmd
>class and doesnt have to be set on every execute invocation
>2. For few commands having sensitive information we are writing
>boilerplate code in all the api's, this is not en elegant way of
>enforcing every API developer to look into this. I would rather want this
>to be dealt through an annotation (if it doesnt exist lets create one in
>the public @interface APICommand and keep the default value to true that
>it contains sensitive information)
>
>
>- Nitin
>
>
>---
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/16385/#review30828
>---
>
>
>On Dec. 23, 2013, 6:13 p.m., Mandar Barve wrote:
>> 
>> ---
>> This is an automatically

RE: 4.3 vote

2014-03-06 Thread Prachi Damle
John,

I could not reproduce this broken build on 4.3 after wiping out my entire 
repository.
1.  rm -rf ~/.m2/repository
2. mvn clean install -Pawsapi

My build is successful.

Can someone who is able to reproduce this check this further?

Prachi


[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Apache CloudStack . SUCCESS [1:53.957s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.089s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [28.189s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:06.368s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.303s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [27.125s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [5.878s]
[INFO] Apache CloudStack API . SUCCESS [55.346s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.891s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [11.845s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.072s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [10.641s]
[INFO] Apache CloudStack Core  SUCCESS [30.300s]
[INFO] Apache CloudStack Agents .. SUCCESS [22.533s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [8.801s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [9.251s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [39.764s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [2.761s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [6.014s]
[INFO] Apache CloudStack Server .. SUCCESS [1:23.722s]
[INFO] Apache CloudStack Usage Server  SUCCESS [9.872s]
[INFO] Apache XenSource XAPI . SUCCESS [17.003s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS [16.774s]

[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.100s]
...
 [INFO] Apache CloudStack Client UI ... SUCCESS [35.094s]
[INFO] Apache CloudStack Console Proxy - RDP Client .. SUCCESS [24.447s]
[INFO] Apache CloudStack Console Proxy ... SUCCESS [0.120s]
[INFO] Apache CloudStack Console Proxy - Server .. SUCCESS [6.431s]
[INFO] Apache CloudStack Framework - QuickCloud .. SUCCESS [0.577s]
[INFO] Apache CloudStack AWS API Bridge .. SUCCESS [4:57.758s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co] 
Sent: Wednesday, March 05, 2014 11:51 AM
To: dev@cloudstack.apache.org
Subject: Re: 4.3 vote

The dependency's actually been broken for a very long time, apparently. On a 
clean box with no maven repository cache (rm -rf ~/.m2/repository), awsapi (and 
therefore RPMs) will not build.

It looks like Noa saw similar issue in 
42f3804fbdde7bfe4f3676ef0c18a54dfe95354c, but I'm still seeing issues.

John

On Mar 5, 2014, at 11:10 AM, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>> wrote:

John when was the dependency broken? Are you not able to build AWSAPI?

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: Wednesday, March 05, 2014 11:00 AM
To: dev@cloudstack.apache.org
Subject: Re: 4.3 vote

FYI I'm still -1 until CLOUDSTACK-6156 and https://reviews.apache.org/r/18392/ 
is addressed.

On Mar 5, 2014, at 10:10 AM, Animesh Chaturvedi 
mailto:animesh.chaturv...@citrix.com>> wrote:



-Original Message-
From: sebgoa [mailto:run...@gmail.com]
Sent: Wednesday, March 05, 2014 7:58 AM
To: dev@cloudstack.apache.org
Subject: Re: 4.3 vote


On Mar 5, 2014, at 4:54 PM, Nux! mailto:n...@li.nux.ro>> wrote:

On 05.03.2014 15:52, Animesh Chaturvedi wrote:
Working on it now, waiting on 1 last thing for realhostip changes

So, does the realhostip "feature" disappear starting with 4.3?

if that's the case we need to put this on the release notes. Happy to do so if 
someone send me the text..
[Animesh] It is really a convenience that we got used to not a feature. You can 
specify your own domain name and change the certificate even now with 4.2 and 
prior releases. The instructions are in Admin Guide [1]

Amogh has put a wiki on the changes at [2].


[1]
http://cloudstack.apache.org/docs/en-US//Apache_CloudStack/4.2.0/html/
Admin_Guide/console-proxy.html#change-console-proxy-ssl-certificate-do
main

[2]
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+chan
ges




Lucian

--
Sent from the Delta quadrant usin

Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-03-06 Thread Karl Harris


> On March 6, 2014, 10:09 a.m., daan Hoogland wrote:
> > Are you contemplating redundant routing on a per network basis? It would 
> > seem to me that the router, hence the whole vpc with all it networks is 
> > redundant or not.

The description below is what my initial code is working toward:

Turn on VPC redundancy and allow user to do CRUD to the networks just as it is 
now.( Create guest networks:NICS, etc; Read guest networks:NICS,etc; Update 
guest networks:NICS,etc; Delete guest networks:NICS,etc)   Because redundancy 
is turned on, the master AND backup router VM's, as well as services conntrackd 
and keepalived running on those router VM's are part of the creating, reading, 
updating and deleting of the guest networks. 

I am making these changes IN ADDITION to the existing functionality.  I do not 
want to break what exists when the redundant routing to VPC's is added, so yes, 
in that sense I am trying to keep VPC's and standalone networks aligned.

Currently, in a VPC,  a SINGLE router  is available without redundant routers. 
In a VPC, guest networks can be created, read, updated, deleted (CRUD) but 
without any redundancy only one router VM needs to be updated.  

With redundancy in VPC's both a master and backup router VM's need to be 
changed as well as supporting services conntrackd and keepalived need to be 
(re)configured when guest networks are created, read, updated and deleted. 

In contrast to VPC's the CloudStack standalone (public) networks currently 
offer a redundant network topology which is static so the redundant topology is 
created once. If CRUD changes need to be made the routers are  deleted and 
created again with the changed configuration; individual networks are never 
created or deleted.  

A bit more detail:

I understand redundancy is either in the VPC or not. In other words ALL guest 
networks within a VPC either have a redundant path or they do not. 

Currently there is CRUD for VPC guest networks, you can create, read, update 
and delete a guest network in a VPC, however VPC's do NOT have the ability to 
offer a redundant path to the guest networks.

My additions to the code are an initial attempt to adapt the existing network 
CRUD functionality to a VPC which has a redundant path for all the guest 
networks. 

When the VPC has redundancy turned on and one creates, reads, updates or 
deletes a guest network, both the master and backup router configuration need 
to be altered based on what is being changed.   When the VPC has redundancy 
turned on the conntrackd and keepalived services need to be reconfigured and 
possibly stopped and started when a guest network create, update or delete 
takes place.


- Karl


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18795/#review36352
---


On March 5, 2014, 8:20 p.m., Karl Harris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18795/
> ---
> 
> (Updated March 5, 2014, 8:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes/additions to BASH scripts and .java files as well as pseudo code 
> comments. This posting is a sanity check review posting; before I get too far 
> along with making the changes required for this JIRA CloudStack-764 nTier 
> Apps 2.0 : Redundant Virtual Router for VPC I thought I'd publish my 
> intentions to the community to review and comment.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java 
> 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  03af0da51b1eec93eb878fd1ebeca2ff2e0802ce 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  69b7c9e07c753c0f0c93197a809acfb3399cf555 
>   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh 
> e5da2e096b30f6fdb15226e889517537d04f2e3e 
> 
> Diff: https://reviews.apache.org/r/18795/diff/
> 
> 
> Testing
> ---
> 
> None, yet still coding
> 
> 
> Thanks,
> 
> Karl Harris
> 
>



Just checked in a minor change to the DB

2014-03-06 Thread Mike Tutkowski
Hi everyone,

Just wanted to give you a heads up that I made a minor change to two views
in the DB in 9b66866dc2085486f465159cbd446ac03e266a2c:

service_offering_view and disk_offering_view

I added some columns to these views so I could present additional info in
the GUI.

If you want to bring these two views up to date, just run the following SQL:

DROP VIEW IF EXISTS `cloud`.`disk_offering_view`;
CREATE VIEW `cloud`.`disk_offering_view` AS
select
disk_offering.id,
disk_offering.uuid,
disk_offering.name,
disk_offering.display_text,
disk_offering.disk_size,
disk_offering.min_iops,
disk_offering.max_iops,
disk_offering.created,
disk_offering.tags,
disk_offering.customized,
disk_offering.customized_iops,
disk_offering.removed,
disk_offering.use_local_storage,
disk_offering.system_use,
disk_offering.hv_ss_reserve,
disk_offering.bytes_read_rate,
disk_offering.bytes_write_rate,
disk_offering.iops_read_rate,
disk_offering.iops_write_rate,
disk_offering.cache_mode,
disk_offering.sort_key,
disk_offering.type,
disk_offering.display_offering,
domain.id domain_id,
domain.uuid domain_uuid,
domain.name domain_name,
domain.path domain_path
from
`cloud`.`disk_offering`
left join
`cloud`.`domain` ON disk_offering.domain_id = domain.id
where
disk_offering.state='ACTIVE';

DROP VIEW IF EXISTS `cloud`.`service_offering_view`;
CREATE VIEW `cloud`.`service_offering_view` AS
select
service_offering.id,
disk_offering.uuid,
disk_offering.name,
disk_offering.display_text,
disk_offering.created,
disk_offering.tags,
disk_offering.removed,
disk_offering.use_local_storage,
disk_offering.system_use,
disk_offering.customized_iops,
disk_offering.min_iops,
disk_offering.max_iops,
disk_offering.hv_ss_reserve,
disk_offering.bytes_read_rate,
disk_offering.bytes_write_rate,
disk_offering.iops_read_rate,
disk_offering.iops_write_rate,
disk_offering.cache_mode,
service_offering.cpu,
service_offering.speed,
service_offering.ram_size,
service_offering.nw_rate,
service_offering.mc_rate,
service_offering.ha_enabled,
service_offering.limit_cpu_use,
service_offering.host_tag,
service_offering.default_use,
service_offering.vm_type,
service_offering.sort_key,
service_offering.is_volatile,
service_offering.deployment_planner,
domain.id domain_id,
domain.uuid domain_uuid,
domain.name domain_name,
domain.path domain_path
from
`cloud`.`service_offering`
inner join
`cloud`.`disk_offering` ON service_offering.id = disk_offering.id
left join
`cloud`.`domain` ON disk_offering.domain_id = domain.id
where
disk_offering.state='Active';

Thanks!

-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Couple JavaScript Questions

2014-03-06 Thread Mike Tutkowski
Just ran a little test on #2 and if args is null, it returns "N/A" as
expected.


On Thu, Mar 6, 2014 at 8:41 AM, Mike Tutkowski  wrote:

> Well, I believe the way it works is maxiops is being passed to the
> converter function with the name args.
>
> The code does work, but I was curious what would happen from a JavaScript
> standpoint if args was null.
>
>
> On Thu, Mar 6, 2014 at 12:34 AM, Punith S  wrote:
>
>> the first block seems to be fine , but in the second block , (args > 0)
>> seems to be incorrect because args is an object right ? which inturn
>> contains the volume properties.
>> which can be accessed as args.volume.maxiops i guess.
>>
>> thanks
>>
>>
>> On Thu, Mar 6, 2014 at 12:52 PM, Mike Tutkowski <
>> mike.tutkow...@solidfire.com> wrote:
>>
>> > Hi,
>> >
>> > I'm not nearly as well versed in JavaScript as I am in Java. I was
>> > wondering if someone could answer these questions for me:
>> >
>> > If "memory" is stored in the DB as null, I assume args will be equal to
>> > undefined below. Is that correct?
>> >
>> > memory: {
>> > label: 'label.memory.mb',
>> > converter: function(args) {
>> > if (args == undefined)
>> > return '';
>> > else
>> > return cloudStack.converters.convertBytes(args * 1024 *
>> 1024);
>> > }
>> > },
>> >
>> > If "maxiops" is stored in the DB as null, will we simply return "N/A"
>> or is
>> > there a problem comparing what is essentially an undefined variable
>> with 0?
>> >
>> > maxiops: {
>> > label: 'label.disk.iops.max',
>> > converter: function(args) {
>> > if (args > 0)
>> > return args;
>> > else
>> > return "N/A";
>> > }
>> > },
>> >
>> > Thanks!
>> >
>> > --
>> > *Mike Tutkowski*
>> > *Senior CloudStack Developer, SolidFire Inc.*
>> > e: mike.tutkow...@solidfire.com
>> > o: 303.746.7302
>> > Advancing the way the world uses the
>> > cloud
>> > *(tm)*
>> >
>>
>>
>>
>> --
>> regards,
>>
>> punith s
>> cloudbyte.com
>>
>
>
>
> --
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the 
> cloud
> *(tm)*
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-06 Thread Amogh Vasekar


> On March 6, 2014, 6:31 p.m., John Kinsella wrote:
> > setup/db/db/schema-421to430.sql, line 126
> > 
> >
> > 1) Why 2 subqueries on these 2 updates? Shouldn't just...
> > 
> > UPDATE `cloud`.`configuration` 
> > SET `value` = CONCAT("*.",(SELECT `value` FROM `cloud`.`configuration` 
> > WHERE `name`="secstorage.ssl.cert.domain")) 
> > WHERE `name`="secstorage.ssl.cert.domain";
> > 
> > work?
> > 
> > 2) What happens here if a install already has changed away from 
> > realhostip.com?

Hi,
Thanks for the comments.

1. Unfortunately, MySQL does not allow you to update a table and select from 
the same table in a subquery. Hence the need.
2. If it has already changed away from realhostip to somedomain, it will be 
replaced by *.somedomain.com and should work seamlessly. More info at : 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+changes#RealhostIPchanges-Upgrade


- Amogh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18759/#review36376
---


On March 5, 2014, 8:47 p.m., Amogh Vasekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18759/
> ---
> 
> (Updated March 5, 2014, 8:47 p.m.)
> 
> 
> Review request for cloudstack, Demetrius Tsitrelis and John Kinsella.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6204
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6204
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes to support HTTP mode in Console Proxy, per 
> http://www.mail-archive.com/dev@cloudstack.apache.org/msg24151.html , as 
> realhostip may go away
> 
> More details here : 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+changes
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/info/ConsoleProxyInfo.java 
> 3439f3d3bfa2e262c48f1d7b1ea4f58522f3fcbe 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
>  a649bb7212308de70c41e2d74de1d865949f1cb7 
>   
> plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java
>  52cad3bc7af291e59eabc68e23e09248877e0a81 
>   server/src/com/cloud/configuration/Config.java 
> 473db96059a4367858f9487d901b7cb3a054654a 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 
> c8769d43349dbc5a3103a00c905f29b7edef0468 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 611550e90832911fb182ad18d93a8a18333f3a35 
>   setup/db/db/schema-421to430.sql 39f58d43822ebbe469d9af433582846a80ce91a0 
>   systemvm/conf/consoleproxy.properties 
> bb452f5823cb2da2e12aa61d762de90e4349e9ee 
> 
> Diff: https://reviews.apache.org/r/18759/diff/
> 
> 
> Testing
> ---
> 
> Tested on local environment by 
> 1. Using HTTP based console proxy
> 2. HTTPS with realhostip domain
> 3. HTTPS with custom domain and self-signed cert
> 4. Secondary storage template download with custom domain and self-signed cert
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>



Re: Review Request 18759: HTTP support for console proxy and making it default

2014-03-06 Thread John Kinsella

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18759/#review36376
---



core/src/com/cloud/info/ConsoleProxyInfo.java


You're now fixing whitespace issues, instead of adding them. :)

Please leave formatting corrections for a separate review or commit, 
they're not related to this bug.

Sorry, I'm a stickler on mixing formatting changes with logic changes. 
Makes the patch less readable.



server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java


Pull this set of include re-ordering from the patch please. Not a logic 
change, confusing.



setup/db/db/schema-421to430.sql


1) Why 2 subqueries on these 2 updates? Shouldn't just...

UPDATE `cloud`.`configuration` 
SET `value` = CONCAT("*.",(SELECT `value` FROM `cloud`.`configuration` 
WHERE `name`="secstorage.ssl.cert.domain")) 
WHERE `name`="secstorage.ssl.cert.domain";

work?

2) What happens here if a install already has changed away from 
realhostip.com?


- John Kinsella


On March 5, 2014, 8:47 p.m., Amogh Vasekar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18759/
> ---
> 
> (Updated March 5, 2014, 8:47 p.m.)
> 
> 
> Review request for cloudstack, Demetrius Tsitrelis and John Kinsella.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6204
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6204
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes to support HTTP mode in Console Proxy, per 
> http://www.mail-archive.com/dev@cloudstack.apache.org/msg24151.html , as 
> realhostip may go away
> 
> More details here : 
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Realhost+IP+changes
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/info/ConsoleProxyInfo.java 
> 3439f3d3bfa2e262c48f1d7b1ea4f58522f3fcbe 
>   
> engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
>  a649bb7212308de70c41e2d74de1d865949f1cb7 
>   
> plugins/storage/image/default/src/org/apache/cloudstack/storage/datastore/driver/CloudStackImageStoreDriverImpl.java
>  52cad3bc7af291e59eabc68e23e09248877e0a81 
>   server/src/com/cloud/configuration/Config.java 
> 473db96059a4367858f9487d901b7cb3a054654a 
>   server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 
> c8769d43349dbc5a3103a00c905f29b7edef0468 
>   server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 
> 611550e90832911fb182ad18d93a8a18333f3a35 
>   setup/db/db/schema-421to430.sql 39f58d43822ebbe469d9af433582846a80ce91a0 
>   systemvm/conf/consoleproxy.properties 
> bb452f5823cb2da2e12aa61d762de90e4349e9ee 
> 
> Diff: https://reviews.apache.org/r/18759/diff/
> 
> 
> Testing
> ---
> 
> Tested on local environment by 
> 1. Using HTTP based console proxy
> 2. HTTPS with realhostip domain
> 3. HTTPS with custom domain and self-signed cert
> 4. Secondary storage template download with custom domain and self-signed cert
> 
> 
> Thanks,
> 
> Amogh Vasekar
> 
>



Re: Review Request 15323: CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator

2014-03-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15323/#review36382
---


Commit 1e5415d9612d9226b89bd4906563986feb3a175c in cloudstack's branch 
refs/heads/4.3-forward from David Grizzanti
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1e5415d ]

CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator

Signed-off-by: Prasanna Santhanam 


- ASF Subversion and Git Services


On Nov. 7, 2013, 8:31 p.m., David Grizzanti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15323/
> ---
> 
> (Updated Nov. 7, 2013, 8:31 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Bugs: CLOUDSTACK-5080
> https://issues.apache.org/jira/browse/CLOUDSTACK-5080
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> CLOUDSTACK-5080: Hypervisor Capabilities table missing entry for Simulator
> - Added new SQL file to db/setup so that a row gets inserted during simulator 
> DB setup for a 'Simulator' hypervisor (in hypervisor_capabilities).
> - Updated developer/pom.xml to include this new file
> 
> 
> Diffs
> -
> 
>   developer/pom.xml 0eb18bf 
>   setup/db/hypervisor_capabilities.simulator.sql PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15323/diff/
> 
> 
> Testing
> ---
> 
> Tested on master and 4.2
> 
> 
> Thanks,
> 
> David Grizzanti
> 
>



Re: Review Request 18768: CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

2014-03-06 Thread ASF Subversion and Git Services

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18768/#review36381
---


Commit 7fb2b8c68e7374d1969ce5ae9af890948dfdd9ce in cloudstack's branch 
refs/heads/4.3-forward from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7fb2b8c ]

CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool

Signed-off-by: Koushik Das 


- ASF Subversion and Git Services


On March 5, 2014, 11:17 a.m., Saksham Srivastava wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18768/
> ---
> 
> (Updated March 5, 2014, 11:17 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6151
> https://issues.apache.org/jira/browse/CLOUDSTACK-6151
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Patch for master :
> https://reviews.apache.org/r/18352/
> 
> 
> Diffs
> -
> 
>   
> engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
>  08efb83 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDao.java
>  2c4369d 
>   
> engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
>  57afa16 
>   server/test/resources/createNetworkOffering.xml c6228da 
> 
> Diff: https://reviews.apache.org/r/18768/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>



Re: OVS plugin in CloudStack 4.3.0

2014-03-06 Thread Nguyen Anh Tu
Removing commits done, Animesh. I will follow on 4.4 branch.

Cheers,

--Tuna


On Fri, Mar 7, 2014 at 12:41 AM, Nguyen Anh Tu  wrote:

>
> On Fri, Mar 7, 2014 at 12:28 AM, Animesh Chaturvedi <
> animesh.chaturv...@citrix.com> wrote:
>
>> Tuna I also noticed in your patch you are making changes to older upgrade
>> file schema-410to420.sql. After 4.2 is released the upgrade file is frozen
>> and we cannot change it.
>
>
> Sure, Animesh. That's why I have to make another commit to fix old version
> problem when rebasing. Anyway, I'm doing revert these commits out of
> 4.3-forward right now. They were on master branch long time ago.
>
> Thanks,
>
> --Tuna
>


Re: com.vmware.vim25 Dependency Issue?

2014-03-06 Thread Min Chen
apputils.jar and vim.jar are not needed in new Vmware SDK jar for 5.1. You
only need to download that vmware-vim25.jar, and install, things should
work. Be sure to clean your old .m2 repository for the old vmware jars.


Thanks
-min

On 3/6/14 9:54 AM, "Alex Hitchins"  wrote:

>Ah, OK.
>
>So when I download the SDK the jars are part of the install?
>
>
>Regards
>
>Alex Hitchins
>
>D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969
>
>alex.hitch...@shapeblue.com
>
>-Original Message-
>From: Min Chen [mailto:min.c...@citrix.com]
>Sent: 06 March 2014 17:37
>To: dev@cloudstack.apache.org
>Subject: Re: com.vmware.vim25 Dependency Issue?
>
>No. Those two jars are out-of-dated, we have upgraded to vmware SDK 5.1,
>those are for older version of SDK.
>
>Thanks
>-min
>
>On 3/6/14 4:44 AM, "Alex Hitchins"  wrote:
>
>>I've just downloaded and run the install-non-oss.sh script however I'm
>>getting lots of errors like the below.
>>
>>java: cannot find symbol
>>  symbol:   class InvalidCollectorVersionFaultMsg
>>  location: package com.vmware.vim25
>>
>>import com.vmware.vim25.InvalidCollectorVersionFaultMsg;
>>^-Unused Import Statement
>>
>>I did notice in the install-non-oss.sh file it handles the follwing
>>.jars
>>
>>   cloud-iControl.jar
>>   cloud-netscaler-sdx.jar
>>   manageontap.jar (renamed from cloud-manageontap.jar)
>>   vim25_51.jar (renamed from vmware-vim25.jar)
>>
>>Are the .jars below included in the above somehow? I can't see where
>>these are called in the install-non-oss.sh script however they sit in
>>the deps folder.
>>
>>   apputils.jar (renamed from vmware-apputils.jar)
>>   vim.jar (renamed from vmware-vim.jar)
>>
>>Are these missing ones causing the errors above?
>>
>>
>>Regards,
>>
>>Alex Hitchins
>>
>>Need Enterprise Grade Support for Apache CloudStack?
>>Our CloudStack Infrastructure
>>Support offers
>>the best 24/7 SLA for CloudStack Environments.
>>
>>Apache CloudStack Bootcamp training courses
>>
>>**NEW!** CloudStack 4.2.1
>>training
>>18th-19th February 2014, Brazil.
>>Classroom
>>17th-23rd March 2014, Region A. Instructor led,
>>On-line
>>24th-28th March 2014, Region B. Instructor led,
>>On-line
>>16th-20th June 2014, Region A. Instructor led,
>>On-line
>>23rd-27th June 2014, Region B. Instructor led,
>>On-line
>>
>>This email and any attachments to it may be confidential and are
>>intended solely for the use of the individual to whom it is addressed.
>>Any views or opinions expressed are solely those of the author and do
>>not necessarily represent those of Shape Blue Ltd or related companies.
>>If you are not the intended recipient of this email, you must neither
>>take any action based upon its contents, nor copy or show it to anyone.
>>Please contact the sender if you believe you have received this email in
>>error.
>>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>>Services India LLP is a company incorporated in India and is operated
>>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda
>>is a company incorporated in Brasil and is operated under license from
>>Shape Blue Ltd. ShapeBlue is a registered trademark.
>
>This email and any attachments to it may be confidential and are intended
>solely for the use of the individual to whom it is addressed. Any views
>or opinions expressed are solely those of the author and do not
>necessarily represent those of Shape Blue Ltd or related companies. If
>you are not the intended recipient of this email, you must neither take
>any action based upon its contents, nor copy or show it to anyone. Please
>contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is a company incorporated in India and is operated
>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
>a company incorporated in Brasil and is operated under license from Shape
>Blue Ltd. ShapeBlue is a registered trademark.



RE: com.vmware.vim25 Dependency Issue?

2014-03-06 Thread Alex Hitchins
Ah, OK.

So when I download the SDK the jars are part of the install?


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Min Chen [mailto:min.c...@citrix.com]
Sent: 06 March 2014 17:37
To: dev@cloudstack.apache.org
Subject: Re: com.vmware.vim25 Dependency Issue?

No. Those two jars are out-of-dated, we have upgraded to vmware SDK 5.1, those 
are for older version of SDK.

Thanks
-min

On 3/6/14 4:44 AM, "Alex Hitchins"  wrote:

>I've just downloaded and run the install-non-oss.sh script however I'm
>getting lots of errors like the below.
>
>java: cannot find symbol
>  symbol:   class InvalidCollectorVersionFaultMsg
>  location: package com.vmware.vim25
>
>import com.vmware.vim25.InvalidCollectorVersionFaultMsg;
>^-Unused Import Statement
>
>I did notice in the install-non-oss.sh file it handles the follwing
>.jars
>
>   cloud-iControl.jar
>   cloud-netscaler-sdx.jar
>   manageontap.jar (renamed from cloud-manageontap.jar)
>   vim25_51.jar (renamed from vmware-vim25.jar)
>
>Are the .jars below included in the above somehow? I can't see where
>these are called in the install-non-oss.sh script however they sit in
>the deps folder.
>
>   apputils.jar (renamed from vmware-apputils.jar)
>   vim.jar (renamed from vmware-vim.jar)
>
>Are these missing ones causing the errors above?
>
>
>Regards,
>
>Alex Hitchins
>
>Need Enterprise Grade Support for Apache CloudStack?
>Our CloudStack Infrastructure
>Support offers
>the best 24/7 SLA for CloudStack Environments.
>
>Apache CloudStack Bootcamp training courses
>
>**NEW!** CloudStack 4.2.1
>training
>18th-19th February 2014, Brazil.
>Classroom
>17th-23rd March 2014, Region A. Instructor led,
>On-line
>24th-28th March 2014, Region B. Instructor led,
>On-line
>16th-20th June 2014, Region A. Instructor led,
>On-line
>23rd-27th June 2014, Region B. Instructor led,
>On-line
>
>This email and any attachments to it may be confidential and are
>intended solely for the use of the individual to whom it is addressed.
>Any views or opinions expressed are solely those of the author and do
>not necessarily represent those of Shape Blue Ltd or related companies.
>If you are not the intended recipient of this email, you must neither
>take any action based upon its contents, nor copy or show it to anyone.
>Please contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is a company incorporated in India and is operated
>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda
>is a company incorporated in Brasil and is operated under license from
>Shape Blue Ltd. ShapeBlue is a registered trademark.

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: OVS plugin in CloudStack 4.3.0

2014-03-06 Thread Nguyen Anh Tu
On Fri, Mar 7, 2014 at 12:28 AM, Animesh Chaturvedi <
animesh.chaturv...@citrix.com> wrote:

> Tuna I also noticed in your patch you are making changes to older upgrade
> file schema-410to420.sql. After 4.2 is released the upgrade file is frozen
> and we cannot change it.


Sure, Animesh. That's why I have to make another commit to fix old version
problem when rebasing. Anyway, I'm doing revert these commits out of
4.3-forward right now. They were on master branch long time ago.

Thanks,

--Tuna


Re: Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)

2014-03-06 Thread Daan Hoogland
Alex, you don't have to create a new review request for this. If you
upload a new version of the patch we can see the diff online and
decide more easily that concerns were met and no new concerns where
introduced.

On Thu, Mar 6, 2014 at 3:59 PM, Alexander Hitchins
 wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18844/
> ---
>
> Review request for cloudstack and Devdeep Singh.
>
>
> Bugs: cloudstack-5440
> https://issues.apache.org/jira/browse/cloudstack-5440
>
>
> Repository: cloudstack-git
>
>
> Description
> ---
>
> Please see amended script to add new os types. 32 & 64 bit separated and hard 
> coded to specific Id numbers.
>
>
> Diffs
> -
>
>   setup/db/db/schema-430to440.sql acc7e21
>
> Diff: https://reviews.apache.org/r/18844/diff/
>
>
> Testing
> ---
>
> Ran SQL, changes applied with no errors.
>
>
> Thanks,
>
> Alexander Hitchins
>



-- 
Daan


Re: com.vmware.vim25 Dependency Issue?

2014-03-06 Thread Min Chen
No. Those two jars are out-of-dated, we have upgraded to vmware SDK 5.1,
those are for older version of SDK.

Thanks
-min

On 3/6/14 4:44 AM, "Alex Hitchins"  wrote:

>I've just downloaded and run the install-non-oss.sh script however I'm
>getting lots of errors like the below.
>
>java: cannot find symbol
>  symbol:   class InvalidCollectorVersionFaultMsg
>  location: package com.vmware.vim25
>
>import com.vmware.vim25.InvalidCollectorVersionFaultMsg;
>^-Unused Import Statement
>
>I did notice in the install-non-oss.sh file it handles the follwing .jars
>
>   cloud-iControl.jar
>   cloud-netscaler-sdx.jar
>   manageontap.jar (renamed from cloud-manageontap.jar)
>   vim25_51.jar (renamed from vmware-vim25.jar)
>
>Are the .jars below included in the above somehow? I can't see where
>these are called in the install-non-oss.sh script however they sit in the
>deps folder.
>
>   apputils.jar (renamed from vmware-apputils.jar)
>   vim.jar (renamed from vmware-vim.jar)
>
>Are these missing ones causing the errors above?
>
>
>Regards,
>
>Alex Hitchins
>
>Need Enterprise Grade Support for Apache CloudStack?
>Our CloudStack Infrastructure
>Support offers
>the best 24/7 SLA for CloudStack Environments.
>
>Apache CloudStack Bootcamp training courses
>
>**NEW!** CloudStack 4.2.1
>training
>18th-19th February 2014, Brazil.
>Classroom
>17th-23rd March 2014, Region A. Instructor led,
>On-line
>24th-28th March 2014, Region B. Instructor led,
>On-line
>16th-20th June 2014, Region A. Instructor led,
>On-line
>23rd-27th June 2014, Region B. Instructor led,
>On-line
>
>This email and any attachments to it may be confidential and are intended
>solely for the use of the individual to whom it is addressed. Any views
>or opinions expressed are solely those of the author and do not
>necessarily represent those of Shape Blue Ltd or related companies. If
>you are not the intended recipient of this email, you must neither take
>any action based upon its contents, nor copy or show it to anyone. Please
>contact the sender if you believe you have received this email in error.
>Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue
>Services India LLP is a company incorporated in India and is operated
>under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is
>a company incorporated in Brasil and is operated under license from Shape
>Blue Ltd. ShapeBlue is a registered trademark.



RE: OVS plugin in CloudStack 4.3.0

2014-03-06 Thread Animesh Chaturvedi


> -Original Message-
> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com]
> Sent: Wednesday, March 05, 2014 10:29 AM
> To: Nguyen Anh Tu; dev@cloudstack.apache.org
> Cc: Florin Dumitrascu; Murali Reddy
> Subject: RE: OVS plugin in CloudStack 4.3.0
> 
> 
> 
> From: ng.t...@gmail.com [mailto:ng.t...@gmail.com] On Behalf Of Nguyen
> Anh Tu
> Sent: Wednesday, March 05, 2014 6:26 AM
> To: dev@cloudstack.apache.org
> Cc: Florin Dumitrascu; Animesh Chaturvedi; Murali Reddy
> Subject: Re: OVS plugin in CloudStack 4.3.0
> 
> 
> On Wed, Mar 5, 2014 at 6:52 PM, sebgoa
> mailto:run...@gmail.com>> wrote:
> Tuna, make sure that all your code and fixes is in Master. That way it will be
> in 4.4 [Animesh] And that it is a big change please revert it from 
> 4.3-forward,
> it should not get accicdently pulled into 4.3 maintenance release
[Animesh] Tuna I also noticed in your patch you are making changes to older 
upgrade file schema-410to420.sql. After 4.2 is released the upgrade file is 
frozen and we cannot change it.
> 
> Got it. Thanks Sebastien!
> 
> --Tuna


Re: Review Request 17888: Dispatcher corrections, refactoring and tests. Corrects problems from previous attempt

2014-03-06 Thread Antonio Fornie

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17888/
---

(Updated March 6, 2014, 4:36 p.m.)


Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo 
Trippaers.


Changes
---

Fix conflicts due to last master changes. Plus improving a couple of names.


Repository: cloudstack-git


Description
---

Dispatcher corrections, refactoring and tests. Corrects problems from previous 
attempts that were reverted by Alena. Most of the changes are the same, but 
this one is not creating conflicts of Map types for Aync Commands or for 
parameters as Lists or Maps.


Diffs (updated)
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 14df653 
  api/src/org/apache/cloudstack/api/BaseCmd.java e869ddf 
  api/src/org/apache/cloudstack/api/BaseListCmd.java c1a4b4c 
  api/test/org/apache/cloudstack/api/BaseCmdTest.java PRE-CREATION 
  server/resources/META-INF/cloudstack/core/spring-server-core-misc-context.xml 
fd2f5fb 
  server/src/com/cloud/api/ApiDispatcher.java 5bdefe7 
  server/src/com/cloud/api/ApiServer.java 7e29324 
  server/src/com/cloud/api/ApiServlet.java 46f7eba 
  server/src/com/cloud/api/dispatch/CommandCreationWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchChain.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchChainFactory.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchTask.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/DispatchWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java 
PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamProcessWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/ParamUnpackWorker.java PRE-CREATION 
  server/src/com/cloud/api/dispatch/SpecificCmdValidationWorker.java 
PRE-CREATION 
  server/src/com/cloud/network/as/AutoScaleManagerImpl.java 208b4a4 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 
37171f5 
  server/src/com/cloud/storage/snapshot/SnapshotSchedulerImpl.java a85c052 
  server/test/com/cloud/api/ApiDispatcherTest.java 7314a57 
  server/test/com/cloud/api/dispatch/CommandCreationWorkerTest.java 
PRE-CREATION 
  server/test/com/cloud/api/dispatch/DispatchChainFactoryTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java 
PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamProcessWorkerTest.java PRE-CREATION 
  server/test/com/cloud/api/dispatch/ParamSemanticValidationWorkerTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/17888/diff/


Testing
---

Full build and test plus manually testing many features. Also including 
CreateTagsCommand that failed in previous commit.

All unit and integration tests.

Test CS Web UI with the browser going through several use cases.

Also use the CS API by sending HTTP requests generated manually including 
requests for Async Commands with Map parameters and during these tests apart 
fromtesting correct functionality I also debugged to check that Maps created 
correctly where they should but also that in the cases where the async command 
must be persisted and later on retrieved and deserialized by gson everything 
works ok and does what and where is expected. An example based on the comment 
by Alena:
http://localhost:8096/client/api?command=createTags&resourceids=ids&resourcetype=type&tags[0].key=region&tags[0].value=canada
Also other examples like
http://localhost:8096/client/api?command=createSecondaryStagingStore&url=httpbla&details[0].key=region&details[0].value=canada&details[1].key=element&details[1].value=fire


Thanks,

Antonio Fornie



Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-03-06 Thread Daan Hoogland
Karl, thanks. This is very clear and I was missing something entirely.
I misled myself by interpreting CRUD as db action exclusively. You
have cleared my mind and make a lot of sense.

On Thu, Mar 6, 2014 at 4:29 PM, Karl Harris  wrote:
> The description below is what my initial code is working toward:
>
> Turn on VPC redundancy and allow user to do CRUD to the networks just as it
> is now.( Create guest networks:NICS, etc; Read guest networks:NICS,etc;
> Update guest networks:NICS,etc; Delete guest networks:NICS,etc)   Because
> redundancy is turned on, the master AND backup router VM's, as well as
> services conntrackd and keepalived running on those router VM's are part of
> the creating, reading, updating and deleting of the guest networks.
>
> I am making these changes IN ADDITION to the existing functionality.  I do
> not want to break what exists when the redundant routing to VPC's is added,
> so yes, in that sense I am trying to keep VPC's and standalone networks
> aligned.
>
> Currently, in a VPC,  a SINGLE router  is available without redundant
> routers. In a VPC, guest networks can be created, read, updated, deleted
> (CRUD) but without any redundancy only one router VM needs to be updated.
>
> With redundancy in VPC's both a master and backup router VM's need to be
> changed as well as supporting services conntrackd and keepalived need to be
> (re)configured when guest networks are created, read, updated and deleted.
>
> In contrast to VPC's the CloudStack standalone (public) networks currently
> offer a redundant network topology which is static so the redundant
> topology is created once. If CRUD changes need to be made the routers are
>  deleted and created again with the changed configuration; individual
> networks are never created or deleted.
>
> A bit more detail:
>
> I understand redundancy is either in the VPC or not. In other words ALL
> guest networks within a VPC either have a redundant path or they do not.
>
> Currently there is CRUD for VPC guest networks, you can create, read,
> update and delete a guest network in a VPC, however VPC's do NOT have the
> ability to offer a redundant path to the guest networks.
>
> My additions to the code are an initial attempt to adapt the existing
> network CRUD functionality to a VPC which has a redundant path for all the
> guest networks.
>
> When the VPC has redundancy turned on and one creates, reads, updates or
> deletes a guest network, both the master and backup router configuration
> need to be altered based on what is being changed.   When the VPC has
> redundancy turned on the conntrackd and keepalived services need to be
> reconfigured and possibly stopped and started when a guest network create,
> update or delete takes place.
>
> Let me know if the above is a bit clearer.
>
>
>
> Karl
>
>
>
>
> On Thu, Mar 6, 2014 at 8:02 AM, Daan Hoogland wrote:
>
>> Not very much, unless i am missing something. The redundancy can not
>> be enabled on a per network basis as the router needs to be in the air
>> twice anyway. I would not like to save data that has no use. What CRUD
>> are you thinking of? Or are you maybe putting some effort into keeping
>> VPC and standalone networks alligned?
>>
>> On Thu, Mar 6, 2014 at 1:13 PM, Karl Harris 
>> wrote:
>> > Redundancy will be on a vpc basis. I'm attempting to add  CRUD
>> functionality
>> > on a network basis. Does this make sense?
>> >
>> > On Thursday, March 6, 2014, daan Hoogland 
>> wrote:
>> >>
>> >>
>> >> ---
>> >>
>> >> This is an automatically generated e-mail. To reply, visit:
>> >> https://reviews.apache.org/r/18795/#review36352
>> >> ---
>> >>
>> >>
>> >>
>> >> Are you contemplating redundant routing on a per network basis? It would
>> >> seem to me that the router, hence the whole vpc with all it networks is
>> >> redundant or not.
>> >>
>> >> - daan Hoogland
>> >>
>> >>
>> >> On March 5, 2014, 8:20 p.m., Karl Harris wrote:
>> >> >
>> >> > ---
>> >>
>> >> > This is an automatically generated e-mail. To reply, visit:
>> >> > https://reviews.apache.org/r/18795/
>> >> > ---
>> >> >
>> >> > (Updated March 5, 2014, 8:20 p.m.)
>> >>
>> >> >
>> >> >
>> >> > Review request for cloudstack.
>> >> >
>> >> >
>> >> > Repository: cloudstack-git
>> >> >
>> >> >
>> >> > Description
>> >> > ---
>> >> >
>> >> > Changes/additions to BASH scripts and .java files as well as pseudo
>> code
>> >> > comments. This posting is a sanity check review posting; before I get
>> too
>> >> > far along with making the changes required for this JIRA
>> CloudStack-764
>> >> > nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd
>> publish my
>> >> > intentions to the community to review and comment.
>> >> >
>> >> >
>> >> > Diffs
>> >> > -
>> >> >
>> >> >   core/src/com/cloud/agent/a

Re: Couple JavaScript Questions

2014-03-06 Thread Mike Tutkowski
Well, I believe the way it works is maxiops is being passed to the
converter function with the name args.

The code does work, but I was curious what would happen from a JavaScript
standpoint if args was null.


On Thu, Mar 6, 2014 at 12:34 AM, Punith S  wrote:

> the first block seems to be fine , but in the second block , (args > 0)
> seems to be incorrect because args is an object right ? which inturn
> contains the volume properties.
> which can be accessed as args.volume.maxiops i guess.
>
> thanks
>
>
> On Thu, Mar 6, 2014 at 12:52 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > Hi,
> >
> > I'm not nearly as well versed in JavaScript as I am in Java. I was
> > wondering if someone could answer these questions for me:
> >
> > If "memory" is stored in the DB as null, I assume args will be equal to
> > undefined below. Is that correct?
> >
> > memory: {
> > label: 'label.memory.mb',
> > converter: function(args) {
> > if (args == undefined)
> > return '';
> > else
> > return cloudStack.converters.convertBytes(args * 1024 *
> 1024);
> > }
> > },
> >
> > If "maxiops" is stored in the DB as null, will we simply return "N/A" or
> is
> > there a problem comparing what is essentially an undefined variable with
> 0?
> >
> > maxiops: {
> > label: 'label.disk.iops.max',
> > converter: function(args) {
> > if (args > 0)
> > return args;
> > else
> > return "N/A";
> > }
> > },
> >
> > Thanks!
> >
> > --
> > *Mike Tutkowski*
> > *Senior CloudStack Developer, SolidFire Inc.*
> > e: mike.tutkow...@solidfire.com
> > o: 303.746.7302
> > Advancing the way the world uses the
> > cloud
> > *(tm)*
> >
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Mike Tutkowski
Yeah, it could be scripted, of course, to re-create the environment. It's
just a complex setup and I haven't spent time writing any automation
scripts to re-create state due to focusing on features I'm building.
Hopefully someday I'll get around to that.


On Thu, Mar 6, 2014 at 6:15 AM, Daan Hoogland wrote:

> Ah, yes and it is an answer to Mike's initial question indeed. It is
> not sufficient for what Miguel describes however.
>
> On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
>  wrote:
> > Hi all,
> >
> > I've been looking at the way DB related code (SQL scripts and Java
> classes) are updated and what is the impact of those updates on a live
> cloudstack DB.
> > By the way, my intention is to support a per-commit DB upgrade of a
> running system.
>
> On Thu, Mar 6, 2014 at 2:02 PM, Donal Lafferty
>  wrote:
> > The thread started with a discussion of problems with out of date
> databases.  Mike pulled from master, rebuilt, and found out his testbed's
> database was out of date and no longer works.
> >
> > We've tried to find a database solution, but out of databases are caused
> by more than schema changes.  The data in the tables and other pieces of
> CloudStack can change after a commit, especially towards the end of release
> when everyone's feature is being merged.
> >
> > With 4.2, I dealt with this issue by writing a script that rebuilt my
> testbed by replaying the API calls I made to set it up in the first place.
> >
> > Is this a solution you've considered for your dev environment?
> >
> > DL
> >
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: 06 March 2014 12:50
> >> To: dev
> >> Cc: Daan Hoogland
> >> Subject: Re: [DISCUSS] Checking in code that will break others'
> environments
> >>
> >> No, but how do you mean with respect to this thread?
> >>
> >> On Thu, Mar 6, 2014 at 1:48 PM, Donal Lafferty <
> donal.laffe...@citrix.com>
> >> wrote:
> >> > Hi Daan,
> >> >
> >> > Is there anything stopping you from scripting the configuration of
> >> > your CloudStack testbed?  E.g. with Marvin or CloudMonkey
> >> >
> >> > DL
> >> >
> >> >> -Original Message-
> >> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> >> Sent: 06 March 2014 09:53
> >> >> To: dev
> >> >> Cc: Daan Hoogland
> >> >> Subject: Re: [DISCUSS] Checking in code that will break others'
> >> >> environments
> >> >>
> >> >> I totally agree with the incremental approach. I am a fascist at time
> >> >> because i would even want people to add downgrade scripts to any db
> >> >> change they make. Having them not adjust their sql is a good first
> step,
> >> though.
> >> >>
> >> >> On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
> >> >>  wrote:
> >> >> > Hi all,
> >> >> >
> >> >> > I've been looking at the way DB related code (SQL scripts and Java
> >> >> > classes)
> >> >> are updated and what is the impact of those updates on a live
> cloudstack
> >> DB.
> >> >> > By the way, my intention is to support a per-commit DB upgrade of a
> >> >> running system.
> >> >> >
> >> >> > Anyway, I completely agree that sending an email warning people
> >> >> > about
> >> >> changes that can potentially break running environments is a good
> >> >> thing, and can save a lot of time and headaches.
> >> >> > I also like the idea of Rajani of using tools to help in the DB
> >> >> > migration
> >> >> process.
> >> >> > However, I would like to put forward another idea: what about
> >> >> > making sure
> >> >> that the changes to the DB (schema and data) are always incremental?
> >> >> >
> >> >> > I mean, once a SQL statement (say A) is added to a script it could
> >> >> > be kept as
> >> >> is, and subsequent modifications cloud be made via new statements
> >> >> (say B), instead of adapting A.
> >> >> > This would allow people to upgrade their databases to the point
> >> >> > they ran
> >> >> statement A, and afterwards upgrade it again to the point they ran
> >> >> statement B.
> >> >> > The same principle could also be applied to the Java classes that
> >> >> > do data
> >> >> migration, but maybe there it might be a bit more involved.
> >> >> >
> >> >> > Cheers,
> >> >> > Miguel
> >> >> >
> >> >> > -Original Message-
> >> >> > From: Koushik Das [mailto:koushik@citrix.com]
> >> >> > Sent: donderdag 6 maart 2014 8:25
> >> >> > To: 
> >> >> > Subject: Re: [DISCUSS] Checking in code that will break others'
> >> >> > environments
> >> >> >
> >> >> > Before doing a git pull, I generally check the sql schema changes
> >> >> > and run
> >> >> the delta manually on my existing setup. In most of the cases that
> >> >> works for me without having to redeploy the db.
> >> >> >
> >> >> > -Koushik
> >> >> >
> >> >> > On 06-Mar-2014, at 11:43 AM, Mike Tutkowski
> >> >>  wrote:
> >> >> >
> >> >> >> Yeah, I definitely just meant a "heads up" during development if
> >> >> >> you are going to change something that will break other people's
> >> >> >> environments who update. If these peopl

Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-03-06 Thread Karl Harris
The description below is what my initial code is working toward:

Turn on VPC redundancy and allow user to do CRUD to the networks just as it
is now.( Create guest networks:NICS, etc; Read guest networks:NICS,etc;
Update guest networks:NICS,etc; Delete guest networks:NICS,etc)   Because
redundancy is turned on, the master AND backup router VM's, as well as
services conntrackd and keepalived running on those router VM's are part of
the creating, reading, updating and deleting of the guest networks.

I am making these changes IN ADDITION to the existing functionality.  I do
not want to break what exists when the redundant routing to VPC's is added,
so yes, in that sense I am trying to keep VPC's and standalone networks
aligned.

Currently, in a VPC,  a SINGLE router  is available without redundant
routers. In a VPC, guest networks can be created, read, updated, deleted
(CRUD) but without any redundancy only one router VM needs to be updated.

With redundancy in VPC's both a master and backup router VM's need to be
changed as well as supporting services conntrackd and keepalived need to be
(re)configured when guest networks are created, read, updated and deleted.

In contrast to VPC's the CloudStack standalone (public) networks currently
offer a redundant network topology which is static so the redundant
topology is created once. If CRUD changes need to be made the routers are
 deleted and created again with the changed configuration; individual
networks are never created or deleted.

A bit more detail:

I understand redundancy is either in the VPC or not. In other words ALL
guest networks within a VPC either have a redundant path or they do not.

Currently there is CRUD for VPC guest networks, you can create, read,
update and delete a guest network in a VPC, however VPC's do NOT have the
ability to offer a redundant path to the guest networks.

My additions to the code are an initial attempt to adapt the existing
network CRUD functionality to a VPC which has a redundant path for all the
guest networks.

When the VPC has redundancy turned on and one creates, reads, updates or
deletes a guest network, both the master and backup router configuration
need to be altered based on what is being changed.   When the VPC has
redundancy turned on the conntrackd and keepalived services need to be
reconfigured and possibly stopped and started when a guest network create,
update or delete takes place.

Let me know if the above is a bit clearer.



Karl




On Thu, Mar 6, 2014 at 8:02 AM, Daan Hoogland wrote:

> Not very much, unless i am missing something. The redundancy can not
> be enabled on a per network basis as the router needs to be in the air
> twice anyway. I would not like to save data that has no use. What CRUD
> are you thinking of? Or are you maybe putting some effort into keeping
> VPC and standalone networks alligned?
>
> On Thu, Mar 6, 2014 at 1:13 PM, Karl Harris 
> wrote:
> > Redundancy will be on a vpc basis. I'm attempting to add  CRUD
> functionality
> > on a network basis. Does this make sense?
> >
> > On Thursday, March 6, 2014, daan Hoogland 
> wrote:
> >>
> >>
> >> ---
> >>
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/18795/#review36352
> >> ---
> >>
> >>
> >>
> >> Are you contemplating redundant routing on a per network basis? It would
> >> seem to me that the router, hence the whole vpc with all it networks is
> >> redundant or not.
> >>
> >> - daan Hoogland
> >>
> >>
> >> On March 5, 2014, 8:20 p.m., Karl Harris wrote:
> >> >
> >> > ---
> >>
> >> > This is an automatically generated e-mail. To reply, visit:
> >> > https://reviews.apache.org/r/18795/
> >> > ---
> >> >
> >> > (Updated March 5, 2014, 8:20 p.m.)
> >>
> >> >
> >> >
> >> > Review request for cloudstack.
> >> >
> >> >
> >> > Repository: cloudstack-git
> >> >
> >> >
> >> > Description
> >> > ---
> >> >
> >> > Changes/additions to BASH scripts and .java files as well as pseudo
> code
> >> > comments. This posting is a sanity check review posting; before I get
> too
> >> > far along with making the changes required for this JIRA
> CloudStack-764
> >> > nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd
> publish my
> >> > intentions to the community to review and comment.
> >> >
> >> >
> >> > Diffs
> >> > -
> >> >
> >> >   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java
> >> > 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1
> >> >
> >> >
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> >> > 03af0da51b1eec93eb878fd1ebeca2ff2e0802ce
> >> >
> >> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> >> > 69b7c9e07c753c0f0c93197a809acfb3399cf555
> >> >   systemvm/pa

Old Jira Issues

2014-03-06 Thread Alex Hitchins
All,

I've been taking a look at some of the issues in Jira and noticed a few have 
text indicating they have been resolved. The following is an example[0].

Is there a precedent on dealing with these? Do we just notify the creator and 
ask they review and update? Where the issue looks open I will go in and test.

[0] 
https://issues.apache.org/jira/browse/CLOUDSTACK-2530?jql=project%20%3D%20CLOUDSTACK%20AND%20resolution%20%3D%20Unresolved%20AND%20priority%20%3D%20Trivial%20ORDER%20BY%20key%20DESC


Regards,

Alex Hitchins


Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: spring modification in order to register new storage plugin ?

2014-03-06 Thread Mike Tutkowski
Hi Punith,

Did you add something like this to client/pom.xml?



  org.apache.cloudstack

  cloud-plugin-storage-volume-solidfire

  ${project.version}




On Thu, Mar 6, 2014 at 7:29 AM, Punith S  wrote:

> hi guys,
>
> i have built a new storage plugin for 4.4, and i have added new
> module.properties as well as
> new spring-storage-volume-cloudbyte-context.xml with the new provider bean
> along with the
> new addition in pom.xml of plugins directory.
>
> after running, mvn -P developer,systemvm clean install,
>
> the build is showing successful, but my plugin jar can't be found in the
> client/target/cloud.war file
>
> but i copied it for my local .m2 repo to the lib folder and ran  mvn -pl
> :cloud-client-ui jetty:run on localhost, 4.4 is coming alive but my plugin
> module without my plugin being loaded even though the jar being implanted.
>
> so am i missing any spring configuration ?
>
>
>
> regards,
>
> punith s
> cloudbyte.com
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Mike Tutkowski
Just to clarify, Punith: You are correct that changing storage QoS
dynamically will be a more time-consuming task than adding that kind of
support on the hypervisor side. That's why I say with the Feature Freeze
date as it is for 4.4 that we should look to address this in 4.5.

Thanks


On Thu, Mar 6, 2014 at 3:42 AM, Wido den Hollander  wrote:

>
>
> On 03/05/2014 07:18 PM, Marcus wrote:
>
>> For the hypervisor version of throttling, we just need
>> ResizeVolumeCommand to pass the VolumeObjectTO rather than just the
>> volume uuid/path, so that when we change offerings on the agent side
>> we have the info we need to update libvirt with the new iops/bytes
>> settings. We also need the libvirt java bindings to do so, per
>> previous discussion.
>>
>>
> I'm already working on the patch: https://github.com/wido/
> libvirt-java/tree/change-iops
>
> It's not so hard to implement it seems. Hopefully I'll have it ready after
> the weekend.
>
>
>  On Wed, Mar 5, 2014 at 11:12 AM, Marcus  wrote:
>>
>>> Wouldn't this be implemented as just changing disk offerings? The
>>> resizeVolume API call already allows you to switch disk offerings, we
>>> just need to add a hook in there to optionally call the storage driver
>>> (If volume is deployed to a primary storage) to make an update to the
>>> iops properties on the backend storage. Come to think of it, depending
>>> on how storage drivers are implementing the iops/limits feature,
>>> resizeVolume might be breaking this, or simply requiring a reboot to
>>> apply. That is, if the storage driver is setting the iops just once
>>> upon volume creation, it's probably breaking when a user moves a disk
>>> between offerings that may have alternate iops limits (this is
>>> probably not the case for hypervisor throttling, as that's applied
>>> from whatever is current when the VM starts up).
>>>
>>> On Wed, Mar 5, 2014 at 9:58 AM, Mike Tutkowski
>>>  wrote:
>>>
 Hi,

 Perhaps I'm not following this correctly, but I'm a bit lost on why we
 are
 talking about changing settings on running VMs.

  From what I understand, you are a representative of a storage vendor
 that
 has a rate-limiting feature. You want to be able to not only set the Max
 IOPS, but also adjust them. Is this true?

 If so, I totally agree. SolidFire has control over Min and Max IOPS and
 it
 is on my to-do list to add support into CloudStack to be able to
 dynamically change these values (right now customers do this from the
 SolidFire API or its GUI).

 If you would like to work on this feature, that would be great. I'd be
 happy to review your design and code.

 One complication is that we are looking at adding support for generic
 key/value pairs for storage plug-ins in 4.5 and this would effectively
 remove the need to have Min and Max IOPS as "special" fields in the
 CloudStack API and GUI.

 I'm going to CC Chris Suichll (from NetApp) as he and I have already
 discussed this generic-properties concept. It would be good to get his
 feedback on how we might go about dynamically updating storage-plug-in
 key/value pairs.

 Thanks!
 Mike


 On Wed, Mar 5, 2014 at 3:12 AM, Wido den Hollander 
 wrote:


>
> On 03/05/2014 10:12 AM, Wei ZHOU wrote:
>
>  I was thinking about it last week.
>> AFAIK, libvirt-java 0.5.1 does not support change setting on running
>> vms,
>> but virsh command line and libvirt API supports it.
>> so the sulution are
>> (1) change libvirt-java to support it, and make it released in the
>> next
>> version. Maybe Wido can help us.
>>
>>
> Sure! That seems the best way forward. What is currently lacking in the
> libvirt-java bindings?
>
>
>   (2) call virsh command line.
>
>>
>>
>>  Please, please, do not do that. That's very hacky. We should really
> keep
> using the libvirt-java bindings and stay away from invoking binaries.
>
> Wido
>
>
>   -Wei
>
>>
>> 2014-03-05 9:01 GMT+01:00 Punith S :
>>
>>   hi guys,
>>
>>>
>>> we are having a fixed max iops for each volume being attached to the
>>> instance in managed storage,
>>> so this a problem where we are making users to pre allocate the iops
>>> of
>>> the
>>> disk without having an option to change or resize it, similar to the
>>> size
>>> metric.
>>>
>>> so i would like to introduce a new feature which enables to change or
>>> resize the volume iops on fly without detaching the datadisk of the
>>> VM
>>> with
>>> zero downtime where performance of the datadisk can be altered at any
>>> point
>>> with the available iops of the primary storage pool, which is
>>> similar in
>>> resizing the volume or datadisk of the vm , where in latter we have
>>> to
>>> detach the data

Review Request 18844: Amended review request (origin: https://reviews.apache.org/r/17531/)

2014-03-06 Thread Alexander Hitchins

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18844/
---

Review request for cloudstack and Devdeep Singh.


Bugs: cloudstack-5440
https://issues.apache.org/jira/browse/cloudstack-5440


Repository: cloudstack-git


Description
---

Please see amended script to add new os types. 32 & 64 bit separated and hard 
coded to specific Id numbers.


Diffs
-

  setup/db/db/schema-430to440.sql acc7e21 

Diff: https://reviews.apache.org/r/18844/diff/


Testing
---

Ran SQL, changes applied with no errors.


Thanks,

Alexander Hitchins



spring modification in order to register new storage plugin ?

2014-03-06 Thread Punith S
hi guys,

i have built a new storage plugin for 4.4, and i have added new
module.properties as well as
new spring-storage-volume-cloudbyte-context.xml with the new provider bean
along with the
new addition in pom.xml of plugins directory.

after running, mvn -P developer,systemvm clean install,

the build is showing successful, but my plugin jar can't be found in the
client/target/cloud.war file

but i copied it for my local .m2 repo to the lib folder and ran  mvn -pl
:cloud-client-ui jetty:run on localhost, 4.4 is coming alive but my plugin
module without my plugin being loaded even though the jar being implanted.

so am i missing any spring configuration ?



regards,

punith s
cloudbyte.com


Unit test failing in master

2014-03-06 Thread Alex Ough
All,

Anyone who can fix this failure in
"cloudstack/plugins/alert-handlers/snmp-alerts"?

Failed tests:
appendTest(org.apache.cloudstack.alert.snmp.SnmpTrapAppenderTest):  error
snmpHelper list size not as expected  expected:<0> but was:<2>

Thanks
Alex Ough


Re: which branch to target in order to push a new feature for 4.4 ?

2014-03-06 Thread Wei ZHOU
master branch
4.4 branch will be created after feature freeze


2014-03-06 15:08 GMT+01:00 Punith S :

> hi guys,
>
> since the feature freeze for 4.4 is on 14th march, i needed to push my new
> storage plugin feature for 4.4 and i was having confusion weather we should
> be targeting the master branch or 4.3 forward or is there any other branch
> ?
>
> thanks.
> --
> regards,
>
> punith s
> cloudbyte.com
>


Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Wei ZHOU
Brilliant!


2014-03-06 12:07 GMT+01:00 Wido den Hollander :

>
>
> On 03/06/2014 11:48 AM, Wei ZHOU wrote:
>
>> awesome!
>>
>> Can you implement cpu tuning or network QoS as well ? Thanks!
>>
>>
> Yes, I was planning on adding multiple methods at once with a couple of
> patches.
>
>
>  -Wei
>>
>>
>>


which branch to target in order to push a new feature for 4.4 ?

2014-03-06 Thread Punith S
hi guys,

since the feature freeze for 4.4 is on 14th march, i needed to push my new
storage plugin feature for 4.4 and i was having confusion weather we should
be targeting the master branch or 4.3 forward or is there any other branch ?

thanks.
-- 
regards,

punith s
cloudbyte.com


RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Alex Hitchins
Thinking about this, I assume the install-non-oss.sh file needs to be changed 
to remove this entry? I'll take a look at making the change.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com]
Sent: 06 March 2014 13:47
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Yes, master should not need it.

Thanks for updating the wiki.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 7:10 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

I'm on current master. If they aren't needed in 4.3 onward then I'll amend the 
wiki accordingly.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com]
Sent: 06 March 2014 13:34
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix


Which branch you are using?
You shouldn't be needing these jar files any more since NetScaler is part of 
OSS now.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:49 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Thanks, I'll make the amendment to the wiki.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 06 March 2014 12:07
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

AFAIK, those jars are updated ones.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
it

RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Alex Hitchins
Not a problem. I wish the  VMware dependencies were that simple.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com]
Sent: 06 March 2014 13:47
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Yes, master should not need it.

Thanks for updating the wiki.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 7:10 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

I'm on current master. If they aren't needed in 4.3 onward then I'll amend the 
wiki accordingly.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com]
Sent: 06 March 2014 13:34
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix


Which branch you are using?
You shouldn't be needing these jar files any more since NetScaler is part of 
OSS now.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:49 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Thanks, I'll make the amendment to the wiki.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 06 March 2014 12:07
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

AFAIK, those jars are updated ones.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you

Re: Review Request 18733: Refactor DbUpgradeUtils

2014-03-06 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18733/#review36356
---

Ship it!


ea0dec77d98e14e47ca715c46cd0316faa37844c (not that behavior has changed slighty 
as per Miguel's comment)

- daan Hoogland


On March 4, 2014, 4:13 p.m., Miguel Ferreira wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18733/
> ---
> 
> (Updated March 4, 2014, 4:13 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo 
> Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Refactor DbUpgradeUtils
> 
>   - Move database access code to new class DatabaseAccessObject. This was 
> done to ease the effort of testing, since DbUpgradeUtils has a static API and 
> it is harder to mock static things with Mockito.
>   - Log exceptions even if ignored.
>   - Add unit tests for both DbUpgradeUtils and DatabaseAccessObject.
>   - DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws 
> CloudRuntimeException to make it consistent with the other methods in the 
> class.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 
> PRE-CREATION 
>   engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java af23b87 
>   engine/schema/test/com/cloud/upgrade/dao/DatabaseAccessObjectTest.java 
> PRE-CREATION 
>   engine/schema/test/com/cloud/upgrade/dao/DbUpgradeUtilsTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18733/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests in eclipse.
> Ran "mvn clean install".
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>



RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Vijay Venkatachalam
Yes, master should not need it. 

Thanks for updating the wiki.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com] 
Sent: Thursday, March 6, 2014 7:10 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

I'm on current master. If they aren't needed in 4.3 onward then I'll amend the 
wiki accordingly.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com]
Sent: 06 March 2014 13:34
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix


Which branch you are using?
You shouldn't be needing these jar files any more since NetScaler is part of 
OSS now.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:49 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Thanks, I'll make the amendment to the wiki.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 06 March 2014 12:07
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

AFAIK, those jars are updated ones.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registere

RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Alex Hitchins
I'm on current master. If they aren't needed in 4.3 onward then I'll amend the 
wiki accordingly.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Vijay Venkatachalam [mailto:vijay.venkatacha...@citrix.com]
Sent: 06 March 2014 13:34
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix


Which branch you are using?
You shouldn't be needing these jar files any more since NetScaler is part of 
OSS now.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:49 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Thanks, I'll make the amendment to the wiki.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 06 March 2014 12:07
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

AFAIK, those jars are updated ones.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or rela

RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Vijay Venkatachalam

Which branch you are using?
You shouldn't be needing these jar files any more since NetScaler is part of 
OSS now.

Thanks,
Vijay V.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com] 
Sent: Thursday, March 6, 2014 5:49 PM
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

Thanks, I'll make the amendment to the wiki.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 06 March 2014 12:07
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

AFAIK, those jars are updated ones.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: Review Request 18733: Refactor DbUpgradeUtils

2014-03-06 Thread daan Hoogland


> On March 4, 2014, 7:49 p.m., daan Hoogland wrote:
> > tests fail:
> > 
> > Running com.cloud.upgrade.dao.DatabaseAccessObjectTest
> > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.139 sec 
> > <<< FAILURE!
> > Running com.cloud.upgrade.dao.DbUpgradeUtilsTest
> > Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.306 sec 
> > <<< FAILURE!
> > 
> > Results :
> > 
> > Tests in error: 
> >   initializationError(com.cloud.upgrade.dao.DatabaseAccessObjectTest): 
> > Lcom/cloud/upgrade/dao/DatabaseAccessObject;
> >   com.cloud.upgrade.dao.DbUpgradeUtilsTest: 
> > Lcom/cloud/upgrade/dao/DatabaseAccessObject;
> > 
> > Tests run: 3, Failures: 0, Errors: 2, Skipped: 0
> >

the errors seem intermittent. I will run a rebase and test run and apply if all 
goes well.


- daan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18733/#review36151
---


On March 4, 2014, 4:13 p.m., Miguel Ferreira wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18733/
> ---
> 
> (Updated March 4, 2014, 4:13 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, daan Hoogland, and Hugo 
> Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Refactor DbUpgradeUtils
> 
>   - Move database access code to new class DatabaseAccessObject. This was 
> done to ease the effort of testing, since DbUpgradeUtils has a static API and 
> it is harder to mock static things with Mockito.
>   - Log exceptions even if ignored.
>   - Add unit tests for both DbUpgradeUtils and DatabaseAccessObject.
>   - DbUpgradeUtils.dropTableColumnsIfExist(...) no longer throws 
> CloudRuntimeException to make it consistent with the other methods in the 
> class.
> 
> 
> Diffs
> -
> 
>   engine/schema/src/com/cloud/upgrade/dao/DatabaseAccessObject.java 
> PRE-CREATION 
>   engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java af23b87 
>   engine/schema/test/com/cloud/upgrade/dao/DatabaseAccessObjectTest.java 
> PRE-CREATION 
>   engine/schema/test/com/cloud/upgrade/dao/DbUpgradeUtilsTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18733/diff/
> 
> 
> Testing
> ---
> 
> Ran all unit tests in eclipse.
> Ran "mvn clean install".
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>



Re: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Daan Hoogland
Ah, yes and it is an answer to Mike's initial question indeed. It is
not sufficient for what Miguel describes however.

On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
 wrote:
> Hi all,
>
> I've been looking at the way DB related code (SQL scripts and Java classes) 
> are updated and what is the impact of those updates on a live cloudstack DB.
> By the way, my intention is to support a per-commit DB upgrade of a running 
> system.

On Thu, Mar 6, 2014 at 2:02 PM, Donal Lafferty
 wrote:
> The thread started with a discussion of problems with out of date databases.  
> Mike pulled from master, rebuilt, and found out his testbed's database was 
> out of date and no longer works.
>
> We've tried to find a database solution, but out of databases are caused by 
> more than schema changes.  The data in the tables and other pieces of 
> CloudStack can change after a commit, especially towards the end of release 
> when everyone's feature is being merged.
>
> With 4.2, I dealt with this issue by writing a script that rebuilt my testbed 
> by replaying the API calls I made to set it up in the first place.
>
> Is this a solution you've considered for your dev environment?
>
> DL
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: 06 March 2014 12:50
>> To: dev
>> Cc: Daan Hoogland
>> Subject: Re: [DISCUSS] Checking in code that will break others' environments
>>
>> No, but how do you mean with respect to this thread?
>>
>> On Thu, Mar 6, 2014 at 1:48 PM, Donal Lafferty 
>> wrote:
>> > Hi Daan,
>> >
>> > Is there anything stopping you from scripting the configuration of
>> > your CloudStack testbed?  E.g. with Marvin or CloudMonkey
>> >
>> > DL
>> >
>> >> -Original Message-
>> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> >> Sent: 06 March 2014 09:53
>> >> To: dev
>> >> Cc: Daan Hoogland
>> >> Subject: Re: [DISCUSS] Checking in code that will break others'
>> >> environments
>> >>
>> >> I totally agree with the incremental approach. I am a fascist at time
>> >> because i would even want people to add downgrade scripts to any db
>> >> change they make. Having them not adjust their sql is a good first step,
>> though.
>> >>
>> >> On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
>> >>  wrote:
>> >> > Hi all,
>> >> >
>> >> > I've been looking at the way DB related code (SQL scripts and Java
>> >> > classes)
>> >> are updated and what is the impact of those updates on a live cloudstack
>> DB.
>> >> > By the way, my intention is to support a per-commit DB upgrade of a
>> >> running system.
>> >> >
>> >> > Anyway, I completely agree that sending an email warning people
>> >> > about
>> >> changes that can potentially break running environments is a good
>> >> thing, and can save a lot of time and headaches.
>> >> > I also like the idea of Rajani of using tools to help in the DB
>> >> > migration
>> >> process.
>> >> > However, I would like to put forward another idea: what about
>> >> > making sure
>> >> that the changes to the DB (schema and data) are always incremental?
>> >> >
>> >> > I mean, once a SQL statement (say A) is added to a script it could
>> >> > be kept as
>> >> is, and subsequent modifications cloud be made via new statements
>> >> (say B), instead of adapting A.
>> >> > This would allow people to upgrade their databases to the point
>> >> > they ran
>> >> statement A, and afterwards upgrade it again to the point they ran
>> >> statement B.
>> >> > The same principle could also be applied to the Java classes that
>> >> > do data
>> >> migration, but maybe there it might be a bit more involved.
>> >> >
>> >> > Cheers,
>> >> > Miguel
>> >> >
>> >> > -Original Message-
>> >> > From: Koushik Das [mailto:koushik@citrix.com]
>> >> > Sent: donderdag 6 maart 2014 8:25
>> >> > To: 
>> >> > Subject: Re: [DISCUSS] Checking in code that will break others'
>> >> > environments
>> >> >
>> >> > Before doing a git pull, I generally check the sql schema changes
>> >> > and run
>> >> the delta manually on my existing setup. In most of the cases that
>> >> works for me without having to redeploy the db.
>> >> >
>> >> > -Koushik
>> >> >
>> >> > On 06-Mar-2014, at 11:43 AM, Mike Tutkowski
>> >>  wrote:
>> >> >
>> >> >> Yeah, I definitely just meant a "heads up" during development if
>> >> >> you are going to change something that will break other people's
>> >> >> environments who update. If these people know in advance, they may
>> >> >> choose to postpone an update until they are at a better point.
>> >> >>
>> >> >>
>> >> >> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi
>> >> >> > >> >>> wrote:
>> >> >>
>> >> >>> Across versions db migration is taken care. I think this is bound
>> >> >>> to occur while working on a release, if multiple people work on
>> >> >>> the same branch with different work-in-progress features.
>> >> >>>
>> >> >>> Could we move to flyway or liquibase which can take care of db
>> >> >>> versioning and migration?
>> >> >>>
>>

Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-03-06 Thread Daan Hoogland
Not very much, unless i am missing something. The redundancy can not
be enabled on a per network basis as the router needs to be in the air
twice anyway. I would not like to save data that has no use. What CRUD
are you thinking of? Or are you maybe putting some effort into keeping
VPC and standalone networks alligned?

On Thu, Mar 6, 2014 at 1:13 PM, Karl Harris  wrote:
> Redundancy will be on a vpc basis. I'm attempting to add  CRUD functionality
> on a network basis. Does this make sense?
>
> On Thursday, March 6, 2014, daan Hoogland  wrote:
>>
>>
>> ---
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/18795/#review36352
>> ---
>>
>>
>>
>> Are you contemplating redundant routing on a per network basis? It would
>> seem to me that the router, hence the whole vpc with all it networks is
>> redundant or not.
>>
>> - daan Hoogland
>>
>>
>> On March 5, 2014, 8:20 p.m., Karl Harris wrote:
>> >
>> > ---
>>
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/18795/
>> > ---
>> >
>> > (Updated March 5, 2014, 8:20 p.m.)
>>
>> >
>> >
>> > Review request for cloudstack.
>> >
>> >
>> > Repository: cloudstack-git
>> >
>> >
>> > Description
>> > ---
>> >
>> > Changes/additions to BASH scripts and .java files as well as pseudo code
>> > comments. This posting is a sanity check review posting; before I get too
>> > far along with making the changes required for this JIRA CloudStack-764
>> > nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd publish my
>> > intentions to the community to review and comment.
>> >
>> >
>> > Diffs
>> > -
>> >
>> >   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java
>> > 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1
>> >
>> > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>> > 03af0da51b1eec93eb878fd1ebeca2ff2e0802ce
>> >
>> > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>> > 69b7c9e07c753c0f0c93197a809acfb3399cf555
>> >   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh
>> > e5da2e096b30f6fdb15226e889517537d04f2e3e
>> >
>> > Diff: https://reviews.apache.org/r/18795/diff/
>> >
>> >
>> > Testing
>> > ---
>> >
>> > None, yet still coding
>> >
>> >
>> > Thanks,
>> >
>> > Karl Harris
>> >
>> >
>>
>
>
> --
> Karl O. Harris
> Cloud Software Engineer
> Sungard Availability Services
>
>



-- 
Daan


RE: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Donal Lafferty
The thread started with a discussion of problems with out of date databases.  
Mike pulled from master, rebuilt, and found out his testbed's database was out 
of date and no longer works.

We've tried to find a database solution, but out of databases are caused by 
more than schema changes.  The data in the tables and other pieces of 
CloudStack can change after a commit, especially towards the end of release 
when everyone's feature is being merged.

With 4.2, I dealt with this issue by writing a script that rebuilt my testbed 
by replaying the API calls I made to set it up in the first place.

Is this a solution you've considered for your dev environment? 

DL
 
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: 06 March 2014 12:50
> To: dev
> Cc: Daan Hoogland
> Subject: Re: [DISCUSS] Checking in code that will break others' environments
> 
> No, but how do you mean with respect to this thread?
> 
> On Thu, Mar 6, 2014 at 1:48 PM, Donal Lafferty 
> wrote:
> > Hi Daan,
> >
> > Is there anything stopping you from scripting the configuration of
> > your CloudStack testbed?  E.g. with Marvin or CloudMonkey
> >
> > DL
> >
> >> -Original Message-
> >> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> >> Sent: 06 March 2014 09:53
> >> To: dev
> >> Cc: Daan Hoogland
> >> Subject: Re: [DISCUSS] Checking in code that will break others'
> >> environments
> >>
> >> I totally agree with the incremental approach. I am a fascist at time
> >> because i would even want people to add downgrade scripts to any db
> >> change they make. Having them not adjust their sql is a good first step,
> though.
> >>
> >> On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
> >>  wrote:
> >> > Hi all,
> >> >
> >> > I've been looking at the way DB related code (SQL scripts and Java
> >> > classes)
> >> are updated and what is the impact of those updates on a live cloudstack
> DB.
> >> > By the way, my intention is to support a per-commit DB upgrade of a
> >> running system.
> >> >
> >> > Anyway, I completely agree that sending an email warning people
> >> > about
> >> changes that can potentially break running environments is a good
> >> thing, and can save a lot of time and headaches.
> >> > I also like the idea of Rajani of using tools to help in the DB
> >> > migration
> >> process.
> >> > However, I would like to put forward another idea: what about
> >> > making sure
> >> that the changes to the DB (schema and data) are always incremental?
> >> >
> >> > I mean, once a SQL statement (say A) is added to a script it could
> >> > be kept as
> >> is, and subsequent modifications cloud be made via new statements
> >> (say B), instead of adapting A.
> >> > This would allow people to upgrade their databases to the point
> >> > they ran
> >> statement A, and afterwards upgrade it again to the point they ran
> >> statement B.
> >> > The same principle could also be applied to the Java classes that
> >> > do data
> >> migration, but maybe there it might be a bit more involved.
> >> >
> >> > Cheers,
> >> > Miguel
> >> >
> >> > -Original Message-
> >> > From: Koushik Das [mailto:koushik@citrix.com]
> >> > Sent: donderdag 6 maart 2014 8:25
> >> > To: 
> >> > Subject: Re: [DISCUSS] Checking in code that will break others'
> >> > environments
> >> >
> >> > Before doing a git pull, I generally check the sql schema changes
> >> > and run
> >> the delta manually on my existing setup. In most of the cases that
> >> works for me without having to redeploy the db.
> >> >
> >> > -Koushik
> >> >
> >> > On 06-Mar-2014, at 11:43 AM, Mike Tutkowski
> >>  wrote:
> >> >
> >> >> Yeah, I definitely just meant a "heads up" during development if
> >> >> you are going to change something that will break other people's
> >> >> environments who update. If these people know in advance, they may
> >> >> choose to postpone an update until they are at a better point.
> >> >>
> >> >>
> >> >> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi
> >> >>  >> >>> wrote:
> >> >>
> >> >>> Across versions db migration is taken care. I think this is bound
> >> >>> to occur while working on a release, if multiple people work on
> >> >>> the same branch with different work-in-progress features.
> >> >>>
> >> >>> Could we move to flyway or liquibase which can take care of db
> >> >>> versioning and migration?
> >> >>>
> >> >>>
> >> >>> ~Rajani
> >> >>>
> >> >>>
> >> >>>
> >> >>> On 06-Mar-2014, at 2:08 am, Mike Tutkowski
> >> >>> 
> >> >>> wrote:
> >> >>>
> >>  Yeah, in this case, I'm not referring to erroneous code that
> >>  breaks a person's environment (since hopefully the person
> >>  wouldn't have knowingly checked in such code), but rather, say,
> >>  DB-type changes that improve the system, but break current
> setups.
> >> 
> >>  Just a heads-up e-mail with some easily identifiable tag.
> >> 
> >>  Can anyone think of a good tag for this? It's not always DB
> >>  related, so
> >> >>

Re: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Daan Hoogland
No, but how do you mean with respect to this thread?

On Thu, Mar 6, 2014 at 1:48 PM, Donal Lafferty
 wrote:
> Hi Daan,
>
> Is there anything stopping you from scripting the configuration of your 
> CloudStack testbed?  E.g. with Marvin or CloudMonkey
>
> DL
>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: 06 March 2014 09:53
>> To: dev
>> Cc: Daan Hoogland
>> Subject: Re: [DISCUSS] Checking in code that will break others' environments
>>
>> I totally agree with the incremental approach. I am a fascist at time 
>> because i
>> would even want people to add downgrade scripts to any db change they
>> make. Having them not adjust their sql is a good first step, though.
>>
>> On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
>>  wrote:
>> > Hi all,
>> >
>> > I've been looking at the way DB related code (SQL scripts and Java classes)
>> are updated and what is the impact of those updates on a live cloudstack DB.
>> > By the way, my intention is to support a per-commit DB upgrade of a
>> running system.
>> >
>> > Anyway, I completely agree that sending an email warning people about
>> changes that can potentially break running environments is a good thing, and
>> can save a lot of time and headaches.
>> > I also like the idea of Rajani of using tools to help in the DB migration
>> process.
>> > However, I would like to put forward another idea: what about making sure
>> that the changes to the DB (schema and data) are always incremental?
>> >
>> > I mean, once a SQL statement (say A) is added to a script it could be kept 
>> > as
>> is, and subsequent modifications cloud be made via new statements (say B),
>> instead of adapting A.
>> > This would allow people to upgrade their databases to the point they ran
>> statement A, and afterwards upgrade it again to the point they ran
>> statement B.
>> > The same principle could also be applied to the Java classes that do data
>> migration, but maybe there it might be a bit more involved.
>> >
>> > Cheers,
>> > Miguel
>> >
>> > -Original Message-
>> > From: Koushik Das [mailto:koushik@citrix.com]
>> > Sent: donderdag 6 maart 2014 8:25
>> > To: 
>> > Subject: Re: [DISCUSS] Checking in code that will break others'
>> > environments
>> >
>> > Before doing a git pull, I generally check the sql schema changes and run
>> the delta manually on my existing setup. In most of the cases that works for
>> me without having to redeploy the db.
>> >
>> > -Koushik
>> >
>> > On 06-Mar-2014, at 11:43 AM, Mike Tutkowski
>>  wrote:
>> >
>> >> Yeah, I definitely just meant a "heads up" during development if you
>> >> are going to change something that will break other people's
>> >> environments who update. If these people know in advance, they may
>> >> choose to postpone an update until they are at a better point.
>> >>
>> >>
>> >> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi
>> >> > >>> wrote:
>> >>
>> >>> Across versions db migration is taken care. I think this is bound to
>> >>> occur while working on a release, if multiple people work on the
>> >>> same branch with different work-in-progress features.
>> >>>
>> >>> Could we move to flyway or liquibase which can take care of db
>> >>> versioning and migration?
>> >>>
>> >>>
>> >>> ~Rajani
>> >>>
>> >>>
>> >>>
>> >>> On 06-Mar-2014, at 2:08 am, Mike Tutkowski
>> >>> 
>> >>> wrote:
>> >>>
>>  Yeah, in this case, I'm not referring to erroneous code that breaks
>>  a person's environment (since hopefully the person wouldn't have
>>  knowingly checked in such code), but rather, say, DB-type changes
>>  that improve the system, but break current setups.
>> 
>>  Just a heads-up e-mail with some easily identifiable tag.
>> 
>>  Can anyone think of a good tag for this? It's not always DB
>>  related, so
>> >>> we
>>  might want the tag to be more general.
>> 
>> 
>>  On Wed, Mar 5, 2014 at 1:28 PM, Ian Duffy  wrote:
>> 
>> > +1 to this.
>> >
>> > Having the build suddenly break due to a git pull has been very
>> >>> annoying!
>> > I usually end up searching through the commit log and doing a
>> > resets until I find a commit where it works. Then waiting awhile
>> > until I do a git pull again and hoping the code was fixed.
>> >
>> > On 5 March 2014 20:19, Mike Tutkowski
>> > 
>> > wrote:
>> >> Hi,
>> >>
>> >> I encountered a bit of a problem this morning and thought I would
>> >> bring
>> > it
>> >> up for discussion.
>> >>
>> >> If we already have a policy around this, please let me know.
>> >>
>> >> So, I fetched the latest and rebased my local 4.4 development
>> >> branch on
>> > top
>> >> of master. This all went just fine.
>> >>
>> >> When I rebuilt and re-started the CS Management Server, I soon
>> >>> realized I
>> >> could no longer log in from the GUI.
>> >>
>> >> As it turns out, the DB schema had been upd

RE: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Donal Lafferty
Hi Daan,

Is there anything stopping you from scripting the configuration of your 
CloudStack testbed?  E.g. with Marvin or CloudMonkey

DL

> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: 06 March 2014 09:53
> To: dev
> Cc: Daan Hoogland
> Subject: Re: [DISCUSS] Checking in code that will break others' environments
> 
> I totally agree with the incremental approach. I am a fascist at time because 
> i
> would even want people to add downgrade scripts to any db change they
> make. Having them not adjust their sql is a good first step, though.
> 
> On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
>  wrote:
> > Hi all,
> >
> > I've been looking at the way DB related code (SQL scripts and Java classes)
> are updated and what is the impact of those updates on a live cloudstack DB.
> > By the way, my intention is to support a per-commit DB upgrade of a
> running system.
> >
> > Anyway, I completely agree that sending an email warning people about
> changes that can potentially break running environments is a good thing, and
> can save a lot of time and headaches.
> > I also like the idea of Rajani of using tools to help in the DB migration
> process.
> > However, I would like to put forward another idea: what about making sure
> that the changes to the DB (schema and data) are always incremental?
> >
> > I mean, once a SQL statement (say A) is added to a script it could be kept 
> > as
> is, and subsequent modifications cloud be made via new statements (say B),
> instead of adapting A.
> > This would allow people to upgrade their databases to the point they ran
> statement A, and afterwards upgrade it again to the point they ran
> statement B.
> > The same principle could also be applied to the Java classes that do data
> migration, but maybe there it might be a bit more involved.
> >
> > Cheers,
> > Miguel
> >
> > -Original Message-
> > From: Koushik Das [mailto:koushik@citrix.com]
> > Sent: donderdag 6 maart 2014 8:25
> > To: 
> > Subject: Re: [DISCUSS] Checking in code that will break others'
> > environments
> >
> > Before doing a git pull, I generally check the sql schema changes and run
> the delta manually on my existing setup. In most of the cases that works for
> me without having to redeploy the db.
> >
> > -Koushik
> >
> > On 06-Mar-2014, at 11:43 AM, Mike Tutkowski
>  wrote:
> >
> >> Yeah, I definitely just meant a "heads up" during development if you
> >> are going to change something that will break other people's
> >> environments who update. If these people know in advance, they may
> >> choose to postpone an update until they are at a better point.
> >>
> >>
> >> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi
> >>  >>> wrote:
> >>
> >>> Across versions db migration is taken care. I think this is bound to
> >>> occur while working on a release, if multiple people work on the
> >>> same branch with different work-in-progress features.
> >>>
> >>> Could we move to flyway or liquibase which can take care of db
> >>> versioning and migration?
> >>>
> >>>
> >>> ~Rajani
> >>>
> >>>
> >>>
> >>> On 06-Mar-2014, at 2:08 am, Mike Tutkowski
> >>> 
> >>> wrote:
> >>>
>  Yeah, in this case, I'm not referring to erroneous code that breaks
>  a person's environment (since hopefully the person wouldn't have
>  knowingly checked in such code), but rather, say, DB-type changes
>  that improve the system, but break current setups.
> 
>  Just a heads-up e-mail with some easily identifiable tag.
> 
>  Can anyone think of a good tag for this? It's not always DB
>  related, so
> >>> we
>  might want the tag to be more general.
> 
> 
>  On Wed, Mar 5, 2014 at 1:28 PM, Ian Duffy  wrote:
> 
> > +1 to this.
> >
> > Having the build suddenly break due to a git pull has been very
> >>> annoying!
> > I usually end up searching through the commit log and doing a
> > resets until I find a commit where it works. Then waiting awhile
> > until I do a git pull again and hoping the code was fixed.
> >
> > On 5 March 2014 20:19, Mike Tutkowski
> > 
> > wrote:
> >> Hi,
> >>
> >> I encountered a bit of a problem this morning and thought I would
> >> bring
> > it
> >> up for discussion.
> >>
> >> If we already have a policy around this, please let me know.
> >>
> >> So, I fetched the latest and rebased my local 4.4 development
> >> branch on
> > top
> >> of master. This all went just fine.
> >>
> >> When I rebuilt and re-started the CS Management Server, I soon
> >>> realized I
> >> could no longer log in from the GUI.
> >>
> >> As it turns out, the DB schema had been updated and so my
> >> database was
> > out
> >> of date. The code was querying for fields that didn't exist in my DB.
> >>
> >> As far as I know, the easiest way to get around this is to
> >> destroy my current cloud, run the

com.vmware.vim25 Dependency Issue?

2014-03-06 Thread Alex Hitchins
I've just downloaded and run the install-non-oss.sh script however I'm getting 
lots of errors like the below.

java: cannot find symbol
  symbol:   class InvalidCollectorVersionFaultMsg
  location: package com.vmware.vim25

import com.vmware.vim25.InvalidCollectorVersionFaultMsg;
^-Unused Import Statement

I did notice in the install-non-oss.sh file it handles the follwing .jars

   cloud-iControl.jar
   cloud-netscaler-sdx.jar
   manageontap.jar (renamed from cloud-manageontap.jar)
   vim25_51.jar (renamed from vmware-vim25.jar)

Are the .jars below included in the above somehow? I can't see where these are 
called in the install-non-oss.sh script however they sit in the deps folder.

   apputils.jar (renamed from vmware-apputils.jar)
   vim.jar (renamed from vmware-vim.jar)

Are these missing ones causing the errors above?


Regards,

Alex Hitchins

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Alex Hitchins
Thanks, I'll make the amendment to the wiki.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Rajesh Battala [mailto:rajesh.batt...@citrix.com]
Sent: 06 March 2014 12:07
To: dev@cloudstack.apache.org
Subject: RE: NonOSS Dependencies - Citrix

AFAIK, those jars are updated ones.

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com]
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-03-06 Thread Karl Harris
Redundancy will be on a vpc basis. I'm attempting to add  CRUD
functionality on a network basis. Does this make sense?

On Thursday, March 6, 2014, daan Hoogland  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18795/#review36352
> ---
>
>
> Are you contemplating redundant routing on a per network basis? It would
> seem to me that the router, hence the whole vpc with all it networks is
> redundant or not.
>
> - daan Hoogland
>
>
> On March 5, 2014, 8:20 p.m., Karl Harris wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/18795/
> > ---
> >
> > (Updated March 5, 2014, 8:20 p.m.)
> >
> >
> > Review request for cloudstack.
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > ---
> >
> > Changes/additions to BASH scripts and .java files as well as pseudo code
> comments. This posting is a sanity check review posting; before I get too
> far along with making the changes required for this JIRA CloudStack-764
> nTier Apps 2.0 : Redundant Virtual Router for VPC I thought I'd publish my
> intentions to the community to review and comment.
> >
> >
> > Diffs
> > -
> >
> >   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java
> 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1
> >
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> 03af0da51b1eec93eb878fd1ebeca2ff2e0802ce
> >
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
> 69b7c9e07c753c0f0c93197a809acfb3399cf555
> >   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh
> e5da2e096b30f6fdb15226e889517537d04f2e3e
> >
> > Diff: https://reviews.apache.org/r/18795/diff/
> >
> >
> > Testing
> > ---
> >
> > None, yet still coding
> >
> >
> > Thanks,
> >
> > Karl Harris
> >
> >
>
>

-- 
Karl O. Harris
Cloud Software Engineer
Sungard Availability Services


RE: NonOSS Dependencies - Citrix

2014-03-06 Thread Rajesh Battala
AFAIK, those jars are updated ones. 

-Original Message-
From: Alex Hitchins [mailto:alex.hitch...@shapeblue.com] 
Sent: Thursday, March 6, 2014 5:26 PM
To: dev@cloudstack.apache.org
Subject: NonOSS Dependencies - Citrix

All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


NonOSS Dependencies - Citrix

2014-03-06 Thread Alex Hitchins
All, I've been following the guides here[0] to get the third party dependencies 
downloaded. The only one causing an issue is the Citrix one[1]. I Googled and 
found a file of the same name over with Wido[2] where other dependencies are 
located[3]. If this is OK to use, I shall update the Wiki to point to this 
location as the current link to Citirx just redirects to a generic Citrix 
landing page of little use. Wido/Others - is this jar.zip still in date?

[0] 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/How+to+build+CloudStack
[1] 
http://community.citrix.com/download/attachments/37847122/cloud-netscaler-jars.zip
[2] http://zooi.widodh.nl/cloudstack/build-dep/
[3] http://zooi.widodh.nl/cloudstack/build-dep/


Regards,

Alex Hitchins
VP Software Engineering

D: +44 1892 523 587 | S: +44 20 3603 0540 | M: 
+44 7788 423 969

ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N 4HS

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Alex Hitchins
Thanks for the clarification Daan.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: 06 March 2014 10:54
To: dev
Subject: Re: [DISCUSS] Checking in code that will break others' environments

On Thu, Mar 6, 2014 at 11:28 AM, Alex Hitchins  
wrote:
> I agree too with this approach. One thing I'm not too familiar with is how 
> the current SQL versioning handled? I know of the schema-xxtoxx sql files but 
> not so much how this are arranged.
>

H Alex,

The present upgrades are on a per release basis. This means that you can 
upgrade from released versions to other released versions or the present state 
of master. You can never upgrade from master or downgrade or from some other 
random commit-state of the source.

The schema-xxxtoxxx are accompanying Upgradexxxtoxxx.java classes and 
schema-xxxtoxxx-cleanup scripts. The DatabaseUpgradeChecker will find which 
version you are at according to the db and then collect all of those three 
categories between then and the ersion you want to got to.
Next it will first run all the schema-xxxtoxxx, then the Upgradexxxtoxxx code 
for migration and finally the schema-xxxtoxxx-cleanup for throwing away any old 
or temporary tables.
And it will then add entries to the version table to indicate what just 
happened.
I'm not sure at what stage but this is not a single transaction anyway (the 
cleanups  are a separate single transaction) so when it fails midways, you are 
up for a restore and -try.

regards,
--
Daan
Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure 
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1 training
18th-19th February 2014, Brazil. 
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue is a registered trademark.


RE: [DISCUSS] realhostip.com going away

2014-03-06 Thread Paul Angus
Hmm, that's not so good.

Regards

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
paul.an...@shapeblue.com

-Original Message-
From: John Kinsella [mailto:j...@stratosec.co]
Sent: 05 March 2014 18:47
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] realhostip.com going away

It’s not.

On Mar 5, 2014, at 1:48 AM, Erik Weber 
mailto:terbol...@gmail.com>> wrote:

How is security being handled in HTTP mode?


--
Erik


On Wed, Mar 5, 2014 at 2:43 AM, Amogh Vasekar 
mailto:amogh.vase...@citrix.com>>wrote:

Hello,

I have created a review request at : https://reviews.apache.org/r/18759/
that partially address the issue. It has a link to the wiki describing the 
changes in detail.

Thanks,
Amogh

On 3/3/14 8:58 AM, "John Kinsella" 
mailto:j...@stratosec.co>> wrote:

I talked with some of the Citrix folk over the weekendŠtheir position is they 
think they¹d be doing the community a disfavor by passing the torch, 
so-to-speak, and I agree with them [1].

>From what I understand, the patches that are going to be proposed will remove 
>HTTPS completely and encrypt over http. That said, I haven¹t seen anything 
>yet, so until we see something we¹re guessing. I¹m waiting a few more days to 
>see what¹s proposed.

John
1: I¹m sharing conversations with individuals, so take this as hearsay not 
official comment from Citrix.

On Mar 2, 2014, at 8:15 AM, Paul Angus
mailto:paul.an...@shapeblue.com>>
 wrote:

There are a few issues with the current console proxy setup, not least of which 
is the need to have internet access to resolve 
realhostip.com in the first place 
- so console proxy can't work if you don't have internet access on your client. 
 I have configured alternative 
realhostip.com setups for clients 
- and quite a lot of work goes into creating the infrastructure (and certs) to 
support changing to a user managed certificate.

Sooo, is it at all possible to secure communications with the console proxy, 
without having to rely on ANY outside entity?

Testing alone is going to be a pain, if a full ssl cert setup is required to 
use console proxy..

Regards

Paul Angus
Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus 
paul.an...@shapeblue.com

-Original Message-
From: Amogh Vasekar [mailto:amogh.vase...@citrix.com]
Sent: 28 February 2014 23:05
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] realhostip.com going away



On 2/28/14 2:03 PM, "Nux!" mailto:n...@li.nux.ro>> wrote:

There's also the problem of the certificate. It comes bundled in ACS as far as 
I can tell.. When does it expire?

notBefore=Feb  3 03:30:40 2012 GMT
notAfter=Feb  7 05:11:23 2017 GMT

Need Enterprise Grade Support for Apache CloudStack?
Our CloudStack Infrastructure
Support offers the 
best 24/7 SLA for CloudStack Environments.

Apache CloudStack Bootcamp training courses

**NEW!** CloudStack 4.2.1
training
18th-19th February 2014, Brazil.
Classroom
17th-23rd March 2014, Region A. Instructor led, 
On-line
24th-28th March 2014, Region B. Instructor led, 
On-line
16th-20th June 2014, Region A. Instructor led, 
On-line
23rd-27th June 2014, Region B. Instructor led, 
On-line

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.
Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue is a 
registered trademark.

Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella




Stratosec - Compliance as a Service
o: 415.315.9385
@johnlkinsella

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions

Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Wido den Hollander



On 03/06/2014 11:48 AM, Wei ZHOU wrote:

awesome!

Can you implement cpu tuning or network QoS as well ? Thanks!



Yes, I was planning on adding multiple methods at once with a couple of 
patches.



-Wei


2014-03-06 11:42 GMT+01:00 Wido den Hollander :




On 03/05/2014 07:18 PM, Marcus wrote:


For the hypervisor version of throttling, we just need
ResizeVolumeCommand to pass the VolumeObjectTO rather than just the
volume uuid/path, so that when we change offerings on the agent side
we have the info we need to update libvirt with the new iops/bytes
settings. We also need the libvirt java bindings to do so, per
previous discussion.



I'm already working on the patch: https://github.com/wido/
libvirt-java/tree/change-iops

It's not so hard to implement it seems. Hopefully I'll have it ready after
the weekend.


  On Wed, Mar 5, 2014 at 11:12 AM, Marcus  wrote:



Wouldn't this be implemented as just changing disk offerings? The
resizeVolume API call already allows you to switch disk offerings, we
just need to add a hook in there to optionally call the storage driver
(If volume is deployed to a primary storage) to make an update to the
iops properties on the backend storage. Come to think of it, depending
on how storage drivers are implementing the iops/limits feature,
resizeVolume might be breaking this, or simply requiring a reboot to
apply. That is, if the storage driver is setting the iops just once
upon volume creation, it's probably breaking when a user moves a disk
between offerings that may have alternate iops limits (this is
probably not the case for hypervisor throttling, as that's applied
from whatever is current when the VM starts up).

On Wed, Mar 5, 2014 at 9:58 AM, Mike Tutkowski
 wrote:


Hi,

Perhaps I'm not following this correctly, but I'm a bit lost on why we
are
talking about changing settings on running VMs.

  From what I understand, you are a representative of a storage vendor
that
has a rate-limiting feature. You want to be able to not only set the Max
IOPS, but also adjust them. Is this true?

If so, I totally agree. SolidFire has control over Min and Max IOPS and
it
is on my to-do list to add support into CloudStack to be able to
dynamically change these values (right now customers do this from the
SolidFire API or its GUI).

If you would like to work on this feature, that would be great. I'd be
happy to review your design and code.

One complication is that we are looking at adding support for generic
key/value pairs for storage plug-ins in 4.5 and this would effectively
remove the need to have Min and Max IOPS as "special" fields in the
CloudStack API and GUI.

I'm going to CC Chris Suichll (from NetApp) as he and I have already
discussed this generic-properties concept. It would be good to get his
feedback on how we might go about dynamically updating storage-plug-in
key/value pairs.

Thanks!
Mike


On Wed, Mar 5, 2014 at 3:12 AM, Wido den Hollander 
wrote:




On 03/05/2014 10:12 AM, Wei ZHOU wrote:

  I was thinking about it last week.

AFAIK, libvirt-java 0.5.1 does not support change setting on running
vms,
but virsh command line and libvirt API supports it.
so the sulution are
(1) change libvirt-java to support it, and make it released in the
next
version. Maybe Wido can help us.



Sure! That seems the best way forward. What is currently lacking in the
libvirt-java bindings?


   (2) call virsh command line.




  Please, please, do not do that. That's very hacky. We should really

keep
using the libvirt-java bindings and stay away from invoking binaries.

Wido


   -Wei



2014-03-05 9:01 GMT+01:00 Punith S :

   hi guys,



we are having a fixed max iops for each volume being attached to the
instance in managed storage,
so this a problem where we are making users to pre allocate the iops
of
the
disk without having an option to change or resize it, similar to the
size
metric.

so i would like to introduce a new feature which enables to change or
resize the volume iops on fly without detaching the datadisk of the
VM
with
zero downtime where performance of the datadisk can be altered at any
point
with the available iops of the primary storage pool, which is
similar in
resizing the volume or datadisk of the vm , where in latter we have
to
detach the datadisk.

what do you guys think about this feature ? any feedback ?

thanks,

--
regards,

punith s
cloudbyte.com







--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*







Re: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Daan Hoogland
On Thu, Mar 6, 2014 at 11:28 AM, Alex Hitchins
 wrote:
> I agree too with this approach. One thing I'm not too familiar with is how 
> the current SQL versioning handled? I know of the schema-xxtoxx sql files but 
> not so much how this are arranged.
>

H Alex,

The present upgrades are on a per release basis. This means that you
can upgrade from released versions to other released versions or the
present state of master. You can never upgrade from master or
downgrade or from some other random commit-state of the source.

The schema-xxxtoxxx are accompanying Upgradexxxtoxxx.java classes and
schema-xxxtoxxx-cleanup scripts. The DatabaseUpgradeChecker will find
which version you are at according to the db and then collect all of
those three categories between then and the ersion you want to got to.
Next it will first run all the schema-xxxtoxxx, then the
Upgradexxxtoxxx code for migration and finally the
schema-xxxtoxxx-cleanup for throwing away any old or temporary tables.
And it will then add entries to the version table to indicate what
just happened.
I'm not sure at what stage but this is not a single transaction anyway
(the cleanups  are a separate single transaction) so when it fails
midways, you are up for a restore and -try.

regards,
-- 
Daan


Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Wei ZHOU
awesome!

Can you implement cpu tuning or network QoS as well ? Thanks!

-Wei


2014-03-06 11:42 GMT+01:00 Wido den Hollander :

>
>
> On 03/05/2014 07:18 PM, Marcus wrote:
>
>> For the hypervisor version of throttling, we just need
>> ResizeVolumeCommand to pass the VolumeObjectTO rather than just the
>> volume uuid/path, so that when we change offerings on the agent side
>> we have the info we need to update libvirt with the new iops/bytes
>> settings. We also need the libvirt java bindings to do so, per
>> previous discussion.
>>
>>
> I'm already working on the patch: https://github.com/wido/
> libvirt-java/tree/change-iops
>
> It's not so hard to implement it seems. Hopefully I'll have it ready after
> the weekend.
>
>
>  On Wed, Mar 5, 2014 at 11:12 AM, Marcus  wrote:
>>
>>> Wouldn't this be implemented as just changing disk offerings? The
>>> resizeVolume API call already allows you to switch disk offerings, we
>>> just need to add a hook in there to optionally call the storage driver
>>> (If volume is deployed to a primary storage) to make an update to the
>>> iops properties on the backend storage. Come to think of it, depending
>>> on how storage drivers are implementing the iops/limits feature,
>>> resizeVolume might be breaking this, or simply requiring a reboot to
>>> apply. That is, if the storage driver is setting the iops just once
>>> upon volume creation, it's probably breaking when a user moves a disk
>>> between offerings that may have alternate iops limits (this is
>>> probably not the case for hypervisor throttling, as that's applied
>>> from whatever is current when the VM starts up).
>>>
>>> On Wed, Mar 5, 2014 at 9:58 AM, Mike Tutkowski
>>>  wrote:
>>>
 Hi,

 Perhaps I'm not following this correctly, but I'm a bit lost on why we
 are
 talking about changing settings on running VMs.

  From what I understand, you are a representative of a storage vendor
 that
 has a rate-limiting feature. You want to be able to not only set the Max
 IOPS, but also adjust them. Is this true?

 If so, I totally agree. SolidFire has control over Min and Max IOPS and
 it
 is on my to-do list to add support into CloudStack to be able to
 dynamically change these values (right now customers do this from the
 SolidFire API or its GUI).

 If you would like to work on this feature, that would be great. I'd be
 happy to review your design and code.

 One complication is that we are looking at adding support for generic
 key/value pairs for storage plug-ins in 4.5 and this would effectively
 remove the need to have Min and Max IOPS as "special" fields in the
 CloudStack API and GUI.

 I'm going to CC Chris Suichll (from NetApp) as he and I have already
 discussed this generic-properties concept. It would be good to get his
 feedback on how we might go about dynamically updating storage-plug-in
 key/value pairs.

 Thanks!
 Mike


 On Wed, Mar 5, 2014 at 3:12 AM, Wido den Hollander 
 wrote:


>
> On 03/05/2014 10:12 AM, Wei ZHOU wrote:
>
>  I was thinking about it last week.
>> AFAIK, libvirt-java 0.5.1 does not support change setting on running
>> vms,
>> but virsh command line and libvirt API supports it.
>> so the sulution are
>> (1) change libvirt-java to support it, and make it released in the
>> next
>> version. Maybe Wido can help us.
>>
>>
> Sure! That seems the best way forward. What is currently lacking in the
> libvirt-java bindings?
>
>
>   (2) call virsh command line.
>
>>
>>
>>  Please, please, do not do that. That's very hacky. We should really
> keep
> using the libvirt-java bindings and stay away from invoking binaries.
>
> Wido
>
>
>   -Wei
>
>>
>> 2014-03-05 9:01 GMT+01:00 Punith S :
>>
>>   hi guys,
>>
>>>
>>> we are having a fixed max iops for each volume being attached to the
>>> instance in managed storage,
>>> so this a problem where we are making users to pre allocate the iops
>>> of
>>> the
>>> disk without having an option to change or resize it, similar to the
>>> size
>>> metric.
>>>
>>> so i would like to introduce a new feature which enables to change or
>>> resize the volume iops on fly without detaching the datadisk of the
>>> VM
>>> with
>>> zero downtime where performance of the datadisk can be altered at any
>>> point
>>> with the available iops of the primary storage pool, which is
>>> similar in
>>> resizing the volume or datadisk of the vm , where in latter we have
>>> to
>>> detach the datadisk.
>>>
>>> what do you guys think about this feature ? any feedback ?
>>>
>>> thanks,
>>>
>>> --
>>> regards,
>>>
>>> punith s
>>> cloudbyte.com
>>>
>>>
>>>
>>

Re: Change Volume IOPS on fly without detaching the disk feature.

2014-03-06 Thread Wido den Hollander



On 03/05/2014 07:18 PM, Marcus wrote:

For the hypervisor version of throttling, we just need
ResizeVolumeCommand to pass the VolumeObjectTO rather than just the
volume uuid/path, so that when we change offerings on the agent side
we have the info we need to update libvirt with the new iops/bytes
settings. We also need the libvirt java bindings to do so, per
previous discussion.



I'm already working on the patch: 
https://github.com/wido/libvirt-java/tree/change-iops


It's not so hard to implement it seems. Hopefully I'll have it ready 
after the weekend.



On Wed, Mar 5, 2014 at 11:12 AM, Marcus  wrote:

Wouldn't this be implemented as just changing disk offerings? The
resizeVolume API call already allows you to switch disk offerings, we
just need to add a hook in there to optionally call the storage driver
(If volume is deployed to a primary storage) to make an update to the
iops properties on the backend storage. Come to think of it, depending
on how storage drivers are implementing the iops/limits feature,
resizeVolume might be breaking this, or simply requiring a reboot to
apply. That is, if the storage driver is setting the iops just once
upon volume creation, it's probably breaking when a user moves a disk
between offerings that may have alternate iops limits (this is
probably not the case for hypervisor throttling, as that's applied
from whatever is current when the VM starts up).

On Wed, Mar 5, 2014 at 9:58 AM, Mike Tutkowski
 wrote:

Hi,

Perhaps I'm not following this correctly, but I'm a bit lost on why we are
talking about changing settings on running VMs.

 From what I understand, you are a representative of a storage vendor that
has a rate-limiting feature. You want to be able to not only set the Max
IOPS, but also adjust them. Is this true?

If so, I totally agree. SolidFire has control over Min and Max IOPS and it
is on my to-do list to add support into CloudStack to be able to
dynamically change these values (right now customers do this from the
SolidFire API or its GUI).

If you would like to work on this feature, that would be great. I'd be
happy to review your design and code.

One complication is that we are looking at adding support for generic
key/value pairs for storage plug-ins in 4.5 and this would effectively
remove the need to have Min and Max IOPS as "special" fields in the
CloudStack API and GUI.

I'm going to CC Chris Suichll (from NetApp) as he and I have already
discussed this generic-properties concept. It would be good to get his
feedback on how we might go about dynamically updating storage-plug-in
key/value pairs.

Thanks!
Mike


On Wed, Mar 5, 2014 at 3:12 AM, Wido den Hollander  wrote:




On 03/05/2014 10:12 AM, Wei ZHOU wrote:


I was thinking about it last week.
AFAIK, libvirt-java 0.5.1 does not support change setting on running vms,
but virsh command line and libvirt API supports it.
so the sulution are
(1) change libvirt-java to support it, and make it released in the next
version. Maybe Wido can help us.



Sure! That seems the best way forward. What is currently lacking in the
libvirt-java bindings?


  (2) call virsh command line.




Please, please, do not do that. That's very hacky. We should really keep
using the libvirt-java bindings and stay away from invoking binaries.

Wido


  -Wei


2014-03-05 9:01 GMT+01:00 Punith S :

  hi guys,


we are having a fixed max iops for each volume being attached to the
instance in managed storage,
so this a problem where we are making users to pre allocate the iops of
the
disk without having an option to change or resize it, similar to the size
metric.

so i would like to introduce a new feature which enables to change or
resize the volume iops on fly without detaching the datadisk of the VM
with
zero downtime where performance of the datadisk can be altered at any
point
with the available iops of the primary storage pool, which is similar in
resizing the volume or datadisk of the vm , where in latter we have to
detach the datadisk.

what do you guys think about this feature ? any feedback ?

thanks,

--
regards,

punith s
cloudbyte.com







--
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the
cloud
*(tm)*


RE: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Alex Hitchins
I agree too with this approach. One thing I'm not too familiar with is how the 
current SQL versioning handled? I know of the schema-xxtoxx sql files but not 
so much how this are arranged.


Regards

Alex Hitchins

D: +44 1892 523 587 | S: +44 2036 030 540 | M: +44 7788 423 969

alex.hitch...@shapeblue.com

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
Sent: 06 March 2014 09:53
To: dev
Cc: Daan Hoogland
Subject: Re: [DISCUSS] Checking in code that will break others' environments

I totally agree with the incremental approach. I am a fascist at time because i 
would even want people to add downgrade scripts to any db change they make. 
Having them not adjust their sql is a good first step, though.

On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira  
wrote:
> Hi all,
>
> I've been looking at the way DB related code (SQL scripts and Java classes) 
> are updated and what is the impact of those updates on a live cloudstack DB.
> By the way, my intention is to support a per-commit DB upgrade of a running 
> system.
>
> Anyway, I completely agree that sending an email warning people about changes 
> that can potentially break running environments is a good thing, and can save 
> a lot of time and headaches.
> I also like the idea of Rajani of using tools to help in the DB migration 
> process.
> However, I would like to put forward another idea: what about making sure 
> that the changes to the DB (schema and data) are always incremental?
>
> I mean, once a SQL statement (say A) is added to a script it could be kept as 
> is, and subsequent modifications cloud be made via new statements (say B), 
> instead of adapting A.
> This would allow people to upgrade their databases to the point they ran 
> statement A, and afterwards upgrade it again to the point they ran statement 
> B.
> The same principle could also be applied to the Java classes that do data 
> migration, but maybe there it might be a bit more involved.
>
> Cheers,
> Miguel
>
> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: donderdag 6 maart 2014 8:25
> To: 
> Subject: Re: [DISCUSS] Checking in code that will break others'
> environments
>
> Before doing a git pull, I generally check the sql schema changes and run the 
> delta manually on my existing setup. In most of the cases that works for me 
> without having to redeploy the db.
>
> -Koushik
>
> On 06-Mar-2014, at 11:43 AM, Mike Tutkowski  
> wrote:
>
>> Yeah, I definitely just meant a "heads up" during development if you
>> are going to change something that will break other people's
>> environments who update. If these people know in advance, they may
>> choose to postpone an update until they are at a better point.
>>
>>
>> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi
>> >> wrote:
>>
>>> Across versions db migration is taken care. I think this is bound to
>>> occur while working on a release, if multiple people work on the
>>> same branch with different work-in-progress features.
>>>
>>> Could we move to flyway or liquibase which can take care of db
>>> versioning and migration?
>>>
>>>
>>> ~Rajani
>>>
>>>
>>>
>>> On 06-Mar-2014, at 2:08 am, Mike Tutkowski
>>> 
>>> wrote:
>>>
 Yeah, in this case, I'm not referring to erroneous code that breaks
 a person's environment (since hopefully the person wouldn't have
 knowingly checked in such code), but rather, say, DB-type changes
 that improve the system, but break current setups.

 Just a heads-up e-mail with some easily identifiable tag.

 Can anyone think of a good tag for this? It's not always DB
 related, so
>>> we
 might want the tag to be more general.


 On Wed, Mar 5, 2014 at 1:28 PM, Ian Duffy  wrote:

> +1 to this.
>
> Having the build suddenly break due to a git pull has been very
>>> annoying!
> I usually end up searching through the commit log and doing a
> resets until I find a commit where it works. Then waiting awhile
> until I do a git pull again and hoping the code was fixed.
>
> On 5 March 2014 20:19, Mike Tutkowski
> 
> wrote:
>> Hi,
>>
>> I encountered a bit of a problem this morning and thought I would
>> bring
> it
>> up for discussion.
>>
>> If we already have a policy around this, please let me know.
>>
>> So, I fetched the latest and rebased my local 4.4 development
>> branch on
> top
>> of master. This all went just fine.
>>
>> When I rebuilt and re-started the CS Management Server, I soon
>>> realized I
>> could no longer log in from the GUI.
>>
>> As it turns out, the DB schema had been updated and so my
>> database was
> out
>> of date. The code was querying for fields that didn't exist in my DB.
>>
>> As far as I know, the easiest way to get around this is to
>> destroy my current cloud, run the script to re-build my database,
>> then re-create
>>> m

Re: Review Request 17790: Domain-Account-User Sync Up Among Multiple Regions

2014-03-06 Thread Daan Hoogland
master, before the 14th. If we get it in in time we will have to make
fixes on both 4.4-forward and master.

On Wed, Mar 5, 2014 at 10:33 PM, Alex Ough  wrote:
> What branch needs to be based to create a review request of this
> implementation that will be included in 4.4 release?
> 4.3 or 4.3-forward?
>
> Thanks
> Alex Ough
>
>
> On Tue, Mar 4, 2014 at 1:25 PM, Alex Ough  wrote:
>>
>> Yes, by 3/7.
>>
>> Thanks
>> Alex Ough
>>
>>
>> On Tue, Mar 4, 2014 at 12:30 PM, Daan Hoogland 
>> wrote:
>>>
>>> This week? should be ok. end of next week is too late!
>>>
>>> On Tue, Mar 4, 2014 at 6:17 PM, Alex Ough  wrote:
>>> > Do you think it is ok to wrap up the implementation until the end of
>>> > this
>>> > week to make this included in 4.4 release?
>>> >
>>> > Thanks
>>> > Alex Ough
>>> >
>>> >
>>> > On Sun, Mar 2, 2014 at 2:10 PM, Daan Hoogland 
>>> > wrote:
>>> >>
>>> >> two weeks from now, but under debate. Let's go with that, though.
>>> >>
>>> >> On Sun, Mar 2, 2014 at 1:17 AM, Alex Ough 
>>> >> wrote:
>>> >> > Can you tell me when the deadline for 4.4 is?
>>> >> >
>>> >> > Thanks
>>> >> > Alex Ough
>>> >> >
>>> >> >
>>> >> > On Sat, Mar 1, 2014 at 2:26 PM, Daan Hoogland
>>> >> > 
>>> >> > wrote:
>>> >> >>
>>> >> >> Ha Alex,
>>> >> >>
>>> >> >> branch 4.3 is going to be a problem. We will be able to release
>>> >> >> this
>>> >> >> with 4.4 if we hurry.
>>> >> >>
>>> >> >> On Fri, Feb 28, 2014 at 4:01 PM, Alex Ough 
>>> >> >> wrote:
>>> >> >> > Hi Daan,
>>> >> >> >
>>> >> >> > 1. Yes, we'll update the request once all the unit tests are
>>> >> >> > completed.
>>> >> >> > 2. And yes, it is a branch from 4.3
>>> >> >> > 3. I'm using the global parameter, called
>>> >> >> > 'region.auto.generation.interval'
>>> >> >> > and the value is 0 (millisec) by default.
>>> >> >> > If you set the value more than 0, it will automatically
>>> >> >> > create/update/remove domains/accounts/users with that interval,
>>> >> >> > which will trigger the scheduled full scan to sync the newly
>>> >> >> > changed
>>> >> >> > resources.
>>> >> >> >
>>> >> >> > Let me know if you need more info.
>>> >> >> > Thanks
>>> >> >> > Alex Ough
>>> >> >> >
>>> >> >> >
>>> >> >> > On Thu, Feb 27, 2014 at 3:50 PM, Daan Hoogland
>>> >> >> > 
>>> >> >> > wrote:
>>> >> >> >>
>>> >> >> >> I see, great.
>>> >> >> >>
>>> >> >> >> I will find a moment to apply it and test. It looks good at
>>> >> >> >> first
>>> >> >> >> sight.
>>> >> >> >>
>>> >> >> >> Don't forget adding the license header to the new files. Are you
>>> >> >> >> updating the review request with these tests?
>>> >> >> >>
>>> >> >> >> You are using a local branch to implement this on,
>>> >> >> >> 'alexoughsg/Albatross'  is a fork of cloudstack, is it?
>>> >> >> >> Let's discuss merge back and testing.
>>> >> >> >> Do you have a integration test script in Marvin and/or scenarios
>>> >> >> >> that
>>> >> >> >> will ensure continued functionality for the sync feature?
>>> >> >> >>
>>> >> >> >>
>>> >> >> >> thanks,
>>> >> >> >> Daan
>>> >> >> >>
>>> >> >> >> On Thu, Feb 27, 2014 at 9:19 PM, Alex Ough
>>> >> >> >> 
>>> >> >> >> wrote:
>>> >> >> >> > Hi Daan,
>>> >> >> >> >
>>> >> >> >> > We started to work on implementing unit tests and checked in
>>> >> >> >> > some
>>> >> >> >> > of
>>> >> >> >> > them,
>>> >> >> >> > so please review them and let us know if there is any
>>> >> >> >> > comments/suggestions.
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> > https://github.com/alexoughsg/Albatross/commit/fca94db36054ee35f5da85c69c2471430e0eebfe
>>> >> >> >> >
>>> >> >> >> > Thanks
>>> >> >> >> > Alex Ough
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> > On Thu, Feb 13, 2014 at 3:15 PM, Alex Ough
>>> >> >> >> > 
>>> >> >> >> > wrote:
>>> >> >> >> >>
>>> >> >> >> >> We're just about to add unit tests, so I'll add them once
>>> >> >> >> >> completed.
>>> >> >> >> >>
>>> >> >> >> >> Thanks
>>> >> >> >> >> Alex Ough
>>> >> >> >> >>
>>> >> >> >> >>
>>> >> >> >> >> On Thu, Feb 13, 2014 at 3:12 PM, Daan Hoogland
>>> >> >> >> >> 
>>> >> >> >> >> wrote:
>>> >> >> >> >>>
>>> >> >> >> >>> h Alex,
>>> >> >> >> >>>
>>> >> >> >> >>>  looks alright (i did mean with newlines but I don't know if
>>> >> >> >> >>> this
>>> >> >> >> >>> is
>>> >> >> >> >>> actually caught by our checkstyle run) I was wondering if
>>> >> >> >> >>> you
>>> >> >> >> >>> have
>>> >> >> >> >>> any
>>> >> >> >> >>> unit
>>> >> >> >> >>> tests for your code. I can see you did take testing
>>> >> >> >> >>> seriously
>>> >> >> >> >>> and I
>>> >> >> >> >>> would
>>> >> >> >> >>> like to see this formalized for future reference and
>>> >> >> >> >>> repetition
>>> >> >> >> >>> on
>>> >> >> >> >>> updates.
>>> >> >> >> >>> Can you add some stuff in this line?
>>> >> >> >> >>>
>>> >> >> >> >>> thanks,
>>> >> >> >> >>> Daan
>>> >> >> >> >>>
>>> >> >> >> >>>
>>> >> >> >> >>> On Thu, Feb 13, 2014 at 9:52 PM, Alex Ough
>>> >> >> >> >>> 
>>> >> >> >> >>> wrote:
>>> >> >> >> 
>>> >> >> >>  Hi Da

Re: Review Request 18795: Sanity code review for: JIRA CloudStack-764 nTier Apps 2.0 : Redundant Virtual Router for VPC

2014-03-06 Thread daan Hoogland

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18795/#review36352
---


Are you contemplating redundant routing on a per network basis? It would seem 
to me that the router, hence the whole vpc with all it networks is redundant or 
not.

- daan Hoogland


On March 5, 2014, 8:20 p.m., Karl Harris wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18795/
> ---
> 
> (Updated March 5, 2014, 8:20 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Changes/additions to BASH scripts and .java files as well as pseudo code 
> comments. This posting is a sanity check review posting; before I get too far 
> along with making the changes required for this JIRA CloudStack-764 nTier 
> Apps 2.0 : Redundant Virtual Router for VPC I thought I'd publish my 
> intentions to the community to review and comment.
> 
> 
> Diffs
> -
> 
>   core/src/com/cloud/agent/api/SetupGuestNetworkCommand.java 
> 2cf5bf8ffaa2b0df122c69f047ee3f56982267e1 
>   
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
>  03af0da51b1eec93eb878fd1ebeca2ff2e0802ce 
>   
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
>  69b7c9e07c753c0f0c93197a809acfb3399cf555 
>   systemvm/patches/debian/config/opt/cloud/bin/vpc_guestnw.sh 
> e5da2e096b30f6fdb15226e889517537d04f2e3e 
> 
> Diff: https://reviews.apache.org/r/18795/diff/
> 
> 
> Testing
> ---
> 
> None, yet still coding
> 
> 
> Thanks,
> 
> Karl Harris
> 
>



[GitHub] cloudstack-docs pull request: add warning not to use "-Dmaven.test...

2014-03-06 Thread snowch
GitHub user snowch opened a pull request:

https://github.com/apache/cloudstack-docs/pull/2

add warning not to use "-Dmaven.test.skip=true"



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/snowch/cloudstack-docs patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2


commit a3c2827cd16a338cd7bd80d5def8ac81262f2adb
Author: Chris Snow 
Date:   2014-03-06T09:57:26Z

add warning not to use "-Dmaven.test.skip=true"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Daan Hoogland
I totally agree with the incremental approach. I am a fascist at time
because i would even want people to add downgrade scripts to any db
change they make. Having them not adjust their sql is a good first
step, though.

On Thu, Mar 6, 2014 at 10:43 AM, Miguel Ferreira
 wrote:
> Hi all,
>
> I've been looking at the way DB related code (SQL scripts and Java classes) 
> are updated and what is the impact of those updates on a live cloudstack DB.
> By the way, my intention is to support a per-commit DB upgrade of a running 
> system.
>
> Anyway, I completely agree that sending an email warning people about changes 
> that can potentially break running environments is a good thing, and can save 
> a lot of time and headaches.
> I also like the idea of Rajani of using tools to help in the DB migration 
> process.
> However, I would like to put forward another idea: what about making sure 
> that the changes to the DB (schema and data) are always incremental?
>
> I mean, once a SQL statement (say A) is added to a script it could be kept as 
> is, and subsequent modifications cloud be made via new statements (say B), 
> instead of adapting A.
> This would allow people to upgrade their databases to the point they ran 
> statement A, and afterwards upgrade it again to the point they ran statement 
> B.
> The same principle could also be applied to the Java classes that do data 
> migration, but maybe there it might be a bit more involved.
>
> Cheers,
> Miguel
>
> -Original Message-
> From: Koushik Das [mailto:koushik@citrix.com]
> Sent: donderdag 6 maart 2014 8:25
> To: 
> Subject: Re: [DISCUSS] Checking in code that will break others' environments
>
> Before doing a git pull, I generally check the sql schema changes and run the 
> delta manually on my existing setup. In most of the cases that works for me 
> without having to redeploy the db.
>
> -Koushik
>
> On 06-Mar-2014, at 11:43 AM, Mike Tutkowski  
> wrote:
>
>> Yeah, I definitely just meant a "heads up" during development if you
>> are going to change something that will break other people's
>> environments who update. If these people know in advance, they may
>> choose to postpone an update until they are at a better point.
>>
>>
>> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi
>> >> wrote:
>>
>>> Across versions db migration is taken care. I think this is bound to
>>> occur while working on a release, if multiple people work on the same
>>> branch with different work-in-progress features.
>>>
>>> Could we move to flyway or liquibase which can take care of db
>>> versioning and migration?
>>>
>>>
>>> ~Rajani
>>>
>>>
>>>
>>> On 06-Mar-2014, at 2:08 am, Mike Tutkowski
>>> 
>>> wrote:
>>>
 Yeah, in this case, I'm not referring to erroneous code that breaks
 a person's environment (since hopefully the person wouldn't have
 knowingly checked in such code), but rather, say, DB-type changes
 that improve the system, but break current setups.

 Just a heads-up e-mail with some easily identifiable tag.

 Can anyone think of a good tag for this? It's not always DB related,
 so
>>> we
 might want the tag to be more general.


 On Wed, Mar 5, 2014 at 1:28 PM, Ian Duffy  wrote:

> +1 to this.
>
> Having the build suddenly break due to a git pull has been very
>>> annoying!
> I usually end up searching through the commit log and doing a
> resets until I find a commit where it works. Then waiting awhile
> until I do a git pull again and hoping the code was fixed.
>
> On 5 March 2014 20:19, Mike Tutkowski
> 
> wrote:
>> Hi,
>>
>> I encountered a bit of a problem this morning and thought I would
>> bring
> it
>> up for discussion.
>>
>> If we already have a policy around this, please let me know.
>>
>> So, I fetched the latest and rebased my local 4.4 development
>> branch on
> top
>> of master. This all went just fine.
>>
>> When I rebuilt and re-started the CS Management Server, I soon
>>> realized I
>> could no longer log in from the GUI.
>>
>> As it turns out, the DB schema had been updated and so my database
>> was
> out
>> of date. The code was querying for fields that didn't exist in my DB.
>>
>> As far as I know, the easiest way to get around this is to destroy
>> my current cloud, run the script to re-build my database, then
>> re-create
>>> my
>> cloud, which is somewhat time consuming.
>>
>> Do we have a process in place currently in which we ask those who
>> make
> such
>> changes to send out a notification e-mail to dev@ to give people a
> heads up
>> that updating will lead to such issues? On previous projects, we
>> would
> send
>> out an e-mail and then people could be aware to only update if
>> they
>>> were
>> prepared for such re-work.
>>
>> To be clear here, I'm not meaning to pick on any

[REGRESSION][4.2]

2014-03-06 Thread Daan Hoogland
H,

We found a functionality that we use once in a while no longer is permitted in 
4.2.1. It seems in line with the philosophy of cloudstack but is hurting our 
operation. In 4.1.1 we could add a bridged network with the following network 
offering:

cno.traffictype = "GUEST"
cno.guestiptype = "Isolated"
cno.specifyipranges = True
cno.specifyvlan = False

cno.serviceproviderlist = [ { "service": "Connectivity", "provider": 
"NiciraNvp"},
{ "service": "UserData", "provider": 
"VirtualRouter"},
{ "service": "Dhcp", "provider": "VirtualRouter"} ]

This is no longer allowed. The use case we have for this is to bridge isolated 
networks using nicira into hardware/baremetal networks. We tried to work around 
it yesterday by using shared networks but can't because as of now we only 
support isolated networks on nicira. The cause of the regression is part of 
commit
commit bdac0f8ebc6ee9368d52a263156259a747a219a6
Author: Anthony Xu  2013-07-22 23:16:20

in one zone, Admin should not be allowed to add a Shared Network with a subnet 
that is already associated with another Vlan.

Which changes mostly the overlap code in 
server/src/com/cloud/configuration/ConfigurationManagerImpl.java but also some 
code in NetworkServiceImpl:
- server/src/com/cloud/network/NetworkServiceImpl.java 
diff --git a/server/src/com/cloud/network/NetworkServiceImpl.java 
b/server/src/com/cloud/network/NetworkServiceImpl.java
index 5ebd702..7e6b581 100755
--- a/server/src/com/cloud/network/NetworkServiceImpl.java
+++ b/server/src/com/cloud/network/NetworkServiceImpl.java
@@ -1248,13 +1248,10 @@
 }
 }
-// Vlan is created in 2 cases - works in Advance zone only:
+// Vlan is created in 1 cases - works in Advance zone only:
 // 1) GuestType is Shared
-// 2) GuestType is Isolated, but SourceNat service is disabled
 boolean createVlan = (startIP != null && endIP != null && 
zone.getNetworkType() == NetworkType.Advanced
-&& ((ntwkOff.getGuestType() == Network.GuestType.Shared)
-|| (ntwkOff.getGuestType() == GuestType.Isolated &&
-!areServicesSupportedByNetworkOffering(ntwkOff.getId(), 
Service.SourceNat;
+&& (ntwkOff.getGuestType() == Network.GuestType.Shared));
 if (!createVlan) {
  // Only support advance shared network in IPv6, which means 
createVlan is a must
I made a custom patch for 4.2.1 to maintain daily operation and would like to 
consider putting this in 4.3 as well. Any alternatives will be considered.

Kind regards,
Daan


RE: [DISCUSS] Checking in code that will break others' environments

2014-03-06 Thread Miguel Ferreira
Hi all,

I've been looking at the way DB related code (SQL scripts and Java classes) are 
updated and what is the impact of those updates on a live cloudstack DB.
By the way, my intention is to support a per-commit DB upgrade of a running 
system.

Anyway, I completely agree that sending an email warning people about changes 
that can potentially break running environments is a good thing, and can save a 
lot of time and headaches.
I also like the idea of Rajani of using tools to help in the DB migration 
process.
However, I would like to put forward another idea: what about making sure that 
the changes to the DB (schema and data) are always incremental?

I mean, once a SQL statement (say A) is added to a script it could be kept as 
is, and subsequent modifications cloud be made via new statements (say B), 
instead of adapting A.
This would allow people to upgrade their databases to the point they ran 
statement A, and afterwards upgrade it again to the point they ran statement B.
The same principle could also be applied to the Java classes that do data 
migration, but maybe there it might be a bit more involved.

Cheers,
Miguel

-Original Message-
From: Koushik Das [mailto:koushik@citrix.com] 
Sent: donderdag 6 maart 2014 8:25
To: 
Subject: Re: [DISCUSS] Checking in code that will break others' environments

Before doing a git pull, I generally check the sql schema changes and run the 
delta manually on my existing setup. In most of the cases that works for me 
without having to redeploy the db.

-Koushik

On 06-Mar-2014, at 11:43 AM, Mike Tutkowski  
wrote:

> Yeah, I definitely just meant a "heads up" during development if you 
> are going to change something that will break other people's 
> environments who update. If these people know in advance, they may 
> choose to postpone an update until they are at a better point.
> 
> 
> On Wed, Mar 5, 2014 at 11:01 PM, Rajani Karuturi 
> > wrote:
> 
>> Across versions db migration is taken care. I think this is bound to 
>> occur while working on a release, if multiple people work on the same 
>> branch with different work-in-progress features.
>> 
>> Could we move to flyway or liquibase which can take care of db 
>> versioning and migration?
>> 
>> 
>> ~Rajani
>> 
>> 
>> 
>> On 06-Mar-2014, at 2:08 am, Mike Tutkowski 
>> 
>> wrote:
>> 
>>> Yeah, in this case, I'm not referring to erroneous code that breaks 
>>> a person's environment (since hopefully the person wouldn't have 
>>> knowingly checked in such code), but rather, say, DB-type changes 
>>> that improve the system, but break current setups.
>>> 
>>> Just a heads-up e-mail with some easily identifiable tag.
>>> 
>>> Can anyone think of a good tag for this? It's not always DB related, 
>>> so
>> we
>>> might want the tag to be more general.
>>> 
>>> 
>>> On Wed, Mar 5, 2014 at 1:28 PM, Ian Duffy  wrote:
>>> 
 +1 to this.
 
 Having the build suddenly break due to a git pull has been very
>> annoying!
 I usually end up searching through the commit log and doing a 
 resets until I find a commit where it works. Then waiting awhile 
 until I do a git pull again and hoping the code was fixed.
 
 On 5 March 2014 20:19, Mike Tutkowski 
 
 wrote:
> Hi,
> 
> I encountered a bit of a problem this morning and thought I would 
> bring
 it
> up for discussion.
> 
> If we already have a policy around this, please let me know.
> 
> So, I fetched the latest and rebased my local 4.4 development 
> branch on
 top
> of master. This all went just fine.
> 
> When I rebuilt and re-started the CS Management Server, I soon
>> realized I
> could no longer log in from the GUI.
> 
> As it turns out, the DB schema had been updated and so my database 
> was
 out
> of date. The code was querying for fields that didn't exist in my DB.
> 
> As far as I know, the easiest way to get around this is to destroy 
> my current cloud, run the script to re-build my database, then 
> re-create
>> my
> cloud, which is somewhat time consuming.
> 
> Do we have a process in place currently in which we ask those who 
> make
 such
> changes to send out a notification e-mail to dev@ to give people a
 heads up
> that updating will lead to such issues? On previous projects, we 
> would
 send
> out an e-mail and then people could be aware to only update if 
> they
>> were
> prepared for such re-work.
> 
> To be clear here, I'm not meaning to pick on anyone in
>> particular...this
> has happened several times over the course of my CloudStack 
> development
 and
> I expect that I, too, have checked in such code (without sending 
> out a relevant e-mail) that lead people to have to perform such a 
> complete re-build action un-expectedly.
> 
> What do people think about this? Maybe we should just add an 
> e-mai

Re: jenkins job for the developer build

2014-03-06 Thread Hugo Trippaers
The Jenkins builds do mvn -Pawsapi,systemvm clean install.

I'm not using the developer profile there thats just for Marvin and Apidocs. 
Those are built separately. You can have a fully functional cloud dev 
environment without the developer profile.

Cheers,

Hugo

Sent from my iPhone

> On 6 mrt. 2014, at 06:01, chris snow  wrote:
> 
> Is there a jenkins job for the developer's build, i.e. mvn clean
> install -P developer,systemvm?  As a newbie cloudstack developer, when
> the build fails locally it's difficult to know whether the problem is
> because I am doing something wrong, or if the problem is due to a bad
> commit.


Re: mvn install has a dependency on tests: "-Dmaven.test.skip=true" breaks the build

2014-03-06 Thread chris snow
-DskipTests may work around the problem by compiling the tests but not
running them.  However, there is still a dependency on test artifacts
being by mvn install.  IMHO, the dependency should be removed or
clearly documented because it deviates from the normal maven usage
patterns?

On Thu, Mar 6, 2014 at 8:59 AM, Wei ZHOU  wrote:
> mvn -P  clean install developer,systemvm -DskipTests
>
>
> 2014-03-06 9:54 GMT+01:00 chris snow :
>
>> I have been adding the flag "-Dmaven.test.skip=true" to my builds:
>>
>>mvn clean install -P developer,systemvm -Dmaven.test.skip=true
>>
>> However, I was getting the error:
>>
>> [ERROR] Failed to execute goal on project cloud-framework-cluster:
>> Could not resolve dependencies for project
>> org.apache.cloudstack:cloud-framework-cluster:jar:4.4.0-SNAPSHOT:
>> Could not find artifact
>> org.apache.cloudstack:cloud-api:jar:tests:4.4.0-SNAPSHOT in
>> sonatype-snapshots
>> (https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]
>>
>> I was surprised that "mvn clean install -P developer,systemvm" has a
>> dependency on tests being run.  It looks as if this commit [1] added
>> the dependency on tests from the maven install goal.
>>
>> I guess either the dependency needs to be removed, or the docs need to
>> be updated to state that the maven.test.skip flag must not be set to
>> true [2]?
>>
>> ---
>> [1]
>> https://github.com/apache/cloudstack/commit/f5e5b39c9bc8d0e719dbb27cb8228b868c6f726f
>> [2]
>> https://github.com/apache/cloudstack-docs/blob/master/rtd/source/developer_guide.rst#installing-from-source
>>



-- 
Check out my professional profile and connect with me on LinkedIn.
http://lnkd.in/cw5k69


Re: mvn install has a dependency on tests: "-Dmaven.test.skip=true" breaks the build

2014-03-06 Thread Wei ZHOU
mvn -P  clean install developer,systemvm -DskipTests


2014-03-06 9:54 GMT+01:00 chris snow :

> I have been adding the flag "-Dmaven.test.skip=true" to my builds:
>
>mvn clean install -P developer,systemvm -Dmaven.test.skip=true
>
> However, I was getting the error:
>
> [ERROR] Failed to execute goal on project cloud-framework-cluster:
> Could not resolve dependencies for project
> org.apache.cloudstack:cloud-framework-cluster:jar:4.4.0-SNAPSHOT:
> Could not find artifact
> org.apache.cloudstack:cloud-api:jar:tests:4.4.0-SNAPSHOT in
> sonatype-snapshots
> (https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]
>
> I was surprised that "mvn clean install -P developer,systemvm" has a
> dependency on tests being run.  It looks as if this commit [1] added
> the dependency on tests from the maven install goal.
>
> I guess either the dependency needs to be removed, or the docs need to
> be updated to state that the maven.test.skip flag must not be set to
> true [2]?
>
> ---
> [1]
> https://github.com/apache/cloudstack/commit/f5e5b39c9bc8d0e719dbb27cb8228b868c6f726f
> [2]
> https://github.com/apache/cloudstack-docs/blob/master/rtd/source/developer_guide.rst#installing-from-source
>


mvn install has a dependency on tests: "-Dmaven.test.skip=true" breaks the build

2014-03-06 Thread chris snow
I have been adding the flag "-Dmaven.test.skip=true" to my builds:

   mvn clean install -P developer,systemvm -Dmaven.test.skip=true

However, I was getting the error:

[ERROR] Failed to execute goal on project cloud-framework-cluster:
Could not resolve dependencies for project
org.apache.cloudstack:cloud-framework-cluster:jar:4.4.0-SNAPSHOT:
Could not find artifact
org.apache.cloudstack:cloud-api:jar:tests:4.4.0-SNAPSHOT in
sonatype-snapshots
(https://oss.sonatype.org/content/repositories/snapshots/) -> [Help 1]

I was surprised that "mvn clean install -P developer,systemvm" has a
dependency on tests being run.  It looks as if this commit [1] added
the dependency on tests from the maven install goal.

I guess either the dependency needs to be removed, or the docs need to
be updated to state that the maven.test.skip flag must not be set to
true [2]?

---
[1] 
https://github.com/apache/cloudstack/commit/f5e5b39c9bc8d0e719dbb27cb8228b868c6f726f
[2] 
https://github.com/apache/cloudstack-docs/blob/master/rtd/source/developer_guide.rst#installing-from-source