Jenkins build is still unstable: simulator-singlerun #313

[jenkins]

See 

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[lsimons]

Github user lsimons commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54785217
  
Hey Daan, _this_ change is fine&done as-is. Like Rajani mentioned, the 
other changes to that file could be ported, too. I'm +0 on that -- on the one 
hand, it's a good change and I can't see any way that it would ever break 
anything, on the other hand it's a (however minor) behavioral change so I 
personally wouldn't put that in a point release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 25426: CLOUDSTACK-7370: Fixed password visible in plain text if password passed is in the end in url

[Anshul Gangwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25426/
---

Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.


Bugs: CLOUDSTACK-7370
https://issues.apache.org/jira/browse/CLOUDSTACK-7370


Repository: cloudstack-git


Description
---

updated the regular expression which is used to clean password


Diffs
-

  utils/src/com/cloud/utils/StringUtils.java 17b8fc0 

Diff: https://reviews.apache.org/r/25426/diff/


Testing
---

tested by passing affected strings through regular expressions.


Thanks,

Anshul Gangwar

[GitHub] cloudstack pull request: bugfix/CLOUDSTACK-7476 for 4.4 branch.

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/17#issuecomment-54790328
  
Leo, you are right but if it is in 4.3 not putting it in 4.4 would make it
a double behavioural change from a user perspective. So I will look at
cherry-picking it anyway


On Mon, Sep 8, 2014 at 9:38 AM, Leo Simons  wrote:

> Hey Daan, *this* change is fine&done as-is. Like Rajani mentioned, the
> other changes to that file could be ported, too. I'm +0 on that -- on the
> one hand, it's a good change and I can't see any way that it would ever
> break anything, on the other hand it's a (however minor) behavioral change
> so I personally wouldn't put that in a point release.
>
> —
> Reply to this email directly or view it on GitHub
> .
>



-- 
Daan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 25427: fixed few coverity issues

[Anshul Gangwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25427/
---

Review request for cloudstack and Devdeep Singh.


Repository: cloudstack-git


Description
---

fixed few coverity issues. Not logging the proper string.


Diffs
-

  
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 76f8e75 

Diff: https://reviews.apache.org/r/25427/diff/


Testing
---


Thanks,

Anshul Gangwar

Request to pick hotfix/4.4/CLOUDSTACK-6624 on 4.4 branch

[Rohit Yadav]

Hi Daan,

Please see if you want to pick hotfix/4.4/CLOUDSTACK-6624 for 4.4 branch. 
Thanks.

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Re: Review Request 25427: fixed few coverity issues

[Anshul Gangwar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25427/
---

(Updated Sept. 8, 2014, 8:57 a.m.)


Review request for cloudstack and Devdeep Singh.


Bugs: CLOUDSTACK-7503
https://issues.apache.org/jira/browse/CLOUDSTACK-7503


Repository: cloudstack-git


Description
---

fixed few coverity issues. Not logging the proper string.


Diffs
-

  
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
 76f8e75 

Diff: https://reviews.apache.org/r/25427/diff/


Testing
---


Thanks,

Anshul Gangwar

Build failed in Jenkins: cloudstack-4.3-maven-build #583

[jenkins]

See 

Changes:

[Rohit Yadav] appliance: fix build.sh for vmware systemvm building and exporting

[Rohit Yadav] CLOUDSTACK-6624: set specifyIpRanges to true if specifyVlan is 
set to true

--
[...truncated 2421 lines...]
219/419 KB   
223/419 KB   
227/419 KB   
231/419 KB   
232/419 KB   
235/419 KB   
239/419 KB   
243/419 KB   
247/419 KB   
251/419 KB   
255/419 KB   
259/419 KB   
263/419 KB   
267/419 KB   
271/419 KB   
275/419 KB   
279/419 KB   
281/419 KB   
284/419 KB   
288/419 KB   
292/419 KB   
296/419 KB   
300/419 KB   
304/419 KB   
308/419 KB   
312/419 KB   
316/419 KB   
320/419 KB   
324/419 KB   
328/419 KB   
332/419 KB   
336/419 KB   
340/419 KB   
344/419 KB   
348/419 KB   
352/419 KB   
356/419 KB   
360/419 KB   
364/419 KB   
368/419 KB   
372/419 KB   
373/419 KB   
377/419 KB   
381/419 KB   
385/419 KB   
389/419 KB   
393/419 KB   
397/419 KB   
401/419 KB   
405/419 KB   
409/419 KB   
413/419 KB   
417/419 KB   
419/419 KB   
 
Downloaded: 
http://repo.maven.apache.org/maven2/org/apache/httpcomponents/httpclient/4.2.2/httpclient-4.2.2.jar
 (419 KB at 3946.4 KB/sec)
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Deleting 

 (includes = [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-plugin-hypervisor-xen ---
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-plugin-hypervisor-xen ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 4 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-plugin-hypervisor-xen ---
[INFO] Compiling 22 source files to 

[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
:[108,33]
 cannot find symbol
symbol  : method 
properFrom(com.xensource.xenapi.Connection,java.util.Set,java.lang.String,java.lang.Double)
location: class com.xensource.xenapi.Event
[ERROR] 
:[171,39]
 cannot find symbol
symbol  : method 
properFrom(com.xensource.xenapi.Connection,java.util.Set,java.lang.String,java.lang.Double)
location: class com.xensource.xenapi.Event
[ERROR] 
:[308,35]
 cannot find symbol
symbol  : method 
properFrom(com.xensource.xenapi.Connection,java.util.Set,java.lang.String,java.lang.Double)
location: class com.xensource.xenapi.Event
[ERROR] 
:[177,34]
 cannot find symbol
symbol  : method 
copyAsync2(com.xensource.xenapi.Connection,com.xensource.xenapi.SR,,)
location: class com.xensource.xenapi.VDI
[ERROR] 
:[236,34]
 cannot find symbol
symbol  : method 
copyAsync2(com.xensource.xenapi.Connection,com.xensource.xenapi.SR,com.xensource.xenapi.VDI,)
location: class com.xensource.xenapi.VDI
[ERROR] 
:[347,43]
 cannot find symbol
symbol  : method 
copyAsync2(com.xensource.xenapi.Connection,com.xensource.xenapi.SR,,)
location: class com.xensource.xenapi.VDI
[ERROR] 
:[465,27]
 cannot find symbol
symbol  : method 
copyAsync2(com.xensource.xenapi.Connection,com.xensource.xenapi.SR,,)
location: class com.xensource.xenapi.VDI
[ERROR] 
:[581,37]
 cannot find symbol
symbol  : method 
copyAsync2(com.xensource.xenapi.Connection,,,com.xensource.xenapi.VDI)
location: clas

Review Request 25429: CLOUDSTACK-7502: UI: Host detail page - Display KVM agent version and Qemu version

[Mihaela Stoica]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25429/
---

Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

- Added Agent version and Qemu version fields to the Host detail page, with the 
values from the host's details field
- Only displayed for KVM hosts, as the details field is not defined for other 
hypervisors


Diffs
-

  client/WEB-INF/classes/resources/messages.properties 4655973 
  ui/dictionary.jsp 0102144 
  ui/scripts/system.js cf3b9dc 

Diff: https://reviews.apache.org/r/25429/diff/


Testing
---


Thanks,

Mihaela Stoica

Re: Review Request 25429: CLOUDSTACK-7502: UI: Host detail page - Display KVM agent version and Qemu version

[Mihaela Stoica]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25429/
---

(Updated Sept. 8, 2014, 10:13 a.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Repository: cloudstack-git


Description
---

- Added Agent version and Qemu version fields to the Host detail page, with the 
values from the host's details field
- Only displayed for KVM hosts, as the details field is not defined for other 
hypervisors


Diffs
-

  client/WEB-INF/classes/resources/messages.properties 4655973 
  ui/dictionary.jsp 0102144 
  ui/scripts/system.js cf3b9dc 

Diff: https://reviews.apache.org/r/25429/diff/


Testing
---


Thanks,

Mihaela Stoica

RE: [VOTE] Release Apache CloudStack 4.3.1, round #2

[Geoff Higginbottom]

-1

I have tested an upgrade from a 4.3 install and whilst nearly everything I have 
tested works, unfortunately a bug which was introduced in 4.3.0 
(CLOUDSTACK-6624) is still there.

The good news however is that I raised this with one of our Devs and it has now 
been fixed so can be tested in the next voting round.

Will continue testing as much as possible where time from @dayjob permits

Regards

Geoff Higginbottom

D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581

geoff.higginbot...@shapeblue.com

-Original Message-
From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
Sent: 05 September 2014 17:01
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Release Apache CloudStack 4.3.1, round #2

+1

Using reasons from previous voting round, tested for Xen/KVM, basic zone + SG.

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.
Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/
---

Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-6099
https://issues.apache.org/jira/browse/CLOUDSTACK-6099


Repository: cloudstack-git


Description
---

live migration is failing for vm deployed using dynaic compute offerings with 
NPE
https://issues.apache.org/jira/browse/CLOUDSTACK-6099


Diffs
-

  api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
  engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java a1e2528 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8edef77 
  server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 

Diff: https://reviews.apache.org/r/25430/diff/


Testing
---

Tested live migration on master using xenserver.


Thanks,

bharat kumar

Re: [VOTE] Release Apache CloudStack 4.3.1, round #2

[Rohit Yadav]

Hi,

I’ve fixed the UI bug that Geoff mentioned and fixed another build issue with 
systemvms.
Now, they are building fine. You may get 4.3.1 systemvms from following links 
(though we need to verify if systemvms changed since 4.3.0):

http://jenkins.buildacloud.org/view/4.3/job/cloudstack-4.3-systemvm64/
http://jenkins.buildacloud.org/view/4.3/job/cloudstack-4.3-systemvm/

On 08-Sep-2014, at 11:13 am, Geoff Higginbottom 
 wrote:
> -1
>
> I have tested an upgrade from a 4.3 install and whilst nearly everything I 
> have tested works, unfortunately a bug which was introduced in 4.3.0 
> (CLOUDSTACK-6624) is still there.
>
> The good news however is that I raised this with one of our Devs and it has 
> now been fixed so can be tested in the next voting round.
>
> Will continue testing as much as possible where time from @dayjob permits
>
> Regards
>
> Geoff Higginbottom
>
> D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581
>
> geoff.higginbot...@shapeblue.com
>
> -Original Message-
> From: Rohit Yadav [mailto:rohit.ya...@shapeblue.com]
> Sent: 05 September 2014 17:01
> To: dev@cloudstack.apache.org
> Subject: Re: [VOTE] Release Apache CloudStack 4.3.1, round #2
>
> +1
>
> Using reasons from previous voting round, tested for Xen/KVM, basic zone + SG.
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +41 779015219 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Infrastructure 
> Support
> CloudStack Bootcamp Training 
> Courses
>
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
> registered by The Republic of South Africa and is traded under license from 
> Shape Blue Ltd. ShapeBlue is a registered trademark.
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Infrastructure 
> Support
> CloudStack Bootcamp Training 
> Courses
>
> This email and any attachments to it may be confidential and are intended 
> solely for the use of the individual to whom it is addressed. Any views or 
> opinions expressed are solely those of the author and do not necessarily 
> represent those of Shape Blue Ltd or related companies. If you are not the 
> intended recipient of this email, you must neither take any action based upon 
> its contents, nor copy or show it to anyone. Please contact the sender if you 
> believe you have received this email in error. Shape Blue Ltd is a company 
> incorporated in England & Wales. ShapeBlue Services India LLP is a company 
> incorporated in India and is operated under license from Shape Blue Ltd. 
> Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
> operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
> registered by The Republic of South Africa and is traded under license from 
> Shape Blue Ltd. ShapeBlue is a registered trademark.

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52575
---



server/src/com/cloud/server/ManagementServerImpl.java


Why not fix VirtualMachineProfileImpl constructor where we're passing the 
offering?

VirtualMachineProfile vmProfile = new VirtualMachineProfileImpl(vm, null, 
_offeringDao.findById(vm.getId(), vm.getServiceOfferingId()), null, null);


- Rohit Yadav


On Sept. 8, 2014, 9:16 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java 
> a1e2528 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
>   server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Koushik Das]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52576
---



server/src/com/cloud/server/ManagementServerImpl.java


In the prvious line, service offering is getting set, why set it again?

Since there is a way to pass offering in ctor, is  an explicit setter 
really required?


- Koushik Das


On Sept. 8, 2014, 9:16 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java 
> a1e2528 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
>   server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52577
---



engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java


setServiceOffering already exists in this class, line #235.

public void setServiceOffering(ServiceOfferingVO offering) {
236 
_offering = offering;
236 
_offering = offering;
237 
}
237 
}


- Rohit Yadav


On Sept. 8, 2014, 9:16 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java 
> a1e2528 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
>   server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52578
---



engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java


If this is the code fixing the bug, you may use one of the available 
VirtualMachineProfile contructor signature or create a new constructor 
signature that accepts vm and service offering.

Quick hack, use:

VirtualMachineProfileImpl(vm, null, serviceOfferingHere, null, null)


- Rohit Yadav


On Sept. 8, 2014, 9:16 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java 
> a1e2528 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
>   server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Request to pick hotfix/4.4/CLOUDSTACK-6624 on 4.4 branch

[Daan Hoogland]

merged


On Mon, Sep 8, 2014 at 10:55 AM, Rohit Yadav 
wrote:

> Hi Daan,
>
> Please see if you want to pick hotfix/4.4/CLOUDSTACK-6624 for 4.4 branch.
> Thanks.
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +41 779015219 | rohit.ya...@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
> Find out more about ShapeBlue and our range of CloudStack related services
>
> IaaS Cloud Design & Build<
> http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge – rapid IaaS deployment framework
> CloudStack Consulting
> CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views or
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not the
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the sender
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is a
> company incorporated in India and is operated under license from Shape Blue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>



-- 
Daan

[ACS44] 4.4.1 rc question

[Daan Hoogland]

H,

In view of our release 4.3.1, should I wait with creating a release
candidate before it is out? It seems that no more work is going on and 4.4
is ready for a new release.

-- 
Daan

Re: [ACS44] 4.4.1 rc question

[Wido den Hollander]

On 09/08/2014 12:03 PM, Daan Hoogland wrote:

H,

In view of our release 4.3.1, should I wait with creating a release
candidate before it is out? It seems that no more work is going on and 4.4
is ready for a new release.



I'd say wait for a moment. There seems to be a last minute bugfix coming 
from the ShapeBlue guys for 4.3.1


We should make sure that everything we fix in 4.3.1 is ALSO fixed in 4.4.1

Wido

Re: [ACS44] 4.4.1 rc question

[Francois Gaudreault]

I wouldnt wait too long we are on this code base for a bit. We kinda
need GA code :)

FG
On Sep 8, 2014 6:09 AM, "Wido den Hollander"  wrote:

> On 09/08/2014 12:03 PM, Daan Hoogland wrote:
>
>> H,
>>
>> In view of our release 4.3.1, should I wait with creating a release
>> candidate before it is out? It seems that no more work is going on and 4.4
>> is ready for a new release.
>>
>>
> I'd say wait for a moment. There seems to be a last minute bugfix coming
> from the ShapeBlue guys for 4.3.1
>
> We should make sure that everything we fix in 4.3.1 is ALSO fixed in 4.4.1
>
> Wido
>

Jenkins build is still unstable: simulator-singlerun #314

[jenkins]

See 

Build failed in Jenkins: build-master-simulator #547

[jenkins]

See 

--
[...truncated 1264 lines...]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ 
cloud-engine-components-api ---
[INFO] Compiling 31 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-engine-components-api ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-engine-components-api ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ 
cloud-engine-components-api ---
[INFO] Surefire report directory: 


---
 T E S T S
---

Results :

Tests run: 0, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] 
[INFO] Building Apache CloudStack Server 4.5.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloud-server ---
[INFO] Deleting 
 
(includes = [**/*], excludes = [])
[INFO] Deleting 
 (includes 
= [target, dist], excludes = [])
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-server ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ cloud-server 
---
[INFO] 
[INFO] --- maven-antrun-plugin:1.7:run (generate-resource) @ cloud-server ---
[INFO] Executing tasks

main:
 [copy] Copying 3 files to 

 [copy] Copying 1 file to 

[INFO] Executed tasks
[INFO] 
[INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 30 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ cloud-server 
---
[INFO] Compiling 367 source files to 

[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-server ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 29 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ 
cloud-server ---
[INFO] Compiling 92 source files to 

[INFO] 
[INFO] --- maven-surefire-plugin:2.12:test (default-test) @ cloud-server ---
[INFO] Surefire report directory: 


---
 T E S T S
---
Running com.cloud.event.EventControlsUnitTest
log4j:WARN No appenders could be found for logger 
(com.cloud.event.EventControlsUnitTest).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more 
info.
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.762 sec
Running com.cloud.keystore.KeystoreTest
org.apache.cloudstack.api.response.UserVmResponse/null/{"id":"3","securitygroup":[],"nic":[],"tags":[],"affinitygroup":[]}
org.apache.cloudstack.api.response.AlertResponse/null/{"id":"100","description":"Hello"}
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.195 sec
Running com.cloud.alert.AlertControlsUnitTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.026 sec
Running com.cloud.capacity.CapacityManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.159 sec
Running com.cloud.servlet.StaticResourceServletTest
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.15 sec
R

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/
---

(Updated Sept. 8, 2014, 10:52 a.m.)


Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-6099
https://issues.apache.org/jira/browse/CLOUDSTACK-6099


Repository: cloudstack-git


Description
---

live migration is failing for vm deployed using dynaic compute offerings with 
NPE
https://issues.apache.org/jira/browse/CLOUDSTACK-6099


Diffs (updated)
-

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8edef77 

Diff: https://reviews.apache.org/r/25430/diff/


Testing
---

Tested live migration on master using xenserver.


Thanks,

bharat kumar

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[bharat kumar]

> On Sept. 8, 2014, 9:27 a.m., Rohit Yadav wrote:
> > server/src/com/cloud/server/ManagementServerImpl.java, lines 1160-1161
> > 
> >
> > Why not fix VirtualMachineProfileImpl constructor where we're passing 
> > the offering?
> > 
> > VirtualMachineProfile vmProfile = new VirtualMachineProfileImpl(vm, 
> > null, _offeringDao.findById(vm.getId(), vm.getServiceOfferingId()), null, 
> > null);

it is a typo, fixed this.


- bharat


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52575
---


On Sept. 8, 2014, 9:16 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 9:16 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 29f3164 
>   engine/components-api/src/com/cloud/vm/VirtualMachineProfileImpl.java 
> a1e2528 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
>   server/src/com/cloud/server/ManagementServerImpl.java 697d1c4 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25431/
---

Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7506
https://issues.apache.org/jira/browse/CLOUDSTACK-7506


Repository: cloudstack-git


Description
---

Few test cases in Secondary Storage Limits failed due to error in registering 
Template - "Invalid Parameters - hypervisor is required".

Base library function is reading hypervisor value only from function parameter 
and not from services dictionary. But the test cases are passing hypervisor 
value from dictionary.

Solution:
Read the hypervisor value from the services dict if it's not passed through the 
function parameter.


Diffs
-

  tools/marvin/marvin/lib/base.py 982986b 

Diff: https://reviews.apache.org/r/25431/diff/


Testing
---

Yes.

Test Try to deploy VM with admin account where account has not used ... === 
TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS ===
ok
Test Try to deploy VM with admin account where account has used ... SKIP: skip
Test TTry to deploy VM with admin account where account has not used ... SKIP: 
skip

--
Ran 3 tests in 199.895s

OK (SKIP=2)


Thanks,

Gaurav Aradhye

Jenkins build is still unstable: simulator-singlerun #315

[jenkins]

See 

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52581
---


Looks good, have you tested it with Xen, KVM? What was the issue causing live 
migrations to fail, the missing offering?

- Rohit Yadav


On Sept. 8, 2014, 10:52 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 10:52 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: [VOTE] Release Apache CloudStack 4.3.1, round #2

[Rajani Karuturi]

+1 based on the minimal testing I did to launch a VM and the LDAP
integration.

~Rajani

On Fri, Sep 5, 2014 at 9:21 PM, sebgoa  wrote:

> Hi All,
>
> I've created a 4.3.1 release, with the following artifacts up for a vote:
>
> Git Branch and Commit SH:
>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.3
> Commit: 15092167296dd7d4d70e69b8ed3b3390ed40fc0e
>
> List of changes:
>
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob;f=CHANGES.md;hb=4.3
>
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.3.1/
>
> PGP release keys (signed using 8F89EB84):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for 72 hours.
>
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52582
---

Ship it!


LGTM

- Rohit Yadav


On Sept. 8, 2014, 10:52 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 10:52 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

[Vetrivel Chinnasamy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24090/
---

(Updated Sept. 8, 2014, 11:43 a.m.)


Review request for cloudstack, Brian Federle and Jessica Wang.


Changes
---

Splitted dictionary.jsp file to fix max size issue and reupdated the patch with 
other externalization modifications.


Repository: cloudstack-git


Description
---

Externalized the hard-coded strings from JavaScript files to resource bundles. 
Updated the dictionary.jsp file accordingly. Also got the externalized strings 
translated in JA & SC.


Diffs (updated)
-

  client/WEB-INF/classes/resources/messages_ja_JP.properties ed6a1b1 
  client/WEB-INF/classes/resources/messages_zh_CN.properties 2c497bc 
  ui/dictionary.jsp 0102144 
  ui/dictionary2.jsp PRE-CREATION 
  ui/index.jsp 48afa6a 
  ui/modules/vnmcAsa1000v/vnmcAsa1000v.js 621c52a 
  ui/modules/vnmcNetworkProvider/vnmcNetworkProvider.js c9295a3 
  ui/scripts/accounts.js cc4624a 
  ui/scripts/autoscaler.js c8963fd 
  ui/scripts/cloudStack.js 38cf501 
  ui/scripts/configuration.js a70c672 
  ui/scripts/domains.js 488382e 
  ui/scripts/events.js 2731cb6 
  ui/scripts/instances.js 4d536e3 
  ui/scripts/lbStickyPolicy.js 16995f6 
  ui/scripts/network.js 8a758c8 
  ui/scripts/projects.js 53b7964 
  ui/scripts/regions.js 368c1bf 
  ui/scripts/sharedFunctions.js bb2d596 
  ui/scripts/storage.js f4ab6e1 
  ui/scripts/system.js cf3b9dc 
  ui/scripts/templates.js 6dcd6da 
  ui/scripts/ui-custom/autoscaler.js 0aa6c77 
  ui/scripts/ui-custom/healthCheck.js 4e10f1c 
  ui/scripts/ui-custom/physicalResources.js 110945e 
  ui/scripts/ui-custom/regions.js 986e009 
  ui/scripts/ui-custom/zoneWizard.js f3a1aae 
  ui/scripts/ui/dialog.js 6c77924 
  ui/scripts/ui/widgets/listView.js 22182c1 
  ui/scripts/ui/widgets/multiEdit.js 47e5f43 
  ui/scripts/vpc.js d3602fc 
  ui/scripts/zoneWizard.js 4498534 

Diff: https://reviews.apache.org/r/24090/diff/


Testing
---

Tested by replacing the modified javascript , dictionary.jsp and properties 
files.


Thanks,

Vetrivel Chinnasamy

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[Rohit Yadav]

> On Sept. 8, 2014, 11:39 a.m., Rohit Yadav wrote:
> > LGTM

Additional notes: this looks like there are other methods in 
VirtualMachineManagerImpl.java that can possibly have the same issue. One way 
is that we do set service offering in VirtualMachineProfileImpl() contructor 
from passed vm object, so we don't have to change outer layers. We can check 
with people who may have some idea on this class, from git blame -- Alex, 
Kelven, Alena, Devdeep, Nitin, Edison, Mike, etc.


- Rohit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/#review52582
---


On Sept. 8, 2014, 10:52 a.m., bharat kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25430/
> ---
> 
> (Updated Sept. 8, 2014, 10:52 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-6099
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> live migration is failing for vm deployed using dynaic compute offerings with 
> NPE
> https://issues.apache.org/jira/browse/CLOUDSTACK-6099
> 
> 
> Diffs
> -
> 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 
> 8edef77 
> 
> Diff: https://reviews.apache.org/r/25430/diff/
> 
> 
> Testing
> ---
> 
> Tested live migration on master using xenserver.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 25392: CLOUDSTACK-7434: Fixed VM Internal name issue in test_custom_hostname.py

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25392/#review52585
---

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Sept. 5, 2014, 3:53 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25392/
> ---
> 
> (Updated Sept. 5, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7434
> https://issues.apache.org/jira/browse/CLOUDSTACK-7434
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1.Corrected the VM internal name formation. The last part of the internal 
> name is value of "instance.name" from global settings and not the display 
> name of the VM.
> 2.Added missing cleanup items.
> 3.Removed test script which caused other test cases to fail.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_custom_hostname.py 22dbaf5 
> 
> Diff: https://reviews.apache.org/r/25392/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested on VMware setup.
> Out of 5 test cases which were run, 1 test case is still failing because of 
> other reason. Need to look at that one seperately.
> 
> Log:
> Verify user provided hostname to an instance ... === TestName: 
> test_01_user_provided_hostname | Status : SUCCESS ===
> ok
> Verify for globally set instancename ... === TestName: 
> test_02_instancename_from_default_configuration | Status : SUCCESS ===
> ok
> Test the duplicate name when old VM is in non-expunged state ... === 
> TestName: test_03_duplicate_name | Status : SUCCESS ===
> ok
> Test Edit the Display name Through the UI. ... SKIP: skip
> Test Unsupported chars in the display name ... SKIP: skip
> Test the instance  name with hyphens ... === TestName: 
> test_instance_name_with_hyphens | Status : SUCCESS ===
> ok
> @Desc: Test whether cloudstack allows duplicate vm instance names in the diff 
> networks ... === TestName: test_vm_instance_name_duplicate_different_accounts 
> | Status :
> FAILED ===
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25392: CLOUDSTACK-7434: Fixed VM Internal name issue in test_custom_hostname.py

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25392/#review52587
---


pushed to master 40a537fedcbb8c088875ef222c950213909df7f8

- SrikanteswaraRao Talluri


On Sept. 5, 2014, 3:53 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25392/
> ---
> 
> (Updated Sept. 5, 2014, 3:53 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7434
> https://issues.apache.org/jira/browse/CLOUDSTACK-7434
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> 1.Corrected the VM internal name formation. The last part of the internal 
> name is value of "instance.name" from global settings and not the display 
> name of the VM.
> 2.Added missing cleanup items.
> 3.Removed test script which caused other test cases to fail.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_custom_hostname.py 22dbaf5 
> 
> Diff: https://reviews.apache.org/r/25392/diff/
> 
> 
> Testing
> ---
> 
> Yes. Tested on VMware setup.
> Out of 5 test cases which were run, 1 test case is still failing because of 
> other reason. Need to look at that one seperately.
> 
> Log:
> Verify user provided hostname to an instance ... === TestName: 
> test_01_user_provided_hostname | Status : SUCCESS ===
> ok
> Verify for globally set instancename ... === TestName: 
> test_02_instancename_from_default_configuration | Status : SUCCESS ===
> ok
> Test the duplicate name when old VM is in non-expunged state ... === 
> TestName: test_03_duplicate_name | Status : SUCCESS ===
> ok
> Test Edit the Display name Through the UI. ... SKIP: skip
> Test Unsupported chars in the display name ... SKIP: skip
> Test the instance  name with hyphens ... === TestName: 
> test_instance_name_with_hyphens | Status : SUCCESS ===
> ok
> @Desc: Test whether cloudstack allows duplicate vm instance names in the diff 
> networks ... === TestName: test_vm_instance_name_duplicate_different_accounts 
> | Status :
> FAILED ===
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Jenkins build is back to normal : build-master-simulator #548

[jenkins]

See 

Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25433/
---

Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7509
https://issues.apache.org/jira/browse/CLOUDSTACK-7509


Repository: cloudstack-git


Description
---

Bound method for copyTemplate was missing in library, hence test cases failed 
during copy operation.


Diffs
-

  tools/marvin/marvin/lib/base.py 982986b 

Diff: https://reviews.apache.org/r/25433/diff/


Testing
---

Yes.

Log:
Test copy template between zones ... === TestName: 
test_04_copy_template_1_root_domain_admin | Status : SUCCESS ===
ok

--
Ran 1 test in 427.374s

OK


Thanks,

Gaurav Aradhye

Jenkins build is still unstable: simulator-singlerun #316

[jenkins]

See 

[GitHub] cloudstack-docs-admin pull request: accounts: document SAML authen...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/19

accounts: document SAML authentication

This adds some documentation on how to use the SAML auth plugin.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bhaisaab/cloudstack-docs-admin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #19


commit daa3b34a3f66b78f3abf3039e55c444167cfbed5
Author: Rohit Yadav 
Date:   2014-09-08T13:02:25Z

accounts: document SAML authentication

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 25436: CLOUDSTACK-7393: Removing dependency on wait period from test case

[Gaurav Aradhye]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25436/
---

Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7393
https://issues.apache.org/jira/browse/CLOUDSTACK-7393


Repository: cloudstack-git


Description
---

The VM was destroyed (not expunged) and wait period was added.
Instead expunged it immediately and removed the wait period.


Diffs
-

  test/integration/component/test_vpc_vm_life_cycle.py 8fc6d62 

Diff: https://reviews.apache.org/r/25436/diff/


Testing
---


Thanks,

Gaurav Aradhye

Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Ilia Shakitko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/
---

Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng Yang.


Bugs: CLOUDSTACK-7159
https://issues.apache.org/jira/browse/CLOUDSTACK-7159


Repository: cloudstack-git


Description
---

Working with Usage server and usage records very often I need to get only 
records for that particular usage ID. For example when filtering out 
network_bytes_received/sent with big amount of data it's not very fast to 
process hundreds of objects looking for the only one you need.
It would be useful to have an ability to filter out usage records only for 
specific resource ID.

This parch brings that to the API.


Diffs
-

  api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
  api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
21a7e4a 
  server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 

Diff: https://reviews.apache.org/r/25435/diff/


Testing
---

Tested cases:
- usageid is specified w/o "type": an exception is thrown (correct)
- provided usageid is not exists: an empty response is returned (since no 
records were found, correct)
- no usageid specified: work as is
- an existing usageid specified (with type, for example type=4 or type=5): only 
records for that usage type is returned


Thanks,

Ilia Shakitko

Jenkins build is still unstable: simulator-singlerun #317

[jenkins]

See 

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Rohit Yadav]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


Thanks for this minor features, I can think of many people using it. Please see 
my review.


api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java


Does this cause any issue? I would avoid this though there is no much 
different, long will occupy some more bytes than Int, but it would require us 
to note change in the API.



api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java


If this is going to be UUID, please use the CommandType.UUID?



server/src/com/cloud/usage/UsageServiceImpl.java


Avoid wildcard imports, dao.* here.



server/src/com/cloud/usage/UsageServiceImpl.java


have all the case block in separate lines, improves readability.
like:
switch (var) {
case 1:
case 2:
case 3:


... etc

}


- Rohit Yadav


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Re: Review Request 25430: live migration is failing for vm deployed using dynaic compute offerings with NPE

[bharat kumar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25430/
---

(Updated Sept. 8, 2014, 1:55 p.m.)


Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, edison su, 
Koushik Das, Mike Tutkowski, and Nitin Mehta.


Bugs: CLOUDSTACK-6099
https://issues.apache.org/jira/browse/CLOUDSTACK-6099


Repository: cloudstack-git


Description
---

live migration is failing for vm deployed using dynaic compute offerings with 
NPE
https://issues.apache.org/jira/browse/CLOUDSTACK-6099


Diffs
-

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java 8edef77 

Diff: https://reviews.apache.org/r/25430/diff/


Testing
---

Tested live migration on master using xenserver.


Thanks,

bharat kumar

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Ilia Shakitko]

> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 73-74
> > 
> >
> > Does this cause any issue? I would avoid this though there is no much 
> > different, long will occupy some more bytes than Int, but it would require 
> > us to note change in the API.

1) UsageTypes are Inegers
2) usageRecord.getUsageType() is returning an Integer
3) public void setUsageType(Integer usageType) { ... }

And If I'll change it to Long back, I'll have to either transform usageType 
(here: "switch (usageType)") to an Integer (to support switch, as of usageTypes 
are Integers) or use if-else statements, what I don't like in this particular 
place.

Convinced? :)


- Ilia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Rohit Yadav]

> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 73-74
> > 
> >
> > Does this cause any issue? I would avoid this though there is no much 
> > different, long will occupy some more bytes than Int, but it would require 
> > us to note change in the API.
> 
> Ilia Shakitko wrote:
> 1) UsageTypes are Inegers
> 2) usageRecord.getUsageType() is returning an Integer
> 3) public void setUsageType(Integer usageType) { ... }
> 
> And If I'll change it to Long back, I'll have to either transform 
> usageType (here: "switch (usageType)") to an Integer (to support switch, as 
> of usageTypes are Integers) or use if-else statements, what I don't like in 
> this particular place.
> 
> Convinced? :)

I'm just trying to help you with the review, my opinion is that one should 
avoid changing API signature so either let Java auto-unbox/cast this from Long 
to Integer for you, or fix usage types to Long.


- Rohit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Ilia Shakitko]

> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 73-74
> > 
> >
> > Does this cause any issue? I would avoid this though there is no much 
> > different, long will occupy some more bytes than Int, but it would require 
> > us to note change in the API.
> 
> Ilia Shakitko wrote:
> 1) UsageTypes are Inegers
> 2) usageRecord.getUsageType() is returning an Integer
> 3) public void setUsageType(Integer usageType) { ... }
> 
> And If I'll change it to Long back, I'll have to either transform 
> usageType (here: "switch (usageType)") to an Integer (to support switch, as 
> of usageTypes are Integers) or use if-else statements, what I don't like in 
> this particular place.
> 
> Convinced? :)
> 
> Rohit Yadav wrote:
> I'm just trying to help you with the review, my opinion is that one 
> should avoid changing API signature so either let Java auto-unbox/cast this 
> from Long to Integer for you, or fix usage types to Long.

If I will change UsageTypes to Long it will be more impact. But anyway, if it 
is required I'll add a cast to Integer, which I don't like of course.


- Ilia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Ilia Shakitko]

> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 73-74
> > 
> >
> > Does this cause any issue? I would avoid this though there is no much 
> > different, long will occupy some more bytes than Int, but it would require 
> > us to note change in the API.
> 
> Ilia Shakitko wrote:
> 1) UsageTypes are Inegers
> 2) usageRecord.getUsageType() is returning an Integer
> 3) public void setUsageType(Integer usageType) { ... }
> 
> And If I'll change it to Long back, I'll have to either transform 
> usageType (here: "switch (usageType)") to an Integer (to support switch, as 
> of usageTypes are Integers) or use if-else statements, what I don't like in 
> this particular place.
> 
> Convinced? :)
> 
> Rohit Yadav wrote:
> I'm just trying to help you with the review, my opinion is that one 
> should avoid changing API signature so either let Java auto-unbox/cast this 
> from Long to Integer for you, or fix usage types to Long.
> 
> Ilia Shakitko wrote:
> If I will change UsageTypes to Long it will be more impact. But anyway, 
> if it is required I'll add a cast to Integer, which I don't like of course.

It is an integer everywhere, but in command parameters. I just wanted to make 
it more clear, fixnig the type. But I can leave it as is.


- Ilia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Jenkins build is still unstable: simulator-singlerun #318

[jenkins]

See 

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Rohit Yadav]

> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 73-74
> > 
> >
> > Does this cause any issue? I would avoid this though there is no much 
> > different, long will occupy some more bytes than Int, but it would require 
> > us to note change in the API.
> 
> Ilia Shakitko wrote:
> 1) UsageTypes are Inegers
> 2) usageRecord.getUsageType() is returning an Integer
> 3) public void setUsageType(Integer usageType) { ... }
> 
> And If I'll change it to Long back, I'll have to either transform 
> usageType (here: "switch (usageType)") to an Integer (to support switch, as 
> of usageTypes are Integers) or use if-else statements, what I don't like in 
> this particular place.
> 
> Convinced? :)
> 
> Rohit Yadav wrote:
> I'm just trying to help you with the review, my opinion is that one 
> should avoid changing API signature so either let Java auto-unbox/cast this 
> from Long to Integer for you, or fix usage types to Long.
> 
> Ilia Shakitko wrote:
> If I will change UsageTypes to Long it will be more impact. But anyway, 
> if it is required I'll add a cast to Integer, which I don't like of course.
> 
> Ilia Shakitko wrote:
> It is an integer everywhere, but in command parameters. I just wanted to 
> make it more clear, fixnig the type. But I can leave it as is.

Thanks for checking. To make this consistent, should we make all the APIs 
usageTypes params to Int? Your patch is fine in that case, just fix the uuid 
and other syntax things.


- Rohit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Cloudstack/KVM/arch i686 case reopened

[Laurent Steff]

Hello,

As a lot of our researchers still need "real" 32bits CPU support
in KVM/Qemu with CloudStack, we reopened and old bug reported by 
a colleague almost one year ago, without any activity.

https://issues.apache.org/jira/browse/CLOUDSTACK-7511

Tell us if we could help (testing, patch, ...)

Thanks in advance.

Regards,
-- 
Laurent Steff

DSI/SESI
INRIA
http://www.inria.fr/

Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.

[Ilia Shakitko]

> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 73-74
> > 
> >
> > Does this cause any issue? I would avoid this though there is no much 
> > different, long will occupy some more bytes than Int, but it would require 
> > us to note change in the API.
> 
> Ilia Shakitko wrote:
> 1) UsageTypes are Inegers
> 2) usageRecord.getUsageType() is returning an Integer
> 3) public void setUsageType(Integer usageType) { ... }
> 
> And If I'll change it to Long back, I'll have to either transform 
> usageType (here: "switch (usageType)") to an Integer (to support switch, as 
> of usageTypes are Integers) or use if-else statements, what I don't like in 
> this particular place.
> 
> Convinced? :)
> 
> Rohit Yadav wrote:
> I'm just trying to help you with the review, my opinion is that one 
> should avoid changing API signature so either let Java auto-unbox/cast this 
> from Long to Integer for you, or fix usage types to Long.
> 
> Ilia Shakitko wrote:
> If I will change UsageTypes to Long it will be more impact. But anyway, 
> if it is required I'll add a cast to Integer, which I don't like of course.
> 
> Ilia Shakitko wrote:
> It is an integer everywhere, but in command parameters. I just wanted to 
> make it more clear, fixnig the type. But I can leave it as is.
> 
> Rohit Yadav wrote:
> Thanks for checking. To make this consistent, should we make all the APIs 
> usageTypes params to Int? Your patch is fine in that case, just fix the uuid 
> and other syntax things.

> should we make all the APIs usageTypes params to Int

I don't think I get you correctly. UsageTypes.java had all the usage types 
Integers. 

Meanwhile I almost finished the second revision of patch with "Long" type used. 
Then I just do intVal().


> On Sept. 8, 2014, 1:52 p.m., Rohit Yadav wrote:
> > api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java,
> >  lines 76-77
> > 
> >
> > If this is going to be UUID, please use the CommandType.UUID?

In this case I'll be forced to use entityType = Response.class in the 
@parameter. But here I can't explicitly set it because it's dependant on the 
usageType is provided. And then I use SWITCH block to determine where to check 
on the usageid existance. That's why I used String for that parameter. I've 
also seen few places where UUID parameter is being accepted as String. 
Probably, to achieve same kind of goal.


- Ilia


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52591
---


On Sept. 8, 2014, 1:45 p.m., Ilia Shakitko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> ---
> 
> (Updated Sept. 8, 2014, 1:45 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng 
> Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
> https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Working with Usage server and usage records very often I need to get only 
> records for that particular usage ID. For example when filtering out 
> network_bytes_received/sent with big amount of data it's not very fast to 
> process hundreds of objects looking for the only one you need.
> It would be useful to have an ability to filter out usage records only for 
> specific resource ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   
> api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 
> 21a7e4a 
>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> ---
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no 
> records were found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): 
> only records for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>

Re: Cloudstack/KVM/arch i686 case reopened

[Rohit Yadav]

Hi Laurent,

You’re welcome to contribute any work that you’ve already done. Else, you could 
have any developers at INRIA or may sponsor developers to work on this issue 
and the ACS community will be happy to assist them during development, help 
with patches, reviews etc.

I’m curious why your researchers would need “real” 32 bit CPUs support and what 
the use cases are.
One can always run 32bit VMs on 64bit CPU/KVM. Will be happy to help.

On 08-Sep-2014, at 5:13 pm, Laurent Steff  wrote:
> Hello,
>
> As a lot of our researchers still need "real" 32bits CPU support
> in KVM/Qemu with CloudStack, we reopened and old bug reported by
> a colleague almost one year ago, without any activity.
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-7511
>
> Tell us if we could help (testing, patch, ...)
>
> Thanks in advance.
>
> Regards,
> --
> Laurent Steff
>
> DSI/SESI
> INRIA
> http://www.inria.fr/

Regards,
Rohit Yadav
Software Architect, ShapeBlue
M. +41 779015219 | rohit.ya...@shapeblue.com
Blog: bhaisaab.org | Twitter: @_bhaisaab



Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build
CSForge – rapid IaaS deployment framework
CloudStack Consulting
CloudStack Infrastructure 
Support
CloudStack Bootcamp Training Courses

This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error. Shape Blue Ltd is a company 
incorporated in England & Wales. ShapeBlue Services India LLP is a company 
incorporated in India and is operated under license from Shape Blue Ltd. Shape 
Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is 
operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company 
registered by The Republic of South Africa and is traded under license from 
Shape Blue Ltd. ShapeBlue is a registered trademark.

Jenkins build is still unstable: simulator-singlerun #319

[jenkins]

See 

Re: Review Request 22712: This Test suite has test cases relating to acess checks for deleteNetwork() for Admin, domain admin and regular users

[sangeetha hariharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22712/
---

(Updated Sept. 8, 2014, 7:52 p.m.)


Review request for cloudstack, Min Chen, Prachi Damle, and Santhosh Edukulla.


Changes
---

Moved out the data used by test suite from Sevices object with in the test 
suite to test_data.py
Changed the tags for test cases - required_hardware="false" to be picked up by 
simulator runs.


Repository: cloudstack-git


Description
---

This Test suite has test cases relating to acess checks for deleteNetwork() for 
Admin, domain admin and regular users


Diffs (updated)
-

  test/integration/component/test_acl_isolatednetwork_delete.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22712/diff/


Testing (updated)
---

Test Suite was executed against a management server built from 4.4-forward 
branch using a simulator set up:
test_deleteNetwork_admin 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_admin | Status : SUCCESS ===
ok
test_deleteNetwork_admin_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_admin_foruserinotherdomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_admin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_admin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_domaindmin 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin | Status : SUCCESS ===
ok
test_deleteNetwork_domaindmin_forcrossdomainuser 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin_forcrossdomainuser | Status : 
SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin_foruserinsamedomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_domaindmin_foruserinsubdomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_domaindmin_foruserinsubdomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_user 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_user | Status : SUCCESS ===
ok
test_deleteNetwork_user_foruserinotherdomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_user_foruserinotherdomain | Status : 
SUCCESS ===
ok
test_deleteNetwork_user_foruserinsamedomain 
(integration.component.test_acl_isolatednetwork_delete.TestIsolatedNetworkDelete)
 ... === TestName: test_deleteNetwork_user_foruserinsamedomain | Status : 
SUCCESS ===
ok

--
Ran 10 tests in 61.766s

OK


Thanks,

sangeetha hariharan

Jenkins build is still unstable: simulator-singlerun #320

[jenkins]

See 

Re: [ACS431] Help testing 4.3.1 vote candidate

[Sebastien Goasguen]

This was mentioned off-list as a blocker:

https://issues.apache.org/jira/browse/CLOUDSTACK-6624

It was fixed by Rohit right away.

I am fine canceling the current vote (since there has not been many votes or 
clear testers).

I will wait till tomorrow morning Europe time, if no-one objects to the 
cancellation, I will cancel and re-launch a vote which will contain the 6624 
fix.


-sebastien

On Sep 5, 2014, at 11:52 AM, sebgoa  wrote:

> I cancelled the first round and started a second round.
> 
> It brings in a debian/changelog change for building debs
> plus a tiny bug fix for 7404 that arrived after the first round started:
> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=c1bf7eb3bd4dad384225d411e21859cce470
> 
> 
> 
> 
> On Sep 5, 2014, at 2:37 PM, sebgoa  wrote:
> 
>> 
>> On Sep 5, 2014, at 1:38 PM, Harikrishna Patnala 
>>  wrote:
>> 
>>> Yes the available 4.3 system vm templates on jenkins are post heart bleed.
>>> 
>>> -Harikrishna
>>> 
>> 
>> Any chance you can check why the 4.3 systemvm jobs are failing on 
>> jenkins.buildacloud.org ?
>> 
>>> 
>>> On 05-Sep-2014, at 12:59 pm, Sebastien Goasguen 
>>> mailto:run...@gmail.com>> wrote:
>>> 
>>> 
>>> On Sep 4, 2014, at 5:25 PM, Rohit Yadav 
>>> mailto:rohit.ya...@shapeblue.com>> wrote:
>>> 
>>> FYI, the deb/rpm repo I shared hosts noredist/nonoss builds.
>>> 
>>> On 04-Sep-2014, at 11:14 pm, ilya musayev 
>>> mailto:ilya.mailing.li...@gmail.com>> wrote:
>>> Ack, will be trying later tonight.
>>> 
>>> Thanks Ilya. Please also test if you are able to download volumes on 
>>> 4.3.0/ESX as well.
>>> 
>>> SystemVMs can be downloaded from: http://jenkins.buildacloud.org/view/4.3
>>> They are failing for some issue now, you may use 4.3.0 or the last 
>>> successful builds from the above link.
>>> 
>>> @Sebastien, @Hugo: can we do something about the failing systemvm builds?
>>> 
>>> 
>>> we need to check if the ones on jenkins are even the right ones, since 4.3 
>>> was released before heart bleed…
>>> 
>>> I don't recall the exact dates and don't really pay attention to system 
>>> discussions :(
>>> 
>>> Regards,
>>> Rohit Yadav
>>> Software Architect, ShapeBlue
>>> M. +41 779015219 | 
>>> rohit.ya...@shapeblue.com
>>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>>> 
>>> Find out more about ShapeBlue and our range of CloudStack related services
>>> 
>>> IaaS Cloud Design & 
>>> Build
>>> CSForge – rapid IaaS deployment framework
>>> CloudStack Consulting
>>> CloudStack Infrastructure 
>>> Support
>>> CloudStack Bootcamp Training 
>>> Courses
>>> 
>>> This email and any attachments to it may be confidential and are intended 
>>> solely for the use of the individual to whom it is addressed. Any views or 
>>> opinions expressed are solely those of the author and do not necessarily 
>>> represent those of Shape Blue Ltd or related companies. If you are not the 
>>> intended recipient of this email, you must neither take any action based 
>>> upon its contents, nor copy or show it to anyone. Please contact the sender 
>>> if you believe you have received this email in error. Shape Blue Ltd is a 
>>> company incorporated in England & Wales. ShapeBlue Services India LLP is a 
>>> company incorporated in India and is operated under license from Shape Blue 
>>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil 
>>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is 
>>> a company registered by The Republic of South Africa and is traded under 
>>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>>> 
>> 
> 

Jenkins build is still unstable: simulator-singlerun #321

[jenkins]

See 

Re: Review Request 22707: Test suite contains test cases relating to access checks for listSnapshot() with parameters - id, listall, isrecursive, account and domainid executed as ROOT admin, domain ad

[sangeetha hariharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22707/
---

(Updated Sept. 9, 2014, 12:27 a.m.)


Review request for cloudstack, edison su, Min Chen, Prachi Damle, and Santhosh 
Edukulla.


Changes
---

Move data used by test cases from services object with in the test suite to the 
common config file - test_data.py
Changed the tags of the test cases to - required_hardware="false" so that they 
get picked up as part of simulator runs


Repository: cloudstack-git


Description
---

This test suite contains test cases relating to access checks for 
listSnapshot() with parameters - id,listall,isrecursive,account and domainid 
executed as ROOT admin,domain admin and regular users.


Diffs (updated)
-

  test/integration/component/test_acl_listsnapshot.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22707/diff/


Testing (updated)
---

test_listSnapshot_as_domainadmin 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_cross_domainid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_cross_domainid | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_cross_domainid_accountid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_cross_domainid_accountid | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid | Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_listall_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_listall_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: 
test_listSnapshot_as_domainadmin_domainid_accountid_listall_true_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_accountid_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_accountid_rec_true | Status 
: SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false_rec_false 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false_rec_false | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_false_rec_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_false_rec_true | 
Status : SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listall_true 
(integration.component.test_acl_listsnapshot.TestSnapshotList) ... === 
TestName: test_listSnapshot_as_domainadmin_domainid_listall_true | Status : 
SUCCESS ===
ok
test_listSnapshot_as_domainadmin_domainid_listal

Re: S3/Swift Problem around Virtual Size

[Mike Tutkowski]

Hi Punith,

Have you been able to make any progress with regards to this Swift/S3 issue?

Thanks!
Mike

On Wed, Aug 27, 2014 at 7:43 AM, Punith S  wrote:

> hi
>
> think i had a timeout problem!
> on the second try the template has been downloaded to the S3 bucket and
> the management server shows the status as download complete with template
> size as 1.6G instead of its virtual size 20G.
>
> and i see the template's status as Download Complete but it seems it is
> not getting installed ! refer the attachment
>
> can anyone explain the "installing template" after the download completes ?
>
>
> On Wed, Aug 27, 2014 at 9:18 AM, Marcus  wrote:
>
>> Per Edisons comments about not knowing the image size, can't we just set
>> some headers and store metadata with the template in S3 to save the
>> virtual
>> size when the template is registered? I'm assuming here that the SSVM does
>> the work of pulling the template in and uploading to S3. Or it could be
>> stored in the template table?
>> On Aug 26, 2014 9:11 PM, "Francois Gaudreault" 
>> wrote:
>>
>> > Looks like your SSVM cannot reach Internet properly?
>> >
>> > FG
>> >
>> > On 2014-08-26, 11:14 AM, Punith S wrote:
>> >
>> >> hi francois,
>> >>
>> >> since i'm not having a swift setup, i'm using the s3 bucket.
>> >>
>> >> and as you recommended i got the SSVM up with seeded nfs storage,
>> >>
>> >> post that i removed the nfs secondary storage and added the S3 with
>> >> staging nfs store as the new sec storage, since you cannot have any nfs
>> >> secondary storage while using the S3.
>> >>
>> >> on registering the a new template, i'm getting template status
>> as*Unable
>> >> to execute HTTP request: No route to host*
>> >> in managementserver.log
>> >>
>> >> 2014-08-26 20:41:07,502 DEBUG [o.a.c.s.RemoteHostEndPoint]
>> >> (Timer-24:ctx-b68380cd) Sending command org.apache.cloudstack.storage.
>> >> command.DownloadProgressCommand to host: 10
>> >> 2014-08-26 20:41:07,507 DEBUG [c.c.a.t.Request] (Timer-24:ctx-b68380cd)
>> >> Seq 10-5684105679694996125: Sending  { Cmd , MgmtId: 52242179434, via:
>> >> 10(s-142-VM), Ver: v1, Flags: 100011, [{"org.apache.cloudstack.
>> >> storage.command.DownloadProgressCommand":{"jobId":"d43a17c9-3b03-4ff9-
>> >> 8906-e1d155981e86","request":"GET_STATUS","hvm":true,"
>> >> description":"centext","maxDownloadSizeInBytes":53687091200,"id":209,"
>> >> resourceType":"TEMPLATE","installPath":"template/tmpl/2/
>> >> 209/209-2-b624436c-5f37-30d4-8eaf-81582eb0d39d","_store":{"
>> >> com.cloud.agent.api.to.S3TO":{"id":14,"uuid":"e4afd7bb-39ea-
>> >> 4128-ab93-f8a09b1d5e03","bucketName":"test-cloudstack",
>> >> "httpsFlag":false,"created":"Aug 26, 2014 8:16:24
>> PM","enableRRS":false,"
>> >> maxSingleUploadSizeInBytes":5368709120}},"url":"http://
>> >> download.cloud.com/templates/builtin/centos56-x86_64.vhd.bz2
>> >>
>> ","format":"VHD","accountId":2,"name":"209-2-b624436c-5f37-30d4-8eaf-81582eb0d39d","wait":0}}]
>> >> }
>> >> 2014-08-26 20:41:07,556 DEBUG [c.c.a.t.Request]
>> >> (AgentManager-Handler-10:null) Seq 10-5684105679694996125:
>> Processing:  {
>> >> Ans: , MgmtId: 52242179434, via: 10, Ver: v1, Flags: 10,
>> >> [{"com.cloud.agent.api.storage.DownloadAnswer":{"
>> >> jobId":"d43a17c9-3b03-4ff9-8906-e1d155981e86","
>> >> downloadPct":0,"errorString":"No route to host","downloadStatus":"
>> >> DOWNLOAD_ERROR","installPath":"template/tmpl/2/209/209-2-
>> >> b624436c-5f37-30d4-8eaf-81582eb0d39d","templateSize":
>> >> 0,"templatePhySicalSize":0,"result":true,"details":"No route to
>> >> host","wait":0}}] }
>> >>
>> >> but i don't see any logging happening in secondary storage vm's
>> cloud.log
>> >>
>> >> not sure this error is happening due to S3!
>> >>
>> >>
>> >> thanks!
>> >>
>> >
>> >
>> > --
>> > Francois Gaudreault
>> > Gestionnaire de Produit | Product Manager - Cloud Platform & Services
>> > t:514-629-6775
>> >
>> > CloudOps Votre partenaire infonuagique | Cloud Solutions Experts
>> > 420 rue Guy | Montreal | Quebec | H3J 1S6
>> > w: cloudops.com | tw: @CloudOps_
>> >
>> >
>>
>
>
>
> --
> regards,
>
> punith s
> cloudbyte.com
>



-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

Re: S3/Swift Problem around Virtual Size

[Punith S]

hi mike,

i have figured out the issue, in NFS secondary storage the virtual size is
been calculated by the VHD Processor by accessing the vhd template.

but in case of S3, cloudstack is not able to access the template but it
only gets to know the physical size of the template!

in order to solve this, we need to download the template from S3 to another
secondary nfs storage and access the template to calculate the virtual size.

if the above solution seems to be complicated, we shall have a quick fix
where virtual size i.e the size of the SAN volume shall be created(like
small-20g, medium-40g) for people using the templates from S3.

any feedback's ?



On Tue, Sep 9, 2014 at 6:34 AM, Mike Tutkowski  wrote:

> Hi Punith,
>
> Have you been able to make any progress with regards to this Swift/S3
> issue?
>
> Thanks!
> Mike
>
> On Wed, Aug 27, 2014 at 7:43 AM, Punith S  wrote:
>
> > hi
> >
> > think i had a timeout problem!
> > on the second try the template has been downloaded to the S3 bucket and
> > the management server shows the status as download complete with template
> > size as 1.6G instead of its virtual size 20G.
> >
> > and i see the template's status as Download Complete but it seems it is
> > not getting installed ! refer the attachment
> >
> > can anyone explain the "installing template" after the download
> completes ?
> >
> >
> > On Wed, Aug 27, 2014 at 9:18 AM, Marcus  wrote:
> >
> >> Per Edisons comments about not knowing the image size, can't we just set
> >> some headers and store metadata with the template in S3 to save the
> >> virtual
> >> size when the template is registered? I'm assuming here that the SSVM
> does
> >> the work of pulling the template in and uploading to S3. Or it could be
> >> stored in the template table?
> >> On Aug 26, 2014 9:11 PM, "Francois Gaudreault" <
> fgaudrea...@cloudops.com>
> >> wrote:
> >>
> >> > Looks like your SSVM cannot reach Internet properly?
> >> >
> >> > FG
> >> >
> >> > On 2014-08-26, 11:14 AM, Punith S wrote:
> >> >
> >> >> hi francois,
> >> >>
> >> >> since i'm not having a swift setup, i'm using the s3 bucket.
> >> >>
> >> >> and as you recommended i got the SSVM up with seeded nfs storage,
> >> >>
> >> >> post that i removed the nfs secondary storage and added the S3 with
> >> >> staging nfs store as the new sec storage, since you cannot have any
> nfs
> >> >> secondary storage while using the S3.
> >> >>
> >> >> on registering the a new template, i'm getting template status
> >> as*Unable
> >> >> to execute HTTP request: No route to host*
> >> >> in managementserver.log
> >> >>
> >> >> 2014-08-26 20:41:07,502 DEBUG [o.a.c.s.RemoteHostEndPoint]
> >> >> (Timer-24:ctx-b68380cd) Sending command
> org.apache.cloudstack.storage.
> >> >> command.DownloadProgressCommand to host: 10
> >> >> 2014-08-26 20:41:07,507 DEBUG [c.c.a.t.Request]
> (Timer-24:ctx-b68380cd)
> >> >> Seq 10-5684105679694996125: Sending  { Cmd , MgmtId: 52242179434,
> via:
> >> >> 10(s-142-VM), Ver: v1, Flags: 100011, [{"org.apache.cloudstack.
> >> >>
> storage.command.DownloadProgressCommand":{"jobId":"d43a17c9-3b03-4ff9-
> >> >> 8906-e1d155981e86","request":"GET_STATUS","hvm":true,"
> >> >>
> description":"centext","maxDownloadSizeInBytes":53687091200,"id":209,"
> >> >> resourceType":"TEMPLATE","installPath":"template/tmpl/2/
> >> >> 209/209-2-b624436c-5f37-30d4-8eaf-81582eb0d39d","_store":{"
> >> >> com.cloud.agent.api.to.S3TO":{"id":14,"uuid":"e4afd7bb-39ea-
> >> >> 4128-ab93-f8a09b1d5e03","bucketName":"test-cloudstack",
> >> >> "httpsFlag":false,"created":"Aug 26, 2014 8:16:24
> >> PM","enableRRS":false,"
> >> >> maxSingleUploadSizeInBytes":5368709120}},"url":"http://
> >> >> download.cloud.com/templates/builtin/centos56-x86_64.vhd.bz2
> >> >>
> >>
> ","format":"VHD","accountId":2,"name":"209-2-b624436c-5f37-30d4-8eaf-81582eb0d39d","wait":0}}]
> >> >> }
> >> >> 2014-08-26 20:41:07,556 DEBUG [c.c.a.t.Request]
> >> >> (AgentManager-Handler-10:null) Seq 10-5684105679694996125:
> >> Processing:  {
> >> >> Ans: , MgmtId: 52242179434, via: 10, Ver: v1, Flags: 10,
> >> >> [{"com.cloud.agent.api.storage.DownloadAnswer":{"
> >> >> jobId":"d43a17c9-3b03-4ff9-8906-e1d155981e86","
> >> >> downloadPct":0,"errorString":"No route to host","downloadStatus":"
> >> >> DOWNLOAD_ERROR","installPath":"template/tmpl/2/209/209-2-
> >> >> b624436c-5f37-30d4-8eaf-81582eb0d39d","templateSize":
> >> >> 0,"templatePhySicalSize":0,"result":true,"details":"No route to
> >> >> host","wait":0}}] }
> >> >>
> >> >> but i don't see any logging happening in secondary storage vm's
> >> cloud.log
> >> >>
> >> >> not sure this error is happening due to S3!
> >> >>
> >> >>
> >> >> thanks!
> >> >>
> >> >
> >> >
> >> > --
> >> > Francois Gaudreault
> >> > Gestionnaire de Produit | Product Manager - Cloud Platform & Services
> >> > t:514-629-6775
> >> >
> >> > CloudOps Votre partenaire infonuagique | Cloud Solutions Experts
> >> > 420 rue Guy | Montreal | Quebec | H3J 1S6
> >> > w: cloudops.com | tw: @CloudOps_
> >

Re: S3/Swift Problem around Virtual Size

[Mike Tutkowski]

Hi Punith,

Thanks for putting in time on this!

So, option 1 occurs after we download the template to S3 or Swift. We then
have to copy it to NFS so that we can determine the virtual size?
Relatively slow, but it would work.

If we went this route, would we then delete that template from the NFS
share since its immediate purpose was so we could figure out the virtual
size or would we leave it on that share?

Option 2 is to allow the user who uploads such a template to specify the
size needed for the root disk (i.e. at least the virtual size of the
template...perhaps larger)?

Does that sound like I understood the options?

Thanks!
Mike

On Mon, Sep 8, 2014 at 10:34 PM, Punith S  wrote:

> hi mike,
>
> i have figured out the issue, in NFS secondary storage the virtual size is
> been calculated by the VHD Processor by accessing the vhd template.
>
> but in case of S3, cloudstack is not able to access the template but it
> only gets to know the physical size of the template!
>
> in order to solve this, we need to download the template from S3 to
> another secondary nfs storage and access the template to calculate the
> virtual size.
>
> if the above solution seems to be complicated, we shall have a quick fix
> where virtual size i.e the size of the SAN volume shall be created(like
> small-20g, medium-40g) for people using the templates from S3.
>
> any feedback's ?
>
>
>
> On Tue, Sep 9, 2014 at 6:34 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> Hi Punith,
>>
>> Have you been able to make any progress with regards to this Swift/S3
>> issue?
>>
>> Thanks!
>> Mike
>>
>> On Wed, Aug 27, 2014 at 7:43 AM, Punith S  wrote:
>>
>> > hi
>> >
>> > think i had a timeout problem!
>> > on the second try the template has been downloaded to the S3 bucket and
>> > the management server shows the status as download complete with
>> template
>> > size as 1.6G instead of its virtual size 20G.
>> >
>> > and i see the template's status as Download Complete but it seems it is
>> > not getting installed ! refer the attachment
>> >
>> > can anyone explain the "installing template" after the download
>> completes ?
>> >
>> >
>> > On Wed, Aug 27, 2014 at 9:18 AM, Marcus  wrote:
>> >
>> >> Per Edisons comments about not knowing the image size, can't we just
>> set
>> >> some headers and store metadata with the template in S3 to save the
>> >> virtual
>> >> size when the template is registered? I'm assuming here that the SSVM
>> does
>> >> the work of pulling the template in and uploading to S3. Or it could be
>> >> stored in the template table?
>> >> On Aug 26, 2014 9:11 PM, "Francois Gaudreault" <
>> fgaudrea...@cloudops.com>
>> >> wrote:
>> >>
>> >> > Looks like your SSVM cannot reach Internet properly?
>> >> >
>> >> > FG
>> >> >
>> >> > On 2014-08-26, 11:14 AM, Punith S wrote:
>> >> >
>> >> >> hi francois,
>> >> >>
>> >> >> since i'm not having a swift setup, i'm using the s3 bucket.
>> >> >>
>> >> >> and as you recommended i got the SSVM up with seeded nfs storage,
>> >> >>
>> >> >> post that i removed the nfs secondary storage and added the S3 with
>> >> >> staging nfs store as the new sec storage, since you cannot have any
>> nfs
>> >> >> secondary storage while using the S3.
>> >> >>
>> >> >> on registering the a new template, i'm getting template status
>> >> as*Unable
>> >> >> to execute HTTP request: No route to host*
>> >> >> in managementserver.log
>> >> >>
>> >> >> 2014-08-26 20:41:07,502 DEBUG [o.a.c.s.RemoteHostEndPoint]
>> >> >> (Timer-24:ctx-b68380cd) Sending command
>> org.apache.cloudstack.storage.
>> >> >> command.DownloadProgressCommand to host: 10
>> >> >> 2014-08-26 20:41:07,507 DEBUG [c.c.a.t.Request]
>> (Timer-24:ctx-b68380cd)
>> >> >> Seq 10-5684105679694996125: Sending  { Cmd , MgmtId: 52242179434,
>> via:
>> >> >> 10(s-142-VM), Ver: v1, Flags: 100011, [{"org.apache.cloudstack.
>> >> >>
>> storage.command.DownloadProgressCommand":{"jobId":"d43a17c9-3b03-4ff9-
>> >> >> 8906-e1d155981e86","request":"GET_STATUS","hvm":true,"
>> >> >>
>> description":"centext","maxDownloadSizeInBytes":53687091200,"id":209,"
>> >> >> resourceType":"TEMPLATE","installPath":"template/tmpl/2/
>> >> >> 209/209-2-b624436c-5f37-30d4-8eaf-81582eb0d39d","_store":{"
>> >> >> com.cloud.agent.api.to.S3TO":{"id":14,"uuid":"e4afd7bb-39ea-
>> >> >> 4128-ab93-f8a09b1d5e03","bucketName":"test-cloudstack",
>> >> >> "httpsFlag":false,"created":"Aug 26, 2014 8:16:24
>> >> PM","enableRRS":false,"
>> >> >> maxSingleUploadSizeInBytes":5368709120}},"url":"http://
>> >> >> download.cloud.com/templates/builtin/centos56-x86_64.vhd.bz2
>> >> >>
>> >>
>> ","format":"VHD","accountId":2,"name":"209-2-b624436c-5f37-30d4-8eaf-81582eb0d39d","wait":0}}]
>> >> >> }
>> >> >> 2014-08-26 20:41:07,556 DEBUG [c.c.a.t.Request]
>> >> >> (AgentManager-Handler-10:null) Seq 10-5684105679694996125:
>> >> Processing:  {
>> >> >> Ans: , MgmtId: 52242179434, via: 10, Ver: v1, Flags: 10,
>> >> >> [{"com.cloud.agent.api.storage.DownloadAnswer":{"
>> >> >> jobId

Re: S3/Swift Problem around Virtual Size

[Will Stevens]

My two cents on the topic.

Ideally we would save the size in the object store metadata and retrieve it
from the metadata if it is set.  If it is not set in the object store
metadata, then when it is fetched, we have to put it on NFS and determine
the size (then ideally save the metadata back to the object store) and
remove the NFS copy.

This way the NFS copy approach is only ever done once and then the data is
populated (for backwards compatibility).  For all templates created after
the patch, the metadata would be stored and retrieved without the need for
the NFS copy.

Is this feasible?

Will


*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Tue, Sep 9, 2014 at 12:48 AM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Hi Punith,
>
> Thanks for putting in time on this!
>
> So, option 1 occurs after we download the template to S3 or Swift. We then
> have to copy it to NFS so that we can determine the virtual size?
> Relatively slow, but it would work.
>
> If we went this route, would we then delete that template from the NFS
> share since its immediate purpose was so we could figure out the virtual
> size or would we leave it on that share?
>
> Option 2 is to allow the user who uploads such a template to specify the
> size needed for the root disk (i.e. at least the virtual size of the
> template...perhaps larger)?
>
> Does that sound like I understood the options?
>
> Thanks!
> Mike
>
> On Mon, Sep 8, 2014 at 10:34 PM, Punith S  wrote:
>
> > hi mike,
> >
> > i have figured out the issue, in NFS secondary storage the virtual size
> is
> > been calculated by the VHD Processor by accessing the vhd template.
> >
> > but in case of S3, cloudstack is not able to access the template but it
> > only gets to know the physical size of the template!
> >
> > in order to solve this, we need to download the template from S3 to
> > another secondary nfs storage and access the template to calculate the
> > virtual size.
> >
> > if the above solution seems to be complicated, we shall have a quick fix
> > where virtual size i.e the size of the SAN volume shall be created(like
> > small-20g, medium-40g) for people using the templates from S3.
> >
> > any feedback's ?
> >
> >
> >
> > On Tue, Sep 9, 2014 at 6:34 AM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> >> Hi Punith,
> >>
> >> Have you been able to make any progress with regards to this Swift/S3
> >> issue?
> >>
> >> Thanks!
> >> Mike
> >>
> >> On Wed, Aug 27, 2014 at 7:43 AM, Punith S 
> wrote:
> >>
> >> > hi
> >> >
> >> > think i had a timeout problem!
> >> > on the second try the template has been downloaded to the S3 bucket
> and
> >> > the management server shows the status as download complete with
> >> template
> >> > size as 1.6G instead of its virtual size 20G.
> >> >
> >> > and i see the template's status as Download Complete but it seems it
> is
> >> > not getting installed ! refer the attachment
> >> >
> >> > can anyone explain the "installing template" after the download
> >> completes ?
> >> >
> >> >
> >> > On Wed, Aug 27, 2014 at 9:18 AM, Marcus  wrote:
> >> >
> >> >> Per Edisons comments about not knowing the image size, can't we just
> >> set
> >> >> some headers and store metadata with the template in S3 to save the
> >> >> virtual
> >> >> size when the template is registered? I'm assuming here that the SSVM
> >> does
> >> >> the work of pulling the template in and uploading to S3. Or it could
> be
> >> >> stored in the template table?
> >> >> On Aug 26, 2014 9:11 PM, "Francois Gaudreault" <
> >> fgaudrea...@cloudops.com>
> >> >> wrote:
> >> >>
> >> >> > Looks like your SSVM cannot reach Internet properly?
> >> >> >
> >> >> > FG
> >> >> >
> >> >> > On 2014-08-26, 11:14 AM, Punith S wrote:
> >> >> >
> >> >> >> hi francois,
> >> >> >>
> >> >> >> since i'm not having a swift setup, i'm using the s3 bucket.
> >> >> >>
> >> >> >> and as you recommended i got the SSVM up with seeded nfs storage,
> >> >> >>
> >> >> >> post that i removed the nfs secondary storage and added the S3
> with
> >> >> >> staging nfs store as the new sec storage, since you cannot have
> any
> >> nfs
> >> >> >> secondary storage while using the S3.
> >> >> >>
> >> >> >> on registering the a new template, i'm getting template status
> >> >> as*Unable
> >> >> >> to execute HTTP request: No route to host*
> >> >> >> in managementserver.log
> >> >> >>
> >> >> >> 2014-08-26 20:41:07,502 DEBUG [o.a.c.s.RemoteHostEndPoint]
> >> >> >> (Timer-24:ctx-b68380cd) Sending command
> >> org.apache.cloudstack.storage.
> >> >> >> command.DownloadProgressCommand to host: 10
> >> >> >> 2014-08-26 20:41:07,507 DEBUG [c.c.a.t.Request]
> >> (Timer-24:ctx-b68380cd)
> >> >> >> Seq 10-5684105679694996125: Sending  { Cmd , MgmtId: 52242179434,
> >> via:
> >> >> >> 10(s-142-VM), Ver: v1, Flags: 100011, [{"org.apache.cloudstack.
> >> >> >>
> >> storage.command.DownloadProgressC

Re: S3/Swift Problem around Virtual Size

[Mike Tutkowski]

Hi Will,

Thanks for the input!

I like the idea of storing the virtual size as metadata in S3 or Swift
although this could require that the end user provide this value when
uploading the template.

However, if we have the ability to determine the virtual size of the
template after it gets downloaded to (secondary-storage) NFS and we're able
to update the database with this info, then it would seem we would never
need to ask the user for this value.

Either way, the tricky part might be if the template in object storage has
already been downloaded to (secondary-storage) NFS (say it was used
before). In this case, we won't need to download it to (secondary-storage)
NFS again (at least not in the same zone), so we won't have an easy
opportunity to figure out the virtual size upon download from object
storage.

I wonder if it's too late in this process if we figured out the virtual
size before the copied template (now on (secondary-storage) NFS) gets
copied to primary storage. If we could do it at this point, then we
wouldn't have to worry about fixing the "legacy" situation because it would
just work out naturally. We would look in the DB to see if the virtual size
for this template is known and, if not, we could figure out the virtual
size before downloading from (secondary-storage) NFS to primary storage
each time. (Although I'm thinking this would come too late in the process
because we may have already asked the primary-storage plug-in to create the
necessary volume.)

By the way, I'm assuming that a template gets copied to (secondary-storage)
NFS before being copied to primary storage. I'm not super familiar with how
this process works.

Talk to you later,
Mike

On Mon, Sep 8, 2014 at 10:59 PM, Will Stevens  wrote:

> My two cents on the topic.
>
> Ideally we would save the size in the object store metadata and retrieve it
> from the metadata if it is set.  If it is not set in the object store
> metadata, then when it is fetched, we have to put it on NFS and determine
> the size (then ideally save the metadata back to the object store) and
> remove the NFS copy.
>
> This way the NFS copy approach is only ever done once and then the data is
> populated (for backwards compatibility).  For all templates created after
> the patch, the metadata would be stored and retrieved without the need for
> the NFS copy.
>
> Is this feasible?
>
> Will
>
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> w cloudops.com *|* tw @CloudOps_
>
> On Tue, Sep 9, 2014 at 12:48 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
> > Hi Punith,
> >
> > Thanks for putting in time on this!
> >
> > So, option 1 occurs after we download the template to S3 or Swift. We
> then
> > have to copy it to NFS so that we can determine the virtual size?
> > Relatively slow, but it would work.
> >
> > If we went this route, would we then delete that template from the NFS
> > share since its immediate purpose was so we could figure out the virtual
> > size or would we leave it on that share?
> >
> > Option 2 is to allow the user who uploads such a template to specify the
> > size needed for the root disk (i.e. at least the virtual size of the
> > template...perhaps larger)?
> >
> > Does that sound like I understood the options?
> >
> > Thanks!
> > Mike
> >
> > On Mon, Sep 8, 2014 at 10:34 PM, Punith S 
> wrote:
> >
> > > hi mike,
> > >
> > > i have figured out the issue, in NFS secondary storage the virtual size
> > is
> > > been calculated by the VHD Processor by accessing the vhd template.
> > >
> > > but in case of S3, cloudstack is not able to access the template but it
> > > only gets to know the physical size of the template!
> > >
> > > in order to solve this, we need to download the template from S3 to
> > > another secondary nfs storage and access the template to calculate the
> > > virtual size.
> > >
> > > if the above solution seems to be complicated, we shall have a quick
> fix
> > > where virtual size i.e the size of the SAN volume shall be created(like
> > > small-20g, medium-40g) for people using the templates from S3.
> > >
> > > any feedback's ?
> > >
> > >
> > >
> > > On Tue, Sep 9, 2014 at 6:34 AM, Mike Tutkowski <
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > >> Hi Punith,
> > >>
> > >> Have you been able to make any progress with regards to this Swift/S3
> > >> issue?
> > >>
> > >> Thanks!
> > >> Mike
> > >>
> > >> On Wed, Aug 27, 2014 at 7:43 AM, Punith S 
> > wrote:
> > >>
> > >> > hi
> > >> >
> > >> > think i had a timeout problem!
> > >> > on the second try the template has been downloaded to the S3 bucket
> > and
> > >> > the management server shows the status as download complete with
> > >> template
> > >> > size as 1.6G instead of its virtual size 20G.
> > >> >
> > >> > and i see the template's status as Download Complete but it seems it
> > is
> > >> > not getting installed ! refer the attachment
> > >> >
> > >> > can a

RE: S3/Swift Problem around Virtual Size

[Sanjeev Neelarapu]

Mike,

You are right. Template gets copied to (secondary-storage) NFS before being 
copied to primary storage

-Sanjeev

-Original Message-
From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] 
Sent: Tuesday, September 09, 2014 10:55 AM
To: dev@cloudstack.apache.org
Cc: Punith S; Francois Gaudreault
Subject: Re: S3/Swift Problem around Virtual Size

Hi Will,

Thanks for the input!

I like the idea of storing the virtual size as metadata in S3 or Swift although 
this could require that the end user provide this value when uploading the 
template.

However, if we have the ability to determine the virtual size of the template 
after it gets downloaded to (secondary-storage) NFS and we're able to update 
the database with this info, then it would seem we would never need to ask the 
user for this value.

Either way, the tricky part might be if the template in object storage has 
already been downloaded to (secondary-storage) NFS (say it was used before). In 
this case, we won't need to download it to (secondary-storage) NFS again (at 
least not in the same zone), so we won't have an easy opportunity to figure out 
the virtual size upon download from object storage.

I wonder if it's too late in this process if we figured out the virtual size 
before the copied template (now on (secondary-storage) NFS) gets copied to 
primary storage. If we could do it at this point, then we wouldn't have to 
worry about fixing the "legacy" situation because it would just work out 
naturally. We would look in the DB to see if the virtual size for this template 
is known and, if not, we could figure out the virtual size before downloading 
from (secondary-storage) NFS to primary storage each time. (Although I'm 
thinking this would come too late in the process because we may have already 
asked the primary-storage plug-in to create the necessary volume.)

By the way, I'm assuming that a template gets copied to (secondary-storage) NFS 
before being copied to primary storage. I'm not super familiar with how this 
process works.

Talk to you later,
Mike

On Mon, Sep 8, 2014 at 10:59 PM, Will Stevens  wrote:

> My two cents on the topic.
>
> Ideally we would save the size in the object store metadata and 
> retrieve it from the metadata if it is set.  If it is not set in the 
> object store metadata, then when it is fetched, we have to put it on 
> NFS and determine the size (then ideally save the metadata back to the 
> object store) and remove the NFS copy.
>
> This way the NFS copy approach is only ever done once and then the 
> data is populated (for backwards compatibility).  For all templates 
> created after the patch, the metadata would be stored and retrieved 
> without the need for the NFS copy.
>
> Is this feasible?
>
> Will
>
>
> *Will STEVENS*
> Lead Developer
>
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw 
> @CloudOps_
>
> On Tue, Sep 9, 2014 at 12:48 AM, Mike Tutkowski < 
> mike.tutkow...@solidfire.com> wrote:
>
> > Hi Punith,
> >
> > Thanks for putting in time on this!
> >
> > So, option 1 occurs after we download the template to S3 or Swift. 
> > We
> then
> > have to copy it to NFS so that we can determine the virtual size?
> > Relatively slow, but it would work.
> >
> > If we went this route, would we then delete that template from the 
> > NFS share since its immediate purpose was so we could figure out the 
> > virtual size or would we leave it on that share?
> >
> > Option 2 is to allow the user who uploads such a template to specify 
> > the size needed for the root disk (i.e. at least the virtual size of 
> > the template...perhaps larger)?
> >
> > Does that sound like I understood the options?
> >
> > Thanks!
> > Mike
> >
> > On Mon, Sep 8, 2014 at 10:34 PM, Punith S 
> wrote:
> >
> > > hi mike,
> > >
> > > i have figured out the issue, in NFS secondary storage the virtual 
> > > size
> > is
> > > been calculated by the VHD Processor by accessing the vhd template.
> > >
> > > but in case of S3, cloudstack is not able to access the template 
> > > but it only gets to know the physical size of the template!
> > >
> > > in order to solve this, we need to download the template from S3 
> > > to another secondary nfs storage and access the template to 
> > > calculate the virtual size.
> > >
> > > if the above solution seems to be complicated, we shall have a 
> > > quick
> fix
> > > where virtual size i.e the size of the SAN volume shall be 
> > > created(like small-20g, medium-40g) for people using the templates from 
> > > S3.
> > >
> > > any feedback's ?
> > >
> > >
> > >
> > > On Tue, Sep 9, 2014 at 6:34 AM, Mike Tutkowski < 
> > > mike.tutkow...@solidfire.com> wrote:
> > >
> > >> Hi Punith,
> > >>
> > >> Have you been able to make any progress with regards to this 
> > >> Swift/S3 issue?
> > >>
> > >> Thanks!
> > >> Mike
> > >>
> > >> On Wed, Aug 27, 2014 at 7:43 AM, Punith S 
> > >> 
> > wrote:
> > >>
> > >> > hi
> > >> >
> >

Re: S3/Swift Problem around Virtual Size

[Mike Tutkowski]

Great :) Then a question might be, "Is it too late in the game to
interrogate the template to discover its virtual size if we're just about
to copy the template to primary storage?"

If it's not, this might be the place to run the logic to figure out the
virtual size.

Really, there are three big possibilities:

1) Just ask the end user to provide the virtual size (not commenting here
on what happens for already-uploaded templates)

or

2) Figure out the virtual size when the template is copied from object
storage to secondary storage and update the DB with this info (not sure
what happens if the template has already been copied to (secondary-storage)
NFS because it was used before)

or

3) Figure out the virtual size when the template is about to be copied from
secondary storage to primary storage

On Mon, Sep 8, 2014 at 11:35 PM, Sanjeev Neelarapu <
sanjeev.neelar...@citrix.com> wrote:

> Mike,
>
> You are right. Template gets copied to (secondary-storage) NFS before
> being copied to primary storage
>
> -Sanjeev
>
> -Original Message-
> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
> Sent: Tuesday, September 09, 2014 10:55 AM
> To: dev@cloudstack.apache.org
> Cc: Punith S; Francois Gaudreault
> Subject: Re: S3/Swift Problem around Virtual Size
>
> Hi Will,
>
> Thanks for the input!
>
> I like the idea of storing the virtual size as metadata in S3 or Swift
> although this could require that the end user provide this value when
> uploading the template.
>
> However, if we have the ability to determine the virtual size of the
> template after it gets downloaded to (secondary-storage) NFS and we're able
> to update the database with this info, then it would seem we would never
> need to ask the user for this value.
>
> Either way, the tricky part might be if the template in object storage has
> already been downloaded to (secondary-storage) NFS (say it was used
> before). In this case, we won't need to download it to (secondary-storage)
> NFS again (at least not in the same zone), so we won't have an easy
> opportunity to figure out the virtual size upon download from object
> storage.
>
> I wonder if it's too late in this process if we figured out the virtual
> size before the copied template (now on (secondary-storage) NFS) gets
> copied to primary storage. If we could do it at this point, then we
> wouldn't have to worry about fixing the "legacy" situation because it would
> just work out naturally. We would look in the DB to see if the virtual size
> for this template is known and, if not, we could figure out the virtual
> size before downloading from (secondary-storage) NFS to primary storage
> each time. (Although I'm thinking this would come too late in the process
> because we may have already asked the primary-storage plug-in to create the
> necessary volume.)
>
> By the way, I'm assuming that a template gets copied to
> (secondary-storage) NFS before being copied to primary storage. I'm not
> super familiar with how this process works.
>
> Talk to you later,
> Mike
>
> On Mon, Sep 8, 2014 at 10:59 PM, Will Stevens 
> wrote:
>
> > My two cents on the topic.
> >
> > Ideally we would save the size in the object store metadata and
> > retrieve it from the metadata if it is set.  If it is not set in the
> > object store metadata, then when it is fetched, we have to put it on
> > NFS and determine the size (then ideally save the metadata back to the
> > object store) and remove the NFS copy.
> >
> > This way the NFS copy approach is only ever done once and then the
> > data is populated (for backwards compatibility).  For all templates
> > created after the patch, the metadata would be stored and retrieved
> > without the need for the NFS copy.
> >
> > Is this feasible?
> >
> > Will
> >
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> > @CloudOps_
> >
> > On Tue, Sep 9, 2014 at 12:48 AM, Mike Tutkowski <
> > mike.tutkow...@solidfire.com> wrote:
> >
> > > Hi Punith,
> > >
> > > Thanks for putting in time on this!
> > >
> > > So, option 1 occurs after we download the template to S3 or Swift.
> > > We
> > then
> > > have to copy it to NFS so that we can determine the virtual size?
> > > Relatively slow, but it would work.
> > >
> > > If we went this route, would we then delete that template from the
> > > NFS share since its immediate purpose was so we could figure out the
> > > virtual size or would we leave it on that share?
> > >
> > > Option 2 is to allow the user who uploads such a template to specify
> > > the size needed for the root disk (i.e. at least the virtual size of
> > > the template...perhaps larger)?
> > >
> > > Does that sound like I understood the options?
> > >
> > > Thanks!
> > > Mike
> > >
> > > On Mon, Sep 8, 2014 at 10:34 PM, Punith S 
> > wrote:
> > >
> > > > hi mike,
> > > >
> > > > i have figured out the issue, in NFS secondary storage the virtu

Re: S3/Swift Problem around Virtual Size

[Mike Tutkowski]

By the way, for anyone new to this issue, this is what we're referring to
here:

https://issues.apache.org/jira/browse/CLOUDSTACK-7406

On Mon, Sep 8, 2014 at 11:41 PM, Mike Tutkowski <
mike.tutkow...@solidfire.com> wrote:

> Great :) Then a question might be, "Is it too late in the game to
> interrogate the template to discover its virtual size if we're just about
> to copy the template to primary storage?"
>
> If it's not, this might be the place to run the logic to figure out the
> virtual size.
>
> Really, there are three big possibilities:
>
> 1) Just ask the end user to provide the virtual size (not commenting here
> on what happens for already-uploaded templates)
>
> or
>
> 2) Figure out the virtual size when the template is copied from object
> storage to secondary storage and update the DB with this info (not sure
> what happens if the template has already been copied to (secondary-storage)
> NFS because it was used before)
>
> or
>
> 3) Figure out the virtual size when the template is about to be copied
> from secondary storage to primary storage
>
> On Mon, Sep 8, 2014 at 11:35 PM, Sanjeev Neelarapu <
> sanjeev.neelar...@citrix.com> wrote:
>
>> Mike,
>>
>> You are right. Template gets copied to (secondary-storage) NFS before
>> being copied to primary storage
>>
>> -Sanjeev
>>
>> -Original Message-
>> From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com]
>> Sent: Tuesday, September 09, 2014 10:55 AM
>> To: dev@cloudstack.apache.org
>> Cc: Punith S; Francois Gaudreault
>> Subject: Re: S3/Swift Problem around Virtual Size
>>
>> Hi Will,
>>
>> Thanks for the input!
>>
>> I like the idea of storing the virtual size as metadata in S3 or Swift
>> although this could require that the end user provide this value when
>> uploading the template.
>>
>> However, if we have the ability to determine the virtual size of the
>> template after it gets downloaded to (secondary-storage) NFS and we're able
>> to update the database with this info, then it would seem we would never
>> need to ask the user for this value.
>>
>> Either way, the tricky part might be if the template in object storage
>> has already been downloaded to (secondary-storage) NFS (say it was used
>> before). In this case, we won't need to download it to (secondary-storage)
>> NFS again (at least not in the same zone), so we won't have an easy
>> opportunity to figure out the virtual size upon download from object
>> storage.
>>
>> I wonder if it's too late in this process if we figured out the virtual
>> size before the copied template (now on (secondary-storage) NFS) gets
>> copied to primary storage. If we could do it at this point, then we
>> wouldn't have to worry about fixing the "legacy" situation because it would
>> just work out naturally. We would look in the DB to see if the virtual size
>> for this template is known and, if not, we could figure out the virtual
>> size before downloading from (secondary-storage) NFS to primary storage
>> each time. (Although I'm thinking this would come too late in the process
>> because we may have already asked the primary-storage plug-in to create the
>> necessary volume.)
>>
>> By the way, I'm assuming that a template gets copied to
>> (secondary-storage) NFS before being copied to primary storage. I'm not
>> super familiar with how this process works.
>>
>> Talk to you later,
>> Mike
>>
>> On Mon, Sep 8, 2014 at 10:59 PM, Will Stevens 
>> wrote:
>>
>> > My two cents on the topic.
>> >
>> > Ideally we would save the size in the object store metadata and
>> > retrieve it from the metadata if it is set.  If it is not set in the
>> > object store metadata, then when it is fetched, we have to put it on
>> > NFS and determine the size (then ideally save the metadata back to the
>> > object store) and remove the NFS copy.
>> >
>> > This way the NFS copy approach is only ever done once and then the
>> > data is populated (for backwards compatibility).  For all templates
>> > created after the patch, the metadata would be stored and retrieved
>> > without the need for the NFS copy.
>> >
>> > Is this feasible?
>> >
>> > Will
>> >
>> >
>> > *Will STEVENS*
>> > Lead Developer
>> >
>> > *CloudOps* *| *Cloud Solutions Experts
>> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
>> > @CloudOps_
>> >
>> > On Tue, Sep 9, 2014 at 12:48 AM, Mike Tutkowski <
>> > mike.tutkow...@solidfire.com> wrote:
>> >
>> > > Hi Punith,
>> > >
>> > > Thanks for putting in time on this!
>> > >
>> > > So, option 1 occurs after we download the template to S3 or Swift.
>> > > We
>> > then
>> > > have to copy it to NFS so that we can determine the virtual size?
>> > > Relatively slow, but it would work.
>> > >
>> > > If we went this route, would we then delete that template from the
>> > > NFS share since its immediate purpose was so we could figure out the
>> > > virtual size or would we leave it on that share?
>> > >
>> > > Option 2 is to allow the user who uploads such a template to specify
>> > 

Re: Review Request 25436: CLOUDSTACK-7393: Removing dependency on wait period from test case

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25436/#review52677
---

Ship it!


This change makes test to run faster. In future, please add test result logs 
too .

- SrikanteswaraRao Talluri


On Sept. 8, 2014, 1:33 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25436/
> ---
> 
> (Updated Sept. 8, 2014, 1:33 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7393
> https://issues.apache.org/jira/browse/CLOUDSTACK-7393
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The VM was destroyed (not expunged) and wait period was added.
> Instead expunged it immediately and removed the wait period.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py 8fc6d62 
> 
> Diff: https://reviews.apache.org/r/25436/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25436: CLOUDSTACK-7393: Removing dependency on wait period from test case

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25436/#review52680
---


pushed to master 402fc914cf4047b7faf1b1410972bb5a4ae5b29d

- SrikanteswaraRao Talluri


On Sept. 8, 2014, 1:33 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25436/
> ---
> 
> (Updated Sept. 8, 2014, 1:33 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7393
> https://issues.apache.org/jira/browse/CLOUDSTACK-7393
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> The VM was destroyed (not expunged) and wait period was added.
> Instead expunged it immediately and removed the wait period.
> 
> 
> Diffs
> -
> 
>   test/integration/component/test_vpc_vm_life_cycle.py 8fc6d62 
> 
> Diff: https://reviews.apache.org/r/25436/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25433/#review52681
---

Ship it!


It would be nice if you could submit patches which replaces other occurences 
copytemplate code in test_templates.py

cmd = copyTemplate.copyTemplateCmd()
cmd.id = self.template_2.id
cmd.destzoneid = self.services["destzoneid"]
cmd.sourcezoneid = self.services["sourcezoneid"]
self.apiclient.copyTemplate(cmd)

- SrikanteswaraRao Talluri


On Sept. 8, 2014, 12:37 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25433/
> ---
> 
> (Updated Sept. 8, 2014, 12:37 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7509
> https://issues.apache.org/jira/browse/CLOUDSTACK-7509
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Bound method for copyTemplate was missing in library, hence test cases failed 
> during copy operation.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py 982986b 
> 
> Diff: https://reviews.apache.org/r/25433/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test copy template between zones ... === TestName: 
> test_04_copy_template_1_root_domain_admin | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 427.374s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25433/#review52683
---


pushed to master: bbb3ea5983928df66704ab78cef0a1c3e292cbe9

- SrikanteswaraRao Talluri


On Sept. 8, 2014, 12:37 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25433/
> ---
> 
> (Updated Sept. 8, 2014, 12:37 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7509
> https://issues.apache.org/jira/browse/CLOUDSTACK-7509
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Bound method for copyTemplate was missing in library, hence test cases failed 
> during copy operation.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py 982986b 
> 
> Diff: https://reviews.apache.org/r/25433/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test copy template between zones ... === TestName: 
> test_04_copy_template_1_root_domain_admin | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 427.374s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation

[Gaurav Aradhye]

> On Sept. 9, 2014, 11:48 a.m., SrikanteswaraRao Talluri wrote:
> > It would be nice if you could submit patches which replaces other 
> > occurences copytemplate code in test_templates.py
> > 
> > cmd = copyTemplate.copyTemplateCmd()
> > cmd.id = self.template_2.id
> > cmd.destzoneid = self.services["destzoneid"]
> > cmd.sourcezoneid = self.services["sourcezoneid"]
> > self.apiclient.copyTemplate(cmd)

Sure, I will submit patch for it.


- Gaurav


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25433/#review52681
---


On Sept. 8, 2014, 6:07 p.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25433/
> ---
> 
> (Updated Sept. 8, 2014, 6:07 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7509
> https://issues.apache.org/jira/browse/CLOUDSTACK-7509
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Bound method for copyTemplate was missing in library, hence test cases failed 
> during copy operation.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py 982986b 
> 
> Diff: https://reviews.apache.org/r/25433/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Log:
> Test copy template between zones ... === TestName: 
> test_04_copy_template_1_root_domain_admin | Status : SUCCESS ===
> ok
> 
> --
> Ran 1 test in 427.374s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25431/#review52685
---

Ship it!


- SrikanteswaraRao Talluri


On Sept. 8, 2014, 11:35 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25431/
> ---
> 
> (Updated Sept. 8, 2014, 11:35 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7506
> https://issues.apache.org/jira/browse/CLOUDSTACK-7506
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Few test cases in Secondary Storage Limits failed due to error in registering 
> Template - "Invalid Parameters - hypervisor is required".
> 
> Base library function is reading hypervisor value only from function 
> parameter and not from services dictionary. But the test cases are passing 
> hypervisor value from dictionary.
> 
> Solution:
> Read the hypervisor value from the services dict if it's not passed through 
> the function parameter.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py 982986b 
> 
> Diff: https://reviews.apache.org/r/25431/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Test Try to deploy VM with admin account where account has not used ... === 
> TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS ===
> ok
> Test Try to deploy VM with admin account where account has used ... SKIP: skip
> Test TTry to deploy VM with admin account where account has not used ... 
> SKIP: skip
> 
> --
> Ran 3 tests in 199.895s
> 
> OK (SKIP=2)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Re: Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter

[SrikanteswaraRao Talluri]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25431/#review52687
---


pushed to master d08d71427bba562aa8b46a54143a783051297494

- SrikanteswaraRao Talluri


On Sept. 8, 2014, 11:35 a.m., Gaurav Aradhye wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25431/
> ---
> 
> (Updated Sept. 8, 2014, 11:35 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and 
> SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7506
> https://issues.apache.org/jira/browse/CLOUDSTACK-7506
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> ---
> 
> Few test cases in Secondary Storage Limits failed due to error in registering 
> Template - "Invalid Parameters - hypervisor is required".
> 
> Base library function is reading hypervisor value only from function 
> parameter and not from services dictionary. But the test cases are passing 
> hypervisor value from dictionary.
> 
> Solution:
> Read the hypervisor value from the services dict if it's not passed through 
> the function parameter.
> 
> 
> Diffs
> -
> 
>   tools/marvin/marvin/lib/base.py 982986b 
> 
> Diff: https://reviews.apache.org/r/25431/diff/
> 
> 
> Testing
> ---
> 
> Yes.
> 
> Test Try to deploy VM with admin account where account has not used ... === 
> TestName: test_01_deploy_vm_domain_limit_reached | Status : SUCCESS ===
> ok
> Test Try to deploy VM with admin account where account has used ... SKIP: skip
> Test TTry to deploy VM with admin account where account has not used ... 
> SKIP: skip
> 
> --
> Ran 3 tests in 199.895s
> 
> OK (SKIP=2)
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>