[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/621#issuecomment-124357139
  
Merging it as 2 LGTMs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[BlockerBug] VR creation fails in basic zone

[Sanjeev N]

Hi,

In latest build with ACS master, VR creation fails in basic zone.
Created a blocker bug for this. More details @
https://issues.apache.org/jira/browse/CLOUDSTACK-8668

Thanks,
Sanjeev

secondary storage migrate to new one

[Star Guo]

Dear All,

 

   I have built with cloudstack 4.4.3 + kvm. Now, I add a new nfs as
secondary storage, and I want to migrate the snapshot&volume&iso on the old
secondary storage to the new one.

   How can I do that ? Thanks. J

 

Best Regards,

Star Guo

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/609


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/606#issuecomment-124334323
  
Thanks for the update. changes looks good :+1: 
Some unit/marvin tests would be good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/609#issuecomment-124330906
  
2 LGTMs and travis is green. I am merging this to master in sometime


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dereference NULL return value

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/618#issuecomment-124330473
  
instead of a notnull check everywhere, can you use a Non Nulllable 
ArrayList for tags or use CollectionUtils.addIgnoreNull() api?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] Snapshot Improvements

[Anshul Gangwar]

Please find my answers inline

Regards,
Anshul

On 23-Jul-2015, at 8:39 pm, Somesh Naidu 
mailto:somesh.na...@citrix.com>> wrote:

Couple of questions:
1. "In case backup snapshot process fails then user will be provided with alert 
that backup of snapshot fails."
What user action required if this happens? Or will the snapshot operation be 
treated as failed marking the DB entry as error and removed from primary 
storage?
[Anshul] Alert will be information purposes and no user action will be 
required. Its a separate bug and will be treated separately.

2. How do we deal with incremental snapshots?
[Anshul]
In case of VmWare will be taking full clone snapshots and in case of XenServer 
its already handled correctly from hypervisor.

Regards,
Somesh


-Original Message-
From: Anshul Gangwar [mailto:anshul.gang...@citrix.com]
Sent: Thursday, July 23, 2015 5:27 AM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] Snapshot Improvements

I am working on improving snapshots experience in CloudStack.

FS is available at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Snapshot+Improvements .

Please review and provide comments/suggestions.

Regards,
Anshul

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/620#issuecomment-124323473
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/621#issuecomment-124323020
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dockerfile

[pdion891]

Github user pdion891 commented on the pull request:

https://github.com/apache/cloudstack/pull/605#issuecomment-124282315
  
I'll squash, I've been told it was better for code review many small 
commits than one big fat ass commit that nobody want to understand.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dockerfile

[pdion891]

Github user pdion891 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/605#discussion_r35387474
  
--- Diff: tools/docker/Dockerfile.marvin ---
@@ -0,0 +1,37 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#   http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#
+# build for cloudstack_home_dir not this folder
+FROM python:2
+
+MAINTAINER "Apache CloudStack" 
+LABEL Vendor="Apache.org"
+LABEL License=ApacheV2
+LABEL Version=4.6.0
+
+ENV 
PKG_URL=http://jenkins.buildacloud.org/job/cloudstack-marvin-master/lastSuccessfulBuild/artifact/tools/marvin/dist/Marvin-4.6.0-SNAPSHOT.tar.gz
+
+RUN pip install --allow-external mysql-connector-python 
mysql-connector-python
+RUN pip install ${PKG_URL}
+
+RUN mkdir -p /marvin
+COPY setup/dev /marvin/dev
+COPY tools/marvin/marvin /marvin/marvin
+COPY test/integration /marvin/integration
+
+WORKDIR /marvin
--- End diff --

No, because it's a set of tool that use the command line, so yes every time 
you /bin/bash into it will spawn a new process of the image. Do you see a 
better aproach ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-systemvm64-master #578

[jenkins]

See 

Changes:

[wrodrigues] CLOUDSTACK-8660 - Formatting test and utility classes

[wrodrigues] CLOUDSTACK-8660 - Adding a method to check if UTF-8 is supported

[wrodrigues] CLOUDSTACK-8660 - Adding new StringUtils.getDefaultCharset() in 
order to wrap the Charset equivalet method.

[wrodrigues] CLOUDSTACK-8649: Fixed unnecessary double url decoding in 
registerSSHKeyPair.

[wrodrigues] CLOUDSTACK-8650: Fix securitygroups ingress FW for protocol any 
and 0.0.0.0/0

[wrodrigues] Sorry about the typo

[Rajani Karuturi] Fixed Coverity issue "Dereference null return value"

[wrodrigues] CLOUDSTACK-8580 Users are now able to view, expunge and recover 
their vm's themselves. Two configuration options are added to allow this 
behaviour on a global or per account scale. Configuration options default to 
false.

--
[...truncated 3252 lines...]
Adding debian:Entrust_Root_Certification_Authority.pem
Adding debian:ePKI_Root_Certification_Authority.pem
Adding debian:Equifax_Secure_CA.pem
Adding debian:Equifax_Secure_eBusiness_CA_1.pem
Adding debian:Equifax_Secure_Global_eBusiness_CA.pem
Adding debian:E-Tugra_Certification_Authority.pem
Adding debian:GeoTrust_Global_CA_2.pem
Adding debian:GeoTrust_Global_CA.pem
Adding debian:GeoTrust_Primary_Certification_Authority.pem
Adding debian:GeoTrust_Primary_Certification_Authority_-_G2.pem
Adding debian:GeoTrust_Primary_Certification_Authority_-_G3.pem
Adding debian:GeoTrust_Universal_CA_2.pem
Adding debian:GeoTrust_Universal_CA.pem
Adding debian:Global_Chambersign_Root_-_2008.pem
Adding debian:GlobalSign_Root_CA.pem
Adding debian:GlobalSign_Root_CA_-_R2.pem
Adding debian:GlobalSign_Root_CA_-_R3.pem
Adding debian:Go_Daddy_Class_2_CA.pem
Adding debian:Go_Daddy_Root_Certificate_Authority_-_G2.pem
Adding debian:GTE_CyberTrust_Global_Root.pem
Adding debian:Hellenic_Academic_and_Research_Institutions_RootCA_2011.pem
Adding debian:Hongkong_Post_Root_CA_1.pem
Adding debian:IGC_A.pem
Adding debian:Izenpe.com.pem
Adding debian:Juur-SK.pem
Adding debian:Microsec_e-Szigno_Root_CA_2009.pem
Adding debian:Microsec_e-Szigno_Root_CA.pem
Adding debian:NetLock_Arany_=Class_Gold=_Főtanúsítvány.pem
Adding debian:NetLock_Business_=Class_B=_Root.pem
Adding debian:NetLock_Express_=Class_C=_Root.pem
Adding debian:NetLock_Notary_=Class_A=_Root.pem
Adding debian:NetLock_Qualified_=Class_QA=_Root.pem
Adding debian:Network_Solutions_Certificate_Authority.pem
Adding debian:OISTE_WISeKey_Global_Root_GA_CA.pem
Adding debian:PSCProcert.pem
Adding debian:QuoVadis_Root_CA_2.pem
Adding debian:QuoVadis_Root_CA_3.pem
Adding debian:QuoVadis_Root_CA.pem
Adding debian:Root_CA_Generalitat_Valenciana.pem
Adding debian:RSA_Root_Certificate_1.pem
Adding debian:RSA_Security_2048_v3.pem
Adding debian:Secure_Global_CA.pem
Adding debian:SecureSign_RootCA11.pem
Adding debian:SecureTrust_CA.pem
Adding debian:Security_Communication_EV_RootCA1.pem
Adding debian:Security_Communication_RootCA2.pem
Adding debian:Security_Communication_Root_CA.pem
Adding debian:SG_TRUST_SERVICES_RACINE.pem
Adding debian:Sonera_Class_1_Root_CA.pem
Adding debian:Sonera_Class_2_Root_CA.pem
Adding debian:Staat_der_Nederlanden_Root_CA.pem
Adding debian:Staat_der_Nederlanden_Root_CA_-_G2.pem
Adding debian:Starfield_Class_2_CA.pem
Adding debian:Starfield_Root_Certificate_Authority_-_G2.pem
Adding debian:Starfield_Services_Root_Certificate_Authority_-_G2.pem
Adding debian:StartCom_Certification_Authority_2.pem
Adding debian:StartCom_Certification_Authority.pem
Adding debian:StartCom_Certification_Authority_G2.pem
Adding debian:S-TRUST_Authentication_and_Encryption_Root_CA_2005_PN.pem
Adding debian:Swisscom_Root_CA_1.pem
Adding debian:Swisscom_Root_CA_2.pem
Adding debian:Swisscom_Root_EV_CA_2.pem
Adding debian:SwissSign_Gold_CA_-_G2.pem
Adding debian:SwissSign_Platinum_CA_-_G2.pem
Adding debian:SwissSign_Silver_CA_-_G2.pem
Adding debian:Taiwan_GRCA.pem
Adding debian:TC_TrustCenter_Class_2_CA_II.pem
Adding debian:TC_TrustCenter_Class_3_CA_II.pem
Adding debian:TC_TrustCenter_Universal_CA_I.pem
Adding debian:TDC_Internet_Root_CA.pem
Adding debian:TeliaSonera_Root_CA_v1.pem
Adding debian:Thawte_Premium_Server_CA.pem
Adding debian:thawte_Primary_Root_CA.pem
Adding debian:thawte_Primary_Root_CA_-_G2.pem
Adding debian:thawte_Primary_Root_CA_-_G3.pem
Adding debian:Thawte_Server_CA.pem
Adding debian:Trustis_FPS_Root_CA.pem
Adding debian:T-TeleSec_GlobalRoot_Class_2.pem
Adding debian:T-TeleSec_GlobalRoot_Class_3.pem
Adding debian:TÜBİTAK_UEKAE_Kök_Sertifika_Hizmet_Sağlayıcısı_-_Sürüm_3.pem
Adding debian:TURKTRUST_Certificate_Services_Provider_Root_1.pem
Adding debian:TURKTRUST_Certificate_Services_Provider_Root_2007.pem
Adding debian:TURKTRUST_Certificate_Services_Provider_Root_2.pem
Adding debian:TWCA_Global_Root_CA.pem
Adding debian:TWCA_Root_Certification_Authority.pem
Adding debian:UTN_DATACorp_SGC_Root_CA.pem
Adding debian:UTN_USERFirst_Email_Root_CA.

[GitHub] cloudstack pull request: Dockerfile

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/605#issuecomment-124263885
  
come on guys, if this is what happened this is what we have got. Squash wht 
is not atomic and nothing else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8648: Do not configure the Ima...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/606#issuecomment-124249061
  
@karuturi Fixed that. See the new commit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dockerfile

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/605#issuecomment-124246163
  
LGTM, but as @runseb says, please squash this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

[wido]

Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/621#issuecomment-124243179
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Proposal] CoreOS support

[Daan Hoogland]

Right Somesh, so I didn't think adding a new OS would be necessary. If
the calls are not fully functional some work is needed, but I remember
adding a redhat version (7?) at some point.

On Thu, Jul 23, 2015 at 4:46 PM, Somesh Naidu  wrote:
> "cloud administrator task" - I thought this functionality already exists with 
> APIs like,
> addGuestOs
> updateGuestOs
> removeGuestOs
> addGuestOsMapping
> updateGuestOsMapping
> removeGuestOsMapping
>
> Regards,
> Somesh
>
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
> Sent: Thursday, July 23, 2015 6:11 AM
> To: dev
> Subject: Re: [Proposal] CoreOS support
>
> of course +1 for adding CoreOS but can we make supporting os-types
> more a cloud administrator task then a cloudstack maintainer task? I
> think some work has gone into that already. Some more work will
> probably be needed.
>
> On Thu, Jul 23, 2015 at 10:43 AM, Kishan Kavala
>  wrote:
>> Sure Sebastian. I'll check OS type list and remove outdated distros.
>>
>> -Original Message-
>> From: Sebastien Goasguen [mailto:run...@gmail.com]
>> Sent: 22 July 2015 08:09 PM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [Proposal] CoreOS support
>>
>> +1
>>
>> Can you clean that last of OS Type while you are it, last time I checked it 
>> was really long with some outdated distros…
>>
>> -sebastien
>>
>>> On Jul 22, 2015, at 4:35 PM, Somesh Naidu  wrote:
>>>
>>> +1
>>>
>>> Regards,
>>> Somesh
>>>
>>> -Original Message-
>>> From: Ahmad [mailto:aemne...@gmail.com]
>>> Sent: Wednesday, July 22, 2015 10:28 AM
>>> To: dev@cloudstack.apache.org
>>> Subject: Re: [Proposal] CoreOS support
>>>
>>> +1 looking forward to this.
>>>
>>>
>>>
 On Jul 22, 2015, at 1:14 PM, Kishan Kavala  
 wrote:

 I would like to add CoreOS as a supported OS type to cloudstack.
 CoreOS vms can be created even now by selecting OS type as "Other". There 
 are cloud providers supporting CoreOS offerings in production already.
 By making the changes mentioned at [1] I would make it easier to deploy 
 CoreOS Vms and also add UI support for providing cloud-config via userdata.
 I'll also update the documentation at [2] after making these changes.

 [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/CoreOS
 [2] https://coreos.com/os/docs/latest/booting-on-cloudstack.html
>>
>
>
>
> --
> Daan



-- 
Daan

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/620#issuecomment-124191945
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [PROPOSAL] Snapshot Improvements

[Somesh Naidu]

Couple of questions:
1. "In case backup snapshot process fails then user will be provided with alert 
that backup of snapshot fails."
What user action required if this happens? Or will the snapshot operation be 
treated as failed marking the DB entry as error and removed from primary 
storage?

2. How do we deal with incremental snapshots?

Regards,
Somesh


-Original Message-
From: Anshul Gangwar [mailto:anshul.gang...@citrix.com] 
Sent: Thursday, July 23, 2015 5:27 AM
To: dev@cloudstack.apache.org
Subject: [PROPOSAL] Snapshot Improvements

I am working on improving snapshots experience in CloudStack.

FS is available at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Snapshot+Improvements .

Please review and provide comments/suggestions.

Regards,
Anshul

RE: [Proposal] CoreOS support

[Somesh Naidu]

"cloud administrator task" - I thought this functionality already exists with 
APIs like,
addGuestOs
updateGuestOs
removeGuestOs
addGuestOsMapping
updateGuestOsMapping
removeGuestOsMapping

Regards,
Somesh

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: Thursday, July 23, 2015 6:11 AM
To: dev
Subject: Re: [Proposal] CoreOS support

of course +1 for adding CoreOS but can we make supporting os-types
more a cloud administrator task then a cloudstack maintainer task? I
think some work has gone into that already. Some more work will
probably be needed.

On Thu, Jul 23, 2015 at 10:43 AM, Kishan Kavala
 wrote:
> Sure Sebastian. I'll check OS type list and remove outdated distros.
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: 22 July 2015 08:09 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [Proposal] CoreOS support
>
> +1
>
> Can you clean that last of OS Type while you are it, last time I checked it 
> was really long with some outdated distros…
>
> -sebastien
>
>> On Jul 22, 2015, at 4:35 PM, Somesh Naidu  wrote:
>>
>> +1
>>
>> Regards,
>> Somesh
>>
>> -Original Message-
>> From: Ahmad [mailto:aemne...@gmail.com]
>> Sent: Wednesday, July 22, 2015 10:28 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [Proposal] CoreOS support
>>
>> +1 looking forward to this.
>>
>>
>>
>>> On Jul 22, 2015, at 1:14 PM, Kishan Kavala  wrote:
>>>
>>> I would like to add CoreOS as a supported OS type to cloudstack.
>>> CoreOS vms can be created even now by selecting OS type as "Other". There 
>>> are cloud providers supporting CoreOS offerings in production already.
>>> By making the changes mentioned at [1] I would make it easier to deploy 
>>> CoreOS Vms and also add UI support for providing cloud-config via userdata.
>>> I'll also update the documentation at [2] after making these changes.
>>>
>>> [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/CoreOS
>>> [2] https://coreos.com/os/docs/latest/booting-on-cloudstack.html
>



-- 
Daan

Re: [Proposal] Continuos Integration Testing on ACS master.

[Bharat Kumar]

Hi Kishan,

I am thinking we will use Citrix hardware until we find something in the acs 
lab. We will publish the results to acs by mails. However until we find 
something publicly accessible people can only see the list of tests that failed,
for providing more info we will need some place to host the logs and other 
related info of the test runs.

long term plan is to move everything into acs infra.

Thanks,
Bharat.

On 23-Jul-2015, at 4:19 pm, Kishan Kavala  wrote:

> Bharat,
> I hope this will go a long way in improving product quality. How are you 
> going to handle the handle the hardware requirement? What is the plan to 
> publish the results to ML?
> 
> -Original Message-
> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
> Sent: 23 July 2015 03:46 PM
> To: dev
> Subject: Re: [Proposal] Continuos Integration Testing on ACS master.
> 
> Good work Bharat, Keep in mind that many people work on this in many ways and 
> many attempts have failed due to nothing but lack of consensus. I have only 
> glanced but will take my time with it soon.
> 
> On Thu, Jul 23, 2015 at 10:50 AM, Bharat Kumar  
> wrote:
>> Hi All,
>> 
>> Currently we do sanity checks on master using Travis, But travis runs 
>> only simulator tests (AFAIK). I think it will be better if we can run both 
>> BVTs and regression tests on real hardware. I am woking on implementing this.
>> 
>> Functional spec and design details.
>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orches
>> trator+and+test+runner+to+enable+continuos+integration
>> 
>> Please read the FS and give your comments or suggestions.
>> 
>> Thanks,
>> Bharat.
> 
> 
> 
> --
> Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8666: Put host in Alert state ...

[koushik-das]

GitHub user koushik-das opened a pull request:

https://github.com/apache/cloudstack/pull/621

CLOUDSTACK-8666: Put host in Alert state only after alert.wait timeout

Instead of putting the host to Alert state immediately, the investigators 
should be allowed to run for some time based on alert.wait global config.
At the end of this interval if the host state still cannot be determined 
then put the host in Alert. Also updated some of the log messages.

Refer to the bug for the detailed description.

Since these scenarios are difficult to simulate, haven't written any tests. 
If anyone has suggestions on some tests please let me know.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/koushik-das/cloudstack CLOUDSTACK-8666

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #621


commit 2cd8e6726540186b9ccec41beebe21af3a6d08b6
Author: Koushik Das 
Date:   2015-07-23T12:27:51Z

CLOUDSTACK-8666: Put host in Alert state only after alert.wait timeout
Instead of putting the host to Alert state immediately, the investigators 
should be allowed to run for some time based on alert.wait global config.
At the end of this interval if the host state still cannot be determined 
then put the host in Alert. Also updated some of the log messages.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Coverity issue "Dereference null re...

[manuiiit]

GitHub user manuiiit opened a pull request:

https://github.com/apache/cloudstack/pull/620

Fixed Coverity issue "Dereference null return value"



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manuiiit/cloudstack master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #620


commit f973d89602c5386f2f00659ebb49432194f303d6
Author: Maneesha P 
Date:   2015-07-22T19:15:00Z

Fixed Coverity issue "Dereference null return value" by adding a Null Value 
Exception

commit f34530f79a6e3070c03ee92a8312ad1a822aeffa
Author: Maneesha P 
Date:   2015-07-23T12:01:47Z

Fixed Coverity issue "Dereference null return value"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/593


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/593#issuecomment-124075403
  
Creating 2 VMs via cloudmonkey

(local) 🐵 > deploy virtualmachine displayname=isovm 
networkids=61fb9ffe-cf5e-4a09-9470-e0800685f74d 
templateid=2853716f-311a-11e5-b59a-5254001daa61 
zoneid=38d556a7-39e5-4b70-9ce2-9bed1a16abc5  
serviceofferingid=5ffbfb25-7df3-4b00-b053-cda67b5b46a9 

(local) 🐵 > deploy virtualmachine displayname=isovm2 
networkids=61fb9ffe-cf5e-4a09-9470-e0800685f74d 
templateid=2853716f-311a-11e5-b59a-5254001daa61 
zoneid=38d556a7-39e5-4b70-9ce2-9bed1a16abc5  
serviceofferingid=5ffbfb25-7df3-4b00-b053-cda67b5b46a9 

Destroying 1 VM via cloudmonkey (no expunge)

(local) 🐵 > destroy virtualmachine 
id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4 

Recovering 1 VM via cloudmonkey

(local) 🐵 > recover virtualmachine 
id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4

Starting 1 VM via cloudmonkey

(local) 🐵 > start virtualmachine id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4


![image](https://cloud.githubusercontent.com/assets/5129209/8849745/74b08848-3142-11e5-9cd4-057593cec312.png)

Destroying 1 VM via cloudmonkey (expunge)

(local) 🐵 > destroy virtualmachine 
id=ecaeb2f4-27fa-4d40-8a72-762232f17cc4 expunge=true


![image](https://cloud.githubusercontent.com/assets/5129209/8849803/e005372e-3142-11e5-8015-01918f6560c8.png)

All L-super-GTM :+1: 

Merging... :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[PROPOSAL] Support for non-US keyboards in Console Proxy

[Anshul Gangwar]

I am working on making easier to add non-US keyboards support in console proxy.

WIP FS for same is available at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy.

Please review and provide suggestions/comments.

Thanks,
Anshul

RE: [Proposal] Continuos Integration Testing on ACS master.

[Kishan Kavala]

Bharat,
 I hope this will go a long way in improving product quality. How are you going 
to handle the handle the hardware requirement? What is the plan to publish the 
results to ML?

-Original Message-
From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] 
Sent: 23 July 2015 03:46 PM
To: dev
Subject: Re: [Proposal] Continuos Integration Testing on ACS master.

Good work Bharat, Keep in mind that many people work on this in many ways and 
many attempts have failed due to nothing but lack of consensus. I have only 
glanced but will take my time with it soon.

On Thu, Jul 23, 2015 at 10:50 AM, Bharat Kumar  wrote:
> Hi All,
>
> Currently we do sanity checks on master using Travis, But travis runs 
> only simulator tests (AFAIK). I think it will be better if we can run both 
> BVTs and regression tests on real hardware. I am woking on implementing this.
>
> Functional spec and design details.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orches
> trator+and+test+runner+to+enable+continuos+integration
>
> Please read the FS and give your comments or suggestions.
>
> Thanks,
> Bharat.



--
Daan

Re: [DISCUSS] Add at least test steps to PR

[Daan Hoogland]

+1

for less trivial changes that have no clear instruction on testing I
would say you would have to be very interested in the component to not
just -1 from the start. We are not writing code for the experts. We
are writing code for the whole world to use understand and enhance.

point of a review is to sharpen the PR as well as understanding it.


On Thu, Jul 23, 2015 at 12:36 PM, Wilder Rodrigues
 wrote:
> Hi all,
>
> Although we have been through those PR related discussions a lot, I would 
> like to add just 1 point:
>
> * When a PR hasn't been properly tested before submitted or when the 
> Committer hasn’t added any test report, that at least the test steps are 
> present in the PR description.
>
> If for every PR I review I have to go through the code to find out the tests 
> steps by myself, I will probably review less PRs otherwise I would have to 
> stop coding.
>
> Cheers,
> Wilder



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/609#issuecomment-124053986
  
to run from eclipse, you need to install Groovy eclipse plugin 
https://code.google.com/p/spock/wiki/GettingStarted#Eclipse


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/609#issuecomment-124052158
  
ran tests from command line. code looks good. I use eclipse and did not 
manage to run tests in the ide yet (no problem with the PR). HInts welcome :) 
:+1:  waiting on travis and the analisys builds


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] Add at least test steps to PR

[Wilder Rodrigues]

Hi all,

Although we have been through those PR related discussions a lot, I would like 
to add just 1 point:

* When a PR hasn't been properly tested before submitted or when the Committer 
hasn’t added any test report, that at least the test steps are present in the 
PR description.

If for every PR I review I have to go through the code to find out the tests 
steps by myself, I will probably review less PRs otherwise I would have to stop 
coding.

Cheers,
Wilder

[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/607#discussion_r35308653
  
--- Diff: test/integration/component/test_browse_templates.py ---
@@ -1674,6 +1674,42 @@ def 
test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deleti
 return
 
 
+@attr(tags = ["advanced", "advancedns", "smoke", "basic"], 
required_hardware="false")
+def test_browser_upload_template_incomplete(self):
+"""
+Test browser based incomplete template upload, followed by SSVM 
destroy. Template should go to UploadAbandoned state and get cleaned up.
+"""
+try:
+self.debug("= Test browser based 
incomplete template upload ")
+
+#Only register template, without uploading
+cmd = 
getUploadParamsForTemplate.getUploadParamsForTemplateCmd()
+cmd.zoneid = self.zone.id
+cmd.format = self.uploadtemplateformat
+
cmd.name=self.templatename+self.account.name+(random.choice(string.ascii_uppercase))
+cmd.account=self.account.name
+cmd.domainid=self.domain.id
+cmd.displaytext=cmd.name
+cmd.hypervisor=self.templatehypervisor
+cmd.ostypeid=self.templateostypeid
+
template_response=self.apiclient.getUploadParamsForTemplate(cmd)
+
+#Destroy SSVM, and wait for new one to start
+self.destroy_ssvm()
+
+#Verify that the template is cleaned up as part of sync-up 
during new SSVM start
+list_template_response=Template.list(
+self.apiclient,
+id=template_response.id,
+templatefilter="all",
+zoneid=self.zone.id)
+self.assertEqual(list_template_response, None, "Template is 
not cleaned up, some issue with template sync-up")
+
--- End diff --

ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/607#issuecomment-124051136
  
looks good :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35308521
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
 ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.ldap;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.naming.NamingEnumeration;
+import javax.naming.NamingException;
+import javax.naming.directory.SearchControls;
+import javax.naming.directory.SearchResult;
+import javax.naming.ldap.LdapContext;
+
+import org.apache.commons.lang.StringUtils;
+import org.apache.log4j.Logger;
+
+public class ADLdapUserManagerImpl extends OpenLdapUserManagerImpl 
implements LdapUserManager {
+public static final Logger s_logger = 
Logger.getLogger(ADLdapUserManagerImpl.class.getName());
+
+@Override
+public List getUsersInGroup(String groupName, LdapContext 
context) throws NamingException {
+final SearchControls searchControls = new SearchControls();
+searchControls.setSearchScope(_ldapConfiguration.getScope());
+
searchControls.setReturningAttributes(_ldapConfiguration.getReturnAttributes());
+
+String basedn = _ldapConfiguration.getBaseDn();
+if (StringUtils.isBlank(basedn)) {
+throw new IllegalArgumentException("ldap basedn is not 
configured");
+}
+
+if (StringUtils.isBlank(groupName)) {
--- End diff --

done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35308512
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
 ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.ldap;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import javax.naming.NamingEnumeration;
+import javax.naming.NamingException;
+import javax.naming.directory.SearchControls;
+import javax.naming.directory.SearchResult;
+import javax.naming.ldap.LdapContext;
+
+import org.apache.commons.lang.StringUtils;
+import org.apache.log4j.Logger;
+
+public class ADLdapUserManagerImpl extends OpenLdapUserManagerImpl 
implements LdapUserManager {
+public static final Logger s_logger = 
Logger.getLogger(ADLdapUserManagerImpl.class.getName());
+
+@Override
+public List getUsersInGroup(String groupName, LdapContext 
context) throws NamingException {
+final SearchControls searchControls = new SearchControls();
+searchControls.setSearchScope(_ldapConfiguration.getScope());
+
searchControls.setReturningAttributes(_ldapConfiguration.getReturnAttributes());
+
+String basedn = _ldapConfiguration.getBaseDn();
+if (StringUtils.isBlank(basedn)) {
+throw new IllegalArgumentException("ldap basedn is not 
configured");
+}
+
+if (StringUtils.isBlank(groupName)) {
+throw new IllegalArgumentException("ldap group name cannot be 
blank");
+}
+
+NamingEnumeration results = context.search(basedn, 
generateADGroupSearchFilter(groupName), searchControls);
+final List users = new ArrayList();
+while (results.hasMoreElements()) {
+final SearchResult result = results.nextElement();
+users.add(createUser(result));
+}
+return users;
+}
+
+private String generateADGroupSearchFilter(String groupName) {
+final StringBuilder userObjectFilter = new StringBuilder();
+userObjectFilter.append("(objectClass=");
+userObjectFilter.append(_ldapConfiguration.getUserObject());
+userObjectFilter.append(")");
+
+final StringBuilder memberOfFilter = new StringBuilder();
+String groupCnName =  _ldapConfiguration.getCommonNameAttribute() 
+ "=" +groupName + "," +  _ldapConfiguration.getBaseDn();
+memberOfFilter.append("(memberOf:1.2.840.113556.1.4.1941:=");
--- End diff --

done



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...

[karuturi]

Github user karuturi commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/609#discussion_r35308492
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
 ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.cloudstack.ldap;
+
+import org.apache.log4j.Logger;
+import org.springframework.beans.BeansException;
+import org.springframework.beans.factory.config.AutowireCapableBeanFactory;
+import org.springframework.context.ApplicationContext;
+import org.springframework.context.ApplicationContextAware;
+
+public class LdapUserManagerFactory implements ApplicationContextAware {
+public static final Logger s_logger = 
Logger.getLogger(LdapUserManagerFactory.class.getName());
+
+private static LdapUserManager adUserManager;
--- End diff --

done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/593#issuecomment-124048910
  
Okay, guys... never mind.

I see now that I have to set 2 new values, not just one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/617


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: boring resourse leaks again

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/602#issuecomment-124046942
  
LGTM :+1: 

:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Proposal] Continuos Integration Testing on ACS master.

[Daan Hoogland]

Good work Bharat, Keep in mind that many people work on this in many
ways and many attempts have failed due to nothing but lack of
consensus. I have only glanced but will take my time with it soon.

On Thu, Jul 23, 2015 at 10:50 AM, Bharat Kumar  wrote:
> Hi All,
>
> Currently we do sanity checks on master using Travis, But travis runs only 
> simulator tests (AFAIK). I think it will be better if
> we can run both BVTs and regression tests on real hardware. I am woking on 
> implementing this.
>
> Functional spec and design details.
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration
>
> Please read the FS and give your comments or suggestions.
>
> Thanks,
> Bharat.



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/593#issuecomment-124045612
  
Hi guys,

I tested the PR and it works fine. Below the steps I followed:

1. Change configuration option
2. create a new user account
  a. type set as USER
3. Log out from admin and login is as the new user
4. Create a VM
5. Destroy the VM

Was not able to see any option to restore the VM. Check the image bellow.


![image](https://cloud.githubusercontent.com/assets/5129209/8847993/40a992dc-3134-11e5-89ca-5e278d675fed.png)

Is it suppose to work only via cloudmonkey?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

[karuturi]

Github user karuturi commented on the pull request:

https://github.com/apache/cloudstack/pull/617#issuecomment-124044971
  
merging to master now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [Proposal] CoreOS support

[Daan Hoogland]

of course +1 for adding CoreOS but can we make supporting os-types
more a cloud administrator task then a cloudstack maintainer task? I
think some work has gone into that already. Some more work will
probably be needed.

On Thu, Jul 23, 2015 at 10:43 AM, Kishan Kavala
 wrote:
> Sure Sebastian. I'll check OS type list and remove outdated distros.
>
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com]
> Sent: 22 July 2015 08:09 PM
> To: dev@cloudstack.apache.org
> Subject: Re: [Proposal] CoreOS support
>
> +1
>
> Can you clean that last of OS Type while you are it, last time I checked it 
> was really long with some outdated distros…
>
> -sebastien
>
>> On Jul 22, 2015, at 4:35 PM, Somesh Naidu  wrote:
>>
>> +1
>>
>> Regards,
>> Somesh
>>
>> -Original Message-
>> From: Ahmad [mailto:aemne...@gmail.com]
>> Sent: Wednesday, July 22, 2015 10:28 AM
>> To: dev@cloudstack.apache.org
>> Subject: Re: [Proposal] CoreOS support
>>
>> +1 looking forward to this.
>>
>>
>>
>>> On Jul 22, 2015, at 1:14 PM, Kishan Kavala  wrote:
>>>
>>> I would like to add CoreOS as a supported OS type to cloudstack.
>>> CoreOS vms can be created even now by selecting OS type as "Other". There 
>>> are cloud providers supporting CoreOS offerings in production already.
>>> By making the changes mentioned at [1] I would make it easier to deploy 
>>> CoreOS Vms and also add UI support for providing cloud-config via userdata.
>>> I'll also update the documentation at [2] after making these changes.
>>>
>>> [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/CoreOS
>>> [2] https://coreos.com/os/docs/latest/booting-on-cloudstack.html
>



-- 
Daan

[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/615#issuecomment-124038730
  
@kishankavala the double encoding was already in before that commit 
(968e71a). This commit refactered some code out of the method in which the 
encoding happened.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8660 - StringUtilsTest.testGet...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/616#issuecomment-124037363
  
?! I did not notice... I swear! :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8580: user can view, expunge a...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/593#issuecomment-124036937
  
Perhaps a bit more of detail on the PR description, like test steps.

I had to look at the diff of the code in order to find the new 
configuration key. Due to that, will have to restart the tests - had create 
account / VM and destroyed VM. :(

No worries, just a hint.  ;)

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8660 - StringUtilsTest.testGet...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/616#issuecomment-124036298
  
LGTM (2*LGTM from one person is only one LGTM;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8664: Verify if queryAsyncJobR...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/619

CLOUDSTACK-8664: Verify if queryAsyncJobResult api return jobinstanceid



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8664-Verify-if-queryAsyncJobResult-api-return-jobinstanceid

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/619.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #619


commit 292734324c81f8fd1fa92606aa42e73dc583c15c
Author: Priti Sarap 
Date:   2015-07-23T09:38:35Z

CLOUDSTACK-8664: Verify if queryAsyncJobResult api return jobinstanceid




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dereference NULL return value

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/618#issuecomment-124034693
  
@kishankavala: The message has been changed.
@karuturi: Added the path. Please check

I have also made another change with respect to solving this problem of 
dereferencing of null pointer. Kindly review the changes. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Dereference NULL return value

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/618#issuecomment-124034602
  
thanks @kansal
Can you add some test cases (for null values found for instance)?
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[PROPOSAL] Snapshot Improvements

[Anshul Gangwar]

I am working on improving snapshots experience in CloudStack.

FS is available at 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Snapshot+Improvements .

Please review and provide comments/suggestions.

Regards,
Anshul

[Proposal] Continuos Integration Testing on ACS master.

[Bharat Kumar]

Hi All,

Currently we do sanity checks on master using Travis, But travis runs only 
simulator tests (AFAIK). I think it will be better if
we can run both BVTs and regression tests on real hardware. I am woking on 
implementing this.

Functional spec and design details.
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Test+bed+orchestrator+and+test+runner+to+enable+continuos+integration

Please read the FS and give your comments or suggestions.

Thanks,
Bharat.

[GitHub] cloudstack pull request: CLOUDSTACK-8634: Made changes to test_sec...

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/586#issuecomment-124023610
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [PROPOSAL] drop old upgrade code

[Daan Hoogland]

I am glad this has led to some discussion.

I do not take a strong position into how we solve the issue but want
to make sure we deal with this old code in some way. In terms of
justifying the work to my sponsor, I cannot (or do not want to) afford
to clean all of it nor to investigate into the exact amount of users
still on old versions.

The reason I choose this approach is practical: our present db scheme
is the 4.0.0 scheme with upgrades applied on it. As it is the most
practical/easiest I still stand by it, in full recognition of the
documentation need of course.

At present the opinions seem to be to diverse to get to concensus but
I am sure that is only appearance.
Talking of a 5.0 is there and it seems sensible but a long way. It
makes sense to me to not stop improving the overall quality of the
project untill then and this code is one item we should address. 5.0
is going to involve the API as well.

ignoring defects on coverity would be fine safe that we should then
also make sure the code is not run and specially not copy&pasted.

just some extra oil to burn,
Daan


On Wed, Jul 22, 2015 at 11:55 AM, Boris Schrijver  wrote:
> +1 on dropping the pre-4.x upgrade code, if done in a documented manner. 
> Instead
> of voting to drop it now shall we vote to drop it in a future release with
> documentation and put it on the roadmap? Like:
>
> At release 4.6: Initial notice to drop pre-4.x upgrade code at release 5.0.
> At release 4.6: Suppress pre-4.x upgrade code from coverity scan.
> At release 5.0: Drop pre-4.x upgrade code entirely.
> At release 5.0: Create documentation to show upgrade path from pre-4.x to 5.0.
>
> Best regards,
>
> Boris Schrijver
>
>>
>> On July 22, 2015 at 11:42 AM Koushik Das  wrote:
>>
>>
>> -1 to dropping pre-4.x upgrade code. If possible we should suppress the
>> old upgrade files from coverity scan.
>>
>> Reasons:
>> There may be users on pre-4.x versions.
>> Removing a functionality should be associated with proper documentation
>> and an advanced notification in some prior releases. This is similar to the
>> way some API is deprecated and then eventually removed.
>>
>> -Koushik
>>
>> -Original Message-
>> From: Daan Hoogland [mailto:daan.hoogl...@gmail.com]
>> Sent: Monday, 20 July 2015 17:19
>> To: dev
>> Subject: [PROPOSAL] drop old upgrade code
>>
>> LS,
>>
>> In coverity the only remaining high impact issues are concerned with
>> upgrade code. Some of it is in 4.3 and 4.5 code but most in pre-4 upgrades.
>>
>> I addressed the file Upgrade218to22.java in a PR [1] and I move that we
>> don't pull it but instead drop the file altogether together with all upgrade
>> code dating prior to 4.0.0. anybody on older versions can still upgrade to 
>> any
>> version between 4.0 and 4.5 and move on from there.
>>
>> My objective is to have no high impact issues remaining so we clearly see
>> when we are digressing beit by hand or in an automated way.
>>
>> +1?
>>
>> [1] https://github.com/apache/cloudstack/pull/603
>> --
>> Daan
>>



-- 
Daan

RE: [Proposal] CoreOS support

[Kishan Kavala]

Sure Sebastian. I'll check OS type list and remove outdated distros. 

-Original Message-
From: Sebastien Goasguen [mailto:run...@gmail.com] 
Sent: 22 July 2015 08:09 PM
To: dev@cloudstack.apache.org
Subject: Re: [Proposal] CoreOS support

+1

Can you clean that last of OS Type while you are it, last time I checked it was 
really long with some outdated distros…

-sebastien

> On Jul 22, 2015, at 4:35 PM, Somesh Naidu  wrote:
> 
> +1
> 
> Regards,
> Somesh
> 
> -Original Message-
> From: Ahmad [mailto:aemne...@gmail.com] 
> Sent: Wednesday, July 22, 2015 10:28 AM
> To: dev@cloudstack.apache.org
> Subject: Re: [Proposal] CoreOS support
> 
> +1 looking forward to this.
> 
> 
> 
>> On Jul 22, 2015, at 1:14 PM, Kishan Kavala  wrote:
>> 
>> I would like to add CoreOS as a supported OS type to cloudstack.
>> CoreOS vms can be created even now by selecting OS type as "Other". There 
>> are cloud providers supporting CoreOS offerings in production already.
>> By making the changes mentioned at [1] I would make it easier to deploy 
>> CoreOS Vms and also add UI support for providing cloud-config via userdata.
>> I'll also update the documentation at [2] after making these changes.
>> 
>> [1] https://cwiki.apache.org/confluence/display/CLOUDSTACK/CoreOS
>> [2] https://coreos.com/os/docs/latest/booting-on-cloudstack.html

[GitHub] cloudstack pull request: CLOUDSTACK-8651: [Browser Based Upload Te...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/607#discussion_r35300288
  
--- Diff: test/integration/component/test_browse_templates.py ---
@@ -1674,6 +1674,42 @@ def 
test_09_Browser_Upload_Volume_secondary_storage_resource_limits_after_deleti
 return
 
 
+@attr(tags = ["advanced", "advancedns", "smoke", "basic"], 
required_hardware="false")
+def test_browser_upload_template_incomplete(self):
+"""
+Test browser based incomplete template upload, followed by SSVM 
destroy. Template should go to UploadAbandoned state and get cleaned up.
+"""
+try:
+self.debug("= Test browser based 
incomplete template upload ")
+
+#Only register template, without uploading
+cmd = 
getUploadParamsForTemplate.getUploadParamsForTemplateCmd()
+cmd.zoneid = self.zone.id
+cmd.format = self.uploadtemplateformat
+
cmd.name=self.templatename+self.account.name+(random.choice(string.ascii_uppercase))
+cmd.account=self.account.name
+cmd.domainid=self.domain.id
+cmd.displaytext=cmd.name
+cmd.hypervisor=self.templatehypervisor
+cmd.ostypeid=self.templateostypeid
+
template_response=self.apiclient.getUploadParamsForTemplate(cmd)
+
+#Destroy SSVM, and wait for new one to start
+self.destroy_ssvm()
+
+#Verify that the template is cleaned up as part of sync-up 
during new SSVM start
+list_template_response=Template.list(
+self.apiclient,
+id=template_response.id,
+templatefilter="all",
+zoneid=self.zone.id)
+self.assertEqual(list_template_response, None, "Template is 
not cleaned up, some issue with template sync-up")
+
--- End diff --

It will not be possible to test for UploadAbandoned/Error as storage GC 
thread will run and move the templates to Inactive state. It is difficult to 
control at what point the storage GC thread runs and the assert needs happen 
before that.

Thats why I am only asserting that the template is cleaned up at the end of 
the test. The destroy_ssvm() ensures that storage GC runs at least once after 
the template sync is done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Added a null value exception in LibvirtBa...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/617#issuecomment-124001316
  
Hi Maneesha,

Yep, it has... I wrote them.

All the wrappers classes have in total 145 unit tests. Have a look at 
LibvirtComputingResourceTes, i think that's the name of the class.

As I said, due to complexity of the code that one test is poor, but most of 
the wrapper classes have 100% coverage.

No worries, I'm busy with improving a couple of tests and will also do the 
one for the backup snapshot.

Apply the change Rajani suggested so we can get it merged.

Cheers,
Wilder

Sent from my iPhone

On 23 Jul 2015, at 08:55, Maneesha P 
mailto:notificati...@github.com>> wrote:

Hi Wilder,
The LibvirtBackupSnapshotCommandWrapper class has no unit
tests.Can I add test cases that covers the exception.

Regards,
P.Maneesha.


On Thu, Jul 23, 2015 at 11:35 AM, Wilder Rodrigues 
mailto:notificati...@github.com>
> wrote:

> Hi @manuiiit 
>
> I checked the LibvirtBackupSnapshotCommandWrapper class and its coverage,
> which is still poor compared to the other classes in the KVM hypervisor
> plugin.
>
> Please, proceed with the changes @karuturi 
> suggested and I will increase the tests on the class in a separate PR.
>
> It is currently 6.9% covered, which is very bad.
>
> Cheers,
> Wilder
>
> —
> Reply to this email directly or view it on GitHub
> .
>

—
Reply to this email directly or view it on 
GitHub.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---