[GitHub] cloudstack pull request: CLOUDSTACK-8711: public_ip type resource ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/662#issuecomment-129323691
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...

[pritisarap12]

GitHub user pritisarap12 opened a pull request:

https://github.com/apache/cloudstack/pull/668

CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath

-Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
-Fixed pep8 issues

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pritisarap12/cloudstack 
CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/668.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #668


commit 23ac5588fb354b9ba36c9e0096287c700a85775f
Author: Priti Sarap 
Date:   2015-08-10T06:00:55Z

CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
-Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8693: Adding missing code in t...

[pritisarap12]

Github user pritisarap12 closed the pull request at:

https://github.com/apache/cloudstack/pull/645


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8693: Adding missing code in t...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/645#issuecomment-129316634
  
C


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/665#issuecomment-129314182
  
Updated testcase:
-Removed redundant code 
-Added validate_list function for list snapshot operation 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[pritisarap12]

Github user pritisarap12 commented on the pull request:

https://github.com/apache/cloudstack/pull/667#issuecomment-129310396
  
Updated testcase with review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8704: Schedule restart of rout...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/656#issuecomment-129300344
  
@remibergsma Thanks for testing the PR. This is a best-effort fix. The 
change just schedules the restart of the system VMs ahead of the user VMs. Now 
if there are fewer VMs for restart, there is a higher probability of all 
restart jobs getting executed at the same time by the HA-worker thread pool. In 
this case the fix won't be effective. If there are more VMs then the 
effectiveness of the fix increases.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

[manuiiit]

Github user manuiiit commented on the pull request:

https://github.com/apache/cloudstack/pull/658#issuecomment-129300171
  
@remibergsma I used it for debugging purpose as a build failed.Removed it 
now.Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36602070
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+"""
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in ["vmware"]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("This test is to be checked on VMWare only \
+Hence, skip for %s" % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+@attr(tags=["advanced", "basic"], required_hardware="false")
+def test_01_recover_VM(self):
+""" Test Restore VM on VMWare
+1. Deploy a VM without datadisk
+2. Restore the VM
+3. Verify that VM comes up in Running state
+"""
 

Re: Anyone wants to take over these orphaned PRs?

[Remi Bergsma]

Hi Mike,

Thanks! It seems the testing / verification is still to do and that is the 
work. Merging itself can be done with a one-liner. 

Are you able to verify the fix in your lab?

Sent from my iPhone

> On 10 Aug 2015, at 04:13, Mike Tutkowski  wrote:
> 
> I could take this one:
> 
> CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
> #547
> https://github.com/apache/cloudstack/pull/547
> ==> 1x LGTM
> 
> I asked this in the PR discussion, but are we under the impression that
> this code has been tested well enough? If so, I can just merge it as the
> code itself LGTM.
> 
> On Sun, Aug 9, 2015 at 12:49 PM, Remi Bergsma 
> wrote:
> 
>> Hi all,
>> 
>> These are 9 PRs sent by Likitha. If I understand correctly Likitha is no
>> longer working with Citrix/ACS. The PRs seem mostly VMware related. Some
>> have LGTM(s), most have comments about missing unit tests.
>> 
>> What do we want to do with them? There's probably not gonna be an update
>> from Likitha, so waiting for that does not make sense. Does anyone wants to
>> step in and finalize a PR? You can get the PR to your own branch and add
>> some work on top of the existing commits and finally send it as a new PR.
>> 
>> I'll add a comment to each of them. If no one wants to take it over, I
>> think we should close the PRs without merging. It's a pity, but I would
>> rather not have long lists of orphaned PRs laying around. The less PRs are
>> open, the better.
>> 
>> Any comments?
>> 
>> Regards,
>> Remi
>> 
>> Cloudstack 8612 [VMware] #562
>> https://github.com/apache/cloudstack/pull/562
>> 
>> CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm...
>> #561
>> https://github.com/apache/cloudstack/pull/561
>> 
>> CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro...
>> #556
>> https://github.com/apache/cloudstack/pull/556
>> 
>> CLOUDSTACK-8608. [VMware] System VM's failed to start due to permissions
>> issue. #555
>> https://github.com/apache/cloudstack/pull/555
>> 
>> CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ...
>> #554
>> https://github.com/apache/cloudstack/pull/554
>> ==> This one has 2xLGTM, but also some remarks to add unit tests.
>> 
>> CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat...
>> #548
>> https://github.com/apache/cloudstack/pull/548
>> ==> 1x LGTM
>> 
>> CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
>> #547
>> https://github.com/apache/cloudstack/pull/547
>> ==> 1x LGTM
>> 
>> CLOUDSTACK-8599. CS reports failure for a successful migration. #544
>> https://github.com/apache/cloudstack/pull/544
>> 
>> CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin...
>> #540
>> https://github.com/apache/cloudstack/pull/540
> 
> 
> -- 
> *Mike Tutkowski*
> *Senior CloudStack Developer, SolidFire Inc.*
> e: mike.tutkow...@solidfire.com
> o: 303.746.7302
> Advancing the way the world uses the cloud
> *™*

[GitHub] cloudstack pull request: CLOUDSTACK-8717: Failed to start instance...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/667#discussion_r36601640
  
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,192 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+"""
+Test restore running VM on VMWare with one cluster having 2 Primary Storage
+"""
+
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import cleanup_resources
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes
+   )
+
+from marvin.codes import CLUSTERTAG1, ROOT
+import time
+
+
+class TestRestoreVM(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestRestoreVM, cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+try:
+cls.skiptest = False
+if cls.hypervisor.lower() not in ["vmware"]:
+cls.skiptest = True
+return
+
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+cls._cleanup.append(cls.account)
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_cwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=CLUSTERTAG1
+)
+cls._cleanup.append(cls.service_offering_cwps)
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("This test is to be checked on VMWare only \
+Hence, skip for %s" % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+
+def tearDown(self):
+try:
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+@attr(tags=["advanced", "basic"], required_hardware="false")
--- End diff --

Since this test is specific to vmware, this can't be run on a simulator. 
Please set required_hardware=true if this is only for vmware.


---
If your project is set up for it, you can reply to this email and have you

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36601607
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
   

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36601462
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
   

[GitHub] cloudstack pull request: CLOUDSTACK-8716: Verify creation of snaps...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/665#discussion_r36601402
  
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,255 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+""" Test case for Multiple Volume Snapshot in ZWPS
+"""
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ DiskOffering,
+ Snapshot,
+ VirtualMachine,
+ StoragePool
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   list_volumes,
+   list_clusters,
+   get_template
+   )
+
+from marvin.codes import PASS, ZONETAG1, ROOT, DATA
+
+
+class TestMultipleVolumeSnapshots(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+testClient = super(TestMultipleVolumeSnapshots, 
cls).getClsTestClient()
+cls.apiclient = testClient.getApiClient()
+cls.testdata = testClient.getParsedTestDataConfig()
+
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.apiclient)
+cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.template = get_template(
+cls.apiclient,
+cls.zone.id,
+cls.testdata["ostype"])
+
+cls._cleanup = []
+
+cls.skiptest = False
+
+clus_list = list_clusters(cls.apiclient)
+
+if cls.hypervisor.lower() not in ['vmware'] or len(clus_list) < 2:
+cls.skiptest = True
+return
+
+try:
+# Create an account
+cls.account = Account.create(
+cls.apiclient,
+cls.testdata["account"],
+domainid=cls.domain.id
+)
+
+# Create user api client of the account
+cls.userapiclient = testClient.getUserApiClient(
+UserName=cls.account.name,
+DomainName=cls.account.domain
+)
+# Create Service offering
+cls.service_offering_zwps = ServiceOffering.create(
+cls.apiclient,
+cls.testdata["service_offering"],
+tags=ZONETAG1
+)
+
+cls.disk_offering_zwps = DiskOffering.create(
+cls.apiclient,
+cls.testdata["disk_offering"],
+tags=ZONETAG1
+)
+
+cls._cleanup = [
+cls.account,
+cls.service_offering_zwps,
+cls.disk_offering_zwps,
+]
+except Exception as e:
+cls.tearDownClass()
+raise e
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+cleanup_resources(cls.apiclient, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+
+def setUp(self):
+
+self.cleanup = []
+if self.skiptest:
+self.skipTest("Skip test as setup is either not VMWare or  \
+having less than 2 clusters %s" % self.hypervisor)
+
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.pools = []
   

RE: Anyone wants to take over these orphaned PRs?

[Suresh Kumar Anaparti]

Hi Remi,

I'll work on these PRs and finalize them. Will send new PRs for them. As 
Likitha is not responding, Can we take up the testcases for LGTM(s) PRs later 
and merge them?  

Thanks,
Suresh

-Original Message-
From: Remi Bergsma [mailto:rberg...@schubergphilis.com] 
Sent: Monday, 10 August 2015 12:20 AM
To: 'dev@cloudstack.apache.org'
Subject: Anyone wants to take over these orphaned PRs?

Hi all,

These are 9 PRs sent by Likitha. If I understand correctly Likitha is no longer 
working with Citrix/ACS. The PRs seem mostly VMware related. Some have LGTM(s), 
most have comments about missing unit tests.

What do we want to do with them? There's probably not gonna be an update from 
Likitha, so waiting for that does not make sense. Does anyone wants to step in 
and finalize a PR? You can get the PR to your own branch and add some work on 
top of the existing commits and finally send it as a new PR.

I'll add a comment to each of them. If no one wants to take it over, I think we 
should close the PRs without merging. It's a pity, but I would rather not have 
long lists of orphaned PRs laying around. The less PRs are open, the better.

Any comments?

Regards,
Remi

Cloudstack 8612 [VMware] #562
https://github.com/apache/cloudstack/pull/562

CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm... #561
https://github.com/apache/cloudstack/pull/561

CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro... #556
https://github.com/apache/cloudstack/pull/556

CLOUDSTACK-8608. [VMware] System VM's failed to start due to permissions issue. 
#555
https://github.com/apache/cloudstack/pull/555

CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ... #554
https://github.com/apache/cloudstack/pull/554
==> This one has 2xLGTM, but also some remarks to add unit tests.

CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat... #548
https://github.com/apache/cloudstack/pull/548
==> 1x LGTM

CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ... #547
https://github.com/apache/cloudstack/pull/547
==> 1x LGTM

CLOUDSTACK-8599. CS reports failure for a successful migration. #544
https://github.com/apache/cloudstack/pull/544

CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin... #540
https://github.com/apache/cloudstack/pull/540

[GitHub] cloudstack pull request: This branch implements the CSV and native...

[anshul1886]

Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/351#issuecomment-129292846
  
@remibergsma,
 Rebased the branch to latest master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Anyone wants to take over these orphaned PRs?

[Mike Tutkowski]

I could take this one:

CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
#547
https://github.com/apache/cloudstack/pull/547
==> 1x LGTM

I asked this in the PR discussion, but are we under the impression that
this code has been tested well enough? If so, I can just merge it as the
code itself LGTM.

On Sun, Aug 9, 2015 at 12:49 PM, Remi Bergsma 
wrote:

> Hi all,
>
> These are 9 PRs sent by Likitha. If I understand correctly Likitha is no
> longer working with Citrix/ACS. The PRs seem mostly VMware related. Some
> have LGTM(s), most have comments about missing unit tests.
>
> What do we want to do with them? There's probably not gonna be an update
> from Likitha, so waiting for that does not make sense. Does anyone wants to
> step in and finalize a PR? You can get the PR to your own branch and add
> some work on top of the existing commits and finally send it as a new PR.
>
> I'll add a comment to each of them. If no one wants to take it over, I
> think we should close the PRs without merging. It's a pity, but I would
> rather not have long lists of orphaned PRs laying around. The less PRs are
> open, the better.
>
> Any comments?
>
> Regards,
> Remi
>
> Cloudstack 8612 [VMware] #562
> https://github.com/apache/cloudstack/pull/562
>
> CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm...
> #561
> https://github.com/apache/cloudstack/pull/561
>
> CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro...
> #556
> https://github.com/apache/cloudstack/pull/556
>
> CLOUDSTACK-8608. [VMware] System VM's failed to start due to permissions
> issue. #555
> https://github.com/apache/cloudstack/pull/555
>
> CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ...
> #554
> https://github.com/apache/cloudstack/pull/554
> ==> This one has 2xLGTM, but also some remarks to add unit tests.
>
> CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat...
> #548
> https://github.com/apache/cloudstack/pull/548
> ==> 1x LGTM
>
> CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ...
> #547
> https://github.com/apache/cloudstack/pull/547
> ==> 1x LGTM
>
> CLOUDSTACK-8599. CS reports failure for a successful migration. #544
> https://github.com/apache/cloudstack/pull/544
>
> CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin...
> #540
> https://github.com/apache/cloudstack/pull/540
>
>
>


-- 
*Mike Tutkowski*
*Senior CloudStack Developer, SolidFire Inc.*
e: mike.tutkow...@solidfire.com
o: 303.746.7302
Advancing the way the world uses the cloud
*™*

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/547#issuecomment-129276125
  
The code LGTM. Are we under the assumption that it was properly tested? If 
so, I can just merge it at this point.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[remibergsma]

Github user remibergsma commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/635#discussion_r36592822
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/admin/template/PrepareTemplateCmd.java
 ---
@@ -60,6 +61,15 @@
description = "template ID of the template to be prepared 
in primary storage(s).")
 private Long templateId;
 
+@ACL(accessType = AccessType.OperateEntry)
+@Parameter(name = ApiConstants.STORAGE_ID,
+type = CommandType.UUID,
+entityType = StoragePoolResponse.class,
+required = false,
+description = "storage pool ID of the primary storage pool to 
which the template should be prepared. If it is not provided the template" +
+" is prepared on all the available primary storage 
pools.")
+private Long storageId;
--- End diff --

@kishankavala That's a conditional LGTM ;-) Please let me know if you LGTM 
as-is, or that you want something changed before LGTM. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8687: Prepare template only on...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/635#issuecomment-129228698
  
@DaanHoogland So, you suggest putting the new tests in a separate PR and 
add relevant unit tests that test the change in this PR? That sounds good to 
me. Let's change one thing per PR.

@devdeep can you align with @DaanHoogland on this please? Once that is done 
I'll merge it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack-8693: Adding missing code in t...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/645#issuecomment-129228411
  
@pritisarap12 Any update on this PR? We cannot merge with conflicts.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implemented condition that only admin or ...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/658#issuecomment-129228123
  
@manuiiit It seems an extra change got in (tools/travis/before_install.sh) 
apart from the template permission issue. Please remove it from this PR as it 
is not related (change one thing per PR). I'm OK if you send the change as 
another PR though. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Cloudstack 8612

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/562#issuecomment-129227087
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8415. SSVM shutdown during sna...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/540#issuecomment-129227064
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8601. VMFS storage added as lo...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/547#issuecomment-129227036
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8602. MigrateVirtualMachineWit...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/548#issuecomment-129227023
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8599. CS reports failure for a...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/544#issuecomment-129227052
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8610. Unable to attach 7th Dis...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/554#issuecomment-129227018
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/555#issuecomment-129227012
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8609. [VMware] VM is not acces...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/556#issuecomment-129227002
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8611. CS waits indefinitely fo...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/561#issuecomment-129226987
  
Who wants to step in and finish this work? It seems the original author is 
not able to finish it. If no one steps in, we'll have to close the PR without 
merging it so please help :-).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Anyone wants to take over these orphaned PRs?

[Remi Bergsma]

Hi all,

These are 9 PRs sent by Likitha. If I understand correctly Likitha is no longer 
working with Citrix/ACS. The PRs seem mostly VMware related. Some have LGTM(s), 
most have comments about missing unit tests.

What do we want to do with them? There's probably not gonna be an update from 
Likitha, so waiting for that does not make sense. Does anyone wants to step in 
and finalize a PR? You can get the PR to your own branch and add some work on 
top of the existing commits and finally send it as a new PR.

I'll add a comment to each of them. If no one wants to take it over, I think we 
should close the PRs without merging. It's a pity, but I would rather not have 
long lists of orphaned PRs laying around. The less PRs are open, the better.

Any comments?

Regards,
Remi

Cloudstack 8612 [VMware] #562
https://github.com/apache/cloudstack/pull/562

CLOUDSTACK-8611. CS waits indefinitely for CheckS2SVpnConnectionsComm... #561
https://github.com/apache/cloudstack/pull/561

CLOUDSTACK-8609. [VMware] VM is not accessible after a migration acro... #556
https://github.com/apache/cloudstack/pull/556

CLOUDSTACK-8608. [VMware] System VM's failed to start due to permissions issue. 
#555
https://github.com/apache/cloudstack/pull/555

CLOUDSTACK-8610. Unable to attach 7th Disk to Windows Server 2012 R2 ... #554
https://github.com/apache/cloudstack/pull/554
==> This one has 2xLGTM, but also some remarks to add unit tests.

CLOUDSTACK-8602. MigrateVirtualMachineWithVolume leaves old chain dat... #548
https://github.com/apache/cloudstack/pull/548
==> 1x LGTM

CLOUDSTACK-8601. VMFS storage added as local storage can be re-added ... #547
https://github.com/apache/cloudstack/pull/547
==> 1x LGTM

CLOUDSTACK-8599. CS reports failure for a successful migration. #544
https://github.com/apache/cloudstack/pull/544

CLOUDSTACK-8415. SSVM shutdown during snapshot operation leaves behin... #540
https://github.com/apache/cloudstack/pull/540