[GitHub] cloudstack pull request: [HOLD] CLOUDSTACK-9042: remove unused edi...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1093#issuecomment-163532209
  
Hi @resmo 

Could you please close this PR? The PR #1084 was already merged. As I 
mentioned above, the edithosts.txt is used by hyperv.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [HOLD] CLOUDSTACK-9042: remove unused edi...

[resmo]

Github user resmo closed the pull request at:

https://github.com/apache/cloudstack/pull/1093


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
  
@sanju1010 

Are you still working on this? It's currently holding us a bit because we 
need to do some work on this test as well. For instance, I want to make it rVPC 
compliant.

The point is: I'm trying to avoid conflicts when merging your changes with 
my changes.

If that would be fine, I would like to suggest I take it over. I already 
applied some fixes to the test_internal_lb.py, which was suffering from the 
same problem. See PR #1204 

Is that okay if I take it ove?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...

[priyankparihar]

GitHub user priyankparihar opened a pull request:

https://github.com/apache/cloudstack/pull/1207

CLOUDSTACK-9133: Two volume.delete usage events are getting generated…

It was happening because event triggering  was happening in 
UserVmManagerImpl.java and VolumeStateListener.java respectively. So i have 
removed it from UserVmManagerImpl.java.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/priyankparihar/cloudstack CLOUDSTACK-9133

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1207.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1207


commit 5af3fd1987e797358e9bc99232202225850ed2c1
Author: Priyank Parihar 
Date:   2015-12-10T07:14:06Z

CLOUDSTACK-9133: Two volume.delete usage events are getting generated for 
destoy vm.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1204#issuecomment-163536301
  
@wilderrodrigues @remibergsma I could only verify for KVM. 

Ran tests on Ubuntu 14.04 management/hypervisor.

```
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok

--
Ran 2 tests in 2532.875s
```

LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-163536428
  
@bhaisaab 

I thought only RMs would merge PR... isn't that so?

Plus, the PR was merged without one single person executing any test 
against it.

@remibergsma, could you please revert it so someone can actually test the 
change?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1198#discussion_r47201591
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -2558,6 +2575,62 @@ public boolean restartNetwork(Long networkId, 
Account callerAccount, User caller
 }
 }
 
+/* If there are redundant routers in the isolated network, we follow 
the steps to make the network working better
+ *  (1) destroy backup router if exists
+ *  (2) create new backup router
+ *  (3) destroy master router (then the backup will become master)
+ *  (4) create a new router as backup router.
+ */
+private boolean restartGuestNetworkWithRedundantRouters(NetworkVO 
network, List routers, ReservationContext context) throws 
ResourceUnavailableException, ConcurrentOperationException, 
InsufficientCapacityException {
+Account caller = CallContext.current().getCallingAccount();
+long callerUserId = CallContext.current().getCallingUserId();
+
+// check the master and backup redundant state
+DomainRouterVO masterRouter = null;
+DomainRouterVO backupRouter = null;
+if (routers != null && routers.size() == 1) {
+masterRouter = routers.get(0);
+} if (routers != null && routers.size() == 2) {
--- End diff --

Avoid magic numbers by putting them in constants.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-163537454
  
@wilderrodrigues it was merged before the freeze so I didn't revert it as 
RM. But you are right about the not being tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1198#discussion_r47201935
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -2558,6 +2575,62 @@ public boolean restartNetwork(Long networkId, 
Account callerAccount, User caller
 }
 }
 
+/* If there are redundant routers in the isolated network, we follow 
the steps to make the network working better
+ *  (1) destroy backup router if exists
+ *  (2) create new backup router
+ *  (3) destroy master router (then the backup will become master)
+ *  (4) create a new router as backup router.
+ */
+private boolean restartGuestNetworkWithRedundantRouters(NetworkVO 
network, List routers, ReservationContext context) throws 
ResourceUnavailableException, ConcurrentOperationException, 
InsufficientCapacityException {
+Account caller = CallContext.current().getCallingAccount();
+long callerUserId = CallContext.current().getCallingUserId();
+
+// check the master and backup redundant state
+DomainRouterVO masterRouter = null;
+DomainRouterVO backupRouter = null;
+if (routers != null && routers.size() == 1) {
+masterRouter = routers.get(0);
+} if (routers != null && routers.size() == 2) {
+DomainRouterVO router1 = routers.get(0);
+DomainRouterVO router2 = routers.get(1);
+if (router1.getRedundantState() == RedundantState.MASTER || 
router2.getRedundantState() == RedundantState.BACKUP) {
+masterRouter = router1;
+backupRouter = router2;
+} else if (router1.getRedundantState() == 
RedundantState.BACKUP || router2.getRedundantState() == RedundantState.MASTER) {
+masterRouter = router2;
+backupRouter = router1;
+} else { // both routers are in UNKNOWN state
+masterRouter = router1;
+backupRouter = router2;
+}
+}
+
+NetworkOfferingVO offering = 
_networkOfferingDao.findByIdIncludingRemoved(network.getNetworkOfferingId());
+DeployDestination dest = new 
DeployDestination(_dcDao.findById(network.getDataCenterId()), null, null, null);
+List providersToImplement = 
getNetworkProviders(network.getId());
+
+// destroy backup router
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), caller, 
callerUserId);
+}
+// create new backup router
+implementNetworkElements(dest, context, network, offering, 
providersToImplement);
+
+// destroy master router
+if (masterRouter != null) {
+try {
+Thread.sleep(1); // wait 10s for the 
keepalived/conntrackd on backup router
--- End diff --

The ```implementNetworkElements()``` is a blocking call. So, you don't need 
the sleep here. Even if you would, 10 seconds is way too much.

I would suggest that first you destroy the master router! The back becomes 
master in no time, so no sleep needed. Then you spin up a new router (which 
will be backup, and destroy the previous (old) master. Serious, no sleep needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[kishankavala]

Github user kishankavala commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163538722
  
You are right @ustcweizhou . My branch was not up to date. Applied the 
patch on latest master.
- Able to see vpcname and vpcid in listRouters response
- Keyword search with vpc name also worked.

LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163539316
  
Did the regression tests:

[1197.network.results.txt](https://github.com/apache/cloudstack/files/57825/1197.network.results.txt)

[1197.vpc.results.txt](https://github.com/apache/cloudstack/files/57826/1197.vpc.results.txt)
and a review: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-163539499
  
Hi @ustcweizhou,

I made a couple of comments in your code that would need addressing. Could 
you have a look at that?

In addition, would you mind improving the smoke/test_vpc_redundant.py in 
order to add a check for the improvements you added?

Did you test this against RVR networks as well?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1198#discussion_r47202713
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -2558,6 +2575,62 @@ public boolean restartNetwork(Long networkId, 
Account callerAccount, User caller
 }
 }
 
+/* If there are redundant routers in the isolated network, we follow 
the steps to make the network working better
+ *  (1) destroy backup router if exists
+ *  (2) create new backup router
+ *  (3) destroy master router (then the backup will become master)
+ *  (4) create a new router as backup router.
+ */
+private boolean restartGuestNetworkWithRedundantRouters(NetworkVO 
network, List routers, ReservationContext context) throws 
ResourceUnavailableException, ConcurrentOperationException, 
InsufficientCapacityException {
+Account caller = CallContext.current().getCallingAccount();
+long callerUserId = CallContext.current().getCallingUserId();
+
+// check the master and backup redundant state
+DomainRouterVO masterRouter = null;
+DomainRouterVO backupRouter = null;
+if (routers != null && routers.size() == 1) {
+masterRouter = routers.get(0);
+} if (routers != null && routers.size() == 2) {
+DomainRouterVO router1 = routers.get(0);
+DomainRouterVO router2 = routers.get(1);
+if (router1.getRedundantState() == RedundantState.MASTER || 
router2.getRedundantState() == RedundantState.BACKUP) {
+masterRouter = router1;
+backupRouter = router2;
+} else if (router1.getRedundantState() == 
RedundantState.BACKUP || router2.getRedundantState() == RedundantState.MASTER) {
+masterRouter = router2;
+backupRouter = router1;
+} else { // both routers are in UNKNOWN state
+masterRouter = router1;
+backupRouter = router2;
+}
+}
+
+NetworkOfferingVO offering = 
_networkOfferingDao.findByIdIncludingRemoved(network.getNetworkOfferingId());
+DeployDestination dest = new 
DeployDestination(_dcDao.findById(network.getDataCenterId()), null, null, null);
+List providersToImplement = 
getNetworkProviders(network.getId());
+
+// destroy backup router
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), caller, 
callerUserId);
+}
+// create new backup router
+implementNetworkElements(dest, context, network, offering, 
providersToImplement);
+
+// destroy master router
+if (masterRouter != null) {
+try {
+Thread.sleep(1); // wait 10s for the 
keepalived/conntrackd on backup router
--- End diff --

if we can make sure that the keepalived/conntrackd are running when the VR 
becomes Running.
I think the sleep is needed, no matter we destroy/create backup or master 
router at first, because there is always a state change from BACKUP to MASTER.

in your method, the sleep is not needed at the first step, but it does at 
the second step.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[Sanjeev N]

@wilder, I am ok with it. You can take it over.
One comment, is ostype "Other PV (64-bit)" valid for other hypervisors
otherthan Xenserver? And vmware template format should be in .ova
The one you have mentioned in the Services class won't work.

On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues  wrote:

> Github user wilderrodrigues commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
>
> @sanju1010
>
> Are you still working on this? It's currently holding us a bit because
> we need to do some work on this test as well. For instance, I want to make
> it rVPC compliant.
>
> The point is: I'm trying to avoid conflicts when merging your changes
> with my changes.
>
> If that would be fine, I would like to suggest I take it over. I
> already applied some fixes to the test_internal_lb.py, which was suffering
> from the same problem. See PR #1204
>
> Is that okay if I take it ove?
>
> Cheers,
> Wilder
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1204#issuecomment-163539777
  
Thanks, @borisroman!

@michaelandersen, have you already tested this against Xen?

By the way, I did both already.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9099: SecretKey is returned fr...

[kansal]

Github user kansal commented on the pull request:

https://github.com/apache/cloudstack/pull/1152#issuecomment-163539799
  
@DaanHoogland Sure will try. Will take some time as I have to go through 
the documentation first. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feedback of my Phd work in Cloudstack Project

[Anshul Gangwar]

Before giving feedback I have some questions

1) What do you mean by "correctly predict 60% commits”?
2) What are the feature measures you are giving as input here to system 
(prediction model)?
3) What kind of output you are expecting?

Web page link you have provided is not working.

> On 10-Dec-2015, at 5:01 AM, Igor Wiese  wrote:
> 
> Hi, Cloudstack Community.
> 
> My name is Igor Wiese, phd Student from Brazil. In my research, I am
> investigating two important questions: What makes two files change
> together? Can we predict when they are going to co-change again?
> 
> I've tried to investigate this question on the Cloudstack project. I've
> collected data from issue reports, discussions and commits and using some
> machine learning techniques to build a prediction model.
> 
> I collected a total of 141 commits in which a pair of files changed
> together and could correctly predict 60% commits. These were the most
> useful information for predicting co-changes of files:
> 
> - sum of number of lines of code added, modified and removed,
> 
> - number of words used to describe and discuss the issues,
> 
> - number of comments in each issue,
> 
> - median value of closeness, a social network measure obtained from issue
> comments, and
> 
> - median value of constraint, a social network measure obtained from issue
> comments.
> 
> To illustrate, consider the following example from our analysis. For
> release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits. In
> another 2 commits, only the first file changed, but not the second.
> Collecting contextual information for each commit made to first file in the
> previous release (4.3), we were able to predict all 3 commits in which both
> files changed together in release 4.4, and we only issued 0 false
> positives. For this pair of files, the most important contextual
> information was the number of lines of code added, removed and modified in
> each commit,the number of comments in each issue, and social network
> measures (closeness, density, constraint, hierarchy) obtained from issue
> comments.
> 
> - Do these results surprise you? Can you think in any explanation for the
> results?
> 
> - Do you think that our rate of prediction is good enough to be used for
> building tool support for the software community?
> 
> - Do you have any suggestion on what can be done to improve the change
> recommendation?
> 
> You can visit our webpage to inspect the results in details:
> http://flosscoach.com/index.php/17-cochanges/67-cloudstack
> 
> All the best,
> Igor Wiese
> Phd Candidate

Deleted projects cannot be billed

[Jochim, Ingo]

Hi all,

does anybody knows how deletion of a project works and why records get deleted 
or replace by NULL?

A much more detailed description of the issue got posted by Norbert here:
https://issues.apache.org/jira/browse/CLOUDSTACK-9096

Thanks and regards,
Ingo



Teaser:

Deleted projects cannot be billed because usage data is not available any more 
from the moment of project deletion. If the project is deleted in the middle of 
the month all usage data of this month is lost:

If you delete a project
1. the database record in cloud.project_view is removed 
2. the name field in the cloud.projects table is set to NULL, thus the original 
project name is completely lost.
3. the usage records for this project are not available any more via 
api/cloudmonkey 
(4. the usage records are still in the database and available via vm_name for 
example)

Re: [GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

[Sanjeev N]

@Wilder, forgot to mention, either we should also add template for LXC or
skip the test for LXC.

On Thu, Dec 10, 2015 at 2:40 PM, Sanjeev N  wrote:

> @wilder, I am ok with it. You can take it over.
> One comment, is ostype "Other PV (64-bit)" valid for other hypervisors
> otherthan Xenserver? And vmware template format should be in .ova
> The one you have mentioned in the Services class won't work.
>
> On Thu, Dec 10, 2015 at 2:03 PM, wilderrodrigues 
> wrote:
>
>> Github user wilderrodrigues commented on the pull request:
>>
>> https://github.com/apache/cloudstack/pull/1156#issuecomment-163533177
>>
>> @sanju1010
>>
>> Are you still working on this? It's currently holding us a bit
>> because we need to do some work on this test as well. For instance, I want
>> to make it rVPC compliant.
>>
>> The point is: I'm trying to avoid conflicts when merging your changes
>> with my changes.
>>
>> If that would be fine, I would like to suggest I take it over. I
>> already applied some fixes to the test_internal_lb.py, which was suffering
>> from the same problem. See PR #1204
>>
>> Is that okay if I take it ove?
>>
>> Cheers,
>> Wilder
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[michaelandersen]

Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1204#issuecomment-163539898
  
Ran tests on Xenserver 6.2:

Results:
```
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok

--
Ran 2 tests in 1064.773s

OK

```
Environment:

```
1 XenServer 6.2
Management Server on CentOS 7.1
```

Test command:
```
nosetests --with-marvin 
--marvin-config=/data/shared/marvin/mct-zone1-xen1.cfg -a 
tags=advanced,required_hardware=true test_internal_lb.py
```

LGTM!
good work @wilderrodrigues 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-163540200
  
@wilderrodrigues thanks for review!
This PR apply on redundant networks, not redundant VR for VPC.
I tested it several times. you may get a result from my first comment of 
this PR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163540517
  
One of the tests (network_results) says:

Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : FAILED ===
FAIL

```
==
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/component/test_routers_network_ops.py",
 line 290, in test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true
"Attempt to retrieve google.com index page should be successful!"
AssertionError: Attempt to retrieve google.com index page should be 
successful!
```

Was it rebased with latest master before tests?

So, do not merge yet. Unless you redo the failed test manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-163541774
  
Hi @ustcweizhou,

The content is a bit misleading because you used the 
```VpcVirtualNetworkApplianceService``` instead of 
```VirtualNetworkApplianceService```.

Concerning the tests, I know you did that. But if tomorrow (or within a 
week) we have to improve it, we will have to do the tests, manually, again. So 
improving the existing integration test will help everybody.

Could you also apply the changes I mentioned against the code, please?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163541483
  
@wilderrodrigues yes, it is rebased with latest master.
going through the files changed in this PR, I think the failure is not 
related to it.
This PR does not touch any operation on networks/vpcs, etc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1204#issuecomment-163542058
  
Thanks, @michaelandersen!

Ping @remibergsma @DaanHoogland - this one is ready to be merged.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1140#issuecomment-163542373
  
@harikrishna-patnala This is reverted because of the lack of test report, 
not the logic of your code. If you feel it must go in anyway please rebase the 
code and make a new PR, make sure you add test instruction to up the chance 
reviewers actually test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

[priyankparihar]

Github user priyankparihar commented on the pull request:

https://github.com/apache/cloudstack/pull/815#issuecomment-163542539
  
@DaanHoogland I did this change because UI does not allow  migration 
between different versions of hyper-visors of  but sometimes user wants to do 
migration from  Lower to Higher Version. So now he can do it via API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1198#discussion_r47204055
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -2558,6 +2575,62 @@ public boolean restartNetwork(Long networkId, 
Account callerAccount, User caller
 }
 }
 
+/* If there are redundant routers in the isolated network, we follow 
the steps to make the network working better
+ *  (1) destroy backup router if exists
+ *  (2) create new backup router
+ *  (3) destroy master router (then the backup will become master)
+ *  (4) create a new router as backup router.
+ */
+private boolean restartGuestNetworkWithRedundantRouters(NetworkVO 
network, List routers, ReservationContext context) throws 
ResourceUnavailableException, ConcurrentOperationException, 
InsufficientCapacityException {
+Account caller = CallContext.current().getCallingAccount();
+long callerUserId = CallContext.current().getCallingUserId();
+
+// check the master and backup redundant state
+DomainRouterVO masterRouter = null;
+DomainRouterVO backupRouter = null;
+if (routers != null && routers.size() == 1) {
+masterRouter = routers.get(0);
+} if (routers != null && routers.size() == 2) {
+DomainRouterVO router1 = routers.get(0);
+DomainRouterVO router2 = routers.get(1);
+if (router1.getRedundantState() == RedundantState.MASTER || 
router2.getRedundantState() == RedundantState.BACKUP) {
+masterRouter = router1;
+backupRouter = router2;
+} else if (router1.getRedundantState() == 
RedundantState.BACKUP || router2.getRedundantState() == RedundantState.MASTER) {
+masterRouter = router2;
+backupRouter = router1;
+} else { // both routers are in UNKNOWN state
+masterRouter = router1;
+backupRouter = router2;
+}
+}
+
+NetworkOfferingVO offering = 
_networkOfferingDao.findByIdIncludingRemoved(network.getNetworkOfferingId());
+DeployDestination dest = new 
DeployDestination(_dcDao.findById(network.getDataCenterId()), null, null, null);
+List providersToImplement = 
getNetworkProviders(network.getId());
+
+// destroy backup router
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), caller, 
callerUserId);
+}
+// create new backup router
+implementNetworkElements(dest, context, network, offering, 
providersToImplement);
+
+// destroy master router
+if (masterRouter != null) {
+try {
+Thread.sleep(1); // wait 10s for the 
keepalived/conntrackd on backup router
--- End diff --

It's a blocking call, you don't need it. Also, the keepalived is started 
with the kernel module. It would be way easier to prove the behaviour with an 
automated test.

If you don't feel confident with writing the test, I can do it after 
christmas/new year and change the java code as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/823#issuecomment-163550095
  
@DaanHoogland : No, it needn't not be an exact match but the new one should 
be a superset of the current one. According to your scenario, as the new one 
supports (x,y) as well as supports an extra tag (z). The interpretation will be 
more clear if we think of this in terms of venn diagram.

The migration will fail in running mode. Dynamic scaling cannot be done. It 
will only be done on reboot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1198#discussion_r47204914
  
--- Diff: 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
 ---
@@ -2558,6 +2575,62 @@ public boolean restartNetwork(Long networkId, 
Account callerAccount, User caller
 }
 }
 
+/* If there are redundant routers in the isolated network, we follow 
the steps to make the network working better
+ *  (1) destroy backup router if exists
+ *  (2) create new backup router
+ *  (3) destroy master router (then the backup will become master)
+ *  (4) create a new router as backup router.
+ */
+private boolean restartGuestNetworkWithRedundantRouters(NetworkVO 
network, List routers, ReservationContext context) throws 
ResourceUnavailableException, ConcurrentOperationException, 
InsufficientCapacityException {
+Account caller = CallContext.current().getCallingAccount();
+long callerUserId = CallContext.current().getCallingUserId();
+
+// check the master and backup redundant state
+DomainRouterVO masterRouter = null;
+DomainRouterVO backupRouter = null;
+if (routers != null && routers.size() == 1) {
+masterRouter = routers.get(0);
+} if (routers != null && routers.size() == 2) {
+DomainRouterVO router1 = routers.get(0);
+DomainRouterVO router2 = routers.get(1);
+if (router1.getRedundantState() == RedundantState.MASTER || 
router2.getRedundantState() == RedundantState.BACKUP) {
+masterRouter = router1;
+backupRouter = router2;
+} else if (router1.getRedundantState() == 
RedundantState.BACKUP || router2.getRedundantState() == RedundantState.MASTER) {
+masterRouter = router2;
+backupRouter = router1;
+} else { // both routers are in UNKNOWN state
+masterRouter = router1;
+backupRouter = router2;
+}
+}
+
+NetworkOfferingVO offering = 
_networkOfferingDao.findByIdIncludingRemoved(network.getNetworkOfferingId());
+DeployDestination dest = new 
DeployDestination(_dcDao.findById(network.getDataCenterId()), null, null, null);
+List providersToImplement = 
getNetworkProviders(network.getId());
+
+// destroy backup router
+if (backupRouter != null) {
+_routerService.destroyRouter(backupRouter.getId(), caller, 
callerUserId);
+}
+// create new backup router
+implementNetworkElements(dest, context, network, offering, 
providersToImplement);
+
+// destroy master router
+if (masterRouter != null) {
+try {
+Thread.sleep(1); // wait 10s for the 
keepalived/conntrackd on backup router
--- End diff --

@wilderrodrigues 
I made this change for 4.2.1 at first. I met some issues during the 
restartnetwork because of the keepalived/conntrackd, hence I added the sleep. 
10 seconds is enough to wait the services to be running.
I did not check the difference between keepalived on Debian 7.0.0 and 
Debian 7.9.0, so I thought the issue still exist.

I am busy on other issues and have no time on writing the test, automated 
test and improvement are welcome.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163554166
  
@ustcweizhou, @wilderrodrigues is right to ask for a retest anyway, will do


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[ustcweizhou]

Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-163554256
  
@wilderrodrigues 

I used VirtualNetworkApplianceService at first, and met an issue like:
"spring autowiring with unique beans: Spring expected single matching bean 
but found 2"
this is because some functions are implemented in both of 
VirtualNetworkApplianceManagerImpl and VpcVirtualNetworkApplianceManagerImpl .

I changed it back to VirtualNetworkApplianceService  just now, the 
compilation succeed, the issue  does not exist any more, weird. 

Anyway, I think it is not important. that is the same to definition in 
api/src/org/apache/cloudstack/api/BaseCmd.java:
public VpcVirtualNetworkApplianceService _routerService;



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-163557163
  
I know this issue. You can get it working with @Autowire and @Quialifier 
annotations. If BaseCmd does the same, then it should be fine.

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163560328
  
LGTM Tested the actual feature:

Created a VPC:
![screen shot 2015-12-10 at 10 49 
05](https://cloud.githubusercontent.com/assets/1630096/11712205/b9f2dfee-9f2b-11e5-9840-9c7c4f991cf8.png)

Tried to search for it:
![screen shot 2015-12-10 at 10 53 
21](https://cloud.githubusercontent.com/assets/1630096/11712280/474ee108-9f2c-11e5-8aab-560c45cfd0b5.png)

Tried a search that should result noting:
![screen shot 2015-12-10 at 10 53 
29](https://cloud.githubusercontent.com/assets/1630096/11712285/50efcda8-9f2c-11e5-97b3-efff2d3a2e94.png)

Before merge, be sure all integration tests pass. If you need help, let me 
know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1201#issuecomment-163562169
  
LGTM, both users and admins can login with/without this plugin enabled.

User login with plugin disabled:
![screen shot 2015-12-10 at 10 52 
03](https://cloud.githubusercontent.com/assets/1630096/11712364/db9e8da4-9f2c-11e5-9ba2-40bce6da2aba.png)

Enabled plugin, restarted mgt afterwards:
![screen shot 2015-12-10 at 10 53 
29](https://cloud.githubusercontent.com/assets/1630096/11712356/ce88281e-9f2c-11e5-87bf-56f403b95a06.png)

Admin with plugin enabled:
![screen shot 2015-12-10 at 10 55 
44](https://cloud.githubusercontent.com/assets/1630096/11712349/c34388b8-9f2c-11e5-988e-b7f795dfdf36.png)

User with plugin enabled:
![screen shot 2015-12-10 at 10 56 
05](https://cloud.githubusercontent.com/assets/1630096/11712346/b9fab7f4-9f2c-11e5-99e7-ce1f0694269b.png)

Pinging @DaanHoogland to also review.

I will also start some integration tests to be sure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Implement Quota service

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/768#issuecomment-163565254
  
@milamberspace okay, sending a new PR for that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1208#issuecomment-163566614
  
cc @remibergsma @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[bhaisaab]

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1208

ui/quota: Make the quota UI plugin icon gray

Makes the quota ui plugin icon gray, based on comment at:
https://github.com/apache/cloudstack/pull/768#issuecomment-163364606

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack master-quota-greyicon

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1208


commit 16d84aa506983c87fc0a59efb47394549d6defcd
Author: Rohit Yadav 
Date:   2015-12-10T10:12:53Z

ui/quota: Make the quota UI plugin icon gray

Makes the quota ui plugin icon gray, based on comment at:
https://github.com/apache/cloudstack/pull/768#issuecomment-163364606

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1204


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[borisroman]

Github user borisroman commented on the pull request:

https://github.com/apache/cloudstack/pull/1208#issuecomment-163568069
  
@wilderrodrigues @remibergsma @DaanHoogland LGTM :+1: 

Better styling this way.

No unit or integration tests run. Though in this case I don't think it's 
necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1196#issuecomment-163570286
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 18877.209s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1208#issuecomment-163570500
  
I don't think it is. :D

Would be nice to see a review from a colour-blind person though. :D

LGTM

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1208#issuecomment-163574449
  
I like angry fruit salads, how about a grey icon that colours all up on 
hovering?

serious? ok, i'm fine with both.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1201#issuecomment-163578041
  
Integration tests are also OK:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
Test for port forwarding on source NAT ... === TestName: 
test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: 
test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : 
SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS 
===
ok
Test for Router rules for network rules on acquired public IP ... === 
TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : 
SUCCESS ===
ok

--
Ran 33 tests in 19982.059s

OK
```


And:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[wilderrodrigues]

Github user wilderrodrigues commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1196#discussion_r47212450
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixHelper.java
 ---
@@ -236,4 +236,15 @@ public static String getProductVersion(final 
Host.Record record) {
 }
 return prodVersion;
 }
+
+public static String getPVbootloaderArgs(String guestOS) {
+if (guestOS.startsWith("SUSE Linux Enterprise Server")) {
+if (guestOS.contains("64-bit")) {
+return "--kernel /boot/vmlinuz-xen --ramdisk 
/boot/initrd-xen";
+} else if (guestOS.contains("32-bit")) {
+return "--kernel /boot/vmlinuz-xenpae --ramdisk 
/boot/initrd-xenpae";
+}
+}
+return "";
+}
--- End diff --

Change looks good and simple. Could you please add an unit test to cover 
the new method?

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9127 Missing PV-bootloader-arg...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1196#issuecomment-163578421
  
Thanks for testing and adding the screenshots, @SudharmaJain!

Waiting for you reply on the unit test question I asked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1201#issuecomment-163579051
  
Had a look at the code and trusting @remibergsma his test work: LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1201


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163579922
  
I reran the test and it failed again:
```
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : FAILED ===
FAIL
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok

==
FAIL: Test redundant router internals
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/component/test_routers_network_ops.py",
 line 483, in test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false
"Attempt to retrieve google.com index page should be successful once 
rule is added!"
AssertionError: Attempt to retrieve google.com index page should be 
successful once rule is added!
 >> begin captured logging << 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9131: Create a new API to chec...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1201#issuecomment-163583068
  
... slightly late, LGTM (did code review)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9125: Brazilian translations

[GabrielBrascher]

Github user GabrielBrascher commented on the pull request:

https://github.com/apache/cloudstack/pull/1194#issuecomment-163584797
  
I think it would be better to change “Quota” by “cota”. Both are 
correct, but Brazilians are used with “cota”.

It seems that the Jenkins had a problem. You should try forcing push it and 
see if the Jenkins build finishes it properly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-163586170
  
@nvazquez I suggested to add the config to the test itself, but I gave it 
some more thought and I agree with you that the test should just assume the 
config is in place. 

Thanks for the documents, but it is still a lot to digest. What about 
step-wise instructions on what to create and in which order?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9125: Brazilian translations

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/1194#issuecomment-163586496
  
@GabrielBrascher Noted, I think I need to submit translation via Transfix. 
I am working on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1187#issuecomment-163590636
  
LGTM, I hit the unit test failure today with Jenkins while building master 
branch (4.7) and @nlivens 's fix worked for me :)
cc @DaanHoogland @remibergsma pl do merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1185#issuecomment-163590671
  
LGTM, I hit the unit test failure today with Jenkins while building master 
branch (4.7) and @nlivens 's fix worked for me :)
cc @DaanHoogland @remibergsma pl do merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

AW: Run Windows on top of KVM+virtio? Watch out for Windows updates, system unbootable!

[Jochim, Ingo]

Hi,

you can use the virtio drivers from the Fedora Project.
I didn't have problems on W2k12 and W2k12R2.

https://fedoraproject.org/wiki/Windows_Virtio_Drivers

Regards,
Ingo


-Ursprüngliche Nachricht-
Von: Nux! [mailto:n...@li.nux.ro] 
Gesendet: Mittwoch, 9. Dezember 2015 10:42
An: dev
Cc: Cloudstack Users List
Betreff: Run Windows on top of KVM+virtio? Watch out for Windows updates, 
system unbootable!

Hi,

Just a quick heads-up! 
Someone on the CentOS ML reported his Windows 2008r2 VM on top of KVM+VirtIO PV 
ended up unbootable after he installed the SUSE Network and Storage drivers 
from the Optional Updates channel.
I've just checked now and it's the case, the system blue screens after reboot. 
Will test 2012r2 shortly.


It'd be best if you don't install those updates/drivers for now, looks like 
someone in Redmond didn't do his homework.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

-- 
This email was Virus checked by UTM 9. http://www.sophos.com

-- 
This email was Virus checked by UTM 9. http://www.sophos.com

Re: Feedback of my Phd work in Cloudstack Project

[Igor Wiese]

Hi Anshul. Thanks for your answer

First of all, sorry about the webpage. I checked and now it is working
http://flosscoach.com/index.php/17-cochanges/67-cloudstack. Let me know if
you still having problem to access the webpage.

About your questions:

1) What do you mean by "correctly predict 60% commits”?
-  Let's suppose that you changed cloud/hypervisor/XenServerGuru.java in an
issue 1. After commit this file, which other files you could change to
complete the changes? Then, we can collect data from previous
issues/commits when XenServerGuru.java changed in the previous release and
recomend to you which other files are more prone to change together in this
new issue that you are working. In 60% of the commits when we applied our
approach, we could correctly predict (recommend) files to change together
with cloud/hypervisor/XenServerGuru.java.

In the webpage you can check all "combinations" (pairs of files) that we
tested to cloudstack project based on releases 4.1, 4.2, 4.3 and 4.4

2) What are the feature measures you are giving as input here to system
(prediction model)?
In total we used 21 metrics: from Issues, communication/experience and
commit. Each pair of file that we tested used different combinations of
measures. From issues for example we used the name of assignee, reporter,
size of description+discussion. From the communication we got the number of
comments, if older commiters from the same size also made comments, social
network from issues/Pull Requests, etc. From commit the number of lines
added, modified, removed.

3) What kind of output you are expecting?
Let's suppose two real scenarios. You are a newcomer, you have difficult to
complete your issues because you don't read much code or don't know much
about the architecture. In such cases newcomers could use our approach (we
are building a tool) to receive recommendations while performing the task.

In the other hand, let's suppose that you are a core member and you are
reviewing the Pull Request, we could give you a list of files to check, if
all of them are in the commit.

All the best,
Igor Wiese


2015-12-10 7:11 GMT-02:00 Anshul Gangwar :

> Before giving feedback I have some questions
>
> 1) What do you mean by "correctly predict 60% commits”?
> 2) What are the feature measures you are giving as input here to system
> (prediction model)?
> 3) What kind of output you are expecting?
>
> Web page link you have provided is not working.
>
> > On 10-Dec-2015, at 5:01 AM, Igor Wiese  wrote:
> >
> > Hi, Cloudstack Community.
> >
> > My name is Igor Wiese, phd Student from Brazil. In my research, I am
> > investigating two important questions: What makes two files change
> > together? Can we predict when they are going to co-change again?
> >
> > I've tried to investigate this question on the Cloudstack project. I've
> > collected data from issue reports, discussions and commits and using some
> > machine learning techniques to build a prediction model.
> >
> > I collected a total of 141 commits in which a pair of files changed
> > together and could correctly predict 60% commits. These were the most
> > useful information for predicting co-changes of files:
> >
> > - sum of number of lines of code added, modified and removed,
> >
> > - number of words used to describe and discuss the issues,
> >
> > - number of comments in each issue,
> >
> > - median value of closeness, a social network measure obtained from issue
> > comments, and
> >
> > - median value of constraint, a social network measure obtained from
> issue
> > comments.
> >
> > To illustrate, consider the following example from our analysis. For
> > release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> > "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits.
> In
> > another 2 commits, only the first file changed, but not the second.
> > Collecting contextual information for each commit made to first file in
> the
> > previous release (4.3), we were able to predict all 3 commits in which
> both
> > files changed together in release 4.4, and we only issued 0 false
> > positives. For this pair of files, the most important contextual
> > information was the number of lines of code added, removed and modified
> in
> > each commit,the number of comments in each issue, and social network
> > measures (closeness, density, constraint, hierarchy) obtained from issue
> > comments.
> >
> > - Do these results surprise you? Can you think in any explanation for the
> > results?
> >
> > - Do you think that our rate of prediction is good enough to be used for
> > building tool support for the software community?
> >
> > - Do you have any suggestion on what can be done to improve the change
> > recommendation?
> >
> > You can visit our webpage to inspect the results in details:
> > http://flosscoach.com/index.php/17-cochanges/67-cloudstack
> >
> > All the best,
> > Igor Wiese
> > Phd Candidate
>
>


-- 
=
Igor Scaliante Wiese
Ph

Re: Feedback of my Phd work in Cloudstack Project

[Vadim Kimlaychuk]

Do I understand correctly that purpose of this work is to find tightly 
coupled classes automatically in order to inverse dependency later on?


Vadim.

On 2015-12-10 01:31, Igor Wiese wrote:


Hi, Cloudstack Community.

My name is Igor Wiese, phd Student from Brazil. In my research, I am
investigating two important questions: What makes two files change
together? Can we predict when they are going to co-change again?

I've tried to investigate this question on the Cloudstack project. I've
collected data from issue reports, discussions and commits and using 
some

machine learning techniques to build a prediction model.

I collected a total of 141 commits in which a pair of files changed
together and could correctly predict 60% commits. These were the most
useful information for predicting co-changes of files:

- sum of number of lines of code added, modified and removed,

- number of words used to describe and discuss the issues,

- number of comments in each issue,

- median value of closeness, a social network measure obtained from 
issue

comments, and

- median value of constraint, a social network measure obtained from 
issue

comments.

To illustrate, consider the following example from our analysis. For
release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
"cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits. 
In

another 2 commits, only the first file changed, but not the second.
Collecting contextual information for each commit made to first file in 
the
previous release (4.3), we were able to predict all 3 commits in which 
both

files changed together in release 4.4, and we only issued 0 false
positives. For this pair of files, the most important contextual
information was the number of lines of code added, removed and modified 
in

each commit,the number of comments in each issue, and social network
measures (closeness, density, constraint, hierarchy) obtained from 
issue

comments.

- Do these results surprise you? Can you think in any explanation for 
the

results?

- Do you think that our rate of prediction is good enough to be used 
for

building tool support for the software community?

- Do you have any suggestion on what can be done to improve the change
recommendation?

You can visit our webpage to inspect the results in details:
http://flosscoach.com/index.php/17-cochanges/67-cloudstack [1]

All the best,
Igor Wiese
Phd Candidate




Links:
--
[1] http://flosscoach.com/index.php/17-cochanges/67-cloudstack

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-9129: list vpc routers b...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1197#issuecomment-163604337
  
That's odd! :(

Same test was executed by @remibergsma and I this week and everything went 
fine.

But if that was rebased, the test should now be under ```smoke``` instead 
of ```component```. Although it would not change anything in the test itself.

@remibergsma: could you please put one of you 8 bubble to run the 
test_network_ops.py ? You have your one-liner! ;)

The MCT-Shared has also changed. The run tests script is getting the tests 
from smoke instead of component. 

Cheers,
Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9134: set device_id as the fir...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1209

CLOUDSTACK-9134: set device_id as the first device_id not in use instead of 
nic count


when we restart vpc tiers, the old nics will be removed, and create a new 
nic.
however, the device_id was set to the nic count, which may be already used.
this commit get the first device_id not in use as the device_id of new nic.

This issue also happen when we add multiple networks to a vm and remove 
them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack free-deviceid

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1209


commit acfc19dc8285a07412ee0078fbc13d7319d5be8b
Author: Wei Zhou 
Date:   2015-12-10T12:26:02Z

CLOUDSTACK-9134: set device_id as the first device_id not in use instead of 
nic count

when we restart vpc tiers, the old nics will be removed, and create a new 
nic.
however, the device_id was set to the nic count, which may be already used.
this commit get the first device_id not in use as the device_id of new nic.

This issue also happen when we add multiple networks to a vm and remove 
them.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1210

[UI] bug fix: Delete added ACL lists is not available for Domain Admin and 
normal users

Only the owner or domain admin/admin can access the page (vpc->Network ACL 
Lists), they are also able to remove the network ACL lists, which is not 
allowed on UI.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack delete-acl-items

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1210


commit 709e0c555e5896f5f2abe16f9ba029010b4f42cc
Author: Wei Zhou 
Date:   2015-12-10T13:09:45Z

[UI] bug fix: Delete added ACL lists is not available for Domain Admin and 
normal users




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

[ustcweizhou]

Github user ustcweizhou closed the pull request at:

https://github.com/apache/cloudstack/pull/1210


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feedback of my Phd work in Cloudstack Project

[Igor Wiese]

Hi Vadim!

In fact, we are recomending files to change together without the
developers/newcomer need to know about the code (structural dependencies
for example), or need to make debugging to find with files could change
together in a task.

We found many situations that files are changed together but there aren't
any "natural" reason for that. For example, they aren't structural
connected or in the same package. In such cases, it is not trivial to
"find" this coupling. Thus we can recommend at least some files to be
inspected by developers while they are perfoming changes.

The main ideia is "avoid" the incomplete change that could causes a new bug
can appeared, or avoid waisting time to inspect files/debugging system to
find files to change in a issue.

What do you think?

All the best,
Igor Wiese

2015-12-10 10:55 GMT-02:00 Vadim Kimlaychuk :

> Do I understand correctly that purpose of this work is to find tightly
> coupled classes automatically in order to inverse dependency later on?
>
> Vadim.
>
>
> On 2015-12-10 01:31, Igor Wiese wrote:
>
> Hi, Cloudstack Community.
>>
>> My name is Igor Wiese, phd Student from Brazil. In my research, I am
>> investigating two important questions: What makes two files change
>> together? Can we predict when they are going to co-change again?
>>
>> I've tried to investigate this question on the Cloudstack project. I've
>> collected data from issue reports, discussions and commits and using some
>> machine learning techniques to build a prediction model.
>>
>> I collected a total of 141 commits in which a pair of files changed
>> together and could correctly predict 60% commits. These were the most
>> useful information for predicting co-changes of files:
>>
>> - sum of number of lines of code added, modified and removed,
>>
>> - number of words used to describe and discuss the issues,
>>
>> - number of comments in each issue,
>>
>> - median value of closeness, a social network measure obtained from issue
>> comments, and
>>
>> - median value of constraint, a social network measure obtained from issue
>> comments.
>>
>> To illustrate, consider the following example from our analysis. For
>> release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
>> "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits. In
>> another 2 commits, only the first file changed, but not the second.
>> Collecting contextual information for each commit made to first file in
>> the
>> previous release (4.3), we were able to predict all 3 commits in which
>> both
>> files changed together in release 4.4, and we only issued 0 false
>> positives. For this pair of files, the most important contextual
>> information was the number of lines of code added, removed and modified in
>> each commit,the number of comments in each issue, and social network
>> measures (closeness, density, constraint, hierarchy) obtained from issue
>> comments.
>>
>> - Do these results surprise you? Can you think in any explanation for the
>> results?
>>
>> - Do you think that our rate of prediction is good enough to be used for
>> building tool support for the software community?
>>
>> - Do you have any suggestion on what can be done to improve the change
>> recommendation?
>>
>> You can visit our webpage to inspect the results in details:
>> http://flosscoach.com/index.php/17-cochanges/67-cloudstack [1]
>>
>> All the best,
>> Igor Wiese
>> Phd Candidate
>>
>
>
>
> Links:
> --
> [1] http://flosscoach.com/index.php/17-cochanges/67-cloudstack
>



-- 
=
Igor Scaliante Wiese
PhD Candidate - Computer Science @ IME/USP
Faculty in Dept. of Computing at Universidade Tecnológica Federal do Paraná

[GitHub] cloudstack pull request: [UI] bug fix: Delete added ACL lists is n...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1211

[UI] bug fix: Delete added ACL lists is not available for Domain Admin and 
normal users

Only the owner or domain admin/admin can access the page (vpc->Network ACL 
Lists), they are also able to remove the network ACL lists, which is not 
allowed on UI.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack delete-acl-items

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1211


commit 709e0c555e5896f5f2abe16f9ba029010b4f42cc
Author: Wei Zhou 
Date:   2015-12-10T13:09:45Z

[UI] bug fix: Delete added ACL lists is not available for Domain Admin and 
normal users




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feedback of my Phd work in Cloudstack Project

[sebgoa]

On Dec 10, 2015, at 12:31 AM, Igor Wiese  wrote:

> Hi, Cloudstack Community.
> 
> My name is Igor Wiese, phd Student from Brazil. In my research, I am
> investigating two important questions: What makes two files change
> together? Can we predict when they are going to co-change again?
> 
> I've tried to investigate this question on the Cloudstack project. I've
> collected data from issue reports, discussions and commits and using some
> machine learning techniques to build a prediction model.
> 
> I collected a total of 141 commits in which a pair of files changed
> together and could correctly predict 60% commits.


Hi Igor, why 141 commits ? Is that the only commits you found with only a pair 
for changes ?

My gut feeling is that you could check the entire history of the CloudStack 
repo (~5 years worth of data) and work on different type of tuples.

141 commits seems like a really small dataset.

-Sebastien

> These were the most
> useful information for predicting co-changes of files:
> 
> - sum of number of lines of code added, modified and removed,
> 
> - number of words used to describe and discuss the issues,
> 
> - number of comments in each issue,
> 
> - median value of closeness, a social network measure obtained from issue
> comments, and
> 
> - median value of constraint, a social network measure obtained from issue
> comments.
> 
> To illustrate, consider the following example from our analysis. For
> release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits. In
> another 2 commits, only the first file changed, but not the second.
> Collecting contextual information for each commit made to first file in the
> previous release (4.3), we were able to predict all 3 commits in which both
> files changed together in release 4.4, and we only issued 0 false
> positives. For this pair of files, the most important contextual
> information was the number of lines of code added, removed and modified in
> each commit,the number of comments in each issue, and social network
> measures (closeness, density, constraint, hierarchy) obtained from issue
> comments.
> 
> - Do these results surprise you? Can you think in any explanation for the
> results?
> 
> - Do you think that our rate of prediction is good enough to be used for
> building tool support for the software community?
> 
> - Do you have any suggestion on what can be done to improve the change
> recommendation?
> 
> You can visit our webpage to inspect the results in details:
> http://flosscoach.com/index.php/17-cochanges/67-cloudstack
> 
> All the best,
> Igor Wiese
> Phd Candidate

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

[ustcweizhou]

GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1212

CLOUDSTACK-9136: remove ssh keypairs along with removing account

We also allow ROOT Admin to remove remained ssh keypairs of removed account

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack remove-ssh-keypairs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1212


commit 67e5e4719f7840753db6764f7e2205cbcdc8b7c2
Author: Wei Zhou 
Date:   2015-12-10T13:25:22Z

CLOUDSTACK-9136: remove ssh keypairs along with removing account

We also allow ROOT Admin to remove remained ssh keypairs of removed account




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1208#issuecomment-163624151
  
LGTM
![screen shot 2015-12-10 at 14 50 
08](https://cloud.githubusercontent.com/assets/1630096/11716922/61d60aa8-9f4d-11e5-9ac0-d442a74cd55c.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1208


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Feedback of my Phd work in Cloudstack Project

[Igor Wiese]

Hi Sebastien.

We used only 141 commits because we needed data from the issues. As my
assumption is related to the contextual information from Issues and Social
aspects, we need to aggregate commits and Issues.

First, I collected the issues from JIRA and then i tryed to aggregate the
commits that explicit made mentions to an issue collected. I only also used
closed issues to obtain the confidence that the code used to build my
models have been merged and checked by the community.

That is the weak point of my approach. I need the past data from the
issues. Sometimes it is not available for past time.
It is in my plan to use also data from github to make the dataset more
complete.

All the best,

2015-12-10 11:22 GMT-02:00 sebgoa :

>
> On Dec 10, 2015, at 12:31 AM, Igor Wiese  wrote:
>
> > Hi, Cloudstack Community.
> >
> > My name is Igor Wiese, phd Student from Brazil. In my research, I am
> > investigating two important questions: What makes two files change
> > together? Can we predict when they are going to co-change again?
> >
> > I've tried to investigate this question on the Cloudstack project. I've
> > collected data from issue reports, discussions and commits and using some
> > machine learning techniques to build a prediction model.
> >
> > I collected a total of 141 commits in which a pair of files changed
> > together and could correctly predict 60% commits.
>
>
> Hi Igor, why 141 commits ? Is that the only commits you found with only a
> pair for changes ?
>
> My gut feeling is that you could check the entire history of the
> CloudStack repo (~5 years worth of data) and work on different type of
> tuples.
>
> 141 commits seems like a really small dataset.
>
> -Sebastien
>
> > These were the most
> > useful information for predicting co-changes of files:
> >
> > - sum of number of lines of code added, modified and removed,
> >
> > - number of words used to describe and discuss the issues,
> >
> > - number of comments in each issue,
> >
> > - median value of closeness, a social network measure obtained from issue
> > comments, and
> >
> > - median value of constraint, a social network measure obtained from
> issue
> > comments.
> >
> > To illustrate, consider the following example from our analysis. For
> > release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> > "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits.
> In
> > another 2 commits, only the first file changed, but not the second.
> > Collecting contextual information for each commit made to first file in
> the
> > previous release (4.3), we were able to predict all 3 commits in which
> both
> > files changed together in release 4.4, and we only issued 0 false
> > positives. For this pair of files, the most important contextual
> > information was the number of lines of code added, removed and modified
> in
> > each commit,the number of comments in each issue, and social network
> > measures (closeness, density, constraint, hierarchy) obtained from issue
> > comments.
> >
> > - Do these results surprise you? Can you think in any explanation for the
> > results?
> >
> > - Do you think that our rate of prediction is good enough to be used for
> > building tool support for the software community?
> >
> > - Do you have any suggestion on what can be done to improve the change
> > recommendation?
> >
> > You can visit our webpage to inspect the results in details:
> > http://flosscoach.com/index.php/17-cochanges/67-cloudstack
> >
> > All the best,
> > Igor Wiese
> > Phd Candidate
>
>


-- 
=
Igor Scaliante Wiese
PhD Candidate - Computer Science @ IME/USP
Faculty in Dept. of Computing at Universidade Tecnológica Federal do Paraná

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1213

CLOUDSTACK-9137 Allow domain admin to manage private gw

To create a private gateway you need a root admin account. This does not 
make sense, as you can do a lot more with such a powerful account. Other 
network related API calls can be made by a domain admin.

This PR allows domain admins to create their own private gateways.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack private_gw_domain_admin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1213


commit e9b5b8f55d100f67146bd03b6b7577bd0660d155
Author: Remi Bergsma 
Date:   2015-12-10T15:09:26Z

CLOUDSTACK-9137 Allow domain admin to manage priv gw




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9123 - As a Developer I want t...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1204#issuecomment-163660061
  
FYI: my tests also succeeded.

```
[root@cs1 integration]# cat  
/tmp//MarvinLogs/test_internal_lb_88R1S8/results.txt 
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok

--
Ran 2 tests in 1733.573s

OK
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1185


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1213#issuecomment-163674707
  
@remibergsma Can domain admin1 delete gateway created by domain admin2? If 
the existing code is properly handling these scenarios then fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1213#issuecomment-163683468
  
It seems this is more complex than it seemed. Since we've to put in a 
'physical network id' (which is obviously owned by ROOT domain, this does not 
work yet.

Creating fails:
```
(admin) 🐵 > create privategateway gateway=1.2.3.4 ipaddress=4.3.2.1 
netmask=255.255.255.0 vpcid=cc80ae2c-c3ad-4ea3-96f4-dc40970c81e4 
vlan="lswitch://uuid"
Error 531: Acct[74caa349-7f41-4e1a-b4b1-d386c0c2a1a2-rbergsma] does not 
have permission to operate within domain id=9c2baf29-9846-11e5-9afa-525400b8977a
cserrorcode = 4365
errorcode = 531
errortext = Acct[74caa349-7f41-4e1a-b4b1-d386c0c2a1a2-rbergsma] does not 
have permission to operate within domain id=9c2baf29-9846-11e5-9afa-525400b8977a
uuidList:
```

This is the mentioned domain id:

```
(admin) 🐵 > set profile root
(root) 🐵 > list domains id=9c2baf29-9846-11e5-9afa-525400b8977a 
filter=name
count = 1
domain:
name = ROOT
```

Most likely due to the physical network id. Hmm..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[serg38]

Github user serg38 commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-163684761
  
Assuming everything else is ready e.g. service controllers, transport zone, 
management server, STT tunnels in-between then to create L2 gateway (page 89 of 
the User guide):
1. Create new gateway transport node
1.1. Download and install either OVA or ISO for your hypervisor (available 
on Vmware site). You need at least 2 separate vSwitches. If tunneling traffic 
follows a different path, then 3 interface might be needed for the appliance
1.2 Login with admin/admin
1.3 Configure
set hostname 
add network dns-server 
add network ntp-server 0.pool.ntp.org
set network interface breth1 ip config static  
   .it could be breth0 in some cases and in some cases more than one 
bridge
add switch manager 
1.4. Obtain gateway certificate
show switch certificate 
1.5 Add gateway node to NSX
  Transport Node->Add->Gateway->Display Name->Admin Status 
Enabled->Security Credentials - Certificate. Paste from section 
1.4->Connection->Add->STT->IP of the bridge used for tunneling traffic
1.6. Create L2 Gateway Service and publish it on created Gateway transport 
node




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1214

Setup routes for RFC 1918 ip space

Setup general route for RFC 1918 space, as otherwise it will be sent to the 
public gateway and likely to be dropped (internet providers do not route ip 
space that is meant for internal use). More specific routes that may be set 
have preference over this generic routes so this works even with private ranges 
used for public ip space (as shown below).

When using an internal DNS server some hosts may resolve to an RFC 1918 ip 
address. The SSVM has a default gw to public so if it has no route for this ip 
address space, it will not work. This PR makes generic RFC 1918 (so all 
internal ip adresses like 10.0.0.10 etc) to the local management gateway. This 
makes them reachable. Without this fix, it is sent upstream and it is dropped 
there.

Should there be a more generic route (smaller prefix), this has preference 
over the generic routes.

Example in my dev environment:

```
root@v-1-VM:~# route -n
Kernel IP routing table
Destination Gateway Genmask Flags Metric RefUse 
Iface
0.0.0.0 192.168.23.10.0.0.0 UG0  00 eth2
10.0.0.0192.168.22.1255.0.0.0   UG0  00 eth1
169.254.0.0 0.0.0.0 255.255.0.0 U 0  00 eth0
172.16.0.0  192.168.22.1255.240.0.0 UG0  00 eth1
192.168.0.0 192.168.22.1255.255.0.0 UG0  00 eth1
192.168.22.00.0.0.0 255.255.255.0   U 0  00 eth1
192.168.23.00.0.0.0 255.255.255.0   U 0  00 eth2
```

Route `192.168.0.0/16` goes via `eth1` but `192.168.23.0/24` is more 
specific and has preference and goes via `eth2`. It works:

```
root@v-1-VM:~# ping 8.8.8.8
PING 8.8.8.8 (8.8.8.8): 48 data bytes
56 bytes from 8.8.8.8: icmp_seq=0 ttl=49 time=7.179 ms
^C--- 8.8.8.8 ping statistics ---
1 packets transmitted, 1 packets received, 0% packet loss
round-trip min/avg/max/stddev = 7.179/7.179/7.179/0.000 ms
```

This solves a lot of the 'internal resolving' issues we face.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack rfc1918_route

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1214.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1214


commit 155c16b67624d3a7babe796c0e7152771028d978
Author: Remi Bergsma 
Date:   2015-12-10T16:50:45Z

Setup routes for RFC 1918 ip space

Setup general route for RFC 1918 space, as otherwise it will be sent to
the public gateway and not work. More specific routes that may be set
have preference over this generic routes.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9137 Allow domain admin to man...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...

[wilderrodrigues]

GitHub user wilderrodrigues opened a pull request:

https://github.com/apache/cloudstack/pull/1215

CLOUDSTACK-9138 - Adds multiple providers back to VPC implementation

   - It is need and already allowed/used in the current implementation. For 
example, the Default [redundant] VPC offerings use two LB providers. If we 
cannot create offerings with 2 LB providers, the whole internal loadbalancer 
implementation won't work.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ekholabs/cloudstack 
improve/mult-providers-CLOUDSTACK-9138

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1215


commit 51c9f0e3b524f978eadb6a6ba630c3f7281b1a11
Author: Wilder Rodrigues 
Date:   2015-12-10T18:51:28Z

CLOUDSTACK-9138 - Adds multiple providers back to VPC implementation

   - It is need and already allowed/used in the current implementation. For 
example, the Default [redundant] VPC offerings use
 two LB providers. If we cannot create offerings with 2 LB providers, 
the whole internal loadbalancer implementation won't work




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9138 - Adds multiple providers...

[wilderrodrigues]

Github user wilderrodrigues commented on the pull request:

https://github.com/apache/cloudstack/pull/1215#issuecomment-163723768
  
Ping @remibergsma @DaanHoogland @miguelaferreira @michaelandersen @bhaisaab 

* Environment
  - 1 KVM host on CentOS 7.1
  - Management Server on CentOS 7.1
  - Cloudmonkey

* Tests
  - Executed cloudmonkey in order to create the offerings

* With only 1 provider

```
create vpcoffering name=test2 displaytext=testtest2 
supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb
 serviceproviderlist[0].service=PortForwarding 
serviceproviderlist[0].provider=VpcVirtualRouter  
serviceproviderlist[1].service=StaticNat 
serviceproviderlist[1].provider=VpcVirtualRouter  
serviceproviderlist[2].service=SourceNat 
serviceproviderlist[2].provider=VpcVirtualRouter  
serviceproviderlist[3].service=Vpn 
serviceproviderlist[3].provider=VpcVirtualRouter  
serviceproviderlist[4].service=Dhcp 
serviceproviderlist[4].provider=VpcVirtualRouter 
serviceproviderlist[5].service=Connectivity 
serviceproviderlist[5].provider=NiciraNvp  serviceproviderlist[6].service=Dns 
serviceproviderlist[6].provider=VpcVirtualRouter  
serviceproviderlist[7].service=UserData 
serviceproviderlist[7].provider=VpcVirtualRouter 
serviceproviderlist[8].service=NetworkACL 
serviceproviderlist[8].provider=VpcVirtualRouter 
serviceproviderlist[9].service=Lb servic
 eproviderlist[9].provider=VpcVirtualRouter 
servicecapabilitylist[0].capabilitytype=RedundantRouter 
servicecapabilitylist[0].service=SourceNat 
servicecapabilitylist[0].capabilityvalue=true
```

*  With 2 providers

```
create vpcoffering name=test displaytext=testtest 
supportedservices=PortForwarding,StaticNat,SourceNat,Vpn,Dhcp,Connectivity,Dns,UserData,NetworkACL,Lb
 serviceproviderlist[0].service=PortForwarding 
serviceproviderlist[0].provider=VpcVirtualRouter  
serviceproviderlist[1].service=StaticNat 
serviceproviderlist[1].provider=VpcVirtualRouter  
serviceproviderlist[2].service=SourceNat 
serviceproviderlist[2].provider=VpcVirtualRouter  
serviceproviderlist[3].service=Vpn 
serviceproviderlist[3].provider=VpcVirtualRouter  
serviceproviderlist[4].service=Dhcp 
serviceproviderlist[4].provider=VpcVirtualRouter 
serviceproviderlist[5].service=Connectivity 
serviceproviderlist[5].provider=NiciraNvp  serviceproviderlist[6].service=Dns 
serviceproviderlist[6].provider=VpcVirtualRouter  
serviceproviderlist[7].service=UserData 
serviceproviderlist[7].provider=VpcVirtualRouter 
serviceproviderlist[8].service=NetworkACL 
serviceproviderlist[8].provider=VpcVirtualRouter 
serviceproviderlist[9].service=Lb servicep
 roviderlist[9].provider=VpcVirtualRouter serviceproviderlist[10].service=Lb 
serviceproviderlist[10].provider=InternalLbVm 
servicecapabilitylist[0].capabilitytype=RedundantRouter 
servicecapabilitylist[0].service=SourceNat 
servicecapabilitylist[0].capabilityvalue=true
```

If that's hard to see, in the second test I added the following:

```
serviceproviderlist[10].service=Lb 
serviceproviderlist[10].provider=InternalLbVm
```

* Screenshots
  - Offerings

![image](https://cloud.githubusercontent.com/assets/5129209/11725664/180234d2-9f7b-11e5-91a6-6bf42579aad8.png)

  - 2 Providers

![image](https://cloud.githubusercontent.com/assets/5129209/11725675/265541be-9f7b-11e5-8c00-124e5a9df1ac.png)

  - 1 Provider

![image](https://cloud.githubusercontent.com/assets/5129209/11725695/40d67800-9f7b-11e5-8add-15ad38bb26ce.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Jenkins build is still unstable: build-systemvm64-master #691

[jenkins]

See 

Re: Feedback of my Phd work in Cloudstack Project

[Patrick Dube]

Are you handling new files as well, or the links between sets of files (or
packages)? As an example, if a user creates a new API cmd, then he will
update the "commands.properties" file. Another example, if a VO file is
updated, then there will be a db migration file added as well.
Cool work,

On Thu, Dec 10, 2015 at 9:21 AM, Igor Wiese  wrote:

> Hi Sebastien.
>
> We used only 141 commits because we needed data from the issues. As my
> assumption is related to the contextual information from Issues and Social
> aspects, we need to aggregate commits and Issues.
>
> First, I collected the issues from JIRA and then i tryed to aggregate the
> commits that explicit made mentions to an issue collected. I only also used
> closed issues to obtain the confidence that the code used to build my
> models have been merged and checked by the community.
>
> That is the weak point of my approach. I need the past data from the
> issues. Sometimes it is not available for past time.
> It is in my plan to use also data from github to make the dataset more
> complete.
>
> All the best,
>
> 2015-12-10 11:22 GMT-02:00 sebgoa :
>
> >
> > On Dec 10, 2015, at 12:31 AM, Igor Wiese  wrote:
> >
> > > Hi, Cloudstack Community.
> > >
> > > My name is Igor Wiese, phd Student from Brazil. In my research, I am
> > > investigating two important questions: What makes two files change
> > > together? Can we predict when they are going to co-change again?
> > >
> > > I've tried to investigate this question on the Cloudstack project. I've
> > > collected data from issue reports, discussions and commits and using
> some
> > > machine learning techniques to build a prediction model.
> > >
> > > I collected a total of 141 commits in which a pair of files changed
> > > together and could correctly predict 60% commits.
> >
> >
> > Hi Igor, why 141 commits ? Is that the only commits you found with only a
> > pair for changes ?
> >
> > My gut feeling is that you could check the entire history of the
> > CloudStack repo (~5 years worth of data) and work on different type of
> > tuples.
> >
> > 141 commits seems like a really small dataset.
> >
> > -Sebastien
> >
> > > These were the most
> > > useful information for predicting co-changes of files:
> > >
> > > - sum of number of lines of code added, modified and removed,
> > >
> > > - number of words used to describe and discuss the issues,
> > >
> > > - number of comments in each issue,
> > >
> > > - median value of closeness, a social network measure obtained from
> issue
> > > comments, and
> > >
> > > - median value of constraint, a social network measure obtained from
> > issue
> > > comments.
> > >
> > > To illustrate, consider the following example from our analysis. For
> > > release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> > > "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3 commits.
> > In
> > > another 2 commits, only the first file changed, but not the second.
> > > Collecting contextual information for each commit made to first file in
> > the
> > > previous release (4.3), we were able to predict all 3 commits in which
> > both
> > > files changed together in release 4.4, and we only issued 0 false
> > > positives. For this pair of files, the most important contextual
> > > information was the number of lines of code added, removed and modified
> > in
> > > each commit,the number of comments in each issue, and social network
> > > measures (closeness, density, constraint, hierarchy) obtained from
> issue
> > > comments.
> > >
> > > - Do these results surprise you? Can you think in any explanation for
> the
> > > results?
> > >
> > > - Do you think that our rate of prediction is good enough to be used
> for
> > > building tool support for the software community?
> > >
> > > - Do you have any suggestion on what can be done to improve the change
> > > recommendation?
> > >
> > > You can visit our webpage to inspect the results in details:
> > > http://flosscoach.com/index.php/17-cochanges/67-cloudstack
> > >
> > > All the best,
> > > Igor Wiese
> > > Phd Candidate
> >
> >
>
>
> --
> =
> Igor Scaliante Wiese
> PhD Candidate - Computer Science @ IME/USP
> Faculty in Dept. of Computing at Universidade Tecnológica Federal do Paraná
>

Re: Feedback of my Phd work in Cloudstack Project

[Igor Wiese]

Hi Patrick

The problem with new files is the absence of history to build the
prediction models. I need at least some commits (10 commits for example).
Yes, the link between files is what we are predicting. We can predict
changes involving commands.properties, XML files in general, .txt files, or
any source code extension :-)

Thanks for the feedback.


2015-12-10 17:40 GMT-02:00 Patrick Dube :

> Are you handling new files as well, or the links between sets of files (or
> packages)? As an example, if a user creates a new API cmd, then he will
> update the "commands.properties" file. Another example, if a VO file is
> updated, then there will be a db migration file added as well.
> Cool work,
>
> On Thu, Dec 10, 2015 at 9:21 AM, Igor Wiese  wrote:
>
> > Hi Sebastien.
> >
> > We used only 141 commits because we needed data from the issues. As my
> > assumption is related to the contextual information from Issues and
> Social
> > aspects, we need to aggregate commits and Issues.
> >
> > First, I collected the issues from JIRA and then i tryed to aggregate the
> > commits that explicit made mentions to an issue collected. I only also
> used
> > closed issues to obtain the confidence that the code used to build my
> > models have been merged and checked by the community.
> >
> > That is the weak point of my approach. I need the past data from the
> > issues. Sometimes it is not available for past time.
> > It is in my plan to use also data from github to make the dataset more
> > complete.
> >
> > All the best,
> >
> > 2015-12-10 11:22 GMT-02:00 sebgoa :
> >
> > >
> > > On Dec 10, 2015, at 12:31 AM, Igor Wiese  wrote:
> > >
> > > > Hi, Cloudstack Community.
> > > >
> > > > My name is Igor Wiese, phd Student from Brazil. In my research, I am
> > > > investigating two important questions: What makes two files change
> > > > together? Can we predict when they are going to co-change again?
> > > >
> > > > I've tried to investigate this question on the Cloudstack project.
> I've
> > > > collected data from issue reports, discussions and commits and using
> > some
> > > > machine learning techniques to build a prediction model.
> > > >
> > > > I collected a total of 141 commits in which a pair of files changed
> > > > together and could correctly predict 60% commits.
> > >
> > >
> > > Hi Igor, why 141 commits ? Is that the only commits you found with
> only a
> > > pair for changes ?
> > >
> > > My gut feeling is that you could check the entire history of the
> > > CloudStack repo (~5 years worth of data) and work on different type of
> > > tuples.
> > >
> > > 141 commits seems like a really small dataset.
> > >
> > > -Sebastien
> > >
> > > > These were the most
> > > > useful information for predicting co-changes of files:
> > > >
> > > > - sum of number of lines of code added, modified and removed,
> > > >
> > > > - number of words used to describe and discuss the issues,
> > > >
> > > > - number of comments in each issue,
> > > >
> > > > - median value of closeness, a social network measure obtained from
> > issue
> > > > comments, and
> > > >
> > > > - median value of constraint, a social network measure obtained from
> > > issue
> > > > comments.
> > > >
> > > > To illustrate, consider the following example from our analysis. For
> > > > release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> > > > "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3
> commits.
> > > In
> > > > another 2 commits, only the first file changed, but not the second.
> > > > Collecting contextual information for each commit made to first file
> in
> > > the
> > > > previous release (4.3), we were able to predict all 3 commits in
> which
> > > both
> > > > files changed together in release 4.4, and we only issued 0 false
> > > > positives. For this pair of files, the most important contextual
> > > > information was the number of lines of code added, removed and
> modified
> > > in
> > > > each commit,the number of comments in each issue, and social network
> > > > measures (closeness, density, constraint, hierarchy) obtained from
> > issue
> > > > comments.
> > > >
> > > > - Do these results surprise you? Can you think in any explanation for
> > the
> > > > results?
> > > >
> > > > - Do you think that our rate of prediction is good enough to be used
> > for
> > > > building tool support for the software community?
> > > >
> > > > - Do you have any suggestion on what can be done to improve the
> change
> > > > recommendation?
> > > >
> > > > You can visit our webpage to inspect the results in details:
> > > > http://flosscoach.com/index.php/17-cochanges/67-cloudstack
> > > >
> > > > All the best,
> > > > Igor Wiese
> > > > Phd Candidate
> > >
> > >
> >
> >
> > --
> > =
> > Igor Scaliante Wiese
> > PhD Candidate - Computer Science @ IME/USP
> > Faculty in Dept. of Computing at Universidade Tecnológica Federal do
> Paraná
> >
>



-- 
=
Igor Scaliante W

Re: Feedback of my Phd work in Cloudstack Project

[Patrick Dube]

The history around the new file isn't the file itself, but in which
directory/package it would be in.

Cheers,

On Thu, Dec 10, 2015 at 3:01 PM, Igor Wiese  wrote:

> Hi Patrick
>
> The problem with new files is the absence of history to build the
> prediction models. I need at least some commits (10 commits for example).
> Yes, the link between files is what we are predicting. We can predict
> changes involving commands.properties, XML files in general, .txt files, or
> any source code extension :-)
>
> Thanks for the feedback.
>
>
> 2015-12-10 17:40 GMT-02:00 Patrick Dube :
>
> > Are you handling new files as well, or the links between sets of files
> (or
> > packages)? As an example, if a user creates a new API cmd, then he will
> > update the "commands.properties" file. Another example, if a VO file is
> > updated, then there will be a db migration file added as well.
> > Cool work,
> >
> > On Thu, Dec 10, 2015 at 9:21 AM, Igor Wiese 
> wrote:
> >
> > > Hi Sebastien.
> > >
> > > We used only 141 commits because we needed data from the issues. As my
> > > assumption is related to the contextual information from Issues and
> > Social
> > > aspects, we need to aggregate commits and Issues.
> > >
> > > First, I collected the issues from JIRA and then i tryed to aggregate
> the
> > > commits that explicit made mentions to an issue collected. I only also
> > used
> > > closed issues to obtain the confidence that the code used to build my
> > > models have been merged and checked by the community.
> > >
> > > That is the weak point of my approach. I need the past data from the
> > > issues. Sometimes it is not available for past time.
> > > It is in my plan to use also data from github to make the dataset more
> > > complete.
> > >
> > > All the best,
> > >
> > > 2015-12-10 11:22 GMT-02:00 sebgoa :
> > >
> > > >
> > > > On Dec 10, 2015, at 12:31 AM, Igor Wiese 
> wrote:
> > > >
> > > > > Hi, Cloudstack Community.
> > > > >
> > > > > My name is Igor Wiese, phd Student from Brazil. In my research, I
> am
> > > > > investigating two important questions: What makes two files change
> > > > > together? Can we predict when they are going to co-change again?
> > > > >
> > > > > I've tried to investigate this question on the Cloudstack project.
> > I've
> > > > > collected data from issue reports, discussions and commits and
> using
> > > some
> > > > > machine learning techniques to build a prediction model.
> > > > >
> > > > > I collected a total of 141 commits in which a pair of files changed
> > > > > together and could correctly predict 60% commits.
> > > >
> > > >
> > > > Hi Igor, why 141 commits ? Is that the only commits you found with
> > only a
> > > > pair for changes ?
> > > >
> > > > My gut feeling is that you could check the entire history of the
> > > > CloudStack repo (~5 years worth of data) and work on different type
> of
> > > > tuples.
> > > >
> > > > 141 commits seems like a really small dataset.
> > > >
> > > > -Sebastien
> > > >
> > > > > These were the most
> > > > > useful information for predicting co-changes of files:
> > > > >
> > > > > - sum of number of lines of code added, modified and removed,
> > > > >
> > > > > - number of words used to describe and discuss the issues,
> > > > >
> > > > > - number of comments in each issue,
> > > > >
> > > > > - median value of closeness, a social network measure obtained from
> > > issue
> > > > > comments, and
> > > > >
> > > > > - median value of constraint, a social network measure obtained
> from
> > > > issue
> > > > > comments.
> > > > >
> > > > > To illustrate, consider the following example from our analysis.
> For
> > > > > release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> > > > > "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3
> > commits.
> > > > In
> > > > > another 2 commits, only the first file changed, but not the second.
> > > > > Collecting contextual information for each commit made to first
> file
> > in
> > > > the
> > > > > previous release (4.3), we were able to predict all 3 commits in
> > which
> > > > both
> > > > > files changed together in release 4.4, and we only issued 0 false
> > > > > positives. For this pair of files, the most important contextual
> > > > > information was the number of lines of code added, removed and
> > modified
> > > > in
> > > > > each commit,the number of comments in each issue, and social
> network
> > > > > measures (closeness, density, constraint, hierarchy) obtained from
> > > issue
> > > > > comments.
> > > > >
> > > > > - Do these results surprise you? Can you think in any explanation
> for
> > > the
> > > > > results?
> > > > >
> > > > > - Do you think that our rate of prediction is good enough to be
> used
> > > for
> > > > > building tool support for the software community?
> > > > >
> > > > > - Do you have any suggestion on what can be done to improve the
> > change
> > > > > recommendation?
> > > > >
> > > > > You can visit our webpage to inspect the re

Re: Feedback of my Phd work in Cloudstack Project

[igor.wiese]

Really nice ideia. I got your point. I will test.
Thanks for the suggestion:)
Sent from Samsung tablet

 Mensagem original 
De : Patrick Dube  
Data: 10/12/2015  18:26  (GMT-03:00) 
Para: dev@cloudstack.apache.org 
Assunto: Re: Feedback of my Phd work in Cloudstack Project 

The history around the new file isn't the file itself, but in which
directory/package it would be in.

Cheers,

On Thu, Dec 10, 2015 at 3:01 PM, Igor Wiese  wrote:

> Hi Patrick
>
> The problem with new files is the absence of history to build the
> prediction models. I need at least some commits (10 commits for example).
> Yes, the link between files is what we are predicting. We can predict
> changes involving commands.properties, XML files in general, .txt files, or
> any source code extension :-)
>
> Thanks for the feedback.
>
>
> 2015-12-10 17:40 GMT-02:00 Patrick Dube :
>
> > Are you handling new files as well, or the links between sets of files
> (or
> > packages)? As an example, if a user creates a new API cmd, then he will
> > update the "commands.properties" file. Another example, if a VO file is
> > updated, then there will be a db migration file added as well.
> > Cool work,
> >
> > On Thu, Dec 10, 2015 at 9:21 AM, Igor Wiese 
> wrote:
> >
> > > Hi Sebastien.
> > >
> > > We used only 141 commits because we needed data from the issues. As my
> > > assumption is related to the contextual information from Issues and
> > Social
> > > aspects, we need to aggregate commits and Issues.
> > >
> > > First, I collected the issues from JIRA and then i tryed to aggregate
> the
> > > commits that explicit made mentions to an issue collected. I only also
> > used
> > > closed issues to obtain the confidence that the code used to build my
> > > models have been merged and checked by the community.
> > >
> > > That is the weak point of my approach. I need the past data from the
> > > issues. Sometimes it is not available for past time.
> > > It is in my plan to use also data from github to make the dataset more
> > > complete.
> > >
> > > All the best,
> > >
> > > 2015-12-10 11:22 GMT-02:00 sebgoa :
> > >
> > > >
> > > > On Dec 10, 2015, at 12:31 AM, Igor Wiese 
> wrote:
> > > >
> > > > > Hi, Cloudstack Community.
> > > > >
> > > > > My name is Igor Wiese, phd Student from Brazil. In my research, I
> am
> > > > > investigating two important questions: What makes two files change
> > > > > together? Can we predict when they are going to co-change again?
> > > > >
> > > > > I've tried to investigate this question on the Cloudstack project.
> > I've
> > > > > collected data from issue reports, discussions and commits and
> using
> > > some
> > > > > machine learning techniques to build a prediction model.
> > > > >
> > > > > I collected a total of 141 commits in which a pair of files changed
> > > > > together and could correctly predict 60% commits.
> > > >
> > > >
> > > > Hi Igor, why 141 commits ? Is that the only commits you found with
> > only a
> > > > pair for changes ?
> > > >
> > > > My gut feeling is that you could check the entire history of the
> > > > CloudStack repo (~5 years worth of data) and work on different type
> of
> > > > tuples.
> > > >
> > > > 141 commits seems like a really small dataset.
> > > >
> > > > -Sebastien
> > > >
> > > > > These were the most
> > > > > useful information for predicting co-changes of files:
> > > > >
> > > > > - sum of number of lines of code added, modified and removed,
> > > > >
> > > > > - number of words used to describe and discuss the issues,
> > > > >
> > > > > - number of comments in each issue,
> > > > >
> > > > > - median value of closeness, a social network measure obtained from
> > > issue
> > > > > comments, and
> > > > >
> > > > > - median value of constraint, a social network measure obtained
> from
> > > > issue
> > > > > comments.
> > > > >
> > > > > To illustrate, consider the following example from our analysis.
> For
> > > > > release 4.4, the files "cloud/hypervisor/XenServerGuru.java" and
> > > > > "cloud/hypervisor/guru/VMwareGuru.java " changed together in 3
> > commits.
> > > > In
> > > > > another 2 commits, only the first file changed, but not the second.
> > > > > Collecting contextual information for each commit made to first
> file
> > in
> > > > the
> > > > > previous release (4.3), we were able to predict all 3 commits in
> > which
> > > > both
> > > > > files changed together in release 4.4, and we only issued 0 false
> > > > > positives. For this pair of files, the most important contextual
> > > > > information was the number of lines of code added, removed and
> > modified
> > > > in
> > > > > each commit,the number of comments in each issue, and social
> network
> > > > > measures (closeness, density, constraint, hierarchy) obtained from
> > > issue
> > > > > comments.
> > > > >
> > > > > - Do these results surprise you? Can you think in any explanation
> for
> > > the
> > > > > results?
> > > > >
> > > > > - Do you think that our rat

Build failed in Jenkins: build-master-slowbuild #2775

[jenkins]

See 

Changes:

[atrbgithub] Sorting of security groups

[bharat.kumar] CLOUDSTACK-8852 Database shows that management server is UP when 
it is

[Daan Hoogland] CLOUDSTACK-9047 use 'State's only with context   there are more 
types

[Daan Hoogland] CLOUDSTACK-9046 renamed enums in kvm plugin

[Daan Hoogland] CLOUDSTACK-9046 rename enums to adhere to naming conventions

[Daan Hoogland] CID-1175714 casts before bit shift

[Daan Hoogland] CID-1116485: cast cidr during bit shifting  and simple test 
included

[Daan Hoogland] CID-1116484 cast to long and use long as cidrsize type  and 
simpel test

[Daan Hoogland] CID-1116483 cidr to netmask bitshifts guarded with casts

[Daan Hoogland] CID-1116482 cidrToLong cleanup of bitshift problem

[Daan Hoogland] CWE-190 netmask as long form cidr-size as method

[Daan Hoogland] CLOUDSTACK-8656: tests ignoring exceptions

[Rajani Karuturi] removed commented code

[Rajani Karuturi] CLOUDSTACK-8868: use same method to generate passwords for 
system/guest

[Rajani Karuturi] CLOUDSTACK-8868: change the default vm.password.length to 10

[Daan Hoogland] CWE-190 unit test for extremes of long netMaskFromCidr(long)

[rafaelweingartner] Changed the behavior of methods that use 
NetUtils.cidrToLong(String)

[Daan Hoogland] move back to original contract of isNetworksOverlap()

[Rajani Karuturi] CLOUDSTACK-9080: Resource limits for Primary arent respected 
during

[lucascristofolini] Removed unused code from the EngineHostDao Implementation.

[pdube] CLOUDSTACK-6276 Fixing affinity groups for projects

[rafaelweingartner] fixed references in async-job-component.xml for storage 
allocators

[rafaelweingartner] created tests cases for method 
"citrixResourceBase.getPatchFiles"

[pdube] CLOUDSTACK-6276 Removing unused parameter in integration test

[pdube] CLOUDSTACK-6276 Removing unused parameter in integration test for

[Harikrishna Patnala] CLOUDSTACK-9094: Multiple threads are being used to 
collect the stats

[w.zhou] CLOUDSTACK-9051: update nic IP address of stopped vm

[w.zhou] CLOUDSTACK-9051: add unit tests for UpdateVmNicIp

[w.zhou] CLOUDSTACK-9051: reprogram network as a part of vm nic ip update

[w.zhou] CLOUDSTACK-9022: keep Destroyed volumes for sometime

[w.zhou] CLOUDSTACK-9022: move storage.cleanup related global configurations to

[rafaelweingartner] Removed PlannerBase empty class

[Rohit Yadav] debian: allow rules to pick ACS_BUILD_OPTS from env

[wrodrigues] CLOUDSTACK-9075 - Add method to get list of Physical Networks per 
zone

[wrodrigues] CLOUDSTACK-9075 - Covers Private GW ACL with Redundant VPCs

[wrodrigues] CLOUDSTACK-9075 - Adds VPC static routes test

[wrodrigues] CLOUDSTACK-9075 - Uses the same vlan since it should have been 
already

[w.zhou] [UI] fix bug: Cannot delete SSH keypairs in projects

[w.zhou] CLOUDSTACK-9101: update volume size after resizevolume

[w.zhou] CLOUDSTACK-9101: add UI support for root volume resize

[w.zhou] CLOUDSTACK-9101: resize root volume of stopped vm on KVM

[Remi Bergsma] CLOUDSTACK-9097 Make public ip work immediately

[josh.harshman] CLOUDSTACK-9004: Add features to HyperVEnlightenmentFeatureDef

[koushik] CLOUDSTACK-9105: Logging enhancement: Handle/reference to track API

[w.zhou] CLOUDSTACK-8845: set isRevertable of snapshot to false if the volume is

[Rohit Yadav] rate-limit: increase JVM memory and enable fork mode for unit 
tests

[koushik] CLOUDSTACK-9107: Description of global config agent.load.threshold and

[Daan Hoogland] 4.6.0 upgrade path is to pass 4.6.1 to create the extra view in 
there

[anshul.gangwar] CLOUDSTACK-9025: Fixed can't create usable template from 
snapshot in

[jeff] Add support for not (re)starting server after cloud-setup-management.

[w.zhou] Revert "CLOUDSTACK-8964 side effect isolation"

[w.zhou] Revert "simple change to prevent failure and keep OVM3 snapshots

[w.zhou] CLOUDSTACK-8964: Ovm3HypervisorGuru handle only srcData with

[miguelferreira] Add test for NSX plugin that simulates a live lock

[miguelferreira] Fix NSX rest client to not reset execution counter after a 
login

[miguelferreira] Ignore pmd generated files during license check

[miguelferreira] Move NSX integrationt test to new plugins folder

[miguelferreira] Use logger to print debug messages during test

[miguelferreira] Refactor test cases to reduce duplication

[miguelferreira] Test NSX tunnel in guest network

[nick.livens] CLOUDSTACK-9095 : Hypervisor changes to support UserData for 
Nuage VSP

[wrodrigues] CLOUDSTACK-9106 - Reduces the amount of iterations through the 
routers

[wrodrigues] CLOUDSTACK-9106 - Refactor the createPrivateNicProfileForGateway()

[wrodrigues] CLOUDSTACK-9106 - Enables private gateway tests on Redundant VPCs

[wrodrigues] CLOUDSTACK-9106 - Makes the router commands call more consistent.

[wrodrigues] CLOUDSTACK-9106 - Adds a test to cover the changes in the

[wrodrigues] CLOUDSTACK-9106 - Makes Enum name complia

Re: [DISCUSS] KVM HA with IPMI Fencing

[John Burwell]

Ronald and Ilya,

Reviewing this FS, I feel that it is a very good idea.  However, I think it 
needs the following refinements to ensure the HA fencing/recovery operations do 
not overwhelm the management server and that the capabilities could be used to 
provide HA for non-KVM resources:

  * Separate Host Power Management: Host power management could be useful for 
more than just repairing stalled KVM hosts.  For example, starting a new server 
before provisioning it using the bare metal plugin or implementing a power 
management facility to shut down hosts when demand is low.
  * Define a HA Resource Management Service: Extract the HA check and recovery 
finite state machines (FSM), persistence, and distributed semantics.  The check 
and recovery of specific resource/device types would be provided via plugins.  
In the future, we may also want to consider exposing the service to end users 
-- allowing applications to leverage it for their HA needs.
  * Build KVM Host HA into the HA Resource Management Service: Implement KVM 
Host HA in terms HA resource management service and the IPMI feature.  This 
approach will increase the cohesion of the KVM plugin by colocating HA check 
and recovery implementations.  It will also allow us to separate the 
requirements for proper KVM host HA operation from the more general 
requirements for HA operation on the CloudStack control plane.

Finally, we need to ensure that the HA workload can be fairly scaled and 
recovered across a management server cluster.  I don't think we want to create 
an HA/fencing mechanism that is unreliable when one or more management servers 
in a cluster fail.

Host Power Management Service
=

While I would like to see IPMI extracted to another FR, I am providing my 
feedback here because power management impacts KVM Host HA.  Given the wide 
range of systems management interfaces (e.g. IPMI, ILO, DRAC, converged 
solutions, etc), it seems provide a pluggable power management service.  This 
service would manage per-host power management FSM to capture the current power 
status using the following states:

  * ON: The host is powered on
  * OFF: The host is powered off
  * UNKNOWN: The host's power status cannot be determined

The FSM would default to UNKNOWN and transition based on power state retrieved. 
 If the power status can not be retrieved (e.g. no provider avaiable, not 
configurated, unable to connect to the system management interface), the state 
would remain UNKNOWN.  It also needs to account for the following failure 
scenarios:

  * The power status of the host is changed outside of CloudStack (e.g. a 
datacenter technician manually powers down a host)
  * Connectivity to the host's system management interface is lost
  * Responses from the system management interface are too slow

Both of these scenarios can be handled with a power state sync daemon that 
regularly queries the power state of the host.  In the event that the power 
status changed externally or the management server can no longer query the 
host's system management interface, the sync daemon would transition the host's 
power management FSM to the appropriate state.  To protect against slow 
responses from the system management interface, all power management operations 
should be bounded by a timeout.  It seeems to me that the timeout should be 
configured globally with a per-host override.  Finally, the power management 
FSM state transitions should trigger the following events:

  * ON->OFF: The power state sync daemon detects that the host was turned off
  * OFF->ON: The power state sync daemon detects that the host was turned on
  * ON->UNSUPPORTED: The power state sync daemon loses connectivity to the 
system management controller
  * UNSUPPORTED->OFF, UNSUPPORTED->ON: The power state sync daemon gains 
connectivity to the system management controller
  * User triggered restart
  * User triggered power on
  * User triggered power off

All changes to a host's power state would be broadcast on the event bus.

In terms of implementing IPMI, it is important to note that the FS assumes that 
all management servers will have access to the system management network.  I 
also think we should default to a native Java implementation such as ipmi4j [1] 
with a configurable fallback to shell scripts.  I have two issues with shell 
scripts -- hidden/unmanaged dependencies and process overhead.  These type of 
shell scripts introduce platform dependencies that are difficult to manage and 
vary across distributions making them difficult to properly test across the 
various Linux distributions.  They also incur additional JVM overhead to 
execute with varied error reporting semantics.  By defaulting a Java library 
with a user-defined shell script fallback, the default management server 
behavior is more deterministic and testable while providing users with the 
ability customize it and the burden of managing additional system 
dependencies/

Re: Better way to do development for SSVM agent code

[Syed Mushtaq]

Thanks for your responses guys, I ended up copying the jar that was
generated and restarting the SSVM. One thing to note though is that the
SSVM has a default DROP policy so I needed to change it before I could scp
my jar.

-Syed

On Wed, Dec 9, 2015 at 11:08 PM, Anshul Gangwar 
wrote:

> You can use QuickCloud. With this you can run secondary storage server
> wherever you want.
> For more details refer
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/QuickCloud.
>
> On 10-Dec-2015, at 2:46 AM, Syed Mushtaq  syed1.mush...@gmail.com>> wrote:
>
> Hi,
>
> I've been working on a couple of fixes on the Swift integration which
> primarily involves changes on the agent that runs on the secondary storage
> VM. For every change that I do, I have to rebuild the systemvm profile and
> blow up my secondary storage VM for it to pick up my new code. Natrually,
> this is very time consuming and annoying. If you guys know of a faster way
> to develop/deploy the agent onto SSVM, please do tell.
>
> Thanks,
> -Syed
>
>

Build failed in Jenkins: build-master-slowbuild #2776

[jenkins]

See 

--
[...truncated 28699 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.803s]
[INFO] Apache CloudStack . SUCCESS [2.097s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.763s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.753s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.185s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.385s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.074s]
[INFO] Apache CloudStack API . SUCCESS [1:49.528s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.250s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [31.173s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.085s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.549s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.195s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.751s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.293s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [38.278s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.128s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:14.898s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [50.222s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [29.070s]
[INFO] Apache CloudStack Server .. SUCCESS [4:37.628s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [43.746s]
[INFO] Apache CloudStack Usage Server  SUCCESS [50.177s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:33.003s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.066s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.573s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [1:08.017s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.935s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.941s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.167s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [27.029s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.238s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [1:52.557s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [2:07.247s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [52.468s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [7.258s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [1:15.808s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[30.840s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[1:06.458s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [36.178s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [44.956s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [18.971s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[19.363s]
[INFO] A

Re: AW: Run Windows on top of KVM+virtio? Watch out for Windows updates, system unbootable!

[Nux!]

Ingo,

Yes, I use the same. But the drivers "SUSE Storage/Net" in Windows Optional 
updates override them. 
Verified on 2008r2 and 2012r2.
Luckily the damage is limited as they are in the Optional channel, not sure how 
many people chose to install those alongside the Important ones, but hopefully 
it won't be that many.

I also got fscked by an update Microsoft pushed for some Intel fake-raid the 
other day.
You'd think a humongous, multi-billion dollar company has some resources to do 
QA, especially on their "Enterprise" products.

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Jochim, Ingo" 
> To: us...@cloudstack.apache.org, "dev" 
> Sent: Thursday, 10 December, 2015 11:58:03
> Subject: AW: Run Windows on top of KVM+virtio? Watch out for Windows updates, 
> system unbootable!

> Hi,
> 
> you can use the virtio drivers from the Fedora Project.
> I didn't have problems on W2k12 and W2k12R2.
> 
> https://fedoraproject.org/wiki/Windows_Virtio_Drivers
> 
> Regards,
> Ingo
> 
> 
> -Ursprüngliche Nachricht-
> Von: Nux! [mailto:n...@li.nux.ro]
> Gesendet: Mittwoch, 9. Dezember 2015 10:42
> An: dev
> Cc: Cloudstack Users List
> Betreff: Run Windows on top of KVM+virtio? Watch out for Windows updates, 
> system
> unbootable!
> 
> Hi,
> 
> Just a quick heads-up!
> Someone on the CentOS ML reported his Windows 2008r2 VM on top of KVM+VirtIO 
> PV
> ended up unbootable after he installed the SUSE Network and Storage drivers
> from the Optional Updates channel.
> I've just checked now and it's the case, the system blue screens after reboot.
> Will test 2012r2 shortly.
> 
> 
> It'd be best if you don't install those updates/drivers for now, looks like
> someone in Redmond didn't do his homework.
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> --
> This email was Virus checked by UTM 9. http://www.sophos.com
> 
> --
> This email was Virus checked by UTM 9. http://www.sophos.com

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

[maneesha-p]

Github user maneesha-p closed the pull request at:

https://github.com/apache/cloudstack/pull/1159


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

[maneesha-p]

GitHub user maneesha-p opened a pull request:

https://github.com/apache/cloudstack/pull/1216

CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0

Added suitable db entries in tables hypervisor_capabilities and 
guest_os_hypervisor to support VMware 6.0 by copying from 5.5 and excluding few 
depricated guest os.And also entries for guest os RHEL 7 for vmware 5.5 and 6.0.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maneesha-p/cloudstack BUG-9103

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1216


commit 59ab097429528becdd6c7d143296f3bf48da4bd2
Author: Maneesha.P 
Date:   2015-12-11T03:41:21Z

CLOUDSTACK-9103 : Missing OS Mappings for VMware 6.0




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

[maneesha-p]

Github user maneesha-p commented on the pull request:

https://github.com/apache/cloudstack/pull/1159#issuecomment-163831485
  
@jburwell @DaanHoogland Raised a new PR(1216) with changes suggested .
@bhaisaab As master is in 4.7 we dont need the change in every upgrade path 
before 4.6 as we can pull the changes required.
Please review pr-1216.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/823#issuecomment-163834017
  
@nitin-maharana The current way was to move the service offering to a 
similar or a more flexible one in terms of deployment. While this change will 
make the new service offering more restrictive and may result in change of 
deployment. This does not sound very reasonable. cc @DaanHoogland 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/872#discussion_r47320168
  
--- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf ---
@@ -30,4 +35,5 @@ conn L2TP-PSK
 # --
 # Change 'ignore' to 'add' to enable this configuration.
 #
+rightsubnetwithin=10.1.2.0/8
--- End diff --

I thought of keeping /24 but what if the range falls in /20 or /18. I am 
not sure how much range is used in production in general.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9136: remove ssh keypairs alon...

[agneya2001]

Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/1212#issuecomment-163835153
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9103 : Missing OS Mappings for...

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1216#discussion_r47322960
  
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -420,3 +420,7 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` 
(uuid,hypervisor_type, hypervis
 INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, 
hypervisor_version, guest_os_name, guest_os_id, created, is_user_defined) 
VALUES (UUID(),'KVM', 'default', 'CentOS 7', 246, utc_timestamp(), 0);
 
 UPDATE  `cloud`.`hypervisor_capabilities` SET  `max_data_volumes_limit` =  
'32' WHERE  `hypervisor_capabilities`.`hypervisor_type` =  'KVM';
+
--- End diff --

For master/4.7.0, we don't need the sql changes in 452-to-460.sql. Please 
remove this.
LGTM, otherwise.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9130: Make RebootCommand simil...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1200#issuecomment-163862343
  
LGTM based on these tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok
Test for port for

[GitHub] cloudstack pull request: Setup routes for RFC 1918 ip space

[terbolous]

Github user terbolous commented on the pull request:

https://github.com/apache/cloudstack/pull/1214#issuecomment-163862541
  
What about users who solely use rfc1918 address space? That could easily be 
the case for internal or enterprise users.
I am in doubt about this change, as I fear it might break such solutions. 

As for the internal dns issue, isn't that already solved by creating a 
manual route entry for it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9114: restartnetwork with clea...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1198#issuecomment-163864347
  
FYI, run integration tests:

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a 
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_routers_network_ops.py \
component/test_vpc_router_nics.py \
smoke/test_loadbalance.py \
smoke/test_internal_lb.py \
smoke/test_ssvm.py \
smoke/test_network.py

```

Result:

```
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and 
check default routes ... === TestName: test_02_redundant_VPC_default_routes | 
Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: 
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Status : 
SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: 
test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics 
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : 
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default 
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: 
test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === 
TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: 
test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: 
test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: 
test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === 
TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS 
===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic 
to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 
| Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : 
SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : 
SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS 
===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS 
===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS 
===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS 
===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn 
| Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
ok
test_01_vpc_privategw_acl 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_01_vpc_privategw_acl | Status : SUCCESS ===
ok
test_02_vpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_02_vpc_privategw_static_routes | Status : SUCCESS ===
ok
test_03_rvpc_privategw_static_routes 
(integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: 
test_03_rvpc_privategw_static_routes | Status : SUCCESS ===
ok
Test for port fo