[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...

2015-12-23 Thread anshul1886
GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1282

CLOUDSTACK-9200: Fixed failed to delete snapshot if snapshot is stuck in 
Allocated state without any job associated with it

https://issues.apache.org/jira/browse/CLOUDSTACK-9200

This issue is hard to reproduce but if occurs then it may lead to account 
resources cleanup failures.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9200

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1282


commit 1fb9b64321dbdbdd42e0cc560c65d45cd08af6c2
Author: Anshul Gangwar 
Date:   2015-12-09T08:33:29Z

CLOUDSTACK-9200: Fixed failed to delete snapshot if snapshot is stuck in 
Allocated state without any job associated with it




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Build failed in Jenkins: build-master-slowbuild #2783

2015-12-23 Thread Daan Hoogland
On Wed, Dec 23, 2015 at 7:20 AM, Sateesh Chodapuneedi <
sateesh.chodapune...@citrix.com> wrote:

> Daan,
> Shall fix those listed in following. But unable to logon to
> Jenkins.buildacloud.org, can you please help with login?
>
> 
>

​Yes I can​



-- 
Daan


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pdion891
Github user pdion891 commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166866589
  
Nice !+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166866569
  
![screen shot 2015-12-23 at 4 55 10 
pm](https://cloud.githubusercontent.com/assets/95203/11975648/fd36c81e-a995-11e5-9fe9-9e70a25327e5.png)

File name changed to reflect the content


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1249#issuecomment-166871427
  
@michaelandersen Can you review this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1249#issuecomment-166871327
  
@mandersen Can you review this please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9128: Testcase to verify physi...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1199#issuecomment-166878523
  
@remibergsma can you merge these changes?  thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---



[GitHub] cloudstack pull request: CLOUDSTACK-9121: Adding VmSnapshot valida...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1190#issuecomment-166878697
  
@remibergsma can you please check this commit and merge it in?  Thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1130#issuecomment-166878921
  
@remibergsma can you please merge this in?  Thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2807

2015-12-23 Thread jenkins
See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[2.067s]
[INFO] Apache CloudStack . SUCCESS [2.608s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.827s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.584s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.657s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.138s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.723s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.695s]
[INFO] Apache CloudStack API . SUCCESS [1:58.380s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.596s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.947s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.126s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.923s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.038s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.069s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.884s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.655s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.172s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.525s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.770s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.329s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.112s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.193s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.161s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.971s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.106s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.509s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.118s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.215s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [31.423s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.750s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [31.349s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.927s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [45.576s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.577s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.613s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.010s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.148s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.440s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.217s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.272s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.576s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.750s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.137s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1041#issuecomment-166879168
  
LGTM - changes look pretty straightforward.  @remibergsma can you please 
merge this in.  Thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1130#issuecomment-166879268
  
@pvr9711 Please make sure we have 2xLGTM of which at least one run the 
test. Will not merge without.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8996: Reducing Virual Machine ...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1010#issuecomment-166879406
  
@borisroman , @bhaisaab , this refactoring helps speed up BVT runs by 
reducing the number of VM deployments.  we should get the test results to close 
on this PR though.   
@pritisarap12, can you please post the test results ?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira closed the pull request at:

https://github.com/apache/cloudstack/pull/1284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1285#issuecomment-166936459
  
I've tested this PR manually in our beta environment, however ince there is 
a marvin test for this functionality I would also like to run that. I haven't 
yet because I haven't found a way to feed the required test data into the test 
run.

Advice on how to run the respective marvin test is very welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1284#issuecomment-166936174
  
I've tested this PR manually in our beta environment, however ince there is 
a marvin test for this functionality I would also like to run that. I haven't 
yet because I haven't found a way to feed the required test data into the test 
run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request:

https://github.com/apache/cloudstack/pull/1285

Map LDAP group to Cloudstack account

The LDAP plugin authenticates Cloudstack users against users in an LDAP 
group, and when doing so creates a Cloudstack account with the same name as the 
LDAP user, and a Cloudstack user also with the same name as the LDAP user.
This makes it difficult to manage the users in a given LDAP group because 
each user will have it's own account and user in Cloudstack, and cannot 
therefore collaborate in managing cloud resources.

This PR changes the LDAP plugin to use the LDAP group for the Cloudstack 
account name, and create the users (belonging to the LDAP group) under the same 
Cloudstack account.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguelaferreira/cloudstack 
map-ldap-group-to-account

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1285.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1285


commit 42d0418530599717624f4614220d06c83ea48c2a
Author: Miguel Ferreira 
Date:   2015-12-23T13:49:29Z

Code formatting

commit 1ca4e484e0730f7a114dd4af7abcb2bcc11e7337
Author: Miguel Ferreira 
Date:   2015-12-23T13:49:53Z

Make ACS account using LDAP group name

commit 0089647c11a36e23cb89770f63c971ee8c12fe89
Author: Miguel Ferreira 
Date:   2015-12-23T14:16:48Z

Enable Java based unit tests in mvn lifecycle




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-12-23 Thread ustcweizhou
Github user ustcweizhou commented on the pull request:

https://github.com/apache/cloudstack/pull/866#issuecomment-166890582
  
good, this might also be useful for restartnetwork, see #1198 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pdube
Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166911537
  
lol @DaanHoogland . +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2015-12-23 Thread pdube
Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961
  
Shouldn't we log this information? Doesn't this mean that some resources 
could be freed up on the hypervisor?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-23 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1276#discussion_r48350750
  
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services, 
retries):
 
 return ssh_client
 
-def create_natrule(self, vpc, vm, public_port, private_port, 
public_ip, network, services=None):
+def _create_natrule(self, vpc, vm, public_port, private_port, 
public_ip, network, services=None):
--- End diff --

why _create_natrule() and not create_natrule()?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...

2015-12-23 Thread pdube
Github user pdube commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-166910265
  
How do you know if there are no jobs associated with it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread jburwell
Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166934017
  
+1 LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
GitHub user miguelaferreira opened a pull request:

https://github.com/apache/cloudstack/pull/1284

Map ldap group to Cloudstack account

The LDAP plugin authenticates Cloudstack users against users in an LDAP 
group, and when doing so creates a Cloudstack account with the same name as the 
LDAP user, and a Cloudstack user also with the same name as the LDAP user.
This makes it difficult to manage the users in a given LDAP group because 
each user will have it's own account and user in Cloudstack, and cannot 
therefore collaborate in managing cloud resources.

This PR changes the LDAP plugin to use the LDAP group for the Cloudstack 
account name, and create the users (belonging to the LDAP group) under the same 
Cloudstack account.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguelaferreira/cloudstack 
map-ldap-group-to-account

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1284


commit 42d0418530599717624f4614220d06c83ea48c2a
Author: Miguel Ferreira 
Date:   2015-12-23T13:49:29Z

Code formatting

commit 1ca4e484e0730f7a114dd4af7abcb2bcc11e7337
Author: Miguel Ferreira 
Date:   2015-12-23T13:49:53Z

Make ACS account using LDAP group name

commit 0089647c11a36e23cb89770f63c971ee8c12fe89
Author: Miguel Ferreira 
Date:   2015-12-23T14:16:48Z

Enable Java based unit tests in mvn lifecycle




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2808

2015-12-23 Thread jenkins
See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.794s]
[INFO] Apache CloudStack . SUCCESS [2.156s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.775s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.971s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.858s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.100s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.414s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.934s]
[INFO] Apache CloudStack API . SUCCESS [1:52.211s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.786s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.493s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.115s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.357s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.148s]
[INFO] Apache CloudStack Core  SUCCESS [1:24.015s]
[INFO] Apache CloudStack Agents .. SUCCESS [37.001s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.562s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.430s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:06.582s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.461s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.110s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.289s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.619s]
[INFO] Apache CloudStack Usage Server  SUCCESS [45.646s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.609s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.066s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.433s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.125s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.401s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.376s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.437s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.468s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.841s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [37.146s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.246s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.608s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.965s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.861s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.296s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.612s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.480s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.085s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.703s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.709s]
[INFO] Apache 

[GitHub] cloudstack pull request: Map ldap group to Cloudstack account

2015-12-23 Thread miguelaferreira
Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1284#issuecomment-166936278
  
Closing as this should have been directed at 4.7 branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166955980
  
Works for me. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2809

2015-12-23 Thread jenkins
See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.914s]
[INFO] Apache CloudStack . SUCCESS [2.227s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.771s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [20.327s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.322s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.099s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.025s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.489s]
[INFO] Apache CloudStack API . SUCCESS [1:51.635s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.698s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.032s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.084s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.177s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.850s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.625s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.899s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.591s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.109s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:05.523s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.896s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.173s]
[INFO] Apache CloudStack Server .. SUCCESS [4:08.932s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.034s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.069s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.903s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.070s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.448s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.227s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.963s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.265s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.680s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.011s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.664s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.214s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.497s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.760s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.033s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.133s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.615s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.995s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.708s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.569s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.939s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.974s]
[INFO] Apache 

Build failed in Jenkins: build-master-slowbuild #2811

2015-12-23 Thread jenkins
See 

--
[...truncated 28732 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.906s]
[INFO] Apache CloudStack . SUCCESS [2.198s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.765s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.862s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.359s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.104s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.910s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.178s]
[INFO] Apache CloudStack API . SUCCESS [1:51.791s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [15.948s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.505s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.097s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.439s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.356s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.262s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.939s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.212s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.240s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:05.761s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.598s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.377s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.840s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.983s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.949s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.570s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.074s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.431s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.911s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.597s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [31.284s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.354s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [30.734s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.349s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.199s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.517s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.207s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.941s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.386s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.549s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.704s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.474s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.249s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.821s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.492s]
[INFO] Apache 

Build failed in Jenkins: build-master-slowbuild #2812

2015-12-23 Thread jenkins
See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.802s]
[INFO] Apache CloudStack . SUCCESS [2.114s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.802s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.081s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.565s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.110s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.540s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.377s]
[INFO] Apache CloudStack API . SUCCESS [1:49.499s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.413s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.454s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.086s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.690s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.067s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.405s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.697s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.929s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.421s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.629s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.127s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.194s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.522s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.949s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.000s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.218s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.077s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.492s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.209s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.729s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.824s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [27.140s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [32.114s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.447s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.287s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.272s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.929s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.006s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.506s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[24.066s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.310s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.522s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.585s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.855s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.842s]
[INFO] Apache 

Re: Protocol to add scripts to a newer version of ACS

2015-12-23 Thread Rafael Weingärtner
Thanks Remi, I will use it in a PR that I am working on.

BTW: I have read a few articles (software engineering baseline management
of database objects) and searched for some tool to help us with ACS
“schema” scripts to update the database during ACS updates. I am drafting a
model that we can use to manage scripts and improve ACs database updates. I
think that I will have it ready only after 04/01/16 (giving Christmas and
New Year’s Eve). After that I believe we can start discussing and maybe
planning some changes in our protocol to create DB scripts.

On Mon, Dec 21, 2015 at 8:14 PM, Remi Bergsma 
wrote:

> Hi Rafael,
>
> You can now make your change in this file:
>
> https://github.com/apache/cloudstack/blob/master/setup/db/db/schema-471to480.sql
>
> Regards,
> Remi
>
>
>
> On 21/12/15 12:05, "Rafael Weingärtner" 
> wrote:
>
> >Thank you guys,
> >I guess I should wait for Remi's PR.
> >
> >On Mon, Dec 21, 2015 at 7:20 AM, Remi Bergsma <
> rberg...@schubergphilis.com>
> >wrote:
> >
> >> - set new version
> >> - create sql files
> >> - construct upgrade path
> >>
> >> Need to be one PR per branch as otherwise you end up on the new version
> >> without upgrade path. We did it like this last time as well.
> >>
> >> Will send a PR per branch.
> >>
> >> Sent from my iPhone
> >>
> >> > On 21 Dec 2015, at 09:48, Daan Hoogland 
> wrote:
> >> >
> >> > Remi, What do you mean by 'more things'? It sounds like i would like
> to
> >> see
> >> > more then one PR.
> >> >
> >> > On Mon, Dec 21, 2015 at 9:19 AM, Remi Bergsma <
> >> rberg...@schubergphilis.com>
> >> > wrote:
> >> >
> >> >> More things need to change at the same time. I will try to send a PR
> for
> >> >> all of it today.
> >> >>
> >> >> Regards, Remi
> >> >>
> >> >> Sent from my iPhone
> >> >>
> >> >>> On 21 Dec 2015, at 07:51, Daan Hoogland 
> >> wrote:
> >> >>>
> >> >>> H Rafael, just make a PR. the 4.7.0 should serve as a proper
> example.
> >> >>>
> >> >>> On Sun, Dec 20, 2015 at 10:19 PM, Rafael Weingärtner <
> >> >>> rafaelweingart...@gmail.com> wrote:
> >> >>>
> >>  Hi guys,
> >> 
> >>  I am working on a PR that will require some data to be added to
> >>  “guest_os_hypervisor” table. However, there is no “*to480.sql”
> script
> >> >> yet.
> >>  How is the protocol to add those inserts that I need into the code
> >> base?
> >> 
> >> 
> >>  --
> >>  Rafael Weingärtner
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>> Daan
> >> >
> >> >
> >> >
> >> > --
> >> > Daan
> >>
> >
> >
> >
> >--
> >Rafael Weingärtner
>



-- 
Rafael Weingärtner


[GitHub] cloudstack pull request: CLOUDSTACK-9200: Fixed failed to delete s...

2015-12-23 Thread anshul1886
Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1282#issuecomment-167040721
  
@pdube Snapshot can be in Allocated state for a split second only in normal 
scenarios. If it is in Allocated state for more than that time, then it simply 
means we are either restarting or have to restart the management server. Now if 
that's the case then it should have been cleaned up by storage cleanup thread 
during management server start if it has job associated with it. But that is 
not happening so it is falling in this scenario.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9161: fix the quota marvin tes...

2015-12-23 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1240#issuecomment-167042039
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2015-12-23 Thread bhaisaab
Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1254#issuecomment-167041889
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1281


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...

2015-12-23 Thread anshul1886
Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1274#issuecomment-167040113
  
@pdube That part is handled elsewhere. Here we are concerned about syncing 
of VM metadata. So here if the VM is not in cloud DB then we are ignoring it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread resmo
Github user resmo commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166980994
  
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.7] FIX Site2SiteVPN on redundant VPC

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1276#discussion_r48382355
  
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services, 
retries):
 
 return ssh_client
 
-def create_natrule(self, vpc, vm, public_port, private_port, 
public_ip, network, services=None):
+def _create_natrule(self, vpc, vm, public_port, private_port, 
public_ip, network, services=None):
--- End diff --

a matter of style i guess, i consistently changed private methods/non-tests 
to be prefixed with an underscore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-166987980
  
@nitin-maharana, thanks for the update, I will just call your attention to 
a few points:

First of all, why did you open a new PR? I know you closed the other one, 
but IMHO it makes my job harder. The other PR had all of our conversions; you 
should have kept working there. It would be easier to track everything that was 
discussed if everything was at the same PR. Now please, keep with this one, no 
need to come back to the one you already closed or to open a new one after my 
suggestions.

I noticed that you extract the code to a method as I suggested and created 
some test cases. You also add the “required = true” as Daan suggested; that 
is good.

Now about the method “getVolumeNameFromCommand” you created. Please 
note that // is not the proper way to create a Java doc, please replace the // 
by the proper mark of Java docs

/** 
* this is a java doc
**/

/*
*This is a block comment
*/

// this is a line comment

About the Java doc I would also encourage you to detail a little bit more 
the method such as:
/** 
* This method retrieves the volume name from the CreateVolumeCmd object.
* If the method CreateVolumeCmd#getVolumeName() returns null, empty or 
blank, It will be generated a random name using getRandomVolumeName().
**/

I do not know the proper notation of java doc to make reference to java 
classes and methods, so you will need to google it.

Now about the tests, please remove those comments over method names. I 
believe they are not needed as the test method name is self-explained.

About the “docs.js”, please improve the sentence you wrote. 'Enter a 
unique volume name; if a name is not provided, a random name will be created'

Now, I draw your attention again to the idea of sticking to the same PR 
were we started reviewing and chatting. If another reviewer comes to help with 
this new PR, she/he would not know about the blank case I told you in the other 
PR. The reviewer might even give a LGTM without even noticing that this PR is 
incomplete.
Having said that, could you add a test case to check the case in which 
users enter blank strings in the volume name? And of course, fix that in the 
code; otherwise, the test methods would not work.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2810

2015-12-23 Thread jenkins
See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.888s]
[INFO] Apache CloudStack . SUCCESS [2.438s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.766s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.278s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.723s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.104s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.518s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.924s]
[INFO] Apache CloudStack API . SUCCESS [1:48.691s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.756s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.475s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.089s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.569s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.039s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.678s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.556s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [37.192s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [15.458s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.382s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.051s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.247s]
[INFO] Apache CloudStack Server .. SUCCESS [4:15.304s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.801s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.212s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.217s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.068s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.447s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.645s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.319s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.191s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.299s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [22.672s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.517s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.262s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.289s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.414s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.007s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.056s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.649s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.330s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.565s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.316s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.887s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.809s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1283#issuecomment-167045587
  
@anshul1886 If the fix was added in 4.2, why it got missed out? Can you 
check the history and update?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

2015-12-23 Thread anshul1886
Github user anshul1886 commented on the pull request:

https://github.com/apache/cloudstack/pull/1283#issuecomment-167046667
  
@koushik-das It was merged to 4.2-forward  but was not merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1285#issuecomment-167044637
  
@miguelaferreira Looks like this PR is going to impact the feature 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LDAP%3A+Trust+AD+and+Auto+Import
 that @karuturi added in 4.6. Please start a discussion thread at dev@ before 
proceeding further with this one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Removed unused variables from "NetworkSta...

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1261#issuecomment-167047897
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2813

2015-12-23 Thread jenkins
See 

Changes:

[Rohit Yadav] README: happy holidays!

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.721s]
[INFO] Apache CloudStack . SUCCESS [2.062s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.784s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.160s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.997s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.100s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.979s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.370s]
[INFO] Apache CloudStack API . SUCCESS [1:47.719s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.203s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.019s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.088s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.622s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.232s]
[INFO] Apache CloudStack Core  SUCCESS [1:20.980s]
[INFO] Apache CloudStack Agents .. SUCCESS [37.379s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.735s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.295s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:06.140s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.792s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.186s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.816s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.059s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.319s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.811s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.078s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.441s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.189s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.077s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.176s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.381s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.814s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [22.710s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.390s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.479s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.599s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.011s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.526s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.701s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.205s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.931s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.183s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.833s]
[INFO] Apache CloudStack Plugin - Host 

[GitHub] cloudstack pull request: CLOUDSTACK-9133: Two volume.delete usage ...

2015-12-23 Thread priyankparihar
Github user priyankparihar closed the pull request at:

https://github.com/apache/cloudstack/pull/1207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9005: Modifying tearDown funct...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/1000#issuecomment-166879646
  
@remibergsma can you please merge this in?  thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9001: Modifying snapshot resul...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/994#issuecomment-166879847
  
@remibergsma can you please merge this in?  thanks, Raja


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/869#issuecomment-166880339
  
@runseb, this cannot be run via simulator.  
LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

2015-12-23 Thread pvr9711
Github user pvr9711 commented on the pull request:

https://github.com/apache/cloudstack/pull/384#issuecomment-166880792
  
@remibergsma can you please comment on this PR, if it was merged ?  thanks,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1277#issuecomment-166881123
  
@koushik-das Github cannot display large diffs. This is how you can show it 
on your local checkout:

```
prId=1277
git checkout master
git fetch origin pull/${prId}/head:pr/${prId}
git checkout pr/${prId}
git show 2aab4c142d47b77e7bbc584927a80b8ba180934e 
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java
```

Hope this helps.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: engine/schema: Use semantically correct u...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1279#issuecomment-166883594
  
@bhaisaab Thanks, makes sense. Will test an upgrade and report back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

2015-12-23 Thread koushik-das
Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1277#issuecomment-166884395
  
@remibergsma What you are suggesting is to pull the commit locally and then 
view it using git show. But then we are loosing the benefit of viewing and 
in-place review of the code where you can put some comment. Would it help to 
break these bigger changes into multiple commits to keep github happy?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/384#issuecomment-166888535
  
It was not merged, see also #720.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

2015-12-23 Thread remibergsma
Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/869#issuecomment-166888961
  
@pvr9711 Where is your LGTM based on? I'd like to see some background, as 
otherwise we don't know what you tested / reviewed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...

2015-12-23 Thread anshul1886
GitHub user anshul1886 opened a pull request:

https://github.com/apache/cloudstack/pull/1283

CLOUDSTACK-4572: findHostsForMigration API does not return correct host list

https://issues.apache.org/jira/browse/CLOUDSTACK-4572

Fix is missing in recent releases.

The api should return the list of suitable/unsuitable hosts
Added fix that creates a deep copy of the the variable allHosts and 
prevents faulty host list return.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-4572

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1283


commit 2cea4d42510230a61c2858ce5789b199cbc6398b
Author: Saksham Srivastava 
Date:   2013-08-30T19:30:41Z

CLOUDSTACK-4572: findHostsForMigration API does not return correct host list

Changes:
Expected behavior:
The api should return the list of suitable/unsuitable hosts
Added fix that creates a deep copy of the the variable allHosts and 
prevents faulty host list return.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: Fixed issues with test_vpc_vpn script

2015-12-23 Thread michaelandersen
Github user michaelandersen commented on the pull request:

https://github.com/apache/cloudstack/pull/1156#issuecomment-166835953
  
Hi @sanju1010,  @wilderrodrigues asked me to extend the test_vpc_vpn script 
and in the proces i added the other hypervisors. 
https://github.com/apache/cloudstack/pull/1276
Could you review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread wido
Github user wido commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166836536
  
:+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread NuxRo
Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166837966
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-12-23 Thread bvbharatk
Github user bvbharatk commented on the pull request:

https://github.com/apache/cloudstack/pull/866#issuecomment-166838925
  
@DaanHoogland 

Added a test to verify if the routers are getting updated one after the 
other.

Test create network with redundant routers ... === TestName: 
test_createRvRNetwork | Status : SUCCESS === 
ok
Test create network with non-default guest cidr with redundant routers ... 
=== TestName: test_createRvRNetwork | Status : SUCCESS === 
ok
Test create RvR supported network offering ... === TestName: 
test_createRvRNetworkOffering | Status : SUCCESS === 
ok
Test redundant router internals ... === TestName: 
test_redundantVR_internals | Status : SUCCESS === 
ok
Test stop master RVR ... === TestName: test_01_stopMasterRvR | Status : 
SUCCESS === 
ok
Test stop backup RVR ... === TestName: test_02_stopBackupRvR | Status : 
SUCCESS === 
ok
Test reboot master RVR ... === TestName: test_03_rebootMasterRvR | Status : 
SUCCESS === 
ok
Test reboot backup RVR ... === TestName: test_04_rebootBackupRvR | Status : 
SUCCESS === 
ok
Test stop backup RVR and start instance ... === TestName: 
test_05_stopBackupRvR_startInstance | Status : SUCCESS === 
ok
Test update network and check if VRs are updated in sequence ... === 
TestName: test_06_updateVRs_in_sequence | Status : SUCCESS === 
ok

--
Ran 10 tests in 5941.052s

OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: build-master-slowbuild #2806

2015-12-23 Thread jenkins
See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.634s]
[INFO] Apache CloudStack . SUCCESS [2.105s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.776s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [21.264s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.368s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.106s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.782s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.786s]
[INFO] Apache CloudStack API . SUCCESS [1:48.985s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.100s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.542s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.084s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.380s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.515s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.857s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.979s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.416s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.027s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.675s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.325s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.417s]
[INFO] Apache CloudStack Server .. SUCCESS [4:14.346s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.496s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.725s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.919s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.070s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.434s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.916s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.233s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.530s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.763s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.716s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.891s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.003s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.346s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.161s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.026s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.465s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.649s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.424s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.181s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.753s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.311s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.802s]
[INFO] Apache 

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread bhaisaab
GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack/pull/1281

README: happy holidays!

Happy holidays, let's merge this asap
cc @remibergsma @DaanHoogland @wido @wilderrodrigues @abhinandanprateek 
@jburwell @borisroman @miguelaferreira @runseb @milamberspace @ke4qqq @karuturi 
@mlsorensen @mike-tutkowski @NuxRo @pdion891 @resmo @pyr and others

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack happy-holidays15

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1281


commit 1a194e67454933b0321ac38d5ac654f6206c7fc0
Author: Rohit Yadav 
Date:   2015-12-23T07:57:40Z

README: happy holidays!

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread pyr
Github user pyr commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166830690
  
:+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

2015-12-23 Thread nitin-maharana
Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-166830953
  
Sure @koushik-das. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread milamberspace
Github user milamberspace commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166833276
  
:+1:  Happy holidays!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread agneya2001
Github user agneya2001 commented on the pull request:

https://github.com/apache/cloudstack/pull/1281#issuecomment-166833361
  
sure !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---