[GitHub] cloudstack issue #1642: System VMs on Managed Storage

2016-08-25 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
Sounds good, @jburwell


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1642: System VMs on Managed Storage

2016-08-25 Thread jburwell
Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
@mike-tutkowski we usually increase the garbage collection frequency and 
reduce any wait time global settings  in order to speed up tests.  Coupled with 
the wait_until Marvin, you build fairly quick, deterministic automated tests 
for these types of scenarios.  If you like more info on this strategy, let me 
know.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1642: System VMs on Managed Storage

2016-08-25 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
Ah, I think I "jumped the gun" on this. It looks like the three SRs (and 
corresponding volumes on the SAN) were to be deleted by a background thread 
(which I didn't wait for).

I plan to set this up again and see if they get automatically deleted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76323706
  
--- Diff: packaging/systemd/cloudstack-agent.default ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+JAVA_HOME=/usr/lib/jvm/jre
+if [ ! -f "$JAVA_HOME"/bin/java ] ; then
+JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
+fi
--- End diff --

@vincentbernat yes this worked for me both on CentOS 7.2, Ubuntu 16.04 
(systemd). Can you build packages and help with a secondary test. When the 
service starts it executes the environment/default file which gives us the 
$(readlink...) to replace $JAVA_HOME usage. I see this in my CentOS 7.2 
environment (and similar on Ubuntu 16.04):

```
 root 27929  0.0  0.0 115340  1616 ?Ss   20:57   0:00 /bin/sh 
-ec  export UCP=`ls /usr/share/cloudstack-usage/cloud-usage-*.jar 
/usr/share/cloudstack-usage/lib/*.jar /usr/share/cloudstack-mysql-ha/lib/*.jar 
| tr "\n" ":"`;  export 
CLASSPATH="$UCP:/etc/cloudstack/usage:/usr/share/java/mysql-connector-java.jar";
  $(readlink -f /usr/bin/java | sed 's:/bin/java::')/bin/java -Dpid=$$ 
-Xms256m -Xmx2048m -cp "$CLASSPATH" $JAVA_CLASS
 root 27936  7.4 13.3 3616388 251860 ?  Sl   20:57   0:07 java 
-Dpid=27929 -Xms256m -Xmx2048m -cp 
/usr/share/cloudstack-usage/cloud-usage-4.9.1.0-SNAPSHOT.jar:/usr/share/cloudstack-usage/lib/activation-1.1.jar:/usr/share/cloudstack-usage/lib/annotations-2.0.1.jar:/usr/share/cloudstack-usage/lib/antisamy-1.5.3.jar:/usr/share/cloudstack-usage/lib/aopalliance-1.0.jar
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-25 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1593
  
LGTM with smoke testing. RHEL 6 management servers, advanced networking, 
Vmware 5.5 .and 6  hypervisors


[root@ussarlabcsmgt41 smoke]# cat 
/tmp//MarvinLogs/test_volumes_340FH1/results.txt|grep -v ok
test DeployVM in anti-affinity groups for project ... === TestName: 
test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS ===
test DeployVM in anti-affinity groups ... === TestName: 
test_DeployVmAntiAffinityGroup | Status : SUCCESS ===
Test Deploy Virtual Machine ... SKIP: Skipping test because suitable 
hypervisor/host notpresent
Test Deploy Virtual Machine from ISO ... === TestName: 
test_deploy_vm_from_iso | Status : SUCCESS ===
Test deploy virtual machine with root resize ... === TestName: 
test_00_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize of 0 ... 
=== TestName: test_01_deploy_vm_root_resize | Status : SUCCESS ===
Test proper failure to deploy virtual machine with rootdisksize less than 
template size ... === TestName: test_02_deploy_vm_root_resize | Status : 
SUCCESS ===
Test to deploy vm with a first fit offering ... === TestName: 
test_deployvm_firstfit | Status : SUCCESS ===
Test deploy VMs using user concentrated planner ... === TestName: 
test_deployvm_userconcentrated | Status : SUCCESS ===
Test deploy VMs using user dispersion planner ... === TestName: 
test_deployvm_userdispersing | Status : SUCCESS ===
Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | 
Status : SUCCESS ===
Test userdata as POST, size > 2k ... === TestName: 
test_deployvm_userdata_post | Status : SUCCESS ===
Test to create disk offering ... === TestName: test_01_create_disk_offering 
| Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_02_create_sparse_type_disk_offering | Status : SUCCESS ===
Test to create  a sparse type disk offering ... === TestName: 
test_04_create_fat_type_disk_offering | Status : SUCCESS ===
Test to update existing disk offering ... === TestName: 
test_02_edit_disk_offering | Status : SUCCESS ===
Test to delete disk offering ... === TestName: test_03_delete_disk_offering 
| Status : SUCCESS ===
Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Test to check role, role permissions and account life cycles ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: 
Dynamic Role-Based API checker not enabled, skipping test
Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based 
API checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests that default four roles exist ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, 
skipping test
Tests role update when role is in use by an account ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests concurrent order updation of role permission ... SKIP: Dynamic 
Role-Based API checker not enabled, skipping test
Tests creation of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker 
not enabled, skipping test
Tests listing of default role's permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
Tests order updation of role permission ... SKIP: Dynamic Role-Based API 
checker not enabled, skipping test
test update configuration setting at zone level scope ... === TestName: 
test_UpdateConfigParamWithScope | Status : SUCCESS ===
Test guest vlan range dedication ... === TestName: 
test_dedicateGuestVlanRange | Status : SUCCESS ===
Test create public & private ISO ... === TestName: test_01_create_iso | 
Status : SUCCESS ===
Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS ===
Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS ===
Test for extract ISO ... === TestName: test_04_extract_Iso | Status : 
SUCCESS ===
Update & Test for ISO permissions ... === TestName: test_05_iso_permissions 
| Status : SUCCESS ===
Test for copy ISO from one zone to another ... SKIP: Not enough zones 
available to perform copy template
Test delete ISO ... === TestName: test_07_list_default_iso | Status : 
SUCCESS ===
Test listing Volumes using 'ids' parameter ... === TestName: 
test_01_list_volumes | Status : SUCCESS ===
Test listing 

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76320932
  
--- Diff: packaging/systemd/cloudstack-agent.default ---
@@ -0,0 +1,24 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+JAVA_HOME=/usr/lib/jvm/jre
+if [ ! -f "$JAVA_HOME"/bin/java ] ; then
+JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
+fi
--- End diff --

Are you sure this will work with systemd? On Ubuntu, the best it could do 
is to keep `JAVA_HOME=/usr/lib/jvm/jre` which is not valid on Ubuntu. Maybe, it 
would be easier to push that inside the ExecStart (and equivalent in init.d):

```
if [ -n "$JAVA_HOME" ]; then
  export JAVA_HOME=$(readlink -f /usr/bin/java | sed 's:/bin/java::')
fi
```

Or, keeping it for RHEL in the default file but using in ExecStart:

```
[ -d "$JAVA_HOME" ] || export JAVA_HOME=$(readlink -f /usr/bin/java | sed 
's:/bin/java::')
```




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76320192
  
--- Diff: debian/rules ---
@@ -35,13 +37,20 @@ override_dh_auto_install:
# cloudstack-agent
mkdir $(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE)/agent
mkdir $(DESTDIR)/$(SYSCONFDIR)/profile.d
-   mkdir $(DESTDIR)/var/log/$(PACKAGE)/agent
mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent
mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent/plugins
install -D agent/target/cloud-agent-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/$(PACKAGE)-agent.jar
install -D 
plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/hypervisors/kvm/target/dependencies/* 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
-   install -D packaging/debian/init/cloud-agent 
$(DESTDIR)/$(SYSCONFDIR)/init.d/$(PACKAGE)-agent
+
+   install -m0755 packaging/debian/$(PACKAGE)-agent.init 
$(DESTDIR)/$(SYSCONFDIR)/init.d/$(PACKAGE)-agent
+   install -d -m0755 debian/$(PACKAGE)-agent/lib/systemd/system
+   # Fix libvirt service name for Debian/Ubuntu
+   sed -i 's/Requires=libvirtd.service/Requires=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
+   sed -i 's/After=libvirtd.service/After=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
+   install -m0644 packaging/systemd/$(PACKAGE)-agent.service 
debian/$(PACKAGE)-agent/lib/systemd/system/$(PACKAGE)-agent.service
+   install -m0644 packaging/systemd/$(PACKAGE)-agent.default 
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
--- End diff --

OK, the symlink comes with default-jre-headless package. If you don't have 
it, you don't have the symlink.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1642: System VMs on Managed Storage

2016-08-25 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
I have been performing additional tests manually on this PR and noticed one 
issue that I want to investigate:

When I put the managed primary storage that the system VMs are running on 
into maintenance mode, the three system VMs were moved to my NFS primary 
storage (so far, so good).

However, the SRs and SAN volumes that stored the root disks of each of 
these system VMs were not cleaned up (I had to do so manually).

Also, when I tried to delete the managed primary storage later, it said 
there were associated volumes, so I had to force delete the primary storage.

I want to investigate why those resources weren't cleaned up automatically.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-25 Thread Rohit Yadav
Hi Martin,


Thanks for sharing. Alright, I'm not sure what's causing issue but based on the 
logs seems like only KVM agents are having issues while connecting to mgmt 
server as I don't see any Nio related exceptions in the management server logs.


I could not see the cloudstack-agent version in the logs, I'm assuming that 
they were all upgraded to 4.9.0, and there are no conflicting jars at 
/usr/share/cloudstack-agent/lib.


First, can you make sure mgmt server has enough ulimit. I found that 
Ubuntu/Debian's init.d script don't override this while CentOS initd/systemd 
script sets ulimit. On your mgmt server, edit /etc/init.d/cloudstack-management 
and add ulimit -n 10240 just before the mgmt server is started in the 'state' 
section (for me it was at around line #147 where it logs a message that it's 
starting the cloudstack-management server).


Next, if this still does not solve the issue -- I created a special 
cloud-utils.jar for you that you need to place on your mgmt server and on the 
KVM agents and restart the mgmt server. This will increase verbosity of the 
error while reduce the Nio polling loop timeout (from 100ms to 10ms). On KVM 
agents, the error from the logs is that during SSL handshake inbound 
connection/stream gets closed, and we want to know the exception message. 
Please get the jar from here:

https://github.com/rhtyd/cloudstack/releases/tag/4.9.0-nioinbound and place 
them at:

/usr/share/cloudstack-agent/lib/ (on kvm host)

/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/ (on mgmt server 
host)


Let me know what worked for you, and if it still failed can you share the mgmt 
server and agent logs once again. Thanks.


Regards.


From: martin kolly 
Sent: 25 August 2016 20:50:08
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601

Hi Rohit

We are running java version 1.7.0.111 on KVM and management server.
mgmt# java -version
java version "1.7.0_111"
kvm# java -version
java version "1.7.0_111"

We get the same error message. Attached are the logs with TRACE enabled.

"success consists of going from failure to failure without loss of enthusiasm."

regards
martin

On 08/25/2016 02:02 PM, Rohit Yadav wrote:

Hi Martin,


Thanks for sharing, on the surface there does not seem to be any issue in 
configuration causing the failures. I'm personally running KVM and Ubuntu hosts 
based env without issues, I'm on Ubuntu 14.04.4 (Linux bluebox 
3.16.0-45-generic #60~14.04.1-Ubuntu) and java 1.7.0_79. Can you try upgrading 
your JRE7 to latest (openjdk-7-jre, 7u111-2.6.7-0ubuntu0.14.04.3) on all mgmt 
server and kvm hosts?


If upgrading your JRE does not help, can you increase the logging verbosity for 
both the agent and management server (in /etc/cloudstack/{agent, management} 
there would be a log4j file, edit that and replace DEBUG/INFO with TRACE for 
class/keys com.cloud and org.apache.cloudstack) and re-share logs when the 
failures occur? I want to see what additional information we can get from logs 
when it tries to connect to host 10.100.12.10 on port: 8250.


Regards.


From: martin kolly 
Sent: 25 August 2016 17:11:06
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


@Simon: We have one management server with local DB. KVMs connect
directly to the management server without any security/loadbalancing
device.

Thanks
Martin

On 08/25/2016 12:41 PM, Simon Weller wrote:


Martin,

Can you provide more detail about your haproxy setup?
Are you running it on separate servers, or on the management server itself?

- Si

Simon Weller/ENA
(615) 312-6068

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 


-Original Message-
From: martin kolly [martin.ko...@senselan.ch]
Received: Thursday, 25 Aug 2016, 5:04AM
To: Rohit Yadav [rohit.ya...@shapeblue.com]; 
dev@cloudstack.apache.org 
[dev@cloudstack.apache.org]
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


thanks for your reply.

This morning we repeated the upgrade process from 4.8 to 4.9 with the
following repository:
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/.

Unfortunately we run into the same issue:

/2016-08-25 09:49:00,660 INFO  [utils.nio.NioClient] (main:null)
(logid:) Connecting to 10.100.12.10:8250//
//2016-08-25 09:49:00,668 WARN  [utils.nio.Link] (main:null) (logid:)
This SSL engine was forced to close inbound due to end of stream.//
//2016-08-25 09:49:00,668 ERROR [utils.nio.NioClient] (main:null)
(logid:) SSL 

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76284726
  
--- Diff: debian/rules ---
@@ -35,13 +37,20 @@ override_dh_auto_install:
# cloudstack-agent
mkdir $(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE)/agent
mkdir $(DESTDIR)/$(SYSCONFDIR)/profile.d
-   mkdir $(DESTDIR)/var/log/$(PACKAGE)/agent
mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent
mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent/plugins
install -D agent/target/cloud-agent-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/$(PACKAGE)-agent.jar
install -D 
plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/hypervisors/kvm/target/dependencies/* 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
-   install -D packaging/debian/init/cloud-agent 
$(DESTDIR)/$(SYSCONFDIR)/init.d/$(PACKAGE)-agent
+
+   install -m0755 packaging/debian/$(PACKAGE)-agent.init 
$(DESTDIR)/$(SYSCONFDIR)/init.d/$(PACKAGE)-agent
+   install -d -m0755 debian/$(PACKAGE)-agent/lib/systemd/system
+   # Fix libvirt service name for Debian/Ubuntu
+   sed -i 's/Requires=libvirtd.service/Requires=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
+   sed -i 's/After=libvirtd.service/After=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
+   install -m0644 packaging/systemd/$(PACKAGE)-agent.service 
debian/$(PACKAGE)-agent/lib/systemd/system/$(PACKAGE)-agent.service
+   install -m0644 packaging/systemd/$(PACKAGE)-agent.default 
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
--- End diff --

This has one issue if there is no /usr/lib/jvm/default-java installed on 
either Ubuntu 14.04/16.04 using the default repositories. I've reverted using 
the readlink solution now. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@vincentbernat @wido thank you for your suggestion and review, I've pushed 
the final version from my end. Packages works on both CentOS7 and Ubuntu 
12.04/14.04/16.04.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76283738
  
--- Diff: packaging/systemd/cloudstack-usage.default ---
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+JAVA_HOME=/usr/lib/jvm/jre
+if [ ! -f "$JAVA_HOME"/bin/java ] ; then
+JAVA_HOME=$(update-alternatives --display java | grep 'currently 
points to' | sed 's:.*currently points to ::' | sed 's:/bin/java::')
+fi
--- End diff --

@vincentbernat okay I'll revert it back to the readlink solution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76281544
  
--- Diff: debian/rules ---
@@ -35,13 +37,20 @@ override_dh_auto_install:
# cloudstack-agent
mkdir $(DESTDIR)/$(SYSCONFDIR)/$(PACKAGE)/agent
mkdir $(DESTDIR)/$(SYSCONFDIR)/profile.d
-   mkdir $(DESTDIR)/var/log/$(PACKAGE)/agent
mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent
mkdir $(DESTDIR)/usr/share/$(PACKAGE)-agent/plugins
install -D agent/target/cloud-agent-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/$(PACKAGE)-agent.jar
install -D 
plugins/hypervisors/kvm/target/cloud-plugin-hypervisor-kvm-$(VERSION).jar 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
install -D plugins/hypervisors/kvm/target/dependencies/* 
$(DESTDIR)/usr/share/$(PACKAGE)-agent/lib/
-   install -D packaging/debian/init/cloud-agent 
$(DESTDIR)/$(SYSCONFDIR)/init.d/$(PACKAGE)-agent
+
+   install -m0755 packaging/debian/$(PACKAGE)-agent.init 
$(DESTDIR)/$(SYSCONFDIR)/init.d/$(PACKAGE)-agent
+   install -d -m0755 debian/$(PACKAGE)-agent/lib/systemd/system
+   # Fix libvirt service name for Debian/Ubuntu
+   sed -i 's/Requires=libvirtd.service/Requires=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
+   sed -i 's/After=libvirtd.service/After=libvirt-bin.service/g' 
packaging/systemd/$(PACKAGE)-agent.service
+   install -m0644 packaging/systemd/$(PACKAGE)-agent.service 
debian/$(PACKAGE)-agent/lib/systemd/system/$(PACKAGE)-agent.service
+   install -m0644 packaging/systemd/$(PACKAGE)-agent.default 
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
--- End diff --

Here:

```
sed 's+JAVA_HOME=.*+JAVA_HOME=/usr/lib/jvm/default-java+' 
$(DESTDIR)/$(SYSCONFDIR)/default/$(PACKAGE)-agent
```

If people don't want to use the default JRE, they are free to change 
`/etc/default/cloudstack-agent`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76281415
  
--- Diff: packaging/systemd/cloudstack-usage.default ---
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+JAVA_HOME=/usr/lib/jvm/jre
+if [ ! -f "$JAVA_HOME"/bin/java ] ; then
+JAVA_HOME=$(update-alternatives --display java | grep 'currently 
points to' | sed 's:.*currently points to ::' | sed 's:/bin/java::')
+fi
--- End diff --

How is that supposed to work with systemd? Moreover, the `readlink -f` 
solution was far more robust than parsing `update-alternatives` output. Let me 
propose something simpler inside `debian/rules` instead.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-25 Thread kiwiflyer
Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
 I took a look at the code last night and it seems that we're no longer 
specifying the source format when calling qemu-img convert. We're relying on 
qemu-img's auto detection of source format and just specifying the output 
format.

See here:

https://github.com/apache/cloudstack/blob/de173bd8921ef926ace405796b4037902ce1979e/plugins/hypervisors/kvm/src/org/apache/cloudstack/utils/qemu/QemuImg.java#L226


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...

2016-08-25 Thread kiwiflyer
Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1644
  
Pure RBD based revert is not supported today (plus it's really slow). The 
way we do it is we snap to volume (clone), shut the vm down, then detach the 
old disk and reattach the new disk to the vm. We submitted a patch a few months 
back to allow for a root volume to be detached and reattached by specifying the 
number of the volume as 0 - https://github.com/apache/cloudstack/pull/1500.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-25 Thread martin kolly
Hi Rohit

We are running java version 1.7.0.111 on KVM and management server.
mgmt# java -version
java version "1.7.0_111"
kvm# java -version
java version "1.7.0_111"

We get the same error message. Attached are the logs with TRACE enabled.

"success consists of going from failure to failure without loss of
enthusiasm."

regards
martin

On 08/25/2016 02:02 PM, Rohit Yadav wrote:
> Hi Martin,
>
>
> Thanks for sharing, on the surface there does not seem to be any issue in 
> configuration causing the failures. I'm personally running KVM and Ubuntu 
> hosts based env without issues, I'm on Ubuntu 14.04.4 (Linux bluebox 
> 3.16.0-45-generic #60~14.04.1-Ubuntu) and java 1.7.0_79. Can you try 
> upgrading your JRE7 to latest (openjdk-7-jre, 7u111-2.6.7-0ubuntu0.14.04.3) 
> on all mgmt server and kvm hosts?
>
>
> If upgrading your JRE does not help, can you increase the logging verbosity 
> for both the agent and management server (in /etc/cloudstack/{agent, 
> management} there would be a log4j file, edit that and replace DEBUG/INFO 
> with TRACE for class/keys com.cloud and org.apache.cloudstack) and re-share 
> logs when the failures occur? I want to see what additional information we 
> can get from logs when it tries to connect to host 10.100.12.10 on port: 8250.
>
>
> Regards.
>
> 
> From: martin kolly 
> Sent: 25 August 2016 17:11:06
> To: dev@cloudstack.apache.org
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
>
> @Simon: We have one management server with local DB. KVMs connect
> directly to the management server without any security/loadbalancing
> device.
>
> Thanks
> Martin
>
> On 08/25/2016 12:41 PM, Simon Weller wrote:
>> Martin,
>>
>> Can you provide more detail about your haproxy setup?
>> Are you running it on separate servers, or on the management server itself?
>>
>> - Si
>>
>> Simon Weller/ENA
>> (615) 312-6068
>>
>> -Original Message-
>> From: martin kolly [martin.ko...@senselan.ch]
>> Received: Thursday, 25 Aug 2016, 5:04AM
>> To: Rohit Yadav [rohit.ya...@shapeblue.com]; dev@cloudstack.apache.org 
>> [dev@cloudstack.apache.org]
>> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>>
>>
>> thanks for your reply.
>>
>> This morning we repeated the upgrade process from 4.8 to 4.9 with the
>> following repository:
>> http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/.
>> 
>> Unfortunately we run into the same issue:
>>
>> /2016-08-25 09:49:00,660 INFO  [utils.nio.NioClient] (main:null)
>> (logid:) Connecting to 10.100.12.10:8250//
>> //2016-08-25 09:49:00,668 WARN  [utils.nio.Link] (main:null) (logid:)
>> This SSL engine was forced to close inbound due to end of stream.//
>> //2016-08-25 09:49:00,668 ERROR [utils.nio.NioClient] (main:null)
>> (logid:) SSL Handshake failed while connecting to host: 10.100.12.10
>> port: 8250//
>> //2016-08-25 09:49:00,668 ERROR [utils.nio.NioConnection] (main:null)
>> (logid:) Unable to initialize the threads.//
>> //java.io.IOException: SSL Handshake failed while connecting to host:
>> 10.100.12.10 port: 8250//
>> //at com.cloud.utils.nio.NioClient.init(NioClient.java:67)//
>> //at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)//
>> //at com.cloud.agent.Agent.start(Agent.java:237)//
>> //at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)//
>> //at
>> com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)//
>> //at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)//
>> //at com.cloud.agent.AgentShell.start(AgentShell.java:456)//
>> //at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)//
>> //at
>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)//
>> //at
>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)//
>> //at java.lang.reflect.Method.invoke(Method.java:606)//
>> //at
>> org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)//
>> //2016-08-25 09:49:00,669 INFO  [utils.exception.CSExceptionErrorCode]
>> (main:null) (logid:) Could not find exception:
>> com.cloud.utils.exception.NioConnectionException in error code list for
>> exceptions//
>> //2016-08-25 09:49:00,669 WARN  [cloud.agent.Agent] (main:null) (logid:)
>> NIO Connection Exception
>> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
>> while connecting to host: 10.100.12.10 port: 8250//
>> //2016-08-25 09:49:00,670 INFO  [cloud.agent.Agent] (main:null) (logid:)
>> Attempted to connect to the server, but received an unexpected
>> exception, trying again.../
>>
>> *KVM Hosts:
>> */# java -version
>> java version "1.7.0_95"
>> OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.14.04.1)
>> OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)
>>
>> # dpkg --get-selections | grep -e 'jdk' -e 'java'
>> ca-certificates-java  

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Update: postinstall code has been removed now @wido @vincentbernat 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-25 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell the smoke test completed successfully
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk | 
Status : SUCCESS ===
ok

--
Ran 1 test in 1961.555s

OK

I'm going to have to rerun the component tests because it looks like it 
picked a Windows based template, and all of the operations where it required 
being able to ssh in failed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-25 Thread nathanejohnson
Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@wido I don't know that the management server knows explicitly, it doesn't 
actually seem to store the disk image format in the snapshot related tables at 
all, only in volumes as far as I can tell.  However, I don't believe the 
management server ever does anything with the snapshot backup on secondary 
other than deleting it whenever the corresponding snapshot is deleted, and for 
that it doesn't actually care what format it's in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-25 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
Done, thanks @rafaelweingartner! I'll start working on adding Marvin tests 
for this PR as @jburwell suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Packaging tests confirmed, PR is OK. Debian packages tested on Ubuntu 
12.04/14.04/16.04, rpms tests on CentOS 7.2. Both usage, agent came up on 
installation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-25 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
@nvazquez great.
What about squashing the commits now?

LGTM for the code, giving my reviews.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-25 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1605
  
Thanks @rafaelweingartner! I pushed new changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido @vincentbernat  I could not get rid of the postinst step as shell is 
not executed when I move the code in the EnvironmentFile itself. I've reduced 
its impact to only run when the default /etc/default/cloudstack-{usage, agent} 
are installed.

Since we're re-using the common systemd files, the JAVA_HOME declared in 
the files are set to the default we see on CentOS and only in that case the 
postinst step will replace it with the system default. On future upgrades, the 
postinst code won't run. Sorry, but this hack was needed.

Please see one last time, if we're in agreement as soon as my packaging 
testing succeed I'll merge this. /cc @jburwell @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...

2016-08-25 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1644
  
Seems logical to me. But we can't revert a RBD snapshot yet, can we?

Sorry, it's getting a bit rusty for me as I haven't looked at that code for 
a while.

Still, sane feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Thanks @wido I'll see if I can fix the issue without including the changes 
in postinst files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #:

2016-08-25 Thread wido
Github user wido commented on the pull request:


https://github.com/apache/cloudstack/commit/fa3fe7bb05fcf26d8fedb9f5ad6d902281504922#commitcomment-18774932
  
Yes, that looks much better.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
LGTM for me right now.

One side note, I hate changes being made in postinst files. But I wouldn't 
know a different route though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-08-25 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@kiwiflyer So does the mgmt server know the snapshot is now in QCOW2? Or 
does it still think it's RAW?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-25 Thread Rohit Yadav
Hi Martin,


Thanks for sharing, on the surface there does not seem to be any issue in 
configuration causing the failures. I'm personally running KVM and Ubuntu hosts 
based env without issues, I'm on Ubuntu 14.04.4 (Linux bluebox 
3.16.0-45-generic #60~14.04.1-Ubuntu) and java 1.7.0_79. Can you try upgrading 
your JRE7 to latest (openjdk-7-jre, 7u111-2.6.7-0ubuntu0.14.04.3) on all mgmt 
server and kvm hosts?


If upgrading your JRE does not help, can you increase the logging verbosity for 
both the agent and management server (in /etc/cloudstack/{agent, management} 
there would be a log4j file, edit that and replace DEBUG/INFO with TRACE for 
class/keys com.cloud and org.apache.cloudstack) and re-share logs when the 
failures occur? I want to see what additional information we can get from logs 
when it tries to connect to host 10.100.12.10 on port: 8250.


Regards.


From: martin kolly 
Sent: 25 August 2016 17:11:06
To: dev@cloudstack.apache.org
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


@Simon: We have one management server with local DB. KVMs connect
directly to the management server without any security/loadbalancing
device.

Thanks
Martin

On 08/25/2016 12:41 PM, Simon Weller wrote:
> Martin,
>
> Can you provide more detail about your haproxy setup?
> Are you running it on separate servers, or on the management server itself?
>
> - Si
>
> Simon Weller/ENA
> (615) 312-6068
>
> -Original Message-
> From: martin kolly [martin.ko...@senselan.ch]
> Received: Thursday, 25 Aug 2016, 5:04AM
> To: Rohit Yadav [rohit.ya...@shapeblue.com]; dev@cloudstack.apache.org 
> [dev@cloudstack.apache.org]
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
>
> thanks for your reply.
>
> This morning we repeated the upgrade process from 4.8 to 4.9 with the
> following repository:
> http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/.
> 
> Unfortunately we run into the same issue:
>
> /2016-08-25 09:49:00,660 INFO  [utils.nio.NioClient] (main:null)
> (logid:) Connecting to 10.100.12.10:8250//
> //2016-08-25 09:49:00,668 WARN  [utils.nio.Link] (main:null) (logid:)
> This SSL engine was forced to close inbound due to end of stream.//
> //2016-08-25 09:49:00,668 ERROR [utils.nio.NioClient] (main:null)
> (logid:) SSL Handshake failed while connecting to host: 10.100.12.10
> port: 8250//
> //2016-08-25 09:49:00,668 ERROR [utils.nio.NioConnection] (main:null)
> (logid:) Unable to initialize the threads.//
> //java.io.IOException: SSL Handshake failed while connecting to host:
> 10.100.12.10 port: 8250//
> //at com.cloud.utils.nio.NioClient.init(NioClient.java:67)//
> //at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)//
> //at com.cloud.agent.Agent.start(Agent.java:237)//
> //at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)//
> //at
> com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)//
> //at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)//
> //at com.cloud.agent.AgentShell.start(AgentShell.java:456)//
> //at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)//
> //at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)//
> //at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)//
> //at java.lang.reflect.Method.invoke(Method.java:606)//
> //at
> org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)//
> //2016-08-25 09:49:00,669 INFO  [utils.exception.CSExceptionErrorCode]
> (main:null) (logid:) Could not find exception:
> com.cloud.utils.exception.NioConnectionException in error code list for
> exceptions//
> //2016-08-25 09:49:00,669 WARN  [cloud.agent.Agent] (main:null) (logid:)
> NIO Connection Exception
> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
> while connecting to host: 10.100.12.10 port: 8250//
> //2016-08-25 09:49:00,670 INFO  [cloud.agent.Agent] (main:null) (logid:)
> Attempted to connect to the server, but received an unexpected
> exception, trying again.../
>
> *KVM Hosts:
> */# java -version
> java version "1.7.0_95"
> OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.14.04.1)
> OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)
>
> # dpkg --get-selections | grep -e 'jdk' -e 'java'
> ca-certificates-javainstall
> java-commoninstall
> libcommons-daemon-javainstall
> openjdk-7-jre-headless:amd64install
> tzdata-javainstall
>
> # apt-cache policy cloudstack-agent
> cloudstack-agent:
>   Installed: 4.9.0
>   Candidate: 4.9.0
>   Version table:
>  *** 4.9.0 0
> 500
> http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages
> 100 /var/lib/dpkg/status
>
> # find /usr/share/ -name "cloud-utils*.jar"
> 

Re: Virtio vs IDE emulation, per OS - where is this info ?

2016-08-25 Thread Andrija Panic
Hi Simon,

thanks a lot for this info - but I'm not sure if this is complete list ?

For example: "Windows PV" is present in DB etc, but it's not here in the
code you sent (Windows PV = virtio hardware, other Windows X =
ide/intel)

Do I miss something - I tried to crosscheck DB and code, and definitely I'm
missing something (hope this is not regresion from previous releases -
we are running 4.5 release...)

Thanks again !

Andrija

On 24 August 2016 at 16:46, Simon Weller  wrote:

> Andrija,
>
>
> It's actually hard coded and based on the template namethis really
> needs to be reworked.
>
>
> https://github.com/apache/cloudstack/blob/3a81a4498f6b56eb7330bc992f0c89
> f6cba86cb3/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/
> LibvirtComputingResource.java#L2885
>
>
> - Si
>
>
>
>
> 
> From: Andrija Panic 
> Sent: Wednesday, August 24, 2016 9:39 AM
> To: dev@cloudstack.apache.org
> Subject: Virtio vs IDE emulation, per OS - where is this info ?
>
> Hi all,
>
> Im trying to build the simple table for our support guys, which OS type (as
> seen in ACS) is virtio emualted, and which is IDE/Intel emulation.
>
> I dont seem to find this in DB, except the list of OS types, families etc.
>
> Can someone give some info, where should I find if OS is supposed to be
> virtio or ide/intel/emulated ?
>
> Thanks,
>
> --
>
> Andrija Panic
>
> --
>
> Andrija Panic
>



-- 

Andrija Panić


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76227828
  
--- Diff: debian/cloudstack-agent.postinst ---
@@ -41,6 +41,12 @@ case "$1" in
 mkdir /etc/libvirt/hooks
 fi
 cp -a /usr/share/cloudstack-agent/lib/libvirtqemuhook 
/etc/libvirt/hooks/qemu
+
+# Update JAVA_HOME in /etc/default/cloudstack-agent to default JRE
+JAVA_HOME=$(readlink -f /usr/bin/java | sed 's/\/jre.*java//g')
+if [ -d "$JAVA_HOME" ]; then
+sed -i "s:^JAVA_HOME=.*:JAVA_HOME=${JAVA_HOME}:" 
/etc/default/cloudstack-agent
+fi
--- End diff --

@vincentbernat  thanks, it makes sense. I'll see if we can move this to the 
`default/files`. An alternative is to document this, we can keep some default 
path and in our installation/upgrade documentation suggest the admin to fix the 
JAVA_HOME here if it's something non-default. The code I've used here simply 
replaces JAVA_HOME to whatever is set globally on that host.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76227609
  
--- Diff: packaging/centos7/cloud.spec ---
@@ -482,7 +488,7 @@ pip install --upgrade 
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/work
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/temp
 %dir %attr(0770,root,cloud) %{_localstatedir}/log/%{name}/management
-%config(noreplace) %{_sysconfdir}/sysconfig/%{name}-management
--- End diff --

Cool, I see several packages hosting default config (such as what we've 
here) at `/etc/default` so I'll keep 'em in `/etc/default` to make things 
consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-25 Thread martin kolly

@Simon: We have one management server with local DB. KVMs connect
directly to the management server without any security/loadbalancing
device.

Thanks
Martin

On 08/25/2016 12:41 PM, Simon Weller wrote:
> Martin,
>
> Can you provide more detail about your haproxy setup?
> Are you running it on separate servers, or on the management server itself?
>
> - Si
>
> Simon Weller/ENA
> (615) 312-6068
>
> -Original Message-
> From: martin kolly [martin.ko...@senselan.ch]
> Received: Thursday, 25 Aug 2016, 5:04AM
> To: Rohit Yadav [rohit.ya...@shapeblue.com]; dev@cloudstack.apache.org 
> [dev@cloudstack.apache.org]
> Subject: Re: CS 4.9 NIO Selector wait time PR-1601
>
>
> thanks for your reply.
>
> This morning we repeated the upgrade process from 4.8 to 4.9 with the
> following repository:
> http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/.
> 
> Unfortunately we run into the same issue:
>
> /2016-08-25 09:49:00,660 INFO  [utils.nio.NioClient] (main:null)
> (logid:) Connecting to 10.100.12.10:8250//
> //2016-08-25 09:49:00,668 WARN  [utils.nio.Link] (main:null) (logid:)
> This SSL engine was forced to close inbound due to end of stream.//
> //2016-08-25 09:49:00,668 ERROR [utils.nio.NioClient] (main:null)
> (logid:) SSL Handshake failed while connecting to host: 10.100.12.10
> port: 8250//
> //2016-08-25 09:49:00,668 ERROR [utils.nio.NioConnection] (main:null)
> (logid:) Unable to initialize the threads.//
> //java.io.IOException: SSL Handshake failed while connecting to host:
> 10.100.12.10 port: 8250//
> //at com.cloud.utils.nio.NioClient.init(NioClient.java:67)//
> //at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)//
> //at com.cloud.agent.Agent.start(Agent.java:237)//
> //at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)//
> //at
> com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)//
> //at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)//
> //at com.cloud.agent.AgentShell.start(AgentShell.java:456)//
> //at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)//
> //at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)//
> //at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)//
> //at java.lang.reflect.Method.invoke(Method.java:606)//
> //at
> org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)//
> //2016-08-25 09:49:00,669 INFO  [utils.exception.CSExceptionErrorCode]
> (main:null) (logid:) Could not find exception:
> com.cloud.utils.exception.NioConnectionException in error code list for
> exceptions//
> //2016-08-25 09:49:00,669 WARN  [cloud.agent.Agent] (main:null) (logid:)
> NIO Connection Exception
> com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
> while connecting to host: 10.100.12.10 port: 8250//
> //2016-08-25 09:49:00,670 INFO  [cloud.agent.Agent] (main:null) (logid:)
> Attempted to connect to the server, but received an unexpected
> exception, trying again.../
>
> *KVM Hosts:
> */# java -version
> java version "1.7.0_95"
> OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.14.04.1)
> OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)
>
> # dpkg --get-selections | grep -e 'jdk' -e 'java'
> ca-certificates-javainstall
> java-commoninstall
> libcommons-daemon-javainstall
> openjdk-7-jre-headless:amd64install
> tzdata-javainstall
>
> # apt-cache policy cloudstack-agent
> cloudstack-agent:
>   Installed: 4.9.0
>   Candidate: 4.9.0
>   Version table:
>  *** 4.9.0 0
> 500
> http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages
> 100 /var/lib/dpkg/status
>
> # find /usr/share/ -name "cloud-utils*.jar"
> /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
> # md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
> a8de7306d7c80b5a73e93b83afdd119f
> /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
>
>
> /*Management Server:
> */# java -version//
> //java version "1.7.0_95"//
> //OpenJDK Runtime Environment (IcedTea 2.6.4)
> (7u95-2.6.4-0ubuntu0.14.04.1)//
> //OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)//
> //
> //# dpkg --get-selections | grep -e 'jdk' -e 'java'//
> //ca-certificates-javainstall//
> //java-commoninstall//
> //libcommons-collections3-javainstall//
> //libcommons-daemon-javainstall//
> //libcommons-dbcp-javainstall//
> //libcommons-pool-javainstall//
> //libecj-javainstall//
> //libgeronimo-jta-1.1-spec-javainstall//
> //libmysql-javainstall//
> //libservlet2.5-javainstall//
> //libtomcat6-javainstall//
> //openjdk-7-jre-headless:amd64  

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76226635
  
--- Diff: packaging/centos7/cloud.spec ---
@@ -482,7 +488,7 @@ pip install --upgrade 
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/work
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/temp
 %dir %attr(0770,root,cloud) %{_localstatedir}/log/%{name}/management
-%config(noreplace) %{_sysconfdir}/sysconfig/%{name}-management
--- End diff --

I am a Debian guy, so I can't give you an authoritative answer. I didn't 
know that `/etc/default` already existed on CentOS too. I suppose that's up to 
you. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76226387
  
--- Diff: packaging/centos7/cloud.spec ---
@@ -482,7 +488,7 @@ pip install --upgrade 
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/work
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/temp
 %dir %attr(0770,root,cloud) %{_localstatedir}/log/%{name}/management
-%config(noreplace) %{_sysconfdir}/sysconfig/%{name}-management
--- End diff --

@vincentbernat thanks, I was not sure but found that /etc/default exists 
and is used by several packages on CentOS and it would keep paths uniform 
across distributions. Should I revert back to sysconfig for CentOS packages 
then?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76226318
  
--- Diff: debian/cloudstack-agent.postinst ---
@@ -41,6 +41,12 @@ case "$1" in
 mkdir /etc/libvirt/hooks
 fi
 cp -a /usr/share/cloudstack-agent/lib/libvirtqemuhook 
/etc/libvirt/hooks/qemu
+
+# Update JAVA_HOME in /etc/default/cloudstack-agent to default JRE
+JAVA_HOME=$(readlink -f /usr/bin/java | sed 's/\/jre.*java//g')
+if [ -d "$JAVA_HOME" ]; then
+sed -i "s:^JAVA_HOME=.*:JAVA_HOME=${JAVA_HOME}:" 
/etc/default/cloudstack-agent
+fi
--- End diff --

This would overwrite a change made by a user during upgrades. I would 
suggest to move the first line directly in /etc/default/cloudstack-agent (if 
it's compatible with RHEL). A user that didn't change anything will get the new 
file and it will work as expected. A user that did alter the file will get a 
prompt to solve the situation.

However, this won't work with systemd without further ugly hacks.

On my system, I notice that `/usr/lib/jvm/default-java` is a symlink. It 
also seems to be the case on Precise. Maybe you could patch 
`/etc/default/cloudstack-agent` after installing it in `debian/rules`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76225900
  
--- Diff: packaging/centos7/cloud.spec ---
@@ -482,7 +488,7 @@ pip install --upgrade 
/usr/share/cloudstack-marvin/Marvin-*.tar.gz
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/work
 %dir %attr(0770,root,cloud) %{_localstatedir}/cache/%{name}/management/temp
 %dir %attr(0770,root,cloud) %{_localstatedir}/log/%{name}/management
-%config(noreplace) %{_sysconfdir}/sysconfig/%{name}-management
--- End diff --

RHEL users won't expect this file to be in /etc/default. In the systemd 
unit:

```
EnvironmentFile=-/etc/default/cloudstack-agent
EnvironmentFile=-/etc/sysconfig/cloudstack-agent
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1662: Fix bug juniper srx

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1662
  
@digitalgust please squash the changes, the changes look like bugfixes so 
please edit the PR and change the base branch to 4.9 branch, and please open a 
ticket on JIRA and edit the commit message to include the JIRA ID. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


RE: CS 4.9 NIO Selector wait time PR-1601

2016-08-25 Thread Simon Weller
Martin,

Can you provide more detail about your haproxy setup?
Are you running it on separate servers, or on the management server itself?

- Si

Simon Weller/ENA
(615) 312-6068

-Original Message-
From: martin kolly [martin.ko...@senselan.ch]
Received: Thursday, 25 Aug 2016, 5:04AM
To: Rohit Yadav [rohit.ya...@shapeblue.com]; dev@cloudstack.apache.org 
[dev@cloudstack.apache.org]
Subject: Re: CS 4.9 NIO Selector wait time PR-1601


thanks for your reply.

This morning we repeated the upgrade process from 4.8 to 4.9 with the
following repository:
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/.

Unfortunately we run into the same issue:

/2016-08-25 09:49:00,660 INFO  [utils.nio.NioClient] (main:null)
(logid:) Connecting to 10.100.12.10:8250//
//2016-08-25 09:49:00,668 WARN  [utils.nio.Link] (main:null) (logid:)
This SSL engine was forced to close inbound due to end of stream.//
//2016-08-25 09:49:00,668 ERROR [utils.nio.NioClient] (main:null)
(logid:) SSL Handshake failed while connecting to host: 10.100.12.10
port: 8250//
//2016-08-25 09:49:00,668 ERROR [utils.nio.NioConnection] (main:null)
(logid:) Unable to initialize the threads.//
//java.io.IOException: SSL Handshake failed while connecting to host:
10.100.12.10 port: 8250//
//at com.cloud.utils.nio.NioClient.init(NioClient.java:67)//
//at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)//
//at com.cloud.agent.Agent.start(Agent.java:237)//
//at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)//
//at
com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)//
//at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)//
//at com.cloud.agent.AgentShell.start(AgentShell.java:456)//
//at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)//
//at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)//
//at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)//
//at java.lang.reflect.Method.invoke(Method.java:606)//
//at
org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)//
//2016-08-25 09:49:00,669 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions//
//2016-08-25 09:49:00,669 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250//
//2016-08-25 09:49:00,670 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again.../

*KVM Hosts:
*/# java -version
java version "1.7.0_95"
OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.14.04.1)
OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)

# dpkg --get-selections | grep -e 'jdk' -e 'java'
ca-certificates-javainstall
java-commoninstall
libcommons-daemon-javainstall
openjdk-7-jre-headless:amd64install
tzdata-javainstall

# apt-cache policy cloudstack-agent
cloudstack-agent:
  Installed: 4.9.0
  Candidate: 4.9.0
  Version table:
 *** 4.9.0 0
500
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages
100 /var/lib/dpkg/status

# find /usr/share/ -name "cloud-utils*.jar"
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
# md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
a8de7306d7c80b5a73e93b83afdd119f
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar


/*Management Server:
*/# java -version//
//java version "1.7.0_95"//
//OpenJDK Runtime Environment (IcedTea 2.6.4)
(7u95-2.6.4-0ubuntu0.14.04.1)//
//OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)//
//
//# dpkg --get-selections | grep -e 'jdk' -e 'java'//
//ca-certificates-javainstall//
//java-commoninstall//
//libcommons-collections3-javainstall//
//libcommons-daemon-javainstall//
//libcommons-dbcp-javainstall//
//libcommons-pool-javainstall//
//libecj-javainstall//
//libgeronimo-jta-1.1-spec-javainstall//
//libmysql-javainstall//
//libservlet2.5-javainstall//
//libtomcat6-javainstall//
//openjdk-7-jre-headless:amd64install//
//tzdata-javainstall//
//
//# apt-cache policy cloudstack-management//
//cloudstack-management://
//  Installed: 4.9.0//
//  Candidate: 4.9.0//
//  Version table://
// *** 4.9.0 0//
//500
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages//
//100 /var/lib/dpkg/status///

/# find /usr/share/ -name "cloud-utils*.jar"//

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
@wido @vincentbernat I've incorporate all the changes now, including 
refactoring of systemd file and now we've both centos and ubuntu/debian 
packaging consuming from the the same service/default systemd files. I tried to 
see if we can include support for cloudstack-management and systemd but that's 
challenging and different. Please review and let's merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: CS 4.9 NIO Selector wait time PR-1601

2016-08-25 Thread martin kolly

thanks for your reply.

This morning we repeated the upgrade process from 4.8 to 4.9 with the
following repository:
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/.

Unfortunately we run into the same issue:

/2016-08-25 09:49:00,660 INFO  [utils.nio.NioClient] (main:null)
(logid:) Connecting to 10.100.12.10:8250//
//2016-08-25 09:49:00,668 WARN  [utils.nio.Link] (main:null) (logid:)
This SSL engine was forced to close inbound due to end of stream.//
//2016-08-25 09:49:00,668 ERROR [utils.nio.NioClient] (main:null)
(logid:) SSL Handshake failed while connecting to host: 10.100.12.10
port: 8250//
//2016-08-25 09:49:00,668 ERROR [utils.nio.NioConnection] (main:null)
(logid:) Unable to initialize the threads.//
//java.io.IOException: SSL Handshake failed while connecting to host:
10.100.12.10 port: 8250//
//at com.cloud.utils.nio.NioClient.init(NioClient.java:67)//
//at com.cloud.utils.nio.NioConnection.start(NioConnection.java:88)//
//at com.cloud.agent.Agent.start(Agent.java:237)//
//at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:399)//
//at
com.cloud.agent.AgentShell.launchAgentFromClassInfo(AgentShell.java:367)//
//at com.cloud.agent.AgentShell.launchAgent(AgentShell.java:351)//
//at com.cloud.agent.AgentShell.start(AgentShell.java:456)//
//at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)//
//at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)//
//at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)//
//at java.lang.reflect.Method.invoke(Method.java:606)//
//at
org.apache.commons.daemon.support.DaemonLoader.start(DaemonLoader.java:243)//
//2016-08-25 09:49:00,669 INFO  [utils.exception.CSExceptionErrorCode]
(main:null) (logid:) Could not find exception:
com.cloud.utils.exception.NioConnectionException in error code list for
exceptions//
//2016-08-25 09:49:00,669 WARN  [cloud.agent.Agent] (main:null) (logid:)
NIO Connection Exception 
com.cloud.utils.exception.NioConnectionException: SSL Handshake failed
while connecting to host: 10.100.12.10 port: 8250//
//2016-08-25 09:49:00,670 INFO  [cloud.agent.Agent] (main:null) (logid:)
Attempted to connect to the server, but received an unexpected
exception, trying again.../

*KVM Hosts:
*/# java -version
java version "1.7.0_95"
OpenJDK Runtime Environment (IcedTea 2.6.4) (7u95-2.6.4-0ubuntu0.14.04.1)
OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)

# dpkg --get-selections | grep -e 'jdk' -e 'java'
ca-certificates-javainstall
java-commoninstall
libcommons-daemon-javainstall
openjdk-7-jre-headless:amd64install
tzdata-javainstall

# apt-cache policy cloudstack-agent
cloudstack-agent:
  Installed: 4.9.0
  Candidate: 4.9.0
  Version table:
 *** 4.9.0 0
500
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages
100 /var/lib/dpkg/status

# find /usr/share/ -name "cloud-utils*.jar"
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
# md5sum /usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar
a8de7306d7c80b5a73e93b83afdd119f 
/usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar


/*Management Server:
*/# java -version//
//java version "1.7.0_95"//
//OpenJDK Runtime Environment (IcedTea 2.6.4)
(7u95-2.6.4-0ubuntu0.14.04.1)//
//OpenJDK 64-Bit Server VM (build 24.95-b01, mixed mode)//
//
//# dpkg --get-selections | grep -e 'jdk' -e 'java'//
//ca-certificates-javainstall//
//java-commoninstall//
//libcommons-collections3-javainstall//
//libcommons-daemon-javainstall//
//libcommons-dbcp-javainstall//
//libcommons-pool-javainstall//
//libecj-javainstall//
//libgeronimo-jta-1.1-spec-javainstall//
//libmysql-javainstall//
//libservlet2.5-javainstall//
//libtomcat6-javainstall//
//openjdk-7-jre-headless:amd64install//
//tzdata-javainstall//
//
//# apt-cache policy cloudstack-management//
//cloudstack-management://
//  Installed: 4.9.0//
//  Candidate: 4.9.0//
//  Version table://
// *** 4.9.0 0//
//500
http://packages.shapeblue.com/cloudstack/upstream/debian/4.9/ ./ Packages//
//100 /var/lib/dpkg/status///

/# find /usr/share/ -name "cloud-utils*.jar"//
///usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar//
///usr/share/cloudstack-agent/lib/cloud-utils-4.9.0.jar//
///usr/share/cloudstack-usage/lib/cloud-utils-4.9.0.jar//
//# md5sum
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar//
//a8de7306d7c80b5a73e93b83afdd119f 
/usr/share/cloudstack-management/webapps/client/WEB-INF/lib/cloud-utils-4.9.0.jar//
//# md5sum 

[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76206826
  
--- Diff: debian/rules ---
@@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
-ifeq ($(shell lsb_release -sr), 14.04)
-SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
-else
-SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
-endif
-
--- End diff --

Oh, OK, that's why you removed it. OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1654: Updating pom.xml version numbers for release 4.8.2.0...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1654
  
@jburwell I've added an empty upgrade path. Tested the db upgrade locally. 
LGTM.
When you fwd-merge on 4.9 use: `git merge -X ours 4.8` to avoid fixing 
merge conflicts in pom.xm files by hand. Merging 4.9 on master should not then 
cause any conflicts. We'll then also need to add/update db upgrade paths from 
4.8.2 to 4.9.1/4.10.0 db versions (separately)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1647
  
Thanks @vincentbernat I'll update the dependencies, and in the 
post-installation step we can modify the default JAVA_HOME path of the host in 
the default/{cloudstack-usage, cloudstack-agent} files if available.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76202771
  
--- Diff: debian/rules ---
@@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
-ifeq ($(shell lsb_release -sr), 14.04)
-SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
-else
-SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
-endif
-
--- End diff --

@vincentbernat that's right, but if we use that then we'll need to 
build/host/publish two version of the deb repository, depending on whether the 
deb pkgs were built of Ubuntu 14.04 or 16.04+. I think the current is still a 
good compromise, I can add new dependency options to allow users to use oracle 
jre/jdk.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-25 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1660
  
RMs please help review /cc @jburwell @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread vincentbernat
Github user vincentbernat commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76200059
  
--- Diff: debian/rules ---
@@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
-ifeq ($(shell lsb_release -sr), 14.04)
-SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
-else
-SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
-endif
-
--- End diff --

That's why I think that the use of `$SUBSTVARS` and `dh_gencontrol` 
override was a good idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1647: [lts] CLOUDSTACK-9462: Systemd support for Ub...

2016-08-25 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1647#discussion_r76197541
  
--- Diff: debian/rules ---
@@ -5,18 +5,9 @@ PACKAGE = $(shell dh_listpackages|head -n 1|cut -d '-' -f 
1)
 SYSCONFDIR = "/etc"
 DESTDIR = "debian/tmp"
 
-ifeq ($(shell lsb_release -sr), 14.04)
-SUBSTVARS = -Vjre:Depends="openjdk-7-jre-headless" 
-Vjdk:Depends="openjdk-7-jdk" -Vinit:"Depends:jsvc"
-else
-SUBSTVARS = -Vjre:Depends="openjdk-8-jre-headless" 
-Vjdk:Depends="openjdk-8-jdk" -Vinit:"Depends:systemd"
-endif
-
--- End diff --

@vincentbernat won't this force some release of Java8, what if the 
openjdk/oracle java8 pkg is not available on that system, say on 12.04 etc.?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---