[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2017-01-02 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-439


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1819: CLOUDSTACK-9653 The system capacity was not getting ...

2017-01-02 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1819
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1826
  
@rashmidixit can you squash your changes, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1826
  
Thanks @rashmidixit I'll review them soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1832: CLOUDSTACK-9652 Job framework - Cancelling async job...

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1832
  
@karuturi please squash your changes and fix the merge conflict. We've 
merged very large changes that were squash to a single commit, it becomes 
easier to then cherry-pick them or revert them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1871: [4.9] CLOUDSTACK-9692: Fix password server issue in ...

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1871
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1871: [4.9] CLOUDSTACK-9692: Fix password server issue in ...

2017-01-02 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1871
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1864: CLOUDSTACK-9710: Switch to using JDK 1.8

2017-01-02 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1864: CLOUDSTACK-9710: Switch to using JDK 1.8

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC2)

2017-01-02 Thread Rohit Yadav 
+1 (binding)

- Based on upgrade tests, all pass no blockers. Manual upgrade tests from 
4.9.1.0.
- Based on Travis tests (with simulator) and Trillian tests (with xenserver 
6.5, kvm centos6/centos7 and vmware 55u3) on: 
https://github.com/apache/cloudstack/pull/1837 (these test results from RC1 are 
still valid as they are run against freshly installed 
system)
- Based on manual upgrade tests on a local deployment
- Based on testing with new 4.6-compatible systemvmtemplate 
http://packages.shapeblue.com/systemvmtemplate/4.6/new/

Regards.


From: Rohit Yadav 
Sent: 03 January 2017 12:35:23
To: dev@cloudstack.apache.org
Subject: [VOTE] Apache Cloudstack 4.9.2.0 (RC2)

Hi All,

I've created a 4.9.2.0 release (RC2), with the following artifacts up for a
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.2.0-RC20170103T1228
Commit: dfc39c1f088dc9979a53bd0de4dfd0e5b266bd0f

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.9.2.0/

PGP release keys (signed using 0EE3D884):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2017-01-02 Thread blueorangutan 
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1837: [4.9] Smoketest Health

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1837
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[VOTE] Apache Cloudstack 4.9.2.0 (RC2)

2017-01-02 Thread Rohit Yadav 
Hi All,

I've created a 4.9.2.0 release (RC2), with the following artifacts up for a
vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.2.0-RC20170103T1228
Commit: dfc39c1f088dc9979a53bd0de4dfd0e5b266bd0f

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.9.2.0/

PGP release keys (signed using 0EE3D884):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 72 hours.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Regards.

[GitHub] cloudstack pull request #1887: schema: Fix upgrade issue for 4.9.1.0->4.9.2....

2017-01-02 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1887


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC1)

2017-01-02 Thread Rohit Yadav 
All,


An upgrade issue was found, I'm closing this voting round for RC1. I'll start 
another voting round shortly.


Regards.


From: Sergey Levitskiy 
Sent: 03 January 2017 10:47:50
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC1)

@milamber Looks like it is an execution of a wrong upgrade path. The last 
entries before the exception is coming from schema-490to4910.sql which is not 
supposed to run during 4.9.1 to 4.9.2 upgrade.
Did you get the code from 4.9.2.0 RC2 branch?



On 1/2/17, 1:46 PM, "Milamber"  wrote:

Hello,

I try to upgrade from 4.9.1.0 to 4.9.2.0 RC1, and I've this error:

2017-01-02 21:28:28,424 WARN [o.a.c.s.m.c.ResourceApplicationContext]
(main:null) (logid:) Exception encountered during context initialization
- cancelling refresh attempt:
org.springframework.context.ApplicationContextException: Failed to start
bean 'cloudStackLifeCycle'; nested exception is
javax.persistence.EntityExistsException: Entity already exists:
=> no other line in log after this line




The full log below:

2017-01-02 21:28:27,284 INFO  [c.c.u.d.T.Transaction] (main:null)
(logid:) Is Data Base High Availiability enabled? Ans : false
2017-01-02 21:28:27,526 DEBUG [c.c.u.d.DriverLoader] (main:null)
(logid:) Successfully loaded DB driver com.mysql.jdbc.Driver
2017-01-02 21:28:27,544 DEBUG [c.c.u.d.DriverLoader] (main:null)
(logid:) DB driver com.mysql.jdbc.Driver was already loaded.
2017-01-02 21:28:27,545 DEBUG [c.c.u.d.DriverLoader] (main:null)
(logid:) DB driver com.mysql.jdbc.Driver was already loaded.
2017-01-02 21:28:27,892 DEBUG [c.c.u.d.ConnectionConcierge] (main:null)
(logid:) Registering a database connection for LockMaster1
2017-01-02 21:28:27,892 INFO  [c.c.u.d.Merovingian2] (main:null)
(logid:) Cleaning up locks for 2200278139079
2017-01-02 21:28:27,898 INFO  [c.c.u.d.Merovingian2] (main:null)
(logid:) Released 0 locks for 2200278139079
2017-01-02 21:28:27,945 INFO [o.a.c.s.l.CloudStackExtendedLifeCycle]
(main:null) (logid:) Running system integrity checker
com.cloud.upgrade.DatabaseUpgradeChecker@15e9c283
2017-01-02 21:28:27,946 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) Grabbing lock to check for database upgrade.
2017-01-02 21:28:27,991 DEBUG [c.c.u.d.VersionDaoImpl] (main:null)
(logid:) Checking to see if the database is at a version before it was
the version table is created
2017-01-02 21:28:28,024 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) DB version = 4.9.1.0 Code Version = 4.9.2.0
2017-01-02 21:28:28,024 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) Database upgrade must be performed from 4.9.1.0 to 4.9.2.0
2017-01-02 21:28:28,024 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) Running upgrade Upgrade490to4910 to upgrade from 4.9.0-4.9.1.0
to 4.9.1.0
2017-01-02 21:28:28,037 DEBUG [c.c.u.s.Script] (main:null) (logid:)
Looking for db/schema-490to4910.sql in the classpath
2017-01-02 21:28:28,037 DEBUG [c.c.u.s.Script] (main:null) (logid:)
System resource:
file:/usr/share/cloudstack-management/setup/db/schema-490to4910.sql
2017-01-02 21:28:28,038 DEBUG [c.c.u.s.Script] (main:null) (logid:)
Absolute path =
/usr/share/cloudstack-management/setup/db/schema-490to4910.sql
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- Licensed to the Apache Software Foundation (ASF) under one
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- or more contributor license agreements.  See the NOTICE file
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- distributed with this work for additional information
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- regarding copyright ownership.  The ASF licenses this file
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- to you under the Apache License, Version 2.0 (the
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- "License"); you may not use this file except in compliance
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- with the License.  You may obtain a copy of the License at
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) --   http://www.apache.org/licenses/LICENSE-2.0
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- Unless required by applicable law or agreed to in writing,
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)

[GitHub] cloudstack pull request #1887: schema: Fix upgrade issue for 4.9.1.0->4.9.2....

2017-01-02 Thread rhtyd 
GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1887

schema: Fix upgrade issue for 4.9.1.0->4.9.2.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4910-upgrade-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1887.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1887


commit a3b86c7135dbd88838c8f44c921577059e22be88
Author: Rohit Yadav 
Date:   2017-01-03T06:50:09Z

schema: Fix upgrade issue for 4.9.1.0->4.9.2.0

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC1)

2017-01-02 Thread Rohit Yadav 
Hi Bruno,


Thanks for starting testing 4.9.2.0 (RC1).


You've found a valid bug. Since 4.9.1.0 was not announced, it's less likely for 
users to hit this but I'll fix this and start another RC today.

During the 4.9.1.0->4.9.2.0 upgrade path, it re-runs the 490to4910 upgrade 
path. The fix is simple:


--- a/engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
+++ b/engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
@@ -280,7 +280,7 @@ public class DatabaseUpgradeChecker implements 
SystemIntegrityChecker {

 _upgradeMap.put(CloudStackVersion.parse("4.9.0"), new DbUpgrade[] {new 
Upgrade490to4910(), new Upgrade4910to4920()});

-_upgradeMap.put(CloudStackVersion.parse("4.9.1.0"), new DbUpgrade[] 
{new Upgrade490to4910(), new Upgrade4910to4920()});
+_upgradeMap.put(CloudStackVersion.parse("4.9.1.0"), new DbUpgrade[] 
{new Upgrade4910to4920()});


After this fix, this is what looked like before upgrade in cloud.version:

| 18 | 4.9.0   | 2017-01-03 06:02:32 | Complete |
| 19 | 4.9.1.0 | 2017-01-03 06:02:32 | Complete |


After upgrade:


| 19 | 4.9.1.0 | 2017-01-03 06:02:32 | Complete |
| 21 | 4.9.2.0 | 2017-01-03 06:48:28 | Complete |


Regards.


From: Milamber 
Sent: 03 January 2017 03:16:20
To: dev@cloudstack.apache.org
Subject: Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC1)

Hello,

I try to upgrade from 4.9.1.0 to 4.9.2.0 RC1, and I've this error:

2017-01-02 21:28:28,424 WARN [o.a.c.s.m.c.ResourceApplicationContext]
(main:null) (logid:) Exception encountered during context initialization
- cancelling refresh attempt:
org.springframework.context.ApplicationContextException: Failed to start
bean 'cloudStackLifeCycle'; nested exception is
javax.persistence.EntityExistsException: Entity already exists:
=> no other line in log after this line




The full log below:

2017-01-02 21:28:27,284 INFO  [c.c.u.d.T.Transaction] (main:null)
(logid:) Is Data Base High Availiability enabled? Ans : false
2017-01-02 21:28:27,526 DEBUG [c.c.u.d.DriverLoader] (main:null)
(logid:) Successfully loaded DB driver com.mysql.jdbc.Driver
2017-01-02 21:28:27,544 DEBUG [c.c.u.d.DriverLoader] (main:null)
(logid:) DB driver com.mysql.jdbc.Driver was already loaded.
2017-01-02 21:28:27,545 DEBUG [c.c.u.d.DriverLoader] (main:null)
(logid:) DB driver com.mysql.jdbc.Driver was already loaded.
2017-01-02 21:28:27,892 DEBUG [c.c.u.d.ConnectionConcierge] (main:null)
(logid:) Registering a database connection for LockMaster1
2017-01-02 21:28:27,892 INFO  [c.c.u.d.Merovingian2] (main:null)
(logid:) Cleaning up locks for 2200278139079
2017-01-02 21:28:27,898 INFO  [c.c.u.d.Merovingian2] (main:null)
(logid:) Released 0 locks for 2200278139079
2017-01-02 21:28:27,945 INFO [o.a.c.s.l.CloudStackExtendedLifeCycle]
(main:null) (logid:) Running system integrity checker
com.cloud.upgrade.DatabaseUpgradeChecker@15e9c283
2017-01-02 21:28:27,946 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) Grabbing lock to check for database upgrade.
2017-01-02 21:28:27,991 DEBUG [c.c.u.d.VersionDaoImpl] (main:null)
(logid:) Checking to see if the database is at a version before it was
the version table is created
2017-01-02 21:28:28,024 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) DB version = 4.9.1.0 Code Version = 4.9.2.0
2017-01-02 21:28:28,024 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) Database upgrade must be performed from 4.9.1.0 to 4.9.2.0
2017-01-02 21:28:28,024 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) Running upgrade Upgrade490to4910 to upgrade from 4.9.0-4.9.1.0
to 4.9.1.0
2017-01-02 21:28:28,037 DEBUG [c.c.u.s.Script] (main:null) (logid:)
Looking for db/schema-490to4910.sql in the classpath
2017-01-02 21:28:28,037 DEBUG [c.c.u.s.Script] (main:null) (logid:)
System resource:
file:/usr/share/cloudstack-management/setup/db/schema-490to4910.sql
2017-01-02 21:28:28,038 DEBUG [c.c.u.s.Script] (main:null) (logid:)
Absolute path =
/usr/share/cloudstack-management/setup/db/schema-490to4910.sql
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- Licensed to the Apache Software Foundation (ASF) under one
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- or more contributor license agreements.  See the NOTICE file
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- distributed with this work for additional information
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- regarding copyright ownership.  The ASF licenses this file
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- to you under the Apache License, Version 2.0 (the
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- "License"); you may not use this file except in compliance
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null)
(logid:) -- with the License.  You may obtain a copy of the

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-02 Thread anshul1886 
Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1735#discussion_r94362243
  
--- Diff: 
api/src/org/apache/cloudstack/api/command/user/snapshot/ListSnapshotsCmd.java 
---
@@ -115,8 +115,10 @@ public void execute() {
 List snapshotResponses = new 
ArrayList();
 for (Snapshot snapshot : result.first()) {
 SnapshotResponse snapshotResponse = 
_responseGenerator.createSnapshotResponse(snapshot);
-snapshotResponse.setObjectName("snapshot");
-snapshotResponses.add(snapshotResponse);
+if (snapshotResponse != null) {
+snapshotResponse.setObjectName("snapshot");
--- End diff --

Is any issue observed here for which null check is added?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-01-02 Thread anshul1886 
Github user anshul1886 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1735#discussion_r94362119
  
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -517,10 +517,10 @@ public String getSecondaryStorageURL(SnapshotVO 
snapshot) {
 List ids = getIdsListFromCmd(cmd.getId(), cmd.getIds());
 
 Ternary 
domainIdRecursiveListProject = new Ternary(cmd.getDomainId(), cmd.isRecursive(), null);
-   _accountMgr.buildACLSearchParameters(caller, id, 
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts, 
domainIdRecursiveListProject, cmd.listAll(), false);
-   Long domainId = domainIdRecursiveListProject.first();
-   Boolean isRecursive = domainIdRecursiveListProject.second();
-   ListProjectResourcesCriteria listProjectResourcesCriteria = 
domainIdRecursiveListProject.third();
+_accountMgr.buildACLSearchParameters(caller, id, 
cmd.getAccountName(), cmd.getProjectId(), permittedAccounts, 
domainIdRecursiveListProject, cmd.listAll(), false);
+Long domainId = domainIdRecursiveListProject.first();
+Boolean isRecursive = domainIdRecursiveListProject.second();
+ListProjectResourcesCriteria listProjectResourcesCriteria = 
domainIdRecursiveListProject.third();
--- End diff --

@nvazquez What is changed here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-01-02 Thread rhtyd 
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@swill @jayapalu updates on this, is this good to go?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-02 Thread anshul1886 
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@serg38 seems so both addressing same issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-02 Thread serg38 
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@mike-tutkowski @anshul-gangwar @nvazquez I believe the same issue is 
addressed in PR1735 but in a more consistent fashion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-02 Thread anshul1886 
Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
@mike-tutkowski Its in bug description. Are you not seeing this issue on 
your end?

2016-08-26 14:34:36,709 DEBUG [c.c.a.ApiServlet] 
(catalina-exec-1:ctx-90c9ba3a) (logid:115e39ad) ===START=== 10.233.88.59 – 
GET 
command=listSnapshots=json=true=1=20&_=1472202277072
2016-08-26 14:34:36,747 ERROR [c.c.a.ApiServer] 
(catalina-exec-1:ctx-90c9ba3a ctx-94284178) (logid:115e39ad) unhandled 
exception executing api command: [Ljava.lang.String;@77f27ce8
com.cloud.utils.exception.CloudRuntimeException: Unable to locate datastore 
with id 1
at 
org.apache.cloudstack.storage.datastore.manager.PrimaryDataStoreProviderManagerImpl.getPrimaryDataStore(PrimaryDataStoreProviderManagerImpl.java:61)
at 
org.apache.cloudstack.storage.datastore.DataStoreManagerImpl.getDataStore(DataStoreManagerImpl.java:48)
at 
com.cloud.api.ApiResponseHelper.getDataStoreRole(ApiResponseHelper.java:571)
at 
com.cloud.api.ApiResponseHelper.createSnapshotResponse(ApiResponseHelper.java:537)
at 
org.apache.cloudstack.api.command.user.snapshot.ListSnapshotsCmd.execute(ListSnapshotsCmd.java:117)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:132)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:707)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:538)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:297)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:129)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103)
at 
org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:126)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:86)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Cloudstack 4.9.2.0 (RC1)

2017-01-02 Thread Milamber 

Hello,

I try to upgrade from 4.9.1.0 to 4.9.2.0 RC1, and I've this error:

2017-01-02 21:28:28,424 WARN [o.a.c.s.m.c.ResourceApplicationContext] 
(main:null) (logid:) Exception encountered during context initialization 
- cancelling refresh attempt: 
org.springframework.context.ApplicationContextException: Failed to start 
bean 'cloudStackLifeCycle'; nested exception is 
javax.persistence.EntityExistsException: Entity already exists:

=> no other line in log after this line




The full log below:

2017-01-02 21:28:27,284 INFO  [c.c.u.d.T.Transaction] (main:null) 
(logid:) Is Data Base High Availiability enabled? Ans : false
2017-01-02 21:28:27,526 DEBUG [c.c.u.d.DriverLoader] (main:null) 
(logid:) Successfully loaded DB driver com.mysql.jdbc.Driver
2017-01-02 21:28:27,544 DEBUG [c.c.u.d.DriverLoader] (main:null) 
(logid:) DB driver com.mysql.jdbc.Driver was already loaded.
2017-01-02 21:28:27,545 DEBUG [c.c.u.d.DriverLoader] (main:null) 
(logid:) DB driver com.mysql.jdbc.Driver was already loaded.
2017-01-02 21:28:27,892 DEBUG [c.c.u.d.ConnectionConcierge] (main:null) 
(logid:) Registering a database connection for LockMaster1
2017-01-02 21:28:27,892 INFO  [c.c.u.d.Merovingian2] (main:null) 
(logid:) Cleaning up locks for 2200278139079
2017-01-02 21:28:27,898 INFO  [c.c.u.d.Merovingian2] (main:null) 
(logid:) Released 0 locks for 2200278139079
2017-01-02 21:28:27,945 INFO [o.a.c.s.l.CloudStackExtendedLifeCycle] 
(main:null) (logid:) Running system integrity checker 
com.cloud.upgrade.DatabaseUpgradeChecker@15e9c283
2017-01-02 21:28:27,946 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Grabbing lock to check for database upgrade.
2017-01-02 21:28:27,991 DEBUG [c.c.u.d.VersionDaoImpl] (main:null) 
(logid:) Checking to see if the database is at a version before it was 
the version table is created
2017-01-02 21:28:28,024 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) DB version = 4.9.1.0 Code Version = 4.9.2.0
2017-01-02 21:28:28,024 INFO  [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Database upgrade must be performed from 4.9.1.0 to 4.9.2.0
2017-01-02 21:28:28,024 DEBUG [c.c.u.DatabaseUpgradeChecker] (main:null) 
(logid:) Running upgrade Upgrade490to4910 to upgrade from 4.9.0-4.9.1.0 
to 4.9.1.0
2017-01-02 21:28:28,037 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Looking for db/schema-490to4910.sql in the classpath
2017-01-02 21:28:28,037 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
System resource: 
file:/usr/share/cloudstack-management/setup/db/schema-490to4910.sql
2017-01-02 21:28:28,038 DEBUG [c.c.u.s.Script] (main:null) (logid:) 
Absolute path = 
/usr/share/cloudstack-management/setup/db/schema-490to4910.sql
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- Licensed to the Apache Software Foundation (ASF) under one
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- or more contributor license agreements.  See the NOTICE file
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- distributed with this work for additional information
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- regarding copyright ownership.  The ASF licenses this file
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- to you under the Apache License, Version 2.0 (the
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- "License"); you may not use this file except in compliance
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- with the License.  You may obtain a copy of the License at

2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) --   http://www.apache.org/licenses/LICENSE-2.0

2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) --
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- Unless required by applicable law or agreed to in writing,
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- software distributed under the License is distributed on an
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
2017-01-02 21:28:28,039 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- KIND, either express or implied.  See the License for the
2017-01-02 21:28:28,040 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- specific language governing permissions and limitations
2017-01-02 21:28:28,040 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- under the License.
2017-01-02 21:28:28,040 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) --;
2017-01-02 21:28:28,041 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) -- Schema upgrade from 4.9.0 to 4.9.1;
2017-01-02 21:28:28,041 DEBUG [c.c.u.d.ScriptRunner] (main:null) 
(logid:) --;
2017-01-02 21:28:28,041 DEBUG

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-02 Thread mike-tutkowski 
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
Can you tell me which line was throwing a NullPointerException in the code 
that you fixed? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...

2017-01-02 Thread jayapalu 
GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1886

CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response

 Url generated by CCP to request traffic sentinel for usage stats is too 
long causing HTTP 414 Request-URI Too Long error response. This is because we 
are using the GET request to send the data to the traffic sentinel instance and 
url size exceeds the max length of GET request.

Changing the request method to POST

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack trafficsentinel

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1886


commit 021eae4f55f4dba9eb267d68a17893d7f31e0d99
Author: Jayapal 
Date:   2017-01-02T10:59:17Z

CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

2017-01-02 Thread jayapalu 
GitHub user jayapalu opened a pull request:

https://github.com/apache/cloudstack/pull/1885

CLOUDSTACK-9724: Fixed missing additional public ip on tier network w…

In VPC tier network acquire an ip and configure the PF service on it. VR 
now will have the two ip addresses on the interface.
Now restart the VPC tier network with cleanup option. After router comes up 
the public interface has only one ip (source nat ip)
Fixed the above issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack vpctier

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1885


commit f678e5d70886b1177b3087e521bfdebb6f945a06
Author: Jayapal 
Date:   2017-01-02T09:02:46Z

CLOUDSTACK-9724: Fixed missing additional public ip on tier network with 
cleanup




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---