date:20170210

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) 
has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Sure @serg38 
@blueorangutan test centos7 xenserver-65sp1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
@BlueOrangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
Trillian test result (tid-810)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32603 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1935-t810-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_redundant_VPC_default_routes | `Failure` | 854.15 | 
test_vpc_redundant.py
test_04_rvpc_privategw_static_routes | `Failure` | 310.34 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 159.79 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.17 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 236.31 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 253.89 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 533.13 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 505.05 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1413.32 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 543.16 | test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1269.24 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.44 | test_volumes.py
test_08_resize_volume | Success | 151.68 | test_volumes.py
test_07_resize_fail | Success | 161.54 | test_volumes.py
test_06_download_detached_volume | Success | 156.35 | test_volumes.py
test_05_detach_volume | Success | 150.77 | test_volumes.py
test_04_delete_attached_volume | Success | 151.29 | test_volumes.py
test_03_download_attached_volume | Success | 156.30 | test_volumes.py
test_02_attach_volume | Success | 84.34 | test_volumes.py
test_01_create_volume | Success | 621.02 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.20 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.77 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.77 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.74 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.62 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.25 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 36.05 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.82 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.30 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 40.47 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.13 | test_templates.py
test_03_delete_template | Success | 5.10 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 40.52 | test_templates.py
test_10_destroy_cpvm | Success | 161.42 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.61 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.56 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.46 | test_ssvm.py
test_06_stop_cpvm | Success | 101.64 | test_ssvm.py
test_05_stop_ssvm | Success | 138.80 | test_ssvm.py
test_04_cpvm_internals | Success | 1.18 | test_ssvm.py
test_03_ssvm_internals | Success | 3.29 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.27 | test_snapshots.py
test_04_change_offering_small | Success | 210.02 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.30 | test_routers.py
test_08_start_router | Success | 25.25 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
Ok, got it.
Maybe in CentOS logical links get created during the installation of Java. 
Or maybe during the installation of ACS. The computer  I am using is not used 
to run ACS, but I use Java here, and this is why I asked you.

my output: 
```
lrwxrwxrwx  1 root root   20 Dec  1 12:48 java-1.6.0-openjdk-amd64 -> 
java-6-ope  

   njdk-amd64/
-rw-r--r--  1 root root 2387 Dec  1 12:48 .java-1.6.0-openjdk-amd64.jinfo
lrwxrwxrwx  1 root root   20 Feb  7 20:10 java-1.7.0-openjdk-amd64 -> 
java-7-ope  

   njdk-amd64/
-rw-r--r--  1 root root 2439 Feb  7 20:10 .java-1.7.0-openjdk-amd64.jinfo
drwxr-xr-x  5 root root 4096 Feb 10 14:00 java-6-openjdk-amd64/
drwxr-xr-x  3 root root 4096 Feb 10 13:59 java-6-openjdk-common/
drwxr-xr-x  5 root root 4096 Feb 10 13:57 java-7-openjdk-amd64/
```
Anyways, I understand that you are following the current pattern. So, we 
may let this problem (if it turns out to be a problem) for our future selves. 
If people start having problems when updating to java JRE version bigger than 
1.8.0.

Having said that, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread swill

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
So the short answer is that I ran into this issue when I upgraded and since 
`jenv` did not correctly set the `JAVA_HOME` directory, I ran into this, so I 
don't have a deep understanding for all the details.  I made this change in my 
environment and everything worked.  I understand this is not a good answer, but 
that is what I have.

I don't install to that path either, but for some reason it was populated 
in my environment.  Can you do an `$ ll /usr/lib/jvm/` and post what you get?  
I am curious what it would return.  

Here is the result from my CentOS 6.8 setup.


![image](https://cloud.githubusercontent.com/assets/13644/22841453/ae384516-ef9f-11e6-835a-60736d6a03dc.png)

The way I see it right now, people WILL run into this issue.  This at least 
reduces the number of people who have problems.  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #34: Remove link to “planet.apache.org” and update ...

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/34
  
Guys (@pdion891, @terbolous) any extra comment here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-www issue #25: Updated list with makewholist.py

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack-www/pull/25
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
@Swill, I have a question (actually two) :)

If âJAVA_HOMEâ is not set, or if âJAVA_HOMEâ content does not 
exist, we check if there is a java installation. I have a doubt about this last 
path we are checking. Is this path â/usr/lib/jvm/jre-1.8.0â default (some 
sort of standard)?

I ask because (at least on Debian, or at least the Debian I am using) 
whenever I install using âaptitudeâ, the java versions were added to 
folders following the pattern: 
â/usr/lib/jvm/java--openjdk-/jre/â. Of 
course, this is for OpenJDK installed with âaptitudeâ.

Are we assuming that the user when installing manually (e.g. installing the 
JRE from Oracle) will put Java JRE files in a folder like 
â/usr/lib/jvm/jre-1.8.0â?

This will also only work for Java JRE 1.8.0, if users install Java JRE 
1.8.1 and use the version as the name of the folder, this would not work. Of 
course, all can be fixed by setting the JAVA_HOME. 

Would not it be better to cause an exception and stop the deployment with a 
message saying that we require the âJAVA_HOMEâ to be set? Then, it feels 
that we will be consistent; otherwise, I can imagine a user complaining that 
she/he has installed the Java 8 (1.8.x; where x > 0), but still ACS does not 
work. 

What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread swill

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
@rhtyd, @wido, @nvazquez, @rafaelweingartner please review...

This fixes an issue with #1888.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME value t...

2017-02-10 Thread nvazquez

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1938
  
Thanks @swill!

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Upgrade fails on Master

2017-02-10 Thread Will Stevens

New PR opened to solve this issue.

Jira: https://issues.apache.org/jira/browse/CLOUDSTACK-9780
Github: https://github.com/apache/cloudstack/pull/1938

Please review...

*Will STEVENS*
Lead Developer



On Fri, Feb 3, 2017 at 12:32 PM, Will Stevens  wrote:

> Thanks for the tip Nicolas.
>
> It turns out that 'jenv' was not setting the JAVA_HOME even though it had
> Java8 configured as the active Java version.
>
> Because of this, the file '/etc/cloudstack/management/classpath.conf' was
> defaulting to Java7.
>
> I commented that section and made it default to Java8 and everything works
> again.
>
> ---
> export CLASSPATH
> #if ([ -z "$JAVA_HOME" ] || [ ! -d "$JAVA_HOME" ]) && [ -d
> /usr/lib/jvm/jre-1.7.0 ]; then
> # export JAVA_HOME=/usr/lib/jvm/jre-1.7.0
> #fi
> if ([ -z "$JAVA_HOME" ] || [ ! -d "$JAVA_HOME" ]) && [ -d
> /usr/lib/jvm/jre-1.8.0 ]; then
>  export JAVA_HOME=/usr/lib/jvm/jre-1.8.0
> fi
> PATH=$JAVA_HOME/bin:/sbin:/usr/sbin:$PATH
> export PATH
> ---
>
> Thanks for the help everyone...
>
>
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Fri, Feb 3, 2017 at 11:57 AM, Rafael Weingärtner <
> rafaelweingart...@gmail.com> wrote:
>
>> The others already answered this one:
>> "Unsupported major.minor version 52.0"
>>
>> I am assuming you are compiling with 1.8, and it seems you are using 1.7
>> or
>> lower version.
>>
>>
>> On Fri, Feb 3, 2017 at 11:48 AM, Nicolas Vazquez > >
>> wrote:
>>
>> > Hi Will,
>> >
>> > Did you try modifying /etc/cloudstack/management/classpath.conf file
>> for
>> > Tomcat to run using java 8?
>> >
>> > 2017-02-03 13:43 GMT-03:00 Daan Hoogland :
>> >
>> > > that's what wat cought my eye as well, and this is important for
>> users to
>> > > consider, So to must first upgrade java and then ACS.
>> > >
>> > > 
>> > > From: Milamber 
>> > > Sent: 03 February 2017 17:40:37
>> > > To: dev@cloudstack.apache.org
>> > > Subject: Re: Upgrade fails on Master
>> > >
>> > >
>> > > Probably an issue with your java version on your Centos machine? now
>> CS
>> > > 4.10 need Java 8 to run.
>> > >
>> > >
>> > > On 03/02/2017 15:12, Will Stevens wrote:
>> > > > That was the 'management-server.log'...
>> > > >
>> > > > Here is the 'catalina.out' log.
>> > > >
>> > > > --- snip ---
>> > > > Feb 03, 2017 2:22:56 PM org.apache.catalina.loader.Web
>> appClassLoader
>> > > > validateJarFile
>> > > > INFO:
>> > > > validateJarFile(/usr/share/cloudstack-management/webapps/
>> > > client/WEB-INF/lib/tomcat-embed-core-8.0.30.jar)
>> > > > - jar not loaded. See Servlet Spec 2.3, section 9.7.2. Offending
>> class:
>> > > > javax/servlet/Servlet.class
>> > > > Feb 03, 2017 2:22:56 PM org.apache.tomcat.util.modeler.Registry
>> > > > registerComponent
>> > > > SEVERE: Null component
>> > > > Catalina:type=JspMonitor,name=jsp,WebModule=//localhost/
>> > > client,J2EEApplication=none,J2EEServer=none
>> > > > Feb 03, 2017 2:22:56 PM org.apache.catalina.startup.HostConfig
>> > > > deployDirectory
>> > > > SEVERE: Error deploying web application directory client
>> > > > java.lang.UnsupportedClassVersionError:
>> > > > org/apache/cloudstack/spring/module/web/CloudStackContextLoa
>> derListene
>> > r
>> > > :
>> > > > Unsupported major.minor version 52.0 (unable to load class
>> > > > org.apache.cloudstack.spring.module.web.CloudStackContextLoa
>> derListene
>> > r)
>> > > > at
>> > > > org.apache.catalina.loader.WebappClassLoader.findClassInternal(
>> > > WebappClassLoader.java:2334)
>> > > > at
>> > > > org.apache.catalina.loader.WebappClassLoader.findClass(
>> > > WebappClassLoader.java:976)
>> > > > at
>> > > > org.apache.catalina.loader.WebappClassLoader.loadClass(
>> > > WebappClassLoader.java:1450)
>> > > > at
>> > > > org.apache.catalina.loader.WebappClassLoader.loadClass(
>> > > WebappClassLoader.java:1329)
>> > > > at
>> > > > org.apache.catalina.startup.WebAnnotationSet.loadClassAnnotation(
>> > > WebAnnotationSet.java:145)
>> > > > at
>> > > > org.apache.catalina.startup.WebAnnotationSet.
>> > > loadApplicationListenerAnnotations(WebAnnotationSet.java:73)
>> > > > at
>> > > > org.apache.catalina.startup.WebAnnotationSet.
>> > loadApplicationAnnotations(
>> > > WebAnnotationSet.java:56)
>> > > > at
>> > > > org.apache.catalina.startup.ContextConfig.
>> > applicationAnnotationsConfig(
>> > > ContextConfig.java:294)
>> > > > at org.apache.catalina.startup.ContextConfig.start(
>> > > ContextConfig.java:1046)
>> > > > at
>> > > > org.apache.catalina.startup.ContextConfig.lifecycleEvent(
>> > > ContextConfig.java:265)
>> > > > at
>> > > > org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(
>> > > LifecycleSupport.java:142)
>> > > > at org.apache.catalina.core.StandardContext.start(
>> > > StandardContext.java:4650)
>> > > > at
>> > > > org.apache.catalina.core.ContainerBase.addChildInternal(
>> > >

[GitHub] cloudstack pull request #1938: CLOUDSTACK-9780: Fixed the default JAVA_HOME ...

2017-02-10 Thread swill

GitHub user swill opened a pull request:

https://github.com/apache/cloudstack/pull/1938

CLOUDSTACK-9780: Fixed the default JAVA_HOME value to be Java8 if not set

Now that PR-1888 is merged, Java8 is required.  Unfortunately, the file 
pushed to `/etc/cloudstack/management/classpath.conf` on ACS install will 
default the version to Java7 instead of Java8 if JAVA_HOME is unset.  This fix 
sets the default to Java8 if JAVA_HOME is not set.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/swill/cloudstack classpath

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1938


commit 6ee4a195f27fe59c61e96d0ab1c56dee0c05a52b
Author: Will Stevens 
Date:   2017-02-10T18:42:58Z

Fixed the default JAVA_HOME value to be Java8 if not set




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-10 Thread swill

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
Here is another set of tests run to validate all the settings (in addition 
to the normal tests).

```

++++---+---+--+--+---+-++
| Status | IKE| ESP| DPD   | Encap 
| IKE Life | ESP Life | Passive   | Conn State  | Requires 
Reset |

++++===+===+==+==+===+=++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
| 86400| 3600 | True : False  | Disconnected : Connected| True : 
False   |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | True  
| 86400| 3600 | True : False  | Disconnected : Connected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
|  | 3600 | True : False  | Disconnected : Connected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
| 86400|  | True : False  | Disconnected : Connected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
|  |  | True : False  | Disconnected : Connected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
| 86400| 3600 | False : False | Connected : Connected   | False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
| 86400| 3600 | True : True   | Disconnected : Disconnected | False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | True  | False 
| 86400| 3600 | False : True  | Connected : Disconnected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | False | False 
| 86400| 3600 | False : False | Connected : Connected   | False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | False | False 
| 86400| 3600 | True : False  | Disconnected : Connected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | False | False 
| 86400| 3600 | True : True   | Disconnected : Disconnected | False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1;modp1536   | False | False 
| 86400| 3600 | False : True  | Connected : Disconnected| False : 
False  |

++++---+---+--+--+---+-++
| OK | aes128-sha1;modp1536   | aes128-sha1| True  | False 
| 86400| 3600 | True : False  | Disconnected : Connected| False : 
False  |

ONE DAY LEFT!!! Submit a CCC Talk for Miami TODAY!

2017-02-10 Thread Will Stevens

Hello Everyone,
We are now down to the wire.  Tomorrow the talk submissions close for the
CloudStack Collaboration Conference in Miami.  Go submit your talk...

It is going to be a great event with a lot of participation, so it is a
great opportunity to network and get exposure for your work.

Here is a little recap of some of the details:

*Talk Submission:*
Talk Submission Deadline: *Feb 11th, 2017*  [Submit a Talk
]
Accepted talks notification: *March 6, 2017*
Schedule Published: *March 9, 2017*

*Registration:*
*Early Registration:* through March 12, 2017
*Standard Registration:* March 13, 2017 - April 16, 2017
*Late Registration:* April 17, 2017 - Event Date
*Committer Registration:* Special pricing is available for active Apache
Committers. Please contact the event organizers for details.
*Speaker Registration:* One free registration is included with each
accepted talk. [Submit a Talk 
]

*Sponsorship:*
We would love to have your organization sponsor the event.  This is a great
opportunity for your organization to be featured in front of the Apache
CloudStack community.  If your organization is able to sponsor, please
review these details.  [Sponsorship
]

Looking forward to seeing you there.

Cheers,

Will

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r100575787
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = GlobalLock.getInternLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+boolean rollBackState = false;
+boolean hasDedicatedResources = false;
+
+try {
+long ownerId = domain.getAccountId();
+if ((cleanup != null) && cleanup.booleanValue()) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
+//don't delete the domain if there are accounts set 
for cleanup, or non-removed

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r100574038
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = GlobalLock.getInternLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+boolean rollBackState = false;
+boolean hasDedicatedResources = false;
+
+try {
+long ownerId = domain.getAccountId();
+if ((cleanup != null) && cleanup.booleanValue()) {
--- End diff --

What about using "org.apache.commons.lang.BooleanUtils.toBoolean(Boolean)" 
here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-02-10 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r100575967
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = GlobalLock.getInternLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+boolean rollBackState = false;
+boolean hasDedicatedResources = false;
+
+try {
+long ownerId = domain.getAccountId();
+if ((cleanup != null) && cleanup.booleanValue()) {
+if (!cleanupDomain(domain.getId(), ownerId)) {
 rollBackState = true;
 CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
+new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
+domain.getId() + ").");
 e.addProxyObject(domain.getUuid(), "domainId");
 throw e;
 }
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
+//don't delete the domain if there are accounts set 
for cleanup, or non-removed

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-10 Thread serg38

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
@borisstoyanov @DaanHoogland @rhtyd KVM tests passed but key smoke test is 
skipped 
test_change_service_offering_for_vm_with_snapshots  Skipped
To be on the safe side can we test it on vmware and Xen as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1727
  
Trillian test result (tid-809)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31586 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1727-t809-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 48 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 310.09 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.06 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.24 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 241.12 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 258.78 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 532.79 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 506.07 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1394.10 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 545.37 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 751.62 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1288.57 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.49 | test_volumes.py
test_08_resize_volume | Success | 151.34 | test_volumes.py
test_07_resize_fail | Success | 156.41 | test_volumes.py
test_06_download_detached_volume | Success | 151.59 | test_volumes.py
test_05_detach_volume | Success | 150.73 | test_volumes.py
test_04_delete_attached_volume | Success | 151.10 | test_volumes.py
test_03_download_attached_volume | Success | 156.22 | test_volumes.py
test_02_attach_volume | Success | 84.11 | test_volumes.py
test_01_create_volume | Success | 711.26 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.76 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.73 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 263.02 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.64 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.15 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 50.93 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.78 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.90 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.41 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 60.58 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.15 | test_templates.py
test_03_delete_template | Success | 5.13 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 40.40 | test_templates.py
test_10_destroy_cpvm | Success | 191.41 | test_ssvm.py
test_09_destroy_ssvm | Success | 168.60 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.48 | test_ssvm.py
test_07_reboot_ssvm | Success | 103.35 | test_ssvm.py
test_06_stop_cpvm | Success | 131.79 | test_ssvm.py
test_05_stop_ssvm | Success | 133.21 | test_ssvm.py
test_04_cpvm_internals | Success | 1.15 | test_ssvm.py
test_03_ssvm_internals | Success | 3.94 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.20 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.29 | test_snapshots.py
test_04_change_offering_small | Success | 239.54 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.17 | test_secondary_storage.py
test_09_reboot_router | Success | 35.29 | test_routers.py
test_08_start_router | Success | 25.24 | test_routers.py
test_07_stop_router | Success | 10.30 | test_routers.py

[GitHub] cloudstack pull request #1913: CLOUDSTACK-9752: [Vmware] Optimization of vol...

2017-02-10 Thread nvazquez

Github user nvazquez commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1913#discussion_r100543231
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
 ---
@@ -1577,11 +1577,15 @@ public Answer createVolume(CreateObjectCommand cmd) 
{
 }
 
 synchronized (this) {
-// s_logger.info("Delete file if exists in datastore 
to clear the way for creating the volume. file: " + volumeDatastorePath);
-VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, 
volumeUuid.toString(), dcMo);
-
-vmMo.createDisk(volumeDatastorePath, 
(int)(volume.getSize() / (1024L * 1024L)), morDatastore, 
vmMo.getScsiDeviceControllerKey());
-vmMo.detachDisk(volumeDatastorePath, false);
+try {
+vmMo.createDisk(volumeDatastorePath, 
(int)(volume.getSize() / (1024L * 1024L)), morDatastore, 
vmMo.getScsiDeviceControllerKey());
+vmMo.detachDisk(volumeDatastorePath, false);
+}
+catch (Exception e) {
+s_logger.error("Deleting file " + 
volumeDatastorePath + " due to error: " + e.getMessage());
+
VmwareStorageLayoutHelper.deleteVolumeVmdkFiles(dsMo, volumeUuid.toString(), 
dcMo);
--- End diff --

Hi @syed @karuturi @SudharmaJain,
What do you think about this approach? We will delete vmdk file if either 
createDisk or detachDisk fails, this way we make sure file doesn't exist in 
case that CloudStack retries operation. By the way, in VolumeOrchestrator lines 
556-588 there's the retry logic, to retry only if failure contains "request 
template reload":


for (int i = 0; i < 2; i++) {
// retry one more time in case of template reload is required 
for Vmware case
AsyncCallFuture future = null;
boolean isNotCreatedFromTemplate = volume.getTemplateId() == 
null ? true : false;
if (isNotCreatedFromTemplate) {
future = volService.createVolumeAsync(volume, store);
} else {
TemplateInfo templ = 
tmplFactory.getTemplate(template.getId(), DataStoreRole.Image);
future = volService.createVolumeFromTemplateAsync(volume, 
store.getId(), templ);
}
try {
VolumeApiResult result = future.get();
if (result.isFailed()) {
if (result.getResult().contains("request template 
reload") && (i == 0)) {
s_logger.debug("Retry template re-deploy for 
vmware");
continue;
} else {
s_logger.debug("create volume failed: " + 
result.getResult());
throw new CloudRuntimeException("create volume 
failed:" + result.getResult());
}
}

return result.getVolume();
} catch (InterruptedException e) {
s_logger.error("create volume failed", e);
throw new CloudRuntimeException("create volume failed", e);
} catch (ExecutionException e) {
s_logger.error("create volume failed", e);
throw new CloudRuntimeException("create volume failed", e);
}
}
throw new CloudRuntimeException("create volume failed even after 
template re-deploy");
}


To preserve this logic is that I've passed caught exception message on 
thrown exception in line 1587. Do you agree with this solution?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-02-10 Thread ProjectMoon

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r100535848
  
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -62,3 +62,4 @@ INSERT INTO `cloud`.`role_permissions` (`uuid`, 
`role_id`, `rule`, `permission`,
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 3, 'createSnapshotFromVMSnapshot', 
'ALLOW', 302) ON DUPLICATE KEY UPDATE rule=rule;
 INSERT INTO `cloud`.`role_permissions` (`uuid`, `role_id`, `rule`, 
`permission`, `sort_order`) values (UUID(), 4, 'createSnapshotFromVMSnapshot', 
'ALLOW', 260) ON DUPLICATE KEY UPDATE rule=rule;
 
+ALTER TABLE `user_ip_address` ADD COLUMN `staticnat_state` VARCHAR(32) 
COMMENT 'static  rule state while removing'
--- End diff --

This column name does not match the name of the column in the VO 
(`rule_state`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
Packaging result: âcentos6 âcentos7 âdebian. JID-478


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1933
  
Testing has PASSED
There's a way to override the hardcoded timeout of 10 mins now by setting 
the "router.aggregation.command.each.timeout" in the 
"/etc/cloudstack/agent/agent.properties" file.
Testing steps:
Set the router.aggregation.command.each.timeout=1
Added a sleep of 15 seconds in the router_proxy.sh
Restarted the agent 
Started a new VM with a new network
In the log the following observations were noted:

```
2017-01-20 12:04:05,787 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-2:null) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.3.57 -c /var/cache/cloud/VR-a20603a7-8e10-4378-96bb-7a2dbc7c6c0b.cfg
2017-01-20 12:04:06,792 WARN  [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-2:null) Timed out: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.3.57 -c /var/cache/cloud/VR-a20603a7-8e10-4378-96bb-7a2dbc7c6c0b.cfg .  
Output is:
2017-01-20 12:05:20,419 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.0.41 -c /var/cache/cloud/VR-090cae6a-f07d-40bb-9f19-809ccdcca16b.cfg
2017-01-20 12:05:21,423 WARN  [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Timed out: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.0.41 -c /var/cache/cloud/VR-090cae6a-f07d-40bb-9f19-809ccdcca16b.cfg .  
Output is:
2017-01-20 12:06:33,620 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.2.33 -c /var/cache/cloud/VR-63f52dbd-b710-4e57-a21b-1f4bcd146ec3.cfg
2017-01-20 12:06:34,624 WARN  [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Timed out: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.2.33 -c /var/cache/cloud/VR-63f52dbd-b710-4e57-a21b-1f4bcd146ec3.cfg .  
Output is:
```

VR Failed to start with a Message "Unable to start a VM due to insufficient 
capacity" 
I think we could add a log message saying that it timed out in the agent 
log, because now it does not leave any clue where the time out is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD request t...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1934
  
@marcaurele there are some marvin tests in extract and delete template, 
could you please have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-10 Thread blueorangutan

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1936: [CLOUDSTACK-9773] API: don't break API output with n...

2017-02-10 Thread borisstoyanov

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1936
  
This is a really small change, why's Travis build failing?
@marcaurele @koushik-das 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1937: CLOUDSTACK-9779 : Releasing secondary guest IP fails...

2017-02-10 Thread ustcweizhou

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1937
  
files are also changed from 100644 â 100755 which is not necessary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-10 Thread ustcweizhou

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1937#discussion_r100511377
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long 
ipAddressId) {
 throw new InvalidParameterValueException("Can' remove the 
ip " + secondaryIp + "is associate with static NAT rule public IP address id " 
+ publicIpVO.getId());
 }
 
-if (_lbService.isLbRuleMappedToVmGuestIp(secondaryIp)) {
+List lbRuleIdList = 
_firewallDao.listIdByNetworkAndPurposeAndNotRevoked(network.getId(), 
Purpose.LoadBalancing);
--- End diff --

this two checks can be done by a join search in LoadBalancerVMMapDao.java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-10 Thread ustcweizhou

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1937#discussion_r100509837
  
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long 
ipAddressId) {
 throw new InvalidParameterValueException("Can' remove the 
ip " + secondaryIp + "is associate with static NAT rule public IP address id " 
+ publicIpVO.getId());
--- End diff --

line 849. The issue also happen on static nat. Could you fix it as well ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-10 Thread Rajani Karuturi

I planning to create first RC end of feb(in 20 days).

~ Rajani

http://cloudplatform.accelerite.com/

On February 10, 2017 at 2:24 PM, Daan Hoogland
(daan.hoogl...@shapeblue.com) wrote:

sorry to keep you guys waiting, I am struggling my way back in
and am working on this (and a lot) will keep you posted. @Rajani,
what is the ETA that I must meet to get this in 4.10?

daan.hoogl...@shapeblue.com
www.shapeblue.com ( http://www.shapeblue.com )
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531
VENetherlands
@shapeblue

-Original Message-
From: jayapalu [mailto:g...@git.apache.org]
Sent: vrijdag 10 februari 2017 09:27
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack issue #1741: Updated StrongSwan VPN
Implementation

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1741

@swill I have tested this PR with systemvm template with
strongswan installed long back. The s2s vpn worked fine.
LGTM from my side.

---
If your project is set up for it, you can reply to this email
and have your reply appear on GitHub as well. If your project
does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure
at infrastruct...@apache.org or file a JIRA ticket with INFRA.
---

[GitHub] cloudstack pull request #1937: CLOUDSTACK-9779 : Releasing secondary guest I...

2017-02-10 Thread niteshsarda

GitHub user niteshsarda opened a pull request:

https://github.com/apache/cloudstack/pull/1937

CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip 
x.x.x.x is mapped to load balancing rule

ISSUE 
=
Releasing secondary guest IP fails with error VM nic Ip x.x.x.x is mapped 
to load balancing rule

REPRO STEPS
==
1. Create two isolated guest networks with same CIDR
2. Deploy VMs on both networks
3. Acquire secondary IP on NICs of both VMs and make sure they have the 
same value, user can input the IP address.
4. Configure Loadbalancing rule on one of the secondary IP address and try 
releasing the other secondary IP address.
5. The operation would fail

EXPECTED BEHAVIOR
==
Secondary IP address should be released if there are no LB rules associated 
with it.

ACTUAL BEHAVIOR
==
Releasing secondary IP address even if there are no LB rules associated 
with it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CS-50136

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1937






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-10 Thread Daan Hoogland

sorry to keep you guys waiting, I am struggling my way back in and am working 
on this (and a lot) will keep you posted. @Rajani, what is the ETA that I must 
meet to get this in 4.10?

daan.hoogl...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, Utrecht Utrecht 3531 VENetherlands
@shapeblue
  
 


-Original Message-
From: jayapalu [mailto:g...@git.apache.org] 
Sent: vrijdag 10 februari 2017 09:27
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@swill I have tested this PR with  systemvm template with strongswan 
installed long back. The s2s vpn worked fine. 
LGTM from my side.


---
If your project is set up for it, you can reply to this email and have your 
reply appear on GitHub as well. If your project does not have this feature 
enabled and wishes so, or if the feature is enabled but not working, please 
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with 
INFRA.
---

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-10 Thread jayapalu

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1741
  
@swill I have tested this PR with  systemvm template with strongswan 
installed long back. The s2s vpn worked fine. 
LGTM from my side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

39 matches

Mail list logo