[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Thanks @priyankparihar 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
Trillian env failed to deploy, restarting tests.
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-502


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@blueorangutan test centos7 xenserver-65sp1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) 
has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
test centos7 vmware-60u2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1250: automated CLOUDSTACK 9177 9178 9179

2017-02-17 Thread shwetaag
Github user shwetaag closed the pull request at:

https://github.com/apache/cloudstack/pull/1250


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1250: automated CLOUDSTACK 9177 9178 9179

2017-02-17 Thread shwetaag
Github user shwetaag commented on the issue:

https://github.com/apache/cloudstack/pull/1250
  
as these cases are also included in PR 1401 so closing this PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1401: automated 9277 9276 9275 9274 9273 9179 9178 ...

2017-02-17 Thread shwetaag
Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r101708018
  
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -781,6 +781,15 @@
 "ostype": "CentOS 5.6 (64-bit)"
 
 },
+"coreos_volume": {
+"diskname": "Volume_core",
+
"urlvmware":"http://10.147.28.7/templates/coreos/coreos_production_vmware.ova";,
--- End diff --

@remibergsma  Removed the link and added a public link  like 

http://dl.openvm.eu/cloudstack/coreos/x86_64/coreos_production_cloudstack_image-vmware.ova


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1401: automated 9277 9276 9275 9274 9273 9179 9178 ...

2017-02-17 Thread shwetaag
Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r101708093
  
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -790,6 +799,26 @@
 "format": "OVA",
 "ispublic": "true"
 },
+"CentOS7template": {
+"displaytext": "Centos",
+"name": "Centos",
+"passwordenabled": False,
+"isdynamicallyscalable":True,
+"ostype": "CentOS 7",
+"url": "http://10.147.28.7/templates/cenots7/Centos7.vhd";,
--- End diff --

Changed the file location to public available link


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1401: automated 9277 9276 9275 9274 9273 9179 9178 ...

2017-02-17 Thread shwetaag
Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r101708141
  
--- Diff: test/integration/component/maint/test_escalations_instances.py ---
@@ -0,0 +1,270 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#Import Local Modules
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  get_hypervisor_type)
+from marvin.lib.base import (Account,
+ VirtualMachine,
+ ServiceOffering,
+ Volume,
+ DiskOffering,
+ Template,
+ listConfigurations,Configurations)
+from marvin.lib.common import (get_domain,list_isos,
+   get_zone,
+   get_template)
+from nose.plugins.attrib import attr
+from ast import literal_eval
+from marvin.codes import PASS
+from marvin.cloudstackException import CloudstackAPIException
+from marvin.sshClient import SshClient
+from marvin.cloudstackException import CloudstackAPIException
+import time
+
+class TestInstance(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+try:
+cls._cleanup = []
+cls.testClient = super(TestInstance, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.services = cls.testClient.getParsedTestDataConfig()
+# Get Domain, Zone, Template
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+if cls.zone.localstorageenabled:
+cls.storagetype = 'local'
+cls.services["service_offerings"]["tiny"]["storagetype"] = 
'local'
+cls.services["disk_offering"]["storagetype"] = 'local'
+else:
+cls.storagetype = 'shared'
+cls.services["service_offerings"]["tiny"]["storagetype"] = 
'shared'
+cls.services["disk_offering"]["storagetype"] = 'shared'
+
+cls.services['mode'] = cls.zone.networktype
+cls.services["virtual_machine"]["hypervisor"] = 
cls.testClient.getHypervisorInfo()
+cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+cls.services["virtual_machine"]["template"] = cls.template.id
+cls.services["custom_volume"]["zoneid"] = cls.zone.id
+# Creating Disk offering, Service Offering and Account
+cls.disk_offering = DiskOffering.create(
+cls.api_client,
+cls.services["disk_offering"]
+)
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+cls.services["service_offerings"]["small"]
+)
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+domainid=cls.domain.id
+)
+# Getting authentication for user in newly created Account
+cls.user = cls.account.user[0]
+cls.userapiclient = 
cls.testClient.getUserApiClient(cls.user.username, cls.domain.name)
+cls._cleanup.append(cls.disk_offering)
+cls._cleanup.append(cls.service_offering)
+cls._cleanup.append(cls.account)
+cls.mgtSvrDetails = cls.config.__dict__["mgtSvr"][0].__dict__
+except Exception as e:
+cls.tearDownClass()
+raise Exceptio

Re: apidocs build failure

2017-02-17 Thread Rajani Karuturi
since travis is already verifying this, I asked infra to disable
this job.

Infra ticket https://issues.apache.org/jira/browse/INFRA-13527

Please comment on the ticket if you think otherwise.

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On February 13, 2017 at 12:29 PM, Rohit Yadav
(rohit.ya...@shapeblue.com) wrote:

Jenkins need to have jdk8 available, someone need to setup jenv
on it as well.

(The first job in Travis does apidocs/marvin/rat related checks
to validate changes and apidocs build).

Regards.


From: Rajani Karuturi 
Sent: 09 February 2017 12:21:40
To: dev@cloudstack.apache.org
Subject: apidocs build failure

Hi all,

All the apidocs builds[1] are failing after the recent java 8
change. Can anyone having access fix it? Or should we talk to
INFRA about it?

Error message:

[INFO]
-
[ERROR] COMPILATION ERROR : [INFO]
-
[ERROR] javac: invalid target release: 1.8 Usage: javac use
-help
for a list of possible options

[1] https://builds.apache.org/job/cloudstack-apidocs-master/

Thanks

~ Rajani

http://cloudplatform.accelerite.com/

rohit.ya...@shapeblue.com
www.shapeblue.com ( http://www.shapeblue.com )
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request #1401: automated 9277 9276 9275 9274 9273 9179 9178 ...

2017-02-17 Thread shwetaag
Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r101708208
  
--- Diff: test/integration/component/test_escalations_instances.py ---
@@ -2068,6 +2068,94 @@ def test_13_vm_nics(self):
 "VM NIC is not same as expected"
 )
 return
+@attr(tags=["advanced", "basic"], required_hardware="true")
+def test_14_Create_vm_with_same_sshkey(self):
+"""
+@Desc: Test to verify API call Register ssh key pair fails when 
uses same public key for differnet key name
+"""
+
+
+# Listing all the SSH Key pairs
+list_keypairs_before = SSHKeyPair.list(
+self.userapiclient
+)
+list_keypairs_before_size = 0
+if list_keypairs_before is not None:
+list_keypairs_before_size = len(list_keypairs_before)
+
+# Registering first Key pair
+new_keypair1 = SSHKeyPair.register(
+self.userapiclient,
+name="keypair1",
+publickey="ssh-rsa: 
e6:9a:1e:b5:98:75:88:5d:56:bc:92:7b:43:48:05:b2")
+self.assertIsNotNone(
+new_keypair1,
+"New Key pair generation failed"
+)
+self.assertEquals(
+"keypair1",
+new_keypair1.name,
+"Key Pair not created with given name"
+)
+# Listing all the SSH Key pairs again
+list_keypairs_after = SSHKeyPair.list(
+self.userapiclient
+)
+status = validateList(list_keypairs_after)
+self.assertEquals(
+PASS,
+status[0],
+"Listing of Key pairs failed"
+)
+# Verifying that list size is increased by 1
+self.assertEquals(
+list_keypairs_before_size + 1,
+len(list_keypairs_after),
+"List count is not matching"
+)
+try:
+
+# Registering second key pair using same public key
+new_keypair2 = SSHKeyPair.register(
+self.userapiclient,
+name="keypair2",
+publickey="ssh-rsa: 
e6:9a:1e:b5:98:75:88:5d:56:bc:92:7b:43:48:05:b2")
+self.fail("SSH Key creation passed using same public key ")
+except CloudstackAPIException  as e:
+self.assertRaises("Exception Raised : %s" % e)
--- End diff --

Moved assertRaise in the end of the test case to execute the case completely


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1857: CLOUDSTACK-8284: On expunge VM, initiate resource co...

2017-02-17 Thread adwaitpatankar
Github user adwaitpatankar commented on the issue:

https://github.com/apache/cloudstack/pull/1857
  
@ustcweizhou, the issue is that the resource count at domain level are not 
getting updated implicitly after expunge VM call. If the user tries to add a 
new instance, and if the primary storage resource count is not up to date, then 
it results in a false alarm (exception) and not allowing the user to create a 
guest instance even though the requested storage space is withing the limits of 
the domain quota.
When we do not pass accountID (as per the fix), the resource counts would 
be getting calculated on expungeVM event at Domain level which is the 
expectation as per the ticket. Also when the resource calculation is done at 
Domain level, all resource counts for all accounts within that domain are 
recalculated as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1401: automated 9277 9276 9275 9274 9273 9179 9178 ...

2017-02-17 Thread shwetaag
Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r101708342
  
--- Diff: test/integration/component/test_project_usage.py ---
@@ -1819,3 +1844,183 @@ def test_01_vpn_usage(self):
 "Check VPN.USER.ADD in events table"
 )
 return
+
+class TestVMSnapshotUsage(cloudstackTestCase):
+
+@classmethod
+def setUpClass(cls):
+cls.testClient = super(TestVMSnapshotUsage, cls).getClsTestClient()
+cls.api_client = cls.testClient.getApiClient()
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+cls.snapshotSupported = True
+cls._cleanup = []
+if cls.hypervisor.lower() in ['hyperv', 'lxc', 'kvm','baremetal']:
+cls.snapshotSupported = False
+return
+cls.services = Services().services
+# Get Zone, Domain and templates
+cls.domain = get_domain(cls.api_client)
+cls.zone = get_zone(cls.api_client, 
cls.testClient.getZoneForTests())
+cls.services['mode'] = cls.zone.networktype
+cls.hypervisor = cls.testClient.getHypervisorInfo()
+template = get_template(
+cls.api_client,
+cls.zone.id,
+cls.services["ostype"]
+)
+cls.services["server"]["zoneid"] = cls.zone.id
+
+cls.services["template"] = template.id
+
+# Create Account, VMs etc
+cls.account = Account.create(
+cls.api_client,
+cls.services["account"],
+domainid=cls.domain.id
+)
+
+cls.services["account"] = cls.account.name
+
+cls.project = Project.create(
+ cls.api_client,
+ cls.services["project"],
+ account=cls.account.name,
+ domainid=cls.account.domainid
+ )
+
+cls.service_offering = ServiceOffering.create(
+cls.api_client,
+
cls.services["service_offering"]
+)
+cls.virtual_machine = VirtualMachine.create(
+cls.api_client,
+cls.services["server"],
+templateid=template.id,
+serviceofferingid=cls.service_offering.id,
+projectid=cls.project.id
+)
+cls._cleanup = [
+cls.project,
+cls.service_offering,
+cls.account,
+]
+return
+
+@classmethod
+def tearDownClass(cls):
+try:
+#Cleanup resources used
+cleanup_resources(cls.api_client, cls._cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+def setUp(self):
+self.apiclient = self.testClient.getApiClient()
+self.dbclient = self.testClient.getDbConnection()
+self.cleanup = []
+if not self.snapshotSupported:
+self.skipTest("Snapshots are not supported on %s" % 
self.hypervisor)
+return
+
+def tearDown(self):
+try:
+#Clean up, terminate the created instance and snapshots
+cleanup_resources(self.apiclient, self.cleanup)
+except Exception as e:
+raise Exception("Warning: Exception during cleanup : %s" % e)
+return
+
+@attr(speed = "slow")
+@attr(tags=["advanced", "basic", "sg", "eip", "advancedns", 
"simulator"], required_hardware="false")
--- End diff --

Done



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1401: automated 9277 9276 9275 9274 9273 9179 9178 ...

2017-02-17 Thread shwetaag
Github user shwetaag commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1401#discussion_r101708312
  
--- Diff: test/integration/component/test_project_usage.py ---
@@ -221,10 +219,35 @@ def test_01_vm_usage(self):
 #VM.Destroy and volume .delete Event for the created account
 # 4. Delete the account
 
+projectlist=Project.list(self.apiclient,account=self.account.name,
+ 
domainid=self.account.domainid,id=self.project.id)
+
+self.assertEqual(projectlist[0].vmrunning,0,"vmrunning value is 
not returned")
--- End diff --

added hasattr function to verify attributes presence


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1857: CLOUDSTACK-8284: On expunge VM, initiate resource co...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1857
  
@adwaitpatankar oh, I totally understand the issue and the change you made. 
You are right as I remember. However, I think the recalculation on other 
accounts in the domain is not necessary ( we also thought about this change 
before), so please test my suggestion in previous comment if possible.

by the way, the issue also exists in 
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@rhtyd As 4.9 is LTS version, it seems not good to drop ubuntu 12.04 
support in next minor release (4.9.3 ?), some customers may still use ubuntu 
12.04 as management server.

I will aim to add this support from 4.10.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@ustcweizhou makes sense, in that case please close this PR and open a new 
PR for 4.10/master that adds support for cloudstack mgmt server on ubuntu 
16.04, dropping support for 12.04 etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread wido
Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@ustcweizhou @rhtyd Seems good to me. Let's drop 12.04 support in 4.10

Java 8 anyway which is not supported on 12.04, so we will need to drop it.

If we just can get rid of 14.04 then I'm very happy (joke). Everything 
systemd :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
we got this failure when installing cloudstack-management

```
root@pr1916-t848-kvm-ubuntu-mgmt1:~# apt-get install cloudstack-management
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 cloudstack-management : Depends: init-system-helpers (>= 1.18~) but 1.14 
is to be installed
E: Unable to correct problems, you have held broken packages.
```
installing on 14.04


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
@borisstoyanov  It is weird I did not specify the minimal version of 
init-system-helpers in debian/control. Did you build the packages on ubuntu 
16.04 and install it on ubuntu 14.04 ?

by the way, could you tell me what command you use to build the packages ? 
dpkg-buildpackage or packaging/build-deb.sh ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1948: Faster IP in subnet check

2017-02-17 Thread ProjectMoon
GitHub user ProjectMoon opened a pull request:

https://github.com/apache/cloudstack/pull/1948

Faster IP in subnet check

This change removes the conversion from IPNetwork to list in one of the 
router scripts. This makes the router faster at processing static NAT rules, 
which can prevent timeouts when attaching or detaching IPs.

With the `list` conversion, it has to potentially check a list of 65536 IP 
strings multiple times. We assume that the comparison implemented in the 
IPNetwork is far more efficient. We have seen speed-up from 218 seconds to 
enable static NAT with 18 IPs on the router to 2 or 3 seconds by removing this 
cast. This also fixes a potential bug where adding IPs to a router time out 
because the scripts are taking too long. 218 seconds, for example, is beyond 
the timeout on the KVM agent for script execution, and then all enableStaticNat 
operations will fail.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/greenqloud/cloudstack pr-faster-static-nats

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1948.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1948


commit bd288ccc233775ce4bd5b67718c4e20611234d24
Author: Stefania 
Date:   2017-02-08T16:01:34Z

Faster ip in subnet check

This change removes an unnecessary conversion from IPNetwork
to list in one of the router scripts. This makes the router
faster at processing static NAT rules, which can prevent
timeouts when attaching or detaching IPs.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: apidocs build failure

2017-02-17 Thread Rohit Yadav
Thanks Rajani, I've no objections.


Regards.


From: Rajani Karuturi 
Sent: 17 February 2017 14:07:34
To: dev@cloudstack.apache.org
Subject: Re: apidocs build failure

since travis is already verifying this, I asked infra to disable
this job.

Infra ticket https://issues.apache.org/jira/browse/INFRA-13527

Please comment on the ticket if you think otherwise.

Thanks,

~ Rajani

http://cloudplatform.accelerite.com/

On February 13, 2017 at 12:29 PM, Rohit Yadav
(rohit.ya...@shapeblue.com) wrote:

Jenkins need to have jdk8 available, someone need to setup jenv
on it as well.

(The first job in Travis does apidocs/marvin/rat related checks
to validate changes and apidocs build).

Regards.


From: Rajani Karuturi 
Sent: 09 February 2017 12:21:40
To: dev@cloudstack.apache.org
Subject: apidocs build failure

Hi all,

All the apidocs builds[1] are failing after the recent java 8
change. Can anyone having access fix it? Or should we talk to
INFRA about it?

Error message:

[INFO]
-
[ERROR] COMPILATION ERROR : [INFO]
-
[ERROR] javac: invalid target release: 1.8 Usage: javac use
-help
for a list of possible options

[1] https://builds.apache.org/job/cloudstack-apidocs-master/

Thanks

~ Rajani

http://cloudplatform.accelerite.com/

rohit.ya...@shapeblue.com
www.shapeblue.com ( http://www.shapeblue.com )
53 Chandos Place, Covent Garden, London WC2N 4HSUK
@shapeblue

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 



[GitHub] cloudstack issue #1943: CLOUDSTACK-9339: Send correct network type to router...

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1943
  
I didn't actually find the other PR, otherwise I probably wouldn't have 
submitted this one. But I do think this is cleaner, and more centralized. 
There's no real harm in having both, and having this one will be more likely to 
prevent future problems where someone attempts to send a network type across 
the wire.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
@blueorangutan test centos7 vmware-60u2


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-60u2) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1916: [4.9] CLOUDSTACK-9462: Build packages on Ubuntu 12.0...

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1916
  
used dpkg-buildpackage 
the docker container just for the build is 16.04
but @rhtyd reports he's able to install this package on his local 14.04


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1949: Cruds2

2017-02-17 Thread shwetaag
GitHub user shwetaag opened a pull request:

https://github.com/apache/cloudstack/pull/1949

Cruds2

Addressed all review comments. Changed all URL to pubic available url where 
ever possible . For few  tests needing rhel7 template or windows server 
templates added a comment in test case to provide a valid urls for those 
templates before executing those test cases

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shwetaag/cloudstack cruds2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1949.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1949


commit 3e3a403208d07a2cbd61da916224a4ffda17fbc7
Author: shweta agarwal 
Date:   2016-02-04T06:49:39Z

automated 9277 9276 9275 9274 9273 9179 9178 9177

commit 15badc456b039ab40378c30df7285cf638cc1fd7
Author: shweta 
Date:   2017-02-17T10:03:45Z

Adressed review comment for automating bugs 9277 9276 9275 9274 9273 9179 
9178 9177




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1950: CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/1950

CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support 
tomcat6/tomcat7

Changes
(1) add systemd support in debian/control and debian/rules for 16.04
(2) add python-setuptools in Build-Depends in debian/control
(3) seperate cloudstack-management.service and 
cloudstack-management.default for CentOS7 and Ubuntu 16.04
(4) add server7-ssl.xml and server7-nonssl.xml in management installation
(5) link /usr/share/cloudstack-management/lib and 
/usr/share/cloudstack-management/bin to correct path (tomcat6 or tomcat7)
(6) link /etc/cloudstack/management/server.xml to correct file path 
(server-nonssl.xml or server7-nonssl.xml)
(7) remove *.zip from .gitignore to avoid build error caused by missing 
/vhds/test.vhd.zip

Instruction
(1) build packages on Ubuntu 16.04: dpkg-buildpackage -uc -us
Output on Ubuntu 16.04:
-rw-r--r-- 1 root root  4090 Feb 17 10:12 
cloudstack_4.10.0.0-SNAPSHOT_amd64.changes
-rw-r--r-- 1 root root  1235 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.dsc
-rw-r--r-- 1 root root   8018248 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.tar.xz
-rw-r--r-- 1 root root  91868746 Feb 17 10:11 
cloudstack-agent_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52882 Feb 17 10:12 
cloudstack-cli_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  98556216 Feb 17 10:08 
cloudstack-common_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52864 Feb 17 10:12 
cloudstack-docs_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root585434 Feb 17 10:12 
cloudstack-integration-tests_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 323459934 Feb 17 10:10 
cloudstack-management_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root442656 Feb 17 10:12 
cloudstack-marvin_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  87037576 Feb 17 10:12 
cloudstack-usage_4.10.0.0-SNAPSHOT_all.deb

(2) setup tomcat6/tomcat7 on management server:
tomcat6: cloudstack-setup-management --tomcat6
tomcat7: cloudstack-setup-management --tomcat7

Already tested on Ubuntu 16.04, upgraded from 4.7.1 to 4.10.0.0-SNAPSHOT

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 4.10-ubuntu16-systemd

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1950


commit fb3d78a96ee886679699a5d5e041f198c54b978f
Author: Wei Zhou 
Date:   2017-02-17T08:59:52Z

CLOUDSTACK-9462: Build packages on Ubuntu 14.04/16.04 and support 
tomcat6/tomcat7

Changes
(1) add systemd support in debian/control and debian/rules for 16.04
(2) add python-setuptools in Build-Depends in debian/control
(3) seperate cloudstack-management.service and 
cloudstack-management.default for CentOS7 and Ubuntu 16.04
(4) add server7-ssl.xml and server7-nonssl.xml in management installation
(5) link /usr/share/cloudstack-management/lib and 
/usr/share/cloudstack-management/bin to correct path (tomcat6 or tomcat7)
(6) link /etc/cloudstack/management/server.xml to correct file path 
(server-nonssl.xml or server7-nonssl.xml)
(7) remove *.zip from .gitignore to avoid build error caused by missing 
/vhds/test.vhd.zip

Instruction
(1) build packages on Ubuntu 16.04: dpkg-buildpackage -uc -us
Output on Ubuntu 16.04:
-rw-r--r-- 1 root root  4090 Feb 17 10:12 
cloudstack_4.10.0.0-SNAPSHOT_amd64.changes
-rw-r--r-- 1 root root  1235 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.dsc
-rw-r--r-- 1 root root   8018248 Feb 17 09:53 
cloudstack_4.10.0.0-SNAPSHOT.tar.xz
-rw-r--r-- 1 root root  91868746 Feb 17 10:11 
cloudstack-agent_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52882 Feb 17 10:12 
cloudstack-cli_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  98556216 Feb 17 10:08 
cloudstack-common_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 52864 Feb 17 10:12 
cloudstack-docs_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root585434 Feb 17 10:12 
cloudstack-integration-tests_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root 323459934 Feb 17 10:10 
cloudstack-management_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root442656 Feb 17 10:12 
cloudstack-marvin_4.10.0.0-SNAPSHOT_all.deb
-rw-r--r-- 1 root root  87037576 Feb 17 10:12 
cloudstack-usage_4.10.0.0-SNAPSHOT_all.deb

(2) setup tomcat6/tomcat7 on management server:
tomcat6: cloudstack-setup-management --tomcat6
tomcat7: cloudstack-setup-management --tomcat7

Already tested on Ubuntu 16.04, upgraded from 4.7.1 to 4.10.0-SNAPSHOT




---
If your project is s

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-17 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1873
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 351
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-503


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@blueorangutan test ubuntu kvm-ubuntu


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
@borisstoyanov a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1949: Cruds2

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1949
  
@shwetaag Hi, I'm sorry but I don't get what is this PR for? Are these some 
internal issues that you're referring to? Each PR should start with an ACS JIRA 
ticket number and should be followed by a description of what it is about. I've 
noticed you're committing some tests, can you please give an overview what are 
they about.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread rhtyd
GitHub user rhtyd opened a pull request:

https://github.com/apache/cloudstack/pull/1951

CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

This adds an upgrade path from 4.9.2.0 to 4.9.3.0, this also includes 
changes from PR https://github.com/apache/cloudstack/pull/1928 that adds 
missing hypervisor capability in 4.9/4.10+. This also fixes a db-cleanup path 
sequence issues, with that puts 4.10 after 4.1.0, and before 4.2.0.

Once validated I can help merge this on master, since this will cause merge 
conflicts on fwd-merging.

Ping - @syed @karuturi @borisstoyanov @DaanHoogland @abhinandanprateek 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack 4930-upgradepath

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1951.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1951


commit 8d876206d46fdbce7a5247df0447abf6b9764221
Author: Rohit Yadav 
Date:   2017-02-17T11:02:10Z

CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread rhtyd
Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1951#discussion_r101735670
  
--- Diff: setup/db/db/schema-4920to4930.sql ---
@@ -0,0 +1,22 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership.  The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License.  You may obtain a copy of the License at
+--
+--   http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied.  See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+--;
+-- Schema upgrade from 4.9.2.0 to 4.9.3.0;
+--;
+
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, 
hypervisor_type, hypervisor_version, max_guests_limit, max_data_volumes_limit, 
storage_motion_supported) values (UUID(), 'XenServer', '7.0.0', 500, 13, 1);
--- End diff --

Note: On fwd merging, this can be re-executed in 4.9.2.0->4.10.0.0 upgrade 
path.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
Thanks @borisstoyanov test results LGTM.
/cc @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1949: Cruds2

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1949#discussion_r101735942
  
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -121,7 +121,7 @@
 "name": "LargeInstance",
 "displaytext": "LargeInstance",
 "cpunumber": 1,
-"cpuspeed": 500,
+"cpuspeed": 1024,
--- End diff --

while appending to this list could be fairly non fragile to tests, editing 
existing entries can be extremely fragile to other tests that are using it. We 
need to be sure this does not brake any of the smoketests, since they are our 
main source of verifying PRs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r101736186
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -175,6 +176,8 @@
 @Inject
 private IPAddressDao _ipAddressDao;
 @Inject
+private FirewallRulesDao _firewallsDao;
--- End diff --

There is already a `FirewallRulesDao` in the file. No need to inject this 
one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1949: Cruds2

2017-02-17 Thread shwetaag
Github user shwetaag commented on the issue:

https://github.com/apache/cloudstack/pull/1949
  
@borisstoyanov  This PR is about automating these 8 cloudstack bugs.  
automated these 8 test bugs 9277 9276 9275 9274 9273 9179 9178 9177

- Test to verify Scale CentOS7 VM does not fails with error "Cannot 
scale up the vm because of memory constraint violation"
- Test to verify Private template is visible in project
- Test to verify attaching 7th Disk to windows server 2012R2 instance
- API listVMSnapshot returns value for tags ‘project’ and 
‘projectid’ when called with project id param
- 'listProjects' doesn't return tags 'vmstopped' or 'vmrunning' when 
their value is zero
- Verify register ssh key pair can not be used to register same ssh 
keys with different name
- Verify correct Guest OS (RHEL 7) Mapping for vmware
- Atomation of Usage events for "uploadedVolume"

the details of these bugs can be seen in related bugs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1949: Cruds2

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1949
  
Thank you @shwetaag can you please edit the PR description


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: Faster IP in subnet check

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
@ProjectMoon thank you for this PR, is there an ACS JIRA issue for this 
change, if so it'll be good to add it in the title same as the other PRs. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: Faster IP in subnet check

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
We have not entered one into JIRA, no. But we can.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-504


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @jburwell ,
Thanks for teaching me something new. Test is also added. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: Faster IP in subnet check

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
Thanks @ProjectMoon 
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: Faster IP in subnet check

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
@borisstoyanov an explicit integration test is not necessary if Travis 
passes, since all changes are around db upgrade/version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
Just want to confirm it fresh installs and upgrades the DB to 4.9.3. will 
cancel the run after as I'm planning to do an upgrade scenario as well. 
Thanks @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar 
1. the file change from 10644 to 10755 is not necessary
2. the default value of forced is false, might cause issue on backwards 
compatibility
3. In the vm installation, as the template is still in use , so we can find 
it in the storage pool where the root disk is located. We need to improve it by 
using the existing template image on storage pool, or copying the template from 
storage pool where the root disk is located to another new storage pool (pool 
of allocated new root disk).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread priyankparihar
Github user priyankparihar commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
Hi @jburwell , 
Would like to add something on @ustcweizhou comment ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1838: CLOUDSTACK-9682: Block VM migration to a storage whi...

2017-02-17 Thread karuturi
Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1838
  
merging


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: Faster IP in subnet check

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-505


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1952: CLOUDSTACK-9790: fix NPE in case of Basic zon...

2017-02-17 Thread sgoeminn
GitHub user sgoeminn opened a pull request:

https://github.com/apache/cloudstack/pull/1952

CLOUDSTACK-9790: fix NPE in case of Basic zone.

This PR fixes the creation of a basic zone.
https://issues.apache.org/jira/browse/CLOUDSTACK-9790

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sgoeminn/cloudstack CLOUDSTACK-9790

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1952.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1952


commit a01f7e76c34342974749e90a64c062b304a39bd1
Author: Sigert Goeminne 
Date:   2017-02-17T10:05:58Z

CLOUDSTACK-9790: fix NPE in case of Basic zone.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1838: CLOUDSTACK-9682: Block VM migration to a stor...

2017-02-17 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1838


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Can't create a zone using master

2017-02-17 Thread Sigert GOEMINNE
Hi all,

We have a new PR that fixes this issue:
https://github.com/apache/cloudstack/pull/1952

Kind regards,

*Sigert Goeminne*
Software Development Engineer

*nuage*networks.net
Copernicuslaan 50
2018 Antwerp
Belgium




On Fri, Feb 17, 2017 at 8:55 AM, Kris Sterckx <
kris.ster...@nuagenetworks.net> wrote:

> Thanks Mike
>
> Investigating.
>
> Kris
>
> On 17 February 2017 at 08:18, Tutkowski, Mike 
> wrote:
>
> > I added a comment on the code of the relevant PR, but the PR is in the
> > Merged state, so I don't know if people receive e-mail notifications
> then.
> >
> > > On Feb 17, 2017, at 12:16 AM, Wei ZHOU  wrote:
> > >
> > > Maybe we need ask Nuage why the lines are added.
> > >
> > >
> > > 2017-02-17 7:54 GMT+01:00 Tutkowski, Mike :
> > >
> > >> Hopefully we can now find someone with experience in CloudStack's
> > >> networking code to tell us if that fix is OK or if that was just a
> > Band-Aid
> > >> and we should do something more thorough to correct the issue.
> > >>
> > >>> On Feb 16, 2017, at 11:48 PM, Rajani Karuturi 
> > wrote:
> > >>>
> > >>> Thanks for digging it Mike.
> > >>>
> > >>> ~ Rajani
> > >>>
> > >>> http://cloudplatform.accelerite.com/
> > >>>
> > >>> On February 17, 2017 at 12:18 AM, Tutkowski, Mike
> > >>> (mike.tutkow...@netapp.com) wrote:
> > >>>
> > >>> Hi,
> > >>>
> > >>> I opened a blocker for 4.10 regarding this issue:
> > >>>
> > >>> https://issues.apache.org/jira/browse/CLOUDSTACK-9790
> > >>>
> > >>> Thanks,
> > >>> Mike
> > >>>
> > >>> On 2/16/17, 8:35 AM, "Tutkowski, Mike"
> > >>>  wrote:
> > >>>
> > >>> I believe the issue is here:
> > >>>
> > >>> https://github.com/apache/cloudstack/pull/1579
> > >>>
> > >>> In ConfigurationManagerImpl.java, it appears the lines that led
> > >>> to NPEs being thrown were added on lines 2924 – 2926:
> > >>>
> > >>> https://github.com/apache/cloudstack/pull/1579/files
> > >>>
> > >>> On 2/16/17, 2:42 AM, "Wido den Hollander" 
> > >>> wrote:
> > >>>
> >  Op 16 februari 2017 om 6:21 schreef Rajani Karuturi
> > >>> :
> > 
> > 
> >  unfortunately, running one set of tests itself is very time
> >  consuming(multiplied by hypervisors, network modes etc. its
> >  impossible to run all)
> > 
> >  If I remember correctly, wido tested it with PR 1700 (IPV6 in
> >  basic networking)
> > 
> > >>>
> > >>> I highly doubt it's PR 1700 which is causing this. The PR I have
> > >>> open to fix a issue ONLY applies if IPv6 has been set.
> > >>>
> > >>> PR 1700 only does something when you have set a IPv6 subnet in
> > >>> the 'vlan' table:
> > >>> https://github.com/apache/cloudstack/commit/
> > >> c0e7766713b2631a167c2ceea7d42b574a5cd1b9#diff-
> > >> f90fdac6810fd89f89e827309a41d180R231
> > >>>
> > >>> So I don't think it's caused by this since you NIC table will
> > >>> not be filled with IPv6 addresses afterwards.
> > >>>
> > >>> Wido
> > >>>
> >  Can you try a commit before and a commit after that PR?
> > 
> >  Thanks,
> > 
> >  ~ Rajani
> > 
> >  http://cloudplatform.accelerite.com/
> > 
> >  On February 16, 2017 at 1:02 AM, Tutkowski, Mike
> >  (mike.tutkow...@netapp.com) wrote:
> > 
> >  Thanks for noting that PR, Rene. I tried building a Basic Zone
> >  making use of code from that PR, but – unfortunately – I still
> >  get an exception (below).
> > 
> >  On a related note, does this mean we don’t run any integration
> >  tests that build a Basic Zone before we OK a PR to be checked
> > >>> in?
> > 
> >  ERROR [c.c.a.ApiServer] (qtp555984412-267:ctx-a904cbd0
> >  ctx-062a000a) (logid:30f5a3ec) unhandled exception executing
> > >>> api
> >  command: [Ljava.lang.String;@4732a98c
> >  java.lang.NullPointerException
> >  at
> >  com.cloud.utils.net.NetUtils.getCidrNetmask(NetUtils.java:956)
> >  at
> > 
> > >>> com.cloud.configuration.ConfigurationManagerImpl.validateIpRange(
> > >> ConfigurationManagerImpl.java:2924)
> >  at
> > 
> > >>> com.cloud.configuration.ConfigurationManagerImpl.
> > >> createVlanAndPublicIpRange(ConfigurationManagerImpl.java:2822)
> >  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> >  at
> > 
> > >>> sun.reflect.NativeMethodAccessorImpl.invoke(
> > >> NativeMethodAccessorImpl.java:62)
> >  at
> > 
> > >>> sun.reflect.DelegatingMethodAccessorImpl.invoke(
> > >> DelegatingMethodAccessorImpl.java:43)
> >  at java.lang.reflect.Method.invoke(Method.java:498)
> >  at
> > 
> > >>> org.springframework.aop.support.AopUtils.
> > invokeJoinpointUsingReflection
> > >> (AopUtils.java:333)
> >  at
> > 
> > >>> org.springframework.aop.framework.ReflectiveMethodInvocation.
> > >> invokeJoinpoint(ReflectiveMethodInvocation.java:190)
> >  at
> > 
> > >>> org.springframework.aop.framework.ReflectiveMethodInvocation.
> proceed(
> > >> ReflectiveMethodInvocation.java:157)
> >  at
> > 
> > >>> org.apache.cloudstack.netwo

[GitHub] cloudstack issue #1952: CLOUDSTACK-9790: fix NPE in case of Basic zone.

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1952
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: PRs for 4.10

2017-02-17 Thread Frank Maximus
I have a couple of bugfixes on previous version outstanding,
which I would like to have merged to 4.10,
both still requiring review:
on 4.8: PR#1912 : which
fixes password service running on internal lb vms, making it impossible to
do loadbalancing on port 8080
on 4.9: PR#1925 : Minor
plugin fix

Kind Regards,
Frank

On Tue, Feb 14, 2017 at 10:56 PM Syed Ahmed  wrote:

I'd like to include https://github.com/apache/cloudstack/pull/1928 to 4.10
as well. This is a simple fix that adds hypervisor capabilities for
XenServer 7

Thanks,
-Syed

On Tue, Feb 14, 2017 at 12:06 AM, Will Stevens 
wrote:

> Not sure, I will see if I can find some time tomorrow to look at this.
> Thanks...
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Mon, Feb 13, 2017 at 11:58 PM, Rajani Karuturi 
> wrote:
>
> > Thanks Will. I will take a look at this today and merge.
> >
> > Is it possible to add a systemvmtemplate job on
> > builds.apachecloudstack.net (https://builds.cloudstack.org/)
> > similar to
> > http://jenkins.buildacloud.org/job/build-systemvm64-master/ ?
> >
> > Thanks,
> >
> > ~ Rajani
> >
> > http://cloudplatform.accelerite.com/
> >
> > On February 13, 2017 at 10:46 PM, Will Stevens
> > (wstev...@cloudops.com) wrote:
> >
> > At this point, I think 1741 is ready to merge. I think we need
> > one more
> > LGTM though...
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Wed, Feb 8, 2017 at 11:32 AM, Will Stevens
> >  wrote:
> >
> > @Daan: In order for the tests to pass with 1741, the tests have
> > to be run
> > with the SystemVM from the PR being used.
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > 
> >
> > On Wed, Feb 8, 2017 at 2:46 AM, Daan Hoogland
> > 
> > wrote:
> >
> > About 1741, I started the packaging, Will but saw Boris making a
> > remark about the system VMs. I'll look into that and start the
> > tests.
> >
> > On Tue, Feb 7, 2017 at 8:19 PM, Will Stevens
> > 
> > wrote:
> >
> > I would like to get 1741(strongswan) in, but I need to get
> > Trillian to
> >
> > run
> >
> > against it with a system vm built from my pr. I have done a CI in
> > bubble
> > and it came back clean, but would like confirmation through
> > Trillian as
> > well.
> >
> > On Feb 7, 2017 2:17 PM, "Milamber"  wrote:
> >
> > And this PR for 4.9 but need to be foward to 4.10 too.
> >
> > https://github.com/apache/cloudstack/pull/1929
> >
> > 2 LGTM
> > CI green
> >
> > On 07/02/2017 13:07, Rajani Karuturi wrote:
> >
> > Hi all,
> > If you know of any PRs which meet the below criteria, please
> > mail
> >
> > them to
> >
> > me.
> > 1. No open questions.
> > 2. Has two LGTMs
> > 3. Has CI test results.
> >
> > ~Rajani
> > http://cloudplatform.accelerite.com
> >
> > --
> > Daan
> >
>


[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-17 Thread ProjectMoon
Github user ProjectMoon commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
Updated with the JIRA ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-17 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1948
  
Thanks, @ProjectMoon I cannot run tests against it since we don't have an 
automated way to build the systemVM. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1856
  
Trillian test result (tid-845)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27608 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1856-t845-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 47 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 355.97 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.01 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.80 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 250.78 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 277.18 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 543.39 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 516.00 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1413.48 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 564.36 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 756.17 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1301.11 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.54 | test_volumes.py
test_08_resize_volume | Success | 156.44 | test_volumes.py
test_07_resize_fail | Success | 161.48 | test_volumes.py
test_06_download_detached_volume | Success | 156.37 | test_volumes.py
test_05_detach_volume | Success | 155.78 | test_volumes.py
test_04_delete_attached_volume | Success | 151.29 | test_volumes.py
test_03_download_attached_volume | Success | 156.33 | test_volumes.py
test_02_attach_volume | Success | 90.50 | test_volumes.py
test_01_create_volume | Success | 711.16 | test_volumes.py
test_deploy_vm_multiple | Success | 267.77 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.73 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.19 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.95 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.15 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.89 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.89 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.19 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 75.75 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.17 | test_templates.py
test_01_create_template | Success | 85.75 | test_templates.py
test_10_destroy_cpvm | Success | 161.72 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.64 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.61 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.58 | test_ssvm.py
test_06_stop_cpvm | Success | 131.85 | test_ssvm.py
test_05_stop_ssvm | Success | 163.97 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.43 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.60 | test_snapshots.py
test_04_change_offering_small | Success | 239.90 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.09 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.11 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 35.33 | test_routers.py
test_08_start_router | Success | 30.29 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.70 | test_routers.py
test_03_restart_network_cleanup | Success | 65.56 | test_routers.py
test_02_router_internal_adv | Success | 1.09 | 

[GitHub] cloudstack pull request #1735: CLOUDSTACK-9570: Bug in listSnapshots for sna...

2017-02-17 Thread nvazquez
Github user nvazquez closed the pull request at:

https://github.com/apache/cloudstack/pull/1735


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2017-02-17 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1735
  
Closing this PR as #1847 includes this changes in a simpler way


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1946
  
Trillian test result (tid-847)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27629 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1946-t847-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 47 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 351.29 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 161.52 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.11 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 261.82 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 279.97 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 537.78 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 513.75 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1418.87 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 568.37 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 759.18 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1302.38 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.41 | test_volumes.py
test_08_resize_volume | Success | 156.31 | test_volumes.py
test_07_resize_fail | Success | 161.42 | test_volumes.py
test_06_download_detached_volume | Success | 156.60 | test_volumes.py
test_05_detach_volume | Success | 155.75 | test_volumes.py
test_04_delete_attached_volume | Success | 151.21 | test_volumes.py
test_03_download_attached_volume | Success | 156.47 | test_volumes.py
test_02_attach_volume | Success | 95.73 | test_volumes.py
test_01_create_volume | Success | 711.63 | test_volumes.py
test_deploy_vm_multiple | Success | 252.62 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.63 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.18 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 55.94 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.12 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.78 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.86 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.33 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 65.69 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 35.37 | test_templates.py
test_10_destroy_cpvm | Success | 191.82 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.95 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.58 | test_ssvm.py
test_07_reboot_ssvm | Success | 134.41 | test_ssvm.py
test_06_stop_cpvm | Success | 137.36 | test_ssvm.py
test_05_stop_ssvm | Success | 133.62 | test_ssvm.py
test_04_cpvm_internals | Success | 1.15 | test_ssvm.py
test_03_ssvm_internals | Success | 3.26 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.14 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.23 | test_snapshots.py
test_04_change_offering_small | Success | 242.59 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.05 | test_service_offerings.py
test_01_create_service_offering | Success | 0.10 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.70 | test_routers.py
test_08_start_router | Success | 30.29 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py
test_06_router_advanced | Success | 0.05 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.71 | test_routers.py
test_03_restart_network_cleanup | Success | 55.50 | test_routers.py
test_02_router_internal_adv | Success | 1.04 | 

[GitHub] cloudstack issue #1770: CLOUDSTACK-9628: Fix Template Size in Swift as Secon...

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1770
  
Trillian test result (tid-844)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31937 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1770-t844-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 320.42 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 140.37 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 56.12 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 251.17 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 248.68 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 505.77 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 505.11 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1418.45 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 542.83 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 750.52 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1273.29 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.48 | test_volumes.py
test_08_resize_volume | Success | 156.38 | test_volumes.py
test_07_resize_fail | Success | 161.65 | test_volumes.py
test_06_download_detached_volume | Success | 156.32 | test_volumes.py
test_05_detach_volume | Success | 241.28 | test_volumes.py
test_04_delete_attached_volume | Success | 151.24 | test_volumes.py
test_03_download_attached_volume | Success | 156.51 | test_volumes.py
test_02_attach_volume | Success | 124.27 | test_volumes.py
test_01_create_volume | Success | 711.36 | test_volumes.py
test_deploy_vm_multiple | Success | 232.65 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.76 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.16 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 35.92 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.14 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.84 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.88 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.16 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.31 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 50.51 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.16 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.14 | test_templates.py
test_01_create_template | Success | 55.51 | test_templates.py
test_10_destroy_cpvm | Success | 161.73 | test_ssvm.py
test_09_destroy_ssvm | Success | 133.60 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.56 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.59 | test_ssvm.py
test_06_stop_cpvm | Success | 131.72 | test_ssvm.py
test_05_stop_ssvm | Success | 138.72 | test_ssvm.py
test_04_cpvm_internals | Success | 1.19 | test_ssvm.py
test_03_ssvm_internals | Success | 3.59 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.24 | test_snapshots.py
test_04_change_offering_small | Success | 209.66 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.15 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.19 | test_secondary_storage.py
test_09_reboot_router | Success | 40.34 | test_routers.py
test_08_start_router | Success | 30.29 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success | 5.73 | test_routers.py
test_03_restart_network_cleanup | Success 

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread leprechau
Github user leprechau commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
We are seeing issues under heavy user interaction cycles with redundant 
VRs.  In testing you can reliably completely fill the `/var/log/` partition 
with data primarily from `cloud.log` when you create/stop/delete/expunge ~200 
VMs over a 24 hour period with the default settings.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Modify the system vm build scripts

2017-02-17 Thread David Mabry
Hello everyone,

I’m looking at making some changes to the system vm, but I have found that 
there looks like there are 2 different places in the code that “build” the 
systemvm.  There is there is 
https://github.com/apache/cloudstack/tree/13bfdd71e6f52d2f613a802b3d16c9b40af7/systemvm/patches/debian,
 which looks like it might be the “old” way and there is 
https://github.com/apache/cloudstack/tree/87ef8137534fa798101f65c6691fcf71513ac978/tools/appliance/definitions/systemvmtemplate,
 which looks like it might be the “new” way.  If I wanted to make changes to 
how the systemvm is built which place should I modify?  I assume that I should 
modify the build scripts in the “new” location, but I thought I would ask here 
first just to be sure.

--Mabry


[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread dmabry
Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
Agreed with @leprechau .  I don't think just changing logrotate to compress 
and rotate at smaller size intervals will not completely solve our issues here. 
 We really need to adjust logrotate to run every hour, or make cloud.log less 
verbose by default.  I'm looking into seeing if it would be viable to make 
logrotate run every hour, but I believe that will require changing how the 
systemvm image is built by moving logrotate from cron.daily to cron.hourly.  
Not a huge deal, but I think it might be right approach over all since we have 
limited disk space in /var/log.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar I agree with @ustcweizhou . Default behavior should remain 
forced. And in this case Web UI we should give a warning with "yes and no" if 
template has deployed VM so users can cancel the operation if they need to.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modify the system vm build scripts

2017-02-17 Thread Will Stevens
So the System VM is "built" from two sources.

1)
https://github.com/apache/cloudstack/tree/master/tools/appliance/definitions/systemvmtemplate
This defines what is actually built and is distributed as the SystemVM
Template.  You MUST use it if you change the packages included in the
SystemVM template or change the core components in any way.  Changing
anything here REQUIRES a new SystemVM template to be distributed for that
change to be used.

2) https://github.com/apache/cloudstack/tree/master/systemvm/patches/debian
This defines the systemvm.iso which is loaded into the System VM template
after the system vm is deployed.  This basically defines configuration
which can be changed without requiring a new System VM template.  This
section does not handle installation of packages and such, instead it
handles System VM configuration and functionality.  So if settings files
need to be changed (for say something like VPN) or if the way we handle IP
address changes, etc...  That is all handled from here.  The systemvm.iso
is generated by the management server (i think) and is pushed to the system
vm after the system vm boots and the configuration which cloudstack manages
is handled through this code.

Is that clear?  Let me know if you have more questions.  I have had to do a
bunch of stuff in this recently for some of the networking issues we have
had as well as the StrongSwan VPN implementation (which changed both
places).

Using StrongSwan as an example:
I had to modify (1) in order to remove the OpenSwan package installation
and add the StrongSwan package installation.

I had to modify (2) in order to change the configuration of the VPN in
order to handle things the way that StrongSwan needed things done.  So the
changes to things like the `ipsec` command are handled in (2) because those
are configuration changes and not package changes.

Is that clearer?

*Will STEVENS*
Lead Developer



On Fri, Feb 17, 2017 at 11:18 AM, David Mabry  wrote:

> Hello everyone,
>
> I’m looking at making some changes to the system vm, but I have found that
> there looks like there are 2 different places in the code that “build” the
> systemvm.  There is there is https://github.com/apache/cloudstack/tree/
> 13bfdd71e6f52d2f613a802b3d16c9b40af7/systemvm/patches/debian, which
> looks like it might be the “old” way and there is
> https://github.com/apache/cloudstack/tree/87ef8137534fa798101f65c6691fcf
> 71513ac978/tools/appliance/definitions/systemvmtemplate, which looks like
> it might be the “new” way.  If I wanted to make changes to how the systemvm
> is built which place should I modify?  I assume that I should modify the
> build scripts in the “new” location, but I thought I would ask here first
> just to be sure.
>
> --Mabry
>


[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-17 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1847
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 352
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_routers_network_ops.py

 * test_03_RVR_Network_check_router_state Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modify the system vm build scripts

2017-02-17 Thread David Mabry
Awesome.  Thanks for the quick answer.  That totally makes sense.  Package 
changes (installation, etc…) are done in the “appliance” section of code.  Any 
“config” changes required beyond package installation are done in the “patches” 
section of code.

Thanks,
David Mabry

On 2/17/17, 10:52 AM, "williamstev...@gmail.com on behalf of Will Stevens" 
 wrote:

So the System VM is "built" from two sources.

1)

https://github.com/apache/cloudstack/tree/master/tools/appliance/definitions/systemvmtemplate
This defines what is actually built and is distributed as the SystemVM
Template.  You MUST use it if you change the packages included in the
SystemVM template or change the core components in any way.  Changing
anything here REQUIRES a new SystemVM template to be distributed for that
change to be used.

2) https://github.com/apache/cloudstack/tree/master/systemvm/patches/debian
This defines the systemvm.iso which is loaded into the System VM template
after the system vm is deployed.  This basically defines configuration
which can be changed without requiring a new System VM template.  This
section does not handle installation of packages and such, instead it
handles System VM configuration and functionality.  So if settings files
need to be changed (for say something like VPN) or if the way we handle IP
address changes, etc...  That is all handled from here.  The systemvm.iso
is generated by the management server (i think) and is pushed to the system
vm after the system vm boots and the configuration which cloudstack manages
is handled through this code.

Is that clear?  Let me know if you have more questions.  I have had to do a
bunch of stuff in this recently for some of the networking issues we have
had as well as the StrongSwan VPN implementation (which changed both
places).

Using StrongSwan as an example:
I had to modify (1) in order to remove the OpenSwan package installation
and add the StrongSwan package installation.

I had to modify (2) in order to change the configuration of the VPN in
order to handle things the way that StrongSwan needed things done.  So the
changes to things like the `ipsec` command are handled in (2) because those
are configuration changes and not package changes.

Is that clearer?

*Will STEVENS*
Lead Developer



On Fri, Feb 17, 2017 at 11:18 AM, David Mabry  wrote:

> Hello everyone,
>
> I’m looking at making some changes to the system vm, but I have found that
> there looks like there are 2 different places in the code that “build” the
> systemvm.  There is there is https://github.com/apache/cloudstack/tree/
> 13bfdd71e6f52d2f613a802b3d16c9b40af7/systemvm/patches/debian, which
> looks like it might be the “old” way and there is
> https://github.com/apache/cloudstack/tree/87ef8137534fa798101f65c6691fcf
> 71513ac978/tools/appliance/definitions/systemvmtemplate, which looks like
> it might be the “new” way.  If I wanted to make changes to how the 
systemvm
> is built which place should I modify?  I assume that I should modify the
> build scripts in the “new” location, but I thought I would ask here first
> just to be sure.
>
> --Mabry
>




Re: Modify the system vm build scripts

2017-02-17 Thread Will Stevens
Yes. Exactly. The "patches" don't require a new system vm template to be
distributed, but changes to the "appliance" does require a new system vm
template.

On Feb 17, 2017 12:04 PM, "David Mabry"  wrote:

> Awesome.  Thanks for the quick answer.  That totally makes sense.  Package
> changes (installation, etc…) are done in the “appliance” section of code.
> Any “config” changes required beyond package installation are done in the
> “patches” section of code.
>
> Thanks,
> David Mabry
>
> On 2/17/17, 10:52 AM, "williamstev...@gmail.com on behalf of Will
> Stevens" 
> wrote:
>
> So the System VM is "built" from two sources.
>
> 1)
> https://github.com/apache/cloudstack/tree/master/tools/
> appliance/definitions/systemvmtemplate
> This defines what is actually built and is distributed as the SystemVM
> Template.  You MUST use it if you change the packages included in the
> SystemVM template or change the core components in any way.  Changing
> anything here REQUIRES a new SystemVM template to be distributed for
> that
> change to be used.
>
> 2) https://github.com/apache/cloudstack/tree/master/
> systemvm/patches/debian
> This defines the systemvm.iso which is loaded into the System VM
> template
> after the system vm is deployed.  This basically defines configuration
> which can be changed without requiring a new System VM template.  This
> section does not handle installation of packages and such, instead it
> handles System VM configuration and functionality.  So if settings
> files
> need to be changed (for say something like VPN) or if the way we
> handle IP
> address changes, etc...  That is all handled from here.  The
> systemvm.iso
> is generated by the management server (i think) and is pushed to the
> system
> vm after the system vm boots and the configuration which cloudstack
> manages
> is handled through this code.
>
> Is that clear?  Let me know if you have more questions.  I have had to
> do a
> bunch of stuff in this recently for some of the networking issues we
> have
> had as well as the StrongSwan VPN implementation (which changed both
> places).
>
> Using StrongSwan as an example:
> I had to modify (1) in order to remove the OpenSwan package
> installation
> and add the StrongSwan package installation.
>
> I had to modify (2) in order to change the configuration of the VPN in
> order to handle things the way that StrongSwan needed things done.  So
> the
> changes to things like the `ipsec` command are handled in (2) because
> those
> are configuration changes and not package changes.
>
> Is that clearer?
>
> *Will STEVENS*
> Lead Developer
>
> 
>
> On Fri, Feb 17, 2017 at 11:18 AM, David Mabry  wrote:
>
> > Hello everyone,
> >
> > I’m looking at making some changes to the system vm, but I have
> found that
> > there looks like there are 2 different places in the code that
> “build” the
> > systemvm.  There is there is https://github.com/apache/
> cloudstack/tree/
> > 13bfdd71e6f52d2f613a802b3d16c9b40af7/systemvm/patches/debian,
> which
> > looks like it might be the “old” way and there is
> > https://github.com/apache/cloudstack/tree/
> 87ef8137534fa798101f65c6691fcf
> > 71513ac978/tools/appliance/definitions/systemvmtemplate, which
> looks like
> > it might be the “new” way.  If I wanted to make changes to how the
> systemvm
> > is built which place should I modify?  I assume that I should modify
> the
> > build scripts in the “new” location, but I thought I would ask here
> first
> > just to be sure.
> >
> > --Mabry
> >
>
>
>


[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1945
  
Trillian test result (tid-849)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33983 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1945-t849-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Test completed. 47 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 376.30 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 160.15 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.11 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 260.67 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 279.96 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 543.45 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 514.12 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1403.38 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 558.74 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 750.10 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1281.58 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.58 | test_volumes.py
test_08_resize_volume | Success | 156.47 | test_volumes.py
test_07_resize_fail | Success | 161.48 | test_volumes.py
test_06_download_detached_volume | Success | 156.30 | test_volumes.py
test_05_detach_volume | Success | 155.89 | test_volumes.py
test_04_delete_attached_volume | Success | 151.25 | test_volumes.py
test_03_download_attached_volume | Success | 156.75 | test_volumes.py
test_02_attach_volume | Success | 95.46 | test_volumes.py
test_01_create_volume | Success | 711.36 | test_volumes.py
test_deploy_vm_multiple | Success | 247.62 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.68 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.46 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 40.98 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.81 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.93 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.32 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 40.54 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.12 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 25.36 | test_templates.py
test_10_destroy_cpvm | Success | 161.67 | test_ssvm.py
test_09_destroy_ssvm | Success | 168.63 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.56 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.56 | test_ssvm.py
test_06_stop_cpvm | Success | 131.91 | test_ssvm.py
test_05_stop_ssvm | Success | 133.96 | test_ssvm.py
test_04_cpvm_internals | Success | 1.23 | test_ssvm.py
test_03_ssvm_internals | Success | 3.40 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.15 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_01_snapshot_root_disk | Success | 11.24 | test_snapshots.py
test_04_change_offering_small | Success | 239.58 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.05 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.13 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.32 | test_routers.py
test_08_start_router | Success | 30.32 | test_routers.py
test_07_stop_router | Success | 10.28 | test_routers.py
test_06_router_advanced | Success | 0.06 | test_routers.py
test_05_router_basic | Success | 0.04 | test_routers.py
test_04_restart_network_wo_cleanup | Success 

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread serg38
Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@priyankparihar @ustcweizhou There seems to be just one case where it will 
affect resetVM operations. If template is deleted and root disk is migrated to 
another PS where there is no template copy at destination and the reset VM wont 
work. It is probably not easy to implement copying a base template from on PS 
to another as a part of migrate volume command. I think the right approach 
would be just to have a check in resetVM and if no local template copy is 
available then find another PS with template copy and reset root disk over 
there or if at that point there is no PS with template copy  gracefully error 
out resetVM command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
agree with @dmabry 
logrotate need to be moved (or copied) to cron.hourly
```
diff --git a/systemvm/patches/debian/config/etc/cron.hourly/logrotate 
b/systemvm/patches/debian/config/etc/cron.hourly/logrotate
new file mode 100755
index 000..055b4d5
--- /dev/null
+++ b/systemvm/patches/debian/config/etc/cron.hourly/logrotate
@@ -0,0 +1,5 @@
+#!/bin/sh
+
+test -x /usr/sbin/logrotate || exit 0
+/usr/sbin/logrotate /etc/logrotate.conf
+
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1952: CLOUDSTACK-9790: fix NPE in case of Basic zone.

2017-02-17 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1952
  
LGTM

I have also incorporated this code and created a Basic Zone with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-17 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1829
  
Trillian test result (tid-851)
Environment: vmware-60u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35957 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1829-t851-vmware-60u2.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: 
/marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
Test completed. 46 look ok, 2 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 768.12 | 
test_privategw_acl.py
ContextSuite context=TestSnapshotRootDisk>:teardown | `Error` | 56.54 | 
test_snapshots.py
test_01_vpc_site2site_vpn | Success | 316.61 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 131.54 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 563.23 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 347.13 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 664.10 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 617.24 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1478.54 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 674.73 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 608.90 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1305.57 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 20.89 | test_volumes.py
test_06_download_detached_volume | Success | 40.44 | test_volumes.py
test_05_detach_volume | Success | 100.25 | test_volumes.py
test_04_delete_attached_volume | Success | 10.19 | test_volumes.py
test_03_download_attached_volume | Success | 15.30 | test_volumes.py
test_02_attach_volume | Success | 48.67 | test_volumes.py
test_01_create_volume | Success | 435.33 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.25 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 220.17 | test_vm_snapshots.py
test_01_test_vm_volume_snapshot | Success | 171.71 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.67 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 262.76 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.04 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.86 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.26 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 55.99 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.16 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 5.11 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 5.14 | test_vm_life_cycle.py
test_02_start_vm | Success | 20.23 | test_vm_life_cycle.py
test_01_stop_vm | Success | 10.15 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 171.25 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.06 | test_templates.py
test_04_extract_template | Success | 10.23 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 100.88 | test_templates.py
test_10_destroy_cpvm | Success | 236.92 | test_ssvm.py
test_09_destroy_ssvm | Success | 238.77 | test_ssvm.py
test_08_reboot_cpvm | Success | 156.53 | test_ssvm.py
test_07_reboot_ssvm | Success | 158.33 | test_ssvm.py
test_06_stop_cpvm | Success | 176.76 | test_ssvm.py
test_05_stop_ssvm | Success | 173.62 | test_ssvm.py
test_04_cpvm_internals | Success | 1.14 | test_ssvm.py
test_03_ssvm_internals | Success | 3.12 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.14 | test_ssvm.py
test_01_snapshot_root_disk | Success | 21.15 | test_snapshots.py
test_04_change_offering_small | Success | 87.06 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.08 | test_service_offerings.py
test_01_create_service_offering | Success | 0.12 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1773
  
@serg38 yes, your approach is the best solution for now.

By the way, I've implemented the copy of template between storage pools on 
kvm/nfs in our branch, not implemented for other situations yet. The missing 
template also impact storage migration (live/offline).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread Sergey Levitskiy
@ustcweizhou that's great . If you can open PR here @nvazquez can try 
implementing in-between PS copies for VMware . Also for VMware storage, 
migration doesn't require base template at destination PS even for linked 
clones. VMware will always convert link clone to a full one during migration

Sent from my iPhone

> On Feb 17, 2017, at 11:39 AM, ustcweizhou  wrote:
> 
> ustcweizhou


[GitHub] cloudstack-www issue #35: Update "who" page to reflect the new additions to ...

2017-02-17 Thread swill
Github user swill commented on the issue:

https://github.com/apache/cloudstack-www/pull/35
  
LGTM 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread dmabry
Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@ustcweizhou - Thanks for the +1 on cron.hourly move.  From looking at the 
code, it looks like non-redundant VRs are already moving to cron.hourly, but 
vpcrouter isn't.  In our case, we are using vpcrouter.  I'm working on a PR 
against master that will fix the vpcrouter flavor of this code.  I'll link the 
PR here when I'm done testing.

I'd also like to understand why you would prefer 'size' over 'maxsize'.  I 
know the difference is subtle and it really won't apply to anything that is set 
to "hourly", but it could impact the dailys.  In the VR case with a limited 
/var/log partition size, I would think that the 'maxsize' option would be 
preferable.  It would keep run away log files in check by rotating them even 
before their interval is reached.

```size size
  Log files are rotated only if they grow bigger then size 
bytes.
  If size is followed by k, the size is assumed to  be  in  
kilo-
  bytes.  If the M is used, the size is in megabytes, and if G 
is
  used, the size is in gigabytes. So size 100,  size  100k,  
size
  100M and size 100G are all valid.
maxsize size
  Log files are rotated when they grow bigger than size bytes 
even before
  the additionally specified time interval (daily, weekly, 
monthly, 
  or yearly).  The related size option is  similar  except  
that  it 
  is mutually exclusive with the time interval options, and it 
causes
  log files to be rotated without regard for the last rotation 
time.  
  When maxsize is used, both the size and timestamp of a log 
file are  
  considered.
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@dmabry I will test it and update you.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-17 Thread syed
Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1951#discussion_r101851324
  
--- Diff: setup/db/db/schema-4920to4930.sql ---
@@ -0,0 +1,22 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements.  See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership.  The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License.  You may obtain a copy of the License at
+--
+--   http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied.  See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+
+--;
+-- Schema upgrade from 4.9.2.0 to 4.9.3.0;
+--;
+
+INSERT IGNORE INTO `cloud`.`hypervisor_capabilities`(uuid, 
hypervisor_type, hypervisor_version, max_guests_limit, max_data_volumes_limit, 
storage_motion_supported) values (UUID(), 'XenServer', '7.0.0', 500, 13, 1);
--- End diff --

@rhtyd I thought that this would be in the 4.9.2.0->4.9.3.0 path which is a 
subset to the 4.10.0.0 path. So in theory, it should be only executed once 
correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [DISCUSS][FS] Host HA for CloudStack

2017-02-17 Thread David Mabry

On 2/16/17, 5:18 AM, "Rohit Yadav"  wrote:

All,


I would like to start discussion on a new feature - Host HA for CloudStack.

CloudStack lacks a way to reliably fence a host, the idea of the host-ha 
feature is to provide a general purpose HA framework and HA provider 
implementation specific for hypervisor that can use additional mechanism such 
as OOBM (ipmi based power management) to reliably investigate, recover and 
fence a host. This feature can handle scenarios associated with server crash 
issues and reliable fencing of hosts and HA of VM. The first version will have 
HA provider implementation for KVM (and for simulator to test the framework 
implementation, and write marvin tests that can validate the feature on Travis 
and others).


Please have a look at the FS here:

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Host+HA


Looking forward to your comments and questions.


Regards.

rohit.ya...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue
  
 

 Rohit,

First, thanks for all the work you have put into this.  This is something that 
CS has sorely needed for a long time.

A couple of items:

1.) You state the following:
“Before invoking the HA provider’s fence operation, the HA resource management 
will place the resource in maintenance mode. The intention is to require an 
administrator to manually verify that a resource is ready to return service by 
requiring an administrator to take it out of maintenance mode.”
I agree that putting a host in maintenance mode to require manual intervention 
in order to bring it back online is ideal and honestly how I would probably 
prefer to do it.  However, I also like to give the end user/operator choice.  
Perhaps we could add an option to bring the Host out of Maintenance mode 
automatically if it passes all checks and comes back into an ELIGIBLE state.  
This way, if the operator chooses, the host could come back into full operation 
and start recovering VMs if needed.  This could also be handy if your 
environment isn’t quite n+1 when it comes to host capacity and you need to have 
the host back up and running as soon as possible to minimize the outage 
duration.  Again, I know it isn’t ideal, but I don’t see the harm in giving the 
operator the choice.

2.) You state the following:
“For the initial release, only KVM with NFS storage will be supported. However, 
the storage check component will be implemented in a modular fashion allowing 
for checks using other storage platforms(e.g. Ceph) in the future. HA provider 
plugins can be implemented for other hypervisors.”
We are using KVM with a Ceph backend and would be very interested in helping 
make it a part of the initial push for this feature.  I have a Dev environment 
backed by Ceph that we could use for teseting and would be willing to help with 
the development of the Ceph activity checks.

I’m looking forward to getting this feature added to CS.  Again, great job 
putting this together and starting the conversation.

Thanks,
Mabry



[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-17 Thread dmabry
Github user dmabry commented on the issue:

https://github.com/apache/cloudstack/pull/1915
  
@serbaut Just curious, are you using VPC routers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-17 Thread cloudmonger
Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1883
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 354
 Hypervisor xenserver
 NetworkType Advanced
 Passed=103
 Failed=2
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed

* test_routers_network_ops.py

 * test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Modify the system vm build scripts

2017-02-17 Thread Daan Hoogland
nice explanation Will, c&p to the wiki and docs, i'd say

On Fri, Feb 17, 2017 at 6:06 PM, Will Stevens  wrote:
> Yes. Exactly. The "patches" don't require a new system vm template to be
> distributed, but changes to the "appliance" does require a new system vm
> template.
>
> On Feb 17, 2017 12:04 PM, "David Mabry"  wrote:
>
>> Awesome.  Thanks for the quick answer.  That totally makes sense.  Package
>> changes (installation, etc…) are done in the “appliance” section of code.
>> Any “config” changes required beyond package installation are done in the
>> “patches” section of code.
>>
>> Thanks,
>> David Mabry
>>
>> On 2/17/17, 10:52 AM, "williamstev...@gmail.com on behalf of Will
>> Stevens" 
>> wrote:
>>
>> So the System VM is "built" from two sources.
>>
>> 1)
>> https://github.com/apache/cloudstack/tree/master/tools/
>> appliance/definitions/systemvmtemplate
>> This defines what is actually built and is distributed as the SystemVM
>> Template.  You MUST use it if you change the packages included in the
>> SystemVM template or change the core components in any way.  Changing
>> anything here REQUIRES a new SystemVM template to be distributed for
>> that
>> change to be used.
>>
>> 2) https://github.com/apache/cloudstack/tree/master/
>> systemvm/patches/debian
>> This defines the systemvm.iso which is loaded into the System VM
>> template
>> after the system vm is deployed.  This basically defines configuration
>> which can be changed without requiring a new System VM template.  This
>> section does not handle installation of packages and such, instead it
>> handles System VM configuration and functionality.  So if settings
>> files
>> need to be changed (for say something like VPN) or if the way we
>> handle IP
>> address changes, etc...  That is all handled from here.  The
>> systemvm.iso
>> is generated by the management server (i think) and is pushed to the
>> system
>> vm after the system vm boots and the configuration which cloudstack
>> manages
>> is handled through this code.
>>
>> Is that clear?  Let me know if you have more questions.  I have had to
>> do a
>> bunch of stuff in this recently for some of the networking issues we
>> have
>> had as well as the StrongSwan VPN implementation (which changed both
>> places).
>>
>> Using StrongSwan as an example:
>> I had to modify (1) in order to remove the OpenSwan package
>> installation
>> and add the StrongSwan package installation.
>>
>> I had to modify (2) in order to change the configuration of the VPN in
>> order to handle things the way that StrongSwan needed things done.  So
>> the
>> changes to things like the `ipsec` command are handled in (2) because
>> those
>> are configuration changes and not package changes.
>>
>> Is that clearer?
>>
>> *Will STEVENS*
>> Lead Developer
>>
>> 
>>
>> On Fri, Feb 17, 2017 at 11:18 AM, David Mabry  wrote:
>>
>> > Hello everyone,
>> >
>> > I’m looking at making some changes to the system vm, but I have
>> found that
>> > there looks like there are 2 different places in the code that
>> “build” the
>> > systemvm.  There is there is https://github.com/apache/
>> cloudstack/tree/
>> > 13bfdd71e6f52d2f613a802b3d16c9b40af7/systemvm/patches/debian,
>> which
>> > looks like it might be the “old” way and there is
>> > https://github.com/apache/cloudstack/tree/
>> 87ef8137534fa798101f65c6691fcf
>> > 71513ac978/tools/appliance/definitions/systemvmtemplate, which
>> looks like
>> > it might be the “new” way.  If I wanted to make changes to how the
>> systemvm
>> > is built which place should I modify?  I assume that I should modify
>> the
>> > build scripts in the “new” location, but I thought I would ask here
>> first
>> > just to be sure.
>> >
>> > --Mabry
>> >
>>
>>
>>



-- 
Daan