[GitHub] cloudstack issue #921: CLOUDSTACK-8944 Template download possible from new n...

2017-04-04 Thread yvsubhash
Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/921
  
Closing this PR, as this is no longer needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #921: CLOUDSTACK-8944 Template download possible fro...

2017-04-04 Thread yvsubhash
Github user yvsubhash closed the pull request at:

https://github.com/apache/cloudstack/pull/921


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-04-04 Thread Wei ZHOU
tomcat7 on ubuntu 16.04 is not working fine in my testing.
Anyone has same issue ?

-Wei

2017-04-03 15:11 GMT+02:00 Pierre-Luc Dion :

> Look like we need a new systemvm named "systemvm-xenserver-4.10". t also
> seams that older VR  ex: 4.7.x are still usable if the globalsetting
> "minreq.sysvmtemplate.version" is changed after the first boot of
> cloudstack-management that upgraded the database. I'll update the release
> note acordingly...
>
> So this 4.10 is looking promising! :-)
>
>
>
>
> On Apr 1, 2017 16:02, "Pierre-Luc Dion"  wrote:
>
> I'm testing upgrade to 4.10 from latest master. I have the following error
> when upgrading from 4.7.2 in management-server.log:
>
> 2017-04-01 15:58:12,558 DEBUG [c.c.u.d.Upgrade4920to41000]
> (localhost-startStop-1:null) (logid:) Updating System Vm template IDs
> 2017-04-01 15:58:12,561 DEBUG [c.c.u.d.Upgrade4920to41000]
> (localhost-startStop-1:null) (logid:) Updating KVM System Vms
> 2017-04-01 15:58:12,561 WARN  [c.c.u.d.Upgrade4920to41000]
> (localhost-startStop-1:null) (logid:) 4.10.0.0KVM SystemVm template not
> found. KVM hypervisor is not used, so not failing upgrade
> 2017-04-01 15:58:12,562 DEBUG [c.c.u.d.Upgrade4920to41000]
> (localhost-startStop-1:null) (logid:) Updating VMware System Vms
> 2017-04-01 15:58:12,563 WARN  [c.c.u.d.Upgrade4920to41000]
> (localhost-startStop-1:null) (logid:) 4.10.0.0VMware SystemVm template not
> found. VMware hypervisor is not used, so not failing upgrade
> 2017-04-01 15:58:12,563 DEBUG [c.c.u.d.Upgrade4920to41000]
> (localhost-startStop-1:null) (logid:) Updating XenServer System Vms
> 2017-04-01 15:58:12,565 ERROR [c.c.u.DatabaseUpgradeChecker]
> (localhost-startStop-1:null) (logid:) Unable to upgrade the database
> com.cloud.utils.exception.CloudRuntimeException: 4.10.0.0XenServer
> SystemVm
> template not found. Cannot upgrade system Vms
> at com.cloud.upgrade.dao.Upgrade4920to41000.updateSystemVmTempl
> ates(Upgrade4920to41000.java:195)
> at com.cloud.upgrade.dao.Upgrade4920to41000.performDataMigratio
> n(Upgrade4920to41000.java:64)
> at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpg
> radeChecker.java:426)
> at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgra
> deChecker.java:507)
> at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLif
> eCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
> at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLif
> eCycle.start(CloudStackExtendedLifeCycle.java:55)
> at org.springframework.context.support.DefaultLifecycleProcesso
> r.doStart(DefaultLifecycleProcessor.java:173)
> at org.springframework.context.support.DefaultLifecycleProcesso
> r.access$200(DefaultLifecycleProcessor.java:51)
> at org.springframework.context.support.DefaultLifecycleProcesso
> r$LifecycleGroup.start(DefaultLifecycleProcessor.java:346)
> at org.springframework.context.support.DefaultLifecycleProcesso
> r.startBeans(DefaultLifecycleProcessor.java:149)
> at org.springframework.context.support.DefaultLifecycleProcesso
> r.onRefresh(DefaultLifecycleProcessor.java:112)
> at org.springframework.context.support.AbstractApplicationConte
> xt.finishRefresh(AbstractApplicationContext.java:879)
> at org.springframework.context.support.AbstractApplicationConte
> xt.refresh(AbstractApplicationContext.java:545)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
> DefinitionSet.load(DefaultModuleDefinitionSet.java:79)
> at org.apache.cloudstack.spring.module.factory.ModuleBasedConte
> xtFactory.loadModules(ModuleBasedContextFactory.java:37)
> at org.apache.cloudstack.spring.module.factory.CloudStackSpring
> Context.init(CloudStackSpringContext.java:71)
> at org.apache.cloudstack.spring.module.factory.CloudStackSpring
> Context.(CloudStackSpringContext.java:58)
> at org.apache.cloudstack.spring.module.factory.CloudStackSpring
> Context.(CloudStackSpringContext.java:62)
> at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListene
> r.
> contextInitialized(CloudStackContextLoaderListener.java:52)
> at org.apache.catalina.core.StandardContext.listenerStart(Stand
> ardContext.java:5068)
> at org.apache.catalina.core.StandardContext.startInternal(Stand
> ardContext.java:5584)
> at o

[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...

2017-04-04 Thread bvbharatk
Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/2018
  
code changes LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #914: BUG-ID CLOUDSTACK-8939 VM Snapshot size with memory i...

2017-04-04 Thread niteshsarda
Github user niteshsarda commented on the issue:

https://github.com/apache/cloudstack/pull/914
  
I have tested this and **LGTM** for test.

Following are the test results : 

**Before applying fix :**

[root@xenserver-jay ~]# xe vbd-list vm-name-label=i-2-120-VM empty=false 
params=vdi-uuid
vdi-uuid ( RO): 674c2c07-954e-4fa0-943a-979a71748727


[root@xenserver-jay ~]# xe vdi-list 
params=physical-utilisation,sm-config,is-a-snapshot 
uuid=674c2c07-954e-4fa0-943a-979a71748727
is-a-snapshot ( RO)   : false
physical-utilisation ( RO): 81256448
   sm-config (MRO): 
host_OpaqueRef:a3c1c534-b5e3-6cb5-10af-b56dead63fc0: RW; vhd-parent: 
1aac168d-22d2-4796-8669-48a3f4361dfc

   
[root@xenserver-jay ~]# xe vdi-list 
params=physical-utilisation,sm-config,is-a-snapshot 
uuid=1aac168d-22d2-4796-8669-48a3f4361dfc
is-a-snapshot ( RO)   : false
physical-utilisation ( RO): 233251328
   sm-config (MRO): vhd-blocks: 
eJxjYEAB7AykARFGPc1cN4UVJGqDAUYG5tZJF0ymbpi4bYUCAxPJ+nn2sDQLMGwTYzzI0OvAQob1AgIBip6BrAIrG0jWDAEAQmQNjA==;
 vhd-parent: 55943089-24fa-4fbe-a44e-e57fe9a080ed
   
[root@xenserver-jay ~]# xe vdi-list name-label=Suspend\ image params=all
uuid ( RO): 105fbe1d-973b-4d8d-82e7-96246669a769
  name-label ( RW): Suspend image
name-description ( RW): Suspend image
   is-a-snapshot ( RO): true
 snapshot-of ( RO): 
   snapshots ( RO):
   snapshot-time ( RO): 20170401T07:49:50Z
  allowed-operations (SRO): forget; generate_config; update; resize; 
destroy; clone; copy; snapshot
  current-operations (SRO):
 sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c
   sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29
   vbd-uuids (SRO):
 crashdump-uuids (SRO):
virtual-size ( RO): 782237696
physical-utilisation ( RO): 6144
location ( RO): 105fbe1d-973b-4d8d-82e7-96246669a769
type ( RO): Suspend
sharable ( RO): false
   read-only ( RO): false
storage-lock ( RO): false
 managed ( RO): true
  parent ( RO): 
 missing ( RO): false
other-config (MRW): content_id: 
842a46b4-bffd-70fb-b00a-47c39de8959b
   xenstore-data (MRO):
   sm-config (MRO): vhd-parent: 
638118a6-5f85-4c35-9aa8-d19793a144a8
 on-boot ( RW): persist
   allow-caching ( RW): false
 metadata-latest ( RO): false
metadata-of-pool ( RO): 
tags (SRW):


[root@xenserver-jay ~]# xe vdi-list 
uuid=638118a6-5f85-4c35-9aa8-d19793a144a8 params=all
uuid ( RO): 638118a6-5f85-4c35-9aa8-d19793a144a8
  name-label ( RW): base copy
name-description ( RW):
   is-a-snapshot ( RO): false
 snapshot-of ( RO): 
   snapshots ( RO):
   snapshot-time ( RO): 19700101T00:00:00Z
  allowed-operations (SRO): forget; generate_config; update; resize; 
destroy; clone; copy; snapshot
  current-operations (SRO):
 sr-uuid ( RO): 99b84794-d0d6-46c6-fa42-07af5b423b8c
   sr-name-label ( RO): d2fecabd-61cf-3458-a120-ea01a4f91c29
   vbd-uuids (SRO):
 crashdump-uuids (SRO):
virtual-size ( RO): 782237696
physical-utilisation ( RO): 548430336
location ( RO): 638118a6-5f85-4c35-9aa8-d19793a144a8
type ( RO): User
sharable ( RO): false
   read-only ( RO): true
storage-lock ( RO): false
 managed ( RO): false
  parent ( RO): 
 missing ( RO): false
other-config (MRW):
   xenstore-data (MRO):
   sm-config (MRO): vhd-blocks: eJz7/x8/+MGAAgD69CDZ
 on-boot ( RW): persist
   allow-caching ( RW): false
 metadata-latest ( RO): false
metadata-of-pool ( RO): 
tags (SRW):

   
   
mysql> select * from cloud.usage_event where resource_name like 
"i-2-120-VM%" \G
*** 1. row ***
   id: 84
 type: VMSNAPSHOT.CREATE
   account_id: 2
  created: 2017-04-01 07:50:42
  zone_id: 2
  resource_id: 120
resource_name: i-2-120-VM_VS_20170401074841
  offering_id: NULL
  template_id: 120
 size: 233272320
resource_type:

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2020: WIP: Expire VM snapshots

2017-04-04 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/2020
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2020: WIP: Expire VM snapshots

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2020
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...

2017-04-04 Thread jayapalu
Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/1997
  
@ramkatru  I am not sure about  Daan comments. 
The tests results are positive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2025: Fix error in restart network in 4.10.0.0 RC

2017-04-04 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request:

https://github.com/apache/cloudstack/pull/2025

Fix error in restart network in 4.10.0.0 RC

The PR fixes the error in restart network:
2017-04-04 10:27:39,217 DEBUG [c.c.n.r.NetworkHelperImpl] 
(API-Job-Executor-2:ctx-08904854 job-29417 ctx-3405d3f2) (logid:19bbd6e6) 
Router requires upgrade. Unable to send command to router:9784, router template 
version : Cloudstack Release 4.10.0 Wed Feb 15 05:42:18 UTC 2017, minimal 
required version : 4.10.0.0

It works after changing minreq.sysvmtemplate.version from 4.10.0.0 to 4.10.0

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ustcweizhou/cloudstack 4.10-restartnetwork

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2025.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2025


commit 5018b579ab1578fa22fdb2ca1ee9218d740c1df7
Author: Wei Zhou 
Date:   2017-04-04T10:43:27Z

Fix error in restart network in 4.10.0.0 RC




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: :[VOTE] Apache Cloudstack 4.10.0.0

2017-04-04 Thread Wei ZHOU
Guys,

I created a PR for erros in restartnetwork in 4.10.0.0-RC, please review.
https://github.com/apache/cloudstack/pull/2025

-Wei

2017-04-04 9:27 GMT+02:00 Wei ZHOU :

> tomcat7 on ubuntu 16.04 is not working fine in my testing.
> Anyone has same issue ?
>
> -Wei
>
> 2017-04-03 15:11 GMT+02:00 Pierre-Luc Dion :
>
>> Look like we need a new systemvm named "systemvm-xenserver-4.10". t also
>> seams that older VR  ex: 4.7.x are still usable if the globalsetting
>> "minreq.sysvmtemplate.version" is changed after the first boot of
>> cloudstack-management that upgraded the database. I'll update the release
>> note acordingly...
>>
>> So this 4.10 is looking promising! :-)
>>
>>
>>
>>
>> On Apr 1, 2017 16:02, "Pierre-Luc Dion"  wrote:
>>
>> I'm testing upgrade to 4.10 from latest master. I have the following error
>> when upgrading from 4.7.2 in management-server.log:
>>
>> 2017-04-01 15:58:12,558 DEBUG [c.c.u.d.Upgrade4920to41000]
>> (localhost-startStop-1:null) (logid:) Updating System Vm template IDs
>> 2017-04-01 15:58:12,561 DEBUG [c.c.u.d.Upgrade4920to41000]
>> (localhost-startStop-1:null) (logid:) Updating KVM System Vms
>> 2017-04-01 15:58:12,561 WARN  [c.c.u.d.Upgrade4920to41000]
>> (localhost-startStop-1:null) (logid:) 4.10.0.0KVM SystemVm template not
>> found. KVM hypervisor is not used, so not failing upgrade
>> 2017-04-01 15:58:12,562 DEBUG [c.c.u.d.Upgrade4920to41000]
>> (localhost-startStop-1:null) (logid:) Updating VMware System Vms
>> 2017-04-01 15:58:12,563 WARN  [c.c.u.d.Upgrade4920to41000]
>> (localhost-startStop-1:null) (logid:) 4.10.0.0VMware SystemVm template not
>> found. VMware hypervisor is not used, so not failing upgrade
>> 2017-04-01 15:58:12,563 DEBUG [c.c.u.d.Upgrade4920to41000]
>> (localhost-startStop-1:null) (logid:) Updating XenServer System Vms
>> 2017-04-01 15:58:12,565 ERROR [c.c.u.DatabaseUpgradeChecker]
>> (localhost-startStop-1:null) (logid:) Unable to upgrade the database
>> com.cloud.utils.exception.CloudRuntimeException: 4.10.0.0XenServer
>> SystemVm
>> template not found. Cannot upgrade system Vms
>> at com.cloud.upgrade.dao.Upgrade4920to41000.updateSystemVmTempl
>> ates(Upgrade4920to41000.java:195)
>> at com.cloud.upgrade.dao.Upgrade4920to41000.performDataMigratio
>> n(Upgrade4920to41000.java:64)
>> at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpg
>> radeChecker.java:426)
>> at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgra
>> deChecker.java:507)
>> at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLif
>> eCycle.checkIntegrity(CloudStackExtendedLifeCycle.java:65)
>> at org.apache.cloudstack.spring.lifecycle.CloudStackExtendedLif
>> eCycle.start(CloudStackExtendedLifeCycle.java:55)
>> at org.springframework.context.support.DefaultLifecycleProcesso
>> r.doStart(DefaultLifecycleProcessor.java:173)
>> at org.springframework.context.support.DefaultLifecycleProcesso
>> r.access$200(DefaultLifecycleProcessor.java:51)
>> at org.springframework.context.support.DefaultLifecycleProcesso
>> r$LifecycleGroup.start(DefaultLifecycleProcessor.java:346)
>> at org.springframework.context.support.DefaultLifecycleProcesso
>> r.startBeans(DefaultLifecycleProcessor.java:149)
>> at org.springframework.context.support.DefaultLifecycleProcesso
>> r.onRefresh(DefaultLifecycleProcessor.java:112)
>> at org.springframework.context.support.AbstractApplicationConte
>> xt.finishRefresh(AbstractApplicationContext.java:879)
>> at org.springframework.context.support.AbstractApplicationConte
>> xt.refresh(AbstractApplicationContext.java:545)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet.loadContext(DefaultModuleDefinitionSet.java:145)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet$2.with(DefaultModuleDefinitionSet.java:122)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet.withModule(DefaultModuleDefinitionSet.java:245)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet.withModule(DefaultModuleDefinitionSet.java:250)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet.withModule(DefaultModuleDefinitionSet.java:233)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet.loadContexts(DefaultModuleDefinitionSet.java:117)
>> at org.apache.cloudstack.spring.module.model.impl.DefaultModule
>> DefinitionSet.load(DefaultModuleDefinitionSet.java:79)
>> at org.apache.cloudstack.spring.module.factory.ModuleBasedConte
>> xtFactory.loadModules(ModuleBasedContextFactory.java:37)
>> at org.apache.cloudstack.spring.module.factory.CloudStackSpring
>> Context.init(CloudStackSpringContext.java:71)
>> at org.apache.cloudstack.spring.module.factory.CloudStackSpring
>> Context.(CloudStackSpringContext.java:58)
>> at org.apache.cloudstack.spring.module.factory.CloudStackSpring
>> Context.(CloudStackSpringContext.java:62)
>> at org.apache.cloudstack.spring.module.web.CloudStackContex

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-04-04 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r109633875
  
--- Diff: debian/control ---
@@ -16,14 +16,15 @@ Description: A common package which contains files 
which are shared by several C
 Package: cloudstack-management
 Architecture: all
 Depends: ${misc:Depends}, ${python:Depends}, openjdk-8-jre-headless | 
java8-runtime-headless | java8-runtime, cloudstack-common (= 
${source:Version}), tomcat6 | tomcat7, sudo, jsvc, python-mysql.connector, 
libmysql-java, augeas-tools, mysql-client, adduser, bzip2, ipmitool, lsb-release
+Recommends: init-system-helpers (>= 1.14)
--- End diff --

@rhtyd Sorry I just noticed your comment.  I will remove all 3 lines
Recommends: init-system-helpers (>= 1.14)

I am not sure if it will cause any issue. Please test it.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-04-04 Thread ustcweizhou
Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1950
  
it would be nice if this can be merged into 4.10.0.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2020: WIP: Expire VM snapshots

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2020
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-613


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@borisstoyanov checking


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails with error

2017-04-04 Thread jayakarteek
Github user jayakarteek commented on the issue:

https://github.com/apache/cloudstack/pull/1849
  
@sudhansu7 

Tested the fix, LGTM.
I am able to change from small computer offering to medium computer 
offering for centos-7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1726: CLOUDSTACK-9560 Root volume of deleted VM left unrem...

2017-04-04 Thread yvsubhash
Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/1726
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1849: CLOUDSTACK-9690: Scale CentOS7 VM fails with error

2017-04-04 Thread jayantpatil1234
Github user jayantpatil1234 commented on the issue:

https://github.com/apache/cloudstack/pull/1849
  
 @sudhansu7 
There is one file "Upgrade4910to4920.java", which does not have any 
changes, still that get added in PR. If possible could you remove that file? 

Otherwise code looks good. LGTM for code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-04-04 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@borisstoyanov I've rebased master branch, can we re-run tests on this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2020: WIP: Expire VM snapshots

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at:

https://github.com/apache/cloudstack/pull/2020


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-04-04 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-04 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r102538324
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -109,6 +112,20 @@
 @Inject
 MessageBus _messageBus;
 
+static boolean rollBackState = false;
--- End diff --

@nvazquez I have been thinking about this variable you introduced here. I 
think it can cause problems (concurrency problems). The `DomainManagerImpl` is 
a singleton. Therefore, it should not have state variables. The `rollBackState 
` is acting as a state variable for requests that use 
`com.cloud.user.DomainManagerImpl.deleteDomain(DomainVO, Boolean)`. The problem 
is that every call should have its own context/state for `rollBackState`. 
However, this will not happen with the current implementation.

I think we should re-work the use of that variable. What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-04 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r103529869
  
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,69 @@ public void testFindDomainByIdOrPathValidId() {
 Assert.assertEquals(domain, domainManager.findDomainByIdOrPath(1L, 
"/validDomain/"));
 }
 
+@Test(expected=InvalidParameterValueException.class)
+public void testDeleteDomainNullDomain() {
+Mockito.when(_domainDao.findById(DOMAIN_ID)).thenReturn(null);
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+}
+
+@Test(expected=PermissionDeniedException.class)
+public void testDeleteDomainRootDomain() {
+
Mockito.when(_domainDao.findById(Domain.ROOT_DOMAIN)).thenReturn(domain);
+domainManager.deleteDomain(Domain.ROOT_DOMAIN, testDomainCleanup);
+}
+
+@Test
+public void testDeleteDomainNoCleanup() {
+domainManager.deleteDomain(DOMAIN_ID, testDomainCleanup);
+Mockito.verify(domainManager).deleteDomain(domain, 
testDomainCleanup);
+
Mockito.verify(domainManager).removeDomainWithNoAccountsForCleanupNetworksOrDedicatedResources(domain);
+Mockito.verify(domainManager).cleanupDomainOfferings(DOMAIN_ID);
+Mockito.verify(lock).unlock();
+}
+
+@Test
+public void 
testRemoveDomainWithNoAccountsForCleanupNetworksOrDedicatedResourcesRemoveDomain()
 {
+
domainManager.removeDomainWithNoAccountsForCleanupNetworksOrDedicatedResources(domain);
+
Mockito.verify(domainManager).publishRemoveEventsAndRemoveDomain(domain);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void 
testRemoveDomainWithNoAccountsForCleanupNetworksOrDedicatedResourcesDontRemoveDomain()
 {
+domainNetworkIds.add(2l);
+
domainManager.removeDomainWithNoAccountsForCleanupNetworksOrDedicatedResources(domain);
+Mockito.verify(domainManager).failRemoveOperation(domain, 
domainAccountsForCleanup, domainNetworkIds, false);
+}
+
+@Test
+public void testPublishRemoveEventsAndRemoveDomainSuccessfulDelete() {
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test(expected=CloudRuntimeException.class)
+public void testPublishRemoveEventsAndRemoveDomainExceptionDelete() {
+Mockito.when(_domainDao.remove(DOMAIN_ID)).thenReturn(false);
+domainManager.publishRemoveEventsAndRemoveDomain(domain);
+Mockito.verify(_messageBus).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_PRE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_messageBus, 
Mockito.never()).publish(Mockito.anyString(), 
Matchers.eq(DomainManager.MESSAGE_REMOVE_DOMAIN_EVENT),
+Matchers.eq(PublishScope.LOCAL), Matchers.eq(domain));
+Mockito.verify(_domainDao).remove(DOMAIN_ID);
+}
+
+@Test
+public void testFailRemoveOperation() {
+try {
+domainManager.failRemoveOperation(domain, 
domainAccountsForCleanup, domainNetworkIds, true);
--- End diff --

Now that you removed the use of `rollBackState`, made the method last 
problematic to test. Therefore, you can use the `@Test(expected=...)`, instead 
of this very unusual construction here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

2017-04-04 Thread rafaelweingartner
Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1935#discussion_r103529571
  
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +284,145 @@ public boolean deleteDomain(long domainId, Boolean 
cleanup) {
 
 @Override
 public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
-// mark domain as inactive
-s_logger.debug("Marking domain id=" + domain.getId() + " as " + 
Domain.State.Inactive + " before actually deleting it");
-domain.setState(Domain.State.Inactive);
-_domainDao.update(domain.getId(), domain);
-boolean rollBackState = false;
-boolean hasDedicatedResources = false;
+GlobalLock lock = getGlobalLock("AccountCleanup");
+if (lock == null) {
+s_logger.debug("Couldn't get the global lock");
+return false;
+}
+
+if (!lock.lock(30)) {
+s_logger.debug("Couldn't lock the db");
+return false;
+}
 
 try {
-long ownerId = domain.getAccountId();
-if ((cleanup != null) && cleanup.booleanValue()) {
-if (!cleanupDomain(domain.getId(), ownerId)) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Failed to clean up 
domain resources and sub domains, delete failed on domain " + domain.getName() 
+ " (id: " +
-domain.getId() + ").");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-} else {
-//don't delete the domain if there are accounts set for 
cleanup, or non-removed networks exist, or domain has dedicated resources
-List networkIds = 
_networkDomainDao.listNetworkIdsByDomain(domain.getId());
-List accountsForCleanup = 
_accountDao.findCleanupsForRemovedAccounts(domain.getId());
-List dedicatedResources = 
_dedicatedDao.listByDomainId(domain.getId());
-if (dedicatedResources != null && 
!dedicatedResources.isEmpty()) {
-s_logger.error("There are dedicated resources for the 
domain " + domain.getId());
-hasDedicatedResources = true;
-}
-if (accountsForCleanup.isEmpty() && networkIds.isEmpty() 
&& !hasDedicatedResources) {
-_messageBus.publish(_name, 
MESSAGE_PRE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
-if (!_domainDao.remove(domain.getId())) {
-rollBackState = true;
-CloudRuntimeException e =
-new CloudRuntimeException("Delete failed on 
domain " + domain.getName() + " (id: " + domain.getId() +
-"); Please make sure all users and sub 
domains have been removed from the domain before deleting");
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
-}
-_messageBus.publish(_name, 
MESSAGE_REMOVE_DOMAIN_EVENT, PublishScope.LOCAL, domain);
+// mark domain as inactive
+s_logger.debug("Marking domain id=" + domain.getId() + " as " 
+ Domain.State.Inactive + " before actually deleting it");
+domain.setState(Domain.State.Inactive);
+_domainDao.update(domain.getId(), domain);
+
+boolean rollBackState = false;
+
+try {
+long ownerId = domain.getAccountId();
+if (BooleanUtils.toBoolean(cleanup)) {
+tryCleanupDomain(domain, ownerId);
 } else {
-rollBackState = true;
-String msg = null;
-if (!accountsForCleanup.isEmpty()) {
-msg = accountsForCleanup.size() + " accounts to 
cleanup";
-} else if (!networkIds.isEmpty()) {
-msg = networkIds.size() + " non-removed networks";
-} else if (hasDedicatedResources) {
-msg = "dedicated resources.";
-}
+
removeDomainWithNoAccountsForCleanupNetworksOrDedicatedResources(domain);
+}
 
-CloudRuntimeException e = new 
CloudRuntimeException("Can't delete the domain yet because it has " + msg);
-e.addProxyObject(domain.getUuid(), "domainId");
-throw e;
+cleanupD

[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...

2017-04-04 Thread DaanHoogland
Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1997
  
@jayapalu your check is ok, what is not ok is that it is needed. Somehow a 
stop can be send to a VM for which no host is known?
I am worried about the reason of your fix and that we might obscure it. Why 
is a stop command attempted on a vm for which no host is known?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2012: CLOUDSTACK-9842: Unable to map root volume usage to ...

2017-04-04 Thread yvsubhash
Github user yvsubhash commented on the issue:

https://github.com/apache/cloudstack/pull/2012
  
Tested this change. LGTM for test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-614


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has 
been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-04-04 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1918: Management Server UI (VM statistics page) CPU Utiliz...

2017-04-04 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1918
  
LGTM for testing. Tested on Vmware 6.0, I attach some screenshots for test 
scenarios, in which vm was deployed using service offering, infinite loop was 
executed to increase CPU utilization and then stopped

- Test case 1: Service offering not limiting CPU speed

![14](https://cloud.githubusercontent.com/assets/5295080/24670974/71480f9e-1946-11e7-931f-b729035b8425.PNG)

![13](https://cloud.githubusercontent.com/assets/5295080/24671023/95bed9a2-1946-11e7-8672-cc4e3403fa3b.PNG)

![15](https://cloud.githubusercontent.com/assets/5295080/24671057/b9fb7d66-1946-11e7-8ba4-ffd2a97738d8.PNG)

![16](https://cloud.githubusercontent.com/assets/5295080/24671096/d18e8c34-1946-11e7-8cd8-57129c60f058.PNG)

![17](https://cloud.githubusercontent.com/assets/5295080/24671225/304a402e-1947-11e7-8aef-39a4405440b0.PNG)

![18](https://cloud.githubusercontent.com/assets/5295080/24671233/35539a84-1947-11e7-9504-00d8c156e5f2.PNG)

- Test case 2: Service offering limiting CPU speed

![21](https://cloud.githubusercontent.com/assets/5295080/24671981/ac4ad8bc-1949-11e7-8712-b256aea941a9.PNG)

![20](https://cloud.githubusercontent.com/assets/5295080/24671990/b09c9b1c-1949-11e7-819c-e5346515b021.PNG)

![22](https://cloud.githubusercontent.com/assets/5295080/24671996/b54e8e36-1949-11e7-8990-b34a56bed6fa.PNG)

![23](https://cloud.githubusercontent.com/assets/5295080/24672002/ba4b8f92-1949-11e7-9efc-83d42057589c.PNG)


@rafaelweingartner thanks for your effort in this PR
@jayakarteek can you please rebase master branch and squash your commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


F5 compile issue with 4.5.x

2017-04-04 Thread Tutkowski, Mike
Hi,

I see the following error now when trying to compile 4.5.x code:

[INFO] Compiling 12 source files to 
/Users/solidfire/Documents/CloudStack/CloudStack/plugins/network-elements/f5/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] 
/Users/solidfire/Documents/CloudStack/CloudStack/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java:[411,26]
 error: cannot access Stub

I’ve not seen this “Stub” problem before.

Anyone familiar with what it’s referring to?

Thanks!
Mike


Re: F5 compile issue with 4.5.x

2017-04-04 Thread Rafael Weingärtner
I feel that I have seen this before.
What is your JDK version?

On Tue, Apr 4, 2017 at 4:06 PM, Tutkowski, Mike 
wrote:

> Hi,
>
> I see the following error now when trying to compile 4.5.x code:
>
> [INFO] Compiling 12 source files to /Users/solidfire/Documents/
> CloudStack/CloudStack/plugins/network-elements/f5/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /Users/solidfire/Documents/CloudStack/CloudStack/plugins/
> network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java:[411,26]
> error: cannot access Stub
>
> I’ve not seen this “Stub” problem before.
>
> Anyone familiar with what it’s referring to?
>
> Thanks!
> Mike
>



-- 
Rafael Weingärtner


Re: F5 compile issue with 4.5.x

2017-04-04 Thread Tutkowski, Mike
I am running with Java 8 because I typically have been working with 4.10. I 
just needed to go back to 4.5.x for another project I’m working on.

Thanks

On 4/4/17, 2:09 PM, "Rafael Weingärtner"  wrote:

I feel that I have seen this before.
What is your JDK version?

On Tue, Apr 4, 2017 at 4:06 PM, Tutkowski, Mike 
wrote:

> Hi,
>
> I see the following error now when trying to compile 4.5.x code:
>
> [INFO] Compiling 12 source files to /Users/solidfire/Documents/
> CloudStack/CloudStack/plugins/network-elements/f5/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /Users/solidfire/Documents/CloudStack/CloudStack/plugins/
> 
network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java:[411,26]
> error: cannot access Stub
>
> I’ve not seen this “Stub” problem before.
>
> Anyone familiar with what it’s referring to?
>
> Thanks!
> Mike
>



-- 
Rafael Weingärtner




Re: F5 compile issue with 4.5.x

2017-04-04 Thread Tutkowski, Mike
To try to get around it, I removed the F5 project. It almost compiled then. (

I got this in the client project:

[ERROR] Failed to execute goal on project cloud-client-ui: Could not resolve 
dependencies for project org.apache.cloudstack:cloud-client-ui:war:4.5.1: Could 
not find artifact org.apache.cloudstack:cloud-plugin-network-f5:jar:4.5.1 in 
central (https://repo.maven.apache.org/maven2) -> [Help 1]

I removed the F5 reference there and am re-compiling.

On 4/4/17, 2:14 PM, "Tutkowski, Mike"  wrote:

I am running with Java 8 because I typically have been working with 4.10. I 
just needed to go back to 4.5.x for another project I’m working on.

Thanks

On 4/4/17, 2:09 PM, "Rafael Weingärtner"  
wrote:

I feel that I have seen this before.
What is your JDK version?

On Tue, Apr 4, 2017 at 4:06 PM, Tutkowski, Mike 

wrote:

> Hi,
>
> I see the following error now when trying to compile 4.5.x code:
>
> [INFO] Compiling 12 source files to /Users/solidfire/Documents/
> CloudStack/CloudStack/plugins/network-elements/f5/target/classes
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /Users/solidfire/Documents/CloudStack/CloudStack/plugins/
> 
network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java:[411,26]
> error: cannot access Stub
>
> I’ve not seen this “Stub” problem before.
>
> Anyone familiar with what it’s referring to?
>
> Thanks!
> Mike
>



-- 
Rafael Weingärtner






Re: F5 compile issue with 4.5.x

2017-04-04 Thread Rafael Weingärtner
What version of Java 8 (e.g. jdk1.8.0_112)?
I had a similar problem quite a long time ago, the compilation would work
with jdk1.8.0_11 (or JDK 7), but would not work with anything higher.
Did you try using Java JDK 7?

On Tue, Apr 4, 2017 at 4:14 PM, Tutkowski, Mike 
wrote:

> I am running with Java 8 because I typically have been working with 4.10.
> I just needed to go back to 4.5.x for another project I’m working on.
>
> Thanks
>
> On 4/4/17, 2:09 PM, "Rafael Weingärtner" 
> wrote:
>
> I feel that I have seen this before.
> What is your JDK version?
>
> On Tue, Apr 4, 2017 at 4:06 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > Hi,
> >
> > I see the following error now when trying to compile 4.5.x code:
> >
> > [INFO] Compiling 12 source files to /Users/solidfire/Documents/
> > CloudStack/CloudStack/plugins/network-elements/f5/target/classes
> > [INFO] -
> > [ERROR] COMPILATION ERROR :
> > [INFO] -
> > [ERROR] /Users/solidfire/Documents/CloudStack/CloudStack/plugins/
> > network-elements/f5/src/com/cloud/network/resource/F5BigIpRe
> source.java:[411,26]
> > error: cannot access Stub
> >
> > I’ve not seen this “Stub” problem before.
> >
> > Anyone familiar with what it’s referring to?
> >
> > Thanks!
> > Mike
> >
>
>
>
> --
> Rafael Weingärtner
>
>
>


-- 
Rafael Weingärtner


Re: F5 compile issue with 4.5.x

2017-04-04 Thread Tutkowski, Mike
javac 1.8.0_121

By removing F5, though, I just got a successful compile. :)

On 4/4/17, 2:19 PM, "Rafael Weingärtner"  wrote:

What version of Java 8 (e.g. jdk1.8.0_112)?
I had a similar problem quite a long time ago, the compilation would work
with jdk1.8.0_11 (or JDK 7), but would not work with anything higher.
Did you try using Java JDK 7?

On Tue, Apr 4, 2017 at 4:14 PM, Tutkowski, Mike 
wrote:

> I am running with Java 8 because I typically have been working with 4.10.
> I just needed to go back to 4.5.x for another project I’m working on.
>
> Thanks
>
> On 4/4/17, 2:09 PM, "Rafael Weingärtner" 
> wrote:
>
> I feel that I have seen this before.
> What is your JDK version?
>
> On Tue, Apr 4, 2017 at 4:06 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > Hi,
> >
> > I see the following error now when trying to compile 4.5.x code:
> >
> > [INFO] Compiling 12 source files to /Users/solidfire/Documents/
> > CloudStack/CloudStack/plugins/network-elements/f5/target/classes
> > [INFO] -
> > [ERROR] COMPILATION ERROR :
> > [INFO] -
> > [ERROR] /Users/solidfire/Documents/CloudStack/CloudStack/plugins/
> > network-elements/f5/src/com/cloud/network/resource/F5BigIpRe
> source.java:[411,26]
> > error: cannot access Stub
> >
> > I’ve not seen this “Stub” problem before.
> >
> > Anyone familiar with what it’s referring to?
> >
> > Thanks!
> > Mike
> >
>
>
>
> --
> Rafael Weingärtner
>
>
>


-- 
Rafael Weingärtner




[GitHub] cloudstack issue #1834: CLOUDSTACK-9679:Allow master user to manage subordin...

2017-04-04 Thread pdion891
Github user pdion891 commented on the issue:

https://github.com/apache/cloudstack/pull/1834
  
@pdumbre @karuturi @syed 
I thinks this introduce an issue where a domain admin cannot get a template 
by id. 
a domain admin can list feature template and get a template via `ids=` but 
not with `id=`
The example bellow is perform with a domain admin account to list 
public+featured template at root domain:

```
(beta2r1-ninja) > list templates templatefilter=featured filter=name,id
count = 9
template:
+--+-+
|  id  |   name  |
+--+-+
| 513b3a6d-c011-46f0-a4a3-2a954cadb673 |  CoreOS Alpha 1367.5.0  |
| 0c04d876-1f85-45a7-b6f4-504de435bf12 |Debian 8.5 PV base (64bit)   |
| 285f2203-449a-428f-997a-1ffbebbf1382 |   CoreOS Alpha  |
| 332b6ca8-b3d6-42c7-83e5-60fe87be6576 |  CoreOS Stable  |
| 3b705008-c186-464d-ad59-312d902420af |   Windows Server 2016 std SPLA  |
| 4256aebe-a1c1-4b49-9993-de2bc712d521 |   Ubuntu 16.04.01 HVM   |
| 59e6b00a-b88e-4539-aa3c-75c9c7e9fa6c | Ubuntu 14.04.5 HVM base (64bit) |
| 3ab936eb-d8c2-44d8-a64b-17ad5adf8a51 |  CentOS 6.8 PV  |
| 7de5d423-c91e-49cc-86e8-9d6ed6abd997 |  CentOS 7.2 HVM |
+--+-+
(beta2r1-ninja) > list templates templatefilter=featured 
id=7de5d423-c91e-49cc-86e8-9d6ed6abd997 filter=name,id
Error 531: Acct[b285d62e-0ec2-4a7c-b773-961595ec6356-Ninja-5664] does not 
have permission to operate within domain id=c9b4f83d-16eb-11e7-a8b9-367e6fe958a9
cserrorcode = 4365
errorcode = 531
errortext = Acct[b285d62e-0ec2-4a7c-b773-961595ec6356-Ninja-5664] does not 
have permission to operate within domain id=c9b4f83d-16eb-11e7-a8b9-367e6fe958a9
uuidList:
(beta2r1-ninja) > list templates templatefilter=featured 
ids=7de5d423-c91e-49cc-86e8-9d6ed6abd997 filter=name,id
count = 1
template:
+--++
|  id  |  name  |
+--++
| 7de5d423-c91e-49cc-86e8-9d6ed6abd997 | CentOS 7.2 HVM |
+--++
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-04-04 Thread nvazquez
Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
Please ommit my last comment, we were using commons-beanutils version 1.8.3 
instead of 1.9.2

LGTM


[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//DVIXST/results.txt
test_list_clusters_metrics (test_metrics_api.TestMetrics) ... === TestName: 
test_list_clusters_metrics | Status : SUCCESS ===
ok
test_list_hosts_metrics (test_metrics_api.TestMetrics) ... === TestName: 
test_list_hosts_metrics | Status : SUCCESS ===
ok
test_list_infrastructure_metrics (test_metrics_api.TestMetrics) ... === 
TestName: test_list_infrastructure_metrics | Status : SUCCESS ===
ok
test_list_pstorage_metrics (test_metrics_api.TestMetrics) ... === TestName: 
test_list_pstorage_metrics | Status : SUCCESS ===
ok
test_list_vms_metrics (test_metrics_api.TestMetrics) ... === TestName: 
test_list_vms_metrics | Status : SUCCESS ===
ok
test_list_volumes_metrics (test_metrics_api.TestMetrics) ... === TestName: 
test_list_volumes_metrics | Status : SUCCESS ===
ok
test_list_zones_metrics (test_metrics_api.TestMetrics) ... === TestName: 
test_list_zones_metrics | Status : SUCCESS ===
ok

--
Ran 7 tests in 142.134s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...

2017-04-04 Thread mrunalinikankariya
Github user mrunalinikankariya commented on the issue:

https://github.com/apache/cloudstack/pull/1740
  
In ACS, all the snapshots are deleted from primary storage as soon as it is 
successfully backed up and copied on secondary storage, hence this issue is not 
valid for ACS. 

However a ticket should be raised to analysis and understand how 
incremental snapshots work if not a single copy kept on primary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-04 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request:

https://github.com/apache/cloudstack/pull/2026

CLOUDSTACK-9861: Expire VM snapshots after configured duration

Default value of the account level global config vmsnapshot.expire.interval 
is -1 that conforms to legacy behaviour
A positive value will expire the VM snapshots for the respective account in 
that many hours

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack ir25-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2026.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2026


commit 1c6a30a0e65f2bc9b1d97920d1562b35f3b682ee
Author: Abhinandan Prateek 
Date:   2017-03-28T12:07:59Z

CLOUDSTACK-9861: Expire VM snapshots after configured duration
Default value of the account level global config vmsnapshot.expire.interval 
is -1 that conforms to legacy behaviour
A positive value will expire the VM snapshots for the respective account in 
that many hours




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-615


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2026
  
@abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/2026
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2026
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-616


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
@abhinandanprateek a Jenkins job has been kicked to build packages. I'll 
keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at:

https://github.com/apache/cloudstack/pull/2014


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

2017-04-04 Thread kishankavala
Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1996#discussion_r109835294
  
--- Diff: server/src/com/cloud/user/AccountManager.java ---
@@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s
 public static final String MESSAGE_ADD_ACCOUNT_EVENT = 
"Message.AddAccount.Event";
 
 public static final String MESSAGE_REMOVE_ACCOUNT_EVENT = 
"Message.RemoveAccount.Event";
+public static final ConfigKey UseSecretKeyInResponse = new 
ConfigKey(
+"Advanced",
+Boolean.class,
+"use.secret.key.in.response",
+"true",
--- End diff --

As per discussion in PR # 1152, default value should be false. Any failing 
tests due to this change have to be fixed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread blueorangutan
Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2014
  
Packaging result: ✖centos6 ✖centos7 ✖debian. JID-617


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[PROPOSAL] Apache Cloudstack should join the gitbox experiment

2017-04-04 Thread Daan Hoogland
In the Apache foundation an experiment has been going on to host
mirrors of Apache project on github with more write access then just
to the mirror-bot. For those projects committers can merge on github
and put labels on PRs. I want to propose that we join that project and
intend to start a vote on it here, soon.

questions, thoughts?

-- 
Daan


[GitHub] cloudstack issue #1917: CLOUDSTACK-9756: Configure to ignore the ipassoc fai...

2017-04-04 Thread kishankavala
Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/1917
  
Code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---