[GitHub] cloudstack pull request #2032: CLOUDSTACK-9783: corrected the version number...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/2032


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2032: CLOUDSTACK-9783: corrected the version number in met...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/2032
  
LGTM. Build is broken due to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2032: CLOUDSTACK-9783: corrected the version number...

[karuturi]

GitHub user karuturi opened a pull request:

https://github.com/apache/cloudstack/pull/2032

CLOUDSTACK-9783: corrected the version number in metrics pom

master is broken after fwd-merging metrics PR #1944 from 4.9
This is due to the incorrect parent version number in the metrics pom.
Corrected the same to reflect master version number.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack master-fix-after-1944

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2032.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2032


commit e1c76dcc235fd350f87725adaf359619331db278
Author: Rajani Karuturi 
Date:   2017-04-07T04:22:27Z

CLOUDSTACK-9783: corrected the version number in metrics pom

master is broken after fwd-merging metrics PR #1944 from 4.9
This is due to the incorrect parent version number in the metrics pom.
Corrected the same to reflect master version number.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...

[jayapalu]

Github user jayapalu commented on the issue:

https://github.com/apache/cloudstack/pull/2018
  
tag:mergeready


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
master is broken after the merge. Pom version changes


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/2018
  
Understood! Looks good to me.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2023: BUG-ID: CLOUDSTACK-9808 Added system Vm upgrade path...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/2023
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2031: CLOUDSTACK - 8672 : Test PR

[nitin-maharana]

GitHub user nitin-maharana opened a pull request:

https://github.com/apache/cloudstack/pull/2031

CLOUDSTACK - 8672 : Test PR

Currently running with few commit. Please don't review this PR.
According to the result of this PR, I will update in original PR(1859).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-8672-TEST

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2031.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2031


commit 58aec81013b44a2e83052adc2a9f9c802210e7db
Author: Rajesh Battala 
Date:   2015-07-23T08:44:07Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit 2ce10b7d97b63edfb24465dfd22a525f99ee1b90
Author: Priyank Parihar 
Date:   2015-08-07T11:10:00Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit b0b1914985320f62ca3f8c0838ea8e10dd28
Author: Nitin Kumar Maharana 
Date:   2015-08-07T11:40:13Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.

commit 29e4f70742ce0a9b91cb3111bac282b5a0cd8331
Author: Sowmya Krishnan 
Date:   2017-01-25T11:47:43Z

CLOUDSTACK-8672 : NCC Integration with CloudStack.
Marvin Integration Tests for Shared and Dedicated Workflow.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2025: [4.10-blocker] Fix error in restart network in 4.10....

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2025
  
Trillian test result (tid-974)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28997 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2025-t974-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 48 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 350.74 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 165.23 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 66.17 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 260.71 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 275.12 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 534.22 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 515.10 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1447.34 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 559.00 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 756.74 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1303.03 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 151.46 | test_volumes.py
test_08_resize_volume | Success | 156.76 | test_volumes.py
test_07_resize_fail | Success | 161.45 | test_volumes.py
test_06_download_detached_volume | Success | 156.35 | test_volumes.py
test_05_detach_volume | Success | 155.80 | test_volumes.py
test_04_delete_attached_volume | Success | 146.21 | test_volumes.py
test_03_download_attached_volume | Success | 156.38 | test_volumes.py
test_02_attach_volume | Success | 124.19 | test_volumes.py
test_01_create_volume | Success | 711.24 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.23 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 95.74 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 158.74 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 272.72 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.03 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 31.74 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.28 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.87 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.85 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.97 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.18 | test_vm_life_cycle.py
test_01_stop_vm | Success | 40.32 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 40.46 | test_templates.py
test_08_list_system_templates | Success | 0.03 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.18 | test_templates.py
test_01_create_template | Success | 50.51 | test_templates.py
test_10_destroy_cpvm | Success | 161.63 | test_ssvm.py
test_09_destroy_ssvm | Success | 163.55 | test_ssvm.py
test_08_reboot_cpvm | Success | 101.55 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.72 | test_ssvm.py
test_06_stop_cpvm | Success | 131.76 | test_ssvm.py
test_05_stop_ssvm | Success | 163.76 | test_ssvm.py
test_04_cpvm_internals | Success | 1.20 | test_ssvm.py
test_03_ssvm_internals | Success | 3.33 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.13 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.15 | test_ssvm.py
test_02_list_snapshots_with_removed_data_store | Success | 86.88 | 
test_snapshots.py
test_01_snapshot_root_disk | Success | 11.24 | test_snapshots.py
test_04_change_offering_small | Success | 210.50 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.20 | test_secondary_storage.py
test_09_reboot_router | Success | 35.34 | test_routers.py
test_08_start_router | Success | 30.29 | test_routers.py
test_07_stop_router | Success | 10.16 | test_routers.py

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
Trillian test result (tid-973)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29259 seconds
Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1935-t973-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Test completed. 48 look ok, 1 have error(s)


Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_04_rvpc_privategw_static_routes | `Failure` | 335.65 | 
test_privategw_acl.py
test_01_vpc_site2site_vpn | Success | 150.05 | test_vpc_vpn.py
test_01_vpc_remote_access_vpn | Success | 61.16 | test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn | Success | 245.99 | test_vpc_vpn.py
test_02_VPC_default_routes | Success | 264.01 | test_vpc_router_nics.py
test_01_VPC_nics_after_destroy | Success | 553.63 | test_vpc_router_nics.py
test_05_rvpc_multi_tiers | Success | 512.64 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | Success | 1410.93 | 
test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | 
Success | 548.06 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | Success | 745.11 | 
test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1306.39 | 
test_vpc_redundant.py
test_09_delete_detached_volume | Success | 156.51 | test_volumes.py
test_08_resize_volume | Success | 156.45 | test_volumes.py
test_07_resize_fail | Success | 161.44 | test_volumes.py
test_06_download_detached_volume | Success | 156.43 | test_volumes.py
test_05_detach_volume | Success | 150.80 | test_volumes.py
test_04_delete_attached_volume | Success | 151.22 | test_volumes.py
test_03_download_attached_volume | Success | 156.38 | test_volumes.py
test_02_attach_volume | Success | 89.17 | test_volumes.py
test_01_create_volume | Success | 622.16 | test_volumes.py
test_03_delete_vm_snapshots | Success | 275.25 | test_vm_snapshots.py
test_02_revert_vm_snapshots | Success | 100.71 | test_vm_snapshots.py
test_01_create_vm_snapshots | Success | 168.82 | test_vm_snapshots.py
test_deploy_vm_multiple | Success | 272.66 | test_vm_life_cycle.py
test_deploy_vm | Success | 0.03 | test_vm_life_cycle.py
test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | Success | 26.55 | test_vm_life_cycle.py
test_09_expunge_vm | Success | 125.24 | test_vm_life_cycle.py
test_08_migrate_vm | Success | 30.88 | test_vm_life_cycle.py
test_07_restore_vm | Success | 0.13 | test_vm_life_cycle.py
test_06_destroy_vm | Success | 125.81 | test_vm_life_cycle.py
test_03_reboot_vm | Success | 125.84 | test_vm_life_cycle.py
test_02_start_vm | Success | 10.17 | test_vm_life_cycle.py
test_01_stop_vm | Success | 35.29 | test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName | Success | 161.14 | test_templates.py
test_08_list_system_templates | Success | 0.04 | test_templates.py
test_07_list_public_templates | Success | 0.04 | test_templates.py
test_05_template_permissions | Success | 0.05 | test_templates.py
test_04_extract_template | Success | 5.17 | test_templates.py
test_03_delete_template | Success | 5.11 | test_templates.py
test_02_edit_template | Success | 90.13 | test_templates.py
test_01_create_template | Success | 35.41 | test_templates.py
test_10_destroy_cpvm | Success | 161.64 | test_ssvm.py
test_09_destroy_ssvm | Success | 133.24 | test_ssvm.py
test_08_reboot_cpvm | Success | 131.61 | test_ssvm.py
test_07_reboot_ssvm | Success | 133.65 | test_ssvm.py
test_06_stop_cpvm | Success | 131.74 | test_ssvm.py
test_05_stop_ssvm | Success | 163.77 | test_ssvm.py
test_04_cpvm_internals | Success | 1.24 | test_ssvm.py
test_03_ssvm_internals | Success | 3.37 | test_ssvm.py
test_02_list_cpvm_vm | Success | 0.12 | test_ssvm.py
test_01_list_sec_storage_vm | Success | 0.13 | test_ssvm.py
test_02_list_snapshots_with_removed_data_store | Success | 86.81 | 
test_snapshots.py
test_01_snapshot_root_disk | Success | 16.33 | test_snapshots.py
test_04_change_offering_small | Success | 209.54 | test_service_offerings.py
test_03_delete_service_offering | Success | 0.04 | test_service_offerings.py
test_02_edit_service_offering | Success | 0.06 | test_service_offerings.py
test_01_create_service_offering | Success | 0.11 | test_service_offerings.py
test_02_sys_template_ready | Success | 0.14 | test_secondary_storage.py
test_01_sys_vm_start | Success | 0.18 | test_secondary_storage.py
test_09_reboot_router | Success | 35.35 | test_routers.py
test_08_start_router | Success | 30.32 | test_routers.py
test_07_stop_router | Success | 10.18 | test_routers.py

[GitHub] cloudstack issue #2027: Activate NioTest following changes in CLOUDSTACK-934...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2027
  
Thanks @marcaurele that's a good catch! Can you push -f and see why Travis 
failed, if your fix works let's reenable this test! Also, can you edit the PR 
and send it for 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2027: Activate NioTest following changes in CLOUDSTACK-934...

[marcaurele]

Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/2027
  
@rhtyd I found one issue with the test and `NioConnection` class. This kind 
of intermittent problem are always hard to search for a root cause, but after 
lots of logging I finally found why. I updated the PR with the change.

If the main thread running the test is stopped there 
https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L102
 due to context switching, the flag `_isRunning` isn't switched to True by the 
time the NioServer connection handler start it's call loop, and it exits on the 
`while(_isRunning)`

https://github.com/apache/cloudstack/blob/master/utils/src/main/java/com/cloud/utils/nio/NioConnection.java#L125
 directly. Therefore the server isn't listening at all and the connection 
cannot be made. The flag `_isRunning` must be turned `true` before submitting 
the task/thread.

I still digging into Nio thread handler as we are experiencing some problem 
in production when quite a few agents try to connect at the same time to a 
management server. None of them can connect.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: VR Question

[Tutkowski, Mike]

Jayapal: Just an FYI that I haven't had a chance to investigate this yet.

I did notice, however, that the same behavior exists in 4.5.

> On Apr 2, 2017, at 10:13 PM, Jayapal Uradi  
> wrote:
> 
> Hi Mike,
> 
> Can you please check the following
> 1. In  kvm host logs once to see any security group rules got failed.
> 2. Check the VR /etc/dhcphosts.txt entry for the vm is configured
> 3. tcpdump on VR interface to see whether the dhcp request reached to VR.
> 
> Thanks,
> Jayapal
> 
>> On Apr 2, 2017, at 12:34 AM, Tutkowski, Mike  
>> wrote:
>> 
>> I migrated my system VMs (including the VR) to KVM hosts today (from 
>> XenServer hosts).
>> 
>> I still cannot get IP addresses assigned to user VMs in a Basic Zone.
>> 
>> This seems like a 4.10 blocker, too.
>> 
>> Is anyone else able to get IP addresses assigned to user VMs in a Basic Zone 
>> when using KVM?
>> 
>> From: "Tutkowski, Mike" 
>> Date: Wednesday, March 29, 2017 at 7:47 PM
>> To: "dev@cloudstack.apache.org" 
>> Subject: VR Question
>> 
>> Hi,
>> 
>> With 4.10 (master), I’m currently running all of my system VMs (including 
>> the VR) on XenServer. When I create a user VM on VMware, it acquires an IP 
>> address; however, when I create one on KVM, it does not.
>> 
>> All of this is running in a single, basic zone.
>> 
>> Thoughts on this?
>> 
>> Thanks!
>> Mike
> 
> 
> 
> 
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is the 
> property of Accelerite, a Persistent Systems business. It is intended only 
> for the use of the individual or entity to which it is addressed. If you are 
> not the intended recipient, you are not authorized to read, retain, copy, 
> print, distribute or use this message. If you have received this 
> communication in error, please notify the sender and delete all copies of 
> this message. Accelerite, a Persistent Systems business does not accept any 
> liability for virus infected mails.

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

[rashmidixit]

Github user rashmidixit closed the pull request at:

https://github.com/apache/cloudstack/pull/1889


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

[rashmidixit]

GitHub user rashmidixit reopened a pull request:

https://github.com/apache/cloudstack/pull/1889

CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for 
migration in a Zone

Refer to 
[CLOUDSTACK-9718](https://issues.apache.org/jira/browse/CLOUDSTACK-9718) for 
more details.

Problem: All the hosts suitable for VM Migration are not shown in the UI. 
This could
confuse the user as the target host might never be shown in the UI.

Root Cause: The API (findHostsForMigration) always returned page 1 results 
which would
be always <= default.page.size global parameter. Therefore, in case of large
no. of hosts where the result can map to multiple pages, this issue would 
arise.

Solution: 1. Replace drop-down with listView widget.
2. Allow lazy-loading of records on listView's scroll.
3. Show additional parameters (CPU/Memory used) to assist admin in decision 
making.
4. Provide 'Search by host name' to limit the results.

Conflicts:
client/WEB-INF/classes/resources/messages.properties
client/WEB-INF/classes/resources/messages_ja_JP.properties
client/WEB-INF/classes/resources/messages_zh_CN.properties
ui/css/cloudstack3.css
ui/dictionary2.jsp

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9718

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1889


commit d8158fe5f4bcdbe58fac4fde1969253f31cdce47
Author: rashmidixit 
Date:   2017-03-16T10:35:22Z

 CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for 
migration in a Zone

Reviewed-By: Rashmi Dixit

Problem: All the hosts suitable for VM Migration are not shown in the 
UI. This could
confuse the user as the target host might never be shown in the UI.

Root Cause: The API (findHostsForMigration) always returned page 1 
results which would
be always <= default.page.size global parameter. Therefore, in case of 
large
no. of hosts where the result can map to multiple pages, this issue 
would arise.

Solution: 1. Replace drop-down with listView widget.
2. Allow lazy-loading of records on listView's scroll.
3. Show additional parameters (CPU/Memory used) to assist admin in 
decision making.
4. Provide 'Search by host name' to limit the results.

Added change where if there are no hosts found, an empty row with message 
will
appear.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/2030#discussion_r110145877
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -550,15 +552,21 @@ public boolean needRecycle(String workerTag) {
 return true;
 }
 
-// disable time-out check until we have found out a VMware API 
that can check if
-// there are pending tasks on the subject VM
-/*
-if(System.currentTimeMillis() - startTick > 
_hungWorkerTimeout) {
-if(s_logger.isInfoEnabled())
-s_logger.info("Worker VM expired, seconds elapsed: 
" + (System.currentTimeMillis() - startTick) / 1000);
-return true;
-}
- */
+// this time-out check was disabled
+// "until we have found out a VMware API that can check if there 
are pending tasks on the subject VM"
+// but as we expire jobs and those stale worker VMs stay around 
untill an MS reboot we opt in to have them removed anyway
+Long hungWorkerTimeout = 2 * 
(AsyncJobManagerImpl.JobExpireMinutes.value() + 
AsyncJobManagerImpl.JobCancelThresholdMinutes.value()) * MILISECONDS_PER_MINUTE;
+Long letsSayNow = System.currentTimeMillis();
+if(s_vmwareCleanOldWorderVMs.value() && letsSayNow - startTick > 
hungWorkerTimeout) {
+if(s_logger.isInfoEnabled()) {
+s_logger.info("Worker VM expired, seconds elapsed: " + 
(System.currentTimeMillis() - startTick) / 1000);
+}
--- End diff --

For timeouts you may want to use java Duration, that is much cleaner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/2030#discussion_r110145761
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
 ---
@@ -128,6 +129,7 @@
 public class VmwareManagerImpl extends ManagerBase implements 
VmwareManager, VmwareStorageMount, Listener, VmwareDatacenterService, 
Configurable {
 private static final Logger s_logger = 
Logger.getLogger(VmwareManagerImpl.class);
 
+private static final long MILISECONDS_PER_MINUTE = 6;
--- End diff --

MILI typo MILLISECONDS ..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

[ProjectMoon]

Github user ProjectMoon commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r110113725
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -625,15 +627,20 @@ protected ExecutionResult 
cleanupNetworkElementCommand(final IpAssocCommand cmd)
 
 // there is only one ip in this public vlan and removing 
it, so
 // remove the nic
-if (ipsCount == 1 && !ip.isAdd()) {
-removeVif = true;
+if (lastIp != null && lastIp.equalsIgnoreCase("true") && 
!ip.isAdd()) {
--- End diff --

True, but a lot of the other code is already using StringUtils or is moving 
to it. Reviewers in other PRs tend to recommend it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r110112007
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final 
PublicIpAddress o2) {
 associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
 }
 
+// for network if the ips does not have any rules, then only 
last ip
+List userIps = 
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(), 
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+// check onetoonenat and also check if the ip "add":false. 
If there are 2 PF remove 1 static nat add
+if (ip.isOneToOneNat() && ip.getRuleState() == null) {
+ipsStaticNat++;
+}
+}
+
 final IpAssocCommand cmd = new IpAssocCommand(ipsToSend);
 cmd.setAccessDetail(NetworkElementCommand.ROUTER_IP, 
_routerControlHelper.getRouterControlIp(router.getId()));
 cmd.setAccessDetail(NetworkElementCommand.ROUTER_GUEST_IP, 
_routerControlHelper.getRouterIpInNetwork(associatedWithNetworkId, 
router.getId()));
 cmd.setAccessDetail(NetworkElementCommand.ROUTER_NAME, 
router.getInstanceName());
 final DataCenterVO dcVo = 
_dcDao.findById(router.getDataCenterId());
 cmd.setAccessDetail(NetworkElementCommand.ZONE_NETWORK_TYPE, 
dcVo.getNetworkType().toString());
 
+// if there 1 static nat then it will be checked for remove at 
the resource
+if (ipsWithrules == 0 && ipsStaticNat == 0 ) {
--- End diff --

If we check the ipsStaticNat=1 then we will miss the case of disabling 
static nat on  network with 1 with static nat.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1908#discussion_r11089
  
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final 
PublicIpAddress o2) {
 associatedWithNetworkId = ipAddrList.get(0).getNetworkId();
 }
 
+// for network if the ips does not have any rules, then only 
last ip
+List userIps = 
_ipAddressDao.listByAssociatedNetwork(associatedWithNetworkId, null);
+
+int ipsWithrules = 0;
+int ipsStaticNat = 0;
+for (IPAddressVO ip : userIps) {
+if ( _rulesDao.countRulesByIpIdAndState(ip.getId(), 
FirewallRule.State.Active) > 0 ) {
+ipsWithrules++;
+}
+
+// check onetoonenat and also check if the ip "add":false. 
If there are 2 PF remove 1 static nat add
+if (ip.isOneToOneNat() && ip.getRuleState() == null) {
--- End diff --

In this case rule state is not set. It is null. I will improve the comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[rashmidixit]

Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@karuturi I have rebased with master and pushed. I still see failures in 
Travis but they dont seem to be with my changes. Can you please check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

[DaanHoogland]

GitHub user DaanHoogland opened a pull request:

https://github.com/apache/cloudstack/pull/2030

WIP: CLOUDSTACK-9864 cleanup stale worker VMs after job expiry time



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack snapshot-housekeeping

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2030.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2030


commit 40869570fc510fac0d2357f272e96cd4a4518176
Author: Daan Hoogland 
Date:   2017-03-30T14:35:37Z

CE-113 trace logging and rethrow instead of nesting CloudRuntimeException

commit 66d7d846352d52cc539b1dafb5e4d0f1620829a5
Author: Daan Hoogland 
Date:   2017-04-05T12:19:14Z

CE-113 configure workervm gc based on job expiry

commit 996f5834e6a0a9e4dc57d436ceeb5b89e6dc9974
Author: Daan Hoogland 
Date:   2017-04-05T15:35:41Z

CE-113 extra trace log of worker VMs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/2026
  
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been 
kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2026
  
LGTM (did not test it).
@blueorangutan test centos7 vmware-55u3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/2026#discussion_r110098624
  
--- Diff: setup/db/db/schema-4920to41000.sql ---
@@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size 
IS NULL) AND
 
 -- CLOUDSTACK-9827: Storage tags stored in multiple places
 DROP VIEW IF EXISTS `cloud`.`storage_tag_view`;
+
+INSERT IGNORE INTO `cloud`.`configuration` VALUES ('Advanced', 'DEFAULT', 
'VMSanpshotManager', 'vmsnapshot.expire.interval', '-1', 'VM Snapshot expire 
interval in hours','-1', NULL, 'Account', 0);
--- End diff --

@abhinandanprateek Since you've used Configkey, no need to use this INSERT 
query. Also typo in the 'VMSanpshotManager'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/2001
  
@LGTM on code review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you 
posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1879
  
@sureshanaparti sure
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2027: Activate NioTest following changes in CLOUDSTACK-934...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2027
  
@marcaurele the test makes use of threads to run various clients and server 
instances and is known to consume ports for the same, for these reasons it 
might fail in some test/build environments. If you look at the git history on 
this test file and on the pom.xml, you'll find that this test had been disabled 
in the past (before PR 1493) due to these issues. The test is known to fail 
intermittently in CI environments such as Jenkins and Travis, which is why I 
added to the ignored list of test with one of the PRs.

On my workstation, I've been consistently able to run and pass it, it is 
likely an environment issue in your laptop if this is failing inconsistently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2024
  
LGTM, @karuturi this is ready for merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

[abhinandanprateek]

Github user abhinandanprateek closed the pull request at:

https://github.com/apache/cloudstack/pull/2029


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/2024
  
@rhtyd @karuturi here is the cherry picked PR on 4.9 
https://github.com/apache/cloudstack/pull/2029


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

[abhinandanprateek]

GitHub user abhinandanprateek opened a pull request:

https://github.com/apache/cloudstack/pull/2029

CLOUDSTACK-9857: With this change if agent dies the systemd will catc…

…h it properly and show process as exited

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9857-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/2029.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2029


commit f5b952939b0fbffcdedc6f369e60502f771d0ac9
Author: Abhinandan Prateek 
Date:   2017-04-03T10:46:21Z

CLOUDSTACK-9857: With this change if agent dies the systemd will catch it 
properly and show process as exited




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1864: [Defunct][Experimental]Switch to using JDK 1.8 and S...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1864
  
@wido no, I'm not working on this presently. Though, I've kept it open as a 
reminder that we need to indeed work on updating the ssvm code to Debian8. Part 
of the issue is between Debian7 and Debian8, systemd's introducing causes 
issues with expecting our VR/ssvm codebase to work out of the box, 
cloud-early-config does not work as it's a init-d script.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@anshul1886 I've left a comment, the code to check and remove snapshot on 
allocated state is already in that method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1282#discussion_r110092518
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
 return true;
 }
 
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --

See 
https://github.com/apache/cloudstack/pull/1282/files#diff-2b08c10a0eea4bef15bece6ff38ed1f9R223


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1282#discussion_r110092478
  
--- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
 return true;
 }
 
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --

@anshul1886 the code to check and remove snapshot when they are stuck in 
Allocated state is already in line 223 above, in the same method. Why this 
redundancy, is this a synchronization issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1951
  
Ping @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1980
  
@karuturi this is ready for merge, has the screenshots and lgtms


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
Thanks @nvazquez @karuturi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...

[rhtyd]

Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
Thanks @karuturi the failures are not related to the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Need help in getting CentOS 7 templates to run on Cloudstack 4.9 and VMWare

[Nux!]

Syed,

Can you try this and let me know if it works better?
http://jenkins.openvm.eu/cloudstack/centos/x86_64/centos-7-vmware.ova

I've removed NetworkManager

--
Sent from the Delta quadrant using Borg technology!

Nux!
www.nux.ro

- Original Message -
> From: "Nux!" 
> To: "dev" 
> Sent: Wednesday, 5 April, 2017 19:21:13
> Subject: Re: Need help in getting CentOS 7 templates to run on Cloudstack 4.9 
> and VMWare

> Syed,
> 
> NetworkManager strikes again! ... I'll make sure it disappears from the
> template. Darn ...
> 
> The centos user password as set by the kickstart is indeed "password" so the
> template can be accessed should cloud-init fail.
> I am not entirely at peace with this as could lead to security problems.
> 
> The thing is, if cloud-init fails to retrieve the metadata, then it will not
> continue the setup in which it adds the user to sudoers, setup swap etc etc.
> 
> That is why you could login with "password" but everything else was broken.
> 
> Thanks for spotting this.
> 
> --
> Sent from the Delta quadrant using Borg technology!
> 
> Nux!
> www.nux.ro
> 
> - Original Message -
>> From: "Syed Ahmed" 
>> To: "dev" 
>> Cc: "Nux!" 
>> Sent: Wednesday, 5 April, 2017 16:41:27
>> Subject: Re: Need help in getting CentOS 7 templates to run on Cloudstack 4.9
>> and VMWare
> 
>> Hi Nux,
>> 
>> So I'm still having trouble with the template :)
>> 
>> As per the configuration
>> http://dl.openvm.eu/cloudstack/config/centos/centos7-vmware.cfg the
>> `centos` user gets the password set to as `password` but is never added to
>> the sudoers list. When does that happen? Also, From the cloud-init logs it
>> looks like it's not using the DHCP server but the default gateway so things
>> like ssh-key is not being set.
>> 
>> Apr  5 15:17:26 syed-test cloud-init: Cloud-init v. 0.7.5 running
>> 'init-local' at Wed, 05 Apr 2017 15:17:26 +. Up 8.99 seconds.
>> Apr  5 15:18:13 syed-test cloud-init: Cloud-init v. 0.7.5 running 'init' at
>> Wed, 05 Apr 2017 15:18:13 +. Up 16.84 seconds.
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> ++Net device info+++
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> ++--+--+---+---+
>> Apr  5 15:18:13 syed-test cloud-init: ci-info: | Device |  Up  |
>> Address|  Mask | Hw-Address|
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> ++--+--+---+---+
>> Apr  5 15:18:13 syed-test cloud-init: ci-info: |  lo:   | True |
>> 127.0.0.1   |   255.0.0.0   | . |
>> Apr  5 15:18:13 syed-test cloud-init: ci-info: | eth0:  | True |
>> 172.31.0.130 | 255.255.254.0 | 06:5a:58:00:01:6a |
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> ++--+--+---+---+
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> +++Route info+++
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> +---+-++---+---+---+
>> Apr  5 15:18:13 syed-test cloud-init: ci-info: | Route | Destination |
>> Gateway   |Genmask| Interface | Flags |
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> +---+-++---+---+---+
>> Apr  5 15:18:13 syed-test cloud-init: ci-info: |   0   |   0.0.0.0   |
>> 172.31.0.1 |0.0.0.0|eth0   |   UG  |
>> Apr  5 15:18:13 syed-test cloud-init: ci-info: |   1   |  172.31.0.0 |
>> 0.0.0.0   | 255.255.254.0 |eth0   |   U   |
>> Apr  5 15:18:13 syed-test cloud-init: ci-info:
>> +---+-++---+---+---+
>> Apr  5 15:19:03 syed-test cloud-init: 2017-04-05 15:19:03,970 -
>> url_helper.py[WARNING]: Calling '
>> http://172.31.0.1//latest/meta-data/instance-id' failed [50/120s]:
>> unexpected error ['NoneType' object has no attribute 'status_code']
>> Apr  5 15:19:55 syed-test cloud-init: 2017-04-05 15:19:55,026 -
>> url_helper.py[WARNING]: Calling '
>> http://172.31.0.1//latest/meta-data/instance-id' failed [101/120s]:
>> unexpected error ['NoneType' object has no attribute 'status_code']
>> Apr  5 15:20:13 syed-test cloud-init: 2017-04-05 15:20:13,048 -
>> url_helper.py[WARNING]: Calling '
>> http://172.31.0.1//latest/meta-data/instance-id' failed [119/120s]:
>> unexpected error ['NoneType' object has no attribute 'status_code']
>> Apr  5 15:20:14 syed-test cloud-init: 2017-04-05 15:20:14,050 -
>> DataSourceCloudStack.py[CRITICAL]: Giving up on waiting for the metadata
>> from ['http://172.31.0.1//latest/meta-data/instance-id'] after 120 seconds
>> Apr  5 15:20:14 syed-test cloud-init: 2017-04-05 15:20:14,050 -
>> util.py[WARNING]: No instance datasource found! Likely bad things to come!
>> 
>> Looking 

[GitHub] cloudstack pull request #1880: CLOUDSTACK-9720: [VMware] template_spool_ref ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1880


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
The above tests failure are not related to this PR. These are failing most 
for the other PRs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1282
  
@swill @rhtyd can you review?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1944


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
merging now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #2022: CLOUDSTACK-9591: Fix systemvmtemplate to not include...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/2022
  
@rhtyd can you check on the failures if they are related?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1889
  
@rashmidixit  travis is failing. Can you rebase with master and force push?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---