Re: CS 4.10 to 4.11.1 upgrade error
Yep, Daan. I found sql files for 4.10 to 4.11 to 4.11.1 upgrade, run them with mysql client, as for the file with procedures definition, I added "delimiter ENDTHAT" in the beginning and "ENDTHAT" in the end and runned it with "mysql <" as well. пн, 28 мая 2018 г., 20:10 Daan Hoogland: > so you did tackle the problem? can you share your workaround? > > On Mon, May 28, 2018 at 3:08 PM, Ivan Kudryavtsev < > kudryavtsev...@bw-sw.com> > wrote: > > > Hello, Daan, I'll try to find it tomorrow and share, unfortunately I'm > not > > confident that I didn't wiped it when tackled the problem, but I'll share > > if it still in place. > > > > пн, 28 мая 2018 г., 19:50 Daan Hoogland : > > > > > Ivan can you share the log bit during startup where it tries to run the > > > 41000to41100 sql file? > > > > > > On Mon, May 28, 2018 at 1:03 PM, Ivan Kudryavtsev < > > > kudryavtsev...@bw-sw.com> > > > wrote: > > > > > > > Hello, yes It looks like the problem is like that, I just suggested > it > > > > could be connected with 'delimiter' because that sql file isn't > > evaluated > > > > in "mysql < file" mode without problems with default ";", but other > > > options > > > > also could work as well. But, the outcome is that 4.10 failed to > > > > automatically upgrade to 4.11.1 rc in my case. Have a good time. > > > > > > > > пн, 28 мая 2018 г., 16:41 Ernie Janse van Rensburg < > > > > ernie.jvrensb...@shapeblue.com>: > > > > > > > > > it seems that when someone installs 4.11.1, the > > > > > META-INF/db/schema-41000to41100.sql file doesn't get executed, > > > > therefore, > > > > > the idempotent stored procedures do not get created > > > > > > > > > > > > > > > From: Ivan Kudryavtsev > > > > > Sent: Saturday, May 26, 2018 5:26:09 PM > > > > > To: dev > > > > > Subject: Re: CS 4.10 to 4.11.1 upgrade error > > > > > > > > > > Rafael, I have read that thread and mentioned it above, but those > sql > > > > > expressions are not connected with the problem above. > > > > > > > > > > сб, 26 мая 2018 г., 22:23 Rafael Weingärtner < > > > > rafaelweingart...@gmail.com > > > > > >: > > > > > > > > > > > Hmm... Isn't there a problem to migrate from 4.10 to 4.11 that is > > > going > > > > > to > > > > > > be fixed in 4.11.1? > > > > > > > > > > > > On Sat, May 26, 2018 at 12:19 PM, Ivan Kudryavtsev < > > > > > > kudryavtsev...@bw-sw.com > > > > > > > wrote: > > > > > > > > > > > > > Hi, Rafael. The first procedure creation > > > > > > > > > > > > > > CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` ( > > > > > > > IN in_table_name VARCHAR(200) > > > > > > > , IN in_column_name VARCHAR(200) > > > > > > > , IN in_column_definition VARCHAR(1000) > > > > > > > ) > > > > > > > BEGIN > > > > > > > > > > > > > > DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = > > > > > > > CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, > ' > > ', > > > > > > > 'ADD COLUMN') ; SET @ddl = CONCAT(@ddl, ' ', in_column_name); > SET > > > > @ddl > > > > > > > = CONCAT(@ddl, ' ', in_column_definition); PREPARE stmt FROM > > @ddl; > > > > > > > EXECUTE stmt; DEALLOCATE PREPARE stmt; END; > > > > > > > > > > > > > > Doesn't work in freshly installed mysql, I suppose other > similar > > > > > > > expressions fail too without custom delimiter specification, at > > > > least I > > > > > > see > > > > > > > that in native mysql console. I found that during upgrade from > > 4.10 > > > > to > > > > > > > 4.11.1 the tables weren't altered (take a look at the first > > > e-mail), > > > > > so I > > > > > > > started to find where that alteration happens and found the > file > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > > > schema-41000to41100.sql > > > > > > > > > > > > > > where that stored procedure is created, it seems that a > migration > > > > > process > > > > > > > failed to run that file content during the migration, > otherwise, > > I > > > > > don't > > > > > > > catch how it could happen, that whole file or its part skipped > > > during > > > > > > 4.10 > > > > > > > to 4.11 upgrade. > > > > > > > > > > > > > > May be the migration code includes the delimiter, but whole > file > > is > > > > > > skipped > > > > > > > during db upgrade by the unknown reason, I haven't looked to > the > > > > > > migration > > > > > > > code, so don't have other details, but I know for sure that > > > migration > > > > > > took > > > > > > > place because it was failing until I uploaded new system vm > > > template > > > > > and > > > > > > > "looks-like-succeeded" without errors after that. > > > > > > > > > > > > > > > > > > > > > сб, 26 мая 2018 г., 19:03 Rafael Weingärtner < > > > > > > rafaelweingart...@gmail.com > > > > > > > >: > > > > > > > > > > > > > > > What
Re: CS 4.10 to 4.11.1 upgrade error
so you did tackle the problem? can you share your workaround? On Mon, May 28, 2018 at 3:08 PM, Ivan Kudryavtsevwrote: > Hello, Daan, I'll try to find it tomorrow and share, unfortunately I'm not > confident that I didn't wiped it when tackled the problem, but I'll share > if it still in place. > > пн, 28 мая 2018 г., 19:50 Daan Hoogland : > > > Ivan can you share the log bit during startup where it tries to run the > > 41000to41100 sql file? > > > > On Mon, May 28, 2018 at 1:03 PM, Ivan Kudryavtsev < > > kudryavtsev...@bw-sw.com> > > wrote: > > > > > Hello, yes It looks like the problem is like that, I just suggested it > > > could be connected with 'delimiter' because that sql file isn't > evaluated > > > in "mysql < file" mode without problems with default ";", but other > > options > > > also could work as well. But, the outcome is that 4.10 failed to > > > automatically upgrade to 4.11.1 rc in my case. Have a good time. > > > > > > пн, 28 мая 2018 г., 16:41 Ernie Janse van Rensburg < > > > ernie.jvrensb...@shapeblue.com>: > > > > > > > it seems that when someone installs 4.11.1, the > > > > META-INF/db/schema-41000to41100.sql file doesn't get executed, > > > therefore, > > > > the idempotent stored procedures do not get created > > > > > > > > > > > > From: Ivan Kudryavtsev > > > > Sent: Saturday, May 26, 2018 5:26:09 PM > > > > To: dev > > > > Subject: Re: CS 4.10 to 4.11.1 upgrade error > > > > > > > > Rafael, I have read that thread and mentioned it above, but those sql > > > > expressions are not connected with the problem above. > > > > > > > > сб, 26 мая 2018 г., 22:23 Rafael Weingärtner < > > > rafaelweingart...@gmail.com > > > > >: > > > > > > > > > Hmm... Isn't there a problem to migrate from 4.10 to 4.11 that is > > going > > > > to > > > > > be fixed in 4.11.1? > > > > > > > > > > On Sat, May 26, 2018 at 12:19 PM, Ivan Kudryavtsev < > > > > > kudryavtsev...@bw-sw.com > > > > > > wrote: > > > > > > > > > > > Hi, Rafael. The first procedure creation > > > > > > > > > > > > CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` ( > > > > > > IN in_table_name VARCHAR(200) > > > > > > , IN in_column_name VARCHAR(200) > > > > > > , IN in_column_definition VARCHAR(1000) > > > > > > ) > > > > > > BEGIN > > > > > > > > > > > > DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = > > > > > > CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' > ', > > > > > > 'ADD COLUMN') ; SET @ddl = CONCAT(@ddl, ' ', in_column_name); SET > > > @ddl > > > > > > = CONCAT(@ddl, ' ', in_column_definition); PREPARE stmt FROM > @ddl; > > > > > > EXECUTE stmt; DEALLOCATE PREPARE stmt; END; > > > > > > > > > > > > Doesn't work in freshly installed mysql, I suppose other similar > > > > > > expressions fail too without custom delimiter specification, at > > > least I > > > > > see > > > > > > that in native mysql console. I found that during upgrade from > 4.10 > > > to > > > > > > 4.11.1 the tables weren't altered (take a look at the first > > e-mail), > > > > so I > > > > > > started to find where that alteration happens and found the file > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > > schema-41000to41100.sql > > > > > > > > > > > > where that stored procedure is created, it seems that a migration > > > > process > > > > > > failed to run that file content during the migration, otherwise, > I > > > > don't > > > > > > catch how it could happen, that whole file or its part skipped > > during > > > > > 4.10 > > > > > > to 4.11 upgrade. > > > > > > > > > > > > May be the migration code includes the delimiter, but whole file > is > > > > > skipped > > > > > > during db upgrade by the unknown reason, I haven't looked to the > > > > > migration > > > > > > code, so don't have other details, but I know for sure that > > migration > > > > > took > > > > > > place because it was failing until I uploaded new system vm > > template > > > > and > > > > > > "looks-like-succeeded" without errors after that. > > > > > > > > > > > > > > > > > > сб, 26 мая 2018 г., 19:03 Rafael Weingärtner < > > > > > rafaelweingart...@gmail.com > > > > > > >: > > > > > > > > > > > > > What line are you talking about? > > > > > > > > > > > > > > On Sat, May 26, 2018 at 3:54 AM, Ivan Kudryavtsev < > > > > > > > kudryavtsev...@bw-sw.com> > > > > > > > wrote: > > > > > > > > > > > > > > > After I manually set delimiter ENDTHAT in the beginning of > the > > > file > > > > > and > > > > > > > in > > > > > > > > the end, expressions have been correctly processed and > upgrade > > > path > > > > > > > > completed well. I was able to start 4.11.1 and it functions > > well. > > > > > > > > > > > > > > > > 2018-05-26 12:52 GMT+07:00 Ivan Kudryavtsev < > > > > >
Re: CS 4.10 to 4.11.1 upgrade error
Hello, Daan, I'll try to find it tomorrow and share, unfortunately I'm not confident that I didn't wiped it when tackled the problem, but I'll share if it still in place. пн, 28 мая 2018 г., 19:50 Daan Hoogland: > Ivan can you share the log bit during startup where it tries to run the > 41000to41100 sql file? > > On Mon, May 28, 2018 at 1:03 PM, Ivan Kudryavtsev < > kudryavtsev...@bw-sw.com> > wrote: > > > Hello, yes It looks like the problem is like that, I just suggested it > > could be connected with 'delimiter' because that sql file isn't evaluated > > in "mysql < file" mode without problems with default ";", but other > options > > also could work as well. But, the outcome is that 4.10 failed to > > automatically upgrade to 4.11.1 rc in my case. Have a good time. > > > > пн, 28 мая 2018 г., 16:41 Ernie Janse van Rensburg < > > ernie.jvrensb...@shapeblue.com>: > > > > > it seems that when someone installs 4.11.1, the > > > META-INF/db/schema-41000to41100.sql file doesn't get executed, > > therefore, > > > the idempotent stored procedures do not get created > > > > > > > > > From: Ivan Kudryavtsev > > > Sent: Saturday, May 26, 2018 5:26:09 PM > > > To: dev > > > Subject: Re: CS 4.10 to 4.11.1 upgrade error > > > > > > Rafael, I have read that thread and mentioned it above, but those sql > > > expressions are not connected with the problem above. > > > > > > сб, 26 мая 2018 г., 22:23 Rafael Weingärtner < > > rafaelweingart...@gmail.com > > > >: > > > > > > > Hmm... Isn't there a problem to migrate from 4.10 to 4.11 that is > going > > > to > > > > be fixed in 4.11.1? > > > > > > > > On Sat, May 26, 2018 at 12:19 PM, Ivan Kudryavtsev < > > > > kudryavtsev...@bw-sw.com > > > > > wrote: > > > > > > > > > Hi, Rafael. The first procedure creation > > > > > > > > > > CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` ( > > > > > IN in_table_name VARCHAR(200) > > > > > , IN in_column_name VARCHAR(200) > > > > > , IN in_column_definition VARCHAR(1000) > > > > > ) > > > > > BEGIN > > > > > > > > > > DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = > > > > > CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', > > > > > 'ADD COLUMN') ; SET @ddl = CONCAT(@ddl, ' ', in_column_name); SET > > @ddl > > > > > = CONCAT(@ddl, ' ', in_column_definition); PREPARE stmt FROM @ddl; > > > > > EXECUTE stmt; DEALLOCATE PREPARE stmt; END; > > > > > > > > > > Doesn't work in freshly installed mysql, I suppose other similar > > > > > expressions fail too without custom delimiter specification, at > > least I > > > > see > > > > > that in native mysql console. I found that during upgrade from 4.10 > > to > > > > > 4.11.1 the tables weren't altered (take a look at the first > e-mail), > > > so I > > > > > started to find where that alteration happens and found the file > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > schema-41000to41100.sql > > > > > > > > > > where that stored procedure is created, it seems that a migration > > > process > > > > > failed to run that file content during the migration, otherwise, I > > > don't > > > > > catch how it could happen, that whole file or its part skipped > during > > > > 4.10 > > > > > to 4.11 upgrade. > > > > > > > > > > May be the migration code includes the delimiter, but whole file is > > > > skipped > > > > > during db upgrade by the unknown reason, I haven't looked to the > > > > migration > > > > > code, so don't have other details, but I know for sure that > migration > > > > took > > > > > place because it was failing until I uploaded new system vm > template > > > and > > > > > "looks-like-succeeded" without errors after that. > > > > > > > > > > > > > > > сб, 26 мая 2018 г., 19:03 Rafael Weingärtner < > > > > rafaelweingart...@gmail.com > > > > > >: > > > > > > > > > > > What line are you talking about? > > > > > > > > > > > > On Sat, May 26, 2018 at 3:54 AM, Ivan Kudryavtsev < > > > > > > kudryavtsev...@bw-sw.com> > > > > > > wrote: > > > > > > > > > > > > > After I manually set delimiter ENDTHAT in the beginning of the > > file > > > > and > > > > > > in > > > > > > > the end, expressions have been correctly processed and upgrade > > path > > > > > > > completed well. I was able to start 4.11.1 and it functions > well. > > > > > > > > > > > > > > 2018-05-26 12:52 GMT+07:00 Ivan Kudryavtsev < > > > > kudryavtsev...@bw-sw.com > > > > > >: > > > > > > > > > > > > > > > The problem is with that file: > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/ > > 9187392ff9cd33b53d5b251076fee2 > > > > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > > > > schema-41000to41100.sql > > > > > > > > > > > > > > > > The expressions don't run on mysql and maria as well
Re: CS 4.10 to 4.11.1 upgrade error
Ivan can you share the log bit during startup where it tries to run the 41000to41100 sql file? On Mon, May 28, 2018 at 1:03 PM, Ivan Kudryavtsevwrote: > Hello, yes It looks like the problem is like that, I just suggested it > could be connected with 'delimiter' because that sql file isn't evaluated > in "mysql < file" mode without problems with default ";", but other options > also could work as well. But, the outcome is that 4.10 failed to > automatically upgrade to 4.11.1 rc in my case. Have a good time. > > пн, 28 мая 2018 г., 16:41 Ernie Janse van Rensburg < > ernie.jvrensb...@shapeblue.com>: > > > it seems that when someone installs 4.11.1, the > > META-INF/db/schema-41000to41100.sql file doesn't get executed, > therefore, > > the idempotent stored procedures do not get created > > > > > > From: Ivan Kudryavtsev > > Sent: Saturday, May 26, 2018 5:26:09 PM > > To: dev > > Subject: Re: CS 4.10 to 4.11.1 upgrade error > > > > Rafael, I have read that thread and mentioned it above, but those sql > > expressions are not connected with the problem above. > > > > сб, 26 мая 2018 г., 22:23 Rafael Weingärtner < > rafaelweingart...@gmail.com > > >: > > > > > Hmm... Isn't there a problem to migrate from 4.10 to 4.11 that is going > > to > > > be fixed in 4.11.1? > > > > > > On Sat, May 26, 2018 at 12:19 PM, Ivan Kudryavtsev < > > > kudryavtsev...@bw-sw.com > > > > wrote: > > > > > > > Hi, Rafael. The first procedure creation > > > > > > > > CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` ( > > > > IN in_table_name VARCHAR(200) > > > > , IN in_column_name VARCHAR(200) > > > > , IN in_column_definition VARCHAR(1000) > > > > ) > > > > BEGIN > > > > > > > > DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = > > > > CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', > > > > 'ADD COLUMN') ; SET @ddl = CONCAT(@ddl, ' ', in_column_name); SET > @ddl > > > > = CONCAT(@ddl, ' ', in_column_definition); PREPARE stmt FROM @ddl; > > > > EXECUTE stmt; DEALLOCATE PREPARE stmt; END; > > > > > > > > Doesn't work in freshly installed mysql, I suppose other similar > > > > expressions fail too without custom delimiter specification, at > least I > > > see > > > > that in native mysql console. I found that during upgrade from 4.10 > to > > > > 4.11.1 the tables weren't altered (take a look at the first e-mail), > > so I > > > > started to find where that alteration happens and found the file > > > > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > schema-41000to41100.sql > > > > > > > > where that stored procedure is created, it seems that a migration > > process > > > > failed to run that file content during the migration, otherwise, I > > don't > > > > catch how it could happen, that whole file or its part skipped during > > > 4.10 > > > > to 4.11 upgrade. > > > > > > > > May be the migration code includes the delimiter, but whole file is > > > skipped > > > > during db upgrade by the unknown reason, I haven't looked to the > > > migration > > > > code, so don't have other details, but I know for sure that migration > > > took > > > > place because it was failing until I uploaded new system vm template > > and > > > > "looks-like-succeeded" without errors after that. > > > > > > > > > > > > сб, 26 мая 2018 г., 19:03 Rafael Weingärtner < > > > rafaelweingart...@gmail.com > > > > >: > > > > > > > > > What line are you talking about? > > > > > > > > > > On Sat, May 26, 2018 at 3:54 AM, Ivan Kudryavtsev < > > > > > kudryavtsev...@bw-sw.com> > > > > > wrote: > > > > > > > > > > > After I manually set delimiter ENDTHAT in the beginning of the > file > > > and > > > > > in > > > > > > the end, expressions have been correctly processed and upgrade > path > > > > > > completed well. I was able to start 4.11.1 and it functions well. > > > > > > > > > > > > 2018-05-26 12:52 GMT+07:00 Ivan Kudryavtsev < > > > kudryavtsev...@bw-sw.com > > > > >: > > > > > > > > > > > > > The problem is with that file: > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/ > 9187392ff9cd33b53d5b251076fee2 > > > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > > > schema-41000to41100.sql > > > > > > > > > > > > > > The expressions don't run on mysql and maria as well without > the > > > > > > delimiter. > > > > > > > > > > > > > > 2018-05-26 12:27 GMT+07:00 Ivan Kudryavtsev < > > > > kudryavtsev...@bw-sw.com > > > > > >: > > > > > > > > > > > > > >> Hello, I found that db upgrade routing is incompatible at > least > > > with > > > > > > >> MariaDB 10.2.10 > > > > > > >> > > > > > > >> 2018-05-26 12:03 GMT+07:00 Ivan Kudryavtsev < > > > > kudryavtsev...@bw-sw.com > > > > > >: > > > > > > >> > > > > > > >>> Hello, Devs. During upgrade I got an error about
Re: CS 4.10 to 4.11.1 upgrade error
Hello, yes It looks like the problem is like that, I just suggested it could be connected with 'delimiter' because that sql file isn't evaluated in "mysql < file" mode without problems with default ";", but other options also could work as well. But, the outcome is that 4.10 failed to automatically upgrade to 4.11.1 rc in my case. Have a good time. пн, 28 мая 2018 г., 16:41 Ernie Janse van Rensburg < ernie.jvrensb...@shapeblue.com>: > it seems that when someone installs 4.11.1, the > META-INF/db/schema-41000to41100.sql file doesn't get executed, therefore, > the idempotent stored procedures do not get created > > > From: Ivan Kudryavtsev> Sent: Saturday, May 26, 2018 5:26:09 PM > To: dev > Subject: Re: CS 4.10 to 4.11.1 upgrade error > > Rafael, I have read that thread and mentioned it above, but those sql > expressions are not connected with the problem above. > > сб, 26 мая 2018 г., 22:23 Rafael Weingärtner >: > > > Hmm... Isn't there a problem to migrate from 4.10 to 4.11 that is going > to > > be fixed in 4.11.1? > > > > On Sat, May 26, 2018 at 12:19 PM, Ivan Kudryavtsev < > > kudryavtsev...@bw-sw.com > > > wrote: > > > > > Hi, Rafael. The first procedure creation > > > > > > CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` ( > > > IN in_table_name VARCHAR(200) > > > , IN in_column_name VARCHAR(200) > > > , IN in_column_definition VARCHAR(1000) > > > ) > > > BEGIN > > > > > > DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = > > > CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', > > > 'ADD COLUMN') ; SET @ddl = CONCAT(@ddl, ' ', in_column_name); SET @ddl > > > = CONCAT(@ddl, ' ', in_column_definition); PREPARE stmt FROM @ddl; > > > EXECUTE stmt; DEALLOCATE PREPARE stmt; END; > > > > > > Doesn't work in freshly installed mysql, I suppose other similar > > > expressions fail too without custom delimiter specification, at least I > > see > > > that in native mysql console. I found that during upgrade from 4.10 to > > > 4.11.1 the tables weren't altered (take a look at the first e-mail), > so I > > > started to find where that alteration happens and found the file > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > schema-41000to41100.sql > > > > > > where that stored procedure is created, it seems that a migration > process > > > failed to run that file content during the migration, otherwise, I > don't > > > catch how it could happen, that whole file or its part skipped during > > 4.10 > > > to 4.11 upgrade. > > > > > > May be the migration code includes the delimiter, but whole file is > > skipped > > > during db upgrade by the unknown reason, I haven't looked to the > > migration > > > code, so don't have other details, but I know for sure that migration > > took > > > place because it was failing until I uploaded new system vm template > and > > > "looks-like-succeeded" without errors after that. > > > > > > > > > сб, 26 мая 2018 г., 19:03 Rafael Weingärtner < > > rafaelweingart...@gmail.com > > > >: > > > > > > > What line are you talking about? > > > > > > > > On Sat, May 26, 2018 at 3:54 AM, Ivan Kudryavtsev < > > > > kudryavtsev...@bw-sw.com> > > > > wrote: > > > > > > > > > After I manually set delimiter ENDTHAT in the beginning of the file > > and > > > > in > > > > > the end, expressions have been correctly processed and upgrade path > > > > > completed well. I was able to start 4.11.1 and it functions well. > > > > > > > > > > 2018-05-26 12:52 GMT+07:00 Ivan Kudryavtsev < > > kudryavtsev...@bw-sw.com > > > >: > > > > > > > > > > > The problem is with that file: > > > > > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > > schema-41000to41100.sql > > > > > > > > > > > > The expressions don't run on mysql and maria as well without the > > > > > delimiter. > > > > > > > > > > > > 2018-05-26 12:27 GMT+07:00 Ivan Kudryavtsev < > > > kudryavtsev...@bw-sw.com > > > > >: > > > > > > > > > > > >> Hello, I found that db upgrade routing is incompatible at least > > with > > > > > >> MariaDB 10.2.10 > > > > > >> > > > > > >> 2018-05-26 12:03 GMT+07:00 Ivan Kudryavtsev < > > > kudryavtsev...@bw-sw.com > > > > >: > > > > > >> > > > > > >>> Hello, Devs. During upgrade I got an error about missing > column: > > > > > >>> > > > > > >>> SELECT network_offerings.id, network_offerings.name, > > > > > >>> network_offerings.unique_name, network_offerings.display_text, > > > > > >>> network_offerings.nw_rate, network_offerings.mc_rate, > > > > > >>> network_offerings.traffic_type, network_offerings.specify_vlan, > > > > > >>> network_offerings.system_only, network_offerings.service_ > > > offering_id, > > > > > >>> network_offerings.tags,
Re: CS 4.10 to 4.11.1 upgrade error
it seems that when someone installs 4.11.1, the META-INF/db/schema-41000to41100.sql file doesn't get executed, therefore, the idempotent stored procedures do not get created From: Ivan KudryavtsevSent: Saturday, May 26, 2018 5:26:09 PM To: dev Subject: Re: CS 4.10 to 4.11.1 upgrade error Rafael, I have read that thread and mentioned it above, but those sql expressions are not connected with the problem above. сб, 26 мая 2018 г., 22:23 Rafael Weingärtner : > Hmm... Isn't there a problem to migrate from 4.10 to 4.11 that is going to > be fixed in 4.11.1? > > On Sat, May 26, 2018 at 12:19 PM, Ivan Kudryavtsev < > kudryavtsev...@bw-sw.com > > wrote: > > > Hi, Rafael. The first procedure creation > > > > CREATE PROCEDURE `cloud`.`IDEMPOTENT_ADD_COLUMN` ( > > IN in_table_name VARCHAR(200) > > , IN in_column_name VARCHAR(200) > > , IN in_column_definition VARCHAR(1000) > > ) > > BEGIN > > > > DECLARE CONTINUE HANDLER FOR 1060 BEGIN END; SET @ddl = > > CONCAT('ALTER TABLE ', in_table_name); SET @ddl = CONCAT(@ddl, ' ', > > 'ADD COLUMN') ; SET @ddl = CONCAT(@ddl, ' ', in_column_name); SET @ddl > > = CONCAT(@ddl, ' ', in_column_definition); PREPARE stmt FROM @ddl; > > EXECUTE stmt; DEALLOCATE PREPARE stmt; END; > > > > Doesn't work in freshly installed mysql, I suppose other similar > > expressions fail too without custom delimiter specification, at least I > see > > that in native mysql console. I found that during upgrade from 4.10 to > > 4.11.1 the tables weren't altered (take a look at the first e-mail), so I > > started to find where that alteration happens and found the file > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > schema-41000to41100.sql > > > > where that stored procedure is created, it seems that a migration process > > failed to run that file content during the migration, otherwise, I don't > > catch how it could happen, that whole file or its part skipped during > 4.10 > > to 4.11 upgrade. > > > > May be the migration code includes the delimiter, but whole file is > skipped > > during db upgrade by the unknown reason, I haven't looked to the > migration > > code, so don't have other details, but I know for sure that migration > took > > place because it was failing until I uploaded new system vm template and > > "looks-like-succeeded" without errors after that. > > > > > > сб, 26 мая 2018 г., 19:03 Rafael Weingärtner < > rafaelweingart...@gmail.com > > >: > > > > > What line are you talking about? > > > > > > On Sat, May 26, 2018 at 3:54 AM, Ivan Kudryavtsev < > > > kudryavtsev...@bw-sw.com> > > > wrote: > > > > > > > After I manually set delimiter ENDTHAT in the beginning of the file > and > > > in > > > > the end, expressions have been correctly processed and upgrade path > > > > completed well. I was able to start 4.11.1 and it functions well. > > > > > > > > 2018-05-26 12:52 GMT+07:00 Ivan Kudryavtsev < > kudryavtsev...@bw-sw.com > > >: > > > > > > > > > The problem is with that file: > > > > > > > > > > > > > > https://github.com/apache/cloudstack/blob/9187392ff9cd33b53d5b251076fee2 > > > > > 2b02743477/engine/schema/src/main/resources/META-INF/db/ > > > > > schema-41000to41100.sql > > > > > > > > > > The expressions don't run on mysql and maria as well without the > > > > delimiter. > > > > > > > > > > 2018-05-26 12:27 GMT+07:00 Ivan Kudryavtsev < > > kudryavtsev...@bw-sw.com > > > >: > > > > > > > > > >> Hello, I found that db upgrade routing is incompatible at least > with > > > > >> MariaDB 10.2.10 > > > > >> > > > > >> 2018-05-26 12:03 GMT+07:00 Ivan Kudryavtsev < > > kudryavtsev...@bw-sw.com > > > >: > > > > >> > > > > >>> Hello, Devs. During upgrade I got an error about missing column: > > > > >>> > > > > >>> SELECT network_offerings.id, network_offerings.name, > > > > >>> network_offerings.unique_name, network_offerings.display_text, > > > > >>> network_offerings.nw_rate, network_offerings.mc_rate, > > > > >>> network_offerings.traffic_type, network_offerings.specify_vlan, > > > > >>> network_offerings.system_only, network_offerings.service_ > > offering_id, > > > > >>> network_offerings.tags, network_offerings.default, > > > > >>> network_offerings.availability, network_offerings.state, > > > > >>> network_offerings.removed, network_offerings.created, > > > > >>> network_offerings.guest_type, network_offerings.dedicated_ > > lb_service, > > > > >>> network_offerings.shared_source_nat_service, > > > > >>> network_offerings.specify_ip_ranges, network_offerings.sort_key, > > > > >>> network_offerings.uuid, network_offerings.redundant_ > > router_service, > > > > >>> network_offerings.conserve_mode, > > > network_offerings.elastic_ip_service, > > > > >>> network_offerings.eip_associate_public_ip, > > > > >>> network_offerings.elastic_lb_service,
Re: [VOTE] Apache CloudStack 4.11.1.0 LTS [RC1]
I checked three verification files, unpacked and build the code, and am trusting the process otherwise: 0 (binding) The reason I am not giving a +1 is because the code presently does not build on anything but linux, due to the configdrive test not building on macosx (and I presume windows) If we add that to release notes I am fine with it. On Sat, May 26, 2018 at 5:27 AM, Tutkowski, Mikewrote: > +1 (binding) > > I created a new cloud using commit 5f48487dc62fd1decaabc4ab2a10f549d6c82400 > (RC1). I ran the automated regression tests for managed storage. All tests > passed. > > On 5/24/18, 9:56 AM, "Paul Angus" wrote: > > Hi All, > > > > I've created a 4.11.1.0 release (RC1), with the following artefacts up > for testing and a vote: > > [NB we know there are issues for Nuage to sort in this RC, but they > will be well contained, so let’s test everything else ] > > > > Git Branch and Commit SH: > > https://gitbox.apache.org/repos/asf?p=cloudstack.git;a= > shortlog;h=refs/heads/4.11.1.0-RC20180524T1000 > > Commit: 5f48487dc62fd1decaabc4ab2a10f549d6c82400 > > > > Source release (checksums and signatures are available at the same > > location): > > https://dist.apache.org/repos/dist/dev/cloudstack/4.11.1.0/ > > > > PGP release keys (signed using 8B309F7251EE0BC8): > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > > > The vote will be open till end of next week, 1st June 2018. > > > > For sanity in tallying the vote, can PMC members please be sure to > indicate "(binding)" with their vote? > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove (and reason why) > > > > Additional information: > > > > For users' convenience, I've built packages from > 5f48487dc62fd1decaabc4ab2a10f549d6c82400 and published RC1 repository > here: > > http://packages.shapeblue.com/testing/4111rc1/ > > > > The release notes are still work-in-progress, but the systemvm > template upgrade section has been updated. You may refer the following for > systemvm template upgrade testing: > > http://docs.cloudstack.apache.org/projects/cloudstack- > release-notes/en/latest/index.html > > > > 4.11.1 systemvm templates are available from here: > http://packages.shapeblue.com/systemvmtemplate/4.11.1-rc1/ > > > Kind regards, > > Paul Angus > > > paul.an...@shapeblue.com > www.shapeblue.com > 53 Chandos Place, Covent Garden, London WC2N 4HSUK > @shapeblue > > > > > > -- Daan