[GitHub] [cloudstack-primate] ggoodrich-ipp commented on issue #3: Checklist: List View Customisation
ggoodrich-ipp commented on issue #3: Checklist: List View Customisation URL: https://github.com/apache/cloudstack-primate/issues/3#issuecomment-547606780 I have been investigating the sorting mechanism built into ant-design-vue in hopes of fulfilling the sort-key feature listed in the description. I've extracted some of the code leveraged by the old UI for sorting, in order to hopefully set the Table.sorter to call this new function. However, what I've discovered is that I can find no mechanism with which to determine which column is being clicked/sorted. The mechanism only passes (a, b, sortOrder), with a and b seeming to be Vue.js data objects that contain, essentially, the data for an entire row in the table. I've found a spot in the ant-design-vue code where I can pass another parameter - sortColumn as the fourth parameter, and this solves the problem. I've been testing it locally. If no-one knows of another good way to accomplish this, I will issue a PR against ant-design-vue to get this change incorporated. The referenced line would be changed to be: `const result = sortColumn.sorter(a, b, sortOrder, sortColumn);` Here is a [link to the current line](https://github.com/vueComponent/ant-design-vue/blob/46644ff435359c6a5c707444b3828bcb99258a74/components/table/Table.jsx#L351) within the ant-design-vue repo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] iceteabottle commented on issue #7: [WIP] Feature/vm wizard
iceteabottle commented on issue #7: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-547492093 > @iceteabottle thanks for resuming this. One request from last time I tested your component/form, can you add the device mixin to hide the infocard on mobile? Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] iceteabottle commented on issue #7: [WIP] Feature/vm wizard
iceteabottle commented on issue #7: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-547482010 Current status:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] iceteabottle commented on a change in pull request #7: [WIP] Feature/vm wizard
iceteabottle commented on a change in pull request #7: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/7#discussion_r340151529 ## File path: src/locales/en.json ## @@ -943,5 +943,6 @@ "yourInstance": "Your instance", "newInstance": "New instance", "cpu": "CPU", -"ram": "RAM" +"ram": "RAM", Review comment: Yes, sure. I will check for using existing translations. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-documentation] andrijapanicsb closed pull request #78: remove mysql-python-connector requirements
andrijapanicsb closed pull request #78: remove mysql-python-connector requirements URL: https://github.com/apache/cloudstack-documentation/pull/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard
rhtyd commented on issue #7: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-547281432 @iceteabottle thanks for resuming this. One request from last time I tested your component/form, can you add the device mixin to hide the infocard on mobile? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on issue #2: [WIP] Added config options to enable HTTPS and custom vhost names
rhtyd commented on issue #2: [WIP] Added config options to enable HTTPS and custom vhost names URL: https://github.com/apache/cloudstack-primate/pull/2#issuecomment-547281594 Thanks @onitake, I'm on leave this week. I'll revisit this PR next week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #7: [WIP] Feature/vm wizard
rhtyd commented on a change in pull request #7: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/7#discussion_r339913084 ## File path: src/locales/en.json ## @@ -943,5 +943,6 @@ "yourInstance": "Your instance", "newInstance": "New instance", "cpu": "CPU", -"ram": "RAM" +"ram": "RAM", Review comment: Can you maybe check against the old UI, wrt any translations you need in the VM deployment form? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #7: [WIP] Feature/vm wizard
rhtyd commented on a change in pull request #7: [WIP] Feature/vm wizard URL: https://github.com/apache/cloudstack-primate/pull/7#discussion_r339912956 ## File path: package.json ## @@ -42,8 +42,7 @@ "axios": "^0.19.0", "enquire.js": "^2.1.6", "js-cookie": "^2.2.1", -"lodash.get": "^4.4.2", -"lodash.pick": "^4.4.0", +"lodash": "^4.17.15", Review comment: +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [cloudstack-primate] rhtyd merged pull request #8: Fix misused class in the info card component. Adjust margin.
rhtyd merged pull request #8: Fix misused class in the info card component. Adjust margin. URL: https://github.com/apache/cloudstack-primate/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
