[GitHub] [cloudstack-primate] utchoang commented on pull request #324: Create new view component for Tree Domain

2020-05-05 Thread GitBox


utchoang commented on pull request #324:
URL: 
https://github.com/apache/cloudstack-primate/pull/324#issuecomment-624473727


   Hi @rhytd. I completed fixed it. Please review and let me know your comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #324: Create new view component for Tree Domain

2020-05-05 Thread GitBox


utchoang edited a comment on pull request #324:
URL: 
https://github.com/apache/cloudstack-primate/pull/324#issuecomment-624473727


   Hi @rhtyd. I completed fixed it. Please review and let me know your comments.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] DaanHoogland commented on a change in pull request #112: Timezone requirements for 4.14+

2020-05-05 Thread GitBox


DaanHoogland commented on a change in pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#discussion_r420576090



##
File path: source/upgrading/upgrade/_timezone.rst
##
@@ -0,0 +1,33 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+.. sub-section included in upgrade notes.
+
+Time zone requirements
+##
+
+As of CloudStack 4.14,  you must explicitly configure time zone either in the 
MySQL server or JDBC driver (db.properties).
+In previous CloudStack versions, UTC time zone was assumed by default (all 
event's have UTC time stamps), so
+the same UTC time zone should now be explicitly configured.
+
+You can do this by editing the /etc/cloudstack/management/db.properties file 
and adding "serverTimezone=UTC"
+to the "db.cloud.url.params=" and "db.usage.url.params=" lines.  Example 
lines, from a clean 4.14 installation, are given below:
+
+.. parsed-literal::
+
+   
db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC
+   db.usage.url.params=serverTimezone=UTC
+
+If you want time stamps in DB to use a different time zone, please make sure 
to test this thoroughly in test environment.

Review comment:
   `If you want time stamps in the DB to use a different time zone, please 
make sure to test this thoroughly in a test environment.`
   (added articles, could be `your` in both cases as well)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] DaanHoogland commented on a change in pull request #112: Timezone requirements for 4.14+

2020-05-05 Thread GitBox


DaanHoogland commented on a change in pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#discussion_r420576090



##
File path: source/upgrading/upgrade/_timezone.rst
##
@@ -0,0 +1,33 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+   or more contributor license agreements.  See the NOTICE file
+   distributed with this work for additional information#
+   regarding copyright ownership.  The ASF licenses this file
+   to you under the Apache License, Version 2.0 (the
+   "License"); you may not use this file except in compliance
+   with the License.  You may obtain a copy of the License at
+   http://www.apache.org/licenses/LICENSE-2.0
+   Unless required by applicable law or agreed to in writing,
+   software distributed under the License is distributed on an
+   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+   KIND, either express or implied.  See the License for the
+   specific language governing permissions and limitations
+   under the License.
+
+.. sub-section included in upgrade notes.
+
+Time zone requirements
+##
+
+As of CloudStack 4.14,  you must explicitly configure time zone either in the 
MySQL server or JDBC driver (db.properties).
+In previous CloudStack versions, UTC time zone was assumed by default (all 
event's have UTC time stamps), so
+the same UTC time zone should now be explicitly configured.
+
+You can do this by editing the /etc/cloudstack/management/db.properties file 
and adding "serverTimezone=UTC"
+to the "db.cloud.url.params=" and "db.usage.url.params=" lines.  Example 
lines, from a clean 4.14 installation, are given below:
+
+.. parsed-literal::
+
+   
db.cloud.url.params=prepStmtCacheSize=517&cachePrepStmts=true&sessionVariables=sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'&serverTimezone=UTC
+   db.usage.url.params=serverTimezone=UTC
+
+If you want time stamps in DB to use a different time zone, please make sure 
to test this thoroughly in test environment.

Review comment:
   `If you want time stamps in the DB to use a different time zone, please 
make sure to test this thoroughly in a test environment.`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #325: [FIX] Translation in Compute Offering/Disk Offering

2020-05-05 Thread GitBox


utchoang commented on pull request #325:
URL: 
https://github.com/apache/cloudstack-primate/pull/325#issuecomment-624471894


   Hi @rhtyd  cc @svenvogel. I fixed translation issues at compute/disk 
offering. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang opened a new pull request #325: [FIX] Translation in Compute Offering/Disk Offering

2020-05-05 Thread GitBox


utchoang opened a new pull request #325:
URL: https://github.com/apache/cloudstack-primate/pull/325


   Open for https://github.com/apache/cloudstack-primate/issues/321



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #112: Timezone requirements for 4.14+

2020-05-05 Thread GitBox


ACSGitBot commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624280614


   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr112
   
   Build Log Output:
   
   
   No log errors found to report.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #112: Timezone requirements for 4.14+

2020-05-05 Thread GitBox


ACSGitBot commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624279672


   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #112: Timezone requirements for 4.14+

2020-05-05 Thread GitBox


ACSGitBot removed a comment on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624273508


   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr112
   
   Build Log Output:
   
   
   No log errors found to report.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #112: Timezone requirements for 4.14+

2020-05-05 Thread GitBox


andrijapanicsb commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624279642


   requesting docbuild



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


ACSGitBot removed a comment on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624272563


   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


ACSGitBot commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624273508


   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr112
   
   Build Log Output:
   
   
   No log errors found to report.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


ACSGitBot commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624272563


   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot removed a comment on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


ACSGitBot removed a comment on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624268729







This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] andrijapanicsb removed a comment on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


andrijapanicsb removed a comment on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624268290


   requesting docbuild



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


ACSGitBot commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624269721


   Build finished.  You can review it at:   
https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr112
   
   Build Log Output:
   
   
   No log errors found to report.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


ACSGitBot commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624268729


   Your request had been received, i'll go and build the documentation and 
check the output log for errors.
   
   This shouldn't take long.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


andrijapanicsb commented on pull request #112:
URL: 
https://github.com/apache/cloudstack-documentation/pull/112#issuecomment-624268290


   requesting docbuild



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-documentation] andrijapanicsb opened a new pull request #112: Create u_timezone.rst

2020-05-05 Thread GitBox


andrijapanicsb opened a new pull request #112:
URL: https://github.com/apache/cloudstack-documentation/pull/112


   Note on explicit Timezone requirements due to my mysql-connector 8.x java 
dependency



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




Re: [VOTE] Apache CloudStack 4.14.0.0 RC1

2020-05-05 Thread Andrija Panic
Hi Liridon,

do you have any feedback about the usage records timing/time zone and such?

Thanks
Andrija

On Mon, 4 May 2020 at 14:32, Daan Hoogland  wrote:

> Liridon,
> "Not owner of usage job, skipping" means there is a PID in the record for
> this job that isn't the current process. If recognise this and have
> remedied by setting the process id to null in the record. I'm sure there is
> some underlying issue that you hit though. Just a workaround.
>
> On Mon, May 4, 2020 at 12:56 PM Ismaili, Liridon (SWISS TXT) <
> liridon.isma...@swisstxt.ch> wrote:
>
>> Hi Rohit
>>
>> I tried so and did configure the usage to run 12:45 so I can monitor the
>> behavior. I got the following output:
>> 2020-05-04 12:45:00,002 INFO  [cloud.usage.UsageManagerImpl]
>> (Usage-Job-1:null) (logid:) starting usage job...
>> 2020-05-04 12:45:00,015 DEBUG [cloud.usage.UsageManagerImpl]
>> (Usage-Job-1:null) (logid:) Not owner of usage job, skipping...
>> 2020-05-04 12:45:00,015 INFO  [cloud.usage.UsageManagerImpl]
>> (Usage-Job-1:null) (logid:) usage job complete
>>
>> So the job did not run for some reason... I'm still looking into this. So
>> currently I can't confirm but will update you later as soon as the usage
>> job did run.
>>
>> Regards
>> Liridon
>> -Original Message-
>> From: Rohit Yadav > rohit%20yadav%20%3crohit.ya...@shapeblue.com%3e>>
>> Reply-To: us...@cloudstack.apache.org
>> To: dev@cloudstack.apache.org > 22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e>>,
>> andrija.pa...@gmail.com > 22andrija.pa...@gmail.com%22%20%3candrija.pa...@gmail.com%3e>>,
>> us...@cloudstack.apache.org > 22us...@cloudstack.apache.org%22%20%3cus...@cloudstack.apache.org%3e>>
>> Subject: Re: [VOTE] Apache CloudStack 4.14.0.0 RC1
>> Date: Mon, 04 May 2020 10:16:51 +
>>
>>
>> Thanks for testing and sharing your results Liridon!
>>
>>
>> Can you also test the case if the usage records have the correct time
>> according to configured timezone (in global settings) if you're using a
>> non-UTC timezone?
>>
>>
>> I'll add the db.usage.url.paramsl as well in the PR.
>>
>>
>>
>> Regards,
>>
>>
>> Rohit Yadav
>>
>>
>> Software Architect, ShapeBlue
>>
>>
>> 
>>
>> https://www.shapeblue.com
>>
>>
>>
>> 
>>
>> From: Ismaili, Liridon (SWISS TXT) <
>>
>> 
>>
>> liridon.isma...@swisstxt.ch
>>
>> >
>>
>> Sent: Monday, May 4, 2020 15:38
>>
>> To:
>>
>> 
>>
>> dev@cloudstack.apache.org
>>
>>  <
>>
>> 
>>
>> dev@cloudstack.apache.org
>>
>> >;
>>
>> 
>>
>> andrija.pa...@gmail.com
>>
>>  <
>>
>> 
>>
>> andrija.pa...@gmail.com
>>
>> >;
>>
>> 
>>
>> us...@cloudstack.apache.org
>>
>>  <
>>
>> 
>>
>> us...@cloudstack.apache.org
>>
>> >
>>
>> Subject: Re: [VOTE] Apache CloudStack 4.14.0.0 RC1
>>
>>
>> Hi Rohit
>>
>>
>> That did the trick! I did remove all the timezone information on my.cnf
>> and only added the timezone information on the db.properties file.
>>
>> So I can confirm it fixes the issue.
>>
>>
>> If you are using the usage service too you will also need to specify the
>> timezone information for the usage DB:
>>
>> "db.usage.url.params=" in the /etc/cloudstack/management/db.properties
>> file. Otherwise the usage service won't be able to start.
>>
>>
>> This did also fix my issue and all my dates inside the db are now in the
>> correct time zone! I'll also update the Github PR so we can track it there.
>>
>>
>> Many thanks and Regards
>>
>> Liridon
>>
>>
>> 
>>
>> rohit.ya...@shapeblue.com
>>
>>
>>
>> 
>>
>> www.shapeblue.com
>>
>>
>> 3 London Bridge Street,  3rd floor, News Building, London  SE1 9SGUK
>>
>> @shapeblue
>>
>>
>>
>>
>>
>>
>>
>> -Original Message-
>>
>> From: "Ismaili, Liridon (SWISS TXT)" <
>>
>> 
>>
>> liridon.isma...@swisstxt.ch
>>
>> >
>> > 20liridon%20%28swiss%20txt%29%22%20%3cliridon.isma...@swisstxt.ch>
>>
>> %20liridon%20%28swiss%20txt%29%22%20%3cliridon.isma...@swisstxt.ch
>>
>> %3e>>
>>
>> Reply-To:
>>
>> 
>>
>> us...@cloudstack.apache.org
>>
>> >
>> 
>>
>> us...@cloudstack.apache.org
>>
>> >
>>
>> To:
>>
>> 
>>
>> dev@cloudstack.apache.org
>>
>>  <
>>
>> 
>>
>> dev@cloudstack.apache.org
>>
>> >
>> 
>>
>> %22...@cloudstack.apache.org
>>
>> 
>>
>> %22%20%3c...@cloudstack.apache.org
>>
>> %3e>>,
>>
>> 
>>
>> andrija.pa...@gmail.com
>>
>>  <
>>
>> 
>>
>> andrija.pa...@gma

Re: [ Proposal ] Managing CloudStack Load Balancer configuration

2020-05-05 Thread Ismaili, Liridon (SWISS TXT)
Hi Wei,

That's some great improvements to the HAProxy! We couldn't realize some 
projects because of the missing features on the HAProxy therefore we are happy 
to hear that there will be some improvements.
As an addition to the proposal of you we would like to see the possibility to 
separate timeout settings (client/server/connect/...) as these timeout can be 
different.
We would also like to have the timeout settings available under the 
LoadbalancerRule

as a summary:
- Separate options for all timeout parameters (client/server/connect/...)
- Timeouts also per LoadbalancerRule, not only Network

We also thought about some "nice to have" additions:
- check customization: HTTP Check, Check Interval, etc.
- LoadbalancerRule: Custom Server string & Custom Listen string (only Domain 
Admin)
- Network: Custom Defaults (only Domain Admin)

Please let me know what you think about these additions.

Best Regards
Liridon

-Original Message-
From: "Riepl, Gregor (SWISS TXT)" 
mailto:%22Riepl,%20gregor%20%28swiss%20txt%29%22%20%3cgregor.ri...@swisstxt.ch%3e>>
Reply-To: dev@cloudstack.apache.org
To: dev@cloudstack.apache.org 
mailto:%22...@cloudstack.apache.org%22%20%3c...@cloudstack.apache.org%3e>>
Subject: Re: [ Proposal ] Managing CloudStack Load Balancer configuration
Date: Mon, 04 May 2020 10:22:39 +


Hi Wei,


Thank you for this proposal!

We are also very much interested in this feature.


There's a few things we're not quite happy with, though - but we still need to 
discuss this internally a bit.

Liridon or myself will give some feedback soon.


Regards,

Gregor



From: Wei ZHOU <



ustcweiz...@gmail.com

>

Sent: 01 May 2020 08:01

To:



dev@cloudstack.apache.org

 <



dev@cloudstack.apache.org

>

Subject: [ Proposal ] Managing CloudStack Load Balancer configuration


Our improvements to cloudstack load balancer (implemented by HAproxy in the

VRs) allow cloudstack users to manage certain restricted configuration

settings. With this feature, users can


* Change basic configuration of HAproxy (e.g. set the amount of allowed

connections),


* choose if load balancer is transparent,


* enable or disable the support for SSL offloading in isolated networks.


* choose if load balancer supports HTTP/2.


* more settings.




To make this possible to the user, we provide two forms on cloudstack GUI

(old GUI, will add changes on Primate) from which the settings can be

managed and applied in virtual routers.




FS can be found at



https://cwiki.apache.org/confluence/display/CLOUDSTACK/VR+haproxy+customization+in+CloudStack




Any suggestions ?




Kind regards,


*Wei Zhou*


Principal Cloud Engineer


Leaseweb Global B.V.


[GitHub] [cloudstack-primate] rhtyd commented on issue #162: [BUG] Events > Delete (Archive) event button does not work properly

2020-05-05 Thread GitBox


rhtyd commented on issue #162:
URL: 
https://github.com/apache/cloudstack-primate/issues/162#issuecomment-624021860


   Test cases:
   - Group action for events and alerts and instance



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #199: [BUG] Different list of template images in old and new UI

2020-05-05 Thread GitBox


rhtyd commented on issue #199:
URL: 
https://github.com/apache/cloudstack-primate/issues/199#issuecomment-624020492


   Related issue; https://github.com/apache/cloudstack/issues/4041



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #296: view: fix api error handling

2020-05-05 Thread GitBox


rhtyd commented on pull request #296:
URL: 
https://github.com/apache/cloudstack-primate/pull/296#issuecomment-624015887


   discuss - come up with a general purpose way of declaring errors?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #225: [BUG] Storage > Volumes > selected volume showing more actions than old UI

2020-05-05 Thread GitBox


vladimirpetrov opened a new issue #225:
URL: https://github.com/apache/cloudstack-primate/issues/225


   **Describe the bug**
   The Primate UI has more actions in 'Storage > Volumes > selected volume' 
than the old UI. Here are the actions that are present only in Primate:
   - Detach volume
   - Migrate volume
   - Download volume
   - Create template from volume
   - Delete volume
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to 'Storage > Volumes' and click on a volume. Look at the possible 
actions.
   
   **Expected behavior**
   The Primate UI should have the same actions as in the old UI.
   
   **Screenshots**
   Old UI:
   
![image](https://user-images.githubusercontent.com/12384665/76778970-53be2a80-67b3-11ea-8735-41c82cb57b09.png)
   
   New UI:
   
![image](https://user-images.githubusercontent.com/12384665/76779030-66d0fa80-67b3-11ea-8c6c-890042ca0b02.png)
   
   **Desktop (please complete the following information):**
- OS: Ubuntu 18.04 LTS
- Browser: Chrome
- Version: 80.0.3987.132 (Official Build) (64-bit)
   
   **Additional context**
   None
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #225: [BUG] Storage > Volumes > selected volume showing more actions than old UI

2020-05-05 Thread GitBox


rhtyd commented on issue #225:
URL: 
https://github.com/apache/cloudstack-primate/issues/225#issuecomment-623988026


   @vladimirpetrov cc @borisstoyanov please test and close against master, 
thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #231: storage: fix volume actions

2020-05-05 Thread GitBox


rhtyd commented on pull request #231:
URL: 
https://github.com/apache/cloudstack-primate/pull/231#issuecomment-623986414


   - There were discrepancies when data disk was in destroy state (but not 
expunged)
   - the args() method is passed store.getters, but still 
store.getters.features... was called leading to exception
   - no explicit check if args was a method, could lead to exception if args 
was not an array



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr opened a new pull request #317: view: fix tab actions permissions check

2020-05-05 Thread GitBox


shwstppr opened a new pull request #317:
URL: https://github.com/apache/cloudstack-primate/pull/317


   Fixes #310 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #177: [BUG] Identify and access > Users > selected user > Change password does not verify the old password

2020-05-05 Thread GitBox


rhtyd commented on issue #177:
URL: 
https://github.com/apache/cloudstack-primate/issues/177#issuecomment-623963542


   @vladimirpetrov please test and close against latest master, thanks. cc 
@borisstoyanov 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] vladimirpetrov opened a new issue #177: [BUG] Identify and access > Users > selected user > Change password does not verify the old password

2020-05-05 Thread GitBox


vladimirpetrov opened a new issue #177:
URL: https://github.com/apache/cloudstack-primate/issues/177


   **Describe the bug**
   'Identify and access > Users > selected user > Change password' dialog has a 
'Current password' field but it's not mandatory nor it's ever verified if 
that's really the current password.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   1. Go to 'Identify and access > Users > selected user'
   2. Click on 'Change password'
   3. Enter a new password in the 'Password' field and a wrong password in the 
'Current password' field.
   4. The password has been changed even though the current password was wrong.
   
   **Expected behavior**
   The password change should not be allowed without entering correct current 
password.
   
   **Screenshots**
   None
   
   **Desktop (please complete the following information):**
- OS: Windows 10 Pro x64
- Browser: Chrome
- Version: 80.0.3987.116 (Official Build) (64-bit)
   
   **Additional context**
   None
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #264: view: fix user change password

2020-05-05 Thread GitBox


rhtyd commented on a change in pull request #264:
URL: https://github.com/apache/cloudstack-primate/pull/264#discussion_r419993310



##
File path: src/views/iam/ChangeUserPassword.vue
##
@@ -0,0 +1,183 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+
+  
+
+  
+
+  

Review comment:
   @shwstppr feedback for you - in forms we would like to include an 
information button/tooltip like this to show API parameter description/help 
like other auto-generated forms. There were few notification/message issues 
that I fixed as well.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] vladimirpetrov commented on issue #243: [BUG] 'Create SSH Key Pair' differences

2020-05-05 Thread GitBox


vladimirpetrov commented on issue #243:
URL: 
https://github.com/apache/cloudstack-primate/issues/243#issuecomment-623947784


   Fix confirmed, closing the issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] vladimirpetrov commented on issue #180: [BUG] Identify and access > Domains > delete domain does not remove it from the tree

2020-05-05 Thread GitBox


vladimirpetrov commented on issue #180:
URL: 
https://github.com/apache/cloudstack-primate/issues/180#issuecomment-623941031


   Fix confirmed, closing the issue.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #307: [FIX] VM Deployment Wizard Changes

2020-05-05 Thread GitBox


rhtyd commented on pull request #307:
URL: 
https://github.com/apache/cloudstack-primate/pull/307#issuecomment-623924377


   thanks @utchoang I'll test and merge this 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang commented on pull request #320: Explore Test Automation

2020-05-05 Thread GitBox


utchoang commented on pull request #320:
URL: 
https://github.com/apache/cloudstack-primate/pull/320#issuecomment-623919476


   @rhtyd OK, got it I'm still in progress after completing 
https://github.com/apache/cloudstack-primate/pull/324 first.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #173: [BUG] Selected instance actions difference between old and new UI

2020-05-05 Thread GitBox


rhtyd commented on issue #173:
URL: 
https://github.com/apache/cloudstack-primate/issues/173#issuecomment-623918581


   ping @vladimirpetrov 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation

2020-05-05 Thread GitBox


rhtyd commented on pull request #320:
URL: 
https://github.com/apache/cloudstack-primate/pull/320#issuecomment-623918168


   If possible could you also explore a way to add some unit test for other 
components/widgets (an example for a small form, or tab component) and the 
autogenview component. Thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on pull request #320: Explore Test Automation

2020-05-05 Thread GitBox


rhtyd commented on pull request #320:
URL: 
https://github.com/apache/cloudstack-primate/pull/320#issuecomment-623917840


   @utchoang thanks, can you also check if Travis runs these test? Maybe add 
test/run command in the .travis.yml



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #322: [BUG] Updatе compute offering access dialog does not get current state on loading

2020-05-05 Thread GitBox


rhtyd commented on issue #322:
URL: 
https://github.com/apache/cloudstack-primate/issues/322#issuecomment-623916581


   PR merged, please test against latest master and close this @vladimirpetrov 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] utchoang opened a new pull request #324: Create new view component for Tree Domain

2020-05-05 Thread GitBox


utchoang opened a new pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #24: Implement groupable actions in List View

2020-05-05 Thread GitBox


rhtyd commented on issue #24:
URL: 
https://github.com/apache/cloudstack-primate/issues/24#issuecomment-623912517


   Dupes https://github.com/apache/cloudstack-primate/issues/162



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #322: [BUG] Updatе compute offering access dialog does not get current state on loading

2020-05-05 Thread GitBox


rhtyd commented on issue #322:
URL: 
https://github.com/apache/cloudstack-primate/issues/322#issuecomment-623911975


   limit them to this bug wrt offerings only for now @shwstppr just send a PR 
with the changes I had removed not considering this case from the original PR
   
   For other update APIs, when form is created we use this.resource to populate 
the options. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] rhtyd commented on issue #199: [BUG] Different list of template images in old and new UI

2020-05-05 Thread GitBox


rhtyd commented on issue #199:
URL: 
https://github.com/apache/cloudstack-primate/issues/199#issuecomment-623911242


   Template filtering options will be added in 1.0/GA



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr commented on issue #322: [BUG] Updatе compute offering access dialog does not get current state on loading

2020-05-05 Thread GitBox


shwstppr commented on issue #322:
URL: 
https://github.com/apache/cloudstack-primate/issues/322#issuecomment-623904391


   @rhtyd @vladimirpetrov Following action/APIs might show similar behaviour,
   
   - updateVirtualMachine
   - updateInstanceGroup
   - updateUser
   - updateRole
   - updateTemplate
   - updateIso
   - updateKubernetesVersion
   - updateNetwork
   - updateVPC
   - updateNetworkACLList
   - updateVpnCustomerGateway
   - enable/disable*Offering
   - updateHost
   - updatePod
   - updateZone
   
   should I change it for them as well?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [cloudstack-primate] shwstppr opened a new pull request #323: view: refresh offering on update offering form open

2020-05-05 Thread GitBox


shwstppr opened a new pull request #323:
URL: https://github.com/apache/cloudstack-primate/pull/323


   Fixes #322



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org