Hi

[Katie F.]

Test again

Sent from my iPhone.Kathleen Foos

[GSoC 2022 Idea] CloudStack OAuth2 Plugin #4834 - Design Document Review

[Daman Arora]

Hi Folks,

As a student in the GSOC 2022 program, I am working on a proposal for
the *Apache
CloudStack **issue # 4834*.
 I have prepared a design
document for the proposal, and would appreciate it if I could get some
feedback on my approach to solve this issue.

https://docs.google.com/document/d/14ZH5ZQ2UfTCutuzvEEZI_EbiBEtjO9tVtKhbBWC_AiU/edit?usp=sharing


I have the document unlocked for adding comments.

Best,
Daman Arora.

[GitHub] [cloudstack-documentation] DaanHoogland commented on a change in pull request #157: Virtual Router Service Offering

[GitBox]

DaanHoogland commented on a change in pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#discussion_r805699640



##
File path: source/adminguide/service_offerings.rst
##
@@ -721,3 +721,53 @@ default system offering used for System VMs.
 
 #. Destroy the existing CPVM or SSVM offerings and wait for them to be
recreated. The new CPVM or SSVM are configured with the new offering.
+
+
+Changing the Default System Offering for Virtual Routers
+---
+
+As a CloudStack administrator, you can change the default system
+offering used for Virtual Routers.
+
+#. Create a new system offering
+
+   For more information, see `“Creating a New System Offering”
+   `_.
+
+#. (Optional) Create a new network offering with SystemOffering
+
+   For more information, see `“Creating a New Network Offering”
+   `_.
+
+#. (Optional) Change account setting
+
+   You can change the default system offering for Virtual Routers of a 
particular
+   account by changing the account's setting "router.service.offering" to the 
uuid
+   of the system offering.
+
+   For more information, see `“Setting Local Configuration Parameters”
+   
<../installguide/configuration.html#setting-local-configuration-parameters>`_.
+
+#. (Optional) Change global configuration
+
+   You can change the default system offering for Virtual Routers of all 
accounts
+   by changing the global configuration "router.service.offering" to the uuid 
of the system offering.
+
+   For more information, see `“Setting Global Configuration Parameters”
+   
<../installguide/configuration.html#setting-global-configuration-parameters>`_.
+
+When you create a network, the virtual routers will use the system offering in 
their NetworkOffering.

Review comment:
   I don't agree with this, either we should use camel case or we should 
use english concepts, not a mix of both.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti merged pull request #157: Virtual Router Service Offering

[GitBox]

sureshanaparti merged pull request #157:
URL: https://github.com/apache/cloudstack-documentation/pull/157


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #157: Virtual Router Service Offering

[GitBox]

blueorangutan commented on pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#issuecomment-1038898039


   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/157. 
(SL-JID 201)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #157: Virtual Router Service Offering

[GitBox]

blueorangutan commented on pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#issuecomment-1038896674


   @weizhouapache a Jenkins job has been kicked to build the document. I'll 
keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] weizhouapache commented on pull request #157: Virtual Router Service Offering

[GitBox]

weizhouapache commented on pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#issuecomment-1038894801


   @blueorangutan docbuild
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #157: Virtual Router Service Offering

[GitBox]

sureshanaparti commented on a change in pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#discussion_r805675040



##
File path: source/adminguide/service_offerings.rst
##
@@ -721,3 +721,53 @@ default system offering used for System VMs.
 
 #. Destroy the existing CPVM or SSVM offerings and wait for them to be
recreated. The new CPVM or SSVM are configured with the new offering.
+
+
+Changing the Default System Offering for Virtual Routers
+---
+
+As a CloudStack administrator, you can change the default system
+offering used for Virtual Routers.
+
+#. Create a new system offering
+
+   For more information, see `“Creating a New System Offering”
+   `_.
+
+#. (Optional) Create a new network offering with SystemOffering
+
+   For more information, see `“Creating a New Network Offering”
+   `_.
+
+#. (Optional) Change account setting
+
+   You can change the default system offering for Virtual Routers of a 
particular
+   account by changing the account's setting "router.service.offering" to the 
uuid
+   of the system offering.
+
+   For more information, see `“Setting Local Configuration Parameters”
+   
<../installguide/configuration.html#setting-local-configuration-parameters>`_.
+
+#. (Optional) Change global configuration
+
+   You can change the default system offering for Virtual Routers of all 
accounts
+   by changing the global configuration "router.service.offering" to the uuid 
of the system offering.
+
+   For more information, see `“Setting Global Configuration Parameters”
+   
<../installguide/configuration.html#setting-global-configuration-parameters>`_.
+
+When you create a network, the virtual routers will use the system offering in 
their NetworkOffering.
+If it is not set, the virtual routers will use the system offering in the 
account setting.
+If the account setting is not set, the virtual routers will use the system 
offering set in the global configuration.
+If the global configuration is not set, the virtual routers will use the 
default system offering for virtual 
+routers ("System Offering For Software Router" or "System Offering For 
Software Router - Local Storage").
+
+You can update an existing network to a new network offering. The new virtual 
routers will use the 
+new system offering set in the NetworkOffering, account setting or global 
configuration.

Review comment:
   ```suggestion
   new system offering set in the Network Offering, account setting or global 
configuration.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #157: Virtual Router Service Offering

[GitBox]

sureshanaparti commented on a change in pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#discussion_r805674518



##
File path: source/adminguide/service_offerings.rst
##
@@ -721,3 +721,53 @@ default system offering used for System VMs.
 
 #. Destroy the existing CPVM or SSVM offerings and wait for them to be
recreated. The new CPVM or SSVM are configured with the new offering.
+
+
+Changing the Default System Offering for Virtual Routers
+---
+
+As a CloudStack administrator, you can change the default system
+offering used for Virtual Routers.
+
+#. Create a new system offering
+
+   For more information, see `“Creating a New System Offering”
+   `_.
+
+#. (Optional) Create a new network offering with SystemOffering
+
+   For more information, see `“Creating a New Network Offering”
+   `_.
+
+#. (Optional) Change account setting
+
+   You can change the default system offering for Virtual Routers of a 
particular
+   account by changing the account's setting "router.service.offering" to the 
uuid
+   of the system offering.
+
+   For more information, see `“Setting Local Configuration Parameters”
+   
<../installguide/configuration.html#setting-local-configuration-parameters>`_.
+
+#. (Optional) Change global configuration
+
+   You can change the default system offering for Virtual Routers of all 
accounts
+   by changing the global configuration "router.service.offering" to the uuid 
of the system offering.
+
+   For more information, see `“Setting Global Configuration Parameters”
+   
<../installguide/configuration.html#setting-global-configuration-parameters>`_.
+
+When you create a network, the virtual routers will use the system offering in 
their NetworkOffering.
+If it is not set, the virtual routers will use the system offering in the 
account setting.
+If the account setting is not set, the virtual routers will use the system 
offering set in the global configuration.
+If the global configuration is not set, the virtual routers will use the 
default system offering for virtual 
+routers ("System Offering For Software Router" or "System Offering For 
Software Router - Local Storage").
+
+You can update an existing network to a new network offering. The new virtual 
routers will use the 
+new system offering set in the NetworkOffering, account setting or global 
configuration.
+For more information, see `“Changing the Network Offering on a Guest Network”
+`_.
+
+You can restart the network with cleanup. The new virtual routers, created 
after the restart, will use
+the new system offering, set in the NetworkOffering, account setting or global 
configuration.

Review comment:
   ```suggestion
   the new system offering, set in the Network Offering, account setting or 
global configuration.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #157: Virtual Router Service Offering

[GitBox]

sureshanaparti commented on a change in pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#discussion_r805673483



##
File path: source/adminguide/service_offerings.rst
##
@@ -721,3 +721,53 @@ default system offering used for System VMs.
 
 #. Destroy the existing CPVM or SSVM offerings and wait for them to be
recreated. The new CPVM or SSVM are configured with the new offering.
+
+
+Changing the Default System Offering for Virtual Routers
+---
+
+As a CloudStack administrator, you can change the default system
+offering used for Virtual Routers.
+
+#. Create a new system offering
+
+   For more information, see `“Creating a New System Offering”
+   `_.
+
+#. (Optional) Create a new network offering with SystemOffering
+
+   For more information, see `“Creating a New Network Offering”
+   `_.
+
+#. (Optional) Change account setting
+
+   You can change the default system offering for Virtual Routers of a 
particular
+   account by changing the account's setting "router.service.offering" to the 
uuid
+   of the system offering.
+
+   For more information, see `“Setting Local Configuration Parameters”
+   
<../installguide/configuration.html#setting-local-configuration-parameters>`_.
+
+#. (Optional) Change global configuration
+
+   You can change the default system offering for Virtual Routers of all 
accounts
+   by changing the global configuration "router.service.offering" to the uuid 
of the system offering.
+
+   For more information, see `“Setting Global Configuration Parameters”
+   
<../installguide/configuration.html#setting-global-configuration-parameters>`_.
+
+When you create a network, the virtual routers will use the system offering in 
their NetworkOffering.

Review comment:
   ```suggestion
   When you create a network, the virtual routers will use the system service 
offering in their Network Offering.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #157: Virtual Router Service Offering

[GitBox]

sureshanaparti commented on a change in pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#discussion_r805673483



##
File path: source/adminguide/service_offerings.rst
##
@@ -721,3 +721,53 @@ default system offering used for System VMs.
 
 #. Destroy the existing CPVM or SSVM offerings and wait for them to be
recreated. The new CPVM or SSVM are configured with the new offering.
+
+
+Changing the Default System Offering for Virtual Routers
+---
+
+As a CloudStack administrator, you can change the default system
+offering used for Virtual Routers.
+
+#. Create a new system offering
+
+   For more information, see `“Creating a New System Offering”
+   `_.
+
+#. (Optional) Create a new network offering with SystemOffering
+
+   For more information, see `“Creating a New Network Offering”
+   `_.
+
+#. (Optional) Change account setting
+
+   You can change the default system offering for Virtual Routers of a 
particular
+   account by changing the account's setting "router.service.offering" to the 
uuid
+   of the system offering.
+
+   For more information, see `“Setting Local Configuration Parameters”
+   
<../installguide/configuration.html#setting-local-configuration-parameters>`_.
+
+#. (Optional) Change global configuration
+
+   You can change the default system offering for Virtual Routers of all 
accounts
+   by changing the global configuration "router.service.offering" to the uuid 
of the system offering.
+
+   For more information, see `“Setting Global Configuration Parameters”
+   
<../installguide/configuration.html#setting-global-configuration-parameters>`_.
+
+When you create a network, the virtual routers will use the system offering in 
their NetworkOffering.

Review comment:
   ```suggestion
   When you create a network, the virtual routers will use the system offering 
in their Network Offering.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-documentation] sureshanaparti commented on a change in pull request #157: Virtual Router Service Offering

[GitBox]

sureshanaparti commented on a change in pull request #157:
URL: 
https://github.com/apache/cloudstack-documentation/pull/157#discussion_r805672899



##
File path: source/adminguide/service_offerings.rst
##
@@ -721,3 +721,53 @@ default system offering used for System VMs.
 
 #. Destroy the existing CPVM or SSVM offerings and wait for them to be
recreated. The new CPVM or SSVM are configured with the new offering.
+
+
+Changing the Default System Offering for Virtual Routers
+---
+
+As a CloudStack administrator, you can change the default system
+offering used for Virtual Routers.
+
+#. Create a new system offering

Review comment:
   ```suggestion
   #. Create a new system service offering
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org