Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1433067504 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: It finally worked, nice catch @DaanHoogland :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Object Store browser connects over HTTP while HTTPS is set in URL
Hi,
While testing the Ceph RGW plugin [0] for the Object Store driver I
noticed the bucket browser isn't working.
So I debugged my Firefox browser and I noticed that it tries to connect
to http://ceph01.holfra.eu/ (not SSL) while the store's URL is
httpS://ceph01.holfra.eu/
My debugger says:
"Blocked loading mixed active content
“http://ceph01.holfra.eu/wido02?location”request.js:150:9;
I looked at ObjectStoreBrowser.vue [1] and found this piece of code:
initMinioClient () {
if (!this.client) {
const url =
/https?:\/\/([^/]+)\/?/.exec(this.resource.url.split(this.resource.name)[0])[1]
const isHttps = /^https/.test(url)
this.client = new Minio.Client({
endPoint: url.split(':')[0],
port: url.split(':').length > 1 ? parseInt(url.split(':')[1])
: isHttps ? 443 : 80,
useSSL: isHttps,
accessKey: this.resource.accesskey,
secretKey: this.resource.usersecretkey
})
this.listObjects()
}
},
Based on if the URL starts with http or https it should select SSL or
not, but in my case it selects HTTP while the URL contains HTTPS.
My JavaScript is a bit rusty, anybody else with ideas?
Wido
[0]: https://github.com/apache/cloudstack/pull/8389
[1]:
https://github.com/apache/cloudstack/blob/1411da1a22bc6aa26634f3038475e3d5fbbcd6bb/ui/src/components/view/ObjectStoreBrowser.vue#L449
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1433016999 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: Let's see how it goes now :crossed_fingers: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1433016999 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: Let's see how it goes now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: New Object Storage - Huawei OBS
It is working now!
PR is out: https://github.com/apache/cloudstack/pull/8389
On 12/16/23 13:14, Wido den Hollander wrote:
On 12/15/23 20:09, Wei ZHOU wrote:
Hi Wido,
I just tested your branch, it looks ok (
https://github.com/wido/cloudstack/commits/ceph-object-store).
Yes, it works now! I had old files in my classpath... (rookie mistake!)
I get an error about an invalid URL, but that's something else:
Error: (HTTP 530, error code ) http://ceph01..eu/ is not a valid
URL
2023-12-16 12:13:25,737 ERROR [o.a.c.a.c.a.s.AddObjectStoragePoolCmd]
(qtp1970436060-18:ctx-9cb56831 ctx-99f41e21) (logid:c93cae1f) Exception:
com.cloud.exception.InvalidParameterValueException:
https://ceph01.xxx.eu/ is not a valid URL
Looking into this!
Wido
I got an error which is because I input invalid host/keys
2023-12-15 19:07:22,313 DEBUG [o.a.c.s.d.l.CephObjectStoreLifeCycleImpl]
(qtp775386112-17:ctx-9be6ad79 ctx-b4cdcdd0) (logid:3a8340e9) Error while
initializing Ceph RGW Object Store: IOException
2023-12-15 19:07:22,313 DEBUG [c.c.s.StorageManagerImpl]
(qtp775386112-17:ctx-9be6ad79 ctx-b4cdcdd0) (logid:3a8340e9) Failed to
add
object store: Error while initializing Ceph RGW Object Store. Invalid
credentials or URL
java.lang.RuntimeException: Error while initializing Ceph RGW Object
Store.
Invalid credentials or URL
at
org.apache.cloudstack.storage.datastore.lifecycle.CephObjectStoreLifeCycleImpl.initialize(CephObjectStoreLifeCycleImpl.java:87)
at
com.cloud.storage.StorageManagerImpl.discoverObjectStore(StorageManagerImpl.java:3777)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
-Wei
On Fri, 15 Dec 2023 at 17:18, Wido den Hollander wrote:
Op 15/12/2023 om 13:54 schreef Wei ZHOU:
Hi Wido,
It looks you need a file like
https://github.com/apache/cloudstack/blob/main/plugins/storage/object/simulator/src/main/resources/META-INF/cloudstack/storage-object-simulator/spring-storage-object-simulator-context.xml
Tnx. But that didn't solve it. The module seems to load according to the
mgmt server log, but I can't add the storage. Exception is the same.
Wido
-Wei
On Fri, 15 Dec 2023 at 13:40, Wido den Hollander
wrote:
On 12/15/23 09:41, Ronald Feicht wrote:
Hi Kishan,
when I add my module to client/pom.xml I get the following error and
http://192.168.17.252:8080/client/ returns "HTTP ERROR 503 Service
Unavailable" because of the following exception:
[WARNING] Failed startup of context
o.e.j.m.p.JettyWebAppContext@1df8ea34
{/client,file:///opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/,UNAVAILABLE}{file:///opt/cloudstack-huawei-obs/client/target/classes/META-INF/webapp/}
java.lang.NullPointerException
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet$1.with
(DefaultModuleDefinitionSet.java:104)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:263)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:268)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:268)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:268)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:268)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:268)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.withModule
(DefaultModuleDefinitionSet.java:251)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.startContexts
(DefaultModuleDefinitionSet.java:96)
at
org.apache.cloudstack.spring.module.model.impl.DefaultModuleDefinitionSet.load
(DefaultModuleDefinitionSet.java:79)
at
org.apache.cloudstack.spring.module.factory.ModuleBasedContextFactory.loadModules
(ModuleBasedContextFactory.java:37)
at
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.init
(CloudStackSpringContext.java:70)
at
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.
(CloudStackSpringContext.java:57)
at
org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.
(CloudStackSpringContext.java:61)
at
org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized
(CloudStackContextLoaderListener.java:52)
at
org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized
(ContextHandler.java:933)
at
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
DaanHoogland commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432834270 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: I think I found it @JoaoJandre , all other anchors have a blank line following (before the title they adhere to) i.e. ``` .. _changing-root-password: Changing the Root Password ~~ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
DaanHoogland commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432834270 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: I think I found it, all other anchors have a blank line following (before the title they adhere to) i.e. ``` .. _changing-root-password: Changing the Root Password ~~ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Correct example IPv6 address and use documentation prefix [cloudstack-documentation]
mivsvit opened a new pull request, #370: URL: https://github.com/apache/cloudstack-documentation/pull/370 The characters `s` and `t` are not valid hex. Correct the example `5001:0dt8:83a3:1012:1000:8s2e:0870:7454` so that it is a valid IPv6 address. Also change to use the 2001:db8::/32 [IPv6 documentation prefix](https://www.rfc-editor.org/rfc/rfc3849.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432721815 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: I've removed the reference, I have no idea what was the issue :shrug: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432661458 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: I've made a commit removing the parenthesis, if this doesn't work, I'll remove the reference -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
JoaoJandre commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432660080 ## source/adminguide/management.rst: ## @@ -13,7 +13,7 @@ specific language governing permissions and limitations under the License. - +.. _resource_tags: Review Comment: The time-zones reference is also cross file, that's the weird part.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
DaanHoogland commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432415170 ## source/adminguide/management.rst: ## @@ -13,7 +13,7 @@ specific language governing permissions and limitations under the License. - +.. _resource_tags: Review Comment: apart from my remark in the refering section, is the issue maybe a cross file reference? I know these should be possible as well, but these might work slightly differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add docs about storage and host tags [cloudstack-documentation]
DaanHoogland commented on code in PR #365: URL: https://github.com/apache/cloudstack-documentation/pull/365#discussion_r1432413451 ## source/adminguide/host_and_storage_tags.rst: ## @@ -0,0 +1,92 @@ +.. Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information# + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + + +Host and Storage Tags +== + +Host tags and storage tags, despite the name, are not related to resource tags (section :ref:`resource-tags`) and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). Review Comment: @JoaoJandre the only thing i see different in this case is the braces "()" maybe try ```suggestion Host tags and storage tags, despite the name, are not related to resource tags, explained in section :ref:`resource-tags` and are a feature to direct resource allocation, such as which host the VM will be deployed on or which storage the volume will be created on. There are several reasons for using tags (such as directing the volume to better quality storage, according to the offering). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
