[VOTE] Apache CloudStack 4.18.2.0 RC2

2024-04-12 Thread João Jandre

Hi All,

I've created a 4.18.2.0 release (RC2), with the following artifacts up 
for a vote:


Git Branch and Commit SH:
https://github.com/apache/cloudstack/tree/4.18.2.0-RC20240412T0825
Commit: 154566f914c778d448d4ab07b47b2db874bbf982

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.18.2.0/

PGP release keys (signed using 488D90DA107445E3243D162606F3CEC65B335790):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 120 hours (due to the weekend).

For sanity in tallying the vote, can PMC members please be sure to 
indicate "(binding)" with their vote?


[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)



Re: [VOTE] Apache CloudStack 4.18.2.0 RC2

2024-04-12 Thread Daan Hoogland
+1 binding
I checked the hashes alright and the log of commit/tag (Note this last
check is based on the recent TZ issues to make sure nothing slipped
through). Other than that trusting on the testing I was involved in
over the last month or so.

On Fri, Apr 12, 2024 at 1:37 PM João Jandre  wrote:
>
> Hi All,
>
> I've created a 4.18.2.0 release (RC2), with the following artifacts up
> for a vote:
>
> Git Branch and Commit SH:
> https://github.com/apache/cloudstack/tree/4.18.2.0-RC20240412T0825
> Commit: 154566f914c778d448d4ab07b47b2db874bbf982
>
> Source release (checksums and signatures are available at the same
> location):
> https://dist.apache.org/repos/dist/dev/cloudstack/4.18.2.0/
>
> PGP release keys (signed using 488D90DA107445E3243D162606F3CEC65B335790):
> https://dist.apache.org/repos/dist/release/cloudstack/KEYS
>
> Vote will be open for 120 hours (due to the weekend).
>
> For sanity in tallying the vote, can PMC members please be sure to
> indicate "(binding)" with their vote?
>
> [ ] +1  approve
> [ ] +0  no opinion
> [ ] -1  disapprove (and reason why)
>


-- 
Daan


Re: ACS 4.16 - Change SystemVM template for CKS

2024-04-12 Thread benoit lair
i succeded to install systemvm template 4.19 as serving template for
control and worker nodes with cks community iso 1.28.4
when cluster saying "starting", i connect to node controller via p, saw
that docker was not installed, but containerd.io yes

I've done the following :

apt install docker-ce
cp /etc/containerd/config.toml /etc/containerd/config.toml.bck
containerd config default | tee /etc/containerd/config.toml
/opt/bin/setup-kube-system
/opt/bin/deploy-kube-system

on to control node and same after on worker node
CS UI show kubernetes yaml
a "kubectl.exe --kubeconfig kube.conf.conf get nodes"

NAME   STATUS   ROLES   AGEVERSION
k8s-cks-cl19-control-18ed18311c9   Readycontrol-plane   3h1m   v1.28.4
k8s-cks-cl19-node-18ed1850433  Ready  170m   v1.28.4

However CS says the cluster is in alert state
And dashboad is not working

Any advice ?

when executing this on my laptop :
kubectl.exe --kubeconfig cl19_k8s_1.28.4.conf proxy

and opening this :
http://localhost:8001/api/v1/namespaces/kubernetes-dashboard/services/https:kubernetes-dashboard:/proxy/

I have this result :
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "no endpoints available for service \"kubernetes-dashboard\"",
  "reason": "ServiceUnavailable",
  "code": 503
}

Somebody got this problem with dashboard ?

Did i miss something installing the cluster manually with acs stuff ?

Le jeu. 11 avr. 2024 à 17:40, benoit lair  a écrit :

> Hi Wei,
>
> Thanks for the sharing, i also tried to install the systemvm 4.19
> I have control node and worker node under template systemvm 4.19 (
> http://download.cloudstack.org/systemvm/4.19/systemvmtemplate-4.19.0-xen.vhd.bz2
> )
> I tried with community cks iso 1.25.0 and 1.28.9
> On systemvm 4.19 docker was not present by default, just containerd in
> 1.6.x version
> I installed docker-ce and docker-ce-cli :
>
> apt install -y apt-transport-https ca-certificates curl
> software-properties-common
> curl -fsSL https://download.docker.com/linux/debian/gpg | sudo gpg
> --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg
> echo "deb [arch=$(dpkg --print-architecture)
> signed-by=/usr/share/keyrings/docker-archive-keyring.gpg]
> https://download.docker.com/linux/debian $(lsb_release -cs) stable" |
> sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
> remove line about docker in double in /etc/apt/sources.list
> apt update
> apt install -y docker-ce
> apt install -y docker-cli
> i mounted the 1.28.4 cks community iso in control vm
>
> and /opt/bin/setup-kube-system
> i have these errors :
>
> Is it the good way to manually install kube system
>
> root@k8s-cks-cl17-control-18ecdc1e5bd:/home/core#
> /opt/bin/setup-kube-system
> Installing binaries from /mnt/k8sdisk/
> 5b1fa8e3e100: Loading layer
> [==>]  803.8kB/803.8kB
> 39c831b1aa26: Loading layer
> [==>]  26.25MB/26.25MB
> Loaded image: apache/cloudstack-kubernetes-autoscaler:latest
> 417cb9b79ade: Loading layer
> [==>]  657.7kB/657.7kB
> 8d323b160d65: Loading layer
> [==>]  24.95MB/24.95MB
> Loaded image: apache/cloudstack-kubernetes-provider:v1.0.0
> 6a4a177e62f3: Loading layer
> [==>]  115.2kB/115.2kB
> 398c9baff0ce: Loading layer
> [==>]  16.07MB/16.07MB
> Loaded image: registry.k8s.io/coredns/coredns:v1.10.1
> bd8a70623766: Loading layer
> [==>]  75.78MB/75.78MB
> c88361932af5: Loading layer
> [==>] 508B/508B
> Loaded image: kubernetesui/dashboard:v2.7.0
> e023e0e48e6e: Loading layer
> [==>]  103.7kB/103.7kB
> 6fbdf253bbc2: Loading layer
> [==>]   21.2kB/21.2kB
> 7bea6b893187: Loading layer
> [==>]  716.5kB/716.5kB
> ff5700ec5418: Loading layer
> [==>] 317B/317B
> d52f02c6501c: Loading layer
> [==>] 198B/198B
> e624a5370eca: Loading layer
> [==>] 113B/113B
> 1a73b54f556b: Loading layer
> [==>] 385B/385B
> d2d7ec0f6756: Loading layer
> [==>] 355B/355B
> 4cb10dd2545b: Loading layer
> [==>]  130.6kB/130.6kB
> ba9afb2b3e0c: Loading layer
> [==>]  1.076MB/1.076MB
> 22bba3da6b0d: Loading layer
> [==>]  91.29MB/91.29

Re: ACS 4.16 - Change SystemVM template for CKS

2024-04-12 Thread Wei ZHOU
Hi,

I would suggest you not to spend time on this... 4.16 is EOL

Please upgrade to cloudstack 4.18/4.19, or use old kubernetes versions ..


-Wei


On Fri, Apr 12, 2024 at 2:25 PM benoit lair  wrote:
>
> i succeded to install systemvm template 4.19 as serving template for
> control and worker nodes with cks community iso 1.28.4
> when cluster saying "starting", i connect to node controller via p, saw
> that docker was not installed, but containerd.io yes
>
> I've done the following :
>
> apt install docker-ce
> cp /etc/containerd/config.toml /etc/containerd/config.toml.bck
> containerd config default | tee /etc/containerd/config.toml
> /opt/bin/setup-kube-system
> /opt/bin/deploy-kube-system
>
> on to control node and same after on worker node
> CS UI show kubernetes yaml
> a "kubectl.exe --kubeconfig kube.conf.conf get nodes"
>
> NAME   STATUS   ROLES   AGEVERSION
> k8s-cks-cl19-control-18ed18311c9   Readycontrol-plane   3h1m   v1.28.4
> k8s-cks-cl19-node-18ed1850433  Ready  170m   v1.28.4
>
> However CS says the cluster is in alert state
> And dashboad is not working
>
> Any advice ?
>
> when executing this on my laptop :
> kubectl.exe --kubeconfig cl19_k8s_1.28.4.conf proxy
>
> and opening this :
> http://localhost:8001/api/v1/namespaces/kubernetes-dashboard/services/https:kubernetes-dashboard:/proxy/
>
> I have this result :
> {
>   "kind": "Status",
>   "apiVersion": "v1",
>   "metadata": {},
>   "status": "Failure",
>   "message": "no endpoints available for service \"kubernetes-dashboard\"",
>   "reason": "ServiceUnavailable",
>   "code": 503
> }
>
> Somebody got this problem with dashboard ?
>
> Did i miss something installing the cluster manually with acs stuff ?
>
> Le jeu. 11 avr. 2024 à 17:40, benoit lair  a écrit :
>
> > Hi Wei,
> >
> > Thanks for the sharing, i also tried to install the systemvm 4.19
> > I have control node and worker node under template systemvm 4.19 (
> > http://download.cloudstack.org/systemvm/4.19/systemvmtemplate-4.19.0-xen.vhd.bz2
> > )
> > I tried with community cks iso 1.25.0 and 1.28.9
> > On systemvm 4.19 docker was not present by default, just containerd in
> > 1.6.x version
> > I installed docker-ce and docker-ce-cli :
> >
> > apt install -y apt-transport-https ca-certificates curl
> > software-properties-common
> > curl -fsSL https://download.docker.com/linux/debian/gpg | sudo gpg
> > --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg
> > echo "deb [arch=$(dpkg --print-architecture)
> > signed-by=/usr/share/keyrings/docker-archive-keyring.gpg]
> > https://download.docker.com/linux/debian $(lsb_release -cs) stable" |
> > sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
> > remove line about docker in double in /etc/apt/sources.list
> > apt update
> > apt install -y docker-ce
> > apt install -y docker-cli
> > i mounted the 1.28.4 cks community iso in control vm
> >
> > and /opt/bin/setup-kube-system
> > i have these errors :
> >
> > Is it the good way to manually install kube system
> >
> > root@k8s-cks-cl17-control-18ecdc1e5bd:/home/core#
> > /opt/bin/setup-kube-system
> > Installing binaries from /mnt/k8sdisk/
> > 5b1fa8e3e100: Loading layer
> > [==>]  803.8kB/803.8kB
> > 39c831b1aa26: Loading layer
> > [==>]  26.25MB/26.25MB
> > Loaded image: apache/cloudstack-kubernetes-autoscaler:latest
> > 417cb9b79ade: Loading layer
> > [==>]  657.7kB/657.7kB
> > 8d323b160d65: Loading layer
> > [==>]  24.95MB/24.95MB
> > Loaded image: apache/cloudstack-kubernetes-provider:v1.0.0
> > 6a4a177e62f3: Loading layer
> > [==>]  115.2kB/115.2kB
> > 398c9baff0ce: Loading layer
> > [==>]  16.07MB/16.07MB
> > Loaded image: registry.k8s.io/coredns/coredns:v1.10.1
> > bd8a70623766: Loading layer
> > [==>]  75.78MB/75.78MB
> > c88361932af5: Loading layer
> > [==>] 508B/508B
> > Loaded image: kubernetesui/dashboard:v2.7.0
> > e023e0e48e6e: Loading layer
> > [==>]  103.7kB/103.7kB
> > 6fbdf253bbc2: Loading layer
> > [==>]   21.2kB/21.2kB
> > 7bea6b893187: Loading layer
> > [==>]  716.5kB/716.5kB
> > ff5700ec5418: Loading layer
> > [==>] 317B/317B
> > d52f02c6501c: Loading layer
> > [==>] 198B/198B
> > e624a5370eca: Loading layer
> > [==>] 113B/113B
> > 1a73b54f556b: Loading layer
> > [==

Re: Community Over Code North America 2024 - Talk submitting

2024-04-12 Thread Gabriel Beims Bräscher
Hi Daniel,

Great to hear, I would love to attend this one.
And good work at making this happen.

Best regards,
Gabriel.

On Fri, 12 Apr 2024 at 1:01 AM Ivet Petrova 
wrote:

> Hey Daniel,
>
> Great initiative! Hope more people will submit proposals. I think we
> posted on socials for the event at some point. Will post today also.
>
> Best regards,
>
>
>
>
> On 12 Apr 2024, at 3:36, Guto Veronezi  wrote:
>
> Hello guys,
>
> The Community Over Code North America (COCNA) will happen in October 2024
> in Denver. The Call For Tracks for this conference occurred between
> December 2023 and January 2024; however, we (the community) did not engage
> in the discussion at that time and ended up not having a track for
> CloudStack in COCNA 2024, like we always had in the past years.
>
> Those interested in submitting talks targeted to ACS do so by submitting
> them to the "Runtime and cloud". However, I am speaking with the
> responsible for the conference to check if we could put something together
> if there were enough talks submitted. Currently, there are already 7 talks
> submitted to "Runtime and cloud" targeted to ACS. Unfortunately, the CPF
> will last until 23:59 UTC on April 15, 2024; therefore, we have a short
> time to try to make that happen. Thus, if you are interested, we invite you
> to submit a CloudStack talk to the track "Runtime and cloud" at COCNA
> 2024[1].
>
> Best regards,
> Daniel Salvador (gutoveronezi)
>
> [1] https://communityovercode.org/call-for-presentations/
>
>
>


Re: ACS 4.16 - Change SystemVM template for CKS

2024-04-12 Thread benoit lair
Hi Wei,

upgrading from 4.16 to 4.19 will be a huge work for me
I have to test vpc/shared network, vrrp vpc with public lb Netscaler and
withou it on several VPCs, i added support for VPX 12 and VPX 13 on it with
a nginx middleware rewriting rules from CS
I am on xcp-ng 8.2.1
i kept during years with a CS 4.3, restarting from 4.16, i would like this
time to keep LTS in production
Is there a specific upgrade path to respect ? a specific process to observe
? what rollback mechanism is possible ?

For my K8S needs, I would like to upgrade it, but it was looking first for
a preproduction K8s working on 1.28 in order integrating CI/CD pipelines
So this would not too be a problem upgrading CS after installing a k8s
cluster for CI/CD

Rohit was talking about CAPC, i can use it independently of the version of
ACS i use ?

Thanks

Le ven. 12 avr. 2024 à 14:30, Wei ZHOU  a écrit :

> Hi,
>
> I would suggest you not to spend time on this... 4.16 is EOL
>
> Please upgrade to cloudstack 4.18/4.19, or use old kubernetes versions ..
>
>
> -Wei
>
>
> On Fri, Apr 12, 2024 at 2:25 PM benoit lair  wrote:
> >
> > i succeded to install systemvm template 4.19 as serving template for
> > control and worker nodes with cks community iso 1.28.4
> > when cluster saying "starting", i connect to node controller via p,
> saw
> > that docker was not installed, but containerd.io yes
> >
> > I've done the following :
> >
> > apt install docker-ce
> > cp /etc/containerd/config.toml /etc/containerd/config.toml.bck
> > containerd config default | tee /etc/containerd/config.toml
> > /opt/bin/setup-kube-system
> > /opt/bin/deploy-kube-system
> >
> > on to control node and same after on worker node
> > CS UI show kubernetes yaml
> > a "kubectl.exe --kubeconfig kube.conf.conf get nodes"
> >
> > NAME   STATUS   ROLES   AGE
> VERSION
> > k8s-cks-cl19-control-18ed18311c9   Readycontrol-plane   3h1m
>  v1.28.4
> > k8s-cks-cl19-node-18ed1850433  Ready  170m
>  v1.28.4
> >
> > However CS says the cluster is in alert state
> > And dashboad is not working
> >
> > Any advice ?
> >
> > when executing this on my laptop :
> > kubectl.exe --kubeconfig cl19_k8s_1.28.4.conf proxy
> >
> > and opening this :
> >
> http://localhost:8001/api/v1/namespaces/kubernetes-dashboard/services/https:kubernetes-dashboard:/proxy/
> >
> > I have this result :
> > {
> >   "kind": "Status",
> >   "apiVersion": "v1",
> >   "metadata": {},
> >   "status": "Failure",
> >   "message": "no endpoints available for service
> \"kubernetes-dashboard\"",
> >   "reason": "ServiceUnavailable",
> >   "code": 503
> > }
> >
> > Somebody got this problem with dashboard ?
> >
> > Did i miss something installing the cluster manually with acs stuff ?
> >
> > Le jeu. 11 avr. 2024 à 17:40, benoit lair  a
> écrit :
> >
> > > Hi Wei,
> > >
> > > Thanks for the sharing, i also tried to install the systemvm 4.19
> > > I have control node and worker node under template systemvm 4.19 (
> > >
> http://download.cloudstack.org/systemvm/4.19/systemvmtemplate-4.19.0-xen.vhd.bz2
> > > )
> > > I tried with community cks iso 1.25.0 and 1.28.9
> > > On systemvm 4.19 docker was not present by default, just containerd in
> > > 1.6.x version
> > > I installed docker-ce and docker-ce-cli :
> > >
> > > apt install -y apt-transport-https ca-certificates curl
> > > software-properties-common
> > > curl -fsSL https://download.docker.com/linux/debian/gpg | sudo gpg
> > > --dearmor -o /usr/share/keyrings/docker-archive-keyring.gpg
> > > echo "deb [arch=$(dpkg --print-architecture)
> > > signed-by=/usr/share/keyrings/docker-archive-keyring.gpg]
> > > https://download.docker.com/linux/debian $(lsb_release -cs) stable" |
> > > sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
> > > remove line about docker in double in /etc/apt/sources.list
> > > apt update
> > > apt install -y docker-ce
> > > apt install -y docker-cli
> > > i mounted the 1.28.4 cks community iso in control vm
> > >
> > > and /opt/bin/setup-kube-system
> > > i have these errors :
> > >
> > > Is it the good way to manually install kube system
> > >
> > > root@k8s-cks-cl17-control-18ecdc1e5bd:/home/core#
> > > /opt/bin/setup-kube-system
> > > Installing binaries from /mnt/k8sdisk/
> > > 5b1fa8e3e100: Loading layer
> > > [==>]  803.8kB/803.8kB
> > > 39c831b1aa26: Loading layer
> > > [==>]  26.25MB/26.25MB
> > > Loaded image: apache/cloudstack-kubernetes-autoscaler:latest
> > > 417cb9b79ade: Loading layer
> > > [==>]  657.7kB/657.7kB
> > > 8d323b160d65: Loading layer
> > > [==>]  24.95MB/24.95MB
> > > Loaded image: apache/cloudstack-kubernetes-provider:v1.0.0
> > > 6a4a177e62f3: Loading layer
> > > [==>]  115.2kB/115.2kB
> > > 398c9baff0ce: Loading layer
> > > [

build error on main

2024-04-12 Thread Daan Hoogland
Devs,
I've been getting these errors on main the last few weeks:
~~~
[ERROR] Failures:
[ERROR]   ActionEventInterceptorTest.testInterceptComplete:247
[ERROR]   ActionEventInterceptorTest.testInterceptException:261
[ERROR]   ActionEventInterceptorTest.testInterceptStartAsync:234
expected: but was:
~~~

I've tried different maven versions and checked the java version, but
have not found the golden clue yet. Did anybody else see these errors?
btw, in intellij there are no errors on these tests and also when run
as an isolated test suit they pass : `mvn -P developer,systemvm clean
install -Dnoredist -DfailIfNoTests=false -pl server
-Dtest=ActionEventInterceptorTest`. Only when building the entire
system with `mvn clean install -P developer,systemvm -Dnoredist` do
these fail.

Any hints/clues or similar experiences?

thanks,
-- 
Daan


Re: [PR] Update README.md [cloudstack-terraform-provider]

2024-04-12 Thread via GitHub


rohityadavcloud merged PR #110:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/110


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] Update README.md [cloudstack-terraform-provider]

2024-04-12 Thread via GitHub


rohityadavcloud commented on PR #110:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/110#issuecomment-2052259140

   Thanks @CodeBleu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [VOTE] Apache CloudStack 4.18.2.0 RC2

2024-04-12 Thread Bryan Lima

+1

I manually tested some basic functionalities with the KVM hypervisor and 
Ubuntu 20.04 LTS:


 * VM deploy;
 * Cold and live migration with and without storage migration, NFS to
   iSCSI (SharedMountPoint) and vice-versa;
 * Network management, firewall, egress/ingress rules, and operations
   with public IP addresses;
 * Checked connectivity and (lack of) between VMs considering the
   network rules applied;
 * Creating and reverting VM and volume snapshots.

Best regards,
Bryan

On 12/04/2024 08:52, Daan Hoogland wrote:

+1 binding
I checked the hashes alright and the log of commit/tag (Note this last
check is based on the recent TZ issues to make sure nothing slipped
through). Other than that trusting on the testing I was involved in
over the last month or so.

On Fri, Apr 12, 2024 at 1:37 PM João Jandre  wrote:

Hi All,

I've created a 4.18.2.0 release (RC2), with the following artifacts up
for a vote:

Git Branch and Commit SH:
https://github.com/apache/cloudstack/tree/4.18.2.0-RC20240412T0825
Commit: 154566f914c778d448d4ab07b47b2db874bbf982

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.18.2.0/

PGP release keys (signed using 488D90DA107445E3243D162606F3CEC65B335790):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 120 hours (due to the weekend).

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Re: [VOTE] Apache CloudStack 4.18.2.0 RC2

2024-04-12 Thread Nux

+1 (binding) on basic VM/storage/network lifecycle ops.

Thanks Joao

On 2024-04-12 19:56, Bryan Lima wrote:

+1

I manually tested some basic functionalities with the KVM hypervisor 
and Ubuntu 20.04 LTS:


 * VM deploy;
 * Cold and live migration with and without storage migration, NFS to
   iSCSI (SharedMountPoint) and vice-versa;
 * Network management, firewall, egress/ingress rules, and operations
   with public IP addresses;
 * Checked connectivity and (lack of) between VMs considering the
   network rules applied;
 * Creating and reverting VM and volume snapshots.

Best regards,
Bryan

On 12/04/2024 08:52, Daan Hoogland wrote:

+1 binding
I checked the hashes alright and the log of commit/tag (Note this last
check is based on the recent TZ issues to make sure nothing slipped
through). Other than that trusting on the testing I was involved in
over the last month or so.

On Fri, Apr 12, 2024 at 1:37 PM João Jandre  wrote:

Hi All,

I've created a 4.18.2.0 release (RC2), with the following artifacts 
up

for a vote:

Git Branch and Commit SH:
https://github.com/apache/cloudstack/tree/4.18.2.0-RC20240412T0825
Commit: 154566f914c778d448d4ab07b47b2db874bbf982

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.18.2.0/

PGP release keys (signed using 
488D90DA107445E3243D162606F3CEC65B335790):

https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 120 hours (due to the weekend).

For sanity in tallying the vote, can PMC members please be sure to
indicate "(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)