Re: Review Request 13552: Merging missing tests from QA repo to ASF - test_network_offerings 1 test added
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13552/#review25123 --- Review 13552 failed the build test : UNSTABLE The url of build cloudstack-master-with-patch #128 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/128/ - Jenkins Cloudstack.org On Aug. 14, 2013, 5:42 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13552/ --- (Updated Aug. 14, 2013, 5:42 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- Merging missing tests from QA repo to ASF - test_network_offerings 1 test added Diffs - test/integration/component/test_network_offering.py 31a5c7d Diff: https://reviews.apache.org/r/13552/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 13556: make the regular expressions in dnsmaq.sh tighter to avoid matching ip6dns in command line.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13556/#review25128 --- Review 13556 PASSED the build test The url of build cloudstack-master-with-patch #129 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/129/ - Jenkins Cloudstack.org On Aug. 14, 2013, 9:27 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13556/ --- (Updated Aug. 14, 2013, 9:27 a.m.) Review request for cloudstack and Jayapal Reddy. Bugs: Cloudstack-4317 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4317 make the regular expressions in dnsmaq.sh tighter to avoid matching ip6dns in command line. Diffs - patches/systemvm/debian/config/root/dnsmasq.sh c6ab07a Diff: https://reviews.apache.org/r/13556/diff/ Testing --- tested on 4.2 Thanks, bharat kumar
Re: Review Request 13557: current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13557/#review25129 --- Review 13557 PASSED the build test The url of build cloudstack-master-with-patch #130 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/130/ - Jenkins Cloudstack.org On Aug. 14, 2013, 10:29 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13557/ --- (Updated Aug. 14, 2013, 10:29 a.m.) Review request for cloudstack, Abhinandan Prateek and Chiradeep Vittal. Bugs: Cloudstack-4132 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-4132 current dnsmasq config does not allow guest virtual machines(clients) to update its hostnames with a DNS server Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config 736234c Diff: https://reviews.apache.org/r/13557/diff/ Testing --- tested on 4.2 Thanks, bharat kumar
Re: Review Request 13558: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13558/#review25130 --- Review 13558 PASSED the build test The url of build cloudstack-master-with-patch #131 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/131/ - Jenkins Cloudstack.org On Aug. 14, 2013, 11:18 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13558/ --- (Updated Aug. 14, 2013, 11:18 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3688 Repository: cloudstack-git Description --- CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed. Fixed the test as per the current design to delete a domain with cleanup=true. Diffs - test/integration/component/test_accounts.py 06b78e6 Diff: https://reviews.apache.org/r/13558/diff/ Testing --- Verified the test locally in cloudtack environment. Thanks, Sanjay Tripathi
Re: Review Request 13560: CLOUDSTACK-4021 : Update the test test_explicit_dedication.py according to new changes to dedicated resources
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13560/#review25133 --- Review 13560 PASSED the build test The url of build cloudstack-master-with-patch #132 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/132/ - Jenkins Cloudstack.org On Aug. 14, 2013, 11:57 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13560/ --- (Updated Aug. 14, 2013, 11:57 a.m.) Review request for cloudstack, Devdeep Singh and Prachi Damle. Bugs: CLOUDSTACK-4021 Repository: cloudstack-git Description --- test_explicit_dedication.py need to modified according to the new changes to dedicate resources feature. Now dedicate a host first and use the created affinity group to deploy vm. Diffs - test/integration/component/test_explicit_dedication.py bd97551 tools/marvin/marvin/integration/lib/common.py 4f5acef Diff: https://reviews.apache.org/r/13560/diff/ Testing --- test runs successfully whenever an empty host is found. Thanks, Saksham Srivastava
Re: Review Request 13559: Automation: Portable IP test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13559/#review25136 --- Review 13559 PASSED the build test The url of build cloudstack-master-with-patch #133 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/133/ - Jenkins Cloudstack.org On Aug. 14, 2013, 11:35 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13559/ --- (Updated Aug. 14, 2013, 11:35 a.m.) Review request for cloudstack, Murali Reddy, venkata swamy babu budumuru, and Prasanna Santhanam. Repository: cloudstack-git Description --- Adding new test cases for feature Portable IP Diffs - test/integration/component/test_portable_ip.py PRE-CREATION Diff: https://reviews.apache.org/r/13559/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 13317: db upgrade 4.1.1 to master
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13317/#review25138 --- Review 13317 PASSED the build test The url of build cloudstack-master-with-patch #134 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/134/ - Jenkins Cloudstack.org On Aug. 14, 2013, 12:56 p.m., daan Hoogland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13317/ --- (Updated Aug. 14, 2013, 12:56 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- needed for testing backwards compatibility in about everything I imagine. Diffs - engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java eb987ea Diff: https://reviews.apache.org/r/13317/diff/ Testing --- Thanks, daan Hoogland
Re: Review Request 13132: Field default value functions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13132/#review25154 --- Review 13132 failed the build test : FAILURE The url of build cloudstack-master-with-patch #135 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/135/ - Jenkins Cloudstack.org On Aug. 2, 2013, 1:37 p.m., Chris Suich wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13132/ --- (Updated Aug. 2, 2013, 1:37 p.m.) Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena. Repository: cloudstack-git Description --- Currently, the default value for a UI field must be a constant. I have extended the dialog forms to allow default value functions which are given the standard 'args' allowing default values to be determined at run time. Diffs - ui/scripts/sharedFunctions.js 8ddaeaf ui/scripts/ui/dialog.js 1ff5401 Diff: https://reviews.apache.org/r/13132/diff/ Testing --- Thanks, Chris Suich
Re: Review Request 13523: 7 New tests for affinity groups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13523/#review25057 --- Review 13523 failed the build test : FAILURE The url of build cloudstack-master-with-patch #116 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/116/ - Jenkins Cloudstack.org On Aug. 13, 2013, 4:40 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13523/ --- (Updated Aug. 13, 2013, 4:40 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- New tests for affinity groups Diffs - test/integration/component/test_affinity_groups.py 39baf3e Diff: https://reviews.apache.org/r/13523/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 13496: changes for guest vm password script for parallel vm deployment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13496/#review25058 --- Review 13496 failed the build test : FAILURE The url of build cloudstack-master-with-patch #117 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/117/ - Jenkins Cloudstack.org On Aug. 12, 2013, 1:24 p.m., Jayapal Reddy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13496/ --- (Updated Aug. 12, 2013, 1:24 p.m.) Review request for cloudstack, anthony xu, Abhinandan Prateek, Chiradeep Vittal, and Sheng Yang. Bugs: CLOUDSTACK-4184 Repository: cloudstack-git Description --- For parallel vm deployment guest vm password script is fixed by retrying after random sleep on failure. Please review the changes and provide your comments so that I can commit this. For windows guest VM script, changes for parallel vm deployment is not added. Diffs - setup/bindir/cloud-set-guest-password.in 3215894 Diff: https://reviews.apache.org/r/13496/diff/ Testing --- Tested by deploying 30 vms. All vms set its password successfully. Thanks, Jayapal Reddy
Re: Review Request 13459: cloudstack-3759: deployVM with state set to be stopped, attach volume to it. The volume should not be created.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13459/#review25059 --- Review 13459 failed the build test : FAILURE The url of build cloudstack-master-with-patch #118 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/118/ - Jenkins Cloudstack.org On Aug. 10, 2013, 12:50 a.m., Fang Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13459/ --- (Updated Aug. 10, 2013, 12:50 a.m.) Review request for cloudstack and Frank Zhang. Bugs: cloudstack-3759 Repository: cloudstack-git Description --- When deploying a new VM, with its state set to be stopped. At that time, when attaching volume to it, we need to delay the volume creation. Because in DB, the host id and pod id, fields for the VM are empty. Diffs - server/src/com/cloud/storage/VolumeManagerImpl.java 100aad3 Diff: https://reviews.apache.org/r/13459/diff/ Testing --- Thanks, Fang Wang
Re: Review Request 13525: CLOUDSTACK-4271: ASF 4.1 to 4.2 Upgrade: Missing Global Configuration parameter vmware.nested.virtualization on the Upgraded Setup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13525/#review25061 --- Review 13525 failed the build test : FAILURE The url of build cloudstack-master-with-patch #119 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/119/ - Jenkins Cloudstack.org On Aug. 13, 2013, 7:08 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13525/ --- (Updated Aug. 13, 2013, 7:08 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-4271 Repository: cloudstack-git Description --- CLOUDSTACK-4271: ASF 4.1 to 4.2 Upgrade: Missing Global Configuration parameter vmware.nested.virtualization on the Upgraded Setup. Diffs - setup/db/db/schema-412to420.sql 3b613a2 Diff: https://reviews.apache.org/r/13525/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12545: CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/#review25062 --- Review 12545 failed the build test : FAILURE The url of build cloudstack-master-with-patch #120 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/120/ - Jenkins Cloudstack.org On Aug. 13, 2013, 7:41 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12545/ --- (Updated Aug. 13, 2013, 7:41 a.m.) Review request for cloudstack, Harikrishna Patnala and Prasanna Santhanam. Bugs: CLOUDSTACK-1800 Repository: cloudstack-git Description --- CLOUDSTACK-1800: Add automation tests for reset sshkey to access VM Diffs - test/integration/component/test_reset_ssh_keypair.py PRE-CREATION Diff: https://reviews.apache.org/r/12545/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 13534: Autoscaling: Deleting an isolated network of an account deletes also the autoscaling rule for a network associated with another account
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13534/#review25067 --- Review 13534 failed the build test : FAILURE The url of build cloudstack-master-with-patch #121 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/121/ - Jenkins Cloudstack.org On Aug. 13, 2013, 10:23 a.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13534/ --- (Updated Aug. 13, 2013, 10:23 a.m.) Review request for cloudstack, Devdeep Singh, Murali Reddy, Ram Ganesh, and Vijay Venkatachalam. Bugs: CLOUDSTACK-3369 Repository: cloudstack-git Description --- issue: if autoscale policies are created by CS , then when any network gets deleted which got created with Netscaler as LB provider, the autoscale servers are getting deleted. during delete the network ipassoc cmd executed on Netscaler resouce is cleaning up the services which are present in the same subnet. NetUtils.sameSubnet(vlanSelfIp, server.get_ipaddress(), vlanNetmask) is returning true for the autoscale servers even they are not present in the subnet because this method is returning true if any any of the ip is true. autoscale server don't have ip address, so true is returned and hence removing the autoscale servers. which is causing severe issue for the autoscale policies created in cloudstack. Fix: while executing the method deleteServersInGuestVlan which will clean up the servers present in same subnet, check is made not to delete the autoscale servers. Diffs - plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java e42a9ea Diff: https://reviews.apache.org/r/13534/diff/ Testing --- created accounts testa testb and created networks with NS as LB provider network offering. 1. In TestA, created autoscale policy and wait for deploy the instance. policy got created and vm got deployed. 2. Delete the testB network, check in ns.log that autoscale servers won't get delete. 3. in testB network, create LB rules, and delete the network, verified autoscale servers won't get delete. 4. Destroy testA, TestB network, first rules got cleaned up and then the ip assocations of the network are removed. Thanks, Rajesh Battala
Re: Review Request 13546: Few Redundant router test disabling as part for 4.2 base line,
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13546/#review25105 --- Review 13546 failed the build test : UNSTABLE The url of build cloudstack-master-with-patch #124 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/124/ - Jenkins Cloudstack.org On Aug. 13, 2013, 11:28 p.m., Rayees Namathponnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13546/ --- (Updated Aug. 13, 2013, 11:28 p.m.) Review request for cloudstack, Prasanna Santhanam and Sheng Yang. Repository: cloudstack-git Description --- Redundant router test disabling as part for 4.2 base line, Please merge to 4.2 branch alone, not master Diffs - test/integration/component/test_redundant_router.py 617a546 Diff: https://reviews.apache.org/r/13546/diff/ Testing --- Tested Thanks, Rayees Namathponnan
Re: Review Request 13547: Extend listCapabilities API support to verify KVM snapshot enabled or not
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/#review25111
---
Review 13547 failed the build test : FAILURE
The url of build cloudstack-master-with-patch #125 is :
http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/125/
- Jenkins Cloudstack.org
On Aug. 14, 2013, 12:46 a.m., Fang Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13547/
---
(Updated Aug. 14, 2013, 12:46 a.m.)
Review request for cloudstack and Venkata Siva Vijayendra Bhamidipati.
Bugs: cloudstack-4308
Repository: cloudstack-git
Description
---
For 6.3 KVM, by default, snapshot is not supported. This is managed by a
global setting KVM.snapshot.enabled.
UI needs the API support for listCapabilities response, to stop user to set
recurring snapshot when snapshot is not supported for KVM 6.3.
Diffs
-
api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java
a30e26c
api/src/org/apache/cloudstack/api/response/CapabilitiesResponse.java
c2996f0
server/src/com/cloud/server/ManagementServerImpl.java 622e167
Diff: https://reviews.apache.org/r/13547/diff/
Testing
---
Before the fix, listCapabilities does not have the KVMSnapshotEnabled field:
listcapabilitiesresponse: {
capability: {
securitygroupsenabled: false,
cloudstackversion: 4.2.0-SNAPSHOT,
userpublictemplateenabled: true,
supportELB: false,
projectinviterequired: false,
allowusercreateprojects: true,
customdiskofferingmaxsize: 1024
}
I tested now with my fix, it shows:
listcapabilitiesresponse : { capability :
{securitygroupsenabled:true,cloudstackversion:4.2.0-SNAPSHOT,userpublictemplateenabled:true,supportELB:false,projectinviterequired:false,allowusercreateprojects:true,customdiskofferingmaxsize:1024,KVMsnapshotenabled:false}
--- default value is false;
I then set the default value to TRUE on MS, and call listCapabilities command
again:
{ listcapabilitiesresponse : { capability :
{securitygroupsenabled:true,cloudstackversion:4.2.0-SNAPSHOT,userpublictemplateenabled:true,supportELB:false,projectinviterequired:false,allowusercreateprojects:true,customdiskofferingmaxsize:1024,KVMsnapshotenabled:true}
} reflect the true value.
Verified the fix through the tests.
Thanks,
Fang Wang
Re: Review Request 13550: Added 5 missing tests from the QA repo to test_custom_hostname.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13550/#review25119 --- Review 13550 failed the build test : UNSTABLE The url of build cloudstack-master-with-patch #126 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/126/ - Jenkins Cloudstack.org On Aug. 14, 2013, 2:10 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13550/ --- (Updated Aug. 14, 2013, 2:10 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- Added 5 missing tests from the QA repo to test_custom_hostname.py in the ASF repo Diffs - test/integration/component/test_accounts.py cf18bef test/integration/component/test_custom_hostname.py 0898e1e Diff: https://reviews.apache.org/r/13550/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 13549: Merging missing tests from QA repo to ASF - Test Account 2 tests added
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13549/#review25120 --- Review 13549 failed the build test : UNSTABLE The url of build cloudstack-master-with-patch #127 is : http://jenkins.buildacloud.org/job/cloudstack-master-with-patch/127/ - Jenkins Cloudstack.org On Aug. 14, 2013, 2:01 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13549/ --- (Updated Aug. 14, 2013, 2:01 a.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- Added 2 missing tests for file test_accounts.py from the old QA repo to ASF Diffs - test/integration/component/test_accounts.py cf18bef Diff: https://reviews.apache.org/r/13549/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 13316: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13316/#review24713 --- Review 13316 failed the build test : FAILURE The url of build cloudstack-master-with-patch #113 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/113/ - Jenkins Cloudstack.org On Aug. 6, 2013, 9:14 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13316/ --- (Updated Aug. 6, 2013, 9:14 a.m.) Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOUDSTACK-3723 Repository: cloudstack-git Description --- CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database. Made the correction in the DB entry to point to Debian 7.0 template instead of Debain 6.0. Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 9cdbd84 setup/db/db/schema-410to420.sql f98bb50 setup/db/templates.sql ba13841 Diff: https://reviews.apache.org/r/13316/diff/ Testing --- Verifed the fix locally on cloudstack environment: 1. Created CS environment successfully. 2. SystemVMs are coming up fine. 3. UserVMs are getting deployed successfully. Thanks, Sanjay Tripathi
Re: Review Request 13325: preserve data in iso_id column while upgrading form 3.0.7 to 4.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13325/#review24722 --- Review 13325 failed the build test : FAILURE The url of build cloudstack-master-with-patch #114 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/114/ - Jenkins Cloudstack.org On Aug. 6, 2013, 1:11 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13325/ --- (Updated Aug. 6, 2013, 1:11 p.m.) Review request for cloudstack and Kishan Kavala. Bugs: Cloudstack-4100 Repository: cloudstack-git Description --- preserve data in iso_id column while upgrading form 3.0.7 to 4.2 Earlier was dropping the iso_id column as a result we loose data from the iso_id column prior to upgrade. Now fixed this by. renaming the iso_id to iso_id1 in schema-307to401 file. and then after upgrade dropping the iso_id column and renaming the iso_id1 to iso_id in 307to401 cleanup schema. Diffs - setup/db/db/schema-307to410-cleanup.sql 6a9e2af setup/db/db/schema-307to410.sql af296ab Diff: https://reviews.apache.org/r/13325/diff/ Testing --- tested the upgrade from 3.0.7 to 4.2. Thanks, bharat kumar
Re: Review Request 13324: CLOUDSTACK-4104: VM Creation should fail if a zone is dedicated to a domain and user of the same domain deploys vm without using affinity group Explicit Dedication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/#review24723 --- Review 13324 failed the build test : FAILURE The url of build cloudstack-master-with-patch #115 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/115/ - Jenkins Cloudstack.org On Aug. 6, 2013, 12:53 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13324/ --- (Updated Aug. 6, 2013, 12:53 p.m.) Review request for cloudstack and Devdeep Singh. Bugs: 4104 Repository: cloudstack-git Description --- To use dedicated resources one must specify the affinity group explicit dedication. If the affinity groups is not specified dedicated resources should not accessible. Currently there are checks for pod/clusters and hosts but zone could still be used. Added check that throws exception whenever a dedicated zone is being used to deploy vm but no affinity group is being used. Diffs - server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c Diff: https://reviews.apache.org/r/13324/diff/ Testing --- Dedicate zone to account/domain and do not use affinity group of type Explicit Dedication - VM deployment fails. Dedicate zone to appropriate account/domain and use affinity group of type Explicit Dedication - VM deployment passes. Build passes. Thanks, Saksham Srivastava
Re: Review Request 13266: CLOUDSTACK-3925: Allow Root Admin to deploy VMs on Zone dedicated to any domain/account
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13266/#review24641 --- Review 13266 failed the build test : FAILURE The url of build cloudstack-master-with-patch #112 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/112/ - Jenkins Cloudstack.org On Aug. 5, 2013, 10:57 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13266/ --- (Updated Aug. 5, 2013, 10:57 a.m.) Review request for cloudstack, Devdeep Singh and Prachi Damle. Bugs: 3925 Repository: cloudstack-git Description --- Currently Root admin cannot deploy vms on a zone dedicated to sub-domain, the fix will ensure the private zone functionality is maintained. The fix allows root admin to deploy vms on zone dedicated to any other domain by both the methods: 1)Using affinity group Explicit Dedication 2)Not using any affinity group. Diffs - plugins/affinity-group-processors/explicit-dedication/src/org/apache/cloudstack/affinity/ExplicitDedicationProcessor.java a0eb56c server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ebf2b0c server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java 10e23d7 Diff: https://reviews.apache.org/r/13266/diff/ Testing --- Root admin is now able to deploy vms on a zone dedicated to a sub domain. Build is successful. Thanks, Saksham Srivastava
Re: Review Request 13223: (CLOUDSTACK-2729) use file lock to prevent concurrent refreshPool/deleteVolume on KVM shared storage pool
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/#review24511 --- Review 13223 failed the build test : FAILURE The url of build cloudstack-master-with-patch #104 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/104/ - Jenkins Cloudstack.org On Aug. 2, 2013, 6:39 a.m., Wei Zhou wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13223/ --- (Updated Aug. 2, 2013, 6:39 a.m.) Review request for cloudstack, edison su and Wido den Hollander. Bugs: CLOUDSTACK-2729 Repository: cloudstack-git Description --- The storage pool issue (CLOUDSTACK-2729) is because of a bug in libvirt (https://bugzilla.redhat.com/show_bug.cgi?id=977706) We need to prevent deleting a volume when refreshing the pool. This patch use a simple file lock to implement it. PS: I have tested another file lock similar to Read/Write file lock, but it was very unstable. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java dae25ae Diff: https://reviews.apache.org/r/13223/diff/ Testing --- Applied on 4.0.2 and 4.0.1 Testing On 4.0.1 From 20,June 3 nodes, create a VM on each node every 15 minutes. Destroy the VMs 5 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 Testing On 4.0.2 From 01,July 2 nodes, create two VMs on each node every 5 minutes. Destroy the VMs 4 minutes later. expunge.inteval = 600 (10 minutes), expunge.worker = 2 Thanks, Wei Zhou
Re: Review Request 13239: fixed the test test_non_contigiousvlan.py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13239/#review24521 --- Review 13239 failed the build test : FAILURE The url of build cloudstack-master-with-patch #105 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/105/ - Jenkins Cloudstack.org On Aug. 2, 2013, 10:54 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13239/ --- (Updated Aug. 2, 2013, 10:54 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- fixed the test test_non_contigiousvlan.py https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Diffs - test/integration/smoke/test_non_contigiousvlan.py 5fdc034 Diff: https://reviews.apache.org/r/13239/diff/ Testing --- tested on 4.2 Thanks, bharat kumar
Re: Review Request 12360: custom cpu model for kvm guest.the default model 'QEMU Virtual CPU version xxx' affect the activation of Windows OS and low performance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12360/#review24525 --- Review 12360 failed the build test : FAILURE The url of build cloudstack-master-with-patch #107 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/107/ - Jenkins Cloudstack.org On July 14, 2013, 3:38 a.m., Jijun wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12360/ --- (Updated July 14, 2013, 3:38 a.m.) Review request for cloudstack, edison su, soren, and Wei Zhou. Repository: cloudstack-git Description --- Add cpu model for kvm guest.Now all the kvm guest's cpu model is 'QEMU Virtual CPU version xxx'. This will affect the activation of Windows OS and low performance. I add three mode for user to indicate the guest cpu model. some ideas come from openstack and libvirt. user can uncomment guest.cpu.mode and guest.cpu.model in agent.properties to enable this feature.it is disabled by default. some details as follows: custom - user custom the CPU model which specified by guest.cpu.model. host-model - identify the named CPU model which most closely matches the host, and then request additional CPU flags to complete the match. This should give close to maximum functionality/performance, which maintaining good reliability/compatibility if the guest is migrated to another host with slightly different host CPUs. host-passthrough - tell KVM to passthrough the host CPU with no modifications. The difference to host-model, instead of just matching feature flags, every last detail of the host CPU is matched. This gives absolutely best performance,and can be important to some apps which check low level CPU details, but it comes at a cost wrt migration. The guest can only be migrated to an exactly matching host CPU. Diffs - agent/conf/agent.properties 60030ae plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 24f9ee0 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 5120870 plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtVMDefTest.java 2c0ff8d Diff: https://reviews.apache.org/r/12360/diff/ Testing --- 1.set guest.cpu.mode=custom,guest.cpu.model=Nehalem in agent.properties,you can get more guest.cpu.model by execute virsh capabilities .create a new vm instance or reboot your vm instance,the guest's cpu model will change as guest.cpu.model specified. 2.set guest.cpu.mode=host-model,create a new vm instance or reboot your vm instance the guest's cpu model will be a closely cpu model as your hypervisor. 3.set guest.cpu.mode=host-passthrough,create a new vm instance or reboot your vm instance,the guest's cpu model should be the cpu model as your hypervisor. Thanks, Jijun
Re: Review Request 13238: JIRA-3701 : VM instantiation : Sending network information to a new VM instance
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13238/#review24526 --- Review 13238 failed the build test : FAILURE The url of build cloudstack-master-with-patch #108 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/108/ - Jenkins Cloudstack.org On Aug. 2, 2013, 11:56 a.m., Nicolas FOATA wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13238/ --- (Updated Aug. 2, 2013, 11:56 a.m.) Review request for cloudstack. Repository: cloudstack-git Description --- Abstract/suggestion: While a VM is instantiated, CloudStack could also send the following information if need be : - the instance name (CS uuid) - the display name - VM tags - network information (IPv4, IPv6, netmask, routing, gateway, mac address, etc.) just if we activate some global settings such as : - vm.instance.boot.network.required (true/false) - vm.instance.boot.vmname (true/false) - vm.instance.boot.uuid (true/false) - vm.instance.boot.tags (true/false) Applications: - A VM could discover its network and dialog with physical and virtual machines, etc. - A VM do not need a virtual router - According of this type of information (tags, names, …) , management servers could be able to configure and deploy correctly VMs. Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7173f0b plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 11a7b42 server/src/com/cloud/configuration/Config.java c815c77 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/13238/diff/ Testing --- Set global settings : instanciantion of VMs : checking if extra parameters are corrected and well send (even in base64URLSafe + / = - _) Thanks, Nicolas FOATA
Re: Review Request 13240: dealt with some warnings in NetworkServiceImpl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/#review24529 --- Review 13240 failed the build test : FAILURE The url of build cloudstack-master-with-patch #109 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/109/ - Jenkins Cloudstack.org On Aug. 2, 2013, 1:15 p.m., daan Hoogland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13240/ --- (Updated Aug. 2, 2013, 1:15 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- dealt with some warnings in NetworkServiceImpl Diffs - server/src/com/cloud/network/NetworkServiceImpl.java ff753f4 Diff: https://reviews.apache.org/r/13240/diff/ Testing --- Thanks, daan Hoogland
Re: Review Request 13241: was not populating the overcommit details in uservm details when overcommit is decreased to one.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13241/#review24530 --- Review 13241 failed the build test : FAILURE The url of build cloudstack-master-with-patch #110 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/110/ - Jenkins Cloudstack.org On Aug. 2, 2013, 1:36 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13241/ --- (Updated Aug. 2, 2013, 1:36 p.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- was not populating the overcommit details in uservm details when overcommit is decreased to one. Diffs - server/src/com/cloud/vm/VirtualMachineManagerImpl.java cf24502 Diff: https://reviews.apache.org/r/13241/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 11861: double slash fix for windows based nfs servers [CLOUDSTACK-2968]
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11861/#review24436 --- Review 11861 failed the build test : FAILURE The url of build cloudstack-master-with-patch #101 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/101/ - Jenkins Cloudstack.org On Aug. 1, 2013, 11:39 a.m., daan Hoogland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11861/ --- (Updated Aug. 1, 2013, 11:39 a.m.) Review request for cloudstack and John Burwell. Bugs: CLOUDSTACK-2968 Repository: cloudstack-git Description --- double slash breaks windows based nfs servers [CLOUDSTACK-2968] Diffs - api/src/com/cloud/storage/template/TemplateInfo.java 6559d73 core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java 98a957f core/src/com/cloud/agent/api/storage/DownloadAnswer.java bb7b8a9 core/src/com/cloud/storage/template/TemplateLocation.java 58d023a engine/schema/src/com/cloud/storage/VMTemplateHostVO.java b8dfc41 engine/storage/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java a6880c3 server/src/com/cloud/storage/download/DownloadListener.java 1d48803 server/src/com/cloud/storage/download/DownloadMonitorImpl.java f72a563 server/src/com/cloud/template/HypervisorTemplateAdapter.java 322f32e server/src/com/cloud/template/TemplateManagerImpl.java 517d4ba utils/src/com/cloud/utils/FileUtil.java 74f4088 utils/test/com/cloud/utils/FileUtilTest.java PRE-CREATION Diff: https://reviews.apache.org/r/11861/diff/ Testing --- database analysis Thanks, daan Hoogland
Re: Review Request 13192: create private network test
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/#review24443 --- Review 13192 failed the build test : FAILURE The url of build cloudstack-master-with-patch #102 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/102/ - Jenkins Cloudstack.org On Aug. 1, 2013, 2:52 p.m., daan Hoogland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13192/ --- (Updated Aug. 1, 2013, 2:52 p.m.) Review request for cloudstack, Koushik Das and Sheng Yang. Bugs: CLOUDSTACK-1532 Repository: cloudstack-git Description --- This is a unit test I have been carrying in my work on CLOUDSTACK-1532. It occurred to me it can be submitted separately. Diffs - server/test/com/cloud/network/CreatePrivateNetworkTest.java PRE-CREATION Diff: https://reviews.apache.org/r/13192/diff/ Testing --- Thanks, daan Hoogland
Re: Review Request 13198: Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13198/#review24488 --- Review 13198 failed the build test : FAILURE The url of build cloudstack-master-with-patch #103 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/103/ - Jenkins Cloudstack.org On Aug. 1, 2013, 10:49 p.m., Rayees Namathponnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13198/ --- (Updated Aug. 1, 2013, 10:49 p.m.) Review request for cloudstack, Prasanna Santhanam and Sheng Yang. Repository: cloudstack-git Description --- Fixing cleanup issues with test_vpn_users.py; test case need to teardown all resources incase any failure in setup Diffs - test/integration/component/test_vpn_users.py fe020d0 Diff: https://reviews.apache.org/r/13198/diff/ Testing --- Tested Thanks, Rayees Namathponnan
Re: Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13102/#review24331 --- Review 13102 PASSED the build test The url of build cloudstack-master-with-patch #91 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/91/ - Jenkins Cloudstack.org On July 31, 2013, 7:15 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13102/ --- (Updated July 31, 2013, 7:15 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-3969 Repository: cloudstack-git Description --- CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup This is due to mysql version conflict with '=' and 'LIKE'. Changing to '=' while searching for new system template. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf Diff: https://reviews.apache.org/r/13102/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13107/#review24344 --- Review 13107 PASSED the build test The url of build cloudstack-master-with-patch #92 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/92/ - Jenkins Cloudstack.org On July 31, 2013, 11:19 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13107/ --- (Updated July 31, 2013, 11:19 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-2717 Repository: cloudstack-git Description --- CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API This is to fix allow.public.user.templates configuration parameter to get the value at account level. Diffs - server/src/com/cloud/server/ManagementServerImpl.java 26efa10 Diff: https://reviews.apache.org/r/13107/diff/ Testing --- Tested locally by firing listcapabilities API call for Admin/user Thanks, Harikrishna Patnala
Re: Review Request 13109: CLOUDSTACK-3594: Fixes related to affinity groups
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13109/#review24346 --- Review 13109 failed the build test : FAILURE The url of build cloudstack-master-with-patch #93 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/93/ - Jenkins Cloudstack.org On July 31, 2013, 12:13 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13109/ --- (Updated July 31, 2013, 12:13 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Fixed test case issues mentioned in issue https://issues.apache.org/jira/browse/CLOUDSTACK-3594 Radom-ized affinity group name to avoid cascading test case failures stating unable to create affinity group due to affinity group with the same name exists. Included following 2 test suites which were not run in last build because there was no decorator for the test cases. 1. TestListAffinityGroups 2. TestUpdateVMAffinityGroups One test case in TestUpdateVMAffinityGroups is skipped, it's failing right now. Will be fixed shortly. Diffs - test/integration/component/test_affinity_groups.py 3ecab6f tools/marvin/marvin/integration/lib/base.py b552aba Diff: https://reviews.apache.org/r/13109/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 13112: upgrade to ASF 4.2 cloud Database Schema Inconsistencies on the Upgraded Setup - Table volumes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/#review24349 --- Review 13112 failed the build test : FAILURE The url of build cloudstack-master-with-patch #94 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/94/ - Jenkins Cloudstack.org On July 31, 2013, 2:53 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13112/ --- (Updated July 31, 2013, 2:53 p.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: Cloudstack-3836 Repository: cloudstack-git Description --- upgrade to ASF 4.2 cloud Database Schema Inconsistencies on the Upgraded Setup - Table volumes https://issues.apache.org/jira/browse/CLOUDSTACK-3836 This extra column is because of the fix Parent id of template incorrectly recorded as last ISO attached to VM. when a template is created form the snapshot the sourcetemplateid is recorded as the iso attached to the VM at thee time of creation. we fix this by adding a iso_id column to the volume table. when a template is created from the snapshot we fetch the iso_id form the parent volume and set it as the sourcetemplated id of the newly created template. Diffs - engine/schema/src/com/cloud/storage/VolumeVO.java 1445e99 engine/schema/src/com/cloud/upgrade/dao/DbUpgradeUtils.java c37be3e engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf server/src/com/cloud/storage/VolumeManager.java 2e44a3c server/src/com/cloud/storage/VolumeManagerImpl.java d8cbf11 server/src/com/cloud/template/TemplateManagerImpl.java 8ccc567 server/src/com/cloud/vm/VirtualMachineManagerImpl.java eedf4d2 setup/db/db/schema-410to420.sql 9cdf837 Diff: https://reviews.apache.org/r/13112/diff/ Testing --- Tested on 4.2. Thanks, bharat kumar
Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review24405 --- Review 12192 failed the build test : FAILURE The url of build cloudstack-master-with-patch #97 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/97/ - Jenkins Cloudstack.org On June 29, 2013, 9:08 p.m., Dave Brosius wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/ --- (Updated June 29, 2013, 9:08 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- code checks the parameter 'state' and if null, set it to Allocated, even though that parameter is never accessed. Meant to set the field 'state'. Diffs - engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 Diff: https://reviews.apache.org/r/12192/diff/ Testing --- Thanks, Dave Brosius
Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12185/#review24407 --- Review 12185 failed the build test : FAILURE The url of build cloudstack-master-with-patch #98 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/98/ - Jenkins Cloudstack.org On June 29, 2013, 2:34 a.m., Dave Brosius wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12185/ --- (Updated June 29, 2013, 2:34 a.m.) Review request for cloudstack. Repository: cloudstack-git Description --- code relies on classes in backport-util-concurrent, when these classes are now available in the jdk supported by cloudstack. Just switch the imports to the built in classes. Diffs - api/test/org/apache/cloudstack/api/command/test/AddClusterCmdTest.java 90759fe api/test/org/apache/cloudstack/api/command/test/AddHostCmdTest.java 531f511 engine/schema/src/com/cloud/keystore/KeystoreDaoImpl.java 0ea97c7 engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java b92f92f engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateDataStoreDaoImpl.java 362f7a6 plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BareMetalResourceBase.java d46048e plugins/network-elements/nicira-nvp/test/com/cloud/network/guru/NiciraNvpGuestNetworkGuruTest.java 0e4f8fd server/src/com/cloud/agent/manager/AgentManagerImpl.java b24a238 server/src/com/cloud/configuration/ConfigurationManagerImpl.java 2089f82 server/src/com/cloud/consoleproxy/ConsoleProxyBalanceAllocator.java 45f0faa server/src/com/cloud/network/security/SecurityGroupManagerImpl.java 1c189c4 server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d server/src/com/cloud/server/ManagementServerImpl.java 40bc437 tools/whisker/descriptor-for-packaging.xml 66099ae utils/src/com/cloud/utils/db/GenericDaoBase.java f0fc700 utils/src/com/cloud/utils/storage/encoding/Decoder.java fe74a04 utils/src/com/cloud/utils/xmlobject/XmlObject.java 67bb8ed vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java d112c34 vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java cabb60a vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java e7fd922 vmware-base/src/com/cloud/hypervisor/vmware/mo/PerfManagerMO.java bb4fb56 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java cf5ffde Diff: https://reviews.apache.org/r/12185/diff/ Testing --- Thanks, Dave Brosius
Re: Review Request 13056: CLOUDSTACK-3168: Fix test_reboot_router.py to ssh using public IP
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13056/#review24218 --- Review 13056 PASSED the build test The url of build cloudstack-master-with-patch #79 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/79/ - Jenkins Cloudstack.org On July 30, 2013, 7:17 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13056/ --- (Updated July 30, 2013, 7:17 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3168 Repository: cloudstack-git Description --- test_reboot_router.py was trying to ssh to vm using private IP and hence it failed with error No route to host. Fixed the testcase to ssh using public IP. Diffs - test/integration/smoke/test_network.py dad5630 Diff: https://reviews.apache.org/r/13056/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 13057: CLOUDSTACK-2909: patch to fix TAB in US keyboard.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13057/#review24219 --- Review 13057 PASSED the build test The url of build cloudstack-master-with-patch #80 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/80/ - Jenkins Cloudstack.org On July 30, 2013, 8:50 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13057/ --- (Updated July 30, 2013, 8:50 a.m.) Review request for cloudstack, Devdeep Singh and Fang Wang. Bugs: CLOUDSTACK-2909 Repository: cloudstack-git Description --- CLOUDSTACK-2909: patch to fix TAB in US keyboard. Diffs - services/console-proxy/server/js/ajaxkeys.js 725c8c5 Diff: https://reviews.apache.org/r/13057/diff/ Testing --- Verified the fix locally on Windows 7 as guestOS and Xenserver 6.2 as hypervisor. Thanks, Sanjay Tripathi
Re: Review Request 13058: unable to update the concurrent_connections in networkoffering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/#review24220 --- Review 13058 failed the build test : FAILURE The url of build cloudstack-master-with-patch #81 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/81/ - Jenkins Cloudstack.org On July 30, 2013, 10:24 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13058/ --- (Updated July 30, 2013, 10:24 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2997 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-2997 cloud not update the concurrent_connections parameter of networkoffering because of some dao dependency. The update was not happening because of choosing a VO variable name having a underscore. Diffs - engine/schema/src/com/cloud/offerings/NetworkOfferingVO.java 406d98a server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3ec3514 Diff: https://reviews.apache.org/r/13058/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 13060: Mid-term report for Dharmesh's update
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13060/#review24229 --- Review 13060 PASSED the build test The url of build cloudstack-master-with-patch #82 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/82/ - Jenkins Cloudstack.org On July 30, 2013, 11:42 a.m., Dharmesh Kakadia wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13060/ --- (Updated July 30, 2013, 11:42 a.m.) Review request for cloudstack and Sebastien Goasguen. Repository: cloudstack-git Description --- GSoC updates from Dharmesh Diffs - docs/en-US/gsoc-midsummer-dharmesh.xml 69e417a Diff: https://reviews.apache.org/r/13060/diff/ Testing --- Built with publican Thanks, Dharmesh Kakadia
Re: Review Request 13062: Disable password change on UI when ldap is enabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13062/#review24231 --- Review 13062 failed the build test : FAILURE The url of build cloudstack-master-with-patch #83 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/83/ - Jenkins Cloudstack.org On July 30, 2013, 1:41 p.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13062/ --- (Updated July 30, 2013, 1:41 p.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repository: cloudstack-git Description --- General clean up + Disable password change on UI when ldap is enabled Diffs - client/WEB-INF/classes/resources/messages.properties 3e775e0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccount.java 01aebce plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 98c9fcf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 27f3dfc plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVOSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapCreateAccountCmdSpec.groovy PRE-CREATION plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy f4d185b plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListAllUsersCmdSpec.groovy 2756e92 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapUserSpec.groovy cf2f9ec plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif f46a383 ui/dictionary.jsp eec0264 ui/scripts/accounts.js 43b242d ui/scripts/ui-custom/accountsWizard.js 7951553 Diff: https://reviews.apache.org/r/13062/diff/ Testing --- Unit tests, ran + looked at. Thanks, Ian Duffy
Re: Review Request 13061: Unable to create the Internal LB vm.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13061/#review24233 --- Review 13061 failed the build test : FAILURE The url of build cloudstack-master-with-patch #84 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/84/ - Jenkins Cloudstack.org On July 30, 2013, 1:07 p.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13061/ --- (Updated July 30, 2013, 1:07 p.m.) Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Ram Ganesh. Bugs: 3924 Repository: cloudstack-git Description --- Issue: == Unable to created internalLB Vm. this is due while determining maxconn value from networkoffering. to find the networking offering, networkid is passed instead of networkoffering id which is causing the issue. fixed: = fixed the issue by passing the network offering id instead of network id. Diffs - plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java 76507e9 Diff: https://reviews.apache.org/r/13061/diff/ Testing --- 1. was able to create the 'b' vm. internal LB VM. Thanks, Rajesh Battala
Re: Review Request 10776: CLOUDSTACK-2191: Added the following to tests to qualify Optional Public IP changes happend in EIP enabled Zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10776/#review24252 --- Review 10776 PASSED the build test The url of build cloudstack-master-with-patch #86 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/86/ - Jenkins Cloudstack.org On July 30, 2013, 4:07 p.m., venkata swamy babu budumuru wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10776/ --- (Updated July 30, 2013, 4:07 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-2191 Repository: cloudstack-git Description --- CLOUDSTACK-2191: Added the following to tests to qualify Optional Public IP changes happend in EIP enabled Zone 1. Verify that the EIP zone is created with AssociatePublicIp capability set to false 2. Verify that VM doesn't get public ip by default after deployVirtualMachine 3. Eanble static NAT and verify EIP semantics 4. disable static NAT and verify EIP semantics Diffs - test/integration/component/test_eip_optional_publicip.py PRE-CREATION Diff: https://reviews.apache.org/r/10776/diff/ Testing --- Encountered few bugs while doing pilot run of the suite hence, couldn't test it completely. Bugs encountered during the run are : CLOUDSTACK-2193 https://issues.apache.org/jira/browse/CLOUDSTACK-2193 CLOUDSTACK-2192 https://issues.apache.org/jira/browse/CLOUDSTACK-2192 Thanks, venkata swamy babu budumuru
Re: Review Request 13065: Add support for memberof filter i.e. groups within LDAP.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13065/#review24255 --- Review 13065 failed the build test : FAILURE The url of build cloudstack-master-with-patch #87 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/87/ - Jenkins Cloudstack.org On July 30, 2013, 5:06 p.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13065/ --- (Updated July 30, 2013, 5:06 p.m.) Review request for cloudstack and Abhinandan Prateek. Repository: cloudstack-git Description --- Add support for memberof filter i.e. groups within LDAP. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java d0ae4d2 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java f255752 server/src/com/cloud/configuration/Config.java 1ec0576 setup/db/db/schema-410to420.sql f4cd1b1 Diff: https://reviews.apache.org/r/13065/diff/ Testing --- Tested against active directory, worked successfully. If the value is left empty its not applied. Thanks, Ian Duffy
Re: Review Request 13088: CLOUDSTACK-3959: [KVM] agent setup failed when physical interface name is in pXpY format
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/#review24303 --- Review 13088 PASSED the build test The url of build cloudstack-master-with-patch #89 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/89/ - Jenkins Cloudstack.org On July 30, 2013, 10:18 p.m., Toshiaki Hatano wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13088/ --- (Updated July 30, 2013, 10:18 p.m.) Review request for cloudstack, edison su and Wido den Hollander. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3959 Repository: cloudstack-git Description --- CloudStack failed to add kvm host when 'pXpY' name format (udev named) physical interface is a member of the bridge (kvm traffic label) on the host. Root cause is in com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.matchPifFileInDirectory(String). There're no handling code for 'pXpY' format interface, so I added that. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 571bcc8 Diff: https://reviews.apache.org/r/13088/diff/ Testing --- Tested locally, advanced zone with vlan isolation, kvm hypervisor (ubuntu 13.04). Thanks, Toshiaki Hatano
Re: Review Request 13093: Put retry logic to check existence/non-existence of created/deleted files even though vSphere returns successful completion on wait for asynchronous task.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13093/#review24312 --- Review 13093 PASSED the build test The url of build cloudstack-master-with-patch #90 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/90/ - Jenkins Cloudstack.org On July 31, 2013, 12:41 a.m., Venkata Siva Vijayendra Bhamidipati wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13093/ --- (Updated July 31, 2013, 12:41 a.m.) Review request for cloudstack, Alena Prokharchyk, Chip Childers, Kelven Yang, and Sateesh Chodapuneedi. Bugs: CLOUDSTACK-3568 Repository: cloudstack-git Description --- When a large number of VMs are created in parallel in vmware deployments, vSphere can slow down and return wrong results for its APIs. For example, the mgmt server correctly waits on the results of asynchronous tasks like deletion/moving of VM root volume files, but vSphere is returning success for those APIs even when the underlying files aren't yet removed/created from/on the actual storage. So we need to work around this using retry logic. This fix puts that in when creating VMs. Diffs - plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 112a0cb Diff: https://reviews.apache.org/r/13093/diff/ Testing --- The fix has been tested with parallel creation of ~15 VMs on vmware and the described issues have not been seen. There seem to be some other exceptions with some VMs, but they are not related to this code path. Thanks, Venkata Siva Vijayendra Bhamidipati
Re: Review Request 13009: CLOUDSTACK-3744 - Accounts not cleaned up
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24093 --- Review 13009 PASSED the build test The url of build cloudstack-master-with-patch #66 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/66/ - Jenkins Cloudstack.org On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/ --- (Updated July 29, 2013, 4:12 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3744 Repository: cloudstack-git Description --- Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. Diffs - test/integration/component/test_netscaler_nw_off.py 5fd2195 Diff: https://reviews.apache.org/r/13009/diff/ Testing --- Tested locally. Script is now passing and cleanup of all accounts done. Thanks, Sowmya Krishnan
Re: Review Request 13010: rb-jenkins-integration test patch
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13010/#review24097 --- Review 13010 PASSED the build test The url of build cloudstack-master-with-patch #67 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/67/ - Jenkins Cloudstack.org On July 29, 2013, 6:34 a.m., Prasanna Santhanam wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13010/ --- (Updated July 29, 2013, 6:34 a.m.) Review request for cloudstack, Hugo Trippaers and Prasanna Santhanam. Repository: cloudstack-git Description --- Test patch request for rb-jenkins integration. Do not merge https://github.com/CloudStack-extras/reviewboard-tools/issues/2 Diffs - INSTALL.md b0e1a761 Diff: https://reviews.apache.org/r/13010/diff/ Testing --- Thanks, Prasanna Santhanam
Re: Review Request 13015: CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13015/#review24130 --- Review 13015 PASSED the build test The url of build cloudstack-master-with-patch #68 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/68/ - Jenkins Cloudstack.org On July 29, 2013, 1:04 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13015/ --- (Updated July 29, 2013, 1:04 p.m.) Review request for cloudstack, Devdeep Singh and Fang Wang. Bugs: CLOUDSTACK-1961 Repository: cloudstack-git Description --- CLOUDSTACK-1961: Common issues found in English OS with EN-US standard Keyboard. Diffs - services/console-proxy/server/js/ajaxviewer.js a6e1eda Diff: https://reviews.apache.org/r/13015/diff/ Testing --- Tested the fix on windows 7 guestOS and Xenserver hypervisor. Thanks, Sanjay Tripathi
Re: Review Request 13012: createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13012/#review24131 --- Review 13012 failed the build test : FAILURE The url of build cloudstack-master-with-patch #69 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/69/ - Jenkins Cloudstack.org On July 29, 2013, 11:21 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13012/ --- (Updated July 29, 2013, 11:21 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-2622 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-2622 createipAlias.sh/deleteipAliash.sh should not be allowed with Isolated Guest Networks Diffs - server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 2a8a6e2 Diff: https://reviews.apache.org/r/13012/diff/ Testing --- Tested with 4.2 Thanks, bharat kumar
Re: Review Request 13014: CLOUDSTACK-3841: Fixed TestDeleteSecurityGroup.test_01_delete_security_grp_running_vm
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13014/#review24132 --- Review 13014 failed the build test : FAILURE The url of build cloudstack-master-with-patch #70 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/70/ - Jenkins Cloudstack.org On July 29, 2013, 12:39 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13014/ --- (Updated July 29, 2013, 12:39 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- The exception raised is valid behavior. It attempts to delete security group without destroying vm in it, hence expecting exception in the operation. Added self.assertRaises for the security group delete operation. Works fin now. Diffs - test/integration/component/test_security_groups.py 3c25e25 Diff: https://reviews.apache.org/r/13014/diff/ Testing --- Tested on KVM basic setup. Thanks, Gaurav Aradhye
Re: Review Request 13013: remove the duplicate entries of the data-server from the /etc/hosts
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13013/#review24134 --- Review 13013 failed the build test : FAILURE The url of build cloudstack-master-with-patch #71 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/71/ - Jenkins Cloudstack.org On July 29, 2013, 12:17 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13013/ --- (Updated July 29, 2013, 12:17 p.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: Cloudstack-3882 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3882 remove the duplicate entries of the data-server from the /etc/hosts Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config c0a7189 Diff: https://reviews.apache.org/r/13013/diff/ Testing --- Tested on 4.2 Thanks, bharat kumar
Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13016/#review24137 --- Review 13016 failed the build test : FAILURE The url of build cloudstack-master-with-patch #72 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/72/ - Jenkins Cloudstack.org On July 29, 2013, 1:46 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13016/ --- (Updated July 29, 2013, 1:46 p.m.) Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-3848 Repository: cloudstack-git Description --- CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM Diffs - api/src/com/cloud/event/EventTypes.java 6f1eed6 api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 758d9c1 server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd Diff: https://reviews.apache.org/r/13016/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala
Re: Review Request 13022: Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13022/#review24151 --- Review 13022 failed the build test : FAILURE The url of build cloudstack-master-with-patch #73 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/73/ - Jenkins Cloudstack.org On July 29, 2013, 5:14 p.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13022/ --- (Updated July 29, 2013, 5:14 p.m.) Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. Bugs: Cloustack-3910 Repository: cloudstack-git Description --- Cloudstack-3910 Upgrade from 3.0.6 to 4.2 is failing with DB exceptions. https://issues.apache.org/jira/browse/CLOUDSTACK-3910 Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java e8ca579 setup/db/db/schema-410to420.sql 7377cbd Diff: https://reviews.apache.org/r/13022/diff/ Testing --- Tested upgrade from 3.0.6 to 4.2 Thanks, bharat kumar
Re: Review Request 13020: CLOUDSTACK-3252 An instance deployed using explicit or implicit dedication doesn't generate a usage even
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13020/#review24152 --- Review 13020 failed the build test : FAILURE The url of build cloudstack-master-with-patch #74 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/74/ - Jenkins Cloudstack.org On July 29, 2013, 3:58 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13020/ --- (Updated July 29, 2013, 3:58 p.m.) Review request for cloudstack, Devdeep Singh and Kishan Kavala. Bugs: 3252 Repository: cloudstack-git Description --- If an instance is deployed using explicit or implicit dedication, or neither of them a usage event isn't generated. Added 2 new usage_events : EVENT_DEDICATED_VM_CREATE_IMPLICIT and EVENT_DEDICATED_VM_CREATE_EXPLICIT generated when VMs are deployed using corresponding dedications. Diffs - api/src/com/cloud/event/EventTypes.java 6f1eed6 server/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e Diff: https://reviews.apache.org/r/13020/diff/ Testing --- usage_events table has now entries for new types: select * from usage_event where type like VM%CREATE% id: 25 type: VM.CREATE.IMPLICIT account_id: 2 created: 2013-07-29 15:46:36 zone_id: 1 resource_id: 7 resource_name: c85cbc76-36fb-4fdc-97d6-8179f670cc54 offering_id: 15 template_id: 5 size: NULL resource_type: XenServer processed: 0 virtual_size: NULL Build passed. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 12912: Fix for packaging defect CLOUDSTACK-2133
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12912/#review24157 --- Review 12912 PASSED the build test The url of build cloudstack-master-with-patch #75 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/75/ - Jenkins Cloudstack.org On July 29, 2013, 6:19 p.m., Rayees Namathponnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12912/ --- (Updated July 29, 2013, 6:19 p.m.) Review request for cloudstack, Koushik Das, Hugo Trippaers, and Wido den Hollander. Bugs: CLOUDSTACK-2133 Repository: cloudstack-git Description --- The Cisco VNMC xml files are present under plugins/network-elements/cisco-vnmc/scripts/network/cisco. All xml files present there needs to be included in the build package. Diffs - packaging/centos63/cloud.spec 61e00bd Diff: https://reviews.apache.org/r/12912/diff/ Testing --- Tested File Attachments updated with file permission from agent to common https://reviews.apache.org/media/uploaded/files/2013/07/29/0001-follow-up-patch-for-CLOUDSTACK-2133_2.patch Thanks, Rayees Namathponnan
Re: Review Request 13025: Bugfix CLOUDSTACK-3915: Creating is mis-spelled in CreateFirewallRuleCmd
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13025/#review24160 --- Review 13025 PASSED the build test The url of build cloudstack-master-with-patch #76 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/76/ - Jenkins Cloudstack.org On July 29, 2013, 7:20 p.m., Jonathan Creasy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13025/ --- (Updated July 29, 2013, 7:20 p.m.) Review request for cloudstack. Bugs: CLOUDSTACK-3915 Repository: cloudstack-git Description --- Fixing a typo in the firewall creation rule script. Diffs - api/src/org/apache/cloudstack/api/command/user/firewall/CreateFirewallRuleCmd.java ff8e283 Diff: https://reviews.apache.org/r/13025/diff/ Testing --- Ran it, seems to work. Thanks, Jonathan Creasy
Re: Review Request 13047: VMSnapshot chainSize check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13047/#review24186 --- Review 13047 failed the build test : FAILURE The url of build cloudstack-master-with-patch #77 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/77/ - Jenkins Cloudstack.org On July 30, 2013, 12:38 a.m., Amogh Vasekar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13047/ --- (Updated July 30, 2013, 12:38 a.m.) Review request for cloudstack and mice xia. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3591 Repository: cloudstack-git Description --- Add check to ensure chainSize adds memory size to ROOT volume only when VMSnapshot Type is DiskAndMemory Diffs - plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 10b6de9 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java fa7f2ec Diff: https://reviews.apache.org/r/13047/diff/ Testing --- Local environment Thanks, Amogh Vasekar
Re: Review Request 13004: Bug:advance zone, create public Network with vlan id specified, but the portgroup is cloud.public.untagged.0.1-vSwitch0 not cloud.public.[vlanid].0.1-vSwitch0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13004/#review24059 --- Review 13004 PASSED the build test The url of build cloudstack-master-with-patch #64 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/64/ - Jenkins Cloudstack.org On July 28, 2013, 11:49 a.m., Jijun wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13004/ --- (Updated July 28, 2013, 11:49 a.m.) Review request for cloudstack, edison su and Wei Zhou. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3883 Repository: cloudstack-git Description --- In lastest CS 4.2 code, I create advance zone with hypervisor vmware esxi, create public Network with vlan id 509 specified and label vSwitch0, when cs create systemvm(cpvm,ssvm), a new portgroup with name cloud.public.untagged.0.1-vSwitch0 was created, not a portgroup cloud.public.509.0.1-vSwitch0 as expected. in database table nics, the field broadcast_uri for new systemvm is vlan:509 , and should be vlan://509 debug the code and found it is a syntax error in Networks.java for new instance java.net.URI. Diffs - api/src/com/cloud/network/Networks.java c76c3d4 Diff: https://reviews.apache.org/r/13004/diff/ Testing --- recreate the system vm or create a new advance zone , public network with vlan Thanks, Jijun
Re: Review Request 13008: Fix usage of vm.instancename.flag when generating VM names on ESX hypervisor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/#review24078 --- Review 13008 failed the build test : FAILURE The url of build cloudstack-master-with-patch #65 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/65/ - Jenkins Cloudstack.org On July 29, 2013, 1:55 a.m., Venkata Siva Vijayendra Bhamidipati wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ --- (Updated July 29, 2013, 1:55 a.m.) Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description --- The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Diffs - engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java 96fb1d9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java d1392c4 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java e5c33cc plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 439163a plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 02e4e64 server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 server/src/com/cloud/hypervisor/HypervisorGuruBase.java ec68529 server/src/com/cloud/vm/UserVmManagerImpl.java 3831f88 server/src/com/cloud/vm/VirtualMachineManagerImpl.java a3187ba vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java dd0f889 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java e2dd789 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java ac14328 Diff: https://reviews.apache.org/r/13008/diff/ Testing --- Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. Thanks, Venkata Siva Vijayendra Bhamidipati
Re: Review Request 12993: CLOUDSTACK-3874: Adding method to cloud-early-config to allow updation of systemvms log rotation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/#review24014 --- Review 12993 PASSED the build test The url of build cloudstack-master-with-patch #58 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/58/ - Jenkins Cloudstack.org On July 27, 2013, 8:55 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12993/ --- (Updated July 27, 2013, 8:55 a.m.) Review request for cloudstack and Abhinandan Prateek. Bugs: 3874 Repository: cloudstack-git Description --- log4j policies in systemvms must be updated to avoid getting full disk space used. cloud-early-config must replace log4j.xml with updated policies. Diffs - patches/systemvm/debian/config/etc/init.d/cloud-early-config 02af602 Diff: https://reviews.apache.org/r/12993/diff/ Testing --- Build is successful. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 12992: CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/#review24021 --- Review 12992 PASSED the build test The url of build cloudstack-master-with-patch #59 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/59/ - Jenkins Cloudstack.org On July 27, 2013, 8:48 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12992/ --- (Updated July 27, 2013, 8:48 a.m.) Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOUDSTACK-3544 Repository: cloudstack-git Description --- CLOUDSTACK-3544: Patch to support upgrade to Xenserver 6.2 Added new guestOS in the schema-410to420 file supported by Xenserver 6.2 Diffs - setup/db/db/schema-410to420.sql 8409c47 Diff: https://reviews.apache.org/r/12992/diff/ Testing --- Thanks, Sanjay Tripathi
Re: Review Request 12997: usage event is not generated for volume resize
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12997/#review24031 --- Review 12997 failed the build test : FAILURE The url of build cloudstack-master-with-patch #60 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/60/ - Jenkins Cloudstack.org On July 27, 2013, 3:11 p.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12997/ --- (Updated July 27, 2013, 3:11 p.m.) Review request for cloudstack, Devdeep Singh, Kishan Kavala, and Ram Ganesh. Repository: cloudstack-git Description --- issue: when resize volume is requested and action is successfuly usage event is not recorded. Code is not present for recording the resize volume usage event. fix: Added the code to record the usage event when the resize volume is requested. Diffs - server/src/com/cloud/storage/VolumeManagerImpl.java a3802a9 Diff: https://reviews.apache.org/r/12997/diff/ Testing --- Environment: kvm, with cluster scope storage pool. default centos instance. 1. created a volume and tried to resize the volume. volume resize is successful usage event is registered in usage_event table now. | 0 | NULL | | 27 | VOLUME.RESIZE | 2 | 2013-07-27 14:54:51 | 1 | 21 | TestVol | 6 | NULL | 5368709120 | NULL | 0 | NULL | ++-++-+-+-+--+-+-+-++---+--+ Thanks, Rajesh Battala
Re: Review Request 12996: Unable to Resize Volume (kvm, vmware)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12996/#review24034 --- Review 12996 PASSED the build test The url of build cloudstack-master-with-patch #61 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/61/ - Jenkins Cloudstack.org On July 27, 2013, 3:05 p.m., Rajesh Battala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12996/ --- (Updated July 27, 2013, 3:05 p.m.) Review request for cloudstack, Devdeep Singh, edison su, Min Chen, and Ram Ganesh. Bugs: 3877 Repository: cloudstack-git Description --- Issue: = this issue is with the way we extract the hypevisor type from the sql mysql SELECT s.hypervisor, c.hypervisor_type from volumes v, storage_pool s, cluster c where v.pool_id = s.id and s.cluster_id = c.id and v.id = 21; ++-+ | hypervisor | hypervisor_type | ++-+ | NULL | KVM | ++-+ first column value will be not null if the storage pool is Zone wide else it will be NULL. but in the code always first column is considering to figure out the hypervisor type which causing the hpervisor type to be NONE and hence failing to resize the volume this issue is happening while determining the hypervisor type for a volume. for ZWPS, it will return the hypervisor because, in storage pool we store the hypervisor type if the pool is added of scoe ZONE. if the pool is of scope Cluster hypervisor type will be NULL we support volume resize when the volume is present on ZONE scope and Cluster scope. they way of hypervisor type extraction from the sql query result should be change which will resolve this blocker. Fix: = depending on the scope type of storage pool, the sql result is passed to determined the hypervisor type. Diffs - engine/schema/src/com/cloud/storage/dao/VolumeDaoImpl.java 7696bcc Diff: https://reviews.apache.org/r/12996/diff/ Testing --- 1. Able to resize the volume successfully Thanks, Rajesh Battala
Re: Review Request 13001: Automation: Adding test cases for CPU limits from Limit Resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review24039 --- Review 13001 PASSED the build test The url of build cloudstack-master-with-patch #62 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/62/ - Jenkins Cloudstack.org On July 27, 2013, 7:49 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/ --- (Updated July 27, 2013, 7:49 p.m.) Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. Repository: cloudstack-git Description --- Adding test cases for CPU limits from Limit Resources. Marvin changes have to be picked up from Memory Limits patch (https://reviews.apache.org/r/11626/). Those are not included in this patch. Diffs - test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION Diff: https://reviews.apache.org/r/13001/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 13003: Adding packaging support for RHEL 5 and 6.2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13003/#review24047 --- Review 13003 PASSED the build test The url of build cloudstack-master-with-patch #63 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/63/ - Jenkins Cloudstack.org On July 28, 2013, 1:14 a.m., Rayees Namathponnan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13003/ --- (Updated July 28, 2013, 1:14 a.m.) Review request for cloudstack, edison su, Frank Zhang, Hugo Trippaers, and Wido den Hollander. Repository: cloudstack-git Description --- There are hard coded values for python version in cloud.spec; it need to be generic to support RHEL 5, since RHEL 5 having Python 2.4 not 2.6 Packaging.sh updated to support RHEL 6.2 and 5, RPM build failing rhel6.2 and 5, since -D_topdir pointing to /usr/src/redhat/SOURCES; fixed this also Diffs - packaging/centos63/cloud.spec 61e00bd packaging/centos63/package.sh c466f58 Diff: https://reviews.apache.org/r/13003/diff/ Testing --- Tested with RHEL 6.3 and RHEL 5.4 Thanks, Rayees Namathponnan
Re: Review Request 12961: CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12961/#review23916 --- Review 12961 PASSED the build test The url of build cloudstack-master-with-patch #43 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/43/ - Jenkins Cloudstack.org On July 26, 2013, 6:30 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12961/ --- (Updated July 26, 2013, 6:30 a.m.) Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOUDSTACK-3723 Repository: cloudstack-git Description --- CLOUDSTACK-3723: System VM Template for XenServer has wrong guest OS type Information on the Database. This commit also contains the guestOS addition of new CentOS releases supported by XenServer 6.2 Diffs - setup/db/templates.sql 313a68d Diff: https://reviews.apache.org/r/12961/diff/ Testing --- Verified by setting up the CS environment and also user VM deploys successfully. Thanks, Sanjay Tripathi
Re: Review Request 12962: CLOUDSTACK-3594: Fix params of AffinityGroup.delete API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12962/#review23919 --- Review 12962 PASSED the build test The url of build cloudstack-master-with-patch #44 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/44/ - Jenkins Cloudstack.org On July 26, 2013, 7:42 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12962/ --- (Updated July 26, 2013, 7:42 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- CLOUDSTACK-3594: Fix params of AffinityGroup.delete API Diffs - test/integration/component/test_affinity_groups.py 3f257c3 Diff: https://reviews.apache.org/r/12962/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12963: Fix some simple typos in ConfigurationManager
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12963/#review23927 --- Review 12963 PASSED the build test The url of build cloudstack-master-with-patch #45 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/45/ - Jenkins Cloudstack.org On July 26, 2013, 9:07 a.m., Thomas O'Dowd wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12963/ --- (Updated July 26, 2013, 9:07 a.m.) Review request for cloudstack. Repository: cloudstack-git Description --- Simple text only fixes to update some typos I noticed in log messages when testing 4.2. Diffs - server/src/com/cloud/configuration/ConfigurationManagerImpl.java 6c32c55 Diff: https://reviews.apache.org/r/12963/diff/ Testing --- Although this patch is against master, I cherry picked it locally to test against 4.2 and did a clean compile. I was able to see the updated message for in stead but I didn't check the other messages. Thanks, Thomas O'Dowd
Re: Review Request 12965: CLOUDSTACK-3780: G11N: JA: Garbled code display on Pod configuration Host configuration pages during Add zone.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12965/#review23938 --- Review 12965 failed the build test : FAILURE The url of build cloudstack-master-with-patch #46 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/46/ - Jenkins Cloudstack.org On July 26, 2013, 10:03 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12965/ --- (Updated July 26, 2013, 10:03 a.m.) Review request for cloudstack and Devdeep Singh. Bugs: CLOUDSTACK-3780 Repository: cloudstack-git Description --- G11N: JA: Garbled code display on Pod configuration Host configuration pages during Add zone Repro Steps 1. Open the browser and login to Web Portal. 2. Navigate the ?Infrastructure? tab. 3. Click ?Zones-view all? button. 4. Click ?Add zone? button. 5. Check ?Basic?. then click ?Next? button. 6. Finish the configuration step by step. 7. Observe the all the UIs. Diffs - client/WEB-INF/classes/resources/messages_ja.properties dc44b0e Diff: https://reviews.apache.org/r/12965/diff/ Testing --- Tested the fix by following the steps in the description. Thanks, Sanjay Tripathi
Re: Review Request 11626: Automation: Memory limits tests from Resource Limits Tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/#review23945 --- Review 11626 PASSED the build test The url of build cloudstack-master-with-patch #47 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/47/ - Jenkins Cloudstack.org On July 26, 2013, 11:27 a.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11626/ --- (Updated July 26, 2013, 11:27 a.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too. Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1modificationDate=1366952352000 Diffs - test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION test/integration/component/memory_limits/test_project_limits.py PRE-CREATION tools/marvin/marvin/integration/lib/base.py 8d9a25d tools/marvin/marvin/integration/lib/common.py 4f5acef Diff: https://reviews.apache.org/r/11626/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 12967: Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12967/#review23946 --- Review 12967 PASSED the build test The url of build cloudstack-master-with-patch #48 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/48/ - Jenkins Cloudstack.org On July 26, 2013, 11:59 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12967/ --- (Updated July 26, 2013, 11:59 a.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Bugs: Cloudstack-1695 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1695 Not enough cpu avialable in cluster according to new overcommit ratio but all stopped Vms can be started without any failure(required cpu for stopped vm is available cpu ) Diffs - server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/12967/diff/ Testing --- Tested on old master. This happened because we were not recalculating the used and the reserved capacities based on the new overcommit ratio. Now used and reserved capacities of all the hosts in a overcommited cluster will be recalculated on overcommit change by the capacity checker. However this will happen only when capacity checker runs meaning the change in capacities due to updated overcommit values will not be instantaneous. Thanks, bharat kumar
Re: Review Request 12966: overcommited memory is not getting displayed at zone level and used % is based on actual memory
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12966/#review23947 --- Review 12966 PASSED the build test The url of build cloudstack-master-with-patch #49 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/49/ - Jenkins Cloudstack.org On July 26, 2013, 11:43 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12966/ --- (Updated July 26, 2013, 11:43 a.m.) Review request for cloudstack, Kishan Kavala and Nitin Mehta. Bugs: Cloudstack-1640 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-1640 overcommited memory is not getting displayed at zone level and used % is based on actual memory Diffs - server/src/com/cloud/capacity/CapacityManagerImpl.java 05a47dd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 1fb118f Diff: https://reviews.apache.org/r/12966/diff/ Testing --- Tested on older master. deployed vms and checked the capacites displayed on the dashboard. Thanks, bharat kumar
Re: Review Request 12968: CLOUDSTACK-3686: Registering a template does not generate a usage event.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review23948 --- Review 12968 PASSED the build test The url of build cloudstack-master-with-patch #50 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/50/ - Jenkins Cloudstack.org On July 26, 2013, 12:42 p.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/ --- (Updated July 26, 2013, 12:42 p.m.) Review request for cloudstack and Min Chen. Bugs: 3686 Repository: cloudstack-git Description --- Registering a template does not generate a usage event. The process should generate a usage event when the template is 100% downloaded. Added a new usage event that has virtual_size also as a parameter. Diffs - engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade Diff: https://reviews.apache.org/r/12968/diff/ Testing --- Now usage_event table is getting updated with the new usage_event. select * from usage_event where id = 23; ++-++-+-+-+---+-+-+--+---+---+--+ | id | type| account_id | created | zone_id | resource_id | resource_name | offering_id | template_id | size | resource_type | processed | virtual_size | ++-++-+-+-+---+-+-+--+---+---+--+ | 23 | TEMPLATE.CREATE | 2 | 2013-07-26 12:04:29 | 0 | 215 | r8|NULL |NULL | 1628 | NULL | 0 | 16777216 | ++-++-+-+-+---+-+-+--+---+---+--+ Build passed. Patch applies cleanly. Thanks, Saksham Srivastava
Re: Review Request 12969: Complete LDAP user provisioning UI.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12969/#review23949 --- Review 12969 failed the build test : FAILURE The url of build cloudstack-master-with-patch #51 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/51/ - Jenkins Cloudstack.org On July 26, 2013, 1:52 p.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12969/ --- (Updated July 26, 2013, 1:52 p.m.) Review request for cloudstack, Abhinandan Prateek, Pranav Saxena, and Sebastien Goasguen. Repository: cloudstack-git Description --- Completes the task for adding LDAP user provisioning UI features. This inlcudes: Add accounts - add account Table of user accounts within LDAP appears. Admin selects user and can add. An admin has the ability to select multiple users. This add screen will only appear when ldap is enabled. Diffs - plugins/user-authenticators/ldap/test/resources/cloudstack.org.ldif b20de81 ui/css/cloudstack3.css 93658db ui/index.jsp 813dbcb ui/scripts/accounts.js e3e28e4 ui/scripts/accountsWizard.js a350085 ui/scripts/sharedFunctions.js 6c1b009 ui/scripts/ui-custom/accountsWizard.js 4037788 Diff: https://reviews.apache.org/r/12969/diff/ Testing --- All testing was done manually Create a single account when ldap is enabled. create multiple accounts when ldap is enabled. create a single account when ldap is disabled. Thanks, Ian Duffy
Re: Review Request 12972: Update CitrixResourceBase to use new vmdata programming method
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/#review23958 --- Review 12972 PASSED the build test The url of build cloudstack-master-with-patch #52 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/52/ - Jenkins Cloudstack.org On July 26, 2013, 5:16 p.m., Marcus Sorensen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/ --- (Updated July 26, 2013, 5:16 p.m.) Review request for cloudstack, Prasanna Santhanam and Sheng Yang. Bugs: CLOUDSTACK-3163 Repository: cloudstack-git Description --- Update CitrixResourceBase to use new vmdata programming method, removing dozens of ssh/scp calls on router and vm startup. This will get rid of vm_data.sh. Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7f8bb3e Diff: https://reviews.apache.org/r/12972/diff/ Testing --- None, please test. Thanks, Marcus Sorensen
Re: Review Request 12976: Remove duplicate row from guest_os table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/#review23964 --- Review 12976 PASSED the build test The url of build cloudstack-master-with-patch #53 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/53/ - Jenkins Cloudstack.org On July 26, 2013, 6:22 p.m., Amogh Vasekar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12976/ --- (Updated July 26, 2013, 6:22 p.m.) Review request for cloudstack, Alena Prokharchyk and Venkata Siva Vijayendra Bhamidipati. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3647 Repository: cloudstack-git Description --- Remove duplicate row (id=206) from table guest_os. Decided to remove instead of checking for duplicates on insertion since : 1. The new row is referenced by id=166 elsewhere in the DB 2. Old row with id=206 is not referenced in DB Diffs - setup/db/db/schema-410to420.sql 82ca403 Diff: https://reviews.apache.org/r/12976/diff/ Testing --- Local environment Thanks, Amogh Vasekar
Re: Review Request 12747: Fix configuration of Jetty-based execution so that CloudStack can execute scripts properly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12747/#review23980 --- Review 12747 PASSED the build test The url of build cloudstack-master-with-patch #54 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/54/ - Jenkins Cloudstack.org On July 18, 2013, 9:34 p.m., Donal Lafferty wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12747/ --- (Updated July 18, 2013, 9:34 p.m.) Review request for cloudstack, Chip Childers, Devdeep Singh, and Hugo Trippaers. Bugs: CLOUDSTACK-3650 Repository: cloudstack-git Description --- CloudStack scripts fail when running on Jetty because the executable flag is not set on their permissions. Diffs - client/pom.xml 32ab94a3cc80d1136d962cad6493461f1d366e29 Diff: https://reviews.apache.org/r/12747/diff/ Testing --- Deployed sample XenServer cloud, verified that error message no longer appears. Inspected file system as well. Thanks, Donal Lafferty
Re: Review Request 12660: Replaced multiple grep/awk/head commands by one awk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12660/#review23982 --- Review 12660 failed the build test : FAILURE The url of build cloudstack-master-with-patch #55 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/55/ - Jenkins Cloudstack.org On July 18, 2013, 3:57 p.m., Rene Diepstraten wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12660/ --- (Updated July 18, 2013, 3:57 p.m.) Review request for cloudstack and Wido den Hollander. Repository: cloudstack-git Description --- Replaced multiple grep/awk/head commands by one awk. Diffs - scripts/vm/network/security_group.py c1c87da Diff: https://reviews.apache.org/r/12660/diff/ Testing --- Tested output. Not able to test using cloudstack function execute() or real ebtables output. Thanks, Rene Diepstraten
Re: Review Request 12658: Corrected typos in log messages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12658/#review23983 --- Review 12658 failed the build test : FAILURE The url of build cloudstack-master-with-patch #56 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/56/ - Jenkins Cloudstack.org On July 18, 2013, 4:07 p.m., Rene Diepstraten wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12658/ --- (Updated July 18, 2013, 4:07 p.m.) Review request for cloudstack and Wido den Hollander. Repository: cloudstack-git Description --- Corrected typos in log messages Diffs - scripts/vm/network/security_group.py 044747a Diff: https://reviews.apache.org/r/12658/diff/ Testing --- These are only log messages and should not change how the code works. Thanks, Rene Diepstraten
Re: Review Request 12985: CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in KVM
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12985/#review24003 --- Review 12985 PASSED the build test The url of build cloudstack-master-with-patch #57 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/57/ - Jenkins Cloudstack.org On July 27, 2013, 12:25 a.m., Toshiaki Hatano wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12985/ --- (Updated July 27, 2013, 12:25 a.m.) Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali Reddy, Hugo Trippaers, and Sheng Yang. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3682 Repository: cloudstack-git Description --- CloudStack-management suddenly start generating broadcastUri in 'vlan:' style instead of 'vlan://' style. That cause issue in KVM-agent VifDrivers (both Bridge and OVS), since they cannot purse different style Uri. For the compatibility to older version, CloudStack-management should generate 'vlan://' style BroadcastUri. Change the URI creation way in 2 method below to make sure they generate 'scheme://host' style BroadcastUri. - com.cloud.network.Networks.IsolationType.toUri(T) - com.cloud.network.Networks.BroadcastDomainType.toUri(T) Diffs - api/src/com/cloud/network/Networks.java c76c3d4 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java 195cf40 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java 7038d7e server/src/com/cloud/network/guru/PublicNetworkGuru.java 8beb42e Diff: https://reviews.apache.org/r/12985/diff/ Testing --- Tested locally, advanced zone with a KVM hypervisor. Thanks, Toshiaki Hatano
Re: Review Request 12934: Tests for egress firewall rules for advance zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/#review23828 --- Review 12934 PASSED the build test The url of build cloudstack-master-with-patch #33 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/33/ - Jenkins Cloudstack.org On July 25, 2013, 4:39 a.m., Ashutosh Kelkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12934/ --- (Updated July 25, 2013, 4:39 a.m.) Review request for cloudstack, Girish Shilamkar, Jayapal Reddy, and Prasanna Santhanam. Repository: cloudstack-git Description --- Tests for egress firewall rules for advance zone. Diffs - test/integration/component/test_egress_fw_rules.py PRE-CREATION Diff: https://reviews.apache.org/r/12934/diff/ Testing --- Thanks, Ashutosh Kelkar
Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12759/#review23830 --- Review 12759 PASSED the build test The url of build cloudstack-master-with-patch #34 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/34/ - Jenkins Cloudstack.org On July 25, 2013, 6:05 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12759/ --- (Updated July 25, 2013, 6:05 a.m.) Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. Bugs: CLOUDSTACK-3669 Repository: cloudstack-git Description --- CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer. Diffs - core/src/com/cloud/agent/api/ScaleVmCommand.java 83cdcac plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 0fba0d9 server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 33dadf0 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d Diff: https://reviews.apache.org/r/12759/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12937: CLOUDSTACK-3779: Support System vm scaling on VMWare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/#review23831 --- Review 12937 failed the build test : FAILURE The url of build cloudstack-master-with-patch #35 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/35/ - Jenkins Cloudstack.org On July 25, 2013, 6:04 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12937/ --- (Updated July 25, 2013, 6:04 a.m.) Review request for cloudstack and Nitin Mehta. Bugs: CLOUDSTACK-3779 Repository: cloudstack-git Description --- CLOUDSTACK-3779: Support System vm scaling on VMWare Marked the system template new system template as dynamicallyScalable - handled upgrade case - moved dynamicallyScalable flag to vm_instance table from user_vm_details to support dynamic scaling of system vm This patch depends on previous review request https://reviews.apache.org/r/12759/ . please review and commit accordingly Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java d4b7b6d engine/schema/src/com/cloud/vm/VMInstanceVO.java e1d2892 engine/schema/src/com/cloud/vm/dao/UserVmDao.java b4f9991 engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java 1c11563 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 2cc592d server/src/com/cloud/hypervisor/HypervisorGuruBase.java 34584ab server/src/com/cloud/vm/UserVmManagerImpl.java ae12523 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44a703d setup/db/db/schema-410to420.sql 664e9b0 Diff: https://reviews.apache.org/r/12937/diff/ Testing --- Thanks, Harikrishna Patnala
Re: Review Request 12913: Fix map based APIs in CloudMonkey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12913/#review23832 --- Review 12913 failed the build test : UNSTABLE The url of build cloudstack-master-with-patch #36 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/36/ - Jenkins Cloudstack.org On July 25, 2013, 4:52 a.m., Carson Anderson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12913/ --- (Updated July 25, 2013, 4:52 a.m.) Review request for cloudstack and Rohit Yadav. Bugs: CLOUDSTACK-3787 Repository: cloudstack-git Description --- CM does not detect required tags if they are passed as a map. When creating resource tags for example. The tags[0].key and tags[0].value weren't counted for the tags parameter and CM would give a missing required parameter error. Diffs - tools/cli/cloudmonkey/cloudmonkey.py 13f54ad Diff: https://reviews.apache.org/r/12913/diff/ Testing --- Tested by adding/removing resourceTags Thanks, Carson Anderson
Re: Review Request 12941: [GSoC] refactor gre controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/#review23833 --- Review 12941 failed the build test : FAILURE The url of build cloudstack-master-with-patch #37 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/37/ - Jenkins Cloudstack.org On July 25, 2013, 9:05 a.m., tuna wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/ --- (Updated July 25, 2013, 9:05 a.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I made an update to refactor gre controller: + remove ovs_devices table, because we'll have an ODL plugin separately. + move command/answer to new package: com.cloud.agent.api + add Connectivity service checking + add new NetworkProvider: Ovs + add L3 services to Ovs Capabilities + add L3 services prototype code. Next step: + L3 services implement with VirtualRouter + ODL plugin Diffs - api/src/com/cloud/network/Network.java a06208b client/tomcatconf/applicationContext.xml.in 60f1e30 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521 plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2 plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324 plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52 plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac plugins/network-elements/ovs/src/com/cloud
Re: Review Request 12942: CLOUDSTACK-3454: Fix test_portable_publicip
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12942/#review23838 --- Review 12942 failed the build test : UNSTABLE The url of build cloudstack-master-with-patch #38 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/38/ - Jenkins Cloudstack.org On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12942/ --- (Updated July 25, 2013, 12:50 p.m.) Review request for cloudstack, Murali Reddy and Prasanna Santhanam. Bugs: CLOUDSTACK-3454 Repository: cloudstack-git Description --- Added isportable param to associateIP API. Fixed base class for PortableIP tio call portableip APIs. Removed test_createPortablePublicIPAcquire from basic zone run requires additional network creation handling which can be done in component tests. Diffs - test/integration/smoke/test_portable_publicip.py 9a3a398 tools/marvin/marvin/integration/lib/base.py 0f6fdc5 Diff: https://reviews.apache.org/r/12942/diff/ Testing --- Yes, but disassociating ip address fails. Maybe a product defect, yet to investigate. Thanks, Girish Shilamkar
Re: Review Request 12943: Replaced virsh() by python-libvirt functions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12943/#review23844 --- Review 12943 PASSED the build test The url of build cloudstack-master-with-patch #39 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/39/ - Jenkins Cloudstack.org On July 25, 2013, 2:01 p.m., Rene Diepstraten wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12943/ --- (Updated July 25, 2013, 2:01 p.m.) Review request for cloudstack and Wido den Hollander. Repository: cloudstack-git Description --- In scripts/vm/network/security_group.py, external calls to virsh are made. Python has a module python-libvirt which has native libvirt bindings. This patch replaces the external calls to the virsh command with functions that use the native python implementation. Diffs - debian/control 46dd505 packaging/centos63/cloud.spec 61e00bd scripts/vm/network/security_group.py 2ce558f Diff: https://reviews.apache.org/r/12943/diff/ Testing --- Tested the output of the new functions. This should be the same as the virsh command. Thanks, Rene Diepstraten
Re: Review Request 12948: Affinity Groups: Adding new test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12948/#review23856 --- Review 12948 PASSED the build test The url of build cloudstack-master-with-patch #40 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/40/ - Jenkins Cloudstack.org On July 25, 2013, 3:32 p.m., Gaurav Aradhye wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12948/ --- (Updated July 25, 2013, 3:32 p.m.) Review request for cloudstack and Prasanna Santhanam. Repository: cloudstack-git Description --- Adding new test cases for affinity groups Diffs - test/integration/component/test_affinity_groups.py 3f257c3 Diff: https://reviews.apache.org/r/12948/diff/ Testing --- Thanks, Gaurav Aradhye
Re: Review Request 12958: Automation test failure: can't attach volume to a stopped created VM. Fix the null pointer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12958/#review23895 --- Review 12958 failed the build test : FAILURE The url of build cloudstack-master-with-patch #41 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/41/ - Jenkins Cloudstack.org On July 25, 2013, 11:15 p.m., Fang Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12958/ --- (Updated July 25, 2013, 11:15 p.m.) Review request for cloudstack and edison su. Bugs: CLOUDSTACK-3759 Repository: cloudstack-git Description --- When the new VM is created and put in stopped state, the volume and pool is not allocated. Hence the NPE. Diffs - server/src/com/cloud/storage/VolumeManagerImpl.java d7d62b0 Diff: https://reviews.apache.org/r/12958/diff/ Testing --- Thanks, Fang Wang
Re: Review Request 12905: Multiple VLAN range API need to accept a list rather than add or remove per command
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/#review23911 --- Review 12905 failed the build test : FAILURE The url of build cloudstack-master-with-patch #42 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/42/ - Jenkins Cloudstack.org On July 26, 2013, 4:17 a.m., bharat kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12905/ --- (Updated July 26, 2013, 4:17 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Bugs: Cloudstack-3753 Repository: cloudstack-git Description --- https://issues.apache.org/jira/browse/CLOUDSTACK-3753 Multiple VLAN range API need to accept a list rather than add or remove per command Diffs - api/src/com/cloud/network/NetworkService.java 59ccdbf api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 333564e engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java e2e6b79 engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java ced2982 server/src/com/cloud/network/NetworkServiceImpl.java f1f71ca server/test/com/cloud/network/MockNetworkManagerImpl.java 4577d0a server/test/com/cloud/network/UpdatePhysicalNetworkTest.java e3fc36a server/test/com/cloud/vpc/MockNetworkManagerImpl.java fd61bc6 Diff: https://reviews.apache.org/r/12905/diff/ Testing --- Tested on master. removed the removevlan parameter. vlan parameter can be used for both addition and removal of valns. instead of passing only a vlan range. user has to pass all the vlan ranges that he wants to keep. the vlan ranges missing in the input and present in the db (not allocated) will be removed. Thanks, bharat kumar
Re: Review Request 12896: General clean up of ldapplugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/#review23746 --- Review 12896 failed the build test : FAILURE The url of build cloudstack-master-with-patch #29 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/29/ - Jenkins Cloudstack.org On July 24, 2013, 10:26 a.m., Ian Duffy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12896/ --- (Updated July 24, 2013, 10:26 a.m.) Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. Repository: cloudstack-git Description --- Cleans up LDAP plugin based on feedback from sonar. Diffs - plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapAddConfigurationCmd.java 62736b16087561a7e25893cd46115795100c609e plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapDeleteConfigurationCmd.java 329b91b plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListAllUsersCmd.java 087d156 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java 6707878 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapUserSearchCmd.java e6a40d0 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java d583346 plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapUserResponse.java 40ba0ce plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java 2916202 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java 8f31ce5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfigurationVO.java d3ff820 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapContextFactory.java 30bdc5b plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java be9b3d5 plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManager.java 54802cf plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUtils.java 453dc0a plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationSpec.groovy 91c9baf plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapConfigurationVO.groovy 8135901 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapDeleteConfigurationCmdSpec.groovy 664fd64 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapListConfigurationCmdSpec.groovy a7c1979 plugins/user-authenticators/ldap/test/groovy/org/apache/cloudstack/ldap/LdapSearchUserCmdSpec.groovy d72878b Diff: https://reviews.apache.org/r/12896/diff/ Testing --- Complied... passed unit tests. Passed integration tests. Thanks, Ian Duffy
Re: Review Request 12897: CLOUDSTACK-3594: Fix regression in Affinity Groups tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/#review23754 --- Review 12897 PASSED the build test The url of build cloudstack-master-with-patch #30 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/30/ - Jenkins Cloudstack.org On July 24, 2013, 10:51 a.m., Girish Shilamkar wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12897/ --- (Updated July 24, 2013, 10:51 a.m.) Review request for cloudstack and Prasanna Santhanam. Bugs: CLOUDSTACK-3594 Repository: cloudstack-git Description --- One of the patches introduced a regression where account and domainid parameters were changed. Therefore Affinity Groups for those accounts were not found and tests failed. Diffs - tools/marvin/marvin/integration/lib/base.py 6e49ae5 Diff: https://reviews.apache.org/r/12897/diff/ Testing --- Thanks, Girish Shilamkar
Re: Review Request 12898: CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/#review23762 --- Review 12898 PASSED the build test The url of build cloudstack-master-with-patch #32 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/32/ - Jenkins Cloudstack.org On July 24, 2013, 12:10 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12898/ --- (Updated July 24, 2013, 12:10 p.m.) Review request for cloudstack, Abhinandan Prateek and Devdeep Singh. Bugs: CLOUDSTACK-3544 Repository: cloudstack-git Description --- CLOUDSTACK-3544: Xen 6.2 hosts are tagged with Xen 6.1. This commit will add the new xenserverresource file to support XenServer 6.2. Also add the guest OS list supported by xenserver 6.2 Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java bbb077c plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java c557631 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java PRE-CREATION Diff: https://reviews.apache.org/r/12898/diff/ Testing --- Tests: 1. Setup a CS using Xenserver 6.2 host. 2. Deploy a user VM. Verified that userVM deployed successfully. Thanks, Sanjay Tripathi
Re: Review Request 12838: CLOUDSTACK-3488: listStoragePools throws NPE if any of the storage pools are not in the right state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12838/#review23680 --- Review 12838 PASSED the build test The url of build cloudstack-master-with-patch #19 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/19/ - Jenkins Cloudstack.org On July 23, 2013, 5:30 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12838/ --- (Updated July 23, 2013, 5:30 a.m.) Review request for cloudstack and Devdeep Singh. Bugs: CLOUDSTACK-3488 Repository: cloudstack-git Description --- CLOUDSTACK-3488: listStoragePools throws NPE if any of the storage pools are not in the right state. This issue is reporducible if user adds a primary storage and quickly fires listStoragePool API command without waiting for the responce of previous createStoragePool API command. So during this period (before receiving createStoragePool API resonce), the primary srorage is in initialized status and the scope of storage is not set. Diffs - server/src/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java 503a563 Diff: https://reviews.apache.org/r/12838/diff/ Testing --- Tests: 1. Add a primary storage. 2. Quickly fire listStoragePool API command. Verified that listStoragePool API command is working properly without hitting any NPE. Thanks, Sanjay Tripathi
Re: Review Request 12849: added backwards compatibility code to Networks enums
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review23683 --- Review 12849 PASSED the build test The url of build cloudstack-master-with-patch #20 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/20/ - Jenkins Cloudstack.org On July 23, 2013, 10:02 a.m., daan Hoogland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated July 23, 2013, 10:02 a.m.) Review request for cloudstack and Koushik Das. Repository: cloudstack-git Description --- Both BroadcastDomainType and IsolationType needed some extra code for backwards compatibility Diffs - api/src/com/cloud/network/Networks.java c76c3d4 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 6fafa3e Diff: https://reviews.apache.org/r/12849/diff/ Testing --- Thanks, daan Hoogland
Re: Review Request 12852: CLOUDSTACK-2508: Template usage should report both physical and virtual sizes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/#review23684 --- Review 12852 PASSED the build test The url of build cloudstack-master-with-patch #21 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/21/ - Jenkins Cloudstack.org On July 23, 2013, 11:18 a.m., Saksham Srivastava wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12852/ --- (Updated July 23, 2013, 11:18 a.m.) Review request for cloudstack and Kishan Kavala. Bugs: 2508 Repository: cloudstack-git Description --- Usage entries for template and iso should include virtual_size parameter. Added new column to usage_event table which contains the virtual size. Modified the usage event creation when a template is created. Diffs - api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 4b355cb api/src/org/apache/cloudstack/usage/Usage.java c74d3b7 engine/schema/src/com/cloud/event/UsageEventVO.java c92972b engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 004ab7c engine/schema/src/com/cloud/usage/UsageStorageVO.java 1337edc engine/schema/src/com/cloud/usage/UsageVO.java 18a3a6b engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 2237d56 engine/schema/src/com/cloud/usage/dao/UsageStorageDaoImpl.java 297c8f4 server/src/com/cloud/api/ApiResponseHelper.java e058105 server/src/com/cloud/event/UsageEventUtils.java 2d92fae server/src/com/cloud/template/TemplateManagerImpl.java 5005ee0 usage/src/com/cloud/usage/UsageManagerImpl.java 4901dd9 usage/src/com/cloud/usage/parser/StorageUsageParser.java 337e8e2 Diff: https://reviews.apache.org/r/12852/diff/ Testing --- Usage event generated for creating template with virtual size. Thanks, Saksham Srivastava
Re: Review Request 12853: CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12853/#review23685 --- Review 12853 PASSED the build test The url of build cloudstack-master-with-patch #22 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/22/ - Jenkins Cloudstack.org On July 23, 2013, 11:06 a.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12853/ --- (Updated July 23, 2013, 11:06 a.m.) Review request for cloudstack, Devdeep Singh and Prasanna Santhanam. Bugs: CLOUDSTACK-3688 Repository: cloudstack-git Description --- CLOUDSTACK-3688: Test cases test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the domain to delete and failed. This issue is in CS product and not in the test_script. The problem is coming because in case of deleteDomain with cleanup = true, CS is not allowing deletion of domain if there are any account under that domain needs clean up; though these accounts are removed and admin can't see them in the listaccounts. So CS should not restrict the deleteDomain in case of accounts needs cleanup. Diffs - server/src/com/cloud/user/DomainManagerImpl.java 1117ff0 test/integration/component/test_accounts.py 3c284bd Diff: https://reviews.apache.org/r/12853/diff/ Testing --- Verified marvin test on my local cloudstack setup. Thanks, Sanjay Tripathi
Re: Review Request 12854: CLOUDSTACK-3727: Resource Count calculation happens for deleted accounts on restart of managment server.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12854/#review23691 --- Review 12854 PASSED the build test The url of build cloudstack-master-with-patch #23 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/23/ - Jenkins Cloudstack.org On July 23, 2013, 12:54 p.m., Sanjay Tripathi wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12854/ --- (Updated July 23, 2013, 12:54 p.m.) Review request for cloudstack and Devdeep Singh. Bugs: CLOUDSTACK-3727 Repository: cloudstack-git Description --- CLOUDSTACK-3727: Resource Count calculation happens for deleted accounts on restart of managment server. The method is listing all the accounts/domains including the removed ones which causes unnecessary insertion of the entries in the resource_count table. Diffs - server/src/com/cloud/server/ConfigurationServerImpl.java 9a9b145 Diff: https://reviews.apache.org/r/12854/diff/ Testing --- Verified that during the startup/restart of MS, resourcetype insertion for removed accounts is not happening. Thanks, Sanjay Tripathi
