Re: Compiling 4.11.2.0 from source with test failure
Same error for me. Did you found the cause of this test error? On Tue, Feb 12, 2019 at 7:06 PM Yiping Zhang wrote: > > > Hi, all: > > > > I am trying to compile CloudStack from the source using 4.11.2.0 branch. > The build fails with one test failure in NioTest.java. How can I fix this > error? > > > > > > 2019-02-12 11:07:47,541 INFO [utils.testcase.NioTest] (main:) Clients > stopped. > > 2019-02-12 11:07:47,541 INFO [utils.testcase.NioTest] (main:) Server > stopped. > > Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 60.106 sec > <<< FAILURE! - in com.cloud.utils.testcase.NioTest > > testConnection(com.cloud.utils.testcase.NioTest) Time elapsed: 60.103 > sec <<< ERROR! > > org.junit.runners.model.TestTimedOutException: test timed out after 6 > milliseconds > > at java.lang.Thread.sleep(Native Method) > > at > com.cloud.utils.testcase.NioTest.testConnection(NioTest.java:145) > > > > > > (skip lots of output here) > > > > > > Results : > > > > Tests in error: > > NioTest.testConnection:145 ? TestTimedOut test timed out after 6 > milliseco... > > > > Tests run: 300, Failures: 0, Errors: 1, Skipped: 1 > > > Thanks, > > Yiping > -- Olivier Lemasle Ingénieur Logiciel *Apalia*™ Mobile: +33-611-69-12-11 *http://www.apalia.net <http://www.apalia.net> olivier.lema...@apalia.net *
Re: Review Request 23150: CLOUDSTACK-7006: Restore template ID in ROOT volume usages
> On juin 30, 2014, 3:11 après-midi, Sebastien Goasguen wrote: > > I applied it to 4.3, I will give Kishan a bit of time to see it and apply > > to master and 4.4 (probably 4.4.1 since we are cutting the RC now). Hi, Is it now possible to apply this patch on branches 4.4 and master? - Olivier --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23150/#review46975 --- On juin 30, 2014, 10:53 matin, Olivier Lemasle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23150/ > --- > > (Updated juin 30, 2014, 10:53 matin) > > > Review request for cloudstack, Kishan Kavala and Sebastien Goasguen. > > > Bugs: CLOUDSTACK-7006 > https://issues.apache.org/jira/browse/CLOUDSTACK-7006 > > > Repository: cloudstack-git > > > Description > --- > > This patch restore the template ID in usages, for ROOT volume created from a > template (see CLOUDSTACK-7006). > > The regression was on the class com.cloud.storage.VolumeManagerImpl (module > "cloud-server") but it has been renamed > org.apache.cloudstack.engine.orchestration.VolumeOrchestrator (module > "cloud-engine-orchestration"). > > The patch applies on branchs master and branch 4.4. > I've attached another patch for branch 4.3 (the only difference is > formatting). > > > Diffs > - > > > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java > 9ba3451 > > Diff: https://reviews.apache.org/r/23150/diff/ > > > Testing > --- > > Tested in ACS 4.3. > 1. Deploy a new VM from a template. > 2. Check if usages for the ROOT volume has the right templateId. > 3. Deploy a new VM from an ISO, and add a DATA volume. > 4. Check that there is no regression for these two types of volume usages > without templateId. > > > File Attachments > ---- > > patch version for ACS 4.3 > > https://reviews.apache.org/media/uploaded/files/2014/06/29/eee8a901-4141-46e7-b4ce-d9cbcfd8c85f__cloudstack-7006-for-ACS4.3.patch > > > Thanks, > > Olivier Lemasle > >
Re: [VOTE] git workflow
+1 on the proposal. Regards, -- Olivier Lemasle Apalia On Thu, Jul 31, 2014 at 5:22 PM, Will Stevens wrote: > +1 > > Something that may need to be adjusted... > > If two different people are working on different hotfixes for 4.4, lets say > they are for bugs CS-1234 and CS-5678, then in the current model they would > both push their hotfix to 'hotfix/4.4.1'. This will cause branch naming > collisions which could be hard to work around. I think we may want to > adopt a hotfix branch name that reflects the bug the hotfix is related to. > So for the above example, the hotfix branches could be named something > like 'hotfix/4.4.1-cs-1234' and 'hotfix/4.4.1-cs-5678'. I don't think that > two different committers work should go into the same 'hotfix/4.4.1' branch > to be committed. I think that will cause way too many issues... > > ws > > > *Will STEVENS* > Lead Developer > > *CloudOps* *| *Cloud Solutions Experts > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 > w cloudops.com *|* tw @CloudOps_ > > > On Thu, Jul 31, 2014 at 11:03 AM, Mike Tutkowski < > mike.tutkow...@solidfire.com> wrote: > > > +1 > > > > On Thursday, July 31, 2014, Hugo Trippaers wrote: > > > > > +1 on the proposal > > > > > > Cheers, > > > > > > Hugo > > > > > > > > > On 31 jul. 2014, at 14:31, Stephen Turner > > > wrote: > > > > > > > +1 from me. > > > > > > > > -- > > > > Stephen Turner > > > > > > > > > > > > -Original Message- > > > > From: Rajani Karuturi [mailto:rajani.karut...@citrix.com > > ] > > > > Sent: 31 July 2014 11:28 > > > > To: dev > > > > Subject: [VOTE] git workflow > > > > > > > > Hi All, > > > > > > > > We had long discussions on the git flow. > > > > I tried to capture the summary of it @ > > > http://markmail.org/message/j5z7dxjcqxfkfhpj > > > > This is updated on wiki @ > > > > > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-ProposedGitflowbasedCheck-inProcess > > > and is up for a vote: > > > > > > > > Can you share your opinion on the proposal? > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > Thanks, > > > > ~Rajani > > > > > > > > > > > > > > > > > > > > > > -- > > *Mike Tutkowski* > > *Senior CloudStack Developer, SolidFire Inc.* > > e: mike.tutkow...@solidfire.com > > o: 303.746.7302 > > Advancing the way the world uses the cloud > > <http://solidfire.com/solution/overview/?video=play>*™* > > > -- Olivier Lemasle Ingénieur Logiciel *Apalia*™ Mobile: +33-611-69-12-11 *http://www.apalia.net <http://www.apalia.net> olivier.lema...@apalia.net *
Re: Review Request 23168: Update cloudstack-usage JAVA_HOME to find JRE for Java 7
> On June 30, 2014, 8:07 p.m., Sebastien Goasguen wrote: > > After the updated review it looks like you are only changing the centOS > > scripts. What about Ubuntu/debs ? is that already fixed ? Yes, I'm only changing the CentOS scripts. I have no Debian server available just now, so I didn't test the .deb packaging, but it seems already fixed for Debian/Ubuntu: In packaging/debian/init/cloud-usage, JDK_DIRS is set to: /usr/lib/jvm/java-7-openjdk-amd64 /usr/lib/jvm/java-7-openjdk-i386 /usr/lib/jvm/java-6-openjdk... This has been set by Wido den Hollander in commit 20070ee07f1718e1eee0f7256e3f1004116cfee8, and it includes common locations for OpenJDK 7 in Debian. - Olivier --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23168/#review47000 --- On June 30, 2014, 5:54 p.m., Olivier Lemasle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23168/ > --- > > (Updated June 30, 2014, 5:54 p.m.) > > > Review request for cloudstack and Sebastien Goasguen. > > > Repository: cloudstack-git > > > Description > --- > > cloudstack-usage is currently configured to search JAVA_HOME only in a small > set of paths corresponding to Java 6 (/usr/lib/jvm/java-6-openjdk, > /usr/lib/jvm/java-6-openjdk-i386, etc). > > If cloudstack-usage is installed on a server with only Java 7, the service > cannot start and fails with the following error: > jsvc error: Cannot locate Java Home > > This commit adds Java 7 paths to the possible set of JAVA_HOME locations. > > > Diffs > - > > packaging/centos63/cloud-usage.rc e78f8c1 > > Diff: https://reviews.apache.org/r/23168/diff/ > > > Testing > --- > > Package CloudStack RPMs for CentOS and install them on a system with > java-1.7.0-openjdk and no Java 6 JRE. > Check that cloudstack-usage works correctly. > > > Thanks, > > Olivier Lemasle > >
Re: Review Request 23168: Update cloudstack-usage JAVA_HOME to find JRE for Java 7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23168/ --- (Updated June 30, 2014, 5:54 p.m.) Review request for cloudstack and Sebastien Goasguen. Repository: cloudstack-git Description --- cloudstack-usage is currently configured to search JAVA_HOME only in a small set of paths corresponding to Java 6 (/usr/lib/jvm/java-6-openjdk, /usr/lib/jvm/java-6-openjdk-i386, etc). If cloudstack-usage is installed on a server with only Java 7, the service cannot start and fails with the following error: jsvc error: Cannot locate Java Home This commit adds Java 7 paths to the possible set of JAVA_HOME locations. Diffs (updated) - packaging/centos63/cloud-usage.rc e78f8c1 Diff: https://reviews.apache.org/r/23168/diff/ Testing (updated) --- Package CloudStack RPMs for CentOS and install them on a system with java-1.7.0-openjdk and no Java 6 JRE. Check that cloudstack-usage works correctly. Thanks, Olivier Lemasle
Review Request 23168: Update cloudstack-usage JAVA_HOME to find JRE for Java 7
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23168/ --- Review request for cloudstack and Sebastien Goasguen. Repository: cloudstack-git Description --- cloudstack-usage is currently configured to search JAVA_HOME only in a small set of paths corresponding to Java 6 (/usr/lib/jvm/java-6-openjdk, /usr/lib/jvm/java-6-openjdk-i386, etc). If cloudstack-usage is installed on a server with only Java 7, the service cannot start and fails with the following error: jsvc error: Cannot locate Java Home This commit adds Java 7 paths to the possible set of JAVA_HOME locations. Diffs - usage/distro/centos/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5 usage/distro/fedora/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5 usage/distro/opensuse/SYSCONFDIR/init.d/cloud-usage.in f968263 usage/distro/rhel/SYSCONFDIR/rc.d/init.d/cloud-usage.in cb5beb5 usage/distro/sles/SYSCONFDIR/init.d/cloud-usage.in f968263 usage/distro/ubuntu/SYSCONFDIR/init.d/cloud-usage.in f968263 Diff: https://reviews.apache.org/r/23168/diff/ Testing --- Thanks, Olivier Lemasle
Review Request 23150: CLOUDSTACK-7006: Restore template ID in ROOT volume usages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23150/ --- Review request for cloudstack, Kishan Kavala and Sebastien Goasguen. Bugs: CLOUDSTACK-7006 https://issues.apache.org/jira/browse/CLOUDSTACK-7006 Repository: cloudstack-git Description --- This patch restore the template ID in usages, for ROOT volume created from a template (see CLOUDSTACK-7006). The regression was on the class com.cloud.storage.VolumeManagerImpl (module "cloud-server") but it has been renamed org.apache.cloudstack.engine.orchestration.VolumeOrchestrator (module "cloud-engine-orchestration"). The patch applies on branchs master and branch 4.4. I've attached another patch for branch 4.3 (the only difference is formatting). Diffs - engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 9ba3451 Diff: https://reviews.apache.org/r/23150/diff/ Testing --- Tested in ACS 4.3. 1. Deploy a new VM from a template. 2. Check if usages for the ROOT volume has the right templateId. 3. Deploy a new VM from an ISO, and add a DATA volume. 4. Check that there is no regression for these two types of volume usages without templateId. File Attachments patch version for ACS 4.3 https://reviews.apache.org/media/uploaded/files/2014/06/29/eee8a901-4141-46e7-b4ce-d9cbcfd8c85f__cloudstack-7006-for-ACS4.3.patch Thanks, Olivier Lemasle
Re: Review Request 22354: CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
> On June 10, 2014, 9:14 a.m., Sebastien Goasguen wrote: > > Ok fine with me, I trust that you will stay on top of this, test and submit > > further fixes. > > > > I applied your patch to master and 4.4-forward. It should be cherry-picked > > to 4.4 > > Nothing done to 4.3. > > > > Thanks. I commit myself to maintain this patch and other usage server features as far as I can. - Olivier --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22354/#review45204 ----------- On June 8, 2014, 6:40 p.m., Olivier Lemasle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22354/ > --- > > (Updated June 8, 2014, 6:40 p.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-6850 > https://issues.apache.org/jira/browse/CLOUDSTACK-6850 > > > Repository: cloudstack-git > > > Description > --- > > This patch updates VMInstanceUsageParser to process usage details (cpu cores, > cpu speed and memory) for dynamic compute offering usages, in order to save > them in table cloud_usage.cloud_usage and return them with the API > (listUsageRecords). > > See CLOUDSTACK-6850. > > A change in database model is required for this patch (three new columns in > cloud_usage.cloud_usage). > > The patch should apply on master and 4.4. > > > Diffs > - > > api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 5e2e85d > api/src/org/apache/cloudstack/usage/Usage.java 20dc189 > engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06d4876 > engine/schema/src/com/cloud/usage/UsageVO.java 67014ef > engine/schema/src/com/cloud/usage/dao/UsageVMInstanceDaoImpl.java b94e12f > server/src/com/cloud/api/ApiResponseHelper.java 119f56d > setup/db/db/schema-430to440.sql d149a65 > usage/src/com/cloud/usage/parser/VMInstanceUsageParser.java ba0d4bf > > Diff: https://reviews.apache.org/r/22354/diff/ > > > Testing > --- > > Packaged in RPMs, installed and manually tested. > > 1. Create a VM with compute offering "Small instance". > 2. Stop the VM. > 3. Change service offering to a custom offering, with cpu_number=1, > cpu_speed=500 MHz, memory=512 MB > 4. Start the VM, wait... Stop the VM. > 6. Change service offering to an other custom offering, with cpu_number=2, > cpu_speed=800 MHz, memory=1024 MB > 7. Start the VM, wait... Stop the VM. > 8. Change service offering to the first custom offering, with same "details" > (cpu_number=2, cpu_speed=800 MHz, memory=1024 MB) > 9. Start the VM, wait... Stop the VM. > 10. Change service offering to "Medium instance". > > Usages and details are reflected in database and in API response. There is no > regression found for other usage types. > Details are returned (and saved in database) only for RUNNING_VM and > ALLOCATED_VM, only if the service offering is a custom one. > > Example of response: > > > admin > 184a6564-edab-11e3-b629-0050569ed71c > fbc7578a-edaa-11e3-b629-0050569ed71c > e5047089-c911-40ea-8251-4a76810ac1e0 > california allocated (ServiceOffering: 12) (Template: > 5) > 0.098078 Hrs > 2 > 0.098078 > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > california > b05b64e9-8e0f-4335-b0e0-acc5bad81938 > fbca2564-edaa-11e3-b629-0050569ed71c > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > XenServer > 1 > 500 > 512 > 2014-06-08'T'17:05:52+02:00 > 2014-06-08'T'17:15:52+02:00 > > > admin > 184a6564-edab-11e3-b629-0050569ed71c > fbc7578a-edaa-11e3-b629-0050569ed71c > e5047089-c911-40ea-8251-4a76810ac1e0 > california allocated (ServiceOffering: 1) (Template: > 5) > 0.068594 Hrs > 2 > 0.068594 > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > california > 84bbf38f-b582-440b-8a8d-20e63e0dbed7 > fbca2564-edaa-11e3-b629-0050569ed71c > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > XenServer > 2014-06-08'T'17:05:52+02:00 > 2014-06-08'T'17:15:52+02:00 > > > > Thanks, > > Olivier Lemasle > >
Re: Review Request 22354: CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
> On June 9, 2014, 9:55 a.m., Sebastien Goasguen wrote: > > Hi, is it a bug or a new feature ? I see that it alters the usage db > > schema, will this affects upgrades ? > > > > The jira entry says that it applies to 4.3 as well, does you patch applies > > to 4.3 ? Hi Sebastien, For me, it's a bug, because a CloudStack feature, usage tracking, is not working properly with dynamic compute offerings. Of course, I might be biased because I work on Amysta development and this bug prevents Amysta from tracking consumption with dynamic compute offerings. But this is a more general issue: there is currently no way to track VM instance usages with dynamic compute offerings using API only. No, the patch is for 4.4 (because I wrote the DB schema changes in schema-430to440.sql It would be great to fix that for ACS 4.3 too, but I'm annoyed with the schema update). Regarding the update process, I tested the patch both with a ACS 4.4 fresh install and with a ACS 4.3 update. There was no regression. Usage details are returned only for usages processed after the update. - Olivier --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22354/#review45061 ------- On June 8, 2014, 6:40 p.m., Olivier Lemasle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22354/ > --- > > (Updated June 8, 2014, 6:40 p.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-6850 > https://issues.apache.org/jira/browse/CLOUDSTACK-6850 > > > Repository: cloudstack-git > > > Description > --- > > This patch updates VMInstanceUsageParser to process usage details (cpu cores, > cpu speed and memory) for dynamic compute offering usages, in order to save > them in table cloud_usage.cloud_usage and return them with the API > (listUsageRecords). > > See CLOUDSTACK-6850. > > A change in database model is required for this patch (three new columns in > cloud_usage.cloud_usage). > > The patch should apply on master and 4.4. > > > Diffs > - > > api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 5e2e85d > api/src/org/apache/cloudstack/usage/Usage.java 20dc189 > engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06d4876 > engine/schema/src/com/cloud/usage/UsageVO.java 67014ef > engine/schema/src/com/cloud/usage/dao/UsageVMInstanceDaoImpl.java b94e12f > server/src/com/cloud/api/ApiResponseHelper.java 119f56d > setup/db/db/schema-430to440.sql d149a65 > usage/src/com/cloud/usage/parser/VMInstanceUsageParser.java ba0d4bf > > Diff: https://reviews.apache.org/r/22354/diff/ > > > Testing > --- > > Packaged in RPMs, installed and manually tested. > > 1. Create a VM with compute offering "Small instance". > 2. Stop the VM. > 3. Change service offering to a custom offering, with cpu_number=1, > cpu_speed=500 MHz, memory=512 MB > 4. Start the VM, wait... Stop the VM. > 6. Change service offering to an other custom offering, with cpu_number=2, > cpu_speed=800 MHz, memory=1024 MB > 7. Start the VM, wait... Stop the VM. > 8. Change service offering to the first custom offering, with same "details" > (cpu_number=2, cpu_speed=800 MHz, memory=1024 MB) > 9. Start the VM, wait... Stop the VM. > 10. Change service offering to "Medium instance". > > Usages and details are reflected in database and in API response. There is no > regression found for other usage types. > Details are returned (and saved in database) only for RUNNING_VM and > ALLOCATED_VM, only if the service offering is a custom one. > > Example of response: > > > admin > 184a6564-edab-11e3-b629-0050569ed71c > fbc7578a-edaa-11e3-b629-0050569ed71c > e5047089-c911-40ea-8251-4a76810ac1e0 > california allocated (ServiceOffering: 12) (Template: > 5) > 0.098078 Hrs > 2 > 0.098078 > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > california > b05b64e9-8e0f-4335-b0e0-acc5bad81938 > fbca2564-edaa-11e3-b629-0050569ed71c > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > XenServer > 1 > 500 > 512 > 2014-06-08'T'17:05:52+02:00 > 2014-06-08'T'17:15:52+02:00 > > > admin > 184a6564-edab-11e3-b629-0050569ed71c > fbc7578a-edaa-11e3-b629-0050569ed71c > e5047089-c911-40ea-8251-4a76810ac1e0 > california allocated (ServiceOffering: 1) (Template: > 5) > 0.068594 Hrs > 2 > 0.068594 > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > california > 84bbf38f-b582-440b-8a8d-20e63e0dbed7 > fbca2564-edaa-11e3-b629-0050569ed71c > e89c22af-65cf-42a2-8905-6f4bbd7d59a1 > XenServer > 2014-06-08'T'17:05:52+02:00 > 2014-06-08'T'17:15:52+02:00 > > > > Thanks, > > Olivier Lemasle > >
Review Request 22354: CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22354/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6850 https://issues.apache.org/jira/browse/CLOUDSTACK-6850 Repository: cloudstack-git Description --- This patch updates VMInstanceUsageParser to process usage details (cpu cores, cpu speed and memory) for dynamic compute offering usages, in order to save them in table cloud_usage.cloud_usage and return them with the API (listUsageRecords). See CLOUDSTACK-6850. A change in database model is required for this patch (three new columns in cloud_usage.cloud_usage). The patch should apply on master and 4.4. Diffs - api/src/org/apache/cloudstack/api/response/UsageRecordResponse.java 5e2e85d api/src/org/apache/cloudstack/usage/Usage.java 20dc189 engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06d4876 engine/schema/src/com/cloud/usage/UsageVO.java 67014ef engine/schema/src/com/cloud/usage/dao/UsageVMInstanceDaoImpl.java b94e12f server/src/com/cloud/api/ApiResponseHelper.java 119f56d setup/db/db/schema-430to440.sql d149a65 usage/src/com/cloud/usage/parser/VMInstanceUsageParser.java ba0d4bf Diff: https://reviews.apache.org/r/22354/diff/ Testing --- Packaged in RPMs, installed and manually tested. 1. Create a VM with compute offering "Small instance". 2. Stop the VM. 3. Change service offering to a custom offering, with cpu_number=1, cpu_speed=500 MHz, memory=512 MB 4. Start the VM, wait... Stop the VM. 6. Change service offering to an other custom offering, with cpu_number=2, cpu_speed=800 MHz, memory=1024 MB 7. Start the VM, wait... Stop the VM. 8. Change service offering to the first custom offering, with same "details" (cpu_number=2, cpu_speed=800 MHz, memory=1024 MB) 9. Start the VM, wait... Stop the VM. 10. Change service offering to "Medium instance". Usages and details are reflected in database and in API response. There is no regression found for other usage types. Details are returned (and saved in database) only for RUNNING_VM and ALLOCATED_VM, only if the service offering is a custom one. Example of response: admin 184a6564-edab-11e3-b629-0050569ed71c fbc7578a-edaa-11e3-b629-0050569ed71c e5047089-c911-40ea-8251-4a76810ac1e0 california allocated (ServiceOffering: 12) (Template: 5) 0.098078 Hrs 2 0.098078 e89c22af-65cf-42a2-8905-6f4bbd7d59a1 california b05b64e9-8e0f-4335-b0e0-acc5bad81938 fbca2564-edaa-11e3-b629-0050569ed71c e89c22af-65cf-42a2-8905-6f4bbd7d59a1 XenServer 1 500 512 2014-06-08'T'17:05:52+02:00 2014-06-08'T'17:15:52+02:00 admin 184a6564-edab-11e3-b629-0050569ed71c fbc7578a-edaa-11e3-b629-0050569ed71c e5047089-c911-40ea-8251-4a76810ac1e0 california allocated (ServiceOffering: 1) (Template: 5) 0.068594 Hrs 2 0.068594 e89c22af-65cf-42a2-8905-6f4bbd7d59a1 california 84bbf38f-b582-440b-8a8d-20e63e0dbed7 fbca2564-edaa-11e3-b629-0050569ed71c e89c22af-65cf-42a2-8905-6f4bbd7d59a1 XenServer 2014-06-08'T'17:05:52+02:00 2014-06-08'T'17:15:52+02:00 Thanks, Olivier Lemasle
Re: Review Request 22339: CLOUDSTACK-6669: Fix support resize in usage server
> On June 7, 2014, 10:39 a.m., Sebastien Goasguen wrote: > > Which branch should this be applied to ? I've tested it in branch 4.4. It should work on master (because commit bdde5335f99 was applied on master and 4.4) - Olivier --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22339/#review45003 --- On June 7, 2014, 10:26 a.m., Olivier Lemasle wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22339/ > --- > > (Updated June 7, 2014, 10:26 a.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-6669 > https://issues.apache.org/jira/browse/CLOUDSTACK-6669 > > > Repository: cloudstack-git > > > Description > --- > > This patch fixes the remaining bug in the initial fix for CLOUDSTACK-6669. > See my example here: > https://issues.apache.org/jira/browse/CLOUDSTACK-6669?focusedCommentId=14020334 > > > Diffs > - > > usage/src/com/cloud/usage/parser/VolumeUsageParser.java cd092a9 > > Diff: https://reviews.apache.org/r/22339/diff/ > > > Testing > --- > > 1. Create a DATA volume with "Custom Disk", size 1GB > 2. Resize it to "Custom Disk", size 3GB > 3. Resize it to "Custom Disk", size 20GB > 4. Change disk offering to "Medium Disk, 20GB" > 5. Check cloud_usage database: > > mysql> select * from usage_volume where id = 9; > ++-++---+--+-+-+-+-+ > | id | zone_id | account_id | domain_id | disk_offering_id | template_id | > size| created | deleted | > ++-++---+--+-+-+-+-+ > | 9 | 1 | 2 | 1 |6 |NULL | > 1073741824 | 2014-06-07 07:00:01 | 2014-06-07 07:02:54 | > | 9 | 1 | 2 | 1 |6 |NULL | > 3221225472 | 2014-06-07 07:02:54 | 2014-06-07 07:26:40 | > | 9 | 1 | 2 | 1 |6 |NULL | > 21474836480 | 2014-06-07 07:26:40 | 2014-06-07 07:29:49 | > | 9 | 1 | 2 | 1 |4 |NULL | > 21474836480 | 2014-06-07 07:29:49 | NULL| > ++-++---+--+-+-+-+-+ > > and: > > mysql> select description, raw_usage, offering_id, size, start_date, end_date > from cloud_usage where usage_id=9 and usage_type = 6; > +---++-+-+-+-+ > | description | raw_usage | > offering_id | size| start_date | end_date| > +---++-+-+-+-+ > | Volume Id: 9 usage time (DiskOffering: 6) | 0.0480558350682259 | > 6 | 1073741824 | 2014-06-07 06:55:00 | 2014-06-07 07:05:00 | > | Volume Id: 9 usage time (DiskOffering: 6) | 0.0350027792155743 | > 6 | 3221225472 | 2014-06-07 06:55:00 | 2014-06-07 07:05:00 | > | Volume Id: 9 usage time (DiskOffering: 6) | 0.16939854622 | > 6 | 3221225472 | 2014-06-07 07:05:00 | 2014-06-07 07:15:00 | > | Volume Id: 9 usage time (DiskOffering: 6) | 0.1667163372 | > 6 | 3221225472 | 2014-06-07 07:15:00 | 2014-06-07 07:25:00 | > | Volume Id: 9 usage time (DiskOffering: 6) | 0.0277749989181757 | > 6 | 3221225472 | 2014-06-07 07:25:00 | 2014-06-07 07:35:00 | > | Volume Id: 9 usage time (DiskOffering: 6) | 0.052500281482935 | > 6 | 21474836480 | 2014-06-07 07:25:00 | 2014-06-07 07:35:00 | > | Volume Id: 9 usage time (DiskOffering: 4) | 0.0863919407129288 | > 4 | 21474836480 | 2014-06-07 07:25:00 | 2014-06-07 07:35:00 | > +---++-+-+-+-+ > > We can see that usage records are duplicated when a volume has multiple sizes > or multiple disk offerings on a given time range. Previously, usage records > were aggregated, and size and offering_id were the values at the end of the > period (see example > https://issues.apache.org/jira/browse/CLOUDSTACK-6669?focusedCommentId=14020334) > > > Thanks, > > Olivier Lemasle > >
Review Request 22339: CLOUDSTACK-6669: Fix support resize in usage server
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22339/ --- Review request for cloudstack and Kishan Kavala. Bugs: CLOUDSTACK-6669 https://issues.apache.org/jira/browse/CLOUDSTACK-6669 Repository: cloudstack-git Description --- This patch fixes the remaining bug in the initial fix for CLOUDSTACK-6669. See my example here: https://issues.apache.org/jira/browse/CLOUDSTACK-6669?focusedCommentId=14020334 Diffs - usage/src/com/cloud/usage/parser/VolumeUsageParser.java cd092a9 Diff: https://reviews.apache.org/r/22339/diff/ Testing --- 1. Create a DATA volume with "Custom Disk", size 1GB 2. Resize it to "Custom Disk", size 3GB 3. Resize it to "Custom Disk", size 20GB 4. Change disk offering to "Medium Disk, 20GB" 5. Check cloud_usage database: mysql> select * from usage_volume where id = 9; ++-++---+--+-+-+-+-+ | id | zone_id | account_id | domain_id | disk_offering_id | template_id | size | created | deleted | ++-++---+--+-+-+-+-+ | 9 | 1 | 2 | 1 |6 |NULL | 1073741824 | 2014-06-07 07:00:01 | 2014-06-07 07:02:54 | | 9 | 1 | 2 | 1 |6 |NULL | 3221225472 | 2014-06-07 07:02:54 | 2014-06-07 07:26:40 | | 9 | 1 | 2 | 1 |6 |NULL | 21474836480 | 2014-06-07 07:26:40 | 2014-06-07 07:29:49 | | 9 | 1 | 2 | 1 |4 |NULL | 21474836480 | 2014-06-07 07:29:49 | NULL| ++-++---+--+-+-+-+-+ and: mysql> select description, raw_usage, offering_id, size, start_date, end_date from cloud_usage where usage_id=9 and usage_type = 6; +---++-+-+-+-+ | description | raw_usage | offering_id | size| start_date | end_date| +---++-+-+-+-+ | Volume Id: 9 usage time (DiskOffering: 6) | 0.0480558350682259 | 6 | 1073741824 | 2014-06-07 06:55:00 | 2014-06-07 07:05:00 | | Volume Id: 9 usage time (DiskOffering: 6) | 0.0350027792155743 | 6 | 3221225472 | 2014-06-07 06:55:00 | 2014-06-07 07:05:00 | | Volume Id: 9 usage time (DiskOffering: 6) | 0.16939854622 | 6 | 3221225472 | 2014-06-07 07:05:00 | 2014-06-07 07:15:00 | | Volume Id: 9 usage time (DiskOffering: 6) | 0.1667163372 | 6 | 3221225472 | 2014-06-07 07:15:00 | 2014-06-07 07:25:00 | | Volume Id: 9 usage time (DiskOffering: 6) | 0.0277749989181757 | 6 | 3221225472 | 2014-06-07 07:25:00 | 2014-06-07 07:35:00 | | Volume Id: 9 usage time (DiskOffering: 6) | 0.052500281482935 | 6 | 21474836480 | 2014-06-07 07:25:00 | 2014-06-07 07:35:00 | | Volume Id: 9 usage time (DiskOffering: 4) | 0.0863919407129288 | 4 | 21474836480 | 2014-06-07 07:25:00 | 2014-06-07 07:35:00 | +---++-+-+-+-+ We can see that usage records are duplicated when a volume has multiple sizes or multiple disk offerings on a given time range. Previously, usage records were aggregated, and size and offering_id were the values at the end of the period (see example https://issues.apache.org/jira/browse/CLOUDSTACK-6669?focusedCommentId=14020334) Thanks, Olivier Lemasle
Re: Cpu, cpu speed and memory in usage records
Thanks Sebastien. On Thu, Jun 5, 2014 at 9:21 PM, sebgoa wrote: > > On Jun 5, 2014, at 9:20 PM, sebgoa wrote: > > > > > On Jun 5, 2014, at 1:29 PM, Olivier Lemasle > wrote: > > > >> Hi, > >> > >> Thanks Harikrishna for your answer. I created a ticket for this > >> (CLOUDSTACK-6880 [1]). > >> I can submit a review request for this issue, but I cannot assign the > issue > >> to myself on Jira. > > > > What's your jira id ? > > Never mind, I found you and added you to jira, you should be able to > assign the ticket now. > > thanks > > > > >> > >> -- > >> Olivier > >> > >> [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6850 > >> > >> > >> On Wed, Jun 4, 2014 at 10:55 AM, Harikrishna Patnala < > >> harikrishna.patn...@citrix.com> wrote: > >> > >>> Hi, > >>> We are recording the cpu and ram values in usage_vm_instance table > while > >>> parsing the usage events. These details needs to be populated in > >>> cloud_usage table as well. Please feel free to file a ticket for this. > >>> > >>> Thanks > >>> Harikrishna > >>> *From:* Olivier Lemasle [olivier.lema...@apalia.net] > >>> *Sent:* Tuesday, June 03, 2014 8:54 PM > >>> *To:* dev@cloudstack.apache.org > >>> *Cc:* Harikrishna Patnala; Kishan Kavala > >>> *Subject:* Cpu, cpu speed and memory in usage records > >>> > >>> Hi, > >>> > >>> Is it normal if CloudStack does not return usage details (cpu cores, > cpu > >>> speed and memory) in the usage records? > >>> > >>> Since the introduction of dynamic compute offerings, these details are > >>> recorded in table cloud_usage.usage_vm_instance, but they are not in > table > >>> cloud_usage.cloud_usage, and they aren't returned by the > "listUsageRecords" > >>> API command. > >>> > >>> So, what was the purpose of these details in cloud_usage > >>> (CLOUDSTACK-4737, CLOUDSTACK-5515, CLOUDSTACK-6466)? It seems they're > saved > >>> in database but never read. Am I wrong? > >>> > >>> Thanks, > >>> > >>> -- > >>> Olivier Lemasle > >>> Software Engineer > >>> *Apalia*™ > >>> Mobile: +33-611-69-12-11 > >>> > >>> *http://www.apalia.net <http://www.apalia.net> > >>> olivier.lema...@apalia.net > >>> * > >>> > > > > -- Olivier Lemasle Ingénieur Logiciel *Apalia*™ Mobile: +33-611-69-12-11 *http://www.apalia.net <http://www.apalia.net> olivier.lema...@apalia.net *
Re: Cpu, cpu speed and memory in usage records
Hi, Thanks Harikrishna for your answer. I created a ticket for this (CLOUDSTACK-6880 [1]). I can submit a review request for this issue, but I cannot assign the issue to myself on Jira. -- Olivier [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6850 On Wed, Jun 4, 2014 at 10:55 AM, Harikrishna Patnala < harikrishna.patn...@citrix.com> wrote: > Hi, > We are recording the cpu and ram values in usage_vm_instance table while > parsing the usage events. These details needs to be populated in > cloud_usage table as well. Please feel free to file a ticket for this. > > Thanks > Harikrishna > *From:* Olivier Lemasle [olivier.lema...@apalia.net] > *Sent:* Tuesday, June 03, 2014 8:54 PM > *To:* dev@cloudstack.apache.org > *Cc:* Harikrishna Patnala; Kishan Kavala > *Subject:* Cpu, cpu speed and memory in usage records > > Hi, > > Is it normal if CloudStack does not return usage details (cpu cores, cpu > speed and memory) in the usage records? > > Since the introduction of dynamic compute offerings, these details are > recorded in table cloud_usage.usage_vm_instance, but they are not in table > cloud_usage.cloud_usage, and they aren't returned by the "listUsageRecords" > API command. > > So, what was the purpose of these details in cloud_usage > (CLOUDSTACK-4737, CLOUDSTACK-5515, CLOUDSTACK-6466)? It seems they're saved > in database but never read. Am I wrong? > > Thanks, > > -- > Olivier Lemasle > Software Engineer > *Apalia*™ > Mobile: +33-611-69-12-11 > > *http://www.apalia.net <http://www.apalia.net> > olivier.lema...@apalia.net > * >
Cpu, cpu speed and memory in usage records
Hi, Is it normal if CloudStack does not return usage details (cpu cores, cpu speed and memory) in the usage records? Since the introduction of dynamic compute offerings, these details are recorded in table cloud_usage.usage_vm_instance, but they are not in table cloud_usage.cloud_usage, and they aren't returned by the "listUsageRecords" API command. So, what was the purpose of these details in cloud_usage (CLOUDSTACK-4737, CLOUDSTACK-5515, CLOUDSTACK-6466)? It seems they're saved in database but never read. Am I wrong? Thanks, -- Olivier Lemasle Software Engineer *Apalia*™ Mobile: +33-611-69-12-11 *http://www.apalia.net <http://www.apalia.net> olivier.lema...@apalia.net *
Re: Review Request 20557: CLOUDSTACK-6472 listUsageRecords generates NPEs for expunging instances
gt; > > > > > > > --- > > > > > This is an automatically generated e-mail. To reply, visit: > > > > > https://reviews.apache.org/r/20557/ > > > > > --- > > > > > > > > > > (Updated April 23, 2014, 12:47 p.m.) > > > > > > > > > > > > > > > Review request for cloudstack. > > > > > > > > > > > > > > > Bugs: CLOUDSTACK-6472 > > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-6472 > > > > > > > > > > > > > > > Repository: cloudstack-git > > > > > > > > > > > > > > > Description > > > > > --- > > > > > > > > > > This is a review request for CLOUDSTACK-6472 "listUsageRecords > > generates > > > > NPEs for expunging instances" > > > > > > > > > > The patch is against the 4.3 branch > > > > > > > > > > > > > > > Diffs > > > > > - > > > > > > > > > > server/src/com/cloud/api/ApiResponseHelper.java e543d1c > > > > > > > > > > Diff: https://reviews.apache.org/r/20557/diff/ > > > > > > > > > > > > > > > Testing > > > > > --- > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > Pierre-Yves Ritschard > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > *Nate Gordon*Director of Technology | Appcore - the business of cloud > > > computing® > > > > > > Office +1.800.735.7104 | Direct +1.515.612.7787 > > > nate.gor...@appcore.com | www.appcore.com > > > > > > -- > > > > > > The information in this message is intended for the named recipients > > only. > > > It may contain information that is privileged, confidential or > otherwise > > > protected from disclosure. If you are not the intended recipient, you > are > > > hereby notified that any disclosure, copying, distribution, or the > taking > > > of any action in reliance on the contents of this message is strictly > > > prohibited. If you have received this e-mail in error, do not print it > or > > > disseminate it or its contents. In such event, please notify the sender > > by > > > return e-mail and delete the e-mail file immediately thereafter. Thank > > you. > > > > > > > > -- Olivier Lemasle Ingénieur Logiciel *Apalia*™ Mobile: +33-611-69-12-11 *http://www.apalia.net <http://www.apalia.net> olivier.lema...@apalia.net *
Re: Wrong dates for network bytes sent/received usages
Hi, Now that CloudStack 4.2.1 is released, could you please have a look to my review request, in order to apply the patch to CLOUDSTACK-5404 in branch 4.3 and master? Please let me know if you have concerns/questions about it. Regards, -- Olivier Lemasle Apalia On Wed, Dec 11, 2013 at 4:39 PM, Wei ZHOU wrote: > I will have a look. > > > 2013/12/11 Olivier Lemasle > > > Hi, > > > > There is currently a bug in network usages in CS 4.2+: usage records for > > network bytes sent/received are saved in database in local time whereas > all > > other usage records are saved in GMT (see issue CLOUDSTACK-5404 [1]). > > > > I've written simple patches for branchs 4.2 / 4.3 and for master. Can > > someone review them, please [2] ? > > > > Regards, > > > > [1] https://issues.apache.org/jira/browse/CLOUDSTACK-5404 > > [2] https://reviews.apache.org/r/16126/ > > > > -- > > Olivier Lemasle > > Software Engineer > > *Apalia*™ > > Mobile: +33-611-69-12-11 > > > > *http://www.apalia.net <http://www.apalia.net> > > olivier.lema...@apalia.net > > * > >
Wrong dates for network bytes sent/received usages
Hi, There is currently a bug in network usages in CS 4.2+: usage records for network bytes sent/received are saved in database in local time whereas all other usage records are saved in GMT (see issue CLOUDSTACK-5404 [1]). I've written simple patches for branchs 4.2 / 4.3 and for master. Can someone review them, please [2] ? Regards, [1] https://issues.apache.org/jira/browse/CLOUDSTACK-5404 [2] https://reviews.apache.org/r/16126/ -- Olivier Lemasle Software Engineer *Apalia*™ Mobile: +33-611-69-12-11 *http://www.apalia.net <http://www.apalia.net> olivier.lema...@apalia.net *
Re: Review Request 16126: CLOUDSTACK-5404: Fix timezone bug in network usages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16126/ --- (Updated Dec. 10, 2013, 10:14 p.m.) Review request for cloudstack, Kishan Kavala and Wei Zhou. Changes --- New patch for master Bugs: CLOUDSTACK-5404 https://issues.apache.org/jira/browse/CLOUDSTACK-5404 Repository: cloudstack-git Description (updated) --- Fix CLOUDSTACK-5404, which was causing a timezone issue: network usages (network bytes sent/received) are in local time, whereas other usages (instances, volumes, network offerings, etc.) are in GMT. More details on Jira (CLOUDSTACK-5404). The patch applies for branchs 4.2 and 4.3. I've attached an other patch for master. Diffs - engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 8b79257 Diff: https://reviews.apache.org/r/16126/diff/ Testing --- I packaged the patch version in RPMs (branch 4.2), installed it, and the bug is fixed. No regression found. File Attachments (updated) patch-for-master https://reviews.apache.org/media/uploaded/files/2013/12/10/e44c83a5-a78f-41e2-9abe-5560e29b5a80__CLOUDSTACK-5404-master.patch Thanks, Olivier Lemasle
Re: Review Request 16126: CLOUDSTACK-5404: Fix timezone bug in network usages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16126/ --- (Updated Dec. 9, 2013, 2:11 p.m.) Review request for cloudstack, Kishan Kavala and Wei Zhou. Bugs: CLOUDSTACK-5404 https://issues.apache.org/jira/browse/CLOUDSTACK-5404 Repository: cloudstack-git Description --- Fix CLOUDSTACK-5404, which was causing a timezone issue: network usages (network bytes sent/received) are in local time, whereas other usages (instances, volumes, network offerings, etc.) are in GMT. More details on Jira (CLOUDSTACK-5404). I did the patch on branch 4.2 where I encountered the bug, but it should be applied on master and 4.3. Diffs - engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 8b79257 Diff: https://reviews.apache.org/r/16126/diff/ Testing (updated) --- I packaged the patch version in RPMs (branch 4.2), installed it, and the bug is fixed. No regression found. Thanks, Olivier Lemasle
Review Request 16126: CLOUDSTACK-5404: Fix timezone bug in network usages
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16126/ --- Review request for cloudstack, Kishan Kavala and Wei Zhou. Bugs: CLOUDSTACK-5404 https://issues.apache.org/jira/browse/CLOUDSTACK-5404 Repository: cloudstack-git Description --- Fix CLOUDSTACK-5404, which was causing a timezone issue: network usages (network bytes sent/received) are in local time, whereas other usages (instances, volumes, network offerings, etc.) are in GMT. More details on Jira (CLOUDSTACK-5404). I did the patch on branch 4.2 where I encountered the bug, but it should be applied on master and 4.3. Diffs - engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java 8b79257 Diff: https://reviews.apache.org/r/16126/diff/ Testing --- I packaged the patch version in RPMs, installed it, and the bug is fixed. No regression found. Thanks, Olivier Lemasle
