Re: SNAT iptable entry on VirtualRouter
Hi Sheng,
Thanks. We are using XenServer 6.2 SP1. After adding debug in the code, I
see that addVif never gets called in my case.
That's why nic deviceId is zero. Code falls thru the case where vif is already
present.If I dump correctVif.getDevice(conn)
it returns zero.
Does this command handler also gets called when Public-ip is associated with
VM's private ip (StaticNAT) ?
Do we create a new interface in DomainRouter when staticNAT entry is created?
Thanks,
Sachin
From: Sheng Yang sh...@yasker.orgmailto:sh...@yasker.org
Date: Friday, June 6, 2014 4:12 PM
To: dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org
dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org, Sachchidanand
Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net
Subject: Re: SNAT iptable entry on VirtualRouter
Hi Sachin,
The nicDevId() you see is coming from
prepareNetworkElementCommand(IpAssocCommand cmd) in CitrixResourceBase in case
of Xen.
You would see this:
if (addVif) {
// Add a new VIF to DomR
String vifDeviceNum = getLowestAvailableVIFDeviceNum(conn,
router);
if (vifDeviceNum == null) {
throw new InternalErrorException(There were no more
available slots for a new VIF on router: + router.getNameLabel(conn));
}
nic.setDeviceId(Integer.valueOf(vifDeviceNum));
correctVif = createVif(conn, routerName, router, null, nic);
correctVif.plug(conn);
// Add iptables rule for network usage
networkUsage(conn, routerIp, addVif, eth +
correctVif.getDevice(conn));
}
And nic.setDeviceId() should set the public nic id(which should be 2 in your
case) to it.
And what's the XenServer version you're using? Could you help to debug it
further more? Sadly we cannot reproduce it in our lab...
Thanks!
--Sheng
On Fri, Jun 6, 2014 at 12:29 AM, Sachchidanand Vaidya
vaidy...@juniper.netmailto:vaidy...@juniper.net wrote:
Hi,
I'm seeing the same issue with 4.4 code. After further debug, I see
that CS mgmt server is sending
following command to XenHost,
xensource.log: script /opt/cloud/bin/ipassoc.sh -A -s -f -l
10.84.59.131/24http://10.84.59.131/24 -c eth0 -g 10.84.59.254 /script
VirtualRouter's public interface is eth2. Also as per dump of VIF list on
XenHost, deviceid for public interface
of domainRouter is 2.
As part of VirtualRoutingResource.java:generateConfig(), CS mgmt server
generates this command.
It generates publicNic = eth + ip.getNicDevId()?
Which deviceId does it refer to? Shouldn't it be the deviceid as per the
XenHost dump?
Does anyone have input on what could he happening here ?
Thanks,
Sachin
Hi,
I have an isolated network (192.168.3.x/24) being served by
VirtualRouter, where 10.84.59.131 is SourceNAT address
and eth0 is VN interface of VirtualRouter eth2 is the public interface
of VirtualRouter.
When I look at the nat table entries on the VirtualRouter, it shows
following :
root@r-6-VM:~# iptables -L -t nat -n -v
..
..
Chain POSTROUTING (policy ACCEPT 330 packets, 22113 bytes)
pkts bytes target prot opt in out source
destination
0 0 SNAT all -- * eth00.0.0.0/0http://0.0.0.0/0
0.0.0.0/0http://0.0.0.0/0to:10.84.59.131
-- Why the out interface for the SNAT entry is VN interface (eth0)
instead of Public interface (eth2) ?
I'm using Cloudstack Release 4.3.0 (64-bit) Thu Apr 10 20:27:11 UTC
2014 cloudstack-release template.
Thanks,
Sachin
---
root@r-6-VM:~# ifconfig
eth0 Link encap:Ethernet HWaddr 02:13:87:88:e6:dd
inet addr:192.168.3.226 Bcast:192.168.3.255 Mask:255.255.255.0
inet6 addr: fe80::13:87ff:fe88:e6dd/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:350 errors:0 dropped:0 overruns:0 frame:0
TX packets:7 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:29400 (28.7 KiB) TX bytes:602 (602.0 B)
Interrupt:25
eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:02:6b
inet addr:169.254.2.107 Bcast:169.254.255.255 Mask:255.255.0.0
inet6 addr: fe80::c00:a9ff:fefe:26b/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:3293 errors:0 dropped:0 overruns:0 frame:0
TX packets:2934 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:444768 (434.3 KiB) TX bytes:539100 (526.4 KiB)
Interrupt:26
eth2 Link encap:Ethernet HWaddr 06:d5:1c:00:00:0b
inet addr:10.84.59.131 Bcast:10.84.59.255 Mask:255.255.255.0
inet6 addr: fe80::4d5:1cff:fe00:b/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:133 errors:0 dropped:0 overruns:0 frame:0
TX packets:1451 errors:0
Re: SNAT iptable entry on VirtualRouter
Hi, I'm seeing the same issue with 4.4 code. After further debug, I see that CS mgmt server is sending following command to XenHost, xensource.log: script /opt/cloud/bin/ipassoc.sh -A -s -f -l 10.84.59.131/24 -c eth0 -g 10.84.59.254 /script VirtualRouter's public interface is eth2. Also as per dump of VIF list on XenHost, deviceid for public interface of domainRouter is 2. As part of VirtualRoutingResource.java:generateConfig(), CS mgmt server generates this command. It generates publicNic = eth + ip.getNicDevId()? Which deviceId does it refer to? Shouldn't it be the deviceid as per the XenHost dump? Does anyone have input on what could he happening here ? Thanks, Sachin Hi, I have an isolated network (192.168.3.x/24) being served by VirtualRouter, where 10.84.59.131 is SourceNAT address and eth0 is VN interface of VirtualRouter eth2 is the public interface of VirtualRouter. When I look at the nat table entries on the VirtualRouter, it shows following : root@r-6-VM:~# iptables -L -t nat -n -v .. .. Chain POSTROUTING (policy ACCEPT 330 packets, 22113 bytes) pkts bytes target prot opt in out source destination 0 0 SNAT all -- * eth00.0.0.0/0 0.0.0.0/0to:10.84.59.131 -- Why the out interface for the SNAT entry is VN interface (eth0) instead of Public interface (eth2) ? I'm using Cloudstack Release 4.3.0 (64-bit) Thu Apr 10 20:27:11 UTC 2014 cloudstack-release template. Thanks, Sachin --- root@r-6-VM:~# ifconfig eth0 Link encap:Ethernet HWaddr 02:13:87:88:e6:dd inet addr:192.168.3.226 Bcast:192.168.3.255 Mask:255.255.255.0 inet6 addr: fe80::13:87ff:fe88:e6dd/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:350 errors:0 dropped:0 overruns:0 frame:0 TX packets:7 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:29400 (28.7 KiB) TX bytes:602 (602.0 B) Interrupt:25 eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:02:6b inet addr:169.254.2.107 Bcast:169.254.255.255 Mask:255.255.0.0 inet6 addr: fe80::c00:a9ff:fefe:26b/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:3293 errors:0 dropped:0 overruns:0 frame:0 TX packets:2934 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:444768 (434.3 KiB) TX bytes:539100 (526.4 KiB) Interrupt:26 eth2 Link encap:Ethernet HWaddr 06:d5:1c:00:00:0b inet addr:10.84.59.131 Bcast:10.84.59.255 Mask:255.255.255.0 inet6 addr: fe80::4d5:1cff:fe00:b/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:133 errors:0 dropped:0 overruns:0 frame:0 TX packets:1451 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:4636 (4.5 KiB) TX bytes:113282 (110.6 KiB) Interrupt:27
Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/ --- (Updated May 7, 2014, 3:44 p.m.) Review request for cloudstack and Rajesh Battala. Changes --- Fixed licenser header and created new EventTypes for serviceInstance VM create and delete. Thanks, Sachin Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence and re-creation during Mgmt server reboot. Diffs (updated) - api/src/com/cloud/event/EventTypes.java 075b1c8 client/tomcatconf/commands.properties.in d3a24f6 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya
SNAT iptable entry on VirtualRouter
Hi, I have an isolated network (192.168.3.x/24) being served by VirtualRouter, where 10.84.59.131 is SourceNAT address and eth0 is VN interface of VirtualRouter eth2 is the public interface of VirtualRouter. When I look at the nat table entries on the VirtualRouter, it shows following : root@r-6-VM:~# iptables -L -t nat -n -v .. .. Chain POSTROUTING (policy ACCEPT 330 packets, 22113 bytes) pkts bytes target prot opt in out source destination 0 0 SNAT all -- * eth00.0.0.0/00.0.0.0/0 to:10.84.59.131 -- Why the out interface for the SNAT entry is VN interface (eth0) instead of Public interface (eth2) ? I'm using Cloudstack Release 4.3.0 (64-bit) Thu Apr 10 20:27:11 UTC 2014 cloudstack-release template. Thanks, Sachin --- root@r-6-VM:~# ifconfig eth0 Link encap:Ethernet HWaddr 02:13:87:88:e6:dd inet addr:192.168.3.226 Bcast:192.168.3.255 Mask:255.255.255.0 inet6 addr: fe80::13:87ff:fe88:e6dd/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:350 errors:0 dropped:0 overruns:0 frame:0 TX packets:7 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:29400 (28.7 KiB) TX bytes:602 (602.0 B) Interrupt:25 eth1 Link encap:Ethernet HWaddr 0e:00:a9:fe:02:6b inet addr:169.254.2.107 Bcast:169.254.255.255 Mask:255.255.0.0 inet6 addr: fe80::c00:a9ff:fefe:26b/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:3293 errors:0 dropped:0 overruns:0 frame:0 TX packets:2934 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:444768 (434.3 KiB) TX bytes:539100 (526.4 KiB) Interrupt:26 eth2 Link encap:Ethernet HWaddr 06:d5:1c:00:00:0b inet addr:10.84.59.131 Bcast:10.84.59.255 Mask:255.255.255.0 inet6 addr: fe80::4d5:1cff:fe00:b/64 Scope:Link UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:133 errors:0 dropped:0 overruns:0 frame:0 TX packets:1451 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:4636 (4.5 KiB) TX bytes:113282 (110.6 KiB) Interrupt:27
Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/ --- (Updated May 8, 2014, 10:36 p.m.) Review request for cloudstack and Rajesh Battala. Changes --- Updated code based on review comment - check added for template, formatting fixed. Repository: cloudstack-git Description --- - Added new Network Service Provider JuniperContrailvSRX. - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider. vSRX element currently supports only sourceNAT. It will be enhanced later to support more features. - Changes to service-instance creation code to use left virtual-network's SourceNAT addr as an interface address on vSRX instance's Public-network interface. Diffs (updated) - api/src/com/cloud/network/Network.java ef3bcdf plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml 99ab02e plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java 49060f1 Diff: https://reviews.apache.org/r/19758/diff/ Testing --- Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Thanks, Sachchidanand Vaidya
Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
Hi Rajesh, My comments inline marked [SACHIN]. Thanks, Sachin From: Rajesh Battala rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com Reply-To: Rajesh Battala rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com Date: Tuesday, May 6, 2014 12:33 AM To: Rajesh Battala rajesh.batt...@citrix.commailto:rajesh.batt...@citrix.com Cc: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net, cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality. This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/ plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.javahttps://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line1(Diff revision 1) 1 // Licensed to the Apache Software Foundation (ASF) under one As this is a new file content. please run rat build to verify the license [SACHIN] No issues with rat build found. plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.javahttps://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line3(Diff revision 1) 3 // distributed with this work for additional information Are there any UnitTests available to test this element? any marvin tests are available? [SACHIN] There are none currently. Will look at adding few. plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.javahttps://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line126(Diff revision 1) 126 ServiceOfferingVO vsrx_compute_offering = null; systemvm service offering can be used or seed required offering and use it. [SACHIN] Systemvm offering can't be used as vSRX needs larger memory footprint. plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.javahttps://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line140(Diff revision 1) 140 VMTemplateVO tmplt = _tmpltDao.findByTemplateName(Juniper vSRX); how this template will be seeded? user will upload this template? [SACHIN] User needs to upload vSRX images as they are not freely distributed. plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.javahttps://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line141(Diff revision 1) 141 VirtualMachineTemplate template = _entityMgr.findById(VirtualMachineTemplate.class, tmplt.getId()); what if there are multiple Juniper vSRX templates are available? findBytemplateName method will not search on uniquename it will search on template name and template name can be same for other templates also. this should be documented that uploaded template name should be with Juniper vSRx otherwise even user uploads it, code wont be able to find it. which hypervisor template is supported? [SACHIN] Currently only Xen Hypervisor template is supported. I will add a check for it. Also I agree with your comment on unique name vs name. I will change the code to check for unique name and send you code for review. plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.javahttps://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line206(Diff revision 1) 206 @Override missed formatting [SACHIN] Will take care. - Rajesh Battala On May 3rd, 2014, 7:30 a.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack and Rajesh Battala. By Sachchidanand Vaidya. Updated May 3, 2014, 7:30 a.m. Repository: cloudstack-git Description - Added new Network Service Provider JuniperContrailvSRX. - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider. vSRX element currently supports only sourceNAT. It will be enhanced later to support more features. - Changes to service-instance creation code to use left virtual-network's SourceNAT addr as an interface address on vSRX instance's Public-network interface. Testing Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Diffs * api/src/com/cloud/network/Network.java (ef3bcdf) * plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml (99ab02e) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java (PRE-CREATION) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java (f34eacc) * plugins/network-elements/juniper
Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
On May 6, 2014, 12:33 a.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java, line 1 https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line1 As this is a new file content. please run rat build to verify the license Fixed. On May 6, 2014, 12:33 a.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java, line 3 https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line3 Are there any UnitTests available to test this element? any marvin tests are available? No unit tests. Will add it later. On May 6, 2014, 12:33 a.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java, line 126 https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line126 systemvm service offering can be used or seed required offering and use it. systemvm offering can't be used. vSRX needs bigger memory foorprint. On May 6, 2014, 12:33 a.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java, line 140 https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line140 how this template will be seeded? user will upload this template? Use will upload this template. On May 6, 2014, 12:33 a.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java, line 141 https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line141 what if there are multiple Juniper vSRX templates are available? findBytemplateName method will not search on uniquename it will search on template name and template name can be same for other templates also. this should be documented that uploaded template name should be with Juniper vSRx otherwise even user uploads it, code wont be able to find it. which hypervisor template is supported? Currently we have image for XenServer only. Also there will be single vSRX template for now. I have added check for hypervisor type and status of the template. On May 6, 2014, 12:33 a.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java, line 206 https://reviews.apache.org/r/19758/diff/1/?file=539139#file539139line206 missed formatting fixed. - Sachchidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/#review42255 --- On May 8, 2014, 10:36 p.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/ --- (Updated May 8, 2014, 10:36 p.m.) Review request for cloudstack and Rajesh Battala. Repository: cloudstack-git Description --- - Added new Network Service Provider JuniperContrailvSRX. - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider. vSRX element currently supports only sourceNAT. It will be enhanced later to support more features. - Changes to service-instance creation code to use left virtual-network's SourceNAT addr as an interface address on vSRX instance's Public-network interface. Diffs - api/src/com/cloud/network/Network.java ef3bcdf plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml 99ab02e plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java 49060f1 Diff: https://reviews.apache.org/r/19758/diff/ Testing --- Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Thanks, Sachchidanand Vaidya
Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
On May 5, 2014, 11:38 p.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java, line 1 https://reviews.apache.org/r/19270/diff/1/?file=521583#file521583line1 No license header after adding license header, please run rat command to check for license Ran rat and fixed license header - Sachchidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/#review42254 --- On May 7, 2014, 3:44 p.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/ --- (Updated May 7, 2014, 3:44 p.m.) Review request for cloudstack and Rajesh Battala. Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence and re-creation during Mgmt server reboot. Diffs - api/src/com/cloud/event/EventTypes.java 075b1c8 client/tomcatconf/commands.properties.in d3a24f6 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya
Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
On May 5, 2014, 11:32 p.m., Rajesh Battala wrote: plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java, line 40 https://reviews.apache.org/r/19270/diff/1/?file=521583#file521583line40 As the service vm is specific to juniper-contrail, instead of using vm_destroy create an specific event type. refer EVENT_INTERNAL_LB_VM_STOP/START Added separete EVENTs for service instance VM creation and destroy. - Sachchidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/#review42253 --- On May 7, 2014, 3:44 p.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/ --- (Updated May 7, 2014, 3:44 p.m.) Review request for cloudstack and Rajesh Battala. Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence and re-creation during Mgmt server reboot. Diffs - api/src/com/cloud/event/EventTypes.java 075b1c8 client/tomcatconf/commands.properties.in d3a24f6 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java 59c4e61 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya
Re: Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/ --- (Updated May 3, 2014, 12:29 a.m.) Review request for cloudstack and Rajesh Battala. Changes --- . Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence and re-creation during Mgmt server reboot. Diffs - client/tomcatconf/commands.properties.in 45debe4 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya
Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/ --- (Updated May 3, 2014, 12:30 a.m.) Review request for cloudstack and Rajesh Battala. Changes --- . Repository: cloudstack-git Description --- - Added new Network Service Provider JuniperContrailvSRX. - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider. vSRX element currently supports only sourceNAT. It will be enhanced later to support more features. - Changes to service-instance creation code to use left virtual-network's SourceNAT addr as an interface address on vSRX instance's Public-network interface. Diffs - api/src/com/cloud/network/Network.java ef3bcdf plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml 99ab02e plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java 49060f1 Diff: https://reviews.apache.org/r/19758/diff/ Testing --- Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Thanks, Sachchidanand Vaidya
Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
Hi Daan, I uploaded a diff (ACS4.4-0004-Add-OpenContrail-support-to-devCloud-environment.patch) based on ACS4.4 code base. Thanks, Sachin From: Daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com Date: Friday, May 2, 2014 11:03 AM To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Cc: cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Review Request 19892: Add Juniper Contrail support to devCloud environment It doesn't cherry-pick cleaanly. Can you have a look? On Thu, May 1, 2014 at 7:38 PM, Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net wrote: Thanks Daan. Can it be committed to 4.4 as well. Best Regards, Sachin From: daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com Reply-To: daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com Date: Thursday, May 1, 2014 4:11 AM To: daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com, Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net, cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Review Request 19892: Add Juniper Contrail support to devCloud environment This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/ Ship it! 537536835bfe5161946fbc83675b4a4696536949 - daan Hoogland On April 30th, 2014, 11:15 p.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack. By Sachchidanand Vaidya. Updated April 30, 2014, 11:15 p.m. Repository: cloudstack-git Description Add OpenContrail support to devCloud environment: - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg). - Modification to deployDataCenter script, to enable JuniperContrailRouter JuniperContrailVpcRouter providers. Testing Unit tested with devCloud2 and ACS4.3 code base. Diffs * tools/devcloud/devcloud-advanced_juniper-contrail.cfg (PRE-CREATION) * tools/marvin/marvin/deployDataCenter.py (31f663e) View Diffhttps://reviews.apache.org/r/19892/diff/ -- Daan
Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
Thanks Daan. Can it be committed to 4.4 as well. Best Regards, Sachin From: daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com Reply-To: daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com Date: Thursday, May 1, 2014 4:11 AM To: daan Hoogland daan.hoogl...@gmail.commailto:daan.hoogl...@gmail.com, Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net, cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Review Request 19892: Add Juniper Contrail support to devCloud environment This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/ Ship it! 537536835bfe5161946fbc83675b4a4696536949 - daan Hoogland On April 30th, 2014, 11:15 p.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack. By Sachchidanand Vaidya. Updated April 30, 2014, 11:15 p.m. Repository: cloudstack-git Description Add OpenContrail support to devCloud environment: - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg). - Modification to deployDataCenter script, to enable JuniperContrailRouter JuniperContrailVpcRouter providers. Testing Unit tested with devCloud2 and ACS4.3 code base. Diffs * tools/devcloud/devcloud-advanced_juniper-contrail.cfg (PRE-CREATION) * tools/marvin/marvin/deployDataCenter.py (31f663e) View Diffhttps://reviews.apache.org/r/19892/diff/
Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/ --- (Updated April 30, 2014, 4:15 p.m.) Review request for cloudstack. Changes --- Thanks Daan. I have updated the diff based on latest code on Master. Also taken care of review comment. Regards, Sachin Repository: cloudstack-git Description --- Add OpenContrail support to devCloud environment: - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg). - Modification to deployDataCenter script, to enable JuniperContrailRouter JuniperContrailVpcRouter providers. Diffs (updated) - tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION tools/marvin/marvin/deployDataCenter.py 31f663e Diff: https://reviews.apache.org/r/19892/diff/ Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16523/ --- (Updated April 17, 2014, 11:16 p.m.) Review request for cloudstack. Changes --- Fixed checkstyle issues. Repository: cloudstack-git Description --- Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. Diffs (updated) - plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/InstanceIpModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/model/VMInterfaceModelTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16523/diff/ Testing --- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya
Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/ --- (Updated April 15, 2014, 1:18 p.m.) Review request for cloudstack. Changes --- Updated diff with whitespaces removed from config file. Repository: cloudstack-git Description --- Add OpenContrail support to devCloud environment: - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg). - Modification to deployDataCenter script, to enable JuniperContrailRouter JuniperContrailVpcRouter providers. Diffs (updated) - tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION tools/marvin/marvin/deployDataCenter.py c4f6e1e Diff: https://reviews.apache.org/r/19892/diff/ Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya
Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey
On April 15, 2014, 7:23 a.m., daan Hoogland wrote: It would seem that this is a behavioral change that would break backwards compatibility, is it? Right now empty service names are accepted. What is the consequence and why change the behavior, can you shed light on the subject? otherwise the change seems trivial enough and is applicable. Hi Daan, If user passes null string during instance creation then it's an issue since we can't search service-instance with a null string as part of Fully Qualified Name lookup on Contrail Controller. Hence user can't delete a service-instance with null string. Passing empty string is functionally ok but we want to avoid both null and empty string since it's not a good idea from usability/debugability point of view. Thanks Regards, Sachin - Sachchidanand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/#review40393 --- On April 2, 2014, 2:14 a.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/ --- (Updated April 2, 2014, 2:14 a.m.) Review request for cloudstack. Repository: cloudstack-git Description --- Don't allow service instance creation with empty or null service-instance name Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java d2cb4de Diff: https://reviews.apache.org/r/19912/diff/ Testing --- Unit tested for null and empty name parameter. Thanks, Sachchidanand Vaidya
Re: Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey
Hi, Can someone pls review these changes. Thanks Regards, Sachin On 4/2/14 2:14 AM, Sachchidanand Vaidya vaidy...@juniper.net wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Don't allow service instance creation with empty or null service-instance name Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/networ k/contrail/api/command/CreateServiceInstanceCmd.java d2cb4de Diff: https://reviews.apache.org/r/19912/diff/ Testing --- Unit tested for null and empty name parameter. Thanks, Sachchidanand Vaidya
Re: Review Request 19892: Add Juniper Contrail support to devCloud environment
Hi, Can someone pls review these changes. Thanks Regards, Sachin From: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Reply-To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Date: Tuesday, April 1, 2014 3:05 PM To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net, cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Review Request 19892: Add Juniper Contrail support to devCloud environment This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/ Review request for cloudstack. By Sachchidanand Vaidya. Repository: cloudstack-git Description Add OpenContrail support to devCloud environment: - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg). - Modification to deployDataCenter script, to enable JuniperContrailRouter JuniperContrailVpcRouter providers. Testing Unit tested with devCloud2 and ACS4.3 code base. Diffs * tools/devcloud/devcloud-advanced_juniper-contrail.cfg (PRE-CREATION) * tools/marvin/marvin/deployDataCenter.py (c4f6e1e) View Diffhttps://reviews.apache.org/r/19892/diff/
Re: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
Hi, Can someone pls. review these changes. Thanks Regards, Sachin From: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Reply-To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net Date: Thursday, March 27, 2014 4:38 PM To: Sachchidanand Vaidya vaidy...@juniper.netmailto:vaidy...@juniper.net, cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality. This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/ Review request for cloudstack. By Sachchidanand Vaidya. Repository: cloudstack-git Description - Added new Network Service Provider JuniperContrailvSRX. - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider. vSRX element currently supports only sourceNAT. It will be enhanced later to support more features. - Changes to service-instance creation code to use left virtual-network's SourceNAT addr as an interface address on vSRX instance's Public-network interface. Testing Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Diffs * api/src/com/cloud/network/Network.java (ef3bcdf) * plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml (99ab02e) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java (PRE-CREATION) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java (f34eacc) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java (49060f1) View Diffhttps://reviews.apache.org/r/19758/diff/
Review Request 19912: [CLOUDSTACK-6322] Fixed Contrail: Params validation is missing while launching a service instance thru cloudmonkey
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19912/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Don't allow service instance creation with empty or null service-instance name Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/CreateServiceInstanceCmd.java d2cb4de Diff: https://reviews.apache.org/r/19912/diff/ Testing --- Unit tested for null and empty name parameter. Thanks, Sachchidanand Vaidya
Review Request 19892: Add Juniper Contrail support to devCloud environment
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19892/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Add OpenContrail support to devCloud environment: - Created new devcloud advanced networking config file (devcloud-advanced_juniper-contrail.cfg). - Modification to deployDataCenter script, to enable JuniperContrailRouter JuniperContrailVpcRouter providers. Diffs - tools/devcloud/devcloud-advanced_juniper-contrail.cfg PRE-CREATION tools/marvin/marvin/deployDataCenter.py c4f6e1e Diff: https://reviews.apache.org/r/19892/diff/ Testing --- Unit tested with devCloud2 and ACS4.3 code base. Thanks, Sachchidanand Vaidya
devCloud2 and master
Hi All, I'm trying to run devCloud2 with CS Management server running master code. Setup is: CS Mgmt Server: 192.168.56.1, XenHost ova:192.168.56.10 - While trying to setup Basic networking using (devcloud.cfg), got Cannot create directory /opt/cloud/bin on XenServer hosts error during addHost. Anyone facing similar issue ? - I can manually ssh to xenhost(192.168.56.10) and also execute the command mkdir -p /opt/cloud/bin /var/log/cloud without any error. INFO [c.c.h.x.d.XcpServerDiscoverer] (562467077@qtp-957221885-0:ctx-3b4e545f ctx-af9f99c3 ctx-87169cf4) Host: devcloud connected with hypervisor type: XenServer. Checking CIDR... INFO [c.c.a.m.DirectAgentAttache] (562467077@qtp-957221885-0:ctx-3b4e545f ctx-af9f99c3 ctx-87169cf4) StartupAnswer received 1 Interval = 60 WARN [c.c.a.m.DirectAgentAttache] (DirectAgent-1:ctx-0439d91d) Seq 1-5104267227671035905: Exception Caught while executing command com.cloud.utils.exception.CloudRuntimeException: Cannot create directory /opt/cloud/bin on XenServer hosts at com.cloud.hypervisor.xen.resource.CitrixResourceBase.setupServer(CitrixResourceBase.java:4892) at com.cloud.hypervisor.xen.resource.CitrixResourceBase.execute(CitrixResourceBase.java:4718) at com.cloud.hypervisor.xen.resource.CitrixResourceBase.executeRequest(CitrixResourceBase.java:497) at com.cloud.hypervisor.xen.resource.XcpOssResource.executeRequest(XcpOssResource.java:176) at com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:216) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:49) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:56) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:103) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:53) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:46) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178) at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) WARN [c.c.h.x.d.XcpServerDiscoverer] (562467077@qtp-957221885-0:ctx-3b4e545f ctx-af9f99c3 ctx-87169cf4) Unable to setup agent 1 due to com.cloud.utils.exception.CloudRuntimeException: Cannot create directory /opt/cloud/bin on XenServer hosts - In addition to above error, also seeing following errors during datacenter deployment.. WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-1:Job-5 ctx-45552650) Received unknown parameters for command createPhysicalNetwork. Unknown parameters : ctxstarteventid INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-1:Job-5) Remove job-5 from job monitoring INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-2:Job-6) Add job-6 into job monitoring WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-2:Job-6 ctx-8ec87166) Received unknown parameters for command addTrafficType. Unknown parameters : ctxstarteventid INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-2:Job-6) Remove job-6 from job monitoring INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-3:Job-7) Add job-7 into job monitoring WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-3:Job-7 ctx-3804814f) Received unknown parameters for command addTrafficType. Unknown parameters : ctxstarteventid INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-3:Job-7) Remove job-7 from job monitoring INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-4:Job-8) Add job-8 into job monitoring WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-4:Job-8 ctx-62121f8f) Received unknown parameters for command configureVirtualRouterElement. Unknown parameters : ctxstarteventid INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-4:Job-8) Remove job-8 from job monitoring INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-5:Job-9) Add job-9 into job monitoring WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-5:Job-9 ctx-31297f1c) Received unknown parameters for command updateNetworkServiceProvider. Unknown parameters : ctxstarteventid INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-5:Job-9) Remove job-9 from job monitoring INFO [o.a.c.f.j.i.AsyncJobMonitor] (API-Job-Executor-6:Job-10) Add job-10 into job monitoring WARN [c.c.a.d.ParamGenericValidationWorker] (API-Job-Executor-6:Job-10 ctx-95dd4c17) Received unknown parameters for
Review Request 19758: Added a Network Service Provider for JuniperContrailvSRX. This NSP provides sourceNAT functionality.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19758/ --- Review request for cloudstack. Repository: cloudstack-git Description --- - Added new Network Service Provider JuniperContrailvSRX. - Impelemted an element (ContrailVSrxElement) to support this Network Service Provider. vSRX element currently supports only sourceNAT. It will be enhanced later to support more features. - Changes to service-instance creation code to use left virtual-network's SourceNAT addr as an interface address on vSRX instance's Public-network interface. Diffs - api/src/com/cloud/network/Network.java ef3bcdf plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml 99ab02e plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailVSrxElementImpl.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VMInterfaceModel.java 49060f1 Diff: https://reviews.apache.org/r/19758/diff/ Testing --- Performed unit tests with vSRX network service provider. Also other unit tests pass in local testbed. Thanks, Sachchidanand Vaidya
Review Request 19270: Added service-instance delete command to Juniper Contrail Plugin and related fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19270/ --- Review request for cloudstack. Repository: cloudstack-git Description --- This patch has following changes: - Added service-instance delete command to Juniper Contrail Plugin. - Fixes to plugin code to handle instance-delete operation properly. - Fix related to service-instance persistence and re-creation during Mgmt server reboot. Diffs - client/tomcatconf/commands.properties.in 45debe4 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/api/command/DeleteServiceInstanceCmd.java PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 05723b0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java f81c0d0 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServerDBSyncImpl.java b9a3ed3 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManager.java e4ef26d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java f34eacc plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/ServiceInstanceModel.java e79053c Diff: https://reviews.apache.org/r/19270/diff/ Testing --- Unit tests passed and additional testing done locally. Thanks, Sachchidanand Vaidya
Re: Difference between Guest Network and Isolated Network under Advanced Networking
Thanks Yoshikaza, Marcus and Yitao. I agree with Yoshikazu, that Guest Network under Admin is a Shared Networks. It will be good to change UI to avoid confusion. Can someone pls. clarify my second question. I created and Enabled a new Network Offering. But when I create an Isolated Network, I don't see the newly created Network offering in the drop-down menu. Are there additional steps to be followed to make new n/w offering visible during Virtual Network creation. Thanks Best Regards, Sachin On 2/12/14 10:21 PM, Yoshikazu Nojima m...@ynojima.net wrote: In my understanding, Guest Network Sachin said is called Shared Network in the document. [1] The word Guest Network refers Shared Network and Isolated Network in some cases. Why don't we avoid using Guest Network to point Shared Network in GUI? [1] http://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.0.2/html/Admin _Guide/about-virtual-networks.html 2014-02-12 22:53 GMT-07:00 Marcus shadow...@gmail.com: I can see how that is confusing, because 'guest' traffic type is where isolated networks are created. They are largely synonymous in many areas of cloudstack. On Wed, Feb 12, 2014 at 8:08 PM, Yitao Jiang willier...@gmail.com wrote: Guest network is same as public ip, which vm's traffic go through switch directly. Isolated Network is a virtual network, all traffic go through VRouter. And if you assigned tag on Physical Network, if so you should set same tag on n/w offering. The effective way is compare your new n/w offering with existed n/w offering DefaultIsolatedNetworkOffering . Thanks, Yitao 2014-02-13 10:40 GMT+08:00 Sachchidanand Vaidya vaidy...@juniper.net: Hi, Under Networks Tab in UI for Admin user, Cloudstack provides 2 options to create networks 1) Add guest network 2) Add Isolated Network. - What is the difference between these 2 networks. Also, I created and Enabled a new Network Offering. But when I create an Isolated Network, I don't see the newly created Network offering in the drop-down menu. Are there additional steps to be followed to make new n/w offering visible during Virtual Network creation. Thanks, Sachin
Difference between Guest Network and Isolated Network under Advanced Networking
Hi, Under Networks Tab in UI for Admin user, Cloudstack provides 2 options to create networks 1) Add guest network 2) Add Isolated Network. - What is the difference between these 2 networks. Also, I created and Enabled a new Network Offering. But when I create an Isolated Network, I don't see the newly created Network offering in the drop-down menu. Are there additional steps to be followed to make new n/w offering visible during Virtual Network creation. Thanks, Sachin
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16523/ --- (Updated Feb. 5, 2014, 11:23 p.m.) Review request for cloudstack. Changes --- Hi Daan, I have updated files correcting some of the formatting. Pls let me know if this looks ok. Thanks, Sachin Repository: cloudstack-git Description --- Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. Diffs (updated) - plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16523/diff/ Testing --- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya
Re: Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16523/ --- (Updated Feb. 3, 2014, 10:15 p.m.) Review request for cloudstack. Changes --- Dann, Thanks. I have updated the file with license header. Best Regards, Sachin Repository: cloudstack-git Description --- Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. Diffs (updated) - plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16523/diff/ Testing --- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya
Review Request 17307: Juniper Contrail Plugin fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17307/ --- Review request for cloudstack. Repository: cloudstack-git Description --- These are additional fixes to make Juniper Contrail plugin work on ACS master Diffs - plugins/network-elements/juniper-contrail/pom.xml ae6961e plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties PRE-CREATION plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 092e4bc plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java 416653d plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java 2f81688 plugins/network-elements/juniper-contrail/test/resources/commonContext.xml eef908f Diff: https://reviews.apache.org/r/17307/diff/ Testing --- Passes unit tests. Thanks, Sachchidanand Vaidya
Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16974/ --- Review request for cloudstack. Repository: cloudstack-git Description --- These are additional fixes to make Juniper Contrail plugin work in ACS4.3. These changes were missed during last commit Diffs - plugins/network-elements/juniper-contrail/pom.xml 22167fe plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties PRE-CREATION plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml PRE-CREATION plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java 18e8bde plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java 82f2cc4 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java dec4a9e plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java 195e932 plugins/network-elements/juniper-contrail/test/resources/commonContext.xml c577513 Diff: https://reviews.apache.org/r/16974/diff/ Testing --- Locally tested on centOS6.3 machine. Thanks, Sachchidanand Vaidya
Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes
Hi Hugo, These fixes are blocker for contrail plugin. We missed this fix while submitting patches to ACS. Thanks, Sachin From: Hugo Trippaers htrippa...@schubergphilis.commailto:htrippa...@schubergphilis.com Reply-To: Hugo Trippaers htrippa...@schubergphilis.commailto:htrippa...@schubergphilis.com Date: Thursday, January 16, 2014 11:01 AM To: Admin vaidy...@juniper.netmailto:vaidy...@juniper.net, Hugo Trippaers htrippa...@schubergphilis.commailto:htrippa...@schubergphilis.com, cloudstack dev@cloudstack.apache.orgmailto:dev@cloudstack.apache.org Subject: Re: Review Request 16974: (ACS4.3) Juniper Contrail Plugin fixes This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16974/ Are these fixes release blockers or can they go into 4.4? The release 4.3 is effectively closed by now. Cheers, Hugo - Hugo Trippaers On January 16th, 2014, 6:53 p.m. UTC, Sachchidanand Vaidya wrote: Review request for cloudstack. By Sachchidanand Vaidya. Updated Jan. 16, 2014, 6:53 p.m. Repository: cloudstack-git Description These are additional fixes to make Juniper Contrail plugin work in ACS4.3. These changes were missed during last commit Testing Locally tested on centOS6.3 machine. Diffs * plugins/network-elements/juniper-contrail/pom.xml (22167fe) * plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/module.properties (PRE-CREATION) * plugins/network-elements/juniper-contrail/resources/META-INF/cloudstack/contrail/spring-contrail-context.xml (PRE-CREATION) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailElementImpl.java (18e8bde) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java (6587534) * plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ServiceManagerImpl.java (82f2cc4) * plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/IntegrationTestConfiguration.java (dec4a9e) * plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/MockAccountManager.java (195e932) * plugins/network-elements/juniper-contrail/test/resources/commonContext.xml (c577513) View Diffhttps://reviews.apache.org/r/16974/diff/
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- (Updated Jan. 14, 2014, 9:44 p.m.) Review request for cloudstack. Changes --- Updating the review diff based on the latest on ACS4.4. Repository: cloudstack-git Description --- Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN. Diffs (updated) - api/src/com/cloud/network/PhysicalNetwork.java 5c348c2 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 079035b plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java 806dd21 ui/scripts/ui-custom/zoneWizard.js 99aa3b9 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
Hi Sheng, I have updated the review with changes based off latest on ACS master. Thanks Best Regards, Sachin On 1/14/14 1:25 PM, Sheng Yang sh...@yasker.org wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/#review31802 --- Looks good to me, but cannot applied to the latest MASTER branch(I suppose that's the target). - Sheng Yang On Jan. 13, 2014, 5:46 a.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- (Updated Jan. 13, 2014, 5:46 a.m.) Review request for cloudstack. Repository: cloudstack-git Description --- Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN. Diffs - api/src/com/cloud/network/PhysicalNetwork.java cfa236d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo rk/contrail/management/ContrailGuru.java ea52be9 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw ork/contrail/management/ManagementServerMock.java c449b8a ui/scripts/ui-custom/zoneWizard.js 28df193 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
Thanks Sheng. Best Regards, Sachin On 1/14/14 1:56 PM, Sheng Yang sh...@yasker.org wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/#review31812 --- Ship it! Applied to MASTER. Thanks. - Sheng Yang On Jan. 14, 2014, 9:44 p.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- (Updated Jan. 14, 2014, 9:44 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN. Diffs - api/src/com/cloud/network/PhysicalNetwork.java 5c348c2 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo rk/contrail/management/ContrailGuru.java 079035b plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw ork/contrail/management/ManagementServerMock.java 806dd21 ui/scripts/ui-custom/zoneWizard.js 99aa3b9 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya
Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16841/ --- Review request for cloudstack. Repository: cloudstack-git Description --- This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4). Diffs - api/src/com/cloud/network/PhysicalNetwork.java 55b18e6 plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466 ui/scripts/ui-custom/zoneWizard.js 28df193 Diff: https://reviews.apache.org/r/16841/diff/ Testing --- Unit testing done. Thanks, Sachchidanand Vaidya
Re: Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- (Updated Jan. 13, 2014, 5:46 a.m.) Review request for cloudstack. Changes --- Minor correction to previous submission. Repository: cloudstack-git Description --- Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN. Diffs (updated) - api/src/com/cloud/network/PhysicalNetwork.java cfa236d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ea52be9 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java c449b8a ui/scripts/ui-custom/zoneWizard.js 28df193 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya
RE: CLOUDSTACK-5502 [Automation] createVlanIpRange API failing, if you pass VLAN
Hi, Bug CS-5502 was fixed (12/20/13) and then reopened (12/26/13) again since for Vlan=UNTAGGED case, createVlanIpRange() API fails with Vlan id is required when add ip range to the public network. Vlan =untagged can be a valid case for public networks (in advanced networking) as is the case in juniper-contrail solution. Is there a fix planned for this bug? Thanks Regards, Sachin
Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.
Thanks. Best Regards, Sachin On 12/29/13 11:57 PM, Hugo Trippaers htrippa...@schubergphilis.com wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15825/#review30945 --- Ship it! commit 7f9683af859224b4aa0cae037acda063a9d1536e Author: Sachchidanand Vaidya vaidy...@juniper.net Date: Tue Dec 10 09:02:25 2013 -0800 Added Virtual-Network and Virtual-Machine Model unit test. Signed-off-by: Hugo Trippaers htrippa...@schubergphilis.com - Hugo Trippaers On Dec. 10, 2013, 5:12 p.m., Sachchidanand Vaidya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15825/ --- (Updated Dec. 10, 2013, 5:12 p.m.) Review request for cloudstack. Repository: cloudstack-git Description --- The code change adds UnitTest cases for Juniper Contrail Virtual Network(VN) and Virtual Machine(VM) Model classes. Only VN VM creation test cases added. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo rk/contrail/management/ModelDatabase.java 7f66a3b plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/netwo rk/contrail/model/VirtualMachineModel.java 96cea95 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw ork/contrail/management/VirtualMachineModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/netw ork/contrail/management/VirtualNetworkModelTest.java 0938541 Diff: https://reviews.apache.org/r/15825/diff/ Testing --- Juniper contrail Unit Tests ran successfully as part of package build. Thanks, Sachchidanand Vaidya
Review Request 16523: Unit tests for Juniper contrail VM Interface Model and Instance Ip Model class.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16523/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Added unit tests for Juniper contrail VM Interface Model and Instance Ip Model class. Diffs - plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/InstanceIpModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VMInterfaceModelTest.java PRE-CREATION Diff: https://reviews.apache.org/r/16523/diff/ Testing --- All Juniper contrail plugin unit tests pass without any error. Thanks, Sachchidanand Vaidya
Review Request 16258: Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16258/ --- Review request for cloudstack. Repository: cloudstack-git Description --- Add new physical network isolationMethod (L3VPN) for Juniper Contrail network Plugin. ContrailGuru checks for IsolationMethod before designing a VN. Diffs - api/src/com/cloud/network/PhysicalNetwork.java cfa236d plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java ea52be9 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java c449b8a ui/scripts/ui-custom/zoneWizard.js 28df193 Diff: https://reviews.apache.org/r/16258/diff/ Testing --- Changes pass unit tests and complete centos63 package build. Thanks, Sachchidanand Vaidya
Re: Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15825/ --- (Updated Dec. 10, 2013, 5:12 p.m.) Review request for cloudstack. Changes --- Updated diff based on the review comments. Repository: cloudstack-git Description --- The code change adds UnitTest cases for Juniper Contrail Virtual Network(VN) and Virtual Machine(VM) Model classes. Only VN VM creation test cases added. Diffs (updated) - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java 7f66a3b plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java 96cea95 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java 0938541 Diff: https://reviews.apache.org/r/15825/diff/ Testing --- Juniper contrail Unit Tests ran successfully as part of package build. Thanks, Sachchidanand Vaidya
Review Request 15825: Added unit tests for Juniper Contrail Virtual Network (VN) and Virtual Machine (VM) Model classes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15825/ --- Review request for cloudstack. Repository: cloudstack-git Description --- The code change adds UnitTest cases for Juniper Contrail Virtual Network(VN) and Virtual Machine(VM) Model classes. Only VN VM creation test cases added. Diffs - plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ModelDatabase.java 7f66a3b plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/model/VirtualMachineModel.java 32d5d93 plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualMachineModelTest.java PRE-CREATION plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/VirtualNetworkModelTest.java 0938541 Diff: https://reviews.apache.org/r/15825/diff/ Testing --- Juniper contrail Unit Tests ran successfully as part of package build. Thanks, Sachchidanand Vaidya
