[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner Sorry for the late reply. But it seems you have misunderstood me here. I am not pointing finger here. I was just trying to point out that there may be developer concern there to not remove it. Some changes looks quite simple but have potential to cause regressions. That's why I have done this way. I prefer to have code improvements of that type of changes in a separate PR. If anything goes wrong then they can be easily reverted without causing any regression. In other words fix for some bug doesn't get accidentally removed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre⦠â¦ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9706 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1867 commit c68931fc64718d8c7f22d401f624ae649effdf94 Author: Anshul Gangwar Date: 2016-05-09T07:15:31Z CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thread if they are failed to cleanup during DeleteSnapshot command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1282: CLOUDSTACK-9200: Fixed failed to delete snaps...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1282#discussion_r111531779
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -245,6 +245,12 @@ public boolean deleteSnapshot(Long snapshotId) {
return true;
}
+if(snapshotVO.getState() == Snapshot.State.Allocated) {
--- End diff --
@rhtyd Missed that change. Closing PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @karuturi Raised #2043 to remove the test which is no longer needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #2043: CLOUDSTACK-9876: Removed test test_01_test_vm...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/2043 CLOUDSTACK-9876: Removed test test_01_test_vm_volume_snapshot As we no longer have that restriction and now after fix for CLOUDSTACK-8663 we allow VM and volume snapshots to exist together You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/2043.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2043 commit fa5e59675e2750edc55a4c75ff8770d363c55de7 Author: Anshul Gangwar Date: 2017-04-14T05:24:56Z CLOUDSTACK-9876: Removed test test_01_test_vm_volume_snapshot as we no longer have that restriction and now after fix for CLOUDSTACK-8663 we allow VM and volume snapshots to exist together --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1853 CLOUDSTACK-9696: Fixed Virtual Router deployment failing if there are⦠⦠no shared resources available and has access to resources through parent domain heirarachy You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9696 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1853 commit 0024dfc62266cc52380b7977860f667414d36e42 Author: Anshul Gangwar Date: 2016-12-22T06:17:03Z CLOUDSTACK-9696: Fixed Virtual Router deployment failing if there are no shared resources available and has access to resources through parent domain heirarachy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1853 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1867 @koushik-das Failing tests doesn't seems to be related to this patch. Rebased against latest master to trigger the build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1853: CLOUDSTACK-9696: Fixed Virtual Router deployment fai...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1853 @koushik-das Made the changes as per review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106632802
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
isExplicit = true;
}
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc =
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If
not, it may belongs to Account or no dedication.
-List domainGroupMappings =
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null ||
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null,
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null,
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) ||
vm.getType() == VirtualMachine.Type.DomainRouter) {
+List allPodsInDc = _podDao.listAllPods(dc.getId());
+List allDedicatedPods = _dedicatedDao.listAllPods();
+allPodsInDc.retainAll(allDedicatedPods);
-for(DedicatedResourceVO vo : tempStorage) {
-allClustersFromDedicatedID.add(vo.getClusterId());
-}
+List allClustersInDc =
_clusterDao.listAllCusters(dc.getId());
+List allDedicatedClusters =
_dedicatedDao.listAllClusters();
+allClustersInDc.retainAll(allDedicatedClusters);
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedHosts(null,
vmDomainId, vmAccountId, null).first();
+List allHostsInDc = _hostDao.listAllHosts(dc.getId());
+List allDedicatedHosts = _dedicatedDao.listAllHosts();
+allHostsInDc.retainAll(allDedicatedHosts);
-for(DedicatedResourceVO vo : tempStorage) {
-allHostsFromDedicatedID.add(vo.getHostId());
-}
+//Only when the type is instance VM and not explicitly
dedicated.
+if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
+//add explicitly dedicated resources in avoidList
-//Remove the dedicated ones from main list
-allPodsInDc.removeAll(allPodsFromDedicatedID);
-allClustersInDc.removeAll(allClustersFromDedicatedID);
-allHostsInDc.removeAll(allHostsFromDedicatedID);
+avoids.addPodList(allPodsInDc);
+avoids.addClusterList(allClustersInDc);
+avoids.addHostList(allHostsInDc);
}
-else {
-//The dedicate
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106632584
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
}
@Override
+public List listAvailableResources(Long
accountId, Long... domains) {
--- End diff --
@koushik-das Made the changes using SearchBuilder class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre⦠â¦ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9706 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1867 commit e9245d3ac1a888505e9d2c1e05841791e29c51ec Author: Anshul Gangwar Date: 2016-05-09T07:15:31Z CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thread if they are failed to cleanup during DeleteSnapshot command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1867 @koushik-das Made the changes as per review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106388631
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {
}
}
+//destroy snapshots in destroying state in
snapshot_store_ref
+List ssSnapshots =
_snapshotStoreDao.listByState(ObjectInDataStoreStateMachine.State.Destroying);
+for(SnapshotDataStoreVO ssSnapshotVO : ssSnapshots){
+try {
+
_snapshotService.deleteSnapshot(snapshotFactory.getSnapshot(ssSnapshotVO.getSnapshotId(),
DataStoreRole.Image));
--- End diff --
@koushik-das If there is any failure in deleteSnapshot() then cleanup will
be retried. DB entry for such snapshots will only be removed on successful
deletion. Destroying check introduced in SnapshotObject class is to make sure
that DB entry doesn't gets deleted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106387626
--- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java ---
@@ -1181,6 +1181,17 @@ public boolean configure(String name, Map params) throws Configu
@Override
public boolean start() {
+//destroy snapshots in destroying state
+List dsnapshots =
_snapshotDao.listAllByStatus(Snapshot.State.Destroying);
--- End diff --
@koushik-das Will make the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106387348
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
---
@@ -191,7 +191,8 @@ public void
processEvent(ObjectInDataStoreStateMachine.Event event) {
s_logger.debug("Failed to update state:" + e.toString());
throw new CloudRuntimeException("Failed to update state: " +
e.toString());
} finally {
-if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+DataObjectInStore obj = objectInStoreMgr.findObject(this,
this.getDataStore());
+if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed &&
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --
@koushik-das obj cannot be null as that method is kind of called on that
object itself. That method is fetching it from DB for some more details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106386503
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -194,18 +194,22 @@ protected boolean deleteSnapshotChain(SnapshotInfo
snapshot) {
}
}
if (!deleted) {
-boolean r = snapshotSvr.deleteSnapshot(snapshot);
-if (r) {
-// delete snapshot in cache if there is
-List cacheSnaps =
snapshotDataFactory.listSnapshotOnCache(snapshot.getId());
-for (SnapshotInfo cacheSnap : cacheSnaps) {
-s_logger.debug("Delete snapshot " +
snapshot.getId() + " from image cache store: " +
cacheSnap.getDataStore().getName());
-cacheSnap.delete();
+try {
+boolean r = snapshotSvr.deleteSnapshot(snapshot);
+if (r) {
+// delete snapshot in cache if there is
+List cacheSnaps =
snapshotDataFactory.listSnapshotOnCache(snapshot.getId());
+for (SnapshotInfo cacheSnap : cacheSnaps) {
+s_logger.debug("Delete snapshot " +
snapshot.getId() + " from image cache store: " +
cacheSnap.getDataStore().getName());
+cacheSnap.delete();
+}
}
-}
-if (!resultIsSet) {
-result = r;
-resultIsSet = true;
+if (!resultIsSet) {
+result = r;
+resultIsSet = true;
+}
+} catch (Exception e){
--- End diff --
@koushik-das Its a catch all as we will retry to delete snapshot again in
next attempt if it fails to delete so just logging in and carry on. Also it is
introduced to make sure that all snapshots gets chance to delete.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106385035
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
---
@@ -191,7 +191,8 @@ public void
processEvent(ObjectInDataStoreStateMachine.Event event) {
s_logger.debug("Failed to update state:" + e.toString());
throw new CloudRuntimeException("Failed to update state: " +
e.toString());
} finally {
-if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed) {
+DataObjectInStore obj = objectInStoreMgr.findObject(this,
this.getDataStore());
+if (event ==
ObjectInDataStoreStateMachine.Event.OperationFailed &&
!obj.getState().equals(ObjectInDataStoreStateMachine.State.Destroying)) {
--- End diff --
@koushik-das If there is failure in destroying snapshot then we should not
delete db entry so that it can be used to detect which snapshots failed to
delete successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1867#discussion_r106384378
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring) {
}
}
+//destroy snapshots in destroying state in
snapshot_store_ref
+List ssSnapshots =
_snapshotStoreDao.listByState(ObjectInDataStoreStateMachine.State.Destroying);
+for(SnapshotDataStoreVO ssSnapshotVO : ssSnapshots){
+try {
+
_snapshotService.deleteSnapshot(snapshotFactory.getSnapshot(ssSnapshotVO.getSnapshotId(),
DataStoreRole.Image));
--- End diff --
@koushik-das If there is any failure then the db entry will remain
Destroying and will only be updated if there is successful deletion. Condition
which is checking Destroying state of object in SnapshotObject class is meant
for this purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106381321
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
isExplicit = true;
}
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc =
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If
not, it may belongs to Account or no dedication.
-List domainGroupMappings =
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null ||
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null,
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null,
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) ||
vm.getType() == VirtualMachine.Type.DomainRouter) {
+List allPodsInDc = _podDao.listAllPods(dc.getId());
+List allDedicatedPods = _dedicatedDao.listAllPods();
+allPodsInDc.retainAll(allDedicatedPods);
-for(DedicatedResourceVO vo : tempStorage) {
-allClustersFromDedicatedID.add(vo.getClusterId());
-}
+List allClustersInDc =
_clusterDao.listAllCusters(dc.getId());
+List allDedicatedClusters =
_dedicatedDao.listAllClusters();
+allClustersInDc.retainAll(allDedicatedClusters);
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedHosts(null,
vmDomainId, vmAccountId, null).first();
+List allHostsInDc = _hostDao.listAllHosts(dc.getId());
+List allDedicatedHosts = _dedicatedDao.listAllHosts();
+allHostsInDc.retainAll(allDedicatedHosts);
-for(DedicatedResourceVO vo : tempStorage) {
-allHostsFromDedicatedID.add(vo.getHostId());
-}
+//Only when the type is instance VM and not explicitly
dedicated.
+if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
+//add explicitly dedicated resources in avoidList
-//Remove the dedicated ones from main list
-allPodsInDc.removeAll(allPodsFromDedicatedID);
-allClustersInDc.removeAll(allClustersFromDedicatedID);
-allHostsInDc.removeAll(allHostsFromDedicatedID);
+avoids.addPodList(allPodsInDc);
+avoids.addClusterList(allClustersInDc);
+avoids.addHostList(allHostsInDc);
}
-else {
-//The dedicate
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106380082
--- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java ---
@@ -584,105 +583,64 @@ private void
checkForNonDedicatedResources(VirtualMachineProfile vmProfile, Data
isExplicit = true;
}
-List allPodsInDc = _podDao.listAllPods(dc.getId());
-List allDedicatedPods = _dedicatedDao.listAllPods();
-allPodsInDc.retainAll(allDedicatedPods);
-
-List allClustersInDc =
_clusterDao.listAllCusters(dc.getId());
-List allDedicatedClusters = _dedicatedDao.listAllClusters();
-allClustersInDc.retainAll(allDedicatedClusters);
-
-List allHostsInDc = _hostDao.listAllHosts(dc.getId());
-List allDedicatedHosts = _dedicatedDao.listAllHosts();
-allHostsInDc.retainAll(allDedicatedHosts);
-
-//Only when the type is instance VM and not explicitly dedicated.
-if (vm.getType() == VirtualMachine.Type.User && !isExplicit) {
-//add explicitly dedicated resources in avoidList
-
-avoids.addPodList(allPodsInDc);
-avoids.addClusterList(allClustersInDc);
-avoids.addHostList(allHostsInDc);
-}
-
-//Handle the Virtual Router Case
-//No need to check the isExplicit. As both the cases are handled.
-if (vm.getType() == VirtualMachine.Type.DomainRouter) {
-long vmAccountId = vm.getAccountId();
-long vmDomainId = vm.getDomainId();
-
-//Lists all explicitly dedicated resources from vm account ID
or domain ID.
-List allPodsFromDedicatedID = new ArrayList();
-List allClustersFromDedicatedID = new ArrayList();
-List allHostsFromDedicatedID = new ArrayList();
-
-//Whether the dedicated resources belong to Domain or not. If
not, it may belongs to Account or no dedication.
-List domainGroupMappings =
_affinityGroupDomainMapDao.listByDomain(vmDomainId);
-
-//For temporary storage and indexing.
-List tempStorage;
-
-if (domainGroupMappings == null ||
domainGroupMappings.isEmpty()) {
-//The dedicated resource belongs to VM Account ID.
-
-tempStorage = _dedicatedDao.searchDedicatedPods(null,
vmDomainId, vmAccountId, null).first();
-
-for(DedicatedResourceVO vo : tempStorage) {
-allPodsFromDedicatedID.add(vo.getPodId());
-}
-
-tempStorage.clear();
-tempStorage = _dedicatedDao.searchDedicatedClusters(null,
vmDomainId, vmAccountId, null).first();
+if ((vm.getType() == VirtualMachine.Type.User && !isExplicit) ||
vm.getType() == VirtualMachine.Type.DomainRouter) {
--- End diff --
@koushik-das Here additional isExplicit check is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1853#discussion_r106378310
--- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java ---
@@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId) {
}
@Override
+public List listAvailableResources(Long
accountId, Long... domains) {
--- End diff --
@koushik-das Could not find a way to write the conditional statement so
went with this way. Here account_id in involved in two places in condition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @GabrielBrascher The other method is there for legacy purposes and is no longer get used in Cloudstack. This was getting used in 2.x versions for UI. Some third party tool might be using it so kept it for that purpose. Mixing things will make it more complicated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner stop start destroy etc all methods related to virtual router code have these parameters? Questions there is why are they not removed in the first place when they CallContext got introduced and removed at some places. That's why I would prefer to have different PR specifically for this. If something breaks then that can be easily tackled without the need of reverting some bug fix which may get lost later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @nvazquez @rafaelweingartner @GabrielBrascher, That method is called from multiple places. There are many places where we can do these kind of changes. I would prefer to have those kind of changes in PR specific to that so that they are easy to track and test for that specific purpose. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @DaanHoogland @rafaelweingartner Will have a look at the proposed changes and get back to you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dyn...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/868#discussion_r105116946
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -1535,6 +1535,19 @@ private boolean upgradeRunningVirtualMachine(Long
vmId, Long newServiceOfferingI
+ ",memory=," + currentMemory + ")");
}
+_offeringDao.loadDetails(currentServiceOffering);
+_offeringDao.loadDetails(newServiceOffering);
+
+Map currentDetails =
currentServiceOffering.getDetails();
+Map newDetails = newServiceOffering.getDetails();
+String currentVgpuType = currentDetails.get("vgpuType");
+String newVgpuType = newDetails.get("vgpuType");
+if(currentVgpuType != null) {
+if(newVgpuType == null ||
!newVgpuType.equalsIgnoreCase(currentVgpuType)) {
+throw new InvalidParameterValueException("Dynamic scaling
of vGPU type is not supported. VM has vGPU Type: " + currentVgpuType);
+}
+}
+
// Check resource limits
--- End diff --
@pedro-martins I would prefer it this way for readability.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @GabrielBrascher @alexandrelimassantana I kept it that way for readability as console proxy code is hard to debug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1282: CLOUDSTACK-9200: Fixed failed to delete snapshot if ...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1282 @swill Added the return true statement. @rhtyd Snapshot in Allocated state means nothing is done for that snapshot so only deletion from DB is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou I think default value should be false. As it tells the user to make informed decision instead of misleading according to original purpose of parameter. @sateesh-chodapuneedi @koushik-das What do you guys think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou Added the global setting allow.deploy.vm.if.deploy.on.given.host.fails to control the behaviour. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/793 @koushik-das @sateesh-chodapuneedi @ramkatru @karuturi @rhtyd Regarding unit tests, I can't see any useful tests can be written here which I have already specified the reason for. Also we have already lot of unit tests which are wasting time to fix. Every now and then I am coming across unit tests which are not written in proper way and leads to waste of effort. As far as my understanding of unit test goes they are to reduce effort not increase. One example is in this PR's last jenkins run. That build was failed because one test is trying to download/copy file and that failed. As per my understanding unit tests should not do any thing which are dependent on external environments failure. As those kind of failures are bound to happen. As when those happen we have to go and check why that is failed wasting some time to understand. So ultimately we are wasting lot of effort currently because of tests not properly written. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/793 @rhtyd Rebased the branch to latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/793 @serg38 That case is already handled. Issue arises if management server goes down then we didn't get chance to clean things up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #793: CLOUDSTACK-8827: Move the VM snapshots stuck i...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #793: CLOUDSTACK-8827: Move the VM snapshots stuck i...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/793 CLOUDSTACK-8827: Move the VM snapshots stuck in transitional states to stable states during managment server restart i.e. If snapshot in creating state move it to Error state and if it is in reverting state move it to Ready state. Manual tests performed Take VM snapshot of VM stop the management server Verify in DB that VM snapshot is in creating state Start the management server Verify that snapshot moves to ERROR state. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8827 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/793.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #793 commit 656e855792737318b7bb5c84eea7a2a30eb6ad71 Author: Anshul Gangwar Date: 2015-09-09T08:51:15Z CLOUDSTACK-8827: Move the VM snapshots stuck in transitional states to stable state during managment server restart i.e. If snapshot in creating state move it to Error state and if it is in reverting state move it to Ready state. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r104846603
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCopyFileInVmCommandWrapper.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package com.cloud.hypervisor.kvm.resource.wrapper;
+
+import com.cloud.agent.api.Answer;
+import com.cloud.agent.api.CopyFileInVmAnswer;
+import com.cloud.agent.api.CopyFileInVmCommand;
+import com.cloud.hypervisor.kvm.resource.LibvirtComputingResource;
+import com.cloud.resource.CommandWrapper;
+import com.cloud.resource.ResourceWrapper;
+import com.cloud.utils.ssh.SshHelper;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.filefilter.TrueFileFilter;
+import org.apache.log4j.Logger;
+
+import java.io.File;
+
+@ResourceWrapper(handles = CopyFileInVmCommand.class)
+public class LibvirtCopyFileInVmCommandWrapper extends
CommandWrapper {
+
+private static final Logger s_logger =
Logger.getLogger(LibvirtCopyFileInVmCommandWrapper.class);
+
+@Override public Answer execute(CopyFileInVmCommand cmd,
LibvirtComputingResource libvirtComputingResource) {
+final File keyFile = new File("/root/.ssh/id_rsa.cloud");
+try {
+File file = new File(cmd.getSrc());
--- End diff --
@rafaelweingartner No, that's not the case. Some hypervisors copy through
hypervisor and some directly copies to system vm. Also can you give example how
all this can be achieved through common code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rafaelweingartner, Yes we can agree on those changes. But with additional description when the CallContext.current().getCallingAccount() call is made then it is setting the proper context which is global in nature and passed automatically to next method calls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, Is it looking good to you now? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/803 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id in volume_store_ref table to newly created volume for migration You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8833 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/803.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #803 commit 42b89278e9386b8bc90e36fb600d7730e676ae72 Author: Anshul Gangwar Date: 2015-06-10T10:03:42Z CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id in volume_store_ref table to newly created volume for migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dyn...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/868 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dyn...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/868 CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type It fixes the bug https://issues.apache.org/jira/browse/CLOUDSTACK-8894. Steps: 1.Install and configure XenServer 6.5 with vGPU enabled . Enabled dynamic scaliing 2. Deploy VM using K160Q type windows 7 template with PV tools installaed and dynamic scaling enabled 3. Tried dynamic scaling with offering which has K180Q defined. Observation: 1. Currently vGPU resource dynamic scaling is not supported. But CloudStack returns success and updating the VM details with new offering details including new vGPU type. 2. But from Xenserver , There is no change with vGPU type and it remains with old vGPU type. This is not correct Expected Result: Dynamic scaling should be restricted when source/destination offering has vGPU type on a vGPU enabled VM You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8894 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/868.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #868 commit f9f0e50f3f3c92e31b50241ad97ed4199c1a2482 Author: Anshul Gangwar Date: 2015-09-22T06:14:11Z CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic scaling if new service offering has different vGPU type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1278
@rafaelweingartner, Basically CallContext.current().getCallingAccount(); is
setting the proper context which is later used. If you have observed in code
all the api calls have a similar call before proceeding further. One random
example:
```java
@ActionEvent(eventType = EventTypes.EVENT_VOLUME_UPLOAD, eventDescription
= "uploading volume", async = true)
public VolumeVO uploadVolume(UploadVolumeCmd cmd) throws
ResourceAllocationException {
Account caller = CallContext.current().getCallingAccount();
```
For more details refer
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Using+CallContext and
commits 7928963 and 11e1e58 which I have mentioned earlier.
Hopefully this clears your doubts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @GabrielBrascher @rafaelweingartner, Please go through deployment planner code. Deployment planner decides the VM placement and virtual router also goes through that. Deployment planners uses allocators and planners. In those planners and allocators you will find the admin account related checks as pointed out in one of my previous comment. My intent to point out those old commits of Calling context introduction was that with that introduction there is calling context is passed around implicit. Here the code changes are making sure that context gets changed to proper user. Hope this clears your doubt. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1845: CLOUDSTACK-9689: [Hyper-V] Fixed VM console i...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1845#discussion_r104339191
--- Diff:
services/console-proxy-rdp/rdpconsole/src/main/java/streamer/apr/AprSocketSource.java
---
@@ -103,44 +103,46 @@ public void poll(boolean block) {
if (verbose)
System.out.println("[" + this + "] INFO: Reading data from
stream.");
-// to unblock during reboot
-long startTime = System.currentTimeMillis();
// FIXME: If pull is destroyed or socket is closed, segfault
will happen here
-int actualLength = (block) ? // Blocking read
-Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset)
-: // Non-blocking read
-Socket.recvt(socket, buf.data, buf.offset,
buf.data.length - buf.offset, 500);
+int actualLength;
+if(block) {
+// Blocking read
+actualLength = Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset);
+} else {
+// non blocking read with 5 seconds timeout
+Socket.timeoutSet(socket, 500);
+actualLength = Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset);
--- End diff --
@ramkatru, Will try that and get back to you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1269: CLOUDSTACK-8867: Added retry logic to reconne...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1269 CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console It also improves handling of sessions to hypervisor in console proxy https://issues.apache.org/jira/browse/CLOUDSTACK-8867 To test: Try on XenServer setup as frequent disconnections are more common for XenServer. Try random key combinations on VM console and see after fix console access denied errors are less frequent. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8867-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1269.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1269 commit 79e6d9f3b8bb9ecc9a515c9e1c4a2b6969a8f94e Author: Anshul Gangwar Date: 2015-09-16T04:45:32Z CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console. It also improves handling of sessions to hypervisor in console proxy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1269: CLOUDSTACK-8867: Added retry logic to reconne...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, Actually I am restoring to old behaviour of 3.x release which got changed to current behaviour because of bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1865 @koushik-das, This method is there so that it only gets called when the call is made through 8096 port. Other parameters processing is done at common place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1868 @ustcweizhou, In my opinion we should not do that as that way we are giving them option of silently deploying VM on some host which he might not be aware of. As after specifying host he is expecting that VM will be deployed on that host. If he is ok with deploying VM on different host then he can try deploying VM in next attempt without specifying hostid. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1278: CLOUDSTACK-9198: Virtual router gets deployed...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1278 CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod While starting the router, send the user from the callingContext instead of defaulting to System user. https://issues.apache.org/jira/browse/CLOUDSTACK-9198 ## To test: Verify that Virtual Router is not getting deployed in disabled Pod. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9198 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1278.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1278 commit d3594526294601bcfda01415f370f4bc0e71e910 Author: Anshul Gangwar Date: 2015-11-02T08:28:44Z CLOUDSTACK-9198: Virtual router gets deployed in disabled Pod. While starting the router, send the user from the callingContext instead of defaulting to System user --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1278: CLOUDSTACK-9198: Virtual router gets deployed...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek @koushik-das That change is intentional to allow admin users to deploy VM on disabled. Ticket which shows that it is intentional https://issues.apache.org/jira/browse/CLOUDSTACK-7047. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek #1860 should take care of last host id scenario. Other case of user specifying host, should we not allow deploying VM in disabled Pod? That's a separate issue by the way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue:
https://github.com/apache/cloudstack/pull/1278
@abhinandanprateek, Yes they are using same deployment planner. But VR was
getting created in disabled Pod but not regular VM because for VR deployment
system user context was getting set. In planner checks are not done/skipped for
system user. So if you observe here fix is to use user from calling context
instead of system user. Hope this clears your doubt.
One such example:
`if (!isRootAdmin(vmProfile)) {
List disabledPods =
listDisabledPods(plan.getDataCenterId());
if (!disabledPods.isEmpty()) {
if (s_logger.isDebugEnabled()) {
s_logger.debug("Removing from the podId list these
pods that are disabled: " + disabledPods);
}
podsWithCapacity.removeAll(disabledPods);
}
}`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @abhinandanprateek, That's the behaviour we disallow VM to be deployed in disabled Pod. But Virtual router was getting deployed as it was getting called through system user for which we allow deployment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1278 @rhtyd , Rebased against laster master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1269 @rhtyd , Rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #868: CLOUDSTACK-8894: Restrict vGPU enabled VMs dynamic sc...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/868 @rhtyd, Rebased against latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #803: CLOUDSTACK-8833: Fixed Generating url and migrate vol...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/803 @rhtyd Rebased against latest master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1977: fixed the merge conflict on merging #1941
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1977 LGTM. This change occurs due to code around that are gets diverged in master and 4.9 with merge of PR #1727. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @karuturi, We can merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @GabrielBrascher, Those tests failure are not related to this PR and seems to be failing most of the time and reported as intermittent failures. @rhtyd @karuturi @serg38, We have already run tests twice, Do we still need to re run? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @koushik-das, That PR is still not merged. @karuturi @rhtyd This PR has LGTM now. Can we merge it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #803: CLOUDSTACK-8833: Fixed Generating url and migr...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/803 CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id in volume_store_ref table to newly created volume for migration You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8833 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/803.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #803 commit 493f5818aaddfe96570ee2ebe1d52f8de447d7b5 Author: Anshul Gangwar Date: 2015-06-10T10:03:42Z CLOUDSTACK-8833: Fixed Generating url and migrate volume to another storage , resulting two entry in UI and listvolume is not working for that volume Update the volume id in volume_store_ref table to newly created volume for migration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @sureshanaparti, Can you have a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1867 CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thre⦠â¦ad if they are failed to cleanup during DeleteSnapshot command You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9706 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1867.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1867 commit 1c04b30143c84cd4c5fabf9467d2509e78b49f06 Author: Anshul Gangwar Date: 2016-05-09T07:15:31Z CLOUDSTACK-9706: Added snapshots cleanup in start and storage GC thread if they are failed to cleanup during DeleteSnapshot command --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #672: Allow VM snapshots and volume snapshots to exi...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 Added the missing license on one js file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1900 @karuturi @koushik-das @sateesh-chodapuneedi , I had analysed those failures and working on how to go about those. Issue here is that there are marvin tests which are for something which was never working. But nobody has reported any bugs for that. When we create VM without starting it(startvm=false), then there are issues. So in this scenario if we try to attach the uploaded volume then its failing in this PR. But in existing code it is passing successfully i.e. DB entries are created. Now when we start the VM then we are doing nothing for uploaded Volume and they always remains in uploaded state and not attached to VM on hypervisor. This marvin test is there for ages but nobody has reported any issue regarding this. So I am currently analysing how to go about this. Is this even used by Users? Because if they were using this then somebody should have reported this as this was introduced some five years back. I am thinking of simple solution which would be to inform user that they have to start vm first (root volume created) before trying to attach volume. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi, Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 Ok, Doing that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi Test failing is unrelated to this PR. === TestName: test_add_user_to_project | Status : EXCEPTION === === TestName: test_add_user_to_project | Status : EXCEPTION === Test failing in travis is | ContextSuite con | exceptions.Excep | 36.025 | test_project_lim | | text=TestResourc | tion | | its | | eLimitsProject>: | | | | | teardown --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @nvazquez , Added the marvin test from #1735. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez, Yeah I am fine with it. I will add the test from your PR to mine PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @rhtyd That test is failing during cleanup to delete the template but there is no such change in PR which will come into picture while deletion of template. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1900 Rebased with current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier https://issues.apache.org/jira/browse/CLOUDSTACK-8665 This branch has implemented following improvements in console proxy keyboard language support 1) ajaxviewer.js and ajaxkeys.js are main files involved in key code translations. These files now can be copied in systemvm/js folder and they will be copied to CPVM with stop/start performed on it. 2) Started passing parameters to CPVM needed to resolve the ambiguous cases of keycode translations. 3) Generalise the framework such that one needs to modify only ajaxkeys.js (file which has keycode mappings) without need of much knowledge in js. FS for this feature is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy After these changes how to add keyboard support for new language or fix existing broken keys WIP document is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Adding+support+for+non-US+Keyboard+for+Console+Proxy You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 nonuskeyboardsupport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #669 commit 31e12325e715420536ee3215e312474be1b258a5 Author: Anshul Gangwar Date: 2015-08-04T04:54:16Z CLOUDSTACK-8665: Added following improvements: 1. Added support for copying js files from management server to console proxy VM with stop start 2. Generalise console keyboard support framework 3. Passing additional parameters which will be needed for keyboard mappings for vm console 4. Moved the console Keyboard Options to new file so that user can add keyboard options easily 5. Improved memory footprint, now keeping only required locale mappings 6. Added more conditions while setting up translation table 7. Improved browser detection for keyboard mappings 8. Formatted ajaxviewer.js and ajaxkeys.js with spaces instead of tabs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez What would you like to do? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r101232184
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -3520,27 +3520,17 @@ public UserVmVO doInTransaction(TransactionStatus
status) throws InsufficientCap
}
rootDiskSize =
Long.parseLong(customParameters.get("rootdisksize"));
-// only KVM supports rootdisksize override
-if (hypervisorType != HypervisorType.KVM) {
--- End diff --
@pdube There was no resource layer code available for XS for this and root
volume resize was only implemented for KVM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1813#discussion_r101231917
--- Diff:
plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixRequestWrapperTest.java
---
@@ -436,7 +436,7 @@ public void testResizeVolumeCommand() {
final Answer answer = wrapper.execute(resizeCommand,
citrixResourceBase);
verify(citrixResourceBase, times(1)).getConnection();
-assertFalse(answer.getResult());
+//assertFalse(answer.getResult());
--- End diff --
@pdube That test is flawed as it always expects that command to fail. Till
now it was working fine as it was always resizing which results in xapi command
failure. But now since there is check for resize only in case of increase of
volume size then the test is failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 @rhtyd @karuturi Should I close this PR then? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 @rhtyd @karuturi @syed Raised #1941 against 4.9. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1941 CLOUDSTACK-8663: Fixed various issues to allow VM snapshots and volume snapshots to exist together Reverting VM to disk only snapshot in Xenserver corrupts VM Stale NFS secondary storage on XS leads to volume creation failure from snapshot Fixed various concerns raised in #672 You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8663 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1941 commit ca84fd4ffd5d80aef9c7624365d29d7b2aeb3225 Author: Anshul Gangwar Date: 2015-07-24T09:15:20Z CLOUDSTACK-8663: Fixed various issues to allow VM snapshots and volume snapshots to exist together Reverting VM to disk only snapshot in Xenserver corrupts VM Stale NFS secondary storage on XS leads to volume creation failure from snapshot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 Resolving conflicts and rebasing the PR against 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #672: Allow VM snapshots and volume snapshots to exist toge...
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/672 @karuturi @rhtyd @syed PR #1829 is subset of this PR i.e. that contains the same fix as one commit of this PR. How to proceed with that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #669: Made the adding new keyboard language support ...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/669 Made the adding new keyboard language support easier https://issues.apache.org/jira/browse/CLOUDSTACK-8665 This branch has implemented following improvements in console proxy keyboard language support 1) ajaxviewer.js and ajaxkeys.js are main files involved in key code translations. These files now can be copied in systemvm/js folder and they will be copied to CPVM with stop/start performed on it. 2) Started passing parameters to CPVM needed to resolve the ambiguous cases of keycode translations. 3) Generalise the framework such that one needs to modify only ajaxkeys.js (file which has keycode mappings) without need of much knowledge in js. FS for this feature is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Support+for+non-US+keyboards+in+Console+Proxy After these changes how to add keyboard support for new language or fix existing broken keys WIP document is available at https://cwiki.apache.org/confluence/display/CLOUDSTACK/Adding+support+for+non-US+Keyboard+for+Console+Proxy You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 nonuskeyboardsupport Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #669 commit 31e12325e715420536ee3215e312474be1b258a5 Author: Anshul Gangwar Date: 2015-08-04T04:54:16Z CLOUDSTACK-8665: Added following improvements: 1. Added support for copying js files from management server to console proxy VM with stop start 2. Generalise console keyboard support framework 3. Passing additional parameters which will be needed for keyboard mappings for vm console 4. Moved the console Keyboard Options to new file so that user can add keyboard options easily 5. Improved memory footprint, now keeping only required locale mappings 6. Added more conditions while setting up translation table 7. Improved browser detection for keyboard mappings 8. Formatted ajaxviewer.js and ajaxkeys.js with spaces instead of tabs --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1900 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1900 CLOUDSTACK-8862: Introduced new state attaching for volume. This will⦠⦠make sure that other attach operation on same volume will fail gracefully without calling access calls for managed storage like SolidFire You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1900.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1900 commit 40d1a82bd9b7e799f269fcfbdfc4ec5923c189b2 Author: Anshul Gangwar Date: 2017-01-10T11:40:28Z CLOUDSTACK-8862: Introduced new state attaching for volume. This will make sure that other attach operation on same volume will fail gracefully without calling access calls for managed storage like SolidFire --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1900: CLOUDSTACK-8862: Introduced new state attachi...
GitHub user anshul1886 reopened a pull request: https://github.com/apache/cloudstack/pull/1900 CLOUDSTACK-8862: Introduced new state attaching for volume. This will⦠⦠make sure that other attach operation on same volume will fail gracefully without calling access calls for managed storage like SolidFire You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-8862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1900.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1900 commit 40d1a82bd9b7e799f269fcfbdfc4ec5923c189b2 Author: Anshul Gangwar Date: 2017-01-10T11:40:28Z CLOUDSTACK-8862: Introduced new state attaching for volume. This will make sure that other attach operation on same volume will fail gracefully without calling access calls for managed storage like SolidFire --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
