[GitHub] cloudstack pull request: Remove AWS api bridge
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/44 Remove AWS api bridge This has been a discussion point for a while. The (mostly generated) code for the AWS api bridge is by far the largest source component in Cloudstack, while seldomly used. Now that alternate options exist to provide EC2 compatibility, it makes sense to remove it for the few users who cannot directly talk to the cloudstack API. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pyr/cloudstack feature/no-dead-code Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/44.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #44 commit 84042f2c3259203b1ea1956cd239b9122079bae9 Author: Pierre-Yves Ritschard Date: 2014-11-21T10:17:18Z Remove AWS api bridge This has been a discussion point for a while. The (mostly generated) code for the AWS api bridge is by far the largest source component in Cloudstack, while seldomly used. Now that alternate options exist to provide EC2 compatibility, it makes sense to remove it for the few users who cannot directly talk to the cloudstack API. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove AWS api bridge
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/44#issuecomment-65030920 closing this since a new branch has been created by @runseb --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Remove AWS api bridge
Github user pyr closed the pull request at: https://github.com/apache/cloudstack/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/65 Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full rationale. You can merge this pull request into a Git repository by running: $ git pull https://github.com/exoscale/cloudstack feature/constant-time Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 commit 9b4e39e837af498599859c4a6687eb8bf9f8ad89 Author: Pierre-Yves Ritschard Date: 2015-01-14T10:27:35Z Use constant-time comparison functions when checking signatures This limits the likeliness of timing attacks against the API. See http://codahale.com/a-lesson-in-timing-attacks/ for the full rationale. Conflicts: server/src/com/cloud/api/ApiServer.java server/src/com/cloud/user/AccountManagerImpl.java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user pyr commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/65#discussion_r22930247
--- Diff: server/src/com/cloud/api/ConstantTimeComparator.java ---
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.api;
+
+public class ConstantTimeComparator {
+
+public static boolean compareBytes(byte[] b1, byte[] b2) {
+if (b1.length != b2.length) {
+return false;
+}
+
+int result = 0;
+for (int i = 0; i < b1.length; i++) {
+result |= b1[i] ^ b2[i];
--- End diff --
Agreed, updated accordingly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Use constant-time comparison functions wh...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/65#issuecomment-69926943 thanks @bhaisaab --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Support all pythons from 2.6 up.
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/89 Support all pythons from 2.6 up. These small changes allow the build to succeed on all versions of python from 2.6 up (2.5 will break). This covers all serious candidate platforms for running cloudstack. You can merge this pull request into a Git repository by running: $ git pull https://github.com/exoscale/cloudstack fix/python-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 commit d5e3d4911dbb2d7620cf3d30ae780336ab7c9496 Author: Pierre-Yves Ritschard Date: 2015-02-27T08:26:13Z Support all pythons from 2.6 up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack/pull/109 Add Apache Kafka event-bus support - producing only. This commit produces event bus messages to a "cloudstack" topic in Apache Kafka. Configuration is expected to be found in /etc/cloudstack/management/kafka.producer.properties and will generally be of the form: bootstrap.servers=kafka-host1:9092,kafka-host2:9092 key.serializer=org.apache.kafka.common.serialization.StringSerializer value.serializer=org.apache.kafka.common.serialization.StringSerializer There is no way to parameterize the topic yet, and the consuming code is just place-holder. I think adding a consumer within cloudstack is very debatable and likely not needed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/exoscale/cloudstack feature/event-bus-kafka Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/109.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #109 commit af369274dc6fc1941d5bd90baf77a3b076f002cf Author: Pierre-Yves Ritschard Date: 2015-03-10T22:25:21Z Add Apache Kafka event-bus support - producing only. This commit produces event bus messages to a "cloudstack" topic in Apache Kafka. Configuration is expected to be found in /etc/cloudstack/management/kafka.producer.properties and will generally be of the form: bootstrap.servers=kafka-host1:9092,kafka-host2:9092 key.serializer=org.apache.kafka.common.serialization.StringSerializer value.serializer=org.apache.kafka.common.serialization.StringSerializer There is no way to parameterize the topic yet, and the consuming code is just place-holder. I think adding a consumer within cloudstack is very debatable and likely not needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...
Github user pyr commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/109#discussion_r26194042 --- Diff: plugins/event-bus/kafka/pom.xml --- @@ -0,0 +1,45 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + cloud-mom-kafka + Apache CloudStack Plugin - Kafka Event Bus + +org.apache.cloudstack +cloudstack-plugins +4.4.2 --- End diff -- will do, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78219876 @bhaisaab the producer has a thread which handles this and knows what broker is responsible for what partition, it maintains its own internal broker topology, so there is no additional code needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78220517 @bhaisaab I made the topic configurable and provided some more explanation in the PR description. Thanks for the review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78245063 @bhaisaab yes, where is the repo ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack-docs-admin pull request: Document Kafka event bus
GitHub user pyr opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/28 Document Kafka event bus You can merge this pull request into a Git repository by running: $ git pull https://github.com/pyr/cloudstack-docs-admin feature/event-bus-kafka Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack-docs-admin/pull/28.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #28 commit f59d1cc6db65cb758fd40e61bdcad4da4f1c64d1 Author: Pierre-Yves Ritschard Date: 2015-03-11T12:13:05Z Document Kafka event bus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: Add Apache Kafka event-bus support - prod...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/109#issuecomment-78251684 @bhaisaab now in apache/cloudstack-docs-admin#28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-213593763 First read-through didn't raise any eyebrows on my end. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: README: happy holidays!
Github user pyr commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166830690 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
