[GitHub] cloudstack issue #1855: CLOUDSTACK-9697: Better error message in UI if user ...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1855 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1868: CLOUDSTACK-9707: While using hostid parameter, vm ge...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1868 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1997 @jayapalu, Please see Daan's and Wido's comments on the referenced PR #1307. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1845: CLOUDSTACK-9689: [Hyper-V] Fixed VM console i...
Github user ramkatru commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1845#discussion_r104242930
--- Diff:
services/console-proxy-rdp/rdpconsole/src/main/java/streamer/apr/AprSocketSource.java
---
@@ -103,44 +103,46 @@ public void poll(boolean block) {
if (verbose)
System.out.println("[" + this + "] INFO: Reading data from
stream.");
-// to unblock during reboot
-long startTime = System.currentTimeMillis();
// FIXME: If pull is destroyed or socket is closed, segfault
will happen here
-int actualLength = (block) ? // Blocking read
-Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset)
-: // Non-blocking read
-Socket.recvt(socket, buf.data, buf.offset,
buf.data.length - buf.offset, 500);
+int actualLength;
+if(block) {
+// Blocking read
+actualLength = Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset);
+} else {
+// non blocking read with 5 seconds timeout
+Socket.timeoutSet(socket, 500);
+actualLength = Socket.recv(socket, buf.data, buf.offset,
buf.data.length - buf.offset);
--- End diff --
@anshul1886 can you please verify if timeout can be set on a socket that is
not opened with APR_SO_NONBLOCK flag?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1865 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1900: CLOUDSTACK-8862: Introduced new state attaching for ...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1900 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #847: Bug-ID: CLOUDSTACK-8880: calculate free memory on hos...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/847 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1774 @priyankparihar please check the test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1897 @sureshanaparti, please look into these failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...
Github user ramkatru commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1922#discussion_r101983289
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final
VirtualRouter router, final
sourceNatIpAdd = new Pair(ip,
ipAddr.getNetworkId());
addSourceNat = add;
}
+
+if (!firstIP || add) {
+firstIP = false;
+}
--- End diff --
Please add a comment explaining this. Not very readable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
