Review Request 13499: [GSoC] Add staticNat support to GRE controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13499/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I make a patch for supporting staticNat service to gre controller. The scenario is: + use GRE isolation method + create a network offering with staticNat,Connectivity (Ovs) and sourceNat,...(VirtualRouter) + create a guest network using the above network offering + deploy VM, enable staticNat Diffs - plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2 plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324 plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 3824669 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15 plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48 plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6 plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8 server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 Diff: https://reviews.apache.org/r/13499/diff/ Testing --- Test done with above scenario. Deploy VMs. enable/disable staticNat. Thanks, tuna
Review Request 14167: [GSoC] Adding LB, PF service to GRE controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I add a final patch for supporting L3 services (staticNAT, PortForwarding, LoadBalancing) to GRE controller Diffs - api/src/com/cloud/network/Network.java aea496d api/src/com/cloud/network/Networks.java 5aede05 api/src/org/apache/cloudstack/api/ResponseGenerator.java b8ecef3 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 9741763 plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 3824669 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java 6ad6e83 scripts/vm/hypervisor/xenserver/ovstunnel 2b26ed6 server/src/com/cloud/network/NetworkModelImpl.java d7ca639 server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 ui/scripts/system.js 18c3df4 Diff: https://reviews.apache.org/r/14167/diff/ Testing --- Testing done. I will make a screencast demo asap. Thanks, tuna
Review Request 14168: [GSoC] Ading KVM support for GRE controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14168/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I add a patch about adding KVM support for GRE controller. This patch will enable GRE working on KVM hypervisor Diffs - plugins/hypervisors/kvm/pom.xml 1babe7c plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 914017c scripts/vm/hypervisor/kvm/cloudstack_pluginlib.py PRE-CREATION scripts/vm/network/vnet/ovstunnel.py PRE-CREATION Diff: https://reviews.apache.org/r/14168/diff/ Testing --- Testing done. I will make a screencast demo asap Thanks, tuna
Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/#review26170 --- api/src/com/cloud/network/Networks.java <https://reviews.apache.org/r/14167/#comment51133> Yes, I'm basing on an unofficial 4.1 version. Will rebase! plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java <https://reviews.apache.org/r/14167/#comment51134> yes, sure plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java <https://reviews.apache.org/r/14167/#comment51137> yes, sure server/src/com/cloud/network/NetworkModelImpl.java <https://reviews.apache.org/r/14167/#comment51135> sure server/src/com/cloud/network/element/VirtualRouterElement.java <https://reviews.apache.org/r/14167/#comment51136> will do - tuna On Sept. 17, 2013, 3:03 a.m., tuna wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14167/ > --- > > (Updated Sept. 17, 2013, 3:03 a.m.) > > > Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > --- > > I add a final patch for supporting L3 services (staticNAT, PortForwarding, > LoadBalancing) to GRE controller > > > Diffs > - > > api/src/com/cloud/network/Network.java aea496d > api/src/com/cloud/network/Networks.java 5aede05 > api/src/org/apache/cloudstack/api/ResponseGenerator.java b8ecef3 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 9741763 > plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java > 3824669 > > plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java > 6ad6e83 > scripts/vm/hypervisor/xenserver/ovstunnel 2b26ed6 > server/src/com/cloud/network/NetworkModelImpl.java d7ca639 > server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 > ui/scripts/system.js 18c3df4 > > Diff: https://reviews.apache.org/r/14167/diff/ > > > Testing > --- > > Testing done. I will make a screencast demo asap. > > > Thanks, > > tuna > >
Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller
On Sept. 17, 2013, 8:24 a.m., tuna wrote: > > Do you have any (unit-)tests or #!human test scenarios to validate your > > code? I haven't made unit tests yet. Will do asap. Just try with my own scenarios. - tuna --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/#review26169 --- On Sept. 17, 2013, 3:03 a.m., tuna wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14167/ > --- > > (Updated Sept. 17, 2013, 3:03 a.m.) > > > Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > --- > > I add a final patch for supporting L3 services (staticNAT, PortForwarding, > LoadBalancing) to GRE controller > > > Diffs > - > > api/src/com/cloud/network/Network.java aea496d > api/src/com/cloud/network/Networks.java 5aede05 > api/src/org/apache/cloudstack/api/ResponseGenerator.java b8ecef3 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 9741763 > plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java > 3824669 > > plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java > 6ad6e83 > scripts/vm/hypervisor/xenserver/ovstunnel 2b26ed6 > server/src/com/cloud/network/NetworkModelImpl.java d7ca639 > server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 > ui/scripts/system.js 18c3df4 > > Diff: https://reviews.apache.org/r/14167/diff/ > > > Testing > --- > > Testing done. I will make a screencast demo asap. > > > Thanks, > > tuna > >
Re: Review Request 14167: [GSoC] Adding LB, PF service to GRE controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14167/ --- (Updated Sept. 17, 2013, 10:03 a.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Changes --- The update patch aim to remove commented code and old files Repository: cloudstack-git Description --- I add a final patch for supporting L3 services (staticNAT, PortForwarding, LoadBalancing) to GRE controller Diffs (updated) - api/src/com/cloud/network/Network.java aea496d api/src/com/cloud/network/Networks.java 5aede05 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 9741763 plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2 plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324 plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 3824669 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java 6ad6e83 plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48 plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6 plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8 server/src/com/cloud/network/NetworkModelImpl.java d7ca639 server/src/com/cloud/network/element/VirtualRouterElement.java ecf6473 ui/scripts/system.js 18c3df4 Diff: https://reviews.apache.org/r/14167/diff/ Testing --- Testing done. I will make a screencast demo asap. Thanks, tuna
Review Request 14628: AutoScaling without NetScaler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14628/ --- Review request for cloudstack and Sebastien Goasguen. Repository: cloudstack-git Description --- I made a patch to add autoscale feature without Netscaler. Requirement: - Xenserver or XCP - Template with pre-installed PVdriver - don't use SNMP or NetScaler counters when configuring AutoScale - AutoScale acts within a Cluster All configuration parameters (durations, interval, destroy_vm_grace_period, quiet_time) are kept as normal. Diffs - api/src/com/cloud/network/as/AutoScaleCounter.java ca7b65a39d4c063029293da1e1eb6832c11425a7 api/src/com/cloud/network/as/AutoScalePolicy.java 7f94f355921bba1ce149ff44f60a5c0e9a5cde28 api/src/com/cloud/network/as/AutoScaleVmGroup.java faa166d2baeb9e49cc064cf9da802a8e56219e00 api/src/com/cloud/network/as/Counter.java 207ec57b5920ad0a28088f37b1c3d5bb59c916fc client/tomcatconf/applicationContext.xml.in 6dda5c707afddd1c20c97cb9a553590730682db3 core/src/com/cloud/agent/api/PerformanceMonitorAnswer.java PRE-CREATION core/src/com/cloud/agent/api/PerformanceMonitorCommand.java PRE-CREATION engine/schema/src/com/cloud/network/as/AutoScalePolicyVO.java f8fbcb483f52ddba3528e2f10644a7322716ce71 engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVO.java d1d85f9e2932f5ce5347e0b0be25af31a5f07066 engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVmMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/as/CounterVO.java b7b03f716b09c8600f8587b3c47124e228d643bb engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMapDao.java 30251984807f9556e8856b1a987ea01ca914a26b engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMapDaoImpl.java 00fee3db6c7e6ee6ab7493d38060267b78fd4ebb engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java PRE-CREATION plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 92fbab28bd24a115d6e933d58ab94390e357c9f7 scripts/vm/hypervisor/xenserver/perfmon.py PRE-CREATION scripts/vm/hypervisor/xenserver/vmopspremium 38ec2e8c1d8d4dfc9bf60df94bf9412d877d128e server/src/com/cloud/network/as/AutoScaleManager.java 5b84b30d74415b7d3c278b6c2dd78fb39bea3668 server/src/com/cloud/network/as/AutoScaleManagerImpl.java 859211bd572a8a0d56ae6fd154788944db58fb24 server/src/com/cloud/network/element/VirtualRouterElement.java 0cd3bcf6db05eddb5f6dfdd3e747d509d84c1164 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java c685ee3e40ba1f1f597d25864957c0f04bea7825 server/src/com/cloud/server/StatsCollector.java b4ec9155faf829dd6da14d9aeb79fefb0a257db1 setup/db/create-schema.sql 79550aee1bb53b9a707eb56911a3186f3475a5d9 setup/db/db/schema-40to410.sql 24f6d4c5e1942232695279ce4dd926e591c4fcd0 Diff: https://reviews.apache.org/r/14628/diff/ Testing --- Testing done with some simple scenario. Need help in testing units. Thanks, tuna
Re: Review Request 14628: AutoScaling without NetScaler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14628/ --- (Updated Oct. 15, 2013, 11:20 a.m.) Review request for cloudstack and Sebastien Goasguen. Changes --- fix issues Repository: cloudstack-git Description --- I made a patch to add autoscale feature without Netscaler. Requirement: - Xenserver or XCP - Template with pre-installed PVdriver - don't use SNMP or NetScaler counters when configuring AutoScale - AutoScale acts within a Cluster All configuration parameters (durations, interval, destroy_vm_grace_period, quiet_time) are kept as normal. Diffs (updated) - api/src/com/cloud/network/as/AutoScaleCounter.java ca7b65a39d4c063029293da1e1eb6832c11425a7 api/src/com/cloud/network/as/AutoScalePolicy.java 7f94f355921bba1ce149ff44f60a5c0e9a5cde28 api/src/com/cloud/network/as/AutoScaleVmGroup.java faa166d2baeb9e49cc064cf9da802a8e56219e00 api/src/com/cloud/network/as/Counter.java 207ec57b5920ad0a28088f37b1c3d5bb59c916fc client/tomcatconf/applicationContext.xml.in 6dda5c707afddd1c20c97cb9a553590730682db3 core/src/com/cloud/agent/api/PerformanceMonitorAnswer.java PRE-CREATION core/src/com/cloud/agent/api/PerformanceMonitorCommand.java PRE-CREATION engine/schema/src/com/cloud/network/as/AutoScalePolicyVO.java f8fbcb483f52ddba3528e2f10644a7322716ce71 engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVO.java d1d85f9e2932f5ce5347e0b0be25af31a5f07066 engine/schema/src/com/cloud/network/as/AutoScaleVmGroupVmMapVO.java PRE-CREATION engine/schema/src/com/cloud/network/as/CounterVO.java b7b03f716b09c8600f8587b3c47124e228d643bb engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMapDao.java 30251984807f9556e8856b1a987ea01ca914a26b engine/schema/src/com/cloud/network/as/dao/AutoScalePolicyConditionMapDaoImpl.java 00fee3db6c7e6ee6ab7493d38060267b78fd4ebb engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDao.java PRE-CREATION engine/schema/src/com/cloud/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java PRE-CREATION plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 92fbab28bd24a115d6e933d58ab94390e357c9f7 scripts/vm/hypervisor/xenserver/perfmon.py PRE-CREATION scripts/vm/hypervisor/xenserver/vmopspremium 38ec2e8c1d8d4dfc9bf60df94bf9412d877d128e server/src/com/cloud/network/as/AutoScaleManager.java 5b84b30d74415b7d3c278b6c2dd78fb39bea3668 server/src/com/cloud/network/as/AutoScaleManagerImpl.java 859211bd572a8a0d56ae6fd154788944db58fb24 server/src/com/cloud/network/element/VirtualRouterElement.java 0cd3bcf6db05eddb5f6dfdd3e747d509d84c1164 server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java c685ee3e40ba1f1f597d25864957c0f04bea7825 server/src/com/cloud/server/StatsCollector.java b4ec9155faf829dd6da14d9aeb79fefb0a257db1 server/src/com/cloud/vm/UserVmManagerImpl.java 6e879161276920c6baf6194fe8a73acec0dd0964 setup/db/create-schema.sql 79550aee1bb53b9a707eb56911a3186f3475a5d9 setup/db/db/schema-40to410.sql 24f6d4c5e1942232695279ce4dd926e591c4fcd0 Diff: https://reviews.apache.org/r/14628/diff/ Testing --- Testing done with some simple scenario. Need help in testing units. Thanks, tuna
Review Request: Add docbook of GSOC native SDN controller proposal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11678/ --- Review request for cloudstack. Description --- This is the docbook for my GSOC project: "Add Xen/XCP support for native GRE SDN controller" Diffs - docs/en-US/gsoc-tuna.xml 68032a8 Diff: https://reviews.apache.org/r/11678/diff/ Testing --- The added xml file was build with publican successfully. Thanks, tuna
Re: Review Request 12445: Making sdn gre work with XCP 1.6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12445/ --- (Updated July 10, 2013, 3:31 p.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- This patch makes sdn gre work with XCP 1.6. Users still can follow the old strategy described in this post: https://cwiki.apache.org/CLOUDSTACK/ovs-tunnel-manager-for-cloudstack.html. Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-1779 Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java d6d0523 scripts/vm/hypervisor/xenserver/ovstunnel ddcaa5b scripts/vm/hypervisor/xenserver/xcposs/patch 4d07c76 scripts/vm/hypervisor/xenserver/xcpserver/patch 7e92d5a scripts/vm/hypervisor/xenserver/xenserver56/patch 8abd6b2 scripts/vm/hypervisor/xenserver/xenserver56fp1/patch 901f6de Diff: https://reviews.apache.org/r/12445/diff/ Testing --- Thanks, tuna
Re: Review Request 12445: Making sdn gre work with XCP 1.6
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12445/ --- (Updated July 12, 2013, 4:12 a.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Changes --- I updated fixing whitespace to the patch Repository: cloudstack-git Description --- This patch makes sdn gre work with XCP 1.6. Users still can follow the old strategy described in this post: https://cwiki.apache.org/CLOUDSTACK/ovs-tunnel-manager-for-cloudstack.html. Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-1779 Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java d6d0523 scripts/vm/hypervisor/xenserver/ovstunnel ddcaa5b scripts/vm/hypervisor/xenserver/xcposs/patch 4d07c76 scripts/vm/hypervisor/xenserver/xcpserver/patch 7e92d5a scripts/vm/hypervisor/xenserver/xenserver56/patch 8abd6b2 scripts/vm/hypervisor/xenserver/xenserver56fp1/patch 901f6de Diff: https://reviews.apache.org/r/12445/diff/ Testing --- File Attachments (updated) Fix whitespace https://reviews.apache.org/media/uploaded/files/2013/07/12/sdn1_1.patch Thanks, tuna
Review Request 12505: fix white-space
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12505/ --- Review request for cloudstack and Sebastien Goasguen. Repository: cloudstack-git Description --- i fixed white-space at my first patch. Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java cda5711 scripts/vm/hypervisor/xenserver/ovstunnel 9a89630 Diff: https://reviews.apache.org/r/12505/diff/ Testing --- Thanks, tuna
Review Request 12534: [GSOC][Database] Adding two new tables for the external ovs controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12534/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I added two new tables for the external ovs controller. ovs_devices: refers to controllers ovs_nic_mapping: refers to logical switches and logical ports (correspond to VM's nic) on the controllers Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java cda5711 plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingDao.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingDaoImpl.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingVO.java PRE-CREATION scripts/vm/hypervisor/xenserver/ovstunnel 9a89630 setup/db/create-schema.sql 79550ae Diff: https://reviews.apache.org/r/12534/diff/ Testing --- Build done with no errors. Thanks, tuna
Re: Review Request 12534: [GSOC][Database] Adding two new tables for the external ovs controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12534/ --- (Updated July 13, 2013, 10:02 a.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I added two new tables for the external ovs controller. ovs_devices: refers to controllers ovs_nic_mapping: refers to logical switches and logical ports (correspond to VM's nic) on the controllers Diffs - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java cda5711 plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingDao.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingDaoImpl.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingVO.java PRE-CREATION scripts/vm/hypervisor/xenserver/ovstunnel 9a89630 setup/db/create-schema.sql 79550ae Diff: https://reviews.apache.org/r/12534/diff/ Testing --- Build done with no errors. Thanks, tuna
Review Request 12644: [GSOC][database] Add two tables for gre controller.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12644/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- Diffs - plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingDao.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingDaoImpl.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsNicMappingVO.java PRE-CREATION Diff: https://reviews.apache.org/r/12644/diff/ Testing --- Build done with no errors. Thanks, tuna
Review Request 12674: [GSoC] Re-factor gre sdn controller prototype
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12674/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I created a prototype for re-factoring the gre sdn controller. Diffs - api/src/com/cloud/event/EventTypes.java ed4ba12 api/src/org/apache/cloudstack/api/ApiConstants.java 83999b6 client/tomcatconf/applicationContext.xml.in 610fdfd client/tomcatconf/commands.properties.in f4b41a7 plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 40be5ff plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java PRE-CREATION setup/db/create-schema.sql 79550ae Diff: https://reviews.apache.org/r/12674/diff/ Testing --- Built successfully with sdnextensions branch Thanks, tuna
Review Request 12941: [GSoC] refactor gre controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I made an update to refactor gre controller: + remove ovs_devices table, because we'll have an ODL plugin separately. + move command/answer to new package: com.cloud.agent.api + add Connectivity service checking + add new NetworkProvider: Ovs + add L3 services to Ovs Capabilities + add L3 services prototype code. Next step: + L3 services implement with VirtualRouter + ODL plugin Diffs - api/src/com/cloud/network/Network.java a06208b client/tomcatconf/applicationContext.xml.in 60f1e30 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521 plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/api/response/OvsDeviceResponse.java c0901b2 plugins/network-elements/ovs/src/com/cloud/network/commands/AddOvsDeviceCmd.java 1abc324 plugins/network-elements/ovs/src/com/cloud/network/commands/DeleteOvsDeviceCmd.java 87eedfb plugins/network-elements/ovs/src/com/cloud/network/commands/ListOvsDevicesCmd.java 2adb33a plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52 plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApi.java b533312 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsApiException.java 20603e0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelAnswer.java 5f0f8c1 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateGreTunnelCommand.java e2cd2d8 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelAnswer.java fc2eb8a plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsCreateTunnelCommand.java 1ececa0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDeleteFlowCommand.java 2a6d5d7 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyBridgeCommand.java 8be5586 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsDestroyTunnelCommand.java 4594d99 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceAnswer.java 1ee6606 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsFetchInterfaceCommand.java c27daf0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowAnswer.java ba16839 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetTagAndFlowCommand.java 17121a0 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsSetupBridgeCommand.java 29cce15 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac plugins/network-elements/ovs/src/com/cloud/network/ovs/StartupOvsCommand.java b85331e plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDao.java 794e45e plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceDaoImpl.java 11a4d48 plugins/network-elements/ovs/src/com/cloud/network/ovs/dao/OvsDeviceVO.java cab63f6 plugins/network-elements/ovs/src/com/cloud/network/resource/OvsResource.java a94e4f8 setup/db/create-schema.sql 143023a Diff: https://reviews.apache.org/r/12941/diff/ Testing --- Thanks, tuna
Review Request 12999: [GSoC] Add mid-term report
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12999/ --- Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Repository: cloudstack-git Description --- I add the mid-term report for my GSoC project Diffs - docs/en-US/gsoc-midsummer-nguyen.xml 96c2de1 docs/en-US/images/bean.png PRE-CREATION docs/en-US/images/canhandle.png PRE-CREATION docs/en-US/images/canhandledetail.png PRE-CREATION docs/en-US/images/component.png PRE-CREATION docs/en-US/images/configure_phase.png PRE-CREATION docs/en-US/images/getlabel.png PRE-CREATION docs/en-US/images/inject.png PRE-CREATION docs/en-US/images/l3_services.png PRE-CREATION docs/en-US/images/level.png PRE-CREATION docs/en-US/images/network_service.png PRE-CREATION docs/en-US/images/odl_structure.jpg PRE-CREATION docs/en-US/images/starting_phase.png PRE-CREATION Diff: https://reviews.apache.org/r/12999/diff/ Testing --- Built successfully with publican. Thanks, tuna
Re: Review Request 12999: [GSoC] Add mid-term report
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12999/ --- (Updated July 28, 2013, 5:38 p.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Changes --- I re-format sourcecodes inserted to report Repository: cloudstack-git Description --- I add the mid-term report for my GSoC project Diffs (updated) - docs/en-US/gsoc-midsummer-nguyen.xml 96c2de1 docs/en-US/images/l3_services.png PRE-CREATION docs/en-US/images/network_service.png PRE-CREATION docs/en-US/images/odl_structure.jpg PRE-CREATION Diff: https://reviews.apache.org/r/12999/diff/ Testing --- Built successfully with publican. Thanks, tuna
Re: Review Request 12941: [GSoC] refactor gre controller
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12941/ --- (Updated Aug. 1, 2013, 1:41 a.m.) Review request for cloudstack, Sebastien Goasguen and Hugo Trippaers. Changes --- I made an update to refactor gre controller: + fix errors on preview patch + add OvsProvider to configPhysicalNetwork phase when deploying zone + remove sdn.ovs.controller to Global Setting + fix getLabel() //also work for multiNic servers Repository: cloudstack-git Description --- I made an update to refactor gre controller: + remove ovs_devices table, because we'll have an ODL plugin separately. + move command/answer to new package: com.cloud.agent.api + add Connectivity service checking + add new NetworkProvider: Ovs + add L3 services to Ovs Capabilities + add L3 services prototype code. Next step: + L3 services implement with VirtualRouter + ODL plugin Diffs (updated) - api/src/com/cloud/network/Network.java a06208b api/src/com/cloud/network/OvsProvider.java PRE-CREATION api/src/com/cloud/network/element/VirtualRouterElementService.java ea971b8 api/src/org/apache/cloudstack/api/ResponseGenerator.java d8d07cb api/src/org/apache/cloudstack/api/command/admin/router/ConfigureOvsElementCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/command/admin/router/ListOvsElementsCmd.java PRE-CREATION api/src/org/apache/cloudstack/api/response/OvsProviderResponse.java PRE-CREATION client/tomcatconf/applicationContext.xml.in 60f1e30 client/tomcatconf/commands.properties.in 6ec4d92 engine/schema/src/com/cloud/network/dao/OvsProviderDao.java PRE-CREATION engine/schema/src/com/cloud/network/dao/OvsProviderDaoImpl.java PRE-CREATION engine/schema/src/com/cloud/network/element/OvsProviderVO.java PRE-CREATION plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 30b0521 plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateGreTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsCreateTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDeleteFlowCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyBridgeCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsDestroyTunnelCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsFetchInterfaceCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowAnswer.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetTagAndFlowCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/OvsSetupBridgeCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/agent/api/StartupOvsCommand.java PRE-CREATION plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java 0ea6b52 plugins/network-elements/ovs/src/com/cloud/network/element/OvsElementService.java b55fe6b plugins/network-elements/ovs/src/com/cloud/network/guru/OvsGuestNetworkGuru.java bbdf110 plugins/network-elements/ovs/src/com/cloud/network/ovs/OvsTunnelManagerImpl.java b1ecaac scripts/vm/hypervisor/xenserver/ovstunnel a4760b2 server/src/com/cloud/api/ApiResponseHelper.java 090d9c2 server/src/com/cloud/network/NetworkServiceImpl.java d4f9030 server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 server/src/com/cloud/server/ManagementServerImpl.java 36b3879 setup/db/create-schema.sql 143023a setup/db/db/schema-410to420.sql b48ae6a tools/apidoc/gen_toc.py 33a7e75 ui/scripts/zoneWizard.js e2ad910 Diff: https://reviews.apache.org/r/12941/diff/ Testing (updated) --- Test done with following cases: + choose GRE method, VLAN range when deploy advanced zone + create new Network Offering and choose Ovs for VirtualNetworking service, VirtualRouter for other services. + create a new Guest network using this new NetworkOffering + deploy VMs on this Guest network + stop, restart, destroy VMs + deploy, stop, restart, destroy VMs on two hosts. Thanks, tuna
[Discuss] AutoScaling.next in CloudStack
Hi guys, At CCCEU13 I talked about the AutoScale without NetScaler feature working with XenServer & XCP. For anyone don’t know about this feature, take a look into my slide here: http://www.slideshare.net/tuna20073882/autoscale-without-netscalerccceu13. Chiradeep and I had a short talk after the presentation about how to improve the AutoScale feature in future. We agreed that: + Need to remove Load Balancing feature from AutoScaling. That’s very simple to do. + Need to use SNMP for monitoring not only instance-level but also application-level. + Also, supporting well KVM hypervisor So, I blow up this thread for all of you guys to discuss the way we design that feature, such as: + technical side, how to integrate effectively SNMP into CLoudStack. Where do we put SNMP monitor components into infrastructure? etc + user experience, how user configure that feature with SNMP monitoring. I image that user can figure out they need AutoScale for which of following items: application, protocol (tcp, udp), port, bandwidth, disk, cpu and memory also, etc + How about autoscale action, not just only deploy or destroy VM, we need maybe dynamically increase-decrease memory/cpu, nic bandwidth, disk,… Personally, we should think about a completely autoscaling feature. Cheers, —Tuna
