[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2020-01-31 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-580651236
 
 
   @utchoang you can continue on it now, raise a new PR. When you do checkout 
latest master, ensure it's same as origin master by doing:
   ```
   git fetch origin master
   git checkout master
   git reset --hard origin/master
   git checkout -b 'new-branch-name for your new PR'
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2020-01-31 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-580650629
 
 
   @utchoang @svenvogel I'll squash merge this per your request, I've not 
tested it. Just checked and added license header to some files.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2020-01-29 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-580094418
 
 
   @utchoang please pick this one next, in consultation with @iceteabottle and 
@svenvogel. Let me know if you've any questions or need any help.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2020-01-16 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-575087477
 
 
   @iceteabottle - let me know if you need any assistance, kindly also merge 
latest origin/master. Thanks.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2020-01-15 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-574558526
 
 
   Ping @iceteabottle @svenvogel - any update on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2019-12-20 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-567947120
 
 
   Good to see you back commiting @iceteabottle !


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2019-11-05 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-549787456
 
 
   Hi @svenvogel in the second screenshot, the order is used to determine the 
sort order of a resource. CloudStack stores the order in `sort_key` in the 
`data_center`, `vm_template` and offerings related tables in the cloud db. This 
sort order is then used to render the sequence of items in the list API 
response by default, so whatever sort order the admin configures; the templates 
show up in the UI with that order for each tab (featured, community etc...)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2019-11-04 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-549441371
 
 
   @iceteabottle that's good idea as well, so basically show features 
templates? However, per the old CloudStack templates have a sort order so I 
don't know if that would break anything esp. in env with large number of 
templates. cc @PaulAngus @svenvogel ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2019-11-04 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-549406169
 
 
   Nice @iceteabottle - do you think instead we could have an explicit tab of 
featured templates (use the star icon), rest looks great!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [cloudstack-primate] rhtyd commented on issue #7: [WIP] Feature/vm wizard

2019-10-29 Thread GitBox
rhtyd commented on issue #7: [WIP] Feature/vm wizard
URL: https://github.com/apache/cloudstack-primate/pull/7#issuecomment-547281432
 
 
   @iceteabottle thanks for resuming this. One request from last time I tested 
your component/form, can you add the device mixin to hide the infocard on 
mobile?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services