[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-664121321 @blueorangutan package @davidjumani can you re-review this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-660986369 @davidjumani is this ready for merge? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659302592 @Pearl1594 @davidjumani @ravening @nvazquez can you help review, thnx @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163835 Can you review and test @davidjumani @Pearl1594 thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163484 @svenvogel please send a separate PR, you may want to include new keys introduced in this PR @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658657237 @utchoang can you merge latest master and fix conflicts as well, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658656367 @utchoang can you test all views you've changed, review and add missing labels for en.json. I've seen many obvious issues where instead of translation the label is seen. For example in the footer of a table it says 'label.of' instead of `of`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658033470 @utchoang can you address the review comments, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-657963737 Hi @svenvogel let us merge this and another related locales related PR and I'll ping you and advise steps to check/contribute translations (I'll email the users list as well) Can you review/test @davidjumani This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-657386668 @nvazquez @davidjumani @ravening can you help review? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-657385509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-656590256 @utchoang do let me know when this is ready for review/testing; thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-655306702 @utchoang can you merge latest master and resolve conflicts? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-654093276 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
