[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements

2020-07-20 Thread GitBox 


utchoang commented on issue #510:
URL: 
https://github.com/apache/cloudstack-primate/issues/510#issuecomment-660823292


   @rhtyd What do you think about my comment?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements

2020-07-15 Thread GitBox 


utchoang commented on issue #510:
URL: 
https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658586035


   @rhtyd Also can I use `core/lazy_use` instead of `core/use` in main.js? 
Because to avoid arising unused components.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements

2020-07-15 Thread GitBox 


utchoang commented on issue #510:
URL: 
https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116


   Currently, I have only found a few issues:
   1. In node_modules, we use package `@antv/g2`, this package is used in the 
chart.
   => Ignore package `@antv/g2` because I think Primate doesn't seem to use the 
chart.
   
   2. Ant design icons are imported entirely including icons not used in Primate
   => Only import component icons to use in Primate. Refer: 
https://stackoverflow.com/questions/48721290/ant-design-huge-imports
   
   3. In src/locales, JSON files are being imported directly, so its size is 
very large (> 2 MB)
   => There is still no better way.
   
   
![image](https://user-images.githubusercontent.com/13766648/8751-d5aa5b80-c6a0-11ea-8c47-a16082be12d6.png)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org