[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
There have been a couple issues that have been reported on `master` so I 
don't expect the RC to be cut right away as we sort out those problems.  I will 
probably merge this and we can then continue testing the other issues we have 
found.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[bvbharatk]

Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 202
 Hypervisor xenserver
 NetworkType Advanced
 Passed=73
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Great, if the RC is cut we can test that better. I'm about to leave on a 2 
week holiday however.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[bvbharatk]

Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 195
 Hypervisor xenserver
 NetworkType Advanced
 Passed=73
 Failed=0
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[bvbharatk]

Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 192
 Hypervisor xenserver
 NetworkType Advanced
 Passed=72
 Failed=1
 Skipped=3

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_vm_life_cycle.py

 * test_10_attachAndDetach_iso Failing since 3 runs


**Skipped tests:**
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[NuxRo]

Github user NuxRo commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
+1 merging, I'm also interested in this if it affects Advanced zone + 
Security Groups.
Will test ASAP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@ustcweizhou I can't wait forever on this. What I will likely do if I don't 
hear back from you is merge this and then cut the RC right away. I am hoping to 
cut the RC tomorrow, so if you can give me feedback before then I would 
appreciate it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@ustcweizhou can you review this PR please.  I think we are ready on this 
one and since it fixes issues on master I would like to get it in before I cut 
the RC.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@swill Pinging @ustcweizhou again, I know leaseweb has an interest in this. 
They use advanced zones in several different setups so their ok is a good 
indication we can merge (together with pcxtreme their ok)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@swill: Yes, LGTM from me. But @The-Loeki and I tested this together, so I 
would prefer more LGTMs, but also want this bug fixed :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@wido judging from your testing and commentary, I believe this has your 
LGTM? You have not officially specified that it does. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@swill I agree, but that's also because this bug is hitting and hurting us. 
However, I need other people to say LGTM :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
BTW, these tests results are for the following tests

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=basic \
component/test_deploy_vm_userdata_multi_nic.py \
component/test_escalations_securitygroups.py \
component/test_escalations_vpncustomergateways.py \
component/test_security_groups.py \
smoke/test_multipleips_per_nic.py \
smoke/test_portable_publicip.py \
smoke/test_routers.py

nosetests --with-marvin --marvin-config=${marvinCfg} -s -a \
component/maint/test_multiple_ip_ranges.py
```

With `${marvinCfg}` of:
`/data/shared/marvin/mct-zone1-kvm1-basic.cfg`
and
`/data/shared/marvin/mct-zone3-kvm3-basic.cfg`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
I ran the same network tests I mentioned above against master and I had the 
following results.

```
Tests Run: 24
  Skipped: 0
   Failed: 8
   Errors: 2
 Duration: 2h 35m 53s
```

All of the errors were the same on `master`, but in addition it also had a 
failure on this test:
```
FAIL: Test authorize ingress rule
--
Traceback (most recent call last):
  File 
"/data/git/cs2/cloudstack/test/integration/component/test_security_groups.py", 
line 459, in test_01_authorizeIngressRule
(self.virtual_machine.ipaddress, e)
AssertionError: SSH Access failed for 192.168.22.221: SSH connection has 
Failed. Waited 600s. Error is SSH Connection Failed
--
Additional details in: /tmp/MarvinLogs/test_routers_ZEOUOD/results.txt
```

I am not sure if this PR fixed this issue or if it is just an intermittent 
issue, but this shows that this PR did not introduce any new issues into master 
(according to these unverified tests).

Given that this fixes issues in basic networking and does not appear to 
introduce any new issues, I am inclined to add it to the 4.9 release.  

@wido, @remibergsma and @DaanHoogland do you guys agree with this decision? 
 Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Here is a run against advanced networking.

I am trying to test a bunch of basic zone networking tests, but I had never 
previously verified if they were broken.  I have run them against this PR, but 
there are a bunch of issues.  I am going to run the same set of tests against 
master to see if there is a difference in the results.

Unverified tests run against this PR.  Doing the same against master now...
```
Tests Run: 24
  Skipped: 0
   Failed: 7
   Errors: 2
 Duration: 2h 21m 30s
```
(details masked intentionally as this set of tests is unverified)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 00m 38s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/DeployDataCenter__Jun_09_2016_06_44_20_ETRLGB/runinfo.txt)

**`/tmp/MarvinLogs/test_network_N3C2B9:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_network_N3C2B9/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_network_N3C2B9/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_network_N3C2B9/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_7OVU64:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_vpc_routers_7OVU64/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_vpc_routers_7OVU64/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547-3/tmp/MarvinLogs/test_vpc_routers_7OVU64/runinfo.txt)


Uploads will be available until `2016-08-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Should this set of test have the "basic" tag?  It only has the "sg" tag, 
which I am not targeting.


`/Users/swill/Dropbox/code/cs/cloudstack/test/integration/component/maint/test_multiple_ip_ranges.py`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Thanks for the feedback @remibergsma and @swill !

Hopefully the results come back positive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
The tests run against basic networking hardly test the functionality of the 
network though.  Apparently most of the tests for the network are only for 
advanced networking.

I will run against advanced networking again now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[remibergsma]

Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Can you also run one against advanced please @swill?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
The above is a test against basic networking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  


### CI RESULTS

```
Tests Run: 22
  Skipped: 1
   Failed: 0
   Errors: 0
 Duration: 0h 32m 39s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/DeployDataCenter__Jun_08_2016_20_33_02_GR1LJ1/runinfo.txt)

**`/tmp/MarvinLogs/test_service_offerings_U496F9:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_service_offerings_U496F9/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_service_offerings_U496F9/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_service_offerings_U496F9/runinfo.txt)

**`/tmp/MarvinLogs/test_ssvm_WVHYBZ:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_ssvm_WVHYBZ/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_ssvm_WVHYBZ/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1547/tmp/MarvinLogs/test_ssvm_WVHYBZ/runinfo.txt)


Uploads will be available until `2016-08-08 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[remibergsma]

Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@wido FYI all Python code is shared between basic/advanced and router/vpc 
so it's important to test both. Will try to look into it again in the next 
days. Not saying it's broken, just want to be careful. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@remi: Thanks for the feedback! @DaanHoogland reported a failure as well, 
but his second test succeeded without any problems.

I don't have experience with VPC, but as far as I can tell this PR does not 
touch any VPC code.

In Daan's original results the 
'test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL' test  went fine.

``Create a redundant VPC with two networks with two VMs in each network ... 
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : 
SUCCESS ===
ok``



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[remibergsma]

Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
I see some tests failing on VPCs:
```
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
test_02_redundant_VPC_default_routes
```

Will rebuild from scratch to see if it fails again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Ok, thanks @DaanHoogland , sounds good!

Looking forward to more input or LGTMs :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Yes @wido ,they look good to me but I am not running a cloud at the moment 
so hence I asked @ustcweizhou to have a look.
He had concerns but I did not see him react since.
The test I did were in advanced zone so we do have a rather broad coverage 
so far.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Thanks @DaanHoogland for the tests! So it seems that the code looks OK to 
you?

I just force pushed so Travis should trigger again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
CI Results: ok one test failed but retest manually succeeded


[1547.results.network.txt](https://github.com/apache/cloudstack/files/300726/1547.results.network.txt)

[1547.results.vpc_routers.txt](https://github.com/apache/cloudstack/files/300727/1547.results.vpc_routers.txt)

@ustcweizhou can you re-review?
@The-Loeki one travis run failed during install though the others 
succeeded. Maybe you can re-open to try your luck.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
Awesome @DaanHoogland ! As said, this is a problem currently on 4.8 when 
using multiple ranges inside a pod VLAN.

I/we can't find any issues with the changes made by @The-Loeki , so 
additional input is welcome.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@wido, I am not in favour of squashing these. They seem to be different 
fixes with their own history. I will start an integration run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
@swill: Before we start squashing all these commits can we get a CI run on 
this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1547: Fixes for VirtualRouters in Basic Networking, especi...

[wido]

Github user wido commented on the issue:

https://github.com/apache/cloudstack/pull/1547
  
I spend some more time testing this. After the latest commits from 
@The-Loeki it all seems to work:

* Virtual Router listens on all addresses
* Apache is configured properly
* DHCP is answered correctly by the VR

The IPs are configured properly inside the VR:


root@r-10-VM:~# ip a
1: lo:  mtu 16436 qdisc noqueue state UNKNOWN 
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
2: eth0:  mtu 1500 qdisc pfifo_fast state 
UP qlen 1000
link/ether 06:ee:34:00:00:85 brd ff:ff:ff:ff:ff:ff
inet 109.XX.YY.248/26 brd 109.XX.YY.255 scope global eth0
inet 109.XX.YY.149/28 brd 109.XX.YY.159 scope global eth0
inet 31.XX.YY.133/26 brd 31.XX.YY.191 scope global eth0
3: eth1:  mtu 1500 qdisc pfifo_fast state 
UP qlen 1000
link/ether 0e:00:a9:fe:00:5f brd ff:ff:ff:ff:ff:ff
inet 169.254.0.95/16 brd 169.254.255.255 scope global eth1
root@r-10-VM:~#


Apache is also working properly on both the VR and the SecStore VM:

root@r-10-VM:~# ls -l /etc/apache2/sites-enabled/
total 30
-rwxr-xr-x 1 root root 10230 Jun  2 13:40 vhost-109.XX.YY.248.conf
-rwxr-xr-x 1 root root 10230 Jun  2 13:40 vhost-109.XX.YY.149.conf
-rwxr-xr-x 1 root root 10230 Jun  2 13:40 vhost-31.XX.YY.133.conf
root@r-10-VM:~# apache2ctl configtest
apache2: apr_sockaddr_info_get() failed for r-10-VM
apache2: Could not reliably determine the server's fully qualified domain 
name, using 127.0.0.1 for ServerName
Syntax OK
root@r-10-VM:~# 

root@s-214-VM:~# ls -l /etc/apache2/sites-enabled/
total 10
lrwxrwxrwx 1 root root26 Nov  9  2015 000-default -> 
../sites-available/default
-rw-r--r-- 1 root root 10206 Jun  2 13:35 vhost-109.XX.YY.206.conf
root@s-214-VM:~# apache2ctl configtest
apache2: Could not reliably determine the server's fully qualified domain 
name, using 109.XX.YY.206 for ServerName
Syntax OK
root@s-214-VM:~#

Instances are also able to gather their metadata with cloud-init:

```
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET 
//latest/meta-data/instance-id HTTP/1.1" 200 240 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/user-data HTTP/1.1" 
200 202 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/meta-data/ HTTP/1.1" 
200 341 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/meta-data/local-ipv4 
HTTP/1.1" 200 216 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET 
/latest/meta-data/local-hostname HTTP/1.1" 200 221 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET 
/latest/meta-data/public-hostname HTTP/1.1" 200 221 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/meta-data/public-keys 
HTTP/1.1" 200 202 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET 
/latest/meta-data/cloud-identifier HTTP/1.1" 200 253 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET 
/latest/meta-data/service-offering HTTP/1.1" 200 225 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/meta-data/public-ipv4 
HTTP/1.1" 200 216 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/meta-data/vm-id 
HTTP/1.1" 200 240 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET 
/latest/meta-data/availability-zone HTTP/1.1" 200 215 "-" "Cloud-Init/0.7.5"
1.2.3.4 - - [02/Jun/2016:13:45:15 +] "GET /latest/meta-data/instance-id 
HTTP/1.1" 200 240 "-" "Cloud-Init/0.7.5"
```

The Instance also reports this:

Cloud-init v. 0.7.5 finished at Thu, 02 Jun 2016 13:46:08 +. 
Datasource DataSourceCloudStack.  Up 62.06 seconds

As far as I can test it is all working. The commits in the PR need to be 
squashed, but to me it looks good.

I consider this PR a **BLOCKER** for 4.9 though.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---