[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1593 ### ACS CI BVT Run **Sumarry:** Build Number 412 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder (search by build_no):_ https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0 **Failed tests:** * test_non_contigiousvlan.py * test_extendPhysicalNetworkVlan Failed **Skipped tests:** test_01_test_vm_volume_snapshot test_vm_nic_adapter_vmxnet3 test_static_role_account_acls test_11_ss_nfs_version_on_ssvm test_nested_virtualization_vmware test_3d_gpu_support test_deploy_vgpu_enabled_vm **Passed test suits:** test_deploy_vm_with_userdata.py test_affinity_groups_projects.py test_portable_publicip.py test_over_provisioning.py test_global_settings.py test_scale_vm.py test_service_offerings.py test_routers_iptables_default_policy.py test_loadbalance.py test_routers.py test_reset_vm_on_reboot.py test_deploy_vms_with_varied_deploymentplanners.py test_network.py test_router_dns.py test_login.py test_deploy_vm_iso.py test_list_ids_parameter.py test_public_ip_range.py test_multipleips_per_nic.py test_regions.py test_affinity_groups.py test_network_acl.py test_pvlan.py test_volumes.py test_nic.py test_deploy_vm_root_resize.py test_resource_detail.py test_secondary_storage.py test_vm_life_cycle.py test_routers_network_ops.py test_disk_offerings.py --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 Packaging result: âcentos6 âcentos7 âdebian. JID-211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @nvazquez @jburwell @serg38 @rafaelweingartner ping @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 I have this PR on a list to re-review. In my view, using a global setting for this value is whole inappropriate. I have been busy with other items, and haven't had a chance to get back around to it. I plan to get it to it in the next day or two. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 giving your explanations I am ok with your proposal. Just one addendum, I think we should document it as much as possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rafaelweingartner @rhtyd Do we make any decision on this? The scope of this PR was very limited initially. It would be much easier if we don't expand it too far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rafaelweingartner In usage_evant_details there will be never details with event_id=0 so there will be no conflict ever if we do it this way. Based on the code there are some details e.g. CPU speed that might be saved to details table at some point but they are always tied to respective event_id which is greater then 0 for normal events. Event id=0 can be considered system and generated by Sanity job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1593 I understand why you want to use something that already exists, instead of creating a new table/DAO/service class. Isnât this table (event_details) used for anything else? If it is something that is already out there and is not being used, I have nothing against using it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@rhtyd @jburwell @rafaelweingartner Can we use event_details table which
is not used at the moment? if we consider sanity job to generate event_id=0
then max_id can be easily represented there as ("id","0","max_id","value")
Alternatively a new table would require new DAO isn't it? Seems to be huge
scope creep for such a minor fix as permission issue. Can we just merge it as
it is and open another PR for the extended scope?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 since we don't have a general key/value store table, we may need to create a new table in `cloud_usage` db. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell @rhtyd What are your ideas on where in DB to store it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell Creating a new table to hold one setting seems to be excessive. How about using sequence table? In this regard last_Id used by usage sanity checker is a sequence. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 I completely agree that it should be in the database, but it's not a configuration setting. Furthermore, it requires a different transactional behavior to operate properly. Therefore, it should be placed in a separate tracking table -- either a new table or as a column on an existing table. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell @rafaelweingartner I agree with @rhtyd to move sanity checker last_id to the DB. No reason to keep in in file system. How about using "usage.sanity.check.lastid in configuration table with the following attributes Category: Hidden component : management-server default value: 0 isdynamic: 0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 LGTM with smoke testing. RHEL 6 management servers, advanced networking, Vmware 5.5 .and 6 hypervisors [root@ussarlabcsmgt41 smoke]# cat /tmp//MarvinLogs/test_volumes_340FH1/results.txt|grep -v ok test DeployVM in anti-affinity groups for project ... === TestName: test_DeployVmAntiAffinityGroup_in_project | Status : SUCCESS === test DeployVM in anti-affinity groups ... === TestName: test_DeployVmAntiAffinityGroup | Status : SUCCESS === Test Deploy Virtual Machine ... SKIP: Skipping test because suitable hypervisor/host notpresent Test Deploy Virtual Machine from ISO ... === TestName: test_deploy_vm_from_iso | Status : SUCCESS === Test deploy virtual machine with root resize ... === TestName: test_00_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize of 0 ... === TestName: test_01_deploy_vm_root_resize | Status : SUCCESS === Test proper failure to deploy virtual machine with rootdisksize less than template size ... === TestName: test_02_deploy_vm_root_resize | Status : SUCCESS === Test to deploy vm with a first fit offering ... === TestName: test_deployvm_firstfit | Status : SUCCESS === Test deploy VMs using user concentrated planner ... === TestName: test_deployvm_userconcentrated | Status : SUCCESS === Test deploy VMs using user dispersion planner ... === TestName: test_deployvm_userdispersing | Status : SUCCESS === Test userdata as GET, size > 2k ... === TestName: test_deployvm_userdata | Status : SUCCESS === Test userdata as POST, size > 2k ... === TestName: test_deployvm_userdata_post | Status : SUCCESS === Test to create disk offering ... === TestName: test_01_create_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_02_create_sparse_type_disk_offering | Status : SUCCESS === Test to create a sparse type disk offering ... === TestName: test_04_create_fat_type_disk_offering | Status : SUCCESS === Test to update existing disk offering ... === TestName: test_02_edit_disk_offering | Status : SUCCESS === Test to delete disk offering ... === TestName: test_03_delete_disk_offering | Status : SUCCESS === Test to ensure 4 default roles cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to check role, role permissions and account life cycles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test for role-rule enforcement in case of multiple mgmt servers ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Test to ensure role in use cannot be deleted ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests normal lifecycle operations for roles ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests that default four roles exist ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests role update when role is in use by an account ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests concurrent order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests creation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests deletion of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests listing of default role's permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test Tests order updation of role permission ... SKIP: Dynamic Role-Based API checker not enabled, skipping test test update configuration setting at zone level scope ... === TestName: test_UpdateConfigParamWithScope | Status : SUCCESS === Test guest vlan range dedication ... === TestName: test_dedicateGuestVlanRange | Status : SUCCESS === Test create public & private ISO ... === TestName: test_01_create_iso | Status : SUCCESS === Test Edit ISO ... === TestName: test_02_edit_iso | Status : SUCCESS === Test delete ISO ... === TestName: test_03_delete_iso | Status : SUCCESS === Test for extract ISO ... === TestName: test_04_extract_Iso | Status : SUCCESS === Update & Test for ISO permissions ... === TestName: test_05_iso_permissions | Status : SUCCESS === Test for copy ISO from one zone to another ... SKIP: Not enough zones available to perform copy template Test delete ISO ... === TestName: test_07_list_default_iso | Status : SUCCESS === Test listing Volumes using 'ids' parameter ... === TestName: test_01_list_volumes | Status : SUCCESS === Test listing Templat
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @abhinandanprateek do you have time to test this PR when upgrading a a clustered usage server environment from 4.9 to master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell Sure, they are squashed now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd Confirming. No issues on usage and management servers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 sorry the `test` keyword is restricted to RMs and few other people for now. There are failure that causes initial setup to fail. Can you confirm if this (mgmt server and usage server) work in your env with the above packages? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @nvazquez could you please squash your commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 @karuturi a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests against packages at http://packages.shapeblue.com/cloudstack/pr/1593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user karuturi commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 we require Marvin test results and, as well as, the results of any manual tests to be posted into the PR. This information is a pre-requisite for merging PRs. Please see other closed PRs for examples of test result reporting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell LGTM for the test part. This PR was extensively tested on Environment: RHEL 6 management servers, Vmware ESX5.5 and 6.0 with advanced networking --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 I only see code review LGTMs. We need at least one test LGTM before this PR. In this case, those tests must be run against real hardware and hypervisors. Also, we need an LGTM from all reviewers that raised an issue. I haven't had a chance tore-review as I am on leave this week. (All PRs require at least one code review and at least test LGTM to be merged). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @karuturi @jburwell There are 2 LGTM in this PR. Packaging, Travis and Jenkins all passed. Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1593 Job ID #65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 Packaging result: âcentos6 âcentos7 âdebian repo: http://packages.shapeblue.com/cloudstack/pr/1593 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd a Trillian-Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1593 Thanks @jburwell for your review! About your first question, as @serg38 said file will be created on sanity check run if it didn't exist, and then it would just update it. About your second question, it would be nice that it can be included on 4.9 but I think it will be deferred to 4.10. I just targeted it to 4.9 as it was current version without realizing about 4.9 freeze. Actually I tried updating JIRA ticket to 4.10 but it doesn't exist. Should I leave version fields blank? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell If no sanity-check-last-id is present it will run Sanity on the whole cloud_usage data set and then create a new sanity-check-last-id file. The whole part of sanity checking related to sanity-check-last-id has been broken for a while since the part to update sanity-check-last-id wasn't in the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @swill I noticed that the associated JIRA ticket was opened after the 4.9.0 freeze, but is targeted against 4.9.0. Should it be included in 4.9 or deferred to 4.10? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @nvazquez when users upgrade existing usage servers, will the location change of the ```sanity-check-last-id``` file impact their operation? /cc @abhinandanprateek --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1593 Thanks @wido! I refactored debian packaging and added fedora21's `cloud.spec` file --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring
Github user wido commented on the issue: https://github.com/apache/cloudstack/pull/1593 Packaging changes seem good to me. Java changes as well. Based on the code this is LGTM to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
