[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1701 Packaging result: âcentos6 âcentos7 âdebian. JID-117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 Since this is a pure UI change, merging based on manual test LGTMs and code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd LGTM on code review...add more such admin UI stuff that admin end up using manually --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 Is this good to merge, purely UI change? /cc @murali-reddy @abhinandanprateek @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 @koushik-das I actually have appended the two translated messages in the conditional, as destroy router would stop the VR first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 LGTM. Small comment on the message for running VR. "Please confirm... " is appearing twice, only one would suffice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 @koushik-das alright I've fixed the message. It shows as follows: 1. When router is in running state:  2. When router is in stopped state:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 @koushik-das I'll see if I can add a conditional in the pop-up :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd You are right, the message only makes sense for destroying running VR. So some conditional check needs to be there for displaying the proper message. Based on the discussion it appears that may be destroy option was intentionally not shown earlier to avoid the effort of showing conditional messages :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 @koushik-das this is available/shown only to the admin, can we assume admin would know that it may cause network disruption for guest vms? The translation can be fixed, though in case the VR is stopped -- the message won't make sense when destroy router action is performed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 Since services are disrupted when VR is destroyed, I think it would be useful to provide a message similar to stop VR. Earlier only destroying a stopped VR was possible from UI so caller was already aware. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 @koushik-das it'll display whatever message is currently displayed for destroy router action, which is not same as stop router action:  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd Will destroy router show a similar message as stop router in UI? All services provided by this virtual router will be interrupted. Please confirm that you want to stop this router. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1701 Packaging result: âcentos6 âcentos7 âdebian. JID-53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1701 Ignore centos6 failure, it succeeded but something went wrong at the backend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1701 Packaging result: âcentos6 âcentos7 âdebian. JID-52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1701 Packaging result: âcentos6 âcentos7 âdebian. JID-51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1701: CLOUDSTACK-9534: Allow VR to be destroy in UI when i...
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1701 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
