[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue:

https://github.com/apache/cloudstack/pull/1933
  
LGTM. @abhinandanprateek is this PR different or is a subset of 
https://github.com/apache/cloudstack/pull/1856


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

2017-02-10 Thread borisstoyanov
Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1933
  
Testing has PASSED
There's a way to override the hardcoded timeout of 10 mins now by setting 
the "router.aggregation.command.each.timeout" in the 
"/etc/cloudstack/agent/agent.properties" file.
Testing steps:
Set the router.aggregation.command.each.timeout=1
Added a sleep of 15 seconds in the router_proxy.sh
Restarted the agent 
Started a new VM with a new network
In the log the following observations were noted:

```
2017-01-20 12:04:05,787 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-2:null) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.3.57 -c /var/cache/cloud/VR-a20603a7-8e10-4378-96bb-7a2dbc7c6c0b.cfg
2017-01-20 12:04:06,792 WARN  [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-2:null) Timed out: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.3.57 -c /var/cache/cloud/VR-a20603a7-8e10-4378-96bb-7a2dbc7c6c0b.cfg .  
Output is:
2017-01-20 12:05:20,419 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.0.41 -c /var/cache/cloud/VR-090cae6a-f07d-40bb-9f19-809ccdcca16b.cfg
2017-01-20 12:05:21,423 WARN  [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Timed out: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.0.41 -c /var/cache/cloud/VR-090cae6a-f07d-40bb-9f19-809ccdcca16b.cfg .  
Output is:
2017-01-20 12:06:33,620 DEBUG [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Executing: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.2.33 -c /var/cache/cloud/VR-63f52dbd-b710-4e57-a21b-1f4bcd146ec3.cfg
2017-01-20 12:06:34,624 WARN  [kvm.resource.LibvirtComputingResource] 
(agentRequest-Handler-1:null) Timed out: 
/usr/share/cloudstack-common/scripts/network/domr/router_proxy.sh vr_cfg.sh 
169.254.2.33 -c /var/cache/cloud/VR-63f52dbd-b710-4e57-a21b-1f4bcd146ec3.cfg .  
Output is:
```

VR Failed to start with a Message "Unable to start a VM due to insufficient 
capacity" 
I think we could add a log message saying that it timed out in the agent 
log, because now it does not leave any clue where the time out is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

2017-02-09 Thread koushik-das
Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1933
  
@abhinandanprateek Looks like there is another PR #1856 related to this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---