[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1972 @SudharmaJain Can you please check new PR for this issue. Also, I have implemented the changes which you have suggested. PR link : #1978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user niteshsarda commented on the issue: https://github.com/apache/cloudstack/pull/1972 @ustcweizhou : Can you please check new PR for this issue and provide LGTM on that PR. PR link : https://github.com/apache/cloudstack/pull/1978 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user SudharmaJain commented on the issue: https://github.com/apache/cloudstack/pull/1972 @niteshsarda I don't see any change in file createNetworkOffering.xml, but still there are many lines being removed and added. As there is not change in this file, please revert. Also the marvin test case seems as the complete file was edited, even the license header. Please add only the changes that are relevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack issue #1972: CLOUDSTACK-9779 : Releasing secondary guest IP fails...
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1972 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
