[GitHub] cloudstack pull request: [4.7] VMware boot order fix
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1395#issuecomment-182489462 Figured it is not needed, closing for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] VMware boot order fix
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/1395 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] VMware boot order fix
Github user PaulAngus commented on the pull request: https://github.com/apache/cloudstack/pull/1395#issuecomment-180581817 I believe Abhi is going to be looking at Marvin soon. We could maybe consider using the vmware python libraries (https://github.com/vmware/pyvmomi) when using Marvin to test vSphere specific code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] VMware boot order fix
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1395#issuecomment-180484419 @DaanHoogland thanks Daan, this particular fix needs to be checked on both cloudstack and vcenter side so I'm not sure if a marvin tests exists or would be easy to write. It might be the case that this fix is not necessary (had sent an email on dev@ seeking advise on this), I'm waiting for other vmware devs who can advise or review -- otherwise we can close this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] VMware boot order fix
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1395#issuecomment-178709268 looks good, I cannot test this. Can you create a marvin test (or point one out) for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: [4.7] VMware boot order fix
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/1395 [4.7] VMware boot order fix In case of VMware, since root disk needs to be first in the hdd boot order, we collect list of hdds and create a hdd boot order with the root disk as the first disk. This fixes a rare edge case where VMs would stop booting due to changed boot order in hdds. For sanity, we want cdroms to boot first, then hdds, floppies etc. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack 4.7-vmware-boot-order Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1395.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1395 commit 2e01b37af4404db2c26deaaba9e6bf74c8381b0a Author: Rohit Yadav Date: 2016-01-29T16:30:51Z vmware: specify hdd boot order based on disk device bus name In case of VMware, since root disk needs to be first in the hdd boot order, we collect list of hdds and create a hdd boot order with the root disk as the first disk. This fixes a rare edge case where VMs would stop booting due to changed boot order in hdds. For sanity, we want cdroms to boot first, then hdds, floppies etc. Signed-off-by: Rohit Yadav --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
