[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1286#issuecomment-168128474 It seems in latest releases bug is already fixed with commit for bug https://issues.apache.org/jira/browse/CLOUDSTACK-8484 so closing PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1286#issuecomment-168010821 What is the best way to test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 closed the pull request at: https://github.com/apache/cloudstack/pull/1283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167095249 Closing this PR, Created new PR against 4.6 https://github.com/apache/cloudstack/pull/1286. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1286 CLOUDSTACK-4572: findHostsForMigration API does not return correct host list https://issues.apache.org/jira/browse/CLOUDSTACK-4572 Fix is missing in recent releases. The api should return the list of suitable/unsuitable hosts Added fix that creates a deep copy of the the variable allHosts and prevents faulty host list return. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-4572-4.6 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1286 commit 7c86ff6af1c04c4709a0a1e8df14b598e5a67e20 Author: Saksham Srivastava Date: 2013-08-30T19:30:41Z CLOUDSTACK-4572: findHostsForMigration API does not return correct host list Changes: Expected behavior: The api should return the list of suitable/unsuitable hosts Added fix that creates a deep copy of the the variable allHosts and prevents faulty host list return. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167094061 yes, and that would mean that we need to run the regression suite against it twice. I am satisfied with it for now, but want to see testing. better to run that against the version we will merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167088134 Can we have review on this PR and when everybody is satisfied then create PR for 4.6? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167079071 I would like it to be a PR to 4.6 and be forward merged to 4.7 and master, instead of being applied on master. ping @remibergsma @wilderrodrigues @borisroman @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167078298 Yes, It is missing in all releases. It can be backported to 4.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167068940 @anshul1886 (ignoring my usual remarks in testing) isn't this for 4.6 and to be merged forward then? It must be missing in all releases in between, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167046667 @koushik-das It was merged to 4.2-forward but was not merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1283#issuecomment-167045587 @anshul1886 If the fix was added in 4.2, why it got missed out? Can you check the history and update? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-4572: findHostsForMigration AP...
GitHub user anshul1886 opened a pull request: https://github.com/apache/cloudstack/pull/1283 CLOUDSTACK-4572: findHostsForMigration API does not return correct host list https://issues.apache.org/jira/browse/CLOUDSTACK-4572 Fix is missing in recent releases. The api should return the list of suitable/unsuitable hosts Added fix that creates a deep copy of the the variable allHosts and prevents faulty host list return. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-4572 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1283.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1283 commit 2cea4d42510230a61c2858ce5789b199cbc6398b Author: Saksham Srivastava Date: 2013-08-30T19:30:41Z CLOUDSTACK-4572: findHostsForMigration API does not return correct host list Changes: Expected behavior: The api should return the list of suitable/unsuitable hosts Added fix that creates a deep copy of the the variable allHosts and prevents faulty host list return. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
