[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/63#issuecomment-69900395
Tested with CloudMonkey/Marvin, most sane clients should not break who
search for objects in a xyzresponse key. This also fixes the UI so we're good.
Google search resulted 8 places where deleteisosresponse was used. Such
fixes have been done in the past. The impact is low, also because it's an async
api.
Response before;
{ deleteisosresponse : {jobid:aef086a9-ceb6-4af1-9b01-44a130dc6a16} }
Response after the fix;
{ deleteisoresponse : {jobid:0fd02b7f-0a14-4ef2-8dc5-932a9ee30004} }
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69761365 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/63 CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's' Signed-off-by: René Moser m...@renemoser.net You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack fix/deleteisoapi Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit c7ebd13d02948fd2ca2d6e4245127e01a2f7579e Author: René Moser m...@renemoser.net Date: 2015-01-13T15:23:31Z CLOUDSTACK-8154: Fix typo in response name string: there is an extra 's' Signed-off-by: René Moser m...@renemoser.net --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69761669 Since, this is an API related change I'm hesitant to merge into master without a discussion around this on dev ML. Can you start a thread on dev ML to discuss fixing typos in the command response key-name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
Github user runseb commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69767205 I am +1 with this, looks like a typo. definitely good for master. maybe other bug fix releases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8154: Fix typo in response nam...
Github user nitmehta commented on the pull request: https://github.com/apache/cloudstack/pull/63#issuecomment-69821830 Does this break backward compatibility ? How is this string used ? Can you please post the old and new response for this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
