[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120883355 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120897166 Thanks both, I pushed another UI change. Please see it too. This change allows admins to say if they want usernames with a domain (extracted from the IDP server). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-121131795 Squashing and merging commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab closed the pull request at: https://github.com/apache/cloudstack/pull/575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120803952 @abhinandanprateek @jburwell @wilderrodrigues ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120815287 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120254575 Hi @bhaisaab Code looks good and screenshot as well. :+1: Hints to test it manually? After hitting the check-box, what should I do? Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120389991 @wilderrodrigues thanks. You can select the authorise sso checkbox and submit if you've a SAML IDP server. For test setup, you can follow this: https://cwiki.apache.org/confluence/display/CLOUDSTACK/SAML+2.0+Plugin#SAML2.0Plugin-Testing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120391833 on Chrome, dev tools if you set g_idpList to null, you should see the saml stuff in the form. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack/pull/575 CLOUDSTACK-8457: Add option to authorize SAML SSO for user when adding user With SAML enabled, add user view shows option to authorize SAML SSO for a user. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/cloudstack saml-adduserfix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/575.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #575 commit c1c67f313a2ba08022b647baa0ca65f134c062c1 Author: Rohit Yadav rohit.ya...@shapeblue.com Date: 2015-07-09T20:56:51Z CLOUDSTACK-8457: Add option to authorize SAML SSO for user when adding user Signed-off-by: Rohit Yadav rohit.ya...@shapeblue.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8457: Add option to authorize ...
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/575#issuecomment-120149819 Screenshot: ![screen shot 2015-07-10 at 2 52 18 am](https://cloud.githubusercontent.com/assets/95203/8607376/133e31a6-26b0-11e5-870d-3bacdb5b1507.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---