[GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
Github user pritisarap12 closed the pull request at: https://github.com/apache/cloudstack/pull/480 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
Github user gauravaradhye commented on the pull request: https://github.com/apache/cloudstack/pull/480#issuecomment-114025746 Please close this review request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
Agree with Gaurav, We should look at the tests which are changing the storage pool status. We should make sure that those tests turn the status back to UP. -Sanjeev On Fri, Jun 19, 2015 at 1:05 PM, gauravaradhye wrote: > Github user gauravaradhye commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/480#discussion_r32807101 > > --- Diff: test/integration/testpaths/testpath_vmlc.py --- > @@ -176,6 +176,19 @@ def setUpClass(cls): > cls.zone = get_zone(cls.apiclient) > cls._cleanup = [] > > +cls.skiptest = False > --- End diff -- > > There is no need for these checks. Instead the tests which leave the > storage pool in disabled state should be looked at. Hold it for now. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
[GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/480#discussion_r32807101 --- Diff: test/integration/testpaths/testpath_vmlc.py --- @@ -176,6 +176,19 @@ def setUpClass(cls): cls.zone = get_zone(cls.apiclient) cls._cleanup = [] +cls.skiptest = False --- End diff -- There is no need for these checks. Instead the tests which leave the storage pool in disabled state should be looked at. Hold it for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
Github user pritisarap12 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/480#discussion_r32804688 --- Diff: test/integration/testpaths/testpath_vmlc.py --- @@ -176,6 +176,19 @@ def setUpClass(cls): cls.zone = get_zone(cls.apiclient) cls._cleanup = [] +cls.skiptest = False --- End diff -- This test does not require any special storage pool or with any tags. This check was put since it did not find any storage pool in UP state.i.e storage pool was present but was not in UP state. So should I remove the check for skipTest? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
Github user gauravaradhye commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/480#discussion_r32713595 --- Diff: test/integration/testpaths/testpath_vmlc.py --- @@ -176,6 +176,19 @@ def setUpClass(cls): cls.zone = get_zone(cls.apiclient) cls._cleanup = [] +cls.skiptest = False --- End diff -- Does this test require any special storage pool? or with any tags? If not, there is no reason to add this check as it is expected that storage pool is present in setup. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] cloudstack pull request: CLOUDSTACK-8572:Unable to deploy VM as no...
GitHub user pritisarap12 opened a pull request: https://github.com/apache/cloudstack/pull/480 CLOUDSTACK-8572:Unable to deploy VM as no storage pool found in UP state You can merge this pull request into a Git repository by running: $ git pull https://github.com/pritisarap12/cloudstack shivani Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/480.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #480 commit b3dab6031adbcb5f08b75e2ccb44874cf0ee688b Author: pritisarap12 Date: 2015-06-18T08:40:40Z CLOUDSTACK-8572:Unable to deploy VM as no storage pool found in UP state --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
